Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX

2020-02-20 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Friday, February 21, 2020 9:38 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Raslan Darawsheh ; Thomas Monjalon > ; ferruh.yi...@intel.com > Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX > > > > From: Viacheslav Ovsi

Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX

2020-02-20 Thread Matan Azrad
From: Viacheslav Ovsiienko > This patch does extra inline packet size check to tune the ConnectX-4LX > performance in the legacy Multi-Packet Write mode. > > Signed-off-by: Viacheslav Ovsiienko Slava, Don't you think we want it for stable releases? Besides it: Acked-by: Matan Azrad > driv

[dpdk-dev] Facing issue with mellanox after increasing number of buffers

2020-02-20 Thread chetan bhasin
Hi, We are using DPDK underneath VPP . We are facing issue when we increase buffers from 100k to 300k after upgrading vpp version (18.01--> 19.08). As per log following error is seen net_mlx5: port %u unable to find virtually contiguous chunk for address (%p). rte_memseg_contig_walk() failed.\n%.0

[dpdk-dev] [crypto][compress][discussion] Add crypto and compress PMD for KAE (Kunpeng Accelerator Engine)

2020-02-20 Thread Yikun Jiang
We propose to add the crypto and compress PMD for KAE (Kunpeng Accelerator Engine). Kunpeng Accelerator Engine is a technology to enhance security and compression performance for Huawei Kunpeng series processor, you could see [1] as reference (OpenSSL and zlib enhancement have been supported). In

Re: [dpdk-dev] [PATCH v3] examples/tep_term: remove redundant info get

2020-02-20 Thread Ye Xiaolong
On 02/20, David Marchand wrote: >On Mon, Feb 17, 2020 at 2:41 AM Xiaoyun Li wrote: >> >> Removed redundant function call of 'rte_eth_dev_info_get()' since it has >> already been called earlier. >> >> Coverity issue: 349922 >> Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration")

[dpdk-dev] [PATCH v3 2/3] devtools: allow test-null.sh to run on ppc64le

2020-02-20 Thread David Wilder
Memory requirements are larger for ppc64le due to a higher RTE_MAX_LCORE value. Signed-off-by: David Wilder Reviewed-by: David Christensen --- devtools/test-null.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/test-null.sh b/devtools/test-null.sh index 548de8113.

[dpdk-dev] [PATCH v3 0/3] add travis ci support for ppc64le

2020-02-20 Thread David Wilder
This patch series adds Travis gcc compilation jobs for ppc64le. Limitations for ppc64le are similar to arm64 (see commit 31bb45bcfd). 1. Only gcc builds are supported on ppc64le. 2. A container is used, therefor Huge pages are not available. Unit tests are not run, a single test (test-null) us

[dpdk-dev] [PATCH v3 1/3] eal/linux: select iova-mode va with no-huge option

2020-02-20 Thread David Wilder
If --no-huge is set and iova-mode has not been specified force VA mode. If --no-huge and --iova-mode=PA is requested error out as this is an impossible configuration. Signed-off-by: David Wilder --- lib/librte_eal/linux/eal/eal.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[dpdk-dev] [PATCH v3 3/3] ci: add travis ci support for native ppc64le

2020-02-20 Thread David Wilder
This change follows the example of aarch64 Travis support by adding support for ppc64le gcc builds. Limitations for ppc64le are the same as aarch64 as described in: commit 31bb45bcfdf5 ("ci: add travis ci support for native aarch64"). Signed-off-by: David Wilder Reviewed-by: David Christensen -

Re: [dpdk-dev] [PATCH] build: fix experimental library versioning

2020-02-20 Thread Luca Boccassi
On Thu, 2020-02-20 at 19:54 +, Ferruh Yigit wrote: > The problem occurred when workaround that makes soname two digits > applied. With this change for the ABI version "20.0.1" the > experimental > library version become ".so.2001". > After workaround removed in ABI version 21.0, the experimenta

Re: [dpdk-dev] [EXTERNAL] [PATCH] kernel: remove unused directory for Windows

2020-02-20 Thread Narcisa Ana Maria Vasile
On 2/17/2020 8:58 AM, Thomas Monjalon wrote: > The netuio driver will be hosted in a separate repository: > > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.dpdk.org%2Fdpdk-kmods%2F&data=02%7C01%7CNarcisa.Vasile%40microsoft.com%7Cdd318aa4159444af328308d7b3caa6c8%7C72f98

Re: [dpdk-dev] [PATCH] build: add combined libs

2020-02-20 Thread Luca Boccassi
On Thu, 2020-02-20 at 13:35 -0800, Ruslan Babayev wrote: > Hi Luca, > > PkgConfig doesn't cover the case of static linking. See below: > > $ pkg-config --libs libdpdk > -lrte_bpf -lrte_flow_classify -lrte_pipeline -lrte_table -lrte_port > -lrte_fib -lrte_ipsec -lrte_vhost -lrte_stack -lrte_securi

Re: [dpdk-dev] [PATCH] build: add combined libs

2020-02-20 Thread Ruslan Babayev
Hi Luca, PkgConfig doesn't cover the case of static linking. See below: $ pkg-config --libs libdpdk -lrte_bpf -lrte_flow_classify -lrte_pipeline -lrte_table -lrte_port -lrte_fib -lrte_ipsec -lrte_vhost -lrte_stack -lrte_security -lrte_sched -lrte_reorder -lrte_rib -lrte_rcu -lrte_rawdev -lrte_pdu

[dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX

2020-02-20 Thread Viacheslav Ovsiienko
This patch does extra inline packet size check to tune the ConnectX-4LX performance in the legacy Multi-Packet Write mode. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/ml

[dpdk-dev] [PATCH] net/mlx5: fix last completed built descriptor

2020-02-20 Thread Viacheslav Ovsiienko
The routine sending packets with Multi-Packet Write method assigns the wqe_last variable with transmit descriptor (WQE - work queue entry) being built. If send queue is close to full state, the WQE has no data yet (trying to put the first packet) and there is no enough space in descriptor for the n

Re: [dpdk-dev] [PATCH 0/4] Reorganise Travis jobs

2020-02-20 Thread David Marchand
On Wed, Feb 19, 2020 at 8:41 PM David Marchand wrote: > This series tries to make the travis configuration a bit easier to read, > then drops jobs that are not essential or functional duplicates in the > hope we can give some oxygen to the robot who seems to lag quite a bit > and can't catch up.

Re: [dpdk-dev] [PATCH 2/4] ci: fix Travis config warnings

2020-02-20 Thread Aaron Conole
David Marchand writes: > On Thu, Feb 20, 2020 at 12:03 PM Thomas Monjalon wrote: >> >> 19/02/2020 20:41, David Marchand: >> > Reading https://config.travis-ci.com/ and using >> > https://config.travis-ci.com/explore to check changes, we can cleanup >> > some warnings reported by the config valid

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix return value in portlist parser

2020-02-20 Thread Ferruh Yigit
On 2/20/2020 5:39 PM, Hariprasad Govindharajan wrote: > The function parse_port_list() is designed to return > unsigned int value. After sanitizing the inputs, > it is returning -1. Changed it to return 0. > > Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") > Cc: hariprasad.govindhara..

[dpdk-dev] [PATCH] build: fix experimental library versioning

2020-02-20 Thread Ferruh Yigit
The problem occurred when workaround that makes soname two digits applied. With this change for the ABI version "20.0.1" the experimental library version become ".so.2001". After workaround removed in ABI version 21.0, the experimental library version will become ".so.210". "2001" is bigger value t

Re: [dpdk-dev] ABI version of experimental libraries

2020-02-20 Thread Ferruh Yigit
On 2/18/2020 10:36 AM, Kinsella, Ray wrote: > > >> -Original Message- >> From: Thomas Monjalon >> Sent: Tuesday 18 February 2020 09:50 >> To: Richardson, Bruce >> Cc: Kinsella, Ray ; nhor...@tuxdriver.com; >> bl...@debian.org; david.march...@redhat.com; ktray...@redhat.com; >> dev@dpdk.

[dpdk-dev] Permissions Required to Run DPDK/MLX5 as Non-Root User?

2020-02-20 Thread David Christensen
Running DPDK 20.02-rc3 and attempting to use the MLX5 PMD as a non-root user. When starting testpmd I'm receiving the following error on both Power and x86_64 platforms (full output further down): net_mlx5: probe of PCI device :01:00.0 aborted after encountering an error: Operation not

[dpdk-dev] [PATCH v3] app/testpmd: fix return value in portlist parser

2020-02-20 Thread Hariprasad Govindharajan
The function parse_port_list() is designed to return unsigned int value. After sanitizing the inputs, it is returning -1. Changed it to return 0. Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") Cc: hariprasad.govindhara...@intel.com Signed-off-by: Hariprasad Govindharajan --- v3: corr

[dpdk-dev] [Bug 402] i40e: cannot add rte_flow with ether_type = ARP

2020-02-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=402 Bug ID: 402 Summary: i40e: cannot add rte_flow with ether_type = ARP Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser

2020-02-20 Thread Ferruh Yigit
On 2/20/2020 3:43 PM, Hariprasad Govindharajan wrote: > The function parse_port_list() is designed to return > unsigned int value. After sanitizing the inputs, > it is returning -1. Changed it to return 0. > > Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") > Cc: hariprasad.govindhara..

Re: [dpdk-dev] [PATCH 2/4] ci: fix Travis config warnings

2020-02-20 Thread David Marchand
On Thu, Feb 20, 2020 at 12:03 PM Thomas Monjalon wrote: > > 19/02/2020 20:41, David Marchand: > > Reading https://config.travis-ci.com/ and using > > https://config.travis-ci.com/explore to check changes, we can cleanup > > some warnings reported by the config validation options in Travis. > > For

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-20 Thread David Marchand
On Thu, Feb 20, 2020 at 3:35 PM Aaron Conole wrote: > > David Marchand writes: > > > On Thu, Feb 20, 2020 at 11:42 AM Thomas Monjalon > > wrote: > >> > >> 19/02/2020 22:39, Aaron Conole: > >> > David Marchand writes: > >> > > >> > > Let's prune the jobs list to limit the amount of time spent b

Re: [dpdk-dev] [PATCH v3] examples/tep_term: remove redundant info get

2020-02-20 Thread David Marchand
On Mon, Feb 17, 2020 at 2:41 AM Xiaoyun Li wrote: > > Removed redundant function call of 'rte_eth_dev_info_get()' since it has > already been called earlier. > > Coverity issue: 349922 > Fixes: 2bb43bd4350a ("examples/tep_term: add TSO offload configuration") > Cc: sta...@dpdk.org > > Signed-off-b

Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix incorrect string for CT length

2020-02-20 Thread David Marchand
On Thu, Feb 20, 2020 at 11:15 AM Akhil Goyal wrote: > > The NIST test vectors use the string 'PTlen' to denote text lengths > > in case of encrypt & decrypt operations. So the same string need to be > > used while parsing PT and CT. > > > > Fixes: 2adb3b4e7e54 ("examples/fips_validation: fix AES-G

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata split with encap action

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Thursday, February 20, 2020 4:44 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix metadata split with encap action > > In order to move the mbuf metadata from th

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser

2020-02-20 Thread Govindharajan, Hariprasad
> -Original Message- > From: Govindharajan, Hariprasad > Sent: Thursday, February 20, 2020 3:43 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; > step...@networkplumber.org; david.march...@redhat.com; > Govindharajan, Hariprasad > Subje

[dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser

2020-02-20 Thread Hariprasad Govindharajan
The function parse_port_list() is designed to return unsigned int value. After sanitizing the inputs, it is returning -1. Changed it to return 0. Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") Cc: hariprasad.govindhara...@intel.com Signed-off-by: Hariprasad Govindharajan --- app/tes

Re: [dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

2020-02-20 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Thursday, February 20, 2020 3:04 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX ; sta...@dpdk.org > Subject: [PATCH] cryptodev: fix missing device id range checking > > This patch adds range-checkin

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events

2020-02-20 Thread Thomas Monjalon
17/02/2020 14:01, Ferruh Yigit: > On 2/15/2020 3:41 PM, Ye Xiaolong wrote: > > On 01/15, taox@intel.com wrote: > >> From: Zhu Tao > >> > >> IXGBE link status task use rte alarm thread in old implementation. > > > > s/use/uses > > > >> Sometime ixgbe link status task takes up to 9 seconds. Th

Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list

2020-02-20 Thread Iremonger, Bernard
Hi Hariprasad, > -Original Message- > From: Govindharajan, Hariprasad > Sent: Thursday, February 20, 2020 1:27 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; > step...@networkplumber.org; david.march...@redhat.com; > Govindharajan, Haripr

Re: [dpdk-dev] [PATCH] net/mlx5: fix running without rxq

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shiri Kuzin > Sent: Thursday, February 20, 2020 4:42 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix running without rxq > > When running mlx5_dev_start in mlx5_ethdev the

[dpdk-dev] [PATCH] cryptodev: fix missing device id range checking

2020-02-20 Thread Adam Dybkowski
This patch adds range-checking of the device id passed from the user app code. It prevents out-of-range array accesses which in some situations resulted in an application crash (segfault). Fixes: 3dd4435cf473 ("cryptodev: fix checks related to device id") Cc: sta...@dpdk.org Signed-off-by: Adam D

Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: copy the item flags from prefix flow

2020-02-20 Thread Raslan Darawsheh
Hi, Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: Suanming Mou > Sent: Thursday, February 20, 2020 3:54 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v3 0/2] net/mlx5: copy the item flag

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata split with encap action

2020-02-20 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Thursday, February 20, 2020 16:44 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix metadata split with encap action > > In order to move the mbuf metadata from the WQE to the FDB steering > domain,

[dpdk-dev] [PATCH v3] cmdline: increase maximum line length

2020-02-20 Thread Wisam Jaddo
This increase due to the usage of cmdline in dpdk applications as config commands such as testpmd do for rte_flow rules creation. The current size of buffer is not enough to fill many cases of rte_flow commands validation/creation. rte_flow now can have outer items, inner items, modify actions, m

[dpdk-dev] [PATCH] net/mlx5: fix metadata split with encap action

2020-02-20 Thread Matan Azrad
In order to move the mbuf metadata from the WQE to the FDB steering domain, the PMD add for each NIC TX flow a new action to copy the metadata register REG_A to REG_C_0. This copy action is considered as modify header action from HW perspective. The HW doesn't support to do modify header action a

[dpdk-dev] [PATCH] net/mlx5: fix running without rxq

2020-02-20 Thread Shiri Kuzin
When running mlx5_dev_start in mlx5_ethdev the function calls mlx5_dev_configure_rss_reta in order to configure the rxq's. Before mlx5_dev_configure_rss_reta there isn't a check whether there are rxq's and if rxq's are 0 the function fails. For example, this command: /build/app/test-pmd/testpmd -n

Re: [dpdk-dev] [PATCH 1/4] ci: remove unnecessary dependency on Linux headers

2020-02-20 Thread Aaron Conole
David Marchand writes: > Following removal of kmod compilation, we don't need to install > linux-headers anymore. > > Fixes: ea860973592b ("ci: remove redundant configs disabling kmods") > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH 2/4] ci: fix Travis config warnings

2020-02-20 Thread Aaron Conole
David Marchand writes: > Reading https://config.travis-ci.com/ and using > https://config.travis-ci.com/explore to check changes, we can cleanup > some warnings reported by the config validation options in Travis. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole Echoing what Tho

Re: [dpdk-dev] [PATCH 3/4] ci: use an explicit list of Travis jobs

2020-02-20 Thread Aaron Conole
David Marchand writes: > Maintaining the .travis.yml requires some knowledge of how Travis > computes the jobs list (combination of os: arch: compiler: etc...). > Let's switch to an explicit list to find all jobs at a glance. > > To enhance readability, jobs have been sorted per arch/compiler wit

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-20 Thread Aaron Conole
David Marchand writes: > On Thu, Feb 20, 2020 at 11:42 AM Thomas Monjalon wrote: >> >> 19/02/2020 22:39, Aaron Conole: >> > David Marchand writes: >> > >> > > Let's prune the jobs list to limit the amount of time spent by the robot >> > > in Travis. >> > > >> > > Since meson enables automatical

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach

2020-02-20 Thread Ferruh Yigit
On 2/20/2020 10:03 AM, Iremonger, Bernard wrote: > >> -Original Message- >> From: dev On Behalf Of Wisam Jaddo >> Sent: Wednesday, February 19, 2020 4:48 PM >> To: Lu, Wenzhuo ; dev@dpdk.org; >> rasl...@mellanox.com; ma...@mellanox.com >> Cc: muk...@igel.co.jp; sta...@dpdk.org >> Subject:

[dpdk-dev] [PATCH v2] cmdline: increase maximum line length

2020-02-20 Thread Wisam Jaddo
The current length of buffer is not enough to fit all allowed items/actions, thus it will block a lot of testing. Cc: sta...@dpdk.org Signed-off-by: Wisam Jaddo --- lib/librte_cmdline/cmdline_rdline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size

2020-02-20 Thread Wisam Monther
Hi, Sure I'll handle the title with the right prefix. - consequence on memory usage? I don't think it will affect much, Since we are reading from the same buffer all the time, Read -> reset -> read again -> ...etc - How critical is this change? For now it's not that critical, but for testing per

[dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support

2020-02-20 Thread Xiaojun Liu
Split dev init to 2 parts. First only register the port in switch management; second init hook will be called after all the pf are registered and switch initialization. It will finish dev init. Also add switch interrupt support. Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset to support mirror op

[dpdk-dev] [PATCH v2 3/5] net/fm10k: add ffu and statistics and config file functions

2020-02-20 Thread Xiaojun Liu
Add ffu to support offload flow into HW. It supports forward, mirror, push VLAN, pop VLAN. It also supports flowset for a group flow definition. The config file can configure debug log, port speed, epl port mapping dpdk port, flowset. All these configuration will be used by switch management. Stati

[dpdk-dev] [PATCH v2 4/5] net/fm10k: add flow interface and switch management

2020-02-20 Thread Xiaojun Liu
Add flow interface to support offload flow into HW. It supports parse vlan and parse mpls, all these data will be transffered to ffu data. Add switch management, includes initialization, port mapping, epl port link, LED controller, interrupt handler. It create 3 threads. One for interrupt handler,

[dpdk-dev] [PATCH v2 1/5] net/fm10k: add basic functions for switch management

2020-02-20 Thread Xiaojun Liu
Add I2C to control the inside LED and PHY. All the operations of I2C are using fm10k I2C register. Add SBUS to communicate with spico(micro code in serdes) by using fm10k SBUS register. This is like I2C operations. Add registers defination, which include all the registers will be used in the driver

[dpdk-dev] [PATCH v2 0/5] support switch management

2020-02-20 Thread Xiaojun Liu
To avoid configuration for both kernel driver and userspace SDK outside DPDK, we add switch management in FM10K DPDK PMD driver. Split dev init to 2 parts. First only register the port in switch management; second init hook will be called after all the pf are registered and switch initialization.

[dpdk-dev] [PATCH v3 0/2] net/mlx5: copy the item flags from prefix flow

2020-02-20 Thread Suanming Mou
For flow split to several subflows, the match items maybe in the prefix flow, and the actions are split to the suffix flow. In this case, for the actions need the user defined match item will not create correctly. Copy the item layers flags to the suffix flow from prefix flow to fix the issue. T

[dpdk-dev] [PATCH v3 1/2] net/mlx5: fix layer flags missing in metadata

2020-02-20 Thread Suanming Mou
Metadata suffix subflow inherits the RSS needed hash_fields from the prefix subflow as the suffix subflow only has the tag match item unable to generate the full original hash_fields for RSS action. Unfortunately, hash_fields will only be generated if flow has RSS action. So it means the prefix fl

[dpdk-dev] [PATCH v3 2/2] net/mlx5: fix lack of match information in meter

2020-02-20 Thread Suanming Mou
As meter flows are split into three subflows each, the prefix subflow with meter action color the packet, the meter subflow filters out the colored packets, the suffix subflow applies all the remaining actions to the passed packets. Currently, all the user defined items are matched in the prefix f

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: copy the item flags from prefix flow

2020-02-20 Thread Raslan Darawsheh
Hi, Taking this series out of next-net-mlx, Waiting for a v2, we are seeing a Seg. Fault due to the first patch of this series. Kindest regards, Raslan Darawsheh > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, February 20, 2020 2:13 PM > To: Suanming Mou ; Slava Ovsiien

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/cmdline_rdline: increase command line buf size

2020-02-20 Thread Thomas Monjalon
Hi, About the title, I suggest: cmdline: increase maximum line length 20/02/2020 14:18, Wisam Jaddo: > The current size of buffer is not enough to fit all allowed items/actions, > thus it will block a lot of testing. > > Cc: sta...@dpdk.org +Cc maintainers of cmdline and testpmd > Signed-off-b

[dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list

2020-02-20 Thread Hariprasad Govindharajan
The function parse_port_list() is designed to return unsigned int value. After sanitizing the inputs, it is returning -1. Changed it to return 0. Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") Cc: hariprasad.govindhara...@intel.com Signed-off-by: Hariprasad Govindharajan --- app/tes

Re: [dpdk-dev] [RFC] service: stop lcore threads before 'finalize'

2020-02-20 Thread David Marchand
On Mon, Feb 10, 2020 at 3:16 PM Van Haaren, Harry wrote: > > > We need a fix for this issue. > > > > +1 > > > > Interestingly, Stephen patch that joins all pthreads at > > > rte_eal_cleanup [1] makes this issue disappear. > > > So my understanding is that we are missing a api (well, I could not >

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Thursday, February 20, 2020 1:33 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag > > HW supports match on one Etherty

[dpdk-dev] [PATCH] lib/cmdline_rdline: increase command line buf size

2020-02-20 Thread Wisam Jaddo
The current size of buffer is not enough to fit all allowed items/actions, thus it will block a lot of testing. Cc: sta...@dpdk.org Signed-off-by: Wisam Jaddo --- lib/librte_cmdline/cmdline_rdline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_cmdline/cmdline_r

[dpdk-dev] [PATCH] doc/mlx5: clarify memory write combining attribute

2020-02-20 Thread Viacheslav Ovsiienko
Just add the words about write combining attribute. Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 5ab7c07..dd2fbde 100644 --- a/doc/guides/nic

Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN actions in meter

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, February 20, 2020 9:46 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix VLAN actions in meter > > Meter suffix subflow only has the port id an

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach

2020-02-20 Thread Wisam Monther
When attaching new device, it needs to pass the white list options with the PCI, For example if I want the following set of options with the new attach device it will fail Due to not enough space: port attach :03:00.0,l3_vxlan_en=1,txq_inline_mpw=77,dv_xmeta_en=1,txqs_min_inline=0,dv_esw_en=1

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix identifier size for port attach

2020-02-20 Thread Ferruh Yigit
On 2/19/2020 4:47 PM, Wisam Jaddo wrote: > Identifier for new port may contain white list options, > and white list options will not fit into 128 from STR_TOKEN_SIZE, > instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide > better and more options Out of curiosity, what device identifie

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-20 Thread David Marchand
On Thu, Feb 20, 2020 at 11:42 AM Thomas Monjalon wrote: > > 19/02/2020 22:39, Aaron Conole: > > David Marchand writes: > > > > > Let's prune the jobs list to limit the amount of time spent by the robot > > > in Travis. > > > > > > Since meson enables automatically the relevant components, there i

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: copy the item flags from prefix flow

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, February 19, 2020 4:31 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5: copy the item flags from prefix flow > > For flow split to several subflows, the match

Re: [dpdk-dev] [PATCH 2/4] ci: fix Travis config warnings

2020-02-20 Thread David Marchand
On Thu, Feb 20, 2020 at 12:03 PM Thomas Monjalon wrote: > > 19/02/2020 20:41, David Marchand: > > Reading https://config.travis-ci.com/ and using > > https://config.travis-ci.com/explore to check changes, we can cleanup > > some warnings reported by the config validation options in Travis. > > For

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag

2020-02-20 Thread Matan Azrad
From: Dekel Peled > HW supports match on one Ethertype, the Ethertype following the last VLAN > tag of the packet (see PRM). > Previous patch added specific handling for packets with VLAN tag, after > setting match on Ethertype. > > This patch moves the handling of packets with VLAN tag, to be

Re: [dpdk-dev] [PATCH] crypto/nitrox: fix coverity defects

2020-02-20 Thread Thomas Monjalon
20/02/2020 12:07, Akhil Goyal: > > > > Address the defects reported by coverity: Unintended sign extension > > and Out-of-bounds access. > > > > Coverity issue: 349899, 349905, 349911, 349921, 349923, 349926 > > > > Fixes: 32e4930d5a3b ("crypto/nitrox: add hardware queue management") > > Fixes:

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-02-20 Thread Trahe, Fiona
Hi Luca, > -Original Message- > > Postponing again by one week to give more time to look into the QAT issue. > > Apologies again for any issue it might cause. Thanks for that and sorry about the delay. We're hoping to send a fix for that today. Fiona

[dpdk-dev] [PATCH v2] net/mlx5: fix match on Ethertype and CVLAN tag

2020-02-20 Thread Dekel Peled
HW supports match on one Ethertype, the Ethertype following the last VLAN tag of the packet (see PRM). Previous patch added specific handling for packets with VLAN tag, after setting match on Ethertype. This patch moves the handling of packets with VLAN tag, to be done before and instead of settin

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: fix incorrect layer choose with decap

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, February 19, 2020 4:26 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5: fix incorrect layer choose with decap > > For header modify actions after decapsulation

Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect set VLAN ID action offset

2020-02-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, February 19, 2020 4:15 PM > To: Slava Ovsiienko ; Matan Azrad > ; Dekel Peled > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix incorrect set VLAN ID action offset > > Currently, the

[dpdk-dev] DPDK Release Status Meeting 20/02/2020

2020-02-20 Thread Ferruh Yigit
Minutes 20 February 2020 Agenda: * Release Dates * -rc3 status * Subtrees * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.02 dates: * -rc3 is released on 16 February * https://mai

Re: [dpdk-dev] [PATCH] crypto/nitrox: fix coverity defects

2020-02-20 Thread Akhil Goyal
> > Address the defects reported by coverity: Unintended sign extension > and Out-of-bounds access. > > Coverity issue: 349899, 349905, 349911, 349921, 349923, 349926 > > Fixes: 32e4930d5a3b ("crypto/nitrox: add hardware queue management") > Fixes: 9fdef0cc2385 ("crypto/nitrox: create symmetric

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-20 Thread Thomas Monjalon
19/02/2020 20:41, David Marchand: > Let's prune the jobs list to limit the amount of time spent by the robot > in Travis. > > Since meson enables automatically the relevant components, there is not > much gain in testing with extra_packages vs required_packages only. > > For a given arch/compiler

Re: [dpdk-dev] [PATCH 3/4] ci: use an explicit list of Travis jobs

2020-02-20 Thread Thomas Monjalon
19/02/2020 20:41, David Marchand: > Maintaining the .travis.yml requires some knowledge of how Travis > computes the jobs list (combination of os: arch: compiler: etc...). > Let's switch to an explicit list to find all jobs at a glance. > > To enhance readability, jobs have been sorted per arch/co

[dpdk-dev] [PATCH] crypto/nitrox: fix coverity defects

2020-02-20 Thread Nagadheeraj Rottela
Address the defects reported by coverity: Unintended sign extension and Out-of-bounds access. Coverity issue: 349899, 349905, 349911, 349921, 349923, 349926 Fixes: 32e4930d5a3b ("crypto/nitrox: add hardware queue management") Fixes: 9fdef0cc2385 ("crypto/nitrox: create symmetric cryptodev") Sign

Re: [dpdk-dev] [PATCH 2/4] ci: fix Travis config warnings

2020-02-20 Thread Thomas Monjalon
19/02/2020 20:41, David Marchand: > Reading https://config.travis-ci.com/ and using > https://config.travis-ci.com/explore to check changes, we can cleanup > some warnings reported by the config validation options in Travis. For documentation purpose, would be good to describe issues in the commit

Re: [dpdk-dev] [PATCH 1/4] ci: remove unnecessary dependency on Linux headers

2020-02-20 Thread Thomas Monjalon
19/02/2020 20:41, David Marchand: > Following removal of kmod compilation, we don't need to install > linux-headers anymore. > > Fixes: ea860973592b ("ci: remove redundant configs disabling kmods") > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH] net/ice: fix queue bind MSI-X interrupt error

2020-02-20 Thread Ferruh Yigit
On 2/20/2020 9:43 AM, Zhu, TaoX wrote: > Hi Yigit, Ferruh > > The original author was not found. The meaning of these bits is as follows: > ITR Index of the interrupt cause: > 00b - ITR0 ; 01b - ITR1; 10b - ITR2; 11b - NoITR > > I think the reason why the original author wrote this strange code i

Re: [dpdk-dev] [PATCH 4/4] ci: reorganise Travis jobs

2020-02-20 Thread Thomas Monjalon
19/02/2020 22:39, Aaron Conole: > David Marchand writes: > > > Let's prune the jobs list to limit the amount of time spent by the robot > > in Travis. > > > > Since meson enables automatically the relevant components, there is not > > much gain in testing with extra_packages vs required_packages

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: extend inline session to non AES-GCM

2020-02-20 Thread Akhil Goyal
> > Hi Akhil, > > > > > This patch extends creation of inline session to all the algorithms. > > > > Previously the inline session was enabled only for AES-GCM cipher. > > > > > > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline > > > > crypto") > > > > > > > > Signed-

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: extend inline session to non AES-GCM

2020-02-20 Thread Ananyev, Konstantin
Hi Akhil, > > > This patch extends creation of inline session to all the algorithms. > > > Previously the inline session was enabled only for AES-GCM cipher. > > > > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline > > > crypto") > > > > > > Signed-off-by: Ankur Dwivedi

Re: [dpdk-dev] [PATCH] app/crypto-perf: use common macros for min/max

2020-02-20 Thread Akhil Goyal
> The macros RTE_MIN and RTE_MAX can be used in DPDK applications. > > Signed-off-by: Thomas Monjalon > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] test/ipsec: fix a typo in function name

2020-02-20 Thread Akhil Goyal
> > > > The name of the static function check_cryptodev_capablity() > > is fixed for the word "capability". > > There is no functional change. > > > > The same typo is fixed in a comment in ip_fragmentation example. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Cc: sta..

Re: [dpdk-dev] [PATCH] ipsec: fix use of uninitialized variable

2020-02-20 Thread Akhil Goyal
> > > Defects reported by coverity scan > > > uninit_use_in_call: Using uninitialized element of array clen when > > > calling cpu_crypto_bulk. > > > > > > Coverity issue: 354233, 354234 > > > Fixes: 957394f72658 ("ipsec: support CPU crypto mode") > > > > > > Signed-off-by: Konstantin Ananyev > >

Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix incorrect string for CT length

2020-02-20 Thread David Marchand
On Thu, Feb 20, 2020 at 11:15 AM Akhil Goyal wrote: > > The NIST test vectors use the string 'PTlen' to denote text lengths > > in case of encrypt & decrypt operations. So the same string need to be > > used while parsing PT and CT. > > > > Fixes: 2adb3b4e7e54 ("examples/fips_validation: fix AES-G

Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix incorrect string for CT length

2020-02-20 Thread Akhil Goyal
> > The NIST test vectors use the string 'PTlen' to denote text lengths > in case of encrypt & decrypt operations. So the same string need to be > used while parsing PT and CT. > > Fixes: 2adb3b4e7e54 ("examples/fips_validation: fix AES-GCM cipher length > parsing") > > Signed-off-by: Anoob Jo

Re: [dpdk-dev] [PATCH] build: add combined libs

2020-02-20 Thread Luca Boccassi
On Wed, 2020-02-19 at 11:13 -0800, Ruslan Babayev wrote: > Add combined libdpdk.a and libdpdk.so libs for Meson similar to how > it's done for Make builds > > Signed-off-by: Ruslan Babayev < > rus...@babayev.com > > > --- > buildtools/group-libs.sh | 2 ++ > buildtools/meson.build | 1 + > me

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: extend inline session to non AES-GCM

2020-02-20 Thread Akhil Goyal
> -Original Message- > From: Anoob Joseph > Sent: Saturday, February 15, 2020 1:06 PM > To: Akhil Goyal ; Konstantin Ananyev > > Cc: Ankur Dwivedi ; Narayana Prasad Raju Athreya > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] examples/ipsec-secgw: extend inline session to > non AES-G

Re: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach

2020-02-20 Thread Iremonger, Bernard
> -Original Message- > From: dev On Behalf Of Wisam Jaddo > Sent: Wednesday, February 19, 2020 4:48 PM > To: Lu, Wenzhuo ; dev@dpdk.org; > rasl...@mellanox.com; ma...@mellanox.com > Cc: muk...@igel.co.jp; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-20 Thread Burakov, Anatoly
On 19-Feb-20 4:20 PM, Kamaraj P wrote: Hi Anatoly, Yes we are facing an issue with our custom applications. Earlier we have tried with l2fwd DPDK application and does not see any issue with memory initialization. Not sure whether we missed any other options. BTW when we tried with l2fwd appli

Re: [dpdk-dev] 17.11.10 (LTS) patches review and test

2020-02-20 Thread Luca Boccassi
On Sat, 15 Feb 2020 at 11:21, Luca Boccassi wrote: > > On Thu, 30 Jan 2020 at 10:08, Luca Boccassi wrote: > > > > On Mon, 2020-01-13 at 12:47 +, Luca Boccassi wrote: > > > Hi all, > > > > > > Here is a list of patches targeted for LTS release 17.11.10. > > > This will be the last 17.11 releas

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc3

2020-02-20 Thread Maxime Coquelin
Hi, Thanks for the testing. On 2/20/20 10:41 AM, Peng, Yuan wrote: > DPDK 20.02 RC3 Test Report from intel: > > Summary > • Totally 9898 test cases for 20.02 RC3, 9629 cases are executed, 9428 > test cases passed, 178 test cases failed, 23 test case blocked, Execution > rate is 97.28%, pa

Re: [dpdk-dev] [PATCH] net/ice: fix queue bind MSI-X interrupt error

2020-02-20 Thread Zhu, TaoX
Hi Yigit, Ferruh The original author was not found. The meaning of these bits is as follows: ITR Index of the interrupt cause: 00b - ITR0 ; 01b - ITR1; 10b - ITR2; 11b - NoITR I think the reason why the original author wrote this strange code is to highlight that these bits are important in this

Re: [dpdk-dev] [dpdk-announce] release candidate 20.02-rc3

2020-02-20 Thread Peng, Yuan
DPDK 20.02 RC3 Test Report from intel: Summary • Totally 9898 test cases for 20.02 RC3, 9629 cases are executed, 9428 test cases passed, 178 test cases failed, 23 test case blocked, Execution rate is 97.28%, pass rate is 97.91%. • Totally create ~278 new tests for DPDK20.02 new fe

[dpdk-dev] [PATCH 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-02-20 Thread Kevin Traynor
gcc 10.0.1 reports: ../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: ../examples/ipsec-secgw/ipsec_process.c:132:34: error: ‘grp.m’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 132 |grp[n].cnt = pkts + i - grp[n].m; |

  1   2   >