[dpdk-dev] [Bug 384] netvsc PMD crashes in secondary process in dev_info_get

2020-01-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=384 Bug ID: 384 Summary: netvsc PMD crashes in secondary process in dev_info_get Product: DPDK Version: 19.08 Hardware: x86 OS: Linux Status: UNCONFIRMED

[dpdk-dev] [PATCH v4 6/6] doc/api: reduce indentation in meson build file

2020-01-10 Thread Bruce Richardson
When building the API docs, we can make the meson.build file easier to read, and allow more code per line, by using subdir_done() to quit early. Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Aaron Conole Acked-by: Luca Boccassi --- @stable, this patch may be considered for back

[dpdk-dev] [PATCH v4 2/6] build: skip processing docs folder if docs disabled

2020-01-10 Thread Bruce Richardson
While each target is set to be ignored if the docs are disabled in the meson build, there is little reason to process the docs folder at all. Signed-off-by: Bruce Richardson Acked-by: Aaron Conole Acked-by: Luca Boccassi --- doc/meson.build | 4 1 file changed, 4 insertions(+) diff --git

[dpdk-dev] [PATCH v4 3/6] doc/api: fix warning with meson build

2020-01-10 Thread Bruce Richardson
The install parameter to configure_file is new in 0.50 and generates a warning since it is newer than our minimum version of 0.47.1. The parameter, however, is unneeded as the documentation states: "When omitted it defaults to true when install_dir is set and not empty, false otherwise." Given th

[dpdk-dev] [PATCH v4 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-10 Thread Bruce Richardson
Add proper support for calling sphinx whenever a file in the doc directory changes. This is accomplished by using a wrapper script for sphinx, which runs sphinx but also emits a gcc-format dependency file listing all the doc files. This is used by ninja so that any change to the doc files triggers

[dpdk-dev] [PATCH v4 4/6] doc/guides: reduce whitespace in meson build file

2020-01-10 Thread Bruce Richardson
For building the guides, we can make the meson.build easier to read by using the subdir_done function to quit early. Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Aaron Conole Acked-by: Luca Boccassi --- @stable, this may be considered for 19.11 backport to make other backport

[dpdk-dev] [PATCH v4 1/6] kernel/linux/kni: fix meson warning about console keyword

2020-01-10 Thread Bruce Richardson
Since kni no longer includes the ethtool code and so is faster to build, we no longer need the console parameter to have incremental screen updates as it builds. Therefore, we drop the keyword which removes the warning. Fixes: b78f32cff94d ("kni: support meson build") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH v4 0/6] meson build improvements

2020-01-10 Thread Bruce Richardson
These patches make some improvements to the meson build, particularly for documentation. They also remove many, but not all warnings issued by meson e.g. warnings about newer features unsupported in baseline. The biggest change is to improve the handling of the guide html docs. The change here is

Re: [dpdk-dev] [PATCH v2 1/7] net/ixgbe: avoid multpile definitions of 'bool'

2020-01-10 Thread Dharmik Thakkar
Hi Ferruh, Thank you for the comments! I have rebased the patches on dpdk-next-net and fixed the issue. I have put out the patch. > On Jan 10, 2020, at 3:22 AM, Ferruh Yigit wrote: > > On 1/2/2020 5:48 PM, Dharmik Thakkar wrote: >> Compilation issue arises due to multiple definitions of 'bool'

[dpdk-dev] [PATCH v3 7/7] net/qede: remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' to avoid possible multiple definitions of 'bool'. (Not sure if the previous code is checking for true/false condition. Recommend careful review on this patch.) Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- drive

[dpdk-dev] [PATCH v3 6/7] net/fm10k: remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' to avoid possible multiple definitions of 'bool'. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Acked-by: Xiao Wang --- drivers/net/fm10k/base/fm10k_osdep.h | 8 +--- drivers/net/fm10k/fm10k_ethdev.c | 6 +++

[dpdk-dev] [PATCH v3 4/7] net/bnx2x: remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' to avoid possible multiple definitions of 'bool'. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- drivers/net/bnx2x/bnx2x_ethdev.h | 4 +-- drivers/net/bnx2x/ecore_sp.c | 46 2

[dpdk-dev] [PATCH v3 5/7] net/e1000: remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' to avoid possible multiple definitions of 'bool'. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang --- drivers/net/e1000/base/e1000_osdep.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/e1000/base/e1000_osdep

[dpdk-dev] [PATCH v3 1/7] net/ixgbe: avoid multpile definitions of 'bool'

2020-01-10 Thread Dharmik Thakkar
Compilation issue arises due to multiple definitions of 'bool' in 'ixgbe_ethdev.h'. Error: '/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c: In function ‘ixgbe_dev_setup_link_alarm_handler’: /dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:4075:43: error: passing argument 3 of ‘ixgbe_get_link_capabilities’ from inco

[dpdk-dev] [PATCH v3 0/7] remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' Thus, avoid future compilation problems when 'stdbool.h' gets included in these files. --- v3: - Rebase on dpdk-next-net - Fix build issue in net/ixgbe --- v2: - Remove 'typedef int bool' from other drivers --- Dharmik Thakkar (7): net/ixgbe: avoid mu

[dpdk-dev] [PATCH v3 2/7] net/cxgbe: remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' to avoid possible multiple definitions of 'bool'. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang --- drivers/net/cxgbe/cxgbe_compat.h | 4 +--- drivers/net/cxgbe/cxgbe_main.c | 13 +++-- 2 files changed, 8

[dpdk-dev] [PATCH v3 3/7] net/vmxnet3: remove 'typedef int bool'

2020-01-10 Thread Dharmik Thakkar
Replace 'typedef int bool' with 'stdbool.h' to avoid possible multiple definitions of 'bool'. Remove 'typedef char Bool' and use 'bool' instead. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Acked-by: Yong Wang --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 6

Re: [dpdk-dev] [PATCH v3 1/6] kernel/linux/kni: fix meson warning about console keyword

2020-01-10 Thread Kevin Traynor
On 09/01/2020 18:02, David Marchand wrote: > On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson > wrote: >> >> Since kni no longer includes the ethtool code and so is faster to build, we >> no longer need the console parameter to have incremental screen updates as >> it builds. Therefore, we drop the

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Kevin Traynor
On 10/01/2020 12:59, Thomas Monjalon wrote: > 10/01/2020 13:34, Maxime Coquelin: >> On 1/10/20 1:31 PM, Wang, Haiyue wrote: >>> From: Thomas Monjalon 10/01/2020 10:07, Matan Azrad: > From: Wang, Haiyue >> From: Matan Azrad delete mode 100644 doc/guides/nics/ifc.rst create m

Re: [dpdk-dev] [PATCH v2 0/2] add IPv4/IPv6 DSCP rewrite action

2020-01-10 Thread Ferruh Yigit
On 1/7/2020 7:24 AM, Suanming Mou wrote: > For some overlay network, such as VXLAN, the DSCP field in the new outer > IP header after VXLAN decapsulation may need to be updated accordingly. > > This patchset implements the DSCP rewrite action for IPv4 and IPv6 as RFC[1]. > > [1] > https://inbox.

Re: [dpdk-dev] [PATCH v3 2/2] net/i40e: support FDIR for L2TPv3 over IP

2020-01-10 Thread Ferruh Yigit
On 1/7/2020 3:39 PM, Rory Sexton wrote: > Adding FDIR support for L2TPv3 over IP header matching and adding > a new customized pctype for l2tpv3 over IP. > > Signed-off-by: Rory Sexton > Signed-off-by: Dariusz Jagus > --- > v3 changes: > * removing testpmd doc update as this patch focus only on

Re: [dpdk-dev] [PATCH v2 2/3] doc: add vDPA feature table

2020-01-10 Thread Thomas Monjalon
09/01/2020 12:00, Matan Azrad: > +This section explains the supported features that are listed in the table > below. > + > + * csum - Device can handle packets with partial checksum. > + * guest csum - Guest can handle packets with partial checksum. > + * mac - Device has given MAC address. > +

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add L2TPv3 over IP header to flow API

2020-01-10 Thread Ferruh Yigit
On 1/7/2020 3:39 PM, Rory Sexton wrote: > This patch adds the new flow item RTE_FLOW_ITEM_TYPE_L2TPV3OIP to > flow API to match a L2TPv3 over IP header. This patch supports only > L2TPv3 over IP header format which is different to L2TPv2/L2TPv3 > over UDP. The difference in header formats between L

Re: [dpdk-dev] [PATCH 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-10 Thread Stephen Hemminger
On Fri, 10 Jan 2020 17:56:59 + Viacheslav Ovsiienko wrote: > + > +static inline uint64_t > +rte_mbuf_has_pinned_extbuf(const struct rte_mbuf *m) > +{ > + if (RTE_MBUF_HAS_EXTBUF(m)) { > + /* > + * The mbuf has the external attached buffer, > + * we sh

[dpdk-dev] [PATCH 4/4] net/mlx5: allow use allocated mbuf with external buffer

2020-01-10 Thread Viacheslav Ovsiienko
In the Rx datapath the flags in the newly allocated mbufs are all explicitly cleared but the EXT_ATTACHED_MBUF must be preserved. It would allow to use mbuf pools with pre-attached external data buffers. The vectorized rx_burst routines are updated in order to inherit the EXT_ATTACHED_MBUF from mb

[dpdk-dev] [PATCH 3/4] app/testpmd: add mempool with external data buffers

2020-01-10 Thread Viacheslav Ovsiienko
The new mbuf pool type is added to testpmd. To engage the mbuf pool with externally attached data buffers the parameter "--mp-alloc=xbuf" should be specified in testpmd command line. The objective of this patch is just to test whether mbuf pool with externally attached data buffers works OK. The m

[dpdk-dev] [PATCH 2/4] mbuf: create packet pool with external memory buffers

2020-01-10 Thread Viacheslav Ovsiienko
The dedicated routine rte_pktmbuf_pool_create_extbuf() is provided to create mbuf pool with data buffers located in the pinned external memory. The application provides the external memory description and routine initialises each mbuf with appropriate virtual and physical buffer address. It is enti

[dpdk-dev] [PATCH 0/4] mbuf: introduce pktmbuf pool with pinned external buffers

2020-01-10 Thread Viacheslav Ovsiienko
Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

[dpdk-dev] [PATCH 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-10 Thread Viacheslav Ovsiienko
Update detach routine to check the mbuf pool type. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 59 ++ 1 file changed, 55 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-10 Thread Thomas Monjalon
10/01/2020 15:18, Xu, Rosen: > From: Thomas Monjalon > > 10/01/2020 03:38, Xu, Rosen: > > > From: Matan Azrad > > > > From: Xu, Rosen > > > > > From: Thomas Monjalon > > > > > > 09/01/2020 03:27, Xu, Rosen: > > > > > > > From: Thomas Monjalon > > > > > > > > 08/01/2020 13:39, Xu, Rosen: > > >

Re: [dpdk-dev] [PATCH v3 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-10 Thread Bruce Richardson
On Thu, Jan 09, 2020 at 03:31:11PM +, Bruce Richardson wrote: > Add proper support for calling sphinx whenever a file in the doc > directory changes. This is accomplished by using a wrapper script > for sphinx, which runs sphinx but also emits a gcc-format dependency > file listing all the doc

Re: [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

2020-01-10 Thread Stephen Hemminger
On Thu, 9 Jan 2020 11:14:25 +0800 Fang TongHao wrote: > Hi all,I am from Sangfor Tech.I found a bug when using DPDK in > multiprocess scenario.The secondary process enters > "rte_eth_dev_pci_copy_info" function when initializing.Then it > sets the value of struct "rte_eth_dev_data.dev_flags" to

[dpdk-dev] [PATCH v4 14/14] doc: update i40e user guide

2020-01-10 Thread Bernard Iremonger
Update the i40e user guide with ESP information. Signed-off-by: Bernard Iremonger --- doc/guides/nics/i40e.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 38acf59..5cf34d9 100644 --- a/doc/guides/nics/i40e.rst +

[dpdk-dev] [PATCH v4 13/14] doc: release note for ESP

2020-01-10 Thread Bernard Iremonger
Release note for ESP support on the i40e PMD. Release note for ESP support on testpmd. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v4 11/14] net/i40e: display Flow Director packet

2020-01-10 Thread Bernard Iremonger
include rte_config.h in i40e_fdir.c In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and in i40e_fdir_construct_pkt() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/i4

[dpdk-dev] [PATCH v4 10/14] config: add debug to I40E Flow Director

2020-01-10 Thread Bernard Iremonger
add CONFIG_RTE_LIBRTE_I40E_DEBUG_FD to config/common_base file Signed-off-by: Bernard Iremonger --- config/common_base | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_base b/config/common_base index 7dec7ed..7a76c26 100644 --- a/config/common_base +++ b/config/common_base @@ -3

[dpdk-dev] [PATCH v4 12/14] librte_ethdev: add ESP and AH flow types to RSS

2020-01-10 Thread Bernard Iremonger
Add flow types for the following PCTYPE's in the DDP ipsec profile: 14: IPV6 ESP 15: IPV4 ESP 16: IPV6 AH 17: IPV4 AH 18: IPV6 UDP ESP 19: IPV4 UDP ESP Add the following RSS macros for IPsec: ETH_RSS_ESP ETH_RSS_AH ETH_RSS_IPSEC Signed-off-by: Bernard Iremonger --- lib/librte_ethdev/rte_ethdev.

[dpdk-dev] [PATCH v4 09/14] net/i40e: support ESP in Flow Director

2020-01-10 Thread Bernard Iremonger
add fill_ip6_head() hardcode udp destination port to 4500 handle ESP and AH pctypes in ESP-AH profile Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 126 --- 1 file changed, 118 insertions(+), 8 deletions(-) diff --git a/drivers/net/i

[dpdk-dev] [PATCH v4 08/14] net/i40e: support ESP flows

2020-01-10 Thread Bernard Iremonger
add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns update i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_flow.c | 135 ++- 1 file changed, 1

[dpdk-dev] [PATCH v4 07/14] net/i40e: support ESP in customised code

2020-01-10 Thread Bernard Iremonger
update customized code for ESP Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 44 +- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5f1cf8a..a462eba

[dpdk-dev] [PATCH v4 06/14] net/i40e: support ipsec-ah profile

2020-01-10 Thread Bernard Iremonger
Add flow structures for the following patterns in i40e_ethdev files: eth/ipv4/esp eth/ipv6/esp eth/ipv4/udp/esp eth/ipv6/esp/udp add oip_type in filter add is_udp in filter use tenant_id in filter for spi Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.h | 38 +

[dpdk-dev] [PATCH v4 01/14] app/testpmd: parse flow command line for ESP

2020-01-10 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI Signed-off-by: Bernard Iremonger Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 4 +--- app/test-pmd/config.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 9643148..

[dpdk-dev] [PATCH v4 00/14] net/i40e: ESP support

2020-01-10 Thread Bernard Iremonger
Add support for ESP flows to testpmd. Improve debug information in testpmd and the i40e PMD. Process ESP flows on the i40e Flow Director and RSS. Changes in V4: - Add extra patch for testpmd Add extra patch for config Split v3 patch "net/i40e: process ESP flows" into 4 patches Changes

[dpdk-dev] [PATCH v4 02/14] app/testpmd: improve debug

2020-01-10 Thread Bernard Iremonger
print function name in port_flow_complain() Signed-off-by: Bernard Iremonger --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index d599682..2753ec5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/co

[dpdk-dev] [PATCH v4 04/14] net/i40e: improve RSS debug

2020-01-10 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 ---

[dpdk-dev] [PATCH v4 05/14] net/i40e: handle ESP tunnel

2020-01-10 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a/drivers/net/i40e/rt

[dpdk-dev] [PATCH v4 03/14] app/testpmd: dump Rx and Tx mbuf

2020-01-10 Thread Bernard Iremonger
add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c Signed-off-by: Bernard Iremonger --- app/test-pmd/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index b514be5..bf03873 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -

Re: [dpdk-dev] [PATCH v4 2/2] ci: add travis ci support for aarch64

2020-01-10 Thread Aaron Conole
Ruifeng Wang writes: > Add Travis compilation jobs for aarch64. gcc/clang compilations for > static/shared libraries are added. > > Some limitations for current aarch64 Travis support: > 1. Container is used. Huge page is not available due to security reason. > 2. Missing kernel header package in

Re: [dpdk-dev] [PATCH v4 1/2] devtools: add path to additional shared object files

2020-01-10 Thread Aaron Conole
Ruifeng Wang writes: > Drivers librte_mempool_ring.so and librte_pmd_null.so are loaded by > librte_eal.so when running testpmd. > In Ubuntu Xenial, driver path is installed to RPATH on testpmd. This > allows librte_eal.so to find drivers by using the RPATH. > However, in Ubuntu Bionic, driver pa

[dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-01-10 Thread Anoob Joseph
Currently only one qp will be used for one core. The number of qps can be increased to match the number of lcore params. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 39 +++--- examples/ipsec-secgw/ipsec.h | 4 +++- 2 files changed,

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP

2020-01-10 Thread Ferruh Yigit
On 1/8/2020 3:57 PM, Loftus, Ciara wrote: >> >> Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just >> call it directly, like elsewhere in the driver. >> >> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Xiao Wang >>

Re: [dpdk-dev] [EXT] RE: [PATCH 11/14] examples/ipsec-secgw: add app processing code

2020-01-10 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 24.12.2019 14:13, Ananyev, Konstantin wrote: > External Email > > -- > >> --- a/examples/ipsec-secgw/ipsec_worker.c >> +++ b/examples/ipsec-secgw/ipsec_worker.c >> @@ -15,6 +

Re: [dpdk-dev] [EXT] RE: [PATCH 11/14] examples/ipsec-secgw: add app processing code

2020-01-10 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 23.12.2019 17:49, Ananyev, Konstantin wrote: > External Email > > -- > > >> >> Add IPsec application processing code for event mode. >> >> Signed-off-by: Anoob Joseph >> Si

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-10 Thread Xu, Rosen
> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 10, 2020 17:21 > To: Matan Azrad ; Xu, Rosen > Cc: Maxime Coquelin ; Bie, Tiwei > ; Wang, Zhihong ; Wang, > Xiao W ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy ; Roni Bar Yanai > > Subject: Re: [dpdk-dev] [PATCH v1 0/

Re: [dpdk-dev] [PATCH v8 3/4] net/ixgbe: cleanup Tx buffers

2020-01-10 Thread Ananyev, Konstantin
> > Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup > to force free consumed buffers on Tx ring. > > Signed-off-by: Chenxu Di > --- > drivers/net/ixgbe/ixgbe_ethdev.c| 2 + > drivers/net/ixgbe/ixgbe_rxtx.c | 109 > drivers/net/ix

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-10 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 10, 2020 15:11 > To: Slava Ovsiienko > Cc: Ferruh Yigit ; dev@dpdk.org; Matan Azrad > ; Raslan Darawsheh ; Ori > Kam > Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion > queue > > 10/01/2020 1

Re: [dpdk-dev] [PATCH v1] net/axgbe: Add a HW quirk for register definitions

2020-01-10 Thread Ferruh Yigit
On 1/10/2020 1:24 PM, Sebastian, Selwin wrote: > [AMD Official Use Only - Internal Distribution Only] > > Hi Ferruh, > I checked for FW version, PHY/MAC , registers for differentiating and > it cannot be used. Thanks for double checking, I will proceed with your v2. > > Thanks and Regar

Re: [dpdk-dev] [PATCH v1] net/axgbe: Add a HW quirk for register definitions

2020-01-10 Thread Sebastian, Selwin
[AMD Official Use Only - Internal Distribution Only] Hi Ferruh, I checked for FW version, PHY/MAC , registers for differentiating and it cannot be used. Thanks and Regards Selwin Sebastian -Original Message- From: Ferruh Yigit Sent: Thursday, January 9, 2020 3:48 PM To: Sebas

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Ferruh Yigit
On 1/10/2020 9:38 AM, Kumar, Ravi1 wrote: <...> >> -Original Message- >> From: dev On Behalf Of cnamb...@amd.com >> Sent: Friday, December 20, 2019 6:13 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats >> reporting >> >> [CAUTION: External Email]

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-10 Thread Thomas Monjalon
10/01/2020 10:55, Slava Ovsiienko: > From: Thomas Monjalon > > 10/01/2020 10:28, Slava Ovsiienko: > > > From: Thomas Monjalon > > > > 09/01/2020 17:22, Slava Ovsiienko: > > > > > From: Ferruh Yigit > > > > > > On 1/9/2020 3:27 PM, Slava Ovsiienko wrote: > > > > > > > From: Ferruh Yigit > > > >

[dpdk-dev] [PATCH v2 2/2] net/axgbe: auto-negotiation support enabled for 1Gbps

2020-01-10 Thread gnandiba
From: Girish Nandibasappa Added CL37 Auto-neg support for 1Gbps interface in axgbe DPDK driver Signed-off-by: Girish Nandibasappa --- drivers/net/axgbe/axgbe_common.h | 1 + drivers/net/axgbe/axgbe_mdio.c | 192 +++-- drivers/net/axgbe/axgbe_phy_impl.c | 37 +++

[dpdk-dev] [PATCH v2 1/2] net/axgbe: 1/2.5Gbps support enabled for axgbe

2020-01-10 Thread gnandiba
From: Girish Nandibasappa Added support for 1Gbps and 2.5Gbps in axgbe dpdk driver Signed-off-by: Girish Nandibasappa --- drivers/net/axgbe/axgbe_phy_impl.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Thomas Monjalon
10/01/2020 13:34, Maxime Coquelin: > On 1/10/20 1:31 PM, Wang, Haiyue wrote: > > From: Thomas Monjalon > >> 10/01/2020 10:07, Matan Azrad: > >>> From: Wang, Haiyue > From: Matan Azrad > >> delete mode 100644 doc/guides/nics/ifc.rst create mode 100644 > >> doc/guides/vdpadevs/feature

Re: [dpdk-dev] [PATCH v7 3/4] net/ixgbe: cleanup Tx buffers

2020-01-10 Thread Ananyev, Konstantin
Hi Chenxu, > hi, Konstantin > > thanks for your opinion, I have fixed almost in new version patch except one. > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Thursday, January 9, 2020 10:02 PM > > To: Di, ChenxuX ; dev@dpdk.org > > Cc: Yang, Qiming ; Di, ChenxuX > > >

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Maxime Coquelin
On 1/10/20 1:31 PM, Wang, Haiyue wrote: >> -Original Message- >> From: Thomas Monjalon >> Sent: Friday, January 10, 2020 17:14 >> To: Wang, Haiyue ; Matan Azrad >> Cc: Maxime Coquelin ; Bie, Tiwei >> ; Wang, Zhihong >> ; Wang, Xiao W ; Yigit, >> Ferruh ; >> dev@dpdk.org; Andrew Rybch

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 10, 2020 17:14 > To: Wang, Haiyue ; Matan Azrad > Cc: Maxime Coquelin ; Bie, Tiwei > ; Wang, Zhihong > ; Wang, Xiao W ; Yigit, Ferruh > ; > dev@dpdk.org; Andrew Rybchenko > Subject: Re: [dpdk-dev] [PATCH v2 3/3] drive

[dpdk-dev] DPDK Release Status Meeting 09/01/2020

2020-01-10 Thread Ferruh Yigit
Minutes 9 January 2020 -- Agenda: * Release Dates * Subtrees * OvS Participants: * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.02 dates: * Integration deadline: Wednesday 15 January 2020 * RC1 is expected befor

Re: [dpdk-dev] [PATCH v2 1/1] test/crypto: fix missing operation status check

2020-01-10 Thread Anoob Joseph
> > This patch adds checking of the symmetric crypto operation status that was > silently skipped before. It fixes the wireless algorithms session creation > (SNOW3G, KASUMI, ZUC) and passing of the digest data for the verification by > PMD. Also fixed the missing aad padding issue revealed after

Re: [dpdk-dev] [PATCH 2/2] net/ena: add support for RX_OFFSET feature

2020-01-10 Thread Ferruh Yigit
On 12/13/2019 1:32 PM, Michal Krawczyk wrote: > From: Maciej Bielski > > Allow the data in the first buffer to be shifted by `pkt_offset` after > the header room. The offset value is provided by `ena_rx_ctx`. > > As part of this update, the version of the ENA was upgraded to v2.0.3. > > Signed-

Re: [dpdk-dev] [PATCH v2 1/2] net/ena: upgrade HAL for new HW features

2020-01-10 Thread Ferruh Yigit
On 1/9/2020 3:39 PM, Michal Krawczyk wrote: > This version of the HAL allows to use the latest HW features, like > rx offsets. > > Driver was adjusted to the new version to fix the build. > > Signed-off-by: Michal Krawczyk > Signed-off-by: Maciej Bielski Applied to dpdk-next-net/master, thanks

Re: [dpdk-dev] [PATCH v7 3/4] net/ixgbe: cleanup Tx buffers

2020-01-10 Thread Di, ChenxuX
hi, Konstantin thanks for your opinion, I have fixed almost in new version patch except one. > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, January 9, 2020 10:02 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > > Subject: RE: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v8 3/4] net/ixgbe: cleanup Tx buffers

2020-01-10 Thread Chenxu Di
Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ixgbe/ixgbe_ethdev.c| 2 + drivers/net/ixgbe/ixgbe_rxtx.c | 109 drivers/net/ixgbe/ixgbe_rxtx.h

[dpdk-dev] [PATCH v8 1/4] net/i40e: cleanup Tx buffers

2020-01-10 Thread Chenxu Di
Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 109 ++

[dpdk-dev] [PATCH v8 2/4] net/ice: cleanup Tx buffers

2020-01-10 Thread Chenxu Di
Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 113 +++ drivers/net/ice/ice_rxtx.h | 5 ++ 3 files c

[dpdk-dev] [PATCH v8 4/4] net/e1000: cleanup Tx buffers

2020-01-10 Thread Chenxu Di
Add support to the igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe

[dpdk-dev] [PATCH v8 0/4] drivers/net: cleanup Tx buffers

2020-01-10 Thread Chenxu Di
Add support to the drivers inclulding i40e, ice, ixgbe and igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. --- v8: deleted function pointer by using other way. v7: changed the design of code, reuse exist function. Chenxu Di (4): net/i40e: cleanup Tx buffe

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-10 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 10, 2020 11:34 > To: Slava Ovsiienko > Cc: Ferruh Yigit ; dev@dpdk.org; Matan Azrad > ; Raslan Darawsheh ; Ori > Kam > Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion > queue > > 10/01/2020 1

[dpdk-dev] [PATCH v4 0/2] add travis ci support for aarch64

2020-01-10 Thread Ruifeng Wang
This patch set is to enable native aarch64 build in Travis CI. It leverages Travis CI multi arch support. As the first step, compilation jobs are added. Unit test is not added for now due to service limitation. We are planning to run unit test with no-huge in future. Plan is to enable the testing

[dpdk-dev] [PATCH v4 2/2] ci: add travis ci support for aarch64

2020-01-10 Thread Ruifeng Wang
Add Travis compilation jobs for aarch64. gcc/clang compilations for static/shared libraries are added. Some limitations for current aarch64 Travis support: 1. Container is used. Huge page is not available due to security reason. 2. Missing kernel header package in Xenial distribution. Solutions t

[dpdk-dev] [PATCH v4 1/2] devtools: add path to additional shared object files

2020-01-10 Thread Ruifeng Wang
Drivers librte_mempool_ring.so and librte_pmd_null.so are loaded by librte_eal.so when running testpmd. In Ubuntu Xenial, driver path is installed to RPATH on testpmd. This allows librte_eal.so to find drivers by using the RPATH. However, in Ubuntu Bionic, driver path is installed to RUNPATH instea

Re: [dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools

2020-01-10 Thread Andrew Rybchenko
On 1/9/20 4:27 PM, Olivier Matz wrote: > When allocating a mempool which is larger than the largest > available area, it can take a lot of time: > > a- the mempool calculate the required memory size, and tries >to allocate it, it fails > b- then it tries to allocate the largest available area

Re: [dpdk-dev] [PATCH v2 1/2] net/ena: upgrade HAL for new HW features

2020-01-10 Thread Michał Krawczyk
pt., 10 sty 2020 o 10:04 Ferruh Yigit napisał(a): > > On 1/9/2020 3:39 PM, Michal Krawczyk wrote: > > This version of the HAL allows to use the latest HW features, like > > rx offsets. > > > > Driver was adjusted to the new version to fix the build. > > > > Signed-off-by: Michal Krawczyk > > Sign

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Looks good to me. Reviewed-by: Ravi Kumar Acked-by: Ravi Kumar Regards, Ravi > >-Original Message- >From: dev On Behalf Of cnamb...@amd.com >Sent: Friday, December 20, 2019 6:13 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH v1]

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-10 Thread Thomas Monjalon
10/01/2020 10:28, Slava Ovsiienko: > From: Thomas Monjalon > > 09/01/2020 17:22, Slava Ovsiienko: > > > From: Ferruh Yigit > > > > On 1/9/2020 3:27 PM, Slava Ovsiienko wrote: > > > > > From: Ferruh Yigit > > > > >> On 1/9/2020 10:56 AM, Viacheslav Ovsiienko wrote: > > > > >>> + assert(

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-10 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 10, 2020 11:07 > To: Slava Ovsiienko > Cc: Ferruh Yigit ; dev@dpdk.org; Matan Azrad > ; Raslan Darawsheh ; Ori > Kam > Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion > queue > > 09/01/2020 1

Re: [dpdk-dev] [PATCH v2 1/7] net/ixgbe: avoid multpile definitions of 'bool'

2020-01-10 Thread Ferruh Yigit
On 1/2/2020 5:48 PM, Dharmik Thakkar wrote: > Compilation issue arises due to multiple definitions of 'bool' > in 'ixgbe_ethdev.h'. > > Error: > '/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c: In function > ‘ixgbe_dev_setup_link_alarm_handler’: > /dpdk/drivers/net/ixgbe/ixgbe_ethdev.c:4075:43: > error: p

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-10 Thread Thomas Monjalon
10/01/2020 03:38, Xu, Rosen: > From: Matan Azrad > > From: Xu, Rosen > > > From: Thomas Monjalon > > > > 09/01/2020 03:27, Xu, Rosen: > > > > > From: Thomas Monjalon > > > > > > 08/01/2020 13:39, Xu, Rosen: > > > > > > > From: Matan Azrad > > > > > > > > From: Xu, Rosen > > > > > > > > > Did y

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

2020-01-10 Thread Iremonger, Bernard
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, January 9, 2020 11:08 PM > To: Iremonger, Bernard ; Zhang, Qi Z > ; dev@dpdk.org; Xing, Beilei > ; Doherty, Declan > Cc: Byrne, Stephen1 ; Zhang, Helin > > Subject: RE: [PATCH v3 6/9] net/i40e: display Flo

Re: [dpdk-dev] [PATCH v3 3/6] doc/api: fix warning with meson build

2020-01-10 Thread Bruce Richardson
On Thu, Jan 09, 2020 at 07:03:05PM +0100, David Marchand wrote: > On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson > wrote: > > > > The install parameter to configure_file is new in 0.50 and generates a > > warning since it is newer than our minimum version of 0.47.1. The > > parameter, however, is

Re: [dpdk-dev] [PATCH v3 5/6] doc/guides: rebuild with meson whenever a file changes

2020-01-10 Thread Bruce Richardson
On Thu, Jan 09, 2020 at 07:06:31PM +0100, David Marchand wrote: > On Thu, Jan 9, 2020 at 7:03 PM David Marchand > wrote: > > > > On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson > > wrote: > > > > > > Add proper support for calling sphinx whenever a file in the doc > > > directory changes. This i

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Thomas Monjalon
10/01/2020 10:07, Matan Azrad: > From: Wang, Haiyue > > From: Matan Azrad > > > > delete mode 100644 doc/guides/nics/ifc.rst create mode 100644 > > > > doc/guides/vdpadevs/features/ifcvf.ini > > > > create mode 100644 doc/guides/vdpadevs/ifc.rst delete mode 100644 > > > > drivers/net/ifc/Makefi

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] > > >-Original Message- >From: Ferruh Yigit >Sent: Thursday, January 9, 2020 8:27 PM >To: dev@dpdk.org; Kumar, Ravi1 >Cc: Namburu, Chandu-babu ; Sebastian, Selwin > >Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] I have reviewed the patch and there are no issues. It can be merged. Regards, Ravi > > >-Original Message- >From: dev On Behalf Of cnamb...@amd.com >Sent: Friday, December 20, 2019 6:13 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

2020-01-10 Thread Matan Azrad
From: Wang, Haiyue > > -Original Message- > > From: dev On Behalf Of Matan Azrad > > Sent: Friday, January 10, 2020 01:26 > > To: Matan Azrad ; Maxime Coquelin > > ; Bie, Tiwei ; Wang, > > Zhihong ; Wang, Xiao W > > > Cc: Yigit, Ferruh ; dev@dpdk.org; Thomas > > Monjalon ; Andrew Rybche

Re: [dpdk-dev] [EXT] Re: [PATCH v4 0/6] OCTEON TX2 End Point Driver

2020-01-10 Thread Mahipal Challa
Hi Jerin, Please see the response inline. > -Original Message- > From: Jerin Jacob > Sent: Friday, January 10, 2020 1:19 PM > To: Mahipal Challa > Cc: dpdk-dev ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Subrahmanyam Nilla ; > Venkateshwarlu Nalla ; Gavin Hu > > Sub

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

2020-01-10 Thread Thomas Monjalon
09/01/2020 17:22, Slava Ovsiienko: > From: Ferruh Yigit > > On 1/9/2020 3:27 PM, Slava Ovsiienko wrote: > > > From: Ferruh Yigit > > >> On 1/9/2020 10:56 AM, Viacheslav Ovsiienko wrote: > > >>> + assert(ci != txq->cq_pi); > > >>> + assert((txq->fcqs[ci & txq->cqe_m] >>

Re: [dpdk-dev] [PATCH v2 1/2] net/ena: upgrade HAL for new HW features

2020-01-10 Thread Ferruh Yigit
On 1/9/2020 3:39 PM, Michal Krawczyk wrote: > This version of the HAL allows to use the latest HW features, like > rx offsets. > > Driver was adjusted to the new version to fix the build. > > Signed-off-by: Michal Krawczyk > Signed-off-by: Maciej Bielski > --- > v2: > * Fix compilation with deb

Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit

2020-01-10 Thread Ferruh Yigit
On 1/9/2020 4:13 PM, Stephen Hemminger wrote: > On Thu, 9 Jan 2020 11:31:30 + > Ferruh Yigit wrote: > >> On 1/9/2020 11:16 AM, Ferruh Yigit wrote: >>> On 1/8/2020 3:28 PM, Stephen Hemminger wrote: On Wed, 8 Jan 2020 09:45:54 + "Iremonger, Bernard" wrote: > Hi Steph

[dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

2020-01-10 Thread Fang TongHao
Hi all,I am from Sangfor Tech.I found a bug when using DPDK in multiprocess scenario.The secondary process enters "rte_eth_dev_pci_copy_info" function when initializing.Then it sets the value of struct "rte_eth_dev_data.dev_flags" to zero, but this struct is shared by primary process and secondary

[dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

2020-01-10 Thread Fang TongHao
Hi all,I am from Sangfor Tech.I found a bug when using DPDK in multiprocess scenario.The secondary process enters "rte_eth_dev_pci_copy_info" function when initializing.Then it sets the value of struct "rte_eth_dev_data.dev_flags" to zero, but this struct is shared by primary process and secondary

  1   2   >