Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

2020-01-06 Thread Matan Azrad
Hi all Any comments? From: Matan Azrad > As discussed and as described in RFC "[RFC] net: new vdpa PMD for Mellanox > devices", new vDPA driver is going to be added for Mellanox devices - vDPA > mlx5 and more. > > The only vDPA driver now is the IFC driver that is located in net directory. > >

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Matan Azrad
From: Suanming Mou > This commit add the IPv4/IPv6 DSCP rewrite actions to the PMD code. > > Supported actions: > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > Signed-off-by: Suanming Mou Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.h| 6 +- >

[dpdk-dev] [PATCH v2 0/2] add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Suanming Mou
For some overlay network, such as VXLAN, the DSCP field in the new outer IP header after VXLAN decapsulation may need to be updated accordingly. This patchset implements the DSCP rewrite action for IPv4 and IPv6 as RFC[1]. [1] https://inbox.dpdk.org/dev/1575955386-6672-1-git-send-email-suanmi...

[dpdk-dev] [PATCH v2 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Suanming Mou
This commit add the IPv4/IPv6 DSCP rewrite actions to the PMD code. Supported actions: RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h| 6 +- drivers/net/mlx5/mlx5_flow_dv.c | 184 ++

[dpdk-dev] [PATCH v2 1/2] ethdev: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Suanming Mou
For some overlay network, such as VXLAN, the DSCP field in the new outer IP header after VXLAN decapsulation may need to be updated accordingly. This commit introduce the DSCP modify action for IPv4 and IPv6. Signed-off-by: Suanming Mou Acked-by: Andrew Rybchenko Acked-by: Ori Kam --- app/tes

Re: [dpdk-dev] [PATCH v3 5/6] raw/octeontx2_ep: add dequeue operation

2020-01-06 Thread Mahipal Challa
Hi Gavin, Please see the response inline. > -Original Message- > From: Gavin Hu > Sent: Tuesday, January 7, 2020 11:13 AM > To: Mahipal Challa ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Subrahmanyam Nilla > ; Venkateshwarlu Nalla ; nd > > Subject:

[dpdk-dev] eventdev fault handling

2020-01-06 Thread Venky Venkatesh
Hi, This concerns eventdev being used in a DPDK multi-process mode wherein the PRIMARY process sets up the device, ports, queues and linkages and the SECONDARY processes are the real workers to which the events are load balanced to via the queues. My question (for both the sw evdev PMD and the DSW

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM

2020-01-06 Thread Anoob Joseph
> -Original Message- > From: Archana Muniganti > Sent: Monday, January 6, 2020 3:03 PM > To: marko.kovace...@intel.com; roy.fan.zh...@intel.com; > akhil.go...@nxp.com > Cc: Sucharitha Sarananaga ; Anoob Joseph > ; Abed Mohammad Kamaluddin > ; Jerin Jacob Kollanukkaran ; > dev@dpdk.org; s

Re: [dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue operation

2020-01-06 Thread Mahipal Challa
Hi Gavin, Please see the response inline. > -Original Message- > From: Gavin Hu > Sent: Tuesday, January 7, 2020 11:26 AM > To: Mahipal Challa ; dev@dpdk.org; Honnappa > Nagarahalli > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Subrahmanyam Nilla > ; Venkateshwarlu

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, January 6, 2020 10:21 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Ath

Re: [dpdk-dev] [PATCH v3 2/6] raw/octeontx2_ep: add device configuration

2020-01-06 Thread Mahipal Challa
Hi Gavin, Please see the response inline. Thanks, Mahipal > -Original Message- > From: Gavin Hu > Sent: Tuesday, January 7, 2020 11:31 AM > To: Mahipal Challa ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Subrahmanyam Nilla > ; Venkateshwarlu Nalla ; nd

Re: [dpdk-dev] [PATCH v2 1/2] ci: add travis ci support for aarch64

2020-01-06 Thread Ruifeng Wang
> -Original Message- > From: dwilder > Sent: Tuesday, January 7, 2020 04:17 > To: Ruifeng Wang > Cc: acon...@redhat.com; maicolgabr...@hotmail.com; > tho...@monjalon.net; ferruh.yi...@intel.com; arybche...@solarflare.com; > dev@dpdk.org; Gavin Hu ; Honnappa Nagarahalli > ; nd > Subject

Re: [dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2020-01-06 Thread Tonghao Zhang
On Mon, Dec 16, 2019 at 2:50 PM Suanming Mou wrote: > > > > -Original Message- > > From: Tonghao Zhang > > Sent: Monday, December 16, 2019 9:29 AM > > To: Matan Azrad ; Shahaf Shuler > > > > Cc: dev@dpdk.org; Suanming Mou > > Subject: Re: [PATCH v2] net/mlx5: avoid crash when meter acti

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Suanming Mou
Hi > -Original Message- > From: Matan Azrad > Sent: Monday, January 6, 2020 10:37 PM > To: Suanming Mou ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam ; > arybche...@solarflare.com; ferruh.yi...@intel.com; Thomas Monjalon > > Subject: RE: [PATCH 2/2] net/mlx5: add IPv4/

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

2020-01-06 Thread Ruifeng Wang
> -Original Message- > From: Aaron Conole > Sent: Monday, January 6, 2020 21:34 > To: Ruifeng Wang > Cc: maicolgabr...@hotmail.com; tho...@monjalon.net; > ferruh.yi...@intel.com; arybche...@solarflare.com; dev@dpdk.org; > david.march...@redhat.com; Gavin Hu ; Honnappa > Nagarahalli ; nd

Re: [dpdk-dev] [PATCH 11/14] examples/ipsec-secgw: add app processing code

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, December 25, 2019 8:49 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju

Re: [dpdk-dev] [PATCH 04/14] examples/ipsec-secgw: add Rx adapter support

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, December 24, 2019 12:18 AM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur D

Re: [dpdk-dev] [PATCH v3 2/6] raw/octeontx2_ep: add device configuration

2020-01-06 Thread Gavin Hu
Hi Mahipal, > -Original Message- > From: Mahipal Challa > Sent: Monday, January 6, 2020 8:07 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com; Gavin Hu > Subject: [dpdk-dev] [PATCH v3 2/6] raw/octeontx2_ep: add device > confi

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

2020-01-06 Thread Honnappa Nagarahalli
> > > + > > > +static __rte_always_inline void > > > +enqueue_elems_128(struct rte_ring *r, uint32_t prod_head, const > > > +void *obj_table, uint32_t n) { unsigned int i; const uint32_t size > > > += r->size; uint32_t idx = prod_head & r->mask; __uint128_t *ring = > > > +(__uint128_t *)&r[1]; con

Re: [dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue operation

2020-01-06 Thread Gavin Hu
Hi Mahipal, > -Original Message- > From: Mahipal Challa > Sent: Monday, January 6, 2020 8:07 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com; Gavin Hu > Subject: [dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue > oper

Re: [dpdk-dev] [PATCH v7 10/17] test/ring: modify single element enq/deq perf test cases

2020-01-06 Thread Honnappa Nagarahalli
> > > > > Add test cases to test rte_ring_xxx_elem APIs for single element > > enqueue/dequeue test cases. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > --- > > app/test/test_ring_perf.c | 100 > > ++ > > 1 file changed, 80 inser

Re: [dpdk-dev] [PATCH v3 5/6] raw/octeontx2_ep: add dequeue operation

2020-01-06 Thread Gavin Hu
Hi Mahipal, Jerin, > -Original Message- > From: Mahipal Challa > Sent: Monday, January 6, 2020 8:07 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com; Gavin Hu > Subject: [dpdk-dev] [PATCH v3 5/6] raw/octeontx2_ep: add dequeue

Re: [dpdk-dev] [PATCH v7 15/17] test/ring: adjust run-on-all-cores perf test cases

2020-01-06 Thread Honnappa Nagarahalli
> > > > > Adjust run-on-all-cores test case to use legacy APIs. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > --- > > app/test/test_ring_perf.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/app/test/test_ring_perf.c b/app/test

Re: [dpdk-dev] [PATCH v7 11/17] test/ring: modify burst enq/deq perf test cases

2020-01-06 Thread Honnappa Nagarahalli
> > > > Add test cases to test legacy and rte_ring_xxx_elem APIs for burst > > enqueue/dequeue test cases. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > --- > > app/test/test_ring_perf.c | 78 > > --- > > 1 file changed, 40 insert

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

2020-01-06 Thread Honnappa Nagarahalli
> > diff --git a/lib/librte_ring/rte_ring_elem.h > > b/lib/librte_ring/rte_ring_elem.h new file mode 100644 index > > 0..fc7fe127c > > --- /dev/null > > +++ b/lib/librte_ring/rte_ring_elem.h > > @@ -0,0 +1,1002 @@ > > + > > +static __rte_always_inline void > > +enqueue_elems_128(struct

Re: [dpdk-dev] [PATCH v7 03/17] test/ring: add functional tests for rte_ring_xxx_elem APIs

2020-01-06 Thread Honnappa Nagarahalli
> Hi Honnappa, Thanks Konstantin for your feedback. > > > Add basic infrastructure to test rte_ring_xxx_elem APIs. Add test > > cases for testing burst and bulk tests. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Gavin Hu > > --- > > app/test/test_ring.c | 466 > > +

Re: [dpdk-dev] [PATCH v3] net/vhost: fix return value of vhost creates not checked

2020-01-06 Thread Tiwei Bie
On Tue, Jan 07, 2020 at 11:25:48AM +0800, Yunjian Wang wrote: > The function eth_dev_vhost_create() could return errors, > the return value need to be checked. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang > --- > v3: >

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2020-01-06 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > On Sat, 21 Dec 2019 16:07:23 + Honnappa Nagarahalli > > > > > > wrote: > > > > > > > > > > > > > Converting these into macros will help remove the size based > > > > > > > duplication > > > > of > > > > > > APIs. I came up with the following macro: > > >

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2020-01-06 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Monday, January 6, 2020 11:16 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > ; Narayana

Re: [dpdk-dev] [PATCH v3 6/6] raw/octeontx2_ep: add driver self test

2020-01-06 Thread Mahipal Challa
Hi Gavin, Please see response inline > -Original Message- > From: Gavin Hu > Sent: Tuesday, January 7, 2020 8:13 AM > To: Mahipal Challa ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Subrahmanyam Nilla > ; Venkateshwarlu Nalla ; nd > > Subject: [EXT] R

[dpdk-dev] [PATCH v3] net/vhost: fix return value of vhost creates not checked

2020-01-06 Thread Yunjian Wang
The function eth_dev_vhost_create() could return errors, the return value need to be checked. Fixes: ee584e9710b9 ("vhost: add driver on top of the library") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v3: * Add newline at the end of the error message v2: * Change function eth_dev_vhos

Re: [dpdk-dev] [PATCH v2] net/vhost: fix return value of vhost creates not checked

2020-01-06 Thread wangyunjian
Thanks, I will fix it in v3. Yunjian > -Original Message- > From: Tiwei Bie [mailto:tiwei@intel.com] > Sent: Tuesday, January 7, 2020 10:32 AM > To: wangyunjian > Cc: dev@dpdk.org; maxime.coque...@redhat.com; zhihong.w...@intel.com; > xudingke ; sta...@dpdk.org > Subject: Re: [PATCH v

Re: [dpdk-dev] [PATCH v3 6/6] raw/octeontx2_ep: add driver self test

2020-01-06 Thread Gavin Hu
Hi Mahipal, > -Original Message- > From: Mahipal Challa > Sent: Monday, January 6, 2020 8:07 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com; Gavin Hu > Subject: [dpdk-dev] [PATCH v3 6/6] raw/octeontx2_ep: add driver self te

Re: [dpdk-dev] [PATCH v2] net/vhost: fix return value of vhost creates not checked

2020-01-06 Thread Tiwei Bie
On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote: > > - eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node, > - flags, disable_flags); > + ret = eth_dev_vhost_create(dev, iface_name, queues, > +dev->device.numa_node,

Re: [dpdk-dev] [PATCH v3] net/i40e: fix TSO pkt exceeds allowed buf size issue

2020-01-06 Thread Ye Xiaolong
On 12/26, Xiaoyun Li wrote: >Hardware limits that max buffer size per tx descriptor should be >(16K-1)B. So when TSO enabled, the mbuf data size may exceed the >limit and cause malicious behavior to the NIC. This patch fixes >this issue by using more tx descs for this kind of large buffer. > >Fixes

Re: [dpdk-dev] [PATCH] vhost: fix socket initial value

2020-01-06 Thread Tiwei Bie
On Fri, Jan 03, 2020 at 01:36:21PM -0500, Xiao Wang wrote: > By default, a vhost socket is created without attaching VDPA device, > this patch fixes the initial value of vdpa_dev_id. > > Fixes: b4953225cea4 ("vhost: add APIs for datapath configuration") > Cc: sta...@dpdk.org > > Signed-off-by: Xi

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio_user: do not close invalid file descriptor

2020-01-06 Thread Tiwei Bie
On Mon, Jan 06, 2020 at 11:18:37AM -0800, Stephen Hemminger wrote: > Valgrind complains that virtio_user is calling close(-1). > Fix this by adding check in virtio that is similar to existing code. > > Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer") > Cc: jianfeng@intel.com

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2020-01-06 Thread Stephen Hemminger
On Tue, 7 Jan 2020 00:44:51 + Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > On Sat, 21 Dec 2019 16:07:23 + Honnappa Nagarahalli > > > > > wrote: > > > > > > > > > > > Converting these into macros will help remove the size based > > > > > > duplication > > > of > >

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2020-01-06 Thread Honnappa Nagarahalli
> > > > > > > > > > > On Sat, 21 Dec 2019 16:07:23 + Honnappa Nagarahalli > > > > wrote: > > > > > > > > > Converting these into macros will help remove the size based > > > > > duplication > > of > > > > APIs. I came up with the following macro: > > > > > > > > > > #define RTE_GET_BIT(nr, v

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2020-01-06 Thread Honnappa Nagarahalli
> > > > > > > > On Sat, 21 Dec 2019 16:07:23 + > > > Honnappa Nagarahalli wrote: > > > > > > > Converting these into macros will help remove the size based > duplication of > > > APIs. I came up with the following macro: > > > > > > > > #define RTE_GET_BIT(nr, var, ret, memorder) \ ({ \ > > >

[dpdk-dev] [PATCH v3 2/7] net/bnxt: fix to use first valid profile

2020-01-06 Thread Ajit Khaparde
From: Somnath Kotur In the case when CoS classification is disabled, driver was iterating looking for only lossy profiles as that is what is expected to be used for regular NIC operations. But in certain custom profiles, there were no lossy profiles configured, only lossless profiles instead. To

[dpdk-dev] [PATCH v3 6/7] net/bnxt: add support for flow mark action

2020-01-06 Thread Ajit Khaparde
Add support for RTE_FLOW_ACTION_TYPE_MARK. Use the flow_id provided by FW during flow creation to lookup the mark id provided by the application. Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt.h| 5 +++ drivers/net/bnxt/bnxt_ethdev.c | 16 -

[dpdk-dev] [PATCH v3 1/7] net/bnxt: fix link failure during port toggle

2020-01-06 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur We need to wait for up to 500ms to receive async event notification after forcing link down. Similarly we need to wait for up to 10s for link to come up after configuring the hardware for link up. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update op

[dpdk-dev] [PATCH v3 7/7] net/bnxt: fix to not overwrite error message

2020-01-06 Thread Ajit Khaparde
In some cases when flow creation fails, we overwrite the specific error message with a generic error message. This patch fixes it. Fixes: d24610f7bfda ("net/bnxt: allow flow creation when RSS is enabled") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drive

[dpdk-dev] [PATCH v3 5/7] net/bnxt: fix to reuse an L2 filter

2020-01-06 Thread Ajit Khaparde
From: Somnath Kotur The software L2 filter was being released back to the free pool, though it was created in HW and the filter corresponding to an actual 'flow' would have reference to the HW L2 filter. But if this 'flow were to be deleted, then this HW L2 filter also would be gone. Fix this by

[dpdk-dev] [PATCH v3 3/7] net/bnxt: fix flow flush to sync with flow destroy

2020-01-06 Thread Ajit Khaparde
From: Somnath Kotur Sync flow flush routine with flow destroy so that the operations performed per flow during a flush are the same as that are done for an individual flow destroy by having a common function to call for both. One of the things that was missed in the flow flush routine was the del

[dpdk-dev] [PATCH v3 4/7] net/bnxt: fix non matching flow hitting filter rule

2020-01-06 Thread Ajit Khaparde
From: Santoshkumar Karanappa Rastapur As part of ntuple filter, we were creating L2 filter with the ntuple redirect queue resulting in any L2 matching flow getting steered to this queue. For ntuple filters, we need to create the L2 filter with default queue. The user specified redirect queue will

[dpdk-dev] [PATCH v3 0/7] bnxt patchset

2020-01-06 Thread Ajit Khaparde
v2->v3: - Rebased patches against latest dpdk-next-net - sync commit logs Ajit Khaparde (2): net/bnxt: add support for flow mark action net/bnxt: fix to not overwrite error message Santoshkumar Karanappa Rastapur (2): net/bnxt: fix link failure during port toggle net/bnxt: fix non match

[dpdk-dev] C++ app does not execute DPDK constructors.

2020-01-06 Thread Sachin Jain
Hi *What am I trying to do?* I am trying to write Gtests for my application based on DPDK. *Details about the app:* The application compiles dpdk as static library. Its a pretty simple. For now it just runs a dummy Gtest and create a memory pool. The key is, its a C++ file. I see no issue if it

[dpdk-dev] [Bug 381] hugepages not detached on cleanup

2020-01-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=381 Bug ID: 381 Summary: hugepages not detached on cleanup Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Prio

[dpdk-dev] [Bug 380] memory subsystem leaks file descriptors

2020-01-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=380 Bug ID: 380 Summary: memory subsystem leaks file descriptors Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH] mem: fix incorrect munmap in error unwind

2020-01-06 Thread Stephen Hemminger
The loop to unwind existing mmaps was only unmapping the first segment. Also, remove obvious redundant assignment. Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal_me

Re: [dpdk-dev] [PATCH v2 1/2] ci: add travis ci support for aarch64

2020-01-06 Thread dwilder
On 2019-12-20 01:37, Ruifeng Wang wrote: Add Travis compilation jobs for aarch64. gcc/clang compilations for static/shared libraries are added. Some limitations for current aarch64 Travis support: 1. Container is used. Huge page is not available due to security reason. 2. Missing kernel header

[dpdk-dev] [PATCH] net/virtio_user: do not close invalid file descriptor

2020-01-06 Thread Stephen Hemminger
Valgrind complains that virtio_user is calling close(-1). Fix this by adding check in virtio that is similar to existing code. Fixes: 37a7eb2ae816 ("net/virtio-user: add device emulation layer") Cc: jianfeng@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/virti

Re: [dpdk-dev] [EXT] [PATCH 2/2] examples/l3fwd: support multiple queues in event mode

2020-01-06 Thread Nipun Gupta
> -Original Message- > From: Sunil Kumar Kori > Sent: Monday, January 6, 2020 11:39 AM > To: Nipun Gupta ; dev@dpdk.org > Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; Hemant Agrawal > ; Akhil Goyal ; > marko.kovace...@intel.com; or...@mellanox.com; > bruce.richard...@

Re: [dpdk-dev] [PATCH 12/14] examples/ipsec-secgw: add driver outbound worker

2020-01-06 Thread Ananyev, Konstantin
> > > This patch adds the driver outbound worker thread for ipsec-secgw. > > > In this mode the security session is a fixed one and sa update is not > > > done. > > > > > > Signed-off-by: Ankur Dwivedi > > > Signed-off-by: Anoob Joseph > > > Signed-off-by: Lukasz Bartosik > > > --- > > > exampl

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-06 Thread Ananyev, Konstantin
> > > Add eventmode support to ipsec-secgw. This uses event helper to setup > > > and use the eventmode capabilities. Add driver inbound worker. > > > > > > Example command: > > > ./ipsec-secgw -c 0x1 -w 0002:02:00.0,ipsec_in_max_spi=100 -w > > > 0002:07:00.0 -w 0002:0e:00.0 -w 0002:10:00.1 -- -P

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-06 Thread Ananyev, Konstantin
> > > Add eventmode support to ipsec-secgw. This uses event helper to setup > > > and use the eventmode capabilities. Add driver inbound worker. > > > > > > Example command: > > > ./ipsec-secgw -c 0x1 -w 0002:02:00.0,ipsec_in_max_spi=100 -w > > > 0002:07:00.0 -w 0002:0e:00.0 -w 0002:10:00.1 -- -P

Re: [dpdk-dev] [PATCH] maintainers: add co-maintainer for flow API

2020-01-06 Thread Ferruh Yigit
On 1/6/2020 10:37 AM, Adrien Mazarguil wrote: > On Sun, Dec 29, 2019 at 08:56:58AM +, Ori Kam wrote: >> I volunteer to be co maintainer for the rte_flow lib. >> >> Signed-off-by: Ori Kam > > Welcome :) > > Acked-by: Adrien Mazarguil > We need help on rte_flow, thank for volunteering Ori!

Re: [dpdk-dev] [PATCH 14/14] examples/ipsec-secgw: add cmd line option for bufs

2020-01-06 Thread Ananyev, Konstantin
> > > > Add command line option -s which can be used to configure number of > > > > buffers in a pool. Default number of buffers is 8192. > > > > > > > > Signed-off-by: Anoob Joseph > > > > Signed-off-by: Lukasz Bartosik > > > > --- > > > > examples/ipsec-secgw/ipsec-secgw.c | 23 +++

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM

2020-01-06 Thread Archana Muniganti
Hi Akhil, Please see inline. Thanks, Archana > -Original Message- > From: Akhil Goyal > Sent: Monday, January 6, 2020 3:09 PM > To: Archana Muniganti ; > marko.kovace...@intel.com; roy.fan.zh...@intel.com > Cc: Sucharitha Sarananaga ; Anoob Joseph > ; Abed Mohammad Kamaluddin > ; Jerin

[dpdk-dev] [PATCH v1 1/1] config: add Broadcom Stingray for meson cross-compilation

2020-01-06 Thread Qingmin Liu
Broadcom Stingray is armv8 CPU having cortex-a72. The implementor ID is 0x41 (arm) and the primary part number is 0xd08 (cortex-a72). Signed-off-by: Qingmin Liu --- config/arm/arm64_stingray_linux_gcc | 17 + 1 file changed, 17 insertions(+) create mode 100644 config/arm/arm64_s

[dpdk-dev] [PATCH v1 0/1] Add Broadcom Stingray for meson cross-compilation

2020-01-06 Thread Qingmin Liu
Add Broadcom Stingray meson config support. Qingmin Liu (1): config: add Broadcom Stingray for meson cross-compilation config/arm/arm64_stingray_linux_gcc | 17 + 1 file changed, 17 insertions(+) create mode 100644 config/arm/arm64_stingray_linux_gcc -- 2.21.0

[dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM

2020-01-06 Thread Archana Muniganti
From: Sucharitha Sarananaga Cipher length need to be updated in case of AES-GCM decryption. Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") Signed-off-by: Archana Muniganti Signed-off-by: Sucharitha Sarananaga --- examples/fips_validation/fips_validation_gcm.c | 2 ++ 1

Re: [dpdk-dev] [PATCH v2 02/12] net/ice/base: support MAC/VLAN with TCP/UDP in switch

2020-01-06 Thread Patil, Kiran
ACK -Original Message- From: Zhang, Qi Z Sent: Sunday, January 5, 2020 7:39 PM To: Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Patil, Kiran ; Stillwell Jr, Paul M Subject: [PATCH v2 02/12] net/ice/base: support MAC/VLAN with TCP/UDP in switch Add a feature to allow u

Re: [dpdk-dev] [PATCH v2 09/12] net/ice/base: change fdir desc preparation

2020-01-06 Thread Patil, Kiran
ACK -Original Message- From: Zhang, Qi Z Sent: Sunday, January 5, 2020 7:39 PM To: Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Patil, Kiran ; Stillwell Jr, Paul M Subject: [PATCH v2 09/12] net/ice/base: change fdir desc preparation Change internal implemenatation of

Re: [dpdk-dev] [PATCH] net/mlx5: fix default mark copy flow

2020-01-06 Thread Matan Azrad
From: Viacheslav Ovsiienko > In extensive metadata mode the MARK copy table is engaged, if the > application creates the flow with zero MARK ID action: > > flow create 1 ingress pattern eth / ... / end actions mark id 0 / .. end > > And then destroys that, the traffic to the port stops. This h

Re: [dpdk-dev] [PATCH] net/mlx5: fix legacy inline multi-packet performance

2020-01-06 Thread Matan Azrad
From: Viacheslav Ovsiienko > The legacy multi-packet write is the feature allowing to put multiple packets > into one transmitting descriptor, this feature is supported by only NIC > ConnectX-4LX. > The number of packets should be limited to provide optimal size descriptor > and better performan

Re: [dpdk-dev] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

2020-01-06 Thread Matan Azrad
From: Viacheslav Ovsiienko > The tx_burst routine supporting multi-segment packets with legacy MPW > and without inline was missed, and there was no valid selection for these > options, patch adds the missing routine. > > Fixes: 82e75f8323bf ("net/mlx5: fix legacy multi-packet Tx descriptors")

Re: [dpdk-dev] [PATCH] net/mlx5: fix matcher metadata register c0 field setup

2020-01-06 Thread Matan Azrad
From: Viacheslav Ovsiienko > The metadata register c0 field in the matcher might be split into two > independent fields - the source vport index and META item value. These > fields have no permanent assigned bits, the configuration is queried from the > kernel drivers. > > MLX5_SET configures t

Re: [dpdk-dev] [PATCH] net/mlx5: fix register c0 usage for metadata entities

2020-01-06 Thread Matan Azrad
From: Viacheslav Ovsiienko > The register c0 might be engaged to support META and MARK related items > and actions. Also, this register might be used by kernel to specify the source > vport index. The register c0 is split into two 16-bit fields. Depending on the > mask returned by kernel the PMD

Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata item endianness conversion

2020-01-06 Thread Matan Azrad
From: Viacheslav Ovsiienko > The metadata register c0 field in the matcher might be split into two > independent fields - the source vport index and META item value. These > fields have no permanent assigned bits, the configuration is queried from the > kernel drivers. > > It means the metadata

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: add IPv4/IPv6 DSCP rewrite action

2020-01-06 Thread Matan Azrad
Hi From: Suanming Mou > This commit add the IPv4/IPv6 DSCP rewrite actions to the PMD code. > > Supported actions: > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > Signed-off-by: Suanming Mou > --- > drivers/net/mlx5/mlx5_flow.h| 6 +- > drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

2020-01-06 Thread Aaron Conole
Ruifeng Wang writes: > Add Travis compilation jobs for aarch64. gcc/clang compilations for > static/shared libraries are added. > > Some limitations for current aarch64 Travis support: > 1. Container is used. Huge page is not available due to security reason. > 2. Missing kernel header package in

Re: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers

2020-01-06 Thread Ananyev, Konstantin
> > > > > + * tx_tail is the last sent packet on the sw_ring. Goto the end > > > > > + * of that packet (the last segment in the packet chain) and > > > > > + * then the next segment will be the start of the oldest segment > > > > > + * in the sw_ring. > > > > > > > > Not sure I understand the se

Re: [dpdk-dev] [PATCH v6 00/11] Add ABI compatibility checks to the meson build

2020-01-06 Thread Aaron Conole
Bruce Richardson writes: > On Fri, Dec 20, 2019 at 02:19:13PM +0100, David Marchand wrote: >> On Fri, Dec 20, 2019 at 12:04 PM Bruce Richardson >> wrote: >> > > For maintainers that integrate patches or developers that get a CI >> > > failure and want to fix it, we would need to help them to: >>

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-06 Thread Aaron Conole
Thomas Monjalon writes: > 20/12/2019 17:20, Kinsella, Ray: >> > -Original Message- >> > From: Richardson, Bruce >> > Sent: Friday 20 December 2019 15:32 >> > To: David Marchand ; dev@dpdk.org >> > Cc: tho...@monjalon.net; Laatz, Kevin ; >> > acon...@redhat.com; nhor...@tuxdriver.com; Mic

Re: [dpdk-dev] [PATCH v2 01/11] examples/l3fwd: add framework for event device

2020-01-06 Thread Ananyev, Konstantin
> >> +struct l3fwd_event_resources { > >> + uint8_t sched_type; > >> + uint8_t enabled; > >> + uint8_t nb_args; > >> + char **args; > >> +}; > >> + > >> +static inline struct l3fwd_event_resources * > >> +l3fwd_get_eventdev_rsrc(void) > >> +{ > >> + static const char name[RTE_MEMZONE_NAMESIZE]

Re: [dpdk-dev] [PATCH v2 09/11] examples/l3fwd: add event em main loop

2020-01-06 Thread Ananyev, Konstantin
> > >> Add em main loop for handling events based on capabilities of the > >> event device. > >> > >> Signed-off-by: Pavan Nikhilesh > >> --- > >> examples/l3fwd/l3fwd.h | 10 ++ > >> examples/l3fwd/l3fwd_em.c| 177 > >+++ > >> examples/l3fwd/l3

Re: [dpdk-dev] [PATCH v2 10/11] examples/l3fwd: add graceful teardown for eventdevice

2020-01-06 Thread Ananyev, Konstantin
> >> Add graceful teardown that addresses both event mode and poll > >mode. > >> > >> Signed-off-by: Pavan Nikhilesh > >> --- > >> examples/l3fwd/main.c | 49 ++- > > > >> 1 file changed, 34 insertions(+), 15 deletions(-) > >> > >> diff --git a/examples/l3

[dpdk-dev] [PATCH v3 5/6] raw/octeontx2_ep: add dequeue operation

2020-01-06 Thread Mahipal Challa
Add rawdev dequeue operation for SDP VF devices. Signed-off-by: Mahipal Challa --- drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 197 ++ drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h | 2 + drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 1 + drivers/raw/octeontx2_ep/otx2_e

[dpdk-dev] [PATCH v3 6/6] raw/octeontx2_ep: add driver self test

2020-01-06 Thread Mahipal Challa
Add rawdev's selftest feature in SDP VF driver, which verifies the EP mode functionality test. Signed-off-by: Mahipal Challa --- doc/guides/rawdevs/octeontx2_ep.rst | 13 +++ drivers/raw/octeontx2_ep/Makefile | 1 + drivers/raw/octeontx2_ep/meson.build | 1 + drivers/raw/

[dpdk-dev] [PATCH v3 4/6] raw/octeontx2_ep: add enqueue operation

2020-01-06 Thread Mahipal Challa
Add rawdev enqueue operation for SDP VF devices. Signed-off-by: Mahipal Challa --- doc/guides/rawdevs/octeontx2_ep.rst | 6 + drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 242 ++ drivers/raw/octeontx2_ep/otx2_ep_enqdeq.h | 39 + drivers/raw/octeontx2_ep/ot

[dpdk-dev] [PATCH v3 2/6] raw/octeontx2_ep: add device configuration

2020-01-06 Thread Mahipal Challa
Register "dev_configure" API to configure/initialize the SDP VF PCIe devices. Signed-off-by: Mahipal Challa --- doc/guides/rawdevs/octeontx2_ep.rst| 29 ++ drivers/common/octeontx2/hw/otx2_sdp.h | 184 + drivers/common/octeontx2/otx2_common.c |

[dpdk-dev] [PATCH v3 3/6] raw/octeontx2_ep: add device uninitialization

2020-01-06 Thread Mahipal Challa
Add rawdev close/uninitialize operation for SDP VF devices. Signed-off-by: Mahipal Challa --- drivers/raw/octeontx2_ep/otx2_ep_enqdeq.c | 111 ++ drivers/raw/octeontx2_ep/otx2_ep_rawdev.c | 78 + drivers/raw/octeontx2_ep/otx2_ep_rawdev.h | 8 +++

[dpdk-dev] [PATCH v3 1/6] raw/octeontx2_ep: add build infra and device probe

2020-01-06 Thread Mahipal Challa
Add the OCTEON TX2 SDP EP device probe along with the build infrastructure for Make and meson builds. Signed-off-by: Mahipal Challa --- MAINTAINERS| 5 + config/common_base | 5 + doc/guides/rawdevs/index.rst

[dpdk-dev] [PATCH v3 0/6] OCTEON TX2 End Point Driver

2020-01-06 Thread Mahipal Challa
This patchset adds support for OCTEON TX2 end point mode of operation. The driver implementation uses DPDK rawdevice sub-system. v2: * Updated memory barrior API's as per Gavin Hu suggestion. v3: * Fixed memory leak possibility issues. Mahipal Challa (6): raw/octeontx2_ep: add build infra and

Re: [dpdk-dev] [PATCH] maintainers: add co-maintainer for flow API

2020-01-06 Thread Adrien Mazarguil
On Sun, Dec 29, 2019 at 08:56:58AM +, Ori Kam wrote: > I volunteer to be co maintainer for the rte_flow lib. > > Signed-off-by: Ori Kam Welcome :) Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

[dpdk-dev] Fwd: How to check the packets dropped by RED in DPDK?

2020-01-06 Thread Gokul Bargaje
Correcting the 'packet drop' mentioned in the previous mail. Hi All, I am running the qos_sched sample application to see the RED packet drop. I am generating the traffic and sending the traffic via qos_sched application. As a result, 1. The application is showing the packet drop which is so high

[dpdk-dev] Fwd: How to check the packets dropped by RED in DPDK?

2020-01-06 Thread Gokul Bargaje
Hi All, I am running the qos_sched sample application to see the RED packet drop. I am generating the traffic and sending the traffic via qos_sched application. As a result, 1. The application is showing the packet drop which is so high as shown in the below figure. 2. How to determine that the pa

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM

2020-01-06 Thread Akhil Goyal
> From: Sucharitha Sarananaga > > Cipher length need to be updated in case of AES-GCM decryption. > > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") > > Signed-off-by: Archana Muniganti > Signed-off-by: Sucharitha Sarananaga > --- > examples/fips_validation/fips_valida

Re: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers

2020-01-06 Thread Di, ChenxuX
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, January 6, 2020 7:36 AM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Yang, Qiming > Subject: RE: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers > > > > > > Add support to the ixgbe driver for the API > > > > rte_eth_t

Re: [dpdk-dev] [RFC PATCH] mbuf: fix to update documentation of PKT_RX_QINQ_STRIPPED

2020-01-06 Thread Somnath Kotur
On Thu, Jan 2, 2020 at 6:35 PM Andrew Rybchenko wrote: > > Somnath, > > On 12/31/19 5:15 AM, Somnath Kotur wrote: > > Andrew, > > > > On Tue, Dec 24, 2019 at 3:23 PM Andrew Rybchenko > > wrote: > >> On 12/24/19 6:16 AM, Somnath Kotur wrote: > >>> Given that we haven't heard any objection from any

[dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation

2020-01-06 Thread Somnath Kotur
Certain hardware may be able to strip and/or save only the outermost VLAN instead of both the VLANs in the mbuf in a QinQ scenario. To handle such cases, we could re-interpret setting of just PKT_RX_QINQ_STRIPPED to indicate that only the outermost VLAN has been stripped and saved in mbuf->vlan_tci

[dpdk-dev] [PATCH v6] eal: add manual probing option

2020-01-06 Thread pbhagavatula
From: Gaetan Rivet Add a new EAL option enabling manual probing in the EAL. This command line option will configure the EAL so that buses will not trigger their probe step on their own. Applications are then expected to hotplug devices as they see fit. Devices declared on the command line by th