Thanks, I will fix it in v3.
Yunjian > -----Original Message----- > From: Tiwei Bie [mailto:tiwei....@intel.com] > Sent: Tuesday, January 7, 2020 10:32 AM > To: wangyunjian <wangyunj...@huawei.com> > Cc: dev@dpdk.org; maxime.coque...@redhat.com; zhihong.w...@intel.com; > xudingke <xudin...@huawei.com>; sta...@dpdk.org > Subject: Re: [PATCH v2] net/vhost: fix return value of vhost creates not > checked > > On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote: > > > > - eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node, > > - flags, disable_flags); > > + ret = eth_dev_vhost_create(dev, iface_name, queues, > > + dev->device.numa_node, flags, disable_flags); > > + if (ret == -1) > > + VHOST_LOG(ERR, "Failed to create %s", name); > > A newline is needed at the end of the error message. > Other than that, > > Reviewed-by: Tiwei Bie <tiwei....@intel.com>
