[dpdk-dev] [PATCH] net/mlx5: fix register c0 usage for metadata entities

2019-12-19 Thread Viacheslav Ovsiienko
The register c0 might be engaged to support META and MARK related items and actions. Also, this register might be used by kernel to specify the source vport index. The register c0 is split into two 16-bit fields. Depending on the mask returned by kernel the PMD can use upper or lower half of regist

[dpdk-dev] [PATCH] net/mlx5: fix matcher metadata register c0 field setup

2019-12-19 Thread Viacheslav Ovsiienko
The metadata register c0 field in the matcher might be split into two independent fields - the source vport index and META item value. These fields have no permanent assigned bits, the configuration is queried from the kernel drivers. MLX5_SET configures the specified 32-bit field as whole entity.

[dpdk-dev] [PATCH] doc: basic update for ice

2019-12-19 Thread Xiaolong Ye
The ice PMD supports 10/25/50/100 Gbps. Signed-off-by: Xiaolong Ye --- doc/guides/nics/ice.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 9b90b389e..cde3fd620 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/ni

Re: [dpdk-dev] [PATCH v1] net/ice: add new device IDs

2019-12-19 Thread Xu, Ting
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 19, 2019 8:14 PM > To: Ye, Xiaolong ; Xu, Ting > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: add new device IDs > > On 12/19/2019 2:43 AM, Ye Xiaolong w

[dpdk-dev] [PATCH v6 2/2] common/octeontx2: add polling based response mbox message

2019-12-19 Thread Sunil Kumar Kori
Currently otx2_mbox_get_rsp_xxx get response once AF driver interrupts after completion. But this funciton will get into deadlock if called in another interrupt context. To avoid it, implemented another version of this function which polls on dedicated memory for a given timeout. Also after clear

[dpdk-dev] [PATCH v6 1/2] eal: add API to check if its interrupt context

2019-12-19 Thread Sunil Kumar Kori
From: Harman Kalra Added an API to check if current execution is in interrupt context. This will be helpful to handle nested interrupt cases. Signed-off-by: Harman Kalra Signed-off-by: Sunil Kumar Kori --- v6: - No changes. v5: - Fix shared library compilation error v4: - No changes. v3: -

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 12:02 PM Gavin Hu wrote: > > Hi Jerin, Hi Gavin, > > > > > > > > > > > > The peripheral coherence order for a memory-mapped peripheral > > > > signifies the > > > > > > order in which accesses arrive at the endpoint. For a read or a > > > > > > write > > > > RW1 > > >

Re: [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs

2019-12-19 Thread Honnappa Nagarahalli
Hi Joyce, These APIs seem to be written considering the PMD requirements. Is there a need to expose these to applications (external to DPDK?). > -Original Message- > From: Joyce Kong > Sent: Wednesday, December 18, 2019 12:00 AM > To: tho...@monjalon.net; step...@networkplumber.o

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Gavin Hu
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Friday, December 20, 2019 12:34 PM > To: Gavin Hu > Cc: dpdk-dev ; nd ; David Marchand > ; tho...@monjalon.net; > rasl...@mellanox.com; maxime.coque...@redhat.com; > tiwei@intel.com; hemant.agra...@nxp.com; jer...@marvell.com

[dpdk-dev] [PATCH v7 11/17] test/ring: modify burst enq/deq perf test cases

2019-12-19 Thread Honnappa Nagarahalli
Add test cases to test legacy and rte_ring_xxx_elem APIs for burst enqueue/dequeue test cases. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 78 --- 1 file changed, 40 insertions(+), 38 deletions(-) diff --git a/ap

[dpdk-dev] [PATCH v7 16/17] lib/hash: use ring with 32b element size to save memory

2019-12-19 Thread Honnappa Nagarahalli
The freelist and external bucket indices are 32b. Using rings that use 32b element sizes will save memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_hash/rte_cuckoo_hash.c | 97 --- lib/librte_hash/rte_cuckoo

[dpdk-dev] [PATCH v7 14/17] test/ring: modify multi-lcore perf test cases

2019-12-19 Thread Honnappa Nagarahalli
Modify test cases to test the performance of legacy and rte_ring_xxx_elem APIs for multi lcore scenarios. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 175 +- 1 file changed, 115 insertions(+), 60 deletions(-) dif

[dpdk-dev] [PATCH v7 09/17] test/ring: removed unused variable synchro

2019-12-19 Thread Honnappa Nagarahalli
Remove unused variable synchro Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 4 1 file changed, 4 deletions(-) diff --git a/app/test/test_ring.c b/app/test/test_ring.c index a082f0137..57fbd897c 100644 --- a/app/test/test_ring.c +++ b/app/test/test_r

[dpdk-dev] [PATCH v7 10/17] test/ring: modify single element enq/deq perf test cases

2019-12-19 Thread Honnappa Nagarahalli
Add test cases to test rte_ring_xxx_elem APIs for single element enqueue/dequeue test cases. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 100 ++ 1 file changed, 80 insertions(+), 20 deletions(-) diff --git a/app/

[dpdk-dev] [PATCH v7 08/17] test/ring: remove duplicate test cases

2019-12-19 Thread Honnappa Nagarahalli
The test cases in the function test_ring_basic are already covered by the function test_ring_burst_bulk_tests and others. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 218 --- 1 file changed, 218 deletions(-) diff

[dpdk-dev] [PATCH v7 15/17] test/ring: adjust run-on-all-cores perf test cases

2019-12-19 Thread Honnappa Nagarahalli
Adjust run-on-all-cores test case to use legacy APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c index b893b5779..fb95e4f2

[dpdk-dev] [PATCH v7 17/17] lib/eventdev: use custom element size ring for event rings

2019-12-19 Thread Honnappa Nagarahalli
Use custom element size ring APIs to replace event ring implementation. This avoids code duplication. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- lib/librte_eventdev/rte_event_ring.c | 147 ++- lib/librte_eventdev/rte_event_r

[dpdk-dev] [PATCH v7 12/17] test/ring: modify bulk enq/deq perf test cases

2019-12-19 Thread Honnappa Nagarahalli
Modify test cases to test legacy and rte_ring_xxx_elem APIs for bulk enqueue/dequeue test cases. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 57 ++- 1 file changed, 14 insertions(+), 43 deletions(-) diff --git a/

[dpdk-dev] [PATCH v7 13/17] test/ring: modify bulk empty deq perf test cases

2019-12-19 Thread Honnappa Nagarahalli
Modify test cases to test legacy and rte_ring_xxx_elem APIs for empty bulk dequeue test cases. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring_perf.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/app

[dpdk-dev] [PATCH v7 01/17] test/ring: use division for cycle count calculation

2019-12-19 Thread Honnappa Nagarahalli
Use division instead of modulo operation to calculate more accurate cycle count. Signed-off-by: Honnappa Nagarahalli Acked-by: Olivier Matz --- app/test/test_ring_perf.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/app/test/test_ring_perf.c b/app/

[dpdk-dev] [PATCH v7 07/17] test/ring: negative test cases for rte_ring_xxx_elem APIs

2019-12-19 Thread Honnappa Nagarahalli
All the negative test cases are consolidated into a single function. This provides the ability to add test cases for rte_ring_xxx_elem APIs easily. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 176 ++- 1 file change

[dpdk-dev] [PATCH v7 03/17] test/ring: add functional tests for rte_ring_xxx_elem APIs

2019-12-19 Thread Honnappa Nagarahalli
Add basic infrastructure to test rte_ring_xxx_elem APIs. Add test cases for testing burst and bulk tests. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 466 --- app/test/test_ring.h | 203 +++ 2 files

[dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

2019-12-19 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

[dpdk-dev] [PATCH v7 05/17] test/ring: add default, single element test cases

2019-12-19 Thread Honnappa Nagarahalli
Add default, single element test cases for rte_ring_xxx_elem APIs. The burst APIs are kept as is since they are being tested with a ring created with SP/SC flags. They are further enhanced with bulk APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 129 +

[dpdk-dev] [PATCH v7 04/17] test/ring: test burst APIs with random empty-full test case

2019-12-19 Thread Honnappa Nagarahalli
The random empty-full test case should be tested with burst APIs as well. Hence the test case is consolidated in test_ring_burst_bulk_tests function. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 91 +--- 1 file chan

[dpdk-dev] [PATCH v7 06/17] test/ring: rte_ring_xxx_elem test cases for exact size ring

2019-12-19 Thread Honnappa Nagarahalli
Test cases for the exact size ring are changed to test rte_ring_xxx_elem APIs. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_ring.c | 147 ++- 1 file changed, 89 insertions(+), 58 deletions(-) diff --git a/app/test/test_ring

[dpdk-dev] [PATCH v7 00/17] lib/ring: APIs to support custom element size

2019-12-19 Thread Honnappa Nagarahalli
The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 9:49 AM Gavin Hu wrote: > > Hi Jerin, > > Thanks for review, inline comments, > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, December 20, 2019 11:38 AM > > To: Gavin Hu > > Cc: dpdk-dev ; nd ; David Marchand > > ; tho...@monjalon.net; > > rasl...

Re: [dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2019-12-19 Thread Gavin Hu
Series-reviewed-by: Gavin Hu

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Gavin Hu
Hi Jerin, Thanks for review, inline comments, > -Original Message- > From: Jerin Jacob > Sent: Friday, December 20, 2019 11:38 AM > To: Gavin Hu > Cc: dpdk-dev ; nd ; David Marchand > ; tho...@monjalon.net; > rasl...@mellanox.com; maxime.coque...@redhat.com; > tiwei@intel.com; hema

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-19 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 8:56 AM Gavin Hu wrote: > > Hi Jerin, > > It got two coding style warnings, otherwise, > Reviewed-by: Gavin Hu Thanks Gavin for review. Since the existing code is using "unsigned" in that file, I thought of not change by this patch. If someone thinks, It is better to chan

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 9:03 AM Jerin Jacob wrote: > > On Fri, Dec 20, 2019 at 8:40 AM Gavin Hu wrote: > > > > Armv8's peripheral coherence order is a total order on all reads and writes > > to that peripheral.[1] > > > > The peripheral coherence order for a memory-mapped peripheral signifies the

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Jerin Jacob
On Fri, Dec 20, 2019 at 8:40 AM Gavin Hu wrote: > > Armv8's peripheral coherence order is a total order on all reads and writes > to that peripheral.[1] > > The peripheral coherence order for a memory-mapped peripheral signifies the > order in which accesses arrive at the endpoint. For a read or

Re: [dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-19 Thread Gavin Hu
Hi Jerin, It got two coding style warnings, otherwise, Reviewed-by: Gavin Hu WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #144: FILE: lib/librte_mempool/rte_mempool.c:84: +arch_mem_object_align(unsigned obj_size) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bar

[dpdk-dev] [PATCH v3 4/5] net/ixgbe: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 39 drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++

[dpdk-dev] [PATCH v3 3/5] net/ice: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 41 drivers/net/ice/ice_rxtx.h | 1 + 3 files cha

[dpdk-dev] [PATCH v3 2/5] net/i40e: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 40 +++

[dpdk-dev] [PATCH v3 5/5] net/e1000: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe

[dpdk-dev] [PATCH v3 1/5] net/fm10k: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the fm10k driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/fm10k/fm10k.h| 2 ++ drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/fm10k/fm10k_rxtx.c | 45

[dpdk-dev] [PATCH v3 0/5] drivers/net: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the drivers inclulding fm10k, i40e, ice, ixgbe and igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. --- v2: added code about igb vf. v3: changed infomation of author Chenxu Di (5): net/fm10k: cleanup Tx buffers net/i40e: cleanup Tx buffers

[dpdk-dev] [PATCH v2 3/3] crypto/virtio: virtual PCI requires smp barriers

2019-12-19 Thread Gavin Hu
Other than real PCI reads and writes to the device memory requiring the io barriers, virtual pci memories are normal memory in the smp configuration, and requires the smp barriers. Since the smp barriers and io barriers are identical on x86 and PPC, this change has only effect on aarch64. As far

[dpdk-dev] [PATCH v2 2/3] net/virtio: virtual PCI requires smp barriers

2019-12-19 Thread Gavin Hu
Other than real PCI reads and writes to the device memory requiring the io barriers, virtual pci memories are normal memory in the smp configuration, which requires the smp barriers. Since the smp barriers and io barriers are identical on x86 and PPC, this change has only effect on aarch64. As fa

[dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

2019-12-19 Thread Gavin Hu
Armv8's peripheral coherence order is a total order on all reads and writes to that peripheral.[1] The peripheral coherence order for a memory-mapped peripheral signifies the order in which accesses arrive at the endpoint. For a read or a write RW1 and a read or a write RW2 to the same peripheral

[dpdk-dev] [PATCH v2 0/3] relax io barrier for aarch64 and use smp barriers for virtual pci memory

2019-12-19 Thread Gavin Hu
Armv8's peripheral coherence order is a total order on all reads and writes to that peripheral, that makes a compiler barrier is enough for abstracted rte io barrier. For virtual PCI devices, the virtual device memory is actually normal memory and the Hypervisor view of things takes precedence and

[dpdk-dev] [PATCH v2 3/5] net/ice: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
From: Di ChenxuX Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 41 drivers/net/ice/ice_rxtx.h

[dpdk-dev] [PATCH v2 5/5] net/e1000: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/e1000/igb_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe

[dpdk-dev] [PATCH v2 1/5] net/fm10k: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
From: Di ChenxuX Add support to the fm10k driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/fm10k/fm10k.h| 2 ++ drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/fm10k/fm10k_rxtx.c | 45 +++

[dpdk-dev] [PATCH v2 2/5] net/i40e: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
From: Di ChenxuX Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 40 ++

[dpdk-dev] [PATCH v2 4/5] net/ixgbe: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
From: Di ChenxuX Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Chenxu Di --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 39 drivers/net/ixgbe/ixgb

[dpdk-dev] [PATCH v2 0/5] drivers/net: cleanup Tx buffers

2019-12-19 Thread Chenxu Di
Add support to the drivers inclulding fm10k, i40e, ice, ixgbe and igb vf for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. --- v2: added code about igb vf. Chenxu Di (5): net/e1000: cleanup Tx buffers net/fm10k: cleanup Tx buffers net/i40e: cleanup Tx buffers

Re: [dpdk-dev] [PATCH v4 06/17] net/ionic: add basic lif support

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:36 +0100 Alfredo Cardigliano wrote: > diff --git a/drivers/net/ionic/ionic.h b/drivers/net/ionic/ionic.h > index a29f0bb89..b6ef63161 100644 > --- a/drivers/net/ionic/ionic.h > +++ b/drivers/net/ionic/ionic.h > @@ -49,7 +49,12 @@ struct ionic_adapter { > struct ion

Re: [dpdk-dev] [PATCH v4 15/17] net/ionic: add stats

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:45 +0100 Alfredo Cardigliano wrote: > + > +void > +ionic_lif_get_stats(struct ionic_lif *lif, struct rte_eth_stats *stats) > +{ It is clearer which parameter is input (vs output) if you mark lif as const here.

Re: [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:34 +0100 Alfredo Cardigliano wrote: > + > +static inline uint16_t ilog2(uint32_t n) > +{ > + uint16_t logv = -1; > + > + if (n == 0) > + return 0; > + > + while (n) { > + logv++; > + n >>= 1; > + } > + > + return lo

Re: [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:34 +0100 Alfredo Cardigliano wrote: > +static int > +eth_ionic_pci_remove(struct rte_pci_device *pci_dev) > +{ > + return 0; > +} > + You probably want to u se rte_eth_dev_pci_generic_remove here

Re: [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:34 +0100 Alfredo Cardigliano wrote: > + adapter->pci_dev = pci_dev; > + hw = &adapter->hw; > + > + hw->device_id = pci_dev->id.device_id; > + hw->vendor_id = pci_dev->id.vendor_id; Other drives to rte_eth_copy_pci_info(eth_dev, pci_dev) here.

Re: [dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:34 +0100 Alfredo Cardigliano wrote: > + adapter = rte_zmalloc("ionic", sizeof(*adapter), 0); > + > + if (!adapter) { Don't need a blank line here; better to have assignment and check next to each other. You probably want to use rte_zmalloc_socket to make sure

Re: [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions

2019-12-19 Thread Stephen Hemminger
On Thu, 19 Dec 2019 23:18:32 +0100 Alfredo Cardigliano wrote: > + > +#pragma pack(push, 1) > + Really, packing leads to unaligned data structures and is generally a bad idea.

[dpdk-dev] [PATCH v4 17/17] net/ionic: read fw version

2019-12-19 Thread Alfredo Cardigliano
Add support for reading the firmware version. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.c | 8 drivers/net/ionic/ionic_ethdev.c | 20 ++

[dpdk-dev] [PATCH v4 15/17] net/ionic: add stats

2019-12-19 Thread Alfredo Cardigliano
Add basic, per queue and extended statistics for RX and TX, both from the adapter and the driver. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 253 + drivers/net/io

[dpdk-dev] [PATCH v4 11/17] net/ionic: add RX filters support

2019-12-19 Thread Alfredo Cardigliano
Add support for managing RX filters based on MAC and VLAN. Hardware cannot provide the list of filters, thus we keep a local list. Add support for promisc and allmulticast modes. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4 + driv

[dpdk-dev] [PATCH v4 13/17] net/ionic: add RX and TX handling

2019-12-19 Thread Alfredo Cardigliano
Add RX and TX queues setup and handling. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 10 + drivers/net/ionic/Makefile | 1 + drivers/net/ionic/ionic_dev.h | 1 + drivers/net/ionic/ionic_ethdev.c | 115 drivers/

[dpdk-dev] [PATCH v4 16/17] net/ionic: add TX checksum support

2019-12-19 Thread Alfredo Cardigliano
Add support for TX checksumming. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_ethdev.c | 5 ++ drivers/net/ionic/ionic_lif.c| 1 + drivers/net/ionic/ionic_lif.h| 1 + drivers/net/ionic/ionic_rxtx.c | 88 +++-

[dpdk-dev] [PATCH v4 14/17] net/ionic: add RSS support

2019-12-19 Thread Alfredo Cardigliano
Add code to manipulate the RSS configuration used by the adapter. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 3 + drivers/net/ionic/ionic_ethdev.c | 175 + drivers/net/ionic/ionic_ethdev.h | 8 ++ d

[dpdk-dev] [PATCH v4 10/17] net/ionic: add basic port operations

2019-12-19 Thread Alfredo Cardigliano
Add support for port start/stop and handle basic features including mtu and link up/down. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 4 + drivers/net/ionic/ionic.h | 1 + drivers/net/ionic/ionic_dev.h | 3 + driver

[dpdk-dev] [PATCH v4 12/17] net/ionic: add Flow Control support

2019-12-19 Thread Alfredo Cardigliano
Add support for managing Flow Control. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 56 ++ 2 files changed, 57 insertions(+) diff --git a/doc/guides/nics/features/i

[dpdk-dev] [PATCH v4 07/17] net/ionic: add doorbells

2019-12-19 Thread Alfredo Cardigliano
Doorbell registers are used by the driver to signal to the NIC that requests are waiting on the message queues. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_dev.c | 15 +++ drivers/net/ionic/ionic_dev.h | 19 +++ drivers/

[dpdk-dev] [PATCH v4 06/17] net/ionic: add basic lif support

2019-12-19 Thread Alfredo Cardigliano
Initialize LIFs (Logical Interfaces) which represents external connections. The NIC can multiplex many LIFs to a single port, but in most setups, LIF0 is the primary control for the port. Create a device for each LIF. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/ne

[dpdk-dev] [PATCH v4 04/17] net/ionic: register and initialize the adapter

2019-12-19 Thread Alfredo Cardigliano
Register the Pensando ionic PMD (net_ionic) and define initial probe and remove callbacks with adapter initialization. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- doc/guides/nics/features/ionic.ini | 2 + drivers/net/ionic/Makefile | 3 + drivers/net/ionic/ion

[dpdk-dev] [PATCH v4 09/17] net/ionic: add notifyq support

2019-12-19 Thread Alfredo Cardigliano
Add support for the notify queue, which is used for events published by the NIC. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 2 + drivers/net/ionic/ionic_ethdev.c | 97 +++ drivers/net/ionic/ionic_lif.c| 196 ++

[dpdk-dev] [PATCH v4 08/17] net/ionic: add adminq support

2019-12-19 Thread Alfredo Cardigliano
Add support for the admin queue, which is used for most of the NIC configurations. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h | 3 + drivers/net/ionic/ionic_dev.c | 255 +++ drivers/net/ionic/ionic_dev.h | 95 ++

[dpdk-dev] [PATCH v4 05/17] net/ionic: add port management commands

2019-12-19 Thread Alfredo Cardigliano
Add port management commands that apply to the physical ports associated with the PCI device, which might be shared among several logical interfaces. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic.h| 6 ++ drivers/net/ionic/ionic_dev.c|

[dpdk-dev] [PATCH v4 03/17] net/ionic: add log

2019-12-19 Thread Alfredo Cardigliano
Add debug options to the config file. Define macros used for logs and make use of config file options to enable them. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/Makefile | 2 +- drivers/net/ionic/ionic_ethdev.c | 15 +++ drivers/net/i

[dpdk-dev] [PATCH v4 01/17] net/ionic: add skeleton

2019-12-19 Thread Alfredo Cardigliano
Add makefile and config file options to compile the Pensando ionic PMD. Add feature and version map file. Update maintainers file. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- MAINTAINERS | 6 +++ config/common_armv8a_linux

[dpdk-dev] [PATCH v4 00/17] Introduces net/ionic PMD

2019-12-19 Thread Alfredo Cardigliano
The patch series provides an initial version of a poll mode driver for Pensando network adapters. The driver name is ionic. v4 Changes: -- - Remove the static list of adapters - Disable compilation on unsupported platforms - Add BSD-3-Clause to ionic_if.h - Add a link to the supported adap

[dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions

2019-12-19 Thread Alfredo Cardigliano
Add hardware structures and message commands definitions for Pensando network adapters. Signed-off-by: Alfredo Cardigliano Reviewed-by: Shannon Nelson --- drivers/net/ionic/ionic_if.h | 2491 ++ 1 file changed, 2491 insertions(+) create mode 100644 drivers/net/i

Re: [dpdk-dev] [PATCH v6 00/11] Add ABI compatibility checks to the meson build

2019-12-19 Thread David Marchand
Hello Kevin, On Fri, Dec 13, 2019 at 5:41 PM Kevin Laatz wrote: > > With the recent changes made to stabilize ABI versioning in DPDK, it will > become increasingly important to check patches for ABI compatibility. We > propose adding the ABI compatibility checking to be done as part of the > buil

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-19 Thread Medvedkin, Vladimir
Hi Anoob, On 19/12/2019 04:37, Anoob Joseph wrote: Hi Vladimir, Please see inline. Thanks, Anoob -Original Message- From: dev On Behalf Of Medvedkin, Vladimir Sent: Wednesday, December 18, 2019 7:22 PM To: Anoob Joseph ; Ananyev, Konstantin ; Akhil Goyal ; Adrien Mazarguil ; Doherty

Re: [dpdk-dev] [PATCH] ci: update travis to use bionic

2019-12-19 Thread Laatz, Kevin
On 17/12/2019 18:03, Aaron Conole wrote: "Laatz, Kevin" writes: On 17/12/2019 14:44, Aaron Conole wrote: Kevin Laatz writes: Currently, the Travis CI is using Ubuntu 16.04 LTS (Xenial) which is becoming increasingly outdated. This patch updates Travis to use Ubuntu 18.04 LTS (Bionic) which

Re: [dpdk-dev] [dpdk-stable] [PATCH] rte_flow: fix docbook comment

2019-12-19 Thread Ferruh Yigit
On 12/18/2019 6:44 AM, Slava Ovsiienko wrote: <...> > >> -Original Message- >> From: Stephen Hemminger >> Sent: Wednesday, December 18, 2019 3:13 >> To: dev@dpdk.org >> Cc: Stephen Hemminger ; Slava Ovsiienko >> ; sta...@dpdk.org >> Subject: [PATCH] rte_flow: fix docbook comment >> >> M

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-19 Thread Thomas Monjalon
19/12/2019 13:42, David Marchand: > On Thu, Dec 12, 2019 at 12:59 PM Bruce Richardson > wrote: > > > > The soname for each stable ABI version should be just the ABI version major > > number without the minor number. Unfortunately both major and minor were > > used causing version 20.1 to be incomp

[dpdk-dev] [PATCH] mempool: fix mempool obj alignment for non x86

2019-12-19 Thread jerinj
From: Jerin Jacob The exiting optimize_object_size() function address the memory object alignment constraint on x86 for better performance. Different (Mirco) architecture may have different memory alignment constraint for better performance and it not same as the existing optimize_object_size()

[dpdk-dev] [PATCH] ethdev: fix switching domain allocation

2019-12-19 Thread Viacheslav Ovsiienko
The maximum amount of unique switching domain is supposed to be equal to RTE_MAX_ETHPORTS. The current implementation allows to allocate only RTE_MAX_ETHPORTS-1 domains. Fixes: ce9250406323 ("ethdev: add switch domain allocator") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- lib/l

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-19 Thread David Marchand
On Thu, Dec 12, 2019 at 12:59 PM Bruce Richardson wrote: > > The soname for each stable ABI version should be just the ABI version major > number without the minor number. Unfortunately both major and minor were > used causing version 20.1 to be incompatible with 20.0. > > This patch fixes the iss

Re: [dpdk-dev] [PATCH v1] net/ice: add new device IDs

2019-12-19 Thread Ferruh Yigit
On 12/19/2019 2:43 AM, Ye Xiaolong wrote: > On 12/18, Ting Xu wrote: >> This patch added new device IDs for C822N. >> >> Signed-off-by: Ting Xu >> --- >> drivers/net/ice/ice_ethdev.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_et

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: fix debug build test

2019-12-19 Thread Thomas Monjalon
16/12/2019 16:29, Thomas Monjalon: > When testing build with +debug options, the statistics are enabled. > It was wrongly matching CONFIG_RTE_IBVERBS_LINK_STATIC. > The pattern is fixed to match only statistics config options. > > Fixes: 2c0dd7b69fb0 ("config: add static linkage of mlx dependency"

[dpdk-dev] DPDK Release Status Meeting 19/12/2019

2019-12-19 Thread Ferruh Yigit
Minutes 19 December 2019 Agenda: * Release Dates * Subtrees * OvS Participants: * Intel * Marvell * Mellanox * Red Hat The next two meetings have been cancelled because of coming holidays, see you next year. 2019 was an amazing year for DPDK, thanks everyone who contrib

Re: [dpdk-dev] [PATCH] net/mlx5: fix item flag on GENEVE item validation

2019-12-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, December 18, 2019 5:10 PM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix item flag on GENEVE item > validation

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant define of LRO masks

2019-12-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, December 18, 2019 9:50 AM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: remove redundant define of LRO > masks > > Bit-masks MLX5

Re: [dpdk-dev] [PATCH] net/mlx5: add define of LRO segment chunk size

2019-12-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, December 18, 2019 9:52 AM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: add define of LRO segment chunk > size > > Maximal size o

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: update RSS action handling

2019-12-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, December 18, 2019 12:06 PM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] net/mlx5: update RSS action handling > > This series includes 2

[dpdk-dev] [PATCH v2 3/3] mbuf: use structure marker typedef in eal

2019-12-19 Thread jerinj
From: Jerin Jacob Use new marker typedef available in EAL and remove private marker typedef. Signed-off-by: Jerin Jacob --- lib/librte_mbuf/rte_mbuf_core.h | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mb

[dpdk-dev] [PATCH v2 1/3] eal: introduce structure marker typedefs

2019-12-19 Thread jerinj
From: Jerin Jacob Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and a generic marker for a point in a structure. Signed-off-by: Jerin Jacob --- v2: - Changed __extension__ to RTE_STD_C11 (Thomas) - Change "a point" to "any place" of RTE_MARKER comment(Thomas) lib/lib

[dpdk-dev] [PATCH v2 2/3] drivers: use structure marker typedef in eal

2019-12-19 Thread jerinj
From: Jerin Jacob Use new marker typedef available in EAL. Signed-off-by: Jerin Jacob --- drivers/net/ark/ark_ethdev_rx.c | 2 +- drivers/net/ark/ark_ethdev_tx.c | 2 +- drivers/net/octeontx2/otx2_ethdev.h | 6 +++--- drivers/net/thunderx/nicvf_struct.h | 4 ++-- 4 files changed, 7 ins

[dpdk-dev] [PATCH] mempool/octeontx: fix error handling in initialization

2019-12-19 Thread kkanas
From: Krzysztof Kanas When octeontx_get_fpavf fails fpa pointer is used to get pool_stack_base, which is then freed. Coverity issue: 351263 Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation") Cc: pbhagavat...@marvell.com Signed-off-by: Krzysztof Kanas --- drivers/memp

Re: [dpdk-dev] [PATCH 1/3] eal: introduce structure marker typedefs

2019-12-19 Thread Jerin Jacob
On Wed, Dec 11, 2019 at 4:16 AM Thomas Monjalon wrote: > > 08/12/2019 12:34, jer...@marvell.com: > > From: Jerin Jacob > > > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and > > a generic marker for a point in a structure. > > > > Signed-off-by: Jerin Jacob > > --- > >

[dpdk-dev] [PATCH v2] net/ixgbe: fix flow ctrl mode setting

2019-12-19 Thread Guinan Sun
When the port starts, the hw register is reset first, and then the required parameters are set again. If the parameters to be used are not set after resetting the register, a read register error will occur. This patch is used to fix the problem. Fixes: af75078fece3 ("first public release") Cc: sta

Re: [dpdk-dev] [PATCH] net/mlx5: allow install more meter actions

2019-12-19 Thread Tonghao Zhang
ping On Tue, Dec 17, 2019 at 3:29 PM wrote: > > From: Tonghao Zhang > > When creating the dr rule of meter, the matcher which > struct is "struct mlx5dv_dr_matcher" should not be > shared, if shared, mlx5dv_dr_rule_create will return > NULL. We can't install more metering offload actions. > > Th

[dpdk-dev] [PATCH v4] vhost: add config change slave msg support

2019-12-19 Thread Li Feng
This msg is used to notify qemu that should get the config of backend. For example, vhost-user-blk uses this msg to notify guest os the capacity of backend has changed. The need_reply flag is not mandatory because it will block the sender thread and master process will send get_config message to

Re: [dpdk-dev] [PATCH] net/ixgbe: enable jumbo frame for VF

2019-12-19 Thread Ye Xiaolong
On 12/02, Junyu Jiang wrote: >Enable jumbo frame for VF by configuring DPDK PF. > >Signed-off-by: Junyu Jiang >--- > drivers/net/ixgbe/ixgbe_pf.c | 13 + > 1 file changed, 13 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c >index d0d85e138..66b8