On Wed, Dec 11, 2019 at 4:16 AM Thomas Monjalon <tho...@monjalon.net> wrote:
>
> 08/12/2019 12:34, jer...@marvell.com:
> > From: Jerin Jacob <jer...@marvell.com>
> >
> > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and
> > a generic marker for a point in a structure.
> >
> > Signed-off-by: Jerin Jacob <jer...@marvell.com>
> > ---
> >  lib/librte_eal/common/include/rte_common.h | 12 ++++++++++++
>
> Good idea, thanks.
>
> > +/** Generic marker for a point in a structure. */
>
> I think "a point" may be replaced with "any place" or something else?

Will fix it v2.

>
> > +__extension__ typedef void    *RTE_MARKER[0];
>
> Why do we need an extension?
> If it is part of C11, we should use RTE_STD_C11 instead.

Will fix it v2.

> If it is another reason, we could create another meaningful EAL macro.
>
>
>

Reply via email to