[dpdk-dev] [RFC] net/mlx5: move to non-cached mode for flow rules

2019-12-10 Thread Bing Zhao
In the current PMD implementation, all the flow rules' related information is stored by default, like the table resources, matchers and actions and so on that are already translated into the hardware descriptions via the interfaces. When restarting a device after stopping it, all the flow rules wil

[dpdk-dev] [PATCH] net/ixgbe: fixed port can not link up in FreeBSD

2019-12-10 Thread Lunyuan Cui
In FreeBSD environment, nic_uio drivers do not support interrupts, rte_intr_callback_register() will fail to register interrupts. We can not make link status to change from down to up by interrupt callback. So we need to wait for the controller to acquire link when ports start. Through multiple tes

[dpdk-dev] [PATCH] net/mlx: fix variadic macro

2019-12-10 Thread Ali Alnubani
This rewrites the MKSTR macro appending an empty string to its arguments to resolve build failures similar to: drivers/net/mlx4/mlx4.c:461:14: fatal error: format string is not a string literal [-Wformat-nonliteral] MKSTR(path, "%s/device/uevent", device->ibdev_path); drivers/net/

Re: [dpdk-dev] [PATCH v5] build: add dockerfile for building docker image

2019-12-10 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Abdul Halim > Sent: Tuesday, December 10, 2019 21:55 > To: dev@dpdk.org > Cc: ray.kinse...@intel.com; yasufu...@gmail.com; Ruifeng Wang (Arm > Technology China) ; Abdul Halim > > Subject: [PATCH v5] build: add dockerfile for building docker image > > Adding

[dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ

2019-12-10 Thread Hemant Agrawal
From: Jun Yang The existing forwarding mode usages the total number of queues as the minimum of rxq and txq. It finds the txq as the same index as rxq. However in some scenarios, specially for flow control the number of rxq and txq can be different. This patch maxes the txq and function of rxq fo

[dpdk-dev] [PATCH 1/2] examples/ip_pipeline: fix crypto queue config

2019-12-10 Thread Hemant Agrawal
queue_conf need to have mempool details before pair setup. Fixes: 261bbff75e34 ("examples: use separate crypto session mempools") Cc: sta...@dpdk.org Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- examples/ip_pipeline/cryptodev.c | 24 +--- 1 file changed, 13 ins

[dpdk-dev] [PATCH 2/2] examples/ip_pipeline: fix to use sock id instead of cpuid

2019-12-10 Thread Hemant Agrawal
From: Jun Yang rte_lcore_to_socket_id should be used to convert cpu ID to socket ID. Fixes: 6bfe74f8c93e ("examples/ip_pipeline: add mempool object") Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object") Cc: sta...@dpdk.org Signed-off-by: Jun Yang --- examples/ip_pipeline/mempool.

[dpdk-dev] Arm's roadmap for 20.02

2019-12-10 Thread Honnappa Nagarahalli
Hi, Following are the work items planned for 20.02: 1) rte_wait_until_equal_xxx APIs for integrating WFE/SEV instructions for Arm architecture 2) Integrate aarch64 crypto library with ArmV8 crypto PMD 3) Ring APIs to support user defined ring element size Thank you, Honnappa

Re: [dpdk-dev] [PATCH v3] vhost: add config change slave msg support

2019-12-10 Thread Li Feng
ping, any update about this? Thanks, Feng Li Li Feng 于2019年12月5日周四 下午1:38写道: > > This msg is used to notify qemu that should get the config of backend. > > For example, vhost-user-blk uses this msg to notify guest os the > compacity of backend has changed. > > Signed-off-by: Li Feng > --- > v3

[dpdk-dev] [PATCH] net/e1000: update UPDATE_VF_STAT to handle rollover

2019-12-10 Thread David Harton
Modified UPDATE_VF_STAT to properly handle rollover conditions. Signed-off-by: David Harton --- drivers/net/e1000/igb_ethdev.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index a3e30dbe5..82566

[dpdk-dev] [PATCH] net/ixgbevf: update VF_STAT macros to handle rollover

2019-12-10 Thread David Harton
Added rollover logic to UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT macros. Signed-off-by: David Harton --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 492

[dpdk-dev] [PATCH] net/ixgbevf: prevent duplicate default mac filter entries

2019-12-10 Thread David Harton
The ixgbe PF manages the default VF mac address in a separate list from the additional VF mac filters. librte_ethdev stores the default mac in dev->data->mac_addrs[0], however, the ixgbevf driver re-adds mac_addr[0] when a mac filter is removed. ixgbevf_remove_mac_addr() is modified to avoid (re)

Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-10 Thread Suanming Mou
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, December 11, 2019 2:32 AM > To: Andrew Rybchenko > Cc: Suanming Mou ; Adrien Mazarguil > ; John McNamara ; > Marko Kovacevic ; Thomas Monjalon > ; Ferruh Yigit ; dev@dpdk.org; > Shahaf Shuler ; Ori Kam ; > Matan Azrad ;

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Bruce Richardson
On Tue, Dec 10, 2019 at 06:22:36PM +, Luca Boccassi wrote: > On Tue, 2019-12-10 at 18:04 +0100, Thomas Monjalon wrote: > > 10/12/2019 17:32, Bruce Richardson: > > > On Tue, Dec 10, 2019 at 04:20:41PM +, Luca Boccassi wrote: > > > > On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote:

Re: [dpdk-dev] [PATCH 00/15] add OCTEONTX2 inline IPsec support

2019-12-10 Thread Thomas Monjalon
09/12/2019 09:06, Jerin Jacob: > On Sun, Dec 8, 2019 at 5:25 PM Anoob Joseph wrote: > > > > This series adds inline IPsec support in OCTEONTX2 PMD. > > > > In the inbound path, rte_flow framework need to be used to configure > > the NPC block, which does the h/w lookup. The packets would get > > p

Re: [dpdk-dev] [PATCH 1/3] eal: introduce structure marker typedefs

2019-12-10 Thread Thomas Monjalon
08/12/2019 12:34, jer...@marvell.com: > From: Jerin Jacob > > Introduce EAL typedef for structure 1B, 2B, 4B, 8B alignment marking and > a generic marker for a point in a structure. > > Signed-off-by: Jerin Jacob > --- > lib/librte_eal/common/include/rte_common.h | 12 Good idea,

[dpdk-dev] [PATCH] net/ena: initialize PCI info in eth_ena_dev_init

2019-12-10 Thread David Harton
Network drivers were originally modified to initialize PCI info with commit eeefe73f0af1 ("drivers: copy PCI device info to ethdev data"). Modifying net/ena to conform. Signed-off-by: David Harton --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/en

[dpdk-dev] [PATCH] net/ena: initialize PCI info in eth_ena_dev_init

2019-12-10 Thread David Harton
Network drivers were originally modified to initialize PCI info with commit eeefe73f. Modifying net/ena to conform. Signed-off-by: David Harton --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index

[dpdk-dev] [PATCH] net/ena: initialize PCI info in eth_ena_dev_init

2019-12-10 Thread David Harton
Network drivers were originally modified to initialize PCI info with commit eeefe73f. Modifying net/ena to conform. Signed-off-by: David Harton --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index

Re: [dpdk-dev] [PATCH 1/9] app/testpmd: parse flow command line for ESP

2019-12-10 Thread Ori Kam
Hi Bernard, > -Original Message- > From: dev On Behalf Of Bernard Iremonger > Sent: Tuesday, December 10, 2019 2:57 PM > To: dev@dpdk.org; beilei.x...@intel.com; qi.z.zh...@intel.com; > declan.dohe...@intel.com > Cc: stephen1.by...@intel.com; konstantin.anan...@intel.com; > bernard.iremo

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-10 Thread Ori Kam
> -Original Message- > Subject: Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to > use one rte flow > > On Sun, Dec 8, 2019 at 4:19 PM Anoob Joseph wrote: > > > > The rte_security API which enables inline protocol/crypto feature > > mandates that for every security ses

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-10 Thread Ori Kam
Hi Rory, > -Original Message- > From: Sexton, Rory > Sent: Tuesday, December 10, 2019 4:52 PM > To: Ori Kam ; dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Adrien Mazarguil ; Jagus, DariuszX > > Subject: RE: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API > > Hi Ori, > > >

Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-10 Thread Ori Kam
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, December 10, 2019 8:32 PM > To: Andrew Rybchenko > Cc: Suanming Mou ; Adrien Mazarguil > ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; dev@dpdk.org; Shahaf Shuler > ; Ori Kam ; Matan

Re: [dpdk-dev] [PATCH v3 00/17] Introduces net/ionic PMD

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > The patch series provides an initial version of a > poll mode driver for Pensando network adapters. > The driver name is ionic. > > v3 Changes: > -- > - Set the license to BSD-3 (in addition to GPL-2) > - Add the new PMD driver to the rele

Re: [dpdk-dev] [PATCH v3 09/17] net/ionic: add notifyq support

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add support for the notify queue, which is used for events > published by the NIC. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > +static int > +ionic_lif_notifyq_init(struct ionic_lif *lif) > +{ > + struct io

Re: [dpdk-dev] [PATCH v3 16/17] net/ionic: add TX checksum support

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add support for TX checksumming. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > @@ -710,7 +794,7 @@ ionic_rx_clean(struct ionic_queue *q, > > /* Vlan Strip */ > if (cq_desc->csum_flags & IONIC_RXQ_CO

Re: [dpdk-dev] [PATCH v3 13/17] net/ionic: add RX and TX handling

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add RX and TX queues setup and handling. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > @@ -7,12 +7,23 @@ > Speed capabilities = Y > Link status = Y > Link status event= Y > +Queue start/stop

Re: [dpdk-dev] [PATCH v3 04/17] net/ionic: register and initialize the adapter

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Register the Pensando ionic PMD (net_ionic) and define initial probe > and remove callbacks with adapter initialization. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > +/* > + * There is no room in struct rte_pci_

Re: [dpdk-dev] [PATCH v3 10/17] net/ionic: add basic port operations

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add support for port start/stop and handle basic features > including mtu and link up/down. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > +static int > +ionic_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu

Re: [dpdk-dev] [PATCH v3 03/17] net/ionic: add log

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add debug options to the config file. > Define macros used for logs and make use of config file options > to enable them. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > @@ -0,0 +1,15 @@ > +/* SPDX-License-Identifi

Re: [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures definitions

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add hardware structures and message commands definitions for > Pensando network adapters. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > drivers/net/ionic/ionic_if.h | 2491 ++ > 1 f

Re: [dpdk-dev] [PATCH v3 03/17] net/ionic: add log

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add debug options to the config file. > Define macros used for logs and make use of config file options > to enable them. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > diff --git a/drivers/net/ionic/ionic_ethdev.

Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton

2019-12-10 Thread Ferruh Yigit
On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: > Add makefile and config file options to compile the Pensando ionic PMD. > Add feature and version map file. > Update maintainers file. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > @@ -277,6 +277,11 @@ CONFIG_RTE

Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-10 Thread Stephen Hemminger
On Tue, 10 Dec 2019 08:55:40 + Suanming Mou wrote: > > -Original Message- > > From: Andrew Rybchenko > > Sent: Tuesday, December 10, 2019 3:33 PM > > To: Suanming Mou ; Adrien Mazarguil > > ; John McNamara ; > > Marko Kovacevic ; Thomas Monjalon > > ; Ferruh Yigit > > Cc: dev@dpdk.o

Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-10 Thread Stephen Hemminger
On Tue, 10 Dec 2019 10:33:28 +0300 Andrew Rybchenko wrote: > > For some overlay network, such as VXLAN, the DSCP field in the new outer > > IP header after VXLAN decapsulation may need to be updated accordingly. > > > > This commit introduce the DSCP modify action for IPv4 and IPv6. > > > > Sig

Re: [dpdk-dev] [PATCH 7/9] librte_ethdev: add ESP and AH flow types to RSS

2019-12-10 Thread Stephen Hemminger
On Tue, 10 Dec 2019 12:57:10 + Bernard Iremonger wrote: > Add flow types for the following PCTYPE's in the DDP ipsec profile: > 14: IPV6 ESP > 15: IPV4 ESP > 16: IPV6 AH > 17: IPV4 AH > 18: IPV6 UDP ESP > 19: IPV4 UDP ESP > > Add the following RSS macros for IPsec: > ETH_RSS_ESP > ETH_RSS_AH

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Luca Boccassi
On Tue, 2019-12-10 at 18:04 +0100, Thomas Monjalon wrote: > 10/12/2019 17:32, Bruce Richardson: > > On Tue, Dec 10, 2019 at 04:20:41PM +, Luca Boccassi wrote: > > > On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote: > > > > On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote:

Re: [dpdk-dev] questions about new offload ethdev api

2019-12-10 Thread Ferruh Yigit
On 1/23/2018 2:34 PM, Shahaf Shuler wrote: > Tuesday, January 23, 2018 3:53 PM, Olivier Matz: <...> >> >> 2/ meaning of rxmode.jumbo_frame, rxmode.enable_scatter, >> rxmode.max_rx_pkt_len >> >> While it's not related to the new API, it is probably a good opportunity >> to clarify the meaning o

[dpdk-dev] [PATCH] build: fix soname info in make build

2019-12-10 Thread Bruce Richardson
The soname for each stable ABI version should be just the ABI version major number without the minor number. Unfortunately both major and minor were used causing version 20.1 to be incompatible with 20.0. For make the fix is to separate out the soname passed to the linker from the final shared lib

Re: [dpdk-dev] [PATCH v5] build: add dockerfile for building docker image

2019-12-10 Thread Ray Kinsella
On 10/12/2019 13:55, Abdul Halim wrote: > Adding a Dockerfile with Ubuntu bionic base image to build dpdk as shared > library. This docker image could be used as base image to build and run > dpdk applications in containers. > > Signed-off-by: Abdul Halim > > --- > > v2: > * renamed Docker

[dpdk-dev] [PATCH] cryptodev: fix set_sym_session_private_data error in sessionless mode

2019-12-10 Thread Junxiao Shi
Bugzilla ID: 377 Signed-off-by: Junxiao Shi --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++-- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni

[dpdk-dev] [Bug 377] CRYPTODEV: set_sym_session_private_data() line 489: Set private data for driver 0 not allowed

2019-12-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=377 Bug ID: 377 Summary: CRYPTODEV: set_sym_session_private_data() line 489: Set private data for driver 0 not allowed Product: DPDK Version: unspecified Hardware: x86 O

[dpdk-dev] [PATCH] build: fix soname info in meson build

2019-12-10 Thread Bruce Richardson
The soname for each stable ABI version should be just the ABI version major number without the minor number. Unfortunately both major and minor were used causing version 20.1 to be incompatible with 20.0. For meson we can fix this by removing the explicit setting of the soversion for each shared l

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Thomas Monjalon
10/12/2019 17:32, Bruce Richardson: > On Tue, Dec 10, 2019 at 04:20:41PM +, Luca Boccassi wrote: > > On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote: > > > On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote: > > > > On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote:

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Bruce Richardson
On Tue, Dec 10, 2019 at 05:39:00PM +0100, Thomas Monjalon wrote: > 10/12/2019 17:20, Luca Boccassi: > > On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote: > > > On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote: > > > > On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote:

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Thomas Monjalon
10/12/2019 17:20, Luca Boccassi: > On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote: > > On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote: > > > On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote: > > > > On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: > >

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Bruce Richardson
On Tue, Dec 10, 2019 at 04:20:41PM +, Luca Boccassi wrote: > On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote: > > On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote: > > > On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote: > > > > On Tue, Dec 10, 2019 at 12:40:53PM

[dpdk-dev] [PATCH 1/2] crypto/qat: handle mixed hash-cipher requests on GEN3 QAT

2019-12-10 Thread Adam Dybkowski
This patch implements handling mixed encrypted digest hash-cipher requests (e.g. SNOW3G + ZUC or ZUC + AES CTR) possible when running on GEN3 QAT. Such algorithm combinations are not supported on GEN1/GEN2 hardware. Signed-off-by: Adam Dybkowski --- doc/guides/cryptodevs/qat.rst | 2

[dpdk-dev] [PATCH 2/2] test/crypto: add more tests for mixed encypted-digest

2019-12-10 Thread Adam Dybkowski
This patch adds unit tests for QAT PMD for mixed encrypted-digest cases, involving SNOW3G UIA2, ZUC EIA3, AES CMAC and NULL auth algorithms together with SNOW3G UEA2, ZUC EEA3, AES CTR and NULL cipher algorithms in various combinations. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Luca Boccassi
On Tue, 2019-12-10 at 15:46 +, Bruce Richardson wrote: > On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote: > > On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote: > > > On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: > > > > On 12/10/2019 12:04 PM, Bruce Richar

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Bruce Richardson
On Tue, Dec 10, 2019 at 03:03:51PM +, Luca Boccassi wrote: > On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote: > > On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: > > > On 12/10/2019 12:04 PM, Bruce Richardson wrote: > > > > On Tue, Dec 10, 2019 at 11:56:28AM +, Ferru

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Ferruh Yigit
On 12/10/2019 3:04 PM, Ferruh Yigit wrote: > On 12/10/2019 2:36 PM, Bruce Richardson wrote: >> On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: >>> On 12/10/2019 12:04 PM, Bruce Richardson wrote: On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote: > Hi, > > W

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Ferruh Yigit
On 12/10/2019 2:36 PM, Bruce Richardson wrote: > On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: >> On 12/10/2019 12:04 PM, Bruce Richardson wrote: >>> On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote: Hi, With new process, the major ABI releases will be com

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Luca Boccassi
On Tue, 2019-12-10 at 14:36 +, Bruce Richardson wrote: > On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: > > On 12/10/2019 12:04 PM, Bruce Richardson wrote: > > > On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote: > > > > Hi, > > > > > > > > With new process, the major

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-10 Thread Sexton, Rory
Hi Ori, > One general question why do we want to support only v3 and not also v2? l2tpv3 is more widely used as a tunneling protocol hence it's inclusion. A specific example is the cable industry where DOCSIS cable traffic is encapsulated using depi and uepi protocols which both make use of l2tpv

[dpdk-dev] [PATCH 4/6] net/bnxt: remove unnecessary macro for unused variables

2019-12-10 Thread Kalesh A P
From: Kalesh AP Remove "__rte_unused" instances that are not required. Signed-off-by: Kalesh AP Reviewed-by: Rahul Gupta Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- drivers/net/bnxt/bnxt_flow.c | 2 +- drivers/net/bnxt/bnxt_stats.c | 6 +++--- 3 files changed,

[dpdk-dev] [PATCH 5/6] net/bnxt: reset filter indices on free

2019-12-10 Thread Kalesh A P
From: Kalesh AP Fix bnxt_free_filter() to ensure that the filter indices are reset correctly when a filter is freed. This change helps in avoiding few duplicate code as well. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethde

[dpdk-dev] [PATCH 6/6] net/bnxt: add a field for fw capabilities

2019-12-10 Thread Kalesh A P
From: Kalesh AP The purpose of this patch is used to add a new field "fw_cap" in bnxt structure. The new "fw_cap" field store all the capabilities reported by the FW. This information will help us to determine the device capablities when registering feature support with FW. Signed-off-by: Kalesh

[dpdk-dev] [PATCH 3/6] net/bnxt: fix request for hot reset support

2019-12-10 Thread Kalesh A P
From: Kalesh AP During the registration process, the drivers must publish "HOT_RESET_SUPPORTED" capability to the core firmware only if core firmware is capable of Hot Reset. Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") Signed-off-by: Kalesh AP Reviewed-by: Ajit Ku

[dpdk-dev] [PATCH 1/6] net/bnxt: restore mac filters during reset recovery

2019-12-10 Thread Kalesh A P
From: Kalesh AP Older Firmware could have state information such as MAC Filters, VLAN settings etc configured by user. But new Firmware is unaware of this state information and as a result driver should restore these settings during reset recovery. This patch restores the user configured mac add

[dpdk-dev] [PATCH 2/6] net/bnxt: restore vlan filters during reset recovery

2019-12-10 Thread Kalesh A P
From: Kalesh AP Older Firmware could have state information such as MAC Filters, VLAN settings etc configured by user. But new Firmware is unaware of this state information and as a result driver should restore these settings during reset recovery. This patch restores the user configured vlan se

[dpdk-dev] [PATCH 0/6] bnxt patchset

2019-12-10 Thread Kalesh A P
From: Kalesh AP bnxt patchset with bug fixes and enhancements. Please apply. Kalesh AP (6): net/bnxt: restore mac filters during reset recovery net/bnxt: restore vlan filters during reset recovery net/bnxt: fix request for hot reset support net/bnxt: remove unnecessary macro for unused

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Bruce Richardson
On Tue, Dec 10, 2019 at 12:40:53PM +, Ferruh Yigit wrote: > On 12/10/2019 12:04 PM, Bruce Richardson wrote: > > On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote: > >> Hi, > >> > >> With new process, the major ABI releases will be compatible until it is > >> deprecated (until next LT

[dpdk-dev] [PATCH v5] build: add dockerfile for building docker image

2019-12-10 Thread Abdul Halim
Adding a Dockerfile with Ubuntu bionic base image to build dpdk as shared library. This docker image could be used as base image to build and run dpdk applications in containers. Signed-off-by: Abdul Halim --- v2: * renamed Dockerfile name from Dockerfile.ubuntu to Dockerfile.bionic * added

[dpdk-dev] [PATCH v4] build: add dockerfile for building docker image

2019-12-10 Thread Abdul Halim
Adding a Dockerfile with Ubuntu bionic base image to build dpdk as shared library. This docker image could be used as base image to build and run dpdk applications in containers. Signed-off-by: Abdul Halim --- v2: * renamed Dockerfile name from Dockerfile.ubuntu to Dockerfile.bionic * added

Re: [dpdk-dev] [PATCH] doc: fix build with python 3.8

2019-12-10 Thread Robin Jarry
2019-12-10, Thomas Monjalon: > 10/12/2019 13:00, Bruce Richardson: > > On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote: > > > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > > > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > > > Did yo

Re: [dpdk-dev] discussion: creating a new class for vdpa driversxiao.w.w...@intel.com

2019-12-10 Thread Tiwei Bie
On Tue, Dec 10, 2019 at 09:00:33AM +0100, Thomas Monjalon wrote: > 10/12/2019 03:41, Tiwei Bie: > > On Mon, Dec 09, 2019 at 02:22:27PM +0300, Andrew Rybchenko wrote: > > > On 12/9/19 1:41 PM, Ori Kam wrote: > > > > From: Andrew Rybchenko > > > >> On 12/8/19 10:06 AM, Matan Azrad wrote: > > > >>> Fr

Re: [dpdk-dev] [PATCH v3] build: add dockerfile for building docker image

2019-12-10 Thread Halim, Abdul
Hi Yasufumi and Ruifeng, Thanks for your feedback and verification. I will update the patch with suggested changes and improve it little bit more to avoid the dirty build directory. Also, for the sample app I will copy examples/helloworld source code only in the docker file. Regards, Abdul > -

Re: [dpdk-dev] [PATCH v2 1/3] app: use RTE_DIM to calculate array size

2019-12-10 Thread David Marchand
On Thu, Nov 7, 2019 at 3:59 AM wrote: > > From: Pavan Nikhilesh > > Use RTE_DIM macro to calculate array size > > Suggested-by: David Marchand > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > -- > - remove macros that are used only once.(David) > > app/test-pmd/cmdline.c

[dpdk-dev] [PATCH 9/9] doc: update i40e user guide

2019-12-10 Thread Bernard Iremonger
Update the i40e user guide with ESP information. Signed-off-by: Bernard Iremonger --- doc/guides/nics/i40e.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 38acf59..5cf34d9 100644 --- a/doc/guides/nics/i40e.rst +

[dpdk-dev] [PATCH 6/9] net/i40e: display Flow Director packet

2019-12-10 Thread Bernard Iremonger
call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_fdir.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index d58cee9..08cbbf6 100644 ---

[dpdk-dev] [PATCH 3/9] net/i40e: improve RSS debug

2019-12-10 Thread Bernard Iremonger
improve RSS debug in i40e_ethdev.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 5999c96..5f1cf8a 100644 --- a/drivers/net/i40e/

[dpdk-dev] [PATCH 4/9] net/i40e: handle ESP tunnel

2019-12-10 Thread Bernard Iremonger
handle ESP tunnel in rte_pmd_i40e.c Signed-off-by: Bernard Iremonger --- drivers/net/i40e/rte_pmd_i40e.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index fdcb1a4..b987346 100644 --- a/drivers/net/i40e/rt

[dpdk-dev] [PATCH 5/9] net/i40e: process ESP flows

2019-12-10 Thread Bernard Iremonger
Process ESP flows on Flow Director and RSS. add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and eth/ipv6/esp/udp patterns update i40e_flow_parse_fdir_filter() add fill_ip6_head() add oip_type in filter add is_udp in filter use tenant_id in filter for spi handle ESP and AH pctypes i

[dpdk-dev] [PATCH 8/9] doc: release note for ESP

2019-12-10 Thread Bernard Iremonger
Release note for ESP support on the i40e PMD. Release note for ESP support on testpmd. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_02.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH 7/9] librte_ethdev: add ESP and AH flow types to RSS

2019-12-10 Thread Bernard Iremonger
Add flow types for the following PCTYPE's in the DDP ipsec profile: 14: IPV6 ESP 15: IPV4 ESP 16: IPV6 AH 17: IPV4 AH 18: IPV6 UDP ESP 19: IPV4 UDP ESP Add the following RSS macros for IPsec: ETH_RSS_ESP ETH_RSS_AH ETH_RSS_IPSEC Signed-off-by: Bernard Iremonger --- lib/librte_ethdev/rte_ethdev.

[dpdk-dev] [PATCH 1/9] app/testpmd: parse flow command line for ESP

2019-12-10 Thread Bernard Iremonger
add ITEM_ESP add ITEM_ESP_SPI add debug to cmdline_flow.c improve debug in config.c Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline_flow.c | 37 ++--- app/test-pmd/config.c | 2 +- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/ap

[dpdk-dev] [PATCH 2/9] app/testpmd: dump Rx and Tx mbuf

2019-12-10 Thread Bernard Iremonger
add call to rte_pktmbuf_dump() in dump_pkt_burst in util.c Signed-off-by: Bernard Iremonger --- app/test-pmd/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index b514be5..bf03873 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -

[dpdk-dev] [PATCH 0/9] net/i40e: ESP support

2019-12-10 Thread Bernard Iremonger
Add support for ESP flows to testpmd. Improve debug information in testpmd and the i40e PMD. Process ESP flows on the i40e Flow Director and RSS. Bernard Iremonger (9): app/testpmd: parse flow command line for ESP app/testpmd: dump Rx and Tx mbuf net/i40e: improve RSS debug net/i40e: handl

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Ferruh Yigit
On 12/10/2019 12:04 PM, Bruce Richardson wrote: > On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote: >> Hi, >> >> With new process, the major ABI releases will be compatible until it is >> deprecated (until next LTS for now), >> like current ABI version is 20 in DPDK_19.11 and DPDK versi

Re: [dpdk-dev] [PATCH] doc: fix build with python 3.8

2019-12-10 Thread Thomas Monjalon
10/12/2019 13:00, Bruce Richardson: > On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote: > > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > > Did you mean "!="? > > if value is not '':

[dpdk-dev] [PATCH] net/octeontx2: perf improvement to rx vector func

2019-12-10 Thread Nithin Dabilpuram
From: Jerin Jacob Use scalar loads instead of vector loads for fields that don't need any vector operations. Signed-off-by: Andrew Pinski Signed-off-by: Jerin Jacob Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_rx.c | 48 - 1 file cha

Re: [dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Bruce Richardson
On Tue, Dec 10, 2019 at 11:56:28AM +, Ferruh Yigit wrote: > Hi, > > With new process, the major ABI releases will be compatible until it is > deprecated (until next LTS for now), > like current ABI version is 20 in DPDK_19.11 and DPDK versions until > DPDK_20.11 > will be ABI compatible with

Re: [dpdk-dev] [PATCH] doc: fix build with python 3.8

2019-12-10 Thread Bruce Richardson
On Mon, Dec 09, 2019 at 10:00:00PM +0100, Thomas Monjalon wrote: > After upgrading to python-3.8.0, a syntax mismatch is revealed: > > doc/guides/conf.py:240: SyntaxWarning: "is not" with a literal. > Did you mean "!="? > if value is not '': > > Replacing "is not" with "!=" seems the righ

[dpdk-dev] How to manage new APIs added after major ABI release?

2019-12-10 Thread Ferruh Yigit
Hi, With new process, the major ABI releases will be compatible until it is deprecated (until next LTS for now), like current ABI version is 20 in DPDK_19.11 and DPDK versions until DPDK_20.11 will be ABI compatible with this version. But if we introduce a new API after major ABI, say in 20.02 re

Re: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build

2019-12-10 Thread Laatz, Kevin
On 10/12/2019 11:07, David Marchand wrote: On Tue, Dec 3, 2019 at 4:27 PM Laatz, Kevin wrote: On 03/12/2019 11:03, David Marchand wrote: On Fri, Nov 29, 2019 at 10:09 PM Kevin Laatz wrote: With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly importa

[dpdk-dev] DPDK LLVM Error on Windows draft branch

2019-12-10 Thread Tal Shnaiderman
Hi, This question is for DPDK for windows developers who develop\ed on the https://git.dpdk.org/draft/dpdk-draft-windows/log/?h=windpdk-v18.08-clang repository which compiles with VS2017. When I try to build a Release version of DPDK I'm getting the following error: error MSB6006: "C:\Program F

Re: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build

2019-12-10 Thread David Marchand
On Tue, Dec 3, 2019 at 4:27 PM Laatz, Kevin wrote: > > On 03/12/2019 11:03, David Marchand wrote: > > On Fri, Nov 29, 2019 at 10:09 PM Kevin Laatz wrote: > >> With the recent changes made to stabilize ABI versioning in DPDK, it will > >> become increasingly important to check patches for ABI comp

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2019-12-10 Thread Burakov, Anatoly
On 07-Dec-19 5:01 PM, Kamaraj P wrote: Hello All, Currently, we are facing an issue with memory allocation failure in memseg_primary_init(). When we configure the CONFIG_RTE_MAX_MEM_MB to 512MB and correspondingly configured the number of huge pages for our platform. But the virtual memory alloc

Re: [dpdk-dev] [PATCH] ethdev: add L2TPv3 header to flow API

2019-12-10 Thread Ori Kam
Hi Rory, One general question why do we want to support only v3 and not also v2? PSB for some other comments. Best, Ori Kam > -Original Message- > From: dev On Behalf Of Rory Sexton > Sent: Wednesday, December 4, 2019 4:11 PM > To: dev@dpdk.org > Cc: qi.z.zh...@intel.com; beilei.x...@i

Re: [dpdk-dev] [RFC PATCH 2/3] doc: update link to the crypto library for armv8 PMD

2019-12-10 Thread Jerin Jacob
On Tue, Dec 10, 2019 at 1:59 PM Ruifeng Wang wrote: > > Armv8 crypto PMD now uses crypto library hosted by Arm. > Update doc with the crypto library link to reflect the change. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob > --- > doc/guides/cryp

[dpdk-dev] [PATCH v1] net/axgbe: Add a HW quirk for register definitions

2019-12-10 Thread Selwin Sebastian
V1000/R1000 processors are using the same PCI ids for the network device but has altered register definitions for determining the window settings for the indirect PCS access.Add support to check for this hardware and if found use the new register values Signed-off-by: Selwin Sebastian --- driver

[dpdk-dev] [RFC v2] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-10 Thread Suanming Mou
For some overlay network, such as VXLAN, the DSCP field in the new outer IP header after VXLAN decapsulation may need to be updated accordingly. This commit introduce the DSCP modify action for IPv4 and IPv6. Signed-off-by: Suanming Mou Acked-by: Andrew Rybchenko --- v2: * Add space to IPv4/6

Re: [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11

2019-12-10 Thread Ferruh Yigit
On 12/6/2019 11:52 PM, Stephen Hemminger wrote: > This is a resend of earlier bug fix and an additional > fix for RSS flags > > Stephen Hemminger (2): > net/netvsc: fix RSS offload flag > net/netvsc: disable before changing RSS parameters > > drivers/net/netvsc/hn_ethdev.c | 17 +

Re: [dpdk-dev] [RFC] ethdev: add IPv4/IPv6 DSCP rewrite action

2019-12-10 Thread Suanming Mou
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, December 10, 2019 3:33 PM > To: Suanming Mou ; Adrien Mazarguil > ; John McNamara ; > Marko Kovacevic ; Thomas Monjalon > ; Ferruh Yigit > Cc: dev@dpdk.org; Shahaf Shuler ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > > Subj

[dpdk-dev] [RFC PATCH 3/3] crypto/armv8: fix clang build

2019-12-10 Thread Ruifeng Wang
1. Clang requires braces around initialization of subobject. 2. Clang complains implicit conversion of enumeration type. Trapped issue with Clang version 8.0 and CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO was set. Error messages: rte_armv8_pmd.c:144:2: error: suggest braces around initialization of subob

[dpdk-dev] [RFC PATCH 1/3] crypto/armv8: link PMD to crypto library hosted by Arm

2019-12-10 Thread Ruifeng Wang
Armv8 crypto PMD linked to armv8_crypto library created by Marvell. Maintenance of armv8_crypto library will be discontinued. Change Armv8 PMD to link to AArch64 crypto library hosted by Arm. Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Li

[dpdk-dev] [RFC PATCH 2/3] doc: update link to the crypto library for armv8 PMD

2019-12-10 Thread Ruifeng Wang
Armv8 crypto PMD now uses crypto library hosted by Arm. Update doc with the crypto library link to reflect the change. Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- doc/guides/cryptodevs/armv8.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc

[dpdk-dev] [RFC PATCH 0/3] armv8 crypto PMD update

2019-12-10 Thread Ruifeng Wang
Maintainance of armv8_crypto library created by Marvell/Cavium will be discontinued. Going forward, Armv8 crypto PMD will link to AArch64 crypto library hosted by Arm. Patch 1/3, 2/3 update source code and document respectively to reflect the change. Patch 3/3 fixed Clang build issue when Armv8 cr

Re: [dpdk-dev] discussion: creating a new class for vdpa driversxiao.w.w...@intel.com

2019-12-10 Thread Thomas Monjalon
10/12/2019 03:41, Tiwei Bie: > On Mon, Dec 09, 2019 at 02:22:27PM +0300, Andrew Rybchenko wrote: > > On 12/9/19 1:41 PM, Ori Kam wrote: > > > From: Andrew Rybchenko > > >> On 12/8/19 10:06 AM, Matan Azrad wrote: > > >>> From: Andrew Rybchenko > > On 12/6/19 8:32 AM, Liang, Cunming wrote: > > >

  1   2   >