On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote:
> Add support for the notify queue, which is used for events
> published by the NIC.
>
> Signed-off-by: Alfredo Cardigliano <cardigli...@ntop.org>
> Reviewed-by: Shannon Nelson <snel...@pensando.io>
<...>
> +static int
> +ionic_lif_notifyq_init(struct ionic_lif *lif)
> +{
> + struct ionic_dev *idev = &lif->adapter->idev;
> + struct ionic_qcq *qcq = lif->notifyqcq;
> + struct ionic_queue *q = &qcq->q;
> + int err;
> +
> + struct ionic_admin_ctx ctx = {
> + .pending_work = true,
> + .cmd.q_init = {
> + .opcode = IONIC_CMD_Q_INIT,
> + .lif_index = lif->index,
> + .type = q->type,
> + .index = q->index,
> + .flags = (IONIC_QINIT_F_IRQ | IONIC_QINIT_F_ENA),
> + .intr_index = qcq->intr.index,
> + .pid = q->pid,
> + .ring_size = ilog2(q->num_descs),
> + .ring_base = q->base_pa,
> + }
> + };
> +
> + IONIC_PRINT(DEBUG, "notifyq_init.pid %d", ctx.cmd.q_init.pid);
> + IONIC_PRINT(DEBUG, "notifyq_init.index %d",
> + ctx.cmd.q_init.index);
> + IONIC_PRINT(DEBUG, "notifyq_init.ring_base 0x%lx",
> + ctx.cmd.q_init.ring_base);
> + IONIC_PRINT(DEBUG, "notifyq_init.ring_size %d",
> + ctx.cmd.q_init.ring_size);
Can you plesae use PRIx64 etc format identifiers to have correct type? The build
is failing in 32 bits just because of log format identifiers.
There are a few cases this is needed, building for i686 should highlight them.
