Re: [dpdk-dev] [PATCH] config: disable iova phys for dpaa and 1588 for dpaa2

2019-10-30 Thread Nipun Gupta
Hi David, > > > > > -Original Message- > > > From: David Marchand > > > Subject: Re: [dpdk-dev] [PATCH] config: disable iova phys for dpaa and > 1588 > > > for dpaa2 > > > > > > On Fri, Oct 4, 2019 at 1:26 PM Nipun Gupta > wrote: > > > > > > > > IOVA_PHYS flag is not required in the DPAA

Re: [dpdk-dev] [EXT] [PATCH v2 5/6] mempool: prevent objects from being across pages

2019-10-30 Thread Vamsi Krishna Attunuru
Hi Olivier, Thanks for reworked patches. With V2, Tests with 512MB & 2M page sizes work fine with octeontx2 mempool pmd. One more concern is, octeontx fpa mempool driver also has the similar requirements. How do we address that, Can you suggest the best way to avoid code duplication in PMDs. R

Re: [dpdk-dev] [PATCH v4 1/3] security: add anti replay window size

2019-10-30 Thread Anoob Joseph
Hi Hemant, How would the PMD specify whether anit-replay is supported or not? Do you have plans to introduce it as a capability? Or do you expect the session creation to fail if the feature is not supported by underlying PMD and the anti replay window size is set. Thanks, Anoob > -Origina

[dpdk-dev] [PATCH 0/3] net/enic: fixes for cosmetic issues

2019-10-30 Thread Hyong Youb Kim
These patches fix 3 cosmetic issues discovered during rc1 testing. For example, removing useless/misleading error messages and adding a space in log messages. Thanks. -Hyong Hyong Youb Kim (3): net/enic: fix whitespaces in log macros net/enic: fix speed capabilities for the new VF net/enic:

[dpdk-dev] [PATCH 2/3] net/enic: fix speed capabilities for the new VF

2019-10-30 Thread Hyong Youb Kim
VFs all have subsystem ID 0. VIC models with the latest VF are at least 40G, so report that as a more reasonable speed than 10G. Fixes: 57bb45b37bdf ("net/enic: add PCI id for new virtual function") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 6 ++

[dpdk-dev] [PATCH 1/3] net/enic: fix whitespaces in log macros

2019-10-30 Thread Hyong Youb Kim
Add a space between the function name and message. Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_compat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/enic/

[dpdk-dev] [PATCH 3/3] net/enic: suppress unwanted error messages

2019-10-30 Thread Hyong Youb Kim
Do not log errors when CMD_OVERLAY_OFFLOAD_CTRL and CMD_GET_SUPP_FEATURE_VER fail, as they are only used to probe if a feature is provisioned. They are expected to fail if the feature is not provisioned. Do not log an error when disabling Geneve offload fails. It is expected to fail if this featur

[dpdk-dev] [PATCH v3] net/ice: remove GTPU tunnel support for inner L4

2019-10-30 Thread Yahui Cao
Remove unsupported flow as title. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_fil

[dpdk-dev] [PATCH v4 1/3] security: add anti replay window size

2019-10-30 Thread Hemant Agrawal
At present the ipsec xfrom is missing the important step to configure the anti replay window size. The newly added field will also help in to enable or disable the anti replay checking, if available in offload by means of non-zero or zero value. Signed-off-by: Hemant Agrawal --- doc/guides/rel_n

[dpdk-dev] [PATCH v4 2/3] ipsec: remove redundant replay_win_sz

2019-10-30 Thread Hemant Agrawal
The rte_security lib has introduced replay_win_sz, so it can be removed from the rte_ipsec lib. Also, the relaved tests,app are also update to reflect the usages. Signed-off-by: Hemant Agrawal --- app/test/test_ipsec.c | 2 +- doc/guides/rel_notes/release_19_11.rst | 7 +--

[dpdk-dev] [PATCH v4 3/3] crypto/dpaa2_sec: enable anti replay window config

2019-10-30 Thread Hemant Agrawal
This patch usages the anti replay window size to config the anti replay checking in decap path for lookaside IPSEC offload Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 21 + drivers/crypto/dpaa_sec/dpaa_sec.c | 26 +

[dpdk-dev] [PATCH] net/ice/base: fix wrong symmetric hash configure

2019-10-30 Thread Qi Zhang
When a new hash profie is created, we need to reset all related GLQF_HSYMM registers, otherwise unexpected hash behaviour may happens on packet that hit that profile. The patch fix the issue that we only do reset when symmetric hash is required, but actually for non symmmetric hash we also need th

[dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting

2019-10-30 Thread Sun GuinanX
macsec setting is not valid when port is stopped. In order to make it valid, the patch changes the setting to where port is started. Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Sun GuinanX --- v6: * Modified inappropriate parameter namin

[dpdk-dev] [PATCH v2] net/ice: remove GTPU tunnel support for inner L4

2019-10-30 Thread Yahui Cao
Currently, share code only support inner L3 matching. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/

Re: [dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4

2019-10-30 Thread Ye Xiaolong
Hi, yahui Prefer to give more details like why we need this patch in commit log. Thanks, Xiaolong On 10/31, Yahui Cao wrote: >Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") > >Signed-off-by: Yahui Cao >--- > drivers/net/ice/ice_fdir_filter.c | 4 > 1 file changed, 4 dele

[dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4

2019-10-30 Thread Yahui Cao
Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 736ccd54e..d80dafa20 100644 --- a/

Re: [dpdk-dev] [PATCH v14 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-10-30 Thread Pei, Andy
Thanks Xiaolong. -Original Message- From: Ye, Xiaolong Sent: Thursday, October 31, 2019 10:01 AM To: Pei, Andy Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei ; Yigit, Ferruh Subject: Re: [PATCH v14 00/19] add PCIe AER disable and IRQ support for ipn3ke On 10/28, Andy Pei wrote: >This pa

Re: [dpdk-dev] [PATCH v14 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-10-30 Thread Xu, Rosen
Thanks Xiaolong. > -Original Message- > From: Ye, Xiaolong > Sent: Thursday, October 31, 2019 10:01 > To: Pei, Andy > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Yigit, Ferruh > Subject: Re: [PATCH v14 00/19] add PCIe AER disable and IRQ support for > ipn3ke > > On 10/28, Andy Pei

Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix macsec setting

2019-10-30 Thread Ye Xiaolong
On 10/30, Sun GuinanX wrote: >macsec setting is not valid when port is stopped. >In order to make it valid, the patch changes the setting >to where port is started. > >Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") >Cc: sta...@dpdk.org [snip] > >+void >+ixgbe_dev_macsec_regis

Re: [dpdk-dev] [PATCH v14 00/19] add PCIe AER disable and IRQ support for ipn3ke

2019-10-30 Thread Ye Xiaolong
On 10/28, Andy Pei wrote: >This patch set adds PCIe AER disable and FPGA interrupt support for >ipn3ke. It also provides a small rework for port bonding between FPGA >line side port and I40e PF port. > >What is the PCI Express AER(Advanced Error Reporting)? >Advanced Error Reporting capability is i

[dpdk-dev] [DPDK] net/ice: set vlan tpid is not supported by ice

2019-10-30 Thread taox . zhu
From: Zhu Tao Set vlan tpid is not supported by ice hardware. Delete driver code that doesn't work. Signed-off-by: Zhu Tao --- drivers/net/ice/ice_ethdev.c | 54 1 file changed, 54 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ic

Re: [dpdk-dev] [PATCH] net/ice: disable useless interrupt

2019-10-30 Thread Zhao1, Wei
Tested-by: Qi Fu < qi...@intel.com> > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, October 30, 2019 3:47 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Ye, Xiaolong > ; Zhao1, Wei > Subject: [PATCH] net/ice: disable useless interrupt > > This is a useless interrup

Re: [dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-10-30 Thread Wang, Haiyue
Hi Olivier, Very appreciate your response, please see reply below. > -Original Message- > From: Olivier Matz > Sent: Thursday, October 31, 2019 00:56 > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by > dynamic mbuf API >

[dpdk-dev] [PATCH v7 14/14] net/mlx5: split hairpin flows

2019-10-30 Thread Ori Kam
Since the encap action is not supported in RX, we need to split the hairpin flow into RX and TX. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 10 ++ drivers/net/mlx5/mlx5.h| 10 ++ drivers/net/mlx5/mlx5_flow.c | 281 +

[dpdk-dev] [PATCH v7 13/14] net/mlx5: add default flows for hairpin

2019-10-30 Thread Ori Kam
When using hairpin all traffic from TX hairpin queues should jump to dedecated table where matching can be done using regesters. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_flow.c| 60 ++

[dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support

2019-10-30 Thread Ori Kam
This commit introduce the hairpin queues to the testpmd. the hairpin queue is configured using --hairpinq= the hairpin queue adds n queue objects for both the total number of TX queues and RX queues. The connection between the queues are 1 to 1, first Rx hairpin queue will be connected to the first

[dpdk-dev] [PATCH v7 10/14] net/mlx5: add support for hairpin hrxq

2019-10-30 Thread Ori Kam
Add support for rss on hairpin queues. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 3 ++ drivers/net/mlx5/mlx5_ethdev.c | 102 ++-- drivers/net/mlx5/mlx5_rss.c | 1 + drivers/net/mlx5/mlx5_rxq.c |

[dpdk-dev] [PATCH v7 12/14] net/mlx5: add id generation function

2019-10-30 Thread Ori Kam
When splitting flows for example in hairpin / metering, there is a need to combine the flows. This is done using ID. This commit introduce a simple way to generate such IDs. The reason why bitmap was not used is due to fact that the release and allocation are O(n) while in the chosen approch the a

[dpdk-dev] [PATCH v7 11/14] net/mlx5: add internal tag item and action

2019-10-30 Thread Ori Kam
This commit introduce the setting and matching on regiters. This item and and action will be used with number of different features like hairpin, metering, metadata. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c| 52 + drivers/net/mlx5/m

[dpdk-dev] [PATCH v7 09/14] net/mlx5: add hairpin binding function

2019-10-30 Thread Ori Kam
When starting the port, in addition to creating the queues we need to bind the hairpin queues. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_devx_cmds.c | 1 + drivers/net/mlx5/mlx5_prm.h | 6 +++ drivers/net/ml

[dpdk-dev] [PATCH v7 06/14] net/mlx5: support Tx hairpin queues

2019-10-30 Thread Ori Kam
This commit adds the support for creating Tx hairpin queues. Hairpin queue is a queue that is created using DevX and only used by the HW. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 36 +- drivers/net/mlx5/mlx5.h | 46 d

[dpdk-dev] [PATCH v7 07/14] net/mlx5: add get hairpin capabilities

2019-10-30 Thread Ori Kam
This commits adds the hairpin get capabilities function. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_19_11.rst | 1 + drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 3 ++- drivers/net/mlx5/mlx5_ethdev.c

[dpdk-dev] [PATCH v7 04/14] net/mlx5: support Rx hairpin queues

2019-10-30 Thread Ori Kam
This commit adds the support for creating Rx hairpin queues. Hairpin queue is a queue that is created using DevX and only used by the HW. This results in that all the data part of the RQ is not being used. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v7 03/14] net/mlx5: query hca hairpin capabilities

2019-10-30 Thread Ori Kam
This commit query and store the hairpin capabilities from the device. Those capabilities will be used when creating the hairpin queue. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 4 drivers/net/mlx5/mlx5_devx_cmds.c | 7 +++ 2 files ch

[dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue

2019-10-30 Thread Ori Kam
This commit introduce hairpin queue type. The hairpin queue in build from Rx queue binded to Tx queue. It is used to offload traffic coming from the wire and redirect it back to the wire. There are 3 new functions: - rte_eth_dev_hairpin_capability_get - rte_eth_rx_hairpin_queue_setup - rte_eth_tx

[dpdk-dev] [PATCH v7 00/14] add hairpin feature

2019-10-30 Thread Ori Kam
This patch set implements the hairpin feature. The hairpin feature was introduced in RFC[1] The hairpin feature (different name can be forward) acts as "bump on the wire", meaning that a packet that is received from the wire can be modified using offloaded action and then sent back to the wire wit

[dpdk-dev] [PATCH v7 05/14] net/mlx5: prepare txq to work with different types

2019-10-30 Thread Ori Kam
Currenlty all Tx queues are created using Verbs. This commit modify the naming so it will not include verbs, since in next commit a new type will be introduce (hairpin) Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v7 01/14] ethdev: move queue state defines to private file

2019-10-30 Thread Ori Kam
The queue state defines are internal to the DPDK. This commit moves them to a private header file. Signed-off-by: Ori Kam Reviewed-by: Andrew Rybchenko --- drivers/net/nfb/nfb_tx.h | 1 + lib/librte_ethdev/rte_ethdev.h| 6 -- lib/librte_ethdev/rte_ethdev_driver.h | 6 ++

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-30 Thread Thomas Monjalon
30/10/2019 17:09, Ilya Maximets: > On 30.10.2019 16:49, Thomas Monjalon wrote: > > 30/10/2019 16:07, Ilya Maximets: > >> On 29.10.2019 19:50, Thomas Monjalon wrote: > >>> In a virtual environment, the network controller may have to configure > >>> some SR-IOV VF parameters for security reasons. > >

Re: [dpdk-dev] [PATCH 1/3] net/qede/base: fix for FW bug

2019-10-30 Thread Rasesh Mody
Hi Kevin, >From: Rasesh Mody >Sent: Monday, October 21, 2019 11:53 AM > >Hi Kevin, > >>From: Kevin Traynor >>Sent: Monday, October 21, 2019 3:58 AM >> >>On 20/10/2019 06:20, Rasesh Mody wrote: >>> In our testing we have identified a critical FW bug. Performance is >>> degraded significantly for

Re: [dpdk-dev] [PATCH v5 1/1] fbarray: fix duplicated fbarray file in secondary

2019-10-30 Thread Ananyev, Konstantin
> -Original Message- > From: Yasufumi Ogawa > Sent: Wednesday, October 30, 2019 1:42 PM > To: Ananyev, Konstantin ; Burakov, Anatoly > ; david.march...@redhat.com > Cc: dev@dpdk.org; sta...@dpdk.org; Yasufumi Ogawa > > Subject: Re: [dpdk-dev] [PATCH v5 1/1] fbarray: fix duplicated fba

Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: fix the meson compile issue

2019-10-30 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Wednesday, October 30, 2019 4:23 AM > >On 10/29/2019 11:09 AM, Gavin Hu wrote: >> The definition is conflicting with that of the compiler, as show the >> following error: ../drivers/net/bnx2x/bnx2x_osal.h:27:17: error: >> conflicting types for ‘uint64_t’ #define __le64

[dpdk-dev] DPDK QoS scheduler changes, are we there yet?

2019-10-30 Thread Gladchun, Glenn
Hi guys, I stumbled upon this 11 month old post (https://narkive.com/ZwBXg4Xe) that goes over future enhancements to the scheduler. All of them are vital, and I am especially interested in 16 TCs per pipe… Christian and/or Jasvinder, is the future here yet in some tangible shape or form? Than

[dpdk-dev] [PATCH] net/octeontx2: fix compilation with x86_x32

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh x86_x32 compilation failing due to incorrect format specifiers in logs. Fixes: a78b9246723b ("net/octeontx2: add remaining PTP operations") Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx2/otx2_ptp.c | 15 --- 1 file changed, 8 insertions(+), 7 deleti

Re: [dpdk-dev] [PATCH v8 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-10-30 Thread Jerin Jacob
On Wed, Oct 30, 2019 at 9:57 PM wrote: > > From: Pavan Nikhilesh > > This patchset adds a new application to demonstrate the usage of event > mode. The poll mode is also available to help with the transition. > > The following new command line parameters are added: > --mode: Dictates the mode of

[dpdk-dev] Mbuf memory alignment constraints for (micro)architectures

2019-10-30 Thread Jerin Jacob Kollanukkaran
CC: Arch and platform maintainers While reviewing the mempool objection allocation requirements in the code, A) it's found that in the default case, mempool objects have padding in the object trailer to have start addresses of objects among the different channels, to enable equally load on th

Re: [dpdk-dev] [pull-request] next-eventdev 19.11 RC1 - Iteration 2

2019-10-30 Thread Jerin Jacob
On Fri, Oct 18, 2019 at 1:49 PM Jerin Jacob Kollanukkaran wrote: > > The following changes since commit b36f587f010bba421a8fd0b4c383276ecb796ae3: > > rcu: fix spurious thread unregister (2019-10-18 06:13:36 +0200) > > are available in the Git repository at: > > http://dpdk.org/git/next/dpdk-ne

Re: [dpdk-dev] [PATCH v2 1/2] net/octeontx2: add support to enable switch type

2019-10-30 Thread Jerin Jacob
On Wed, Oct 23, 2019 at 8:56 PM wrote: > > From: Kiran Kumar K > > Adding support to configure specific switch types like high2 and dsa > on a port. When this switch type is configured, it is expected that > all the traffic on that port should be of specific type only. > > Signed-off-by: Kiran Ku

Re: [dpdk-dev] Performance impact of "declaring" more CPU cores

2019-10-30 Thread Tom Barbette
Thanks for your comment. The raw number of cache misses is just higher almost in every function. While hwloc is indeed useful, the assignation is exactly the same in all cases. What we do is to define with "-l" more or less *unused* cores. But the used ones run at the same place, with the same r

[dpdk-dev] [PATCH v6 0/2] extend flow metadata feature

2019-10-30 Thread Viacheslav Ovsiienko
This patchset just combines two metadata related patches to provide right applying order. The first patch introduces the ingress metadata with mbuf dynamic field usage, the second one moves egress metadata to the dynamic field presented by first patch. Signed-off-by: Viacheslav Ovsiienko Viaches

[dpdk-dev] [PATCH v6 2/2] ethdev: move egress metadata to dynamic field

2019-10-30 Thread Viacheslav Ovsiienko
The dynamic mbuf fields were introduced by [1]. The egress metadata is good candidate to be move from statically allocated field tx_metadata to dynamic one. Because mbufs are used in half-duplex fashion only, it is safe to share this dynamic field with ingress metadata. The shared dynamic field co

[dpdk-dev] [PATCH v6 1/2] ethdev: extend flow metadata

2019-10-30 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r

[dpdk-dev] [PATCH v8 10/10] doc: add application usage guide for l2fwd-event

2019-10-30 Thread pbhagavatula
From: Sunil Kumar Kori Add documentation for l2fwd-event example. Update release notes. Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 1 + doc/guides/rel_notes/release_19_11.rst| 6 + doc/guides/sample_app_ug/index.rst| 1 + doc/g

Re: [dpdk-dev] [PATCH v2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-10-30 Thread Olivier Matz
Hi Haiyue, Please see some comments below. On Tue, Oct 29, 2019 at 03:34:48PM +0800, Haiyue Wang wrote: > The original design is to use rte_mbuf::udata64 to save the metadata of > protocol extraction which has network protocol data fields and type, an nit: an -> a > private API is used to decod

[dpdk-dev] [PATCH v8 09/10] examples/l2fwd-event: add graceful teardown

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh Add graceful teardown that addresses both event mode and poll mode. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/main.c | 50 + 1 file changed, 40 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd-event/main.c b/exa

[dpdk-dev] [PATCH v8 08/10] examples/l2fwd-event: add eventdev main loop

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh Add event dev main loop based on enabled l2fwd options and eventdev capabilities. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_common.c | 6 + examples/l2fwd-event/l2fwd_common.h | 1 + examples/l2fwd-event/l2fwd_event.c | 238 +++

Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-10-30 Thread Ajit Khaparde
On Wed, Oct 30, 2019 at 12:43 AM David Marchand wrote: > Hello Ajit, Kevin, > > On Wed, Oct 2, 2019 at 3:29 AM Ajit Khaparde > wrote: > > > > On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor > wrote: > > > > > If rc contains a non-zero return code from bnxt_hwrm_send_message(), > > > HWRM_CHECK_RES

[dpdk-dev] [PATCH v8 05/10] examples/l2fwd-event: add eventdev queue and port setup

2019-10-30 Thread pbhagavatula
From: Sunil Kumar Kori Add event device queue and port setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c| 9 +- examples/l2fwd-event/l2fwd_event.h| 10 ++ examples/

[dpdk-dev] [PATCH v8 06/10] examples/l2fwd-event: add event Rx/Tx adapter setup

2019-10-30 Thread pbhagavatula
From: Sunil Kumar Kori Add event eth Rx/Tx adapter setup for both generic and internal port event device pipelines. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c| 3 + examples/l2fwd-event/l2fwd_event.h| 16 +++

[dpdk-dev] [PATCH v8 07/10] examples/l2fwd-event: add service core setup

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh Setup service cores for eventdev and Rx/Tx adapter when they don't have internal port capability. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c | 82 ++ examples/l2fwd-event/l2fwd_event.h | 1 + examples/l2fwd-event/mai

[dpdk-dev] [PATCH v8 04/10] examples/l2fwd-event: add event device setup

2019-10-30 Thread pbhagavatula
From: Sunil Kumar Kori Add event device device setup based on event eth Tx adapter capabilities. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_event.c| 3 + examples/l2fwd-event/l2fwd_event.h| 16 examples/l2fwd-eve

[dpdk-dev] [PATCH v8 02/10] examples/l2fwd-event: add infra for eventdev

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh Add infra to select event device as a mode to process packets through command line arguments. Also, allow the user to select the schedule type to be RTE_SCHED_TYPE_ORDERED, RTE_SCHED_TYPE_ATOMIC or RTE_SCHED_TYPE_PARALLEL. Usage: `--mode="eventdev"` or `--mode="poll"` `--e

[dpdk-dev] [PATCH v8 03/10] examples/l2fwd-event: add infra to split eventdev framework

2019-10-30 Thread pbhagavatula
From: Sunil Kumar Kori Add infra to split eventdev framework based on event Tx adapter capability. If event Tx adapter has internal port capability then we use `rte_event_eth_tx_adapter_enqueue` to transmitting packets else we use a SINGLE_LINK event queue to enqueue packets to a service core whi

[dpdk-dev] [PATCH v8 00/10] example/l2fwd-event: introduce l2fwd-event example

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds a new application to demonstrate the usage of event mode. The poll mode is also available to help with the transition. The following new command line parameters are added: --mode: Dictates the mode of operation either poll or event. --eventq_sched: Dict

[dpdk-dev] [PATCH v8 01/10] examples/l2fwd-event: add default poll mode routines

2019-10-30 Thread pbhagavatula
From: Pavan Nikhilesh Add the default l2fwd poll mode routines similar to examples/l2fwd. Signed-off-by: Sunil Kumar Kori Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 5 + examples/Makefile | 1 + examples/l2fwd-event/Makefile | 59

Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: skip flow control on lbk ports

2019-10-30 Thread Jerin Jacob
On Wed, Oct 30, 2019 at 11:24 AM wrote: > > From: Vamsi Attunuru > > LBK interface does not support any flow control related > HW configurations. > > Skip flow control set requests on LBK bound ethports. > > Signed-off-by: Harman Kalra > Signed-off-by: Vamsi Attunuru Acked-by: Jerin Jacob Ap

Re: [dpdk-dev] [PATCH v5] ethdev: extend flow metadata

2019-10-30 Thread Olivier Matz
On Wed, Oct 30, 2019 at 03:58:04PM +, Slava Ovsiienko wrote: > > -Original Message- > > From: Olivier Matz > > Sent: Wednesday, October 30, 2019 17:20 > > To: Slava Ovsiienko > > Cc: Andrew Rybchenko ; dev@dpdk.org; > > Matan Azrad ; Raslan Darawsheh > > ; Thomas Monjalon > > Subject

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-30 Thread Ilya Maximets
On 30.10.2019 16:49, Thomas Monjalon wrote: 30/10/2019 16:07, Ilya Maximets: On 29.10.2019 19:50, Thomas Monjalon wrote: In a virtual environment, the network controller may have to configure some SR-IOV VF parameters for security reasons. When the PF (host port) is driven by DPDK (OVS-DPDK ca

Re: [dpdk-dev] [PATCH v5] ethdev: extend flow metadata

2019-10-30 Thread Slava Ovsiienko
> -Original Message- > From: Olivier Matz > Sent: Wednesday, October 30, 2019 17:20 > To: Slava Ovsiienko > Cc: Andrew Rybchenko ; dev@dpdk.org; > Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon > Subject: Re: [PATCH v5] ethdev: extend flow metadata > > Hi, > > On Wed, Oct 30, 2019

Re: [dpdk-dev] [PATCH v5] ethdev: extend flow metadata

2019-10-30 Thread Thomas Monjalon
30/10/2019 16:20, Olivier Matz: > > From: Slava Ovsiienko > > > > On 10/29/19 10:31 PM, Viacheslav Ovsiienko wrote: > > > > > Currently, metadata can be set on egress path via mbuf tx_metadata > > > > > field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META > > > > matches metadata. > > > > >

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-30 Thread Thomas Monjalon
30/10/2019 16:07, Ilya Maximets: > On 29.10.2019 19:50, Thomas Monjalon wrote: > > In a virtual environment, the network controller may have to configure > > some SR-IOV VF parameters for security reasons. > > > > When the PF (host port) is driven by DPDK (OVS-DPDK case), > > we face two different

Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata

2019-10-30 Thread Olivier Matz
Hi, On Wed, Oct 30, 2019 at 10:35:16AM +0300, Andrew Rybchenko wrote: > @Olivier, please, take a look at the end of the mail. > (...) > On 10/29/19 8:19 PM, Slava Ovsiienko wrote: > > > > +}; > > > > + > > > > +/* Mbuf dynamic field offset for metadata. */ extern int > > > > +rte_flow_dynf_meta

[dpdk-dev] DPDK QoS scheduler changes, are we there yet?

2019-10-30 Thread Gladchun, Glenn
Hi guys, I stumbled upon this 11 month old post (https://narkive.com/ZwBXg4Xe) that goes over future enhancements to the scheduler. All of them are vital, and I am especially interested in 16 TCs per pipe… Christian and/or Jasvinder, is the future here yet in some tangible shape or form? Than

Re: [dpdk-dev] [PATCH v5] ethdev: extend flow metadata

2019-10-30 Thread Olivier Matz
Hi, On Wed, Oct 30, 2019 at 02:46:06PM +, Slava Ovsiienko wrote: > > -Original Message- > > From: Slava Ovsiienko > > Sent: Wednesday, October 30, 2019 16:41 > > To: Andrew Rybchenko ; dev@dpdk.org > > Cc: Matan Azrad ; Raslan Darawsheh > > ; Thomas Monjalon ; > > olivier.m...@6wind.co

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-30 Thread Ilya Maximets
On 29.10.2019 19:50, Thomas Monjalon wrote: In a virtual environment, the network controller may have to configure some SR-IOV VF parameters for security reasons. When the PF (host port) is driven by DPDK (OVS-DPDK case), we face two different cases: - driver is bifurcated (Mellanox case),

Re: [dpdk-dev] [PATCH v2 6/6] mempool: use the specific macro for object alignment

2019-10-30 Thread Andrew Rybchenko
On 10/30/19 5:36 PM, Olivier Matz wrote: For consistency, RTE_MEMPOOL_ALIGN should be used in place of RTE_CACHE_LINE_SIZE. They have the same value, because the only arch that was defining a specific value for it has been removed from dpdk. Signed-off-by: Olivier Matz Reviewed-by: Andrew Ryb

Re: [dpdk-dev] [EXT] [PATCH 5/5] mempool: prevent objects from being across pages

2019-10-30 Thread Jerin Jacob
On Wed, Oct 30, 2019 at 8:03 PM Olivier Matz wrote: > > Hi Jerin, > > On Wed, Oct 30, 2019 at 02:08:40PM +0530, Jerin Jacob wrote: > > On Wed, Oct 30, 2019 at 1:16 PM Andrew Rybchenko > > wrote: > > > > > > > > >> int > > > >> rte_mempool_op_populate_default(struct rte_mempool *mp, unsigned i

Re: [dpdk-dev] [PATCH v5] ethdev: extend flow metadata

2019-10-30 Thread Slava Ovsiienko
> -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, October 30, 2019 16:41 > To: Andrew Rybchenko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; > olivier.m...@6wind.com > Subject: RE: [PATCH v5] ethdev: extend flow metadata > > > -Original Messag

Re: [dpdk-dev] [PATCH v5] ethdev: extend flow metadata

2019-10-30 Thread Slava Ovsiienko
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, October 30, 2019 10:02 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; > olivier.m...@6wind.com; Yongseok Koh > Subject: Re: [PATCH v5] ethdev: extend flow metadata > > On 10/

[dpdk-dev] [PATCH v2 2/6] mempool: reduce wasted space on mempool populate

2019-10-30 Thread Olivier Matz
The size returned by rte_mempool_op_calc_mem_size_default() is aligned to the specified page size. Therefore, with big pages, the returned size can be much more that what we really need to populate the mempool. For instance, populating a mempool that requires 1.1GB of memory with 1GB hugepages can

[dpdk-dev] [PATCH v2 5/6] mempool: prevent objects from being across pages

2019-10-30 Thread Olivier Matz
When populating a mempool, ensure that objects are not located across several pages, except if user did not request iova contiguous objects. Signed-off-by: Vamsi Krishna Attunuru Signed-off-by: Olivier Matz --- drivers/mempool/octeontx2/Makefile | 3 + drivers/mempool/octeontx2/meso

[dpdk-dev] [PATCH v2 1/6] mempool: allow unaligned addr/len in populate virt

2019-10-30 Thread Olivier Matz
rte_mempool_populate_virt() currently requires that both addr and length are page-aligned. Remove this uneeded constraint which can be annoying with big hugepages (ex: 1GB). Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c | 23 +++-

[dpdk-dev] [PATCH v2 0/6] mempool: avoid objects allocations across pages

2019-10-30 Thread Olivier Matz
KNI supposes that mbufs are contiguous in kernel virtual memory. This may not be true when using the IOVA=VA mode. To fix this, a possibility is to ensure that objects do not cross page boundaries in mempool. This patchset implements this in the last patch (5/5). The previous patches prepare the j

[dpdk-dev] [PATCH v2 6/6] mempool: use the specific macro for object alignment

2019-10-30 Thread Olivier Matz
For consistency, RTE_MEMPOOL_ALIGN should be used in place of RTE_CACHE_LINE_SIZE. They have the same value, because the only arch that was defining a specific value for it has been removed from dpdk. Signed-off-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 2 +- lib/librte

[dpdk-dev] [PATCH v2 4/6] mempool: introduce function to get mempool page size

2019-10-30 Thread Olivier Matz
In rte_mempool_populate_default(), we determine the page size, which is needed for calc_size and allocation of memory. Move this in a function and export it, it will be used in next commit. Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c

[dpdk-dev] [PATCH v2 3/6] mempool: remove optimistic IOVA-contiguous allocation

2019-10-30 Thread Olivier Matz
The previous commit reduced the amount of required memory when populating the mempool with non iova-contiguous memory. Since there is no big advantage to have a fully iova-contiguous mempool if it is not explicitly asked, remove this code, it simplifies the populate function. Signed-off-by: Olivi

Re: [dpdk-dev] [EXT] [PATCH 5/5] mempool: prevent objects from being across pages

2019-10-30 Thread Olivier Matz
Hi Jerin, On Wed, Oct 30, 2019 at 02:08:40PM +0530, Jerin Jacob wrote: > On Wed, Oct 30, 2019 at 1:16 PM Andrew Rybchenko > wrote: > > > > > >> int > > >> rte_mempool_op_populate_default(struct rte_mempool *mp, unsigned int > > >> max_objs, > > >> void *vaddr, rte_iova_t iova, s

Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size

2019-10-30 Thread Olivier Matz
On Wed, Oct 30, 2019 at 09:32:08AM +0100, Olivier Matz wrote: > On Tue, Oct 29, 2019 at 06:20:47PM +0100, Olivier Matz wrote: > > On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > > > On 10/28/19 5:01 PM, Olivier Matz wrote: > > > > In rte_mempool_populate_default(), we determine

Re: [dpdk-dev] [PATCH v6 00/12] Add an option to use LTO for DPDK build

2019-10-30 Thread Aaron Conole
Andrzej Ostruszka writes: > On 10/29/19 3:12 PM, Andrzej Ostruszka wrote: >> This patch series adds an option to make use of link time optimization >> (if compiler has support for it). > [...] >> .travis.yml | 7 > [...] > > Aaron, Michael, all > > I'd prob

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-30 Thread Ananyev, Konstantin
Hi Akhil, > > > > > Added my comments inline with your draft. > > > > > [snip].. > > > > > > > > > > > > > > > > > Ok, then my suggestion: > > > > > > Let's at least write down all points about crypto-dev approach > > > > > > where we > > > > > > disagree and then probably try to resolve them o

[dpdk-dev] Link status issue with i40e firmware 7.0x

2019-10-30 Thread David Marchand
Hello, We recently upgraded a XXV710 nic on a Dell R740 server (running RHEL 7.7) to firmware version 7.00. # ethtool -i enp59s0f0 driver: i40e version: 2.8.10-k firmware-version: 7.00 0x80004cf8 1.2154.0 expansion-rom-version: bus-info: :3b:00.0 supports-statistics: yes supports-test: yes su

[dpdk-dev] [PATCH] net/mlx5: port id action must be after VLAN actions

2019-10-30 Thread Xiaoyu Min
Rdma-core needs the dst_vport (port_id) action be after push/pop VLAN and modify hdr actions otherwise it will reject to create rule. This pach validates the port_id is after push/pop VLAN and set VLAN VID/PCP otherwise PMD spits out errors. Fixes: 5f163d520cff ("net/mlx5: support modify VLAN ID

[dpdk-dev] [PATCH v1 1/1] net/octeontx2: add SDP interface support

2019-10-30 Thread Subrahmanyam Nilla
System DPI Packet Interface Unit (SDP) is a co-processor of OCTEON TX2 which provides PCIe endpoint support for a remote host to DMA packets into and out of the OCTEON TX2 SoC. SDP interface comes in to live only when it is connected in EP mode. It exposes input and output queue pairs to remote hos

Re: [dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized

2019-10-30 Thread Ye Xiaolong
Latest update, since i40e now has added FDIR ID to vector rx after patchset https://patches.dpdk.org/cover/60820/ being merged, this patch is no longer needed, so just drop it from next-net-intel. Thanks, Xiaolong On 10/28, Ye Xiaolong wrote: >Sorry for missing this patch for a long time. > >On 0

Re: [dpdk-dev] [PATCH v1 1/1] net/octeontx2: fix VF index in VF action

2019-10-30 Thread Jerin Jacob
On Tue, Oct 29, 2019 at 11:50 PM wrote: > > From: Vamsi Attunuru > > VF index needs to be checked against maxvf count > before incrementing it for preparing pf_func. > > Fixes: 520270d518 ("net/octeontx2: support PF and VF action") Cc: sta...@dpdk.rog > Signed-off-by: Vamsi Attunuru Acked-by:

Re: [dpdk-dev] [PATCH v5 1/1] fbarray: fix duplicated fbarray file in secondary

2019-10-30 Thread Yasufumi Ogawa
On 2019/10/29 21:03, Ananyev, Konstantin wrote: -Original Message- From: dev On Behalf Of yasufu...@gmail.com Sent: Monday, October 28, 2019 8:08 AM To: Burakov, Anatoly ; david.march...@redhat.com Cc: dev@dpdk.org; sta...@dpdk.org; yasufu...@gmail.com; Yasufumi Ogawa Subject: [dpdk

Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head

2019-10-30 Thread Jerin Jacob
On Sun, Oct 27, 2019 at 2:42 PM Gavin Hu (Arm Technology China) wrote: > > Hi Pavan, > > > -Original Message- > > From: Pavan Nikhilesh Bhagavatula > > Sent: Saturday, October 26, 2019 1:06 AM > > To: Gavin Hu (Arm Technology China) ; > > jer...@marvell.com > > Cc: dev@dpdk.org; nd ; nd

Re: [dpdk-dev] [PATCH v7 10/10] doc: add application usage guide for l2fwd-event

2019-10-30 Thread Jerin Jacob
On Sat, Oct 26, 2019 at 4:42 PM wrote: > > From: Sunil Kumar Kori > > Add documentation for l2fwd-event example. > Update release notes. > > Signed-off-by: Sunil Kumar Kori > --- > MAINTAINERS | 1 + > doc/guides/rel_notes/release_19_11.rst| 6 + >

Re: [dpdk-dev] [PATCH v3 2/2] ipsec: remove redundant replay_win_sz

2019-10-30 Thread Ananyev, Konstantin
Hi Hemant, > The rte_security lib has introduced replay_win_sz, > so it can be removed from the rte_ipsec lib. > > Also, the relaved tests,app are also update to reflect > the usages. > > Signed-off-by: Hemant Agrawal > --- > v3: fix the compilation issue > > app/test/test_ipsec.c

Re: [dpdk-dev] [PATCH v2 0/6] implement common rte bit operation APIs in PMDs

2019-10-30 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Wednesday, October 30, 2019 1:33 PM > > On Wed, Oct 30, 2019 at 3:25 PM Gavin Hu (Arm Technology China) > wrote: > > > > Hi Thomas, > > > > > -Original Message- > > > From: Thomas Monja

  1   2   >