Hi Arek,
This patchset is showing compilation issues in CI. Please fix and send the
updated patchset.
Regards,
Akhil
>
> This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
> to Intel QuickAssist Technology PMD. It also adds session-less test cases
> for those algorithms.
Thursday, October 17, 2019 6:15 PM, Stephen Hemminger:
> Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline
> packet
>
> On Thu, 17 Oct 2019 07:27:34 +
> Shahaf Shuler wrote:
>
> > Some PMDs inline the mbuf data buffer directly to device. This is in
> > order to save the
Thursday, October 17, 2019 8:19 PM, Jerin Jacob:
> Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline
> packet
>
> On Thu, Oct 17, 2019 at 4:30 PM Shahaf Shuler
> wrote:
> >
> > Thursday, October 17, 2019 11:17 AM, Jerin Jacob:
> > > Subject: Re: [dpdk-dev] [RFC PATCH 20.02] m
>
> We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256
>
>
Description should have appropriate information explaining what the issue is and
What is done in the patch to fix the issue.
>
> Title should be: crypto/ccp: update max qp and burst size.
>
> >
> > From: Amara
Hi,
Please refer coding guidelines at
https://doc.dpdk.org/guides/contributing/patches.html
Here is the example of a fix commit. In this "abcdefgh1234" is the commit id
which introduced this issue.
You can check the commit id of the changed commit using git blame .
doc: fix some parameter desc
Hi,
As this is indeed a kernel driver issue, and Magnus is working on the
workaound/fix
in i40e kernel driver, as long as the workaound/fix can be merged in v5.4, this
patch can be dropped.
Thanks,
Xiaolong
On 09/30, Ciara Loftus wrote:
>From: Xiaolong Ye
>
>The kernel only consumes Tx packet
Hi, Ferruh, Olivier,
Thanks for your advice. I think I misunderstood the comments in the last commit.
This time I move the GTP header definition in the new file rte_gtp.h. Hope it
would be better.
Thanks.
-Original Message-
From: Olivier Matz [mailto:olivier.m...@6wind.com]
Sent: Tuesd
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, October 21, 2019 9:24 PM
> To: Gagandeep Singh ; dev@dpdk.org
> Subject: Re: [PATCH v4 1/3] net/enetc: add macro for BD ring alignment
>
> On 10/21/2019 11:50 AM, Gagandeep Singh wrote:
> > enetc BD rings should be aligned to 128
<...>
> >
> > include $(RTE_SDK)/mk/rte.lib.mk
> > diff --git a/drivers/net/enetc/enetc_ethdev.c
> b/drivers/net/enetc/enetc_ethdev.c
> > index 4e978348c..475ec77c3 100644
> > --- a/drivers/net/enetc/enetc_ethdev.c
> > +++ b/drivers/net/enetc/enetc_ethdev.c
> > @@ -4,6 +4,7 @@
> >
> > #include
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, October 21, 2019 9:26 PM
> To: Gagandeep Singh ; dev@dpdk.org
> Subject: Re: [PATCH v4 3/3] net/enetc: enable dpaax library
>
> On 10/21/2019 11:50 AM, Gagandeep Singh wrote:
> > With this patch, enetc driver would start using th
This patch enables testpmd to forward GTP packet in csum fwd mode.
A GTP header structure (without optional fields and extension header)
is defined in new rte_gtp.h. A parser function in testpmd is added.
GTPU and GTPC packets are both supported, with respective UDP
destination port and GTP message
We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256
-Original Message-
From: Akhil Goyal
Sent: Tuesday, October 15, 2019 4:28 PM
To: Somalapuram, Amaranath ; dev@dpdk.org
Cc: sta...@dpdk.org
Subject: RE: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max bu
Hi Akhil,
Not sure about how to use fix line if I don't have bug number.
If I run ./devtools/check-git-log.sh it expect bug number.
Do you recommend to log a bug for my patches ??
Please let me know.
Regards,
S.Amarnath
-Original Message-
From: Akhil Goyal
Sent: Tuesday, October 15,
Hi Akhil,
I have to resubmit this patch. Please ignore this.
-Original Message-
From: Akhil Goyal
Sent: Tuesday, October 15, 2019 4:38 PM
To: Somalapuram, Amaranath ; dev@dpdk.org
Cc: sta...@dpdk.org
Subject: RE: [PATCH v1 5/6] crypto/ccp: enable IOMMU for CCP
[CAUTION: External Email]
Hi Jerin,
I will check how to improve this. Will resubmit this patch with your suggested
changes.
Regards,
S.Amarnath
-Original Message-
From: Jerin Jacob
Sent: Tuesday, October 15, 2019 3:14 PM
To: Somalapuram, Amaranath
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: Re: [dpdk-dev] [PATC
From: Kiran Kumar K
Add new rte_flow_item_higig2_hdr in order to match higig2 header.
It is a layer 2.5 protocol and used in Broadcom switches.
Header format is based on the following document.
http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf
Signed-off-by: Kiran Kumar K
Ac
Hi Pavan,
snipped
> >> Add event dev main loop based on enabled l2fwd options and
> >eventdev
> >> capabilities.
> >>
> >> Signed-off-by: Pavan Nikhilesh
> >> ---
> >> + if (rsrc->event_mode) {
> >> + port_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
> >> + port_conf.rx_adv_conf.rss_co
Hi Pavan,
snipped
> >>
> >> Based on event device capability the configuration is done as follows:
> >> - A single event device is enabled.
> >> - The number of event ports is equal to the number of worker
> >> cores enabled in the core mask. Additional event ports might
> >> b
Hi Pavan,
snipped
> >> Add graceful teardown that addresses both event mode and poll
> >mode.
> >>
> >> Signed-off-by: Pavan Nikhilesh
> >> ---
> >snipped
> >> + if (rsrc->event_mode) {
> >> + struct l2fwd_event_resources *evt_rsrc =
> >> +
From: Nic Chautru
A change to PCI mapping assumption was missed earlier, this causes
probing to fail with the fpga_lte_fec PMD when checking for name
of the rte_driver (not set yet) instead of the rte_pci__driver.
Signed-off-by: Nic Chautru
---
drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 8
From: Nic Chautru
Polling of a MMIO register could misreport the actual value
set dynamically in hardware as the variable was not set explictly to
volatile integer.
Signed-off-by: Nic Chautru
---
drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Failures found when running validation with FPGA HW and the related FPGA PMD
driver on latest code base pre 19.11.
Two bug fixes below :
- The first error is a fatal failure during probing which was missed and would
fundamentally prevent using the driver. This was missed as HW validation was
st
Off the list
Hi, Ferruh
On 10/21, Ferruh Yigit wrote:
>On 10/21/2019 1:06 PM, Simei Su wrote:
>> This patch supports:
>> (1)symmetric hash by rte_flow RSS action.
>> (2)input set change by rte_flow RSS action.
>>
>> Signed-off-by: Simei Su
>> Acked-by: Qi Zhang
>
><...>
>
>> +static int
>>
Thanks!
> -Original Message-
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Monday, October 21, 2019 23:55
> To: Li, Xiaoyun
> Cc: dev ; Wu, Jingjing ; Wiles, Keith
> ; Maslekar, Omkar ; Liang,
> Cunming ; Thomas Monjalon
>
> Subject: Re: [dpdk-dev] [PATCH v6 0/4] enab
Some of the internal header files have 'rte_' prefix
and some don't.
Remove 'rte_' prefix from all internal header files.
Suggested-by: Thomas Monjalon
Signed-off-by: Dharmik Thakkar
Reviewed-by: Phil Yang
Reviewed-by: Ruifeng Wang
---
drivers/compress/zlib/zlib_pmd_private.h
On 21/10/2019 21:46, Rasesh Mody wrote:
>> From: Kevin Traynor
>> Sent: Monday, October 21, 2019 1:10 PM
>>
>> --
>> On 21/10/2019 19:52, Rasesh Mody wrote:
>>> Hi Kevin,
>>>
From: Kevin Traynor
Sent: Monday, October 21
>From: Kevin Traynor
>Sent: Monday, October 21, 2019 1:10 PM
>
>--
>On 21/10/2019 19:52, Rasesh Mody wrote:
>> Hi Kevin,
>>
>>> From: Kevin Traynor
>>> Sent: Monday, October 21, 2019 3:58 AM
>>>
>>> --
On 21/10/2019 03:44, Xiao Zhang wrote:
> Vlan packets with ip length bigger then 1496 will not be received by
> i40e/i40evf due to wrong packets size checking. This patch fixes the issue
> by correcting the maximum frame size during checking.
>
> Fixes: 43e5488c0ac6 ("net/i40e: support MTU configu
On 21/10/2019 19:52, Rasesh Mody wrote:
> Hi Kevin,
>
>> From: Kevin Traynor
>> Sent: Monday, October 21, 2019 3:58 AM
>>
>> --
>> On 20/10/2019 06:20, Rasesh Mody wrote:
>>> In our testing we have identified a critical FW bug. P
>
> On Tue, Oct 8, 2019 at 11:12 PM Honnappa Nagarahalli
> wrote:
> >
> > Few typo fixes, some corrections to the documentation and simple fixes
> > to the test cases.
> >
> > The last 2 commits contain simple optimizations with good amount of
> > performance improvements.
>
> Do you have numb
On Fri, Oct 18, 2019 at 3:58 PM Honnappa Nagarahalli
wrote:
>
>
>
> > Subject: [PATCH] rcu: fix reference to offline function
> >
> > Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: David Marchand
> Reviewed-by: Honnappa Nagar
On Tue, Oct 8, 2019 at 11:12 PM Honnappa Nagarahalli
wrote:
>
> Few typo fixes, some corrections to the documentation and simple fixes to
> the test cases.
>
> The last 2 commits contain simple optimizations with good amount of
> performance improvements.
Do you have numbers to illustrate?
>
> v
On Tue, Oct 8, 2019 at 11:12 PM Honnappa Nagarahalli
wrote:
>
> Variables used to store the return value of rte_rcu_qsbr_get_memsize
> in variables of type 'int'. The variables are of type 'size_t' now.
Added a comment on the two cases we have here: the uint32_t storage
are fine while the int one
On Mon, Oct 21, 2019 at 11:48 AM Gavin Hu wrote:
>
> The rte_wait_until_equal_xx APIs abstract the functionality of
> 'polling for a memory location to become equal to a given value'.
>
> Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled
> by default. When it is enabled, the above
On Mon, Oct 21, 2019 at 9:39 AM Gavin Hu (Arm Technology China)
wrote:
> > -Original Message-
> > From: David Marchand
> > - This is a new api, should be marked experimental, even if inlined.
> It is ok to add for the patches except the rte_ring, which called the API in
> the .h file, ot
On Mon, Oct 21, 2019 at 11:48 AM Gavin Hu wrote:
>
> There are two definitions conflicting each other, for more
> details, refer to [1].
>
> include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror]
> drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the
> previous definition
On Mon, Oct 21, 2019 at 4:12 PM Thomas Monjalon wrote:
>
> 13/08/2019 08:38, David Marchand:
> > The regexp part of the cleanup routine was not updated accordingly when
> > a common prefix for temp files was introduced.
> > Set the trap handler only when required.
> >
> > Fixes: ff37ca5d3773 ("dev
Hi Kevin,
>From: Kevin Traynor
>Sent: Monday, October 21, 2019 3:58 AM
>
>--
>On 20/10/2019 06:20, Rasesh Mody wrote:
>> In our testing we have identified a critical FW bug. Performance is
>> degraded significantly for certain pa
On 10/21/2019 1:22 PM, Ciara Power wrote:
> The promiscuous and multicast fields are now initialised as enabled for
> some virtual PMDs. This allows the devices to be used when running
> applications that attempt to enable promiscuous or multicast mode.
>
> Signed-off-by: Ciara Power
Reviewed-by
On 10/21/2019 1:22 PM, Ciara Power wrote:
> The promiscuous enable and disable functions now check the
> promiscuous state of the device before checking if the dev_ops
> function exists for the device.
>
> This change is necessary to allow sample applications run on
> virtual PMDs, as previously -
On 10/18/2019 4:15 PM, Ferruh Yigit wrote:
> On 10/18/2019 3:24 PM, Flavia Musatescu wrote:
>> When sendto call fails and ENOBUFS/EAGAIN error is being set
>> some of the packets are actually successfully transmitted.
>> There is no available count of those packets, so in order to
>> make the stati
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Monday, October 21, 2019 7:09 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal,
> ArkadiuszX
>
> Subject: [PATCH v3 0/5] Add session-less, RSA, RSA-CRT to QAT
>
> This patchset adds session-less option, RS
This commit adds RSA tests to Intel QuickAssist Technology pmd
and OpenSSL pmd test suite for session and session-less cases
when PADDING_NONE selected
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 140 --
app/test/test_cryptodev_rsa_test_vectors.h
This commit extends RSA implementation by CRT option
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/features/qat.ini | 1 +
doc/guides/rel_notes/release_19_11.rst | 2 +
.../qat/qat_adf/qat_pke_functionality_arrays.h | 9
drivers/crypto/qat/qat_asym.c
This commit adds asymmetric sessionless tests to mod exp.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 73 --
1 file changed, 49 insertions(+), 24 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.
This patch adds option to use asymmetric crypto pmd with
session-less support.
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/features/qat.ini | 1 +
doc/guides/rel_notes/release_19_11.rst | 4 +
drivers/crypto/qat/qat_asym.c | 328 -
drivers/c
This commit adds rsa algorithm to asymmetric pmd
using pair (n, d) private key
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/features/qat.ini | 2 +
doc/guides/cryptodevs/qat.rst | 1 +
doc/guides/rel_notes/release_19_11.rst | 2 +
.../q
This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
to Intel QuickAssist Technology PMD. It also adds session-less test cases
for those algorithms.
Test case for RSA signature with no padding will be sent in a later patch.
[1]crypto/qat: add sessionless implementation to asym
On 10/21/2019 1:06 PM, Simei Su wrote:
> This patch changes a variable type from uint64_t to void pointer
> to avoid compilation issues for converting a point to uint64_t
> in i686 environment.
>
> Signed-off-by: Simei Su
Squashed into relevant commit in next-net, thanks.
On 10/21/2019 1:06 PM, Simei Su wrote:
> This patch supports:
> (1)symmetric hash by rte_flow RSS action.
> (2)input set change by rte_flow RSS action.
>
> Signed-off-by: Simei Su
> Acked-by: Qi Zhang
<...>
> +static int
> +ice_hash_parse_action(struct ice_pattern_match_item *pattern_match
Hi Vipin,
>Hi Pavan,
>
>Thanks for sharing the write up, following are some of my thoughts.
>
>Snipped
>>
>> Based on event device capability the configuration is done as follows:
>> - A single event device is enabled.
>> - The number of event ports is equal to the number of worker
>>
>Hi Pavan,
>
>snipped
>>
>> Add graceful teardown that addresses both event mode and poll
>mode.
>>
>> Signed-off-by: Pavan Nikhilesh
>> ---
>snipped
>> +if (rsrc->event_mode) {
>> +struct l2fwd_event_resources *evt_rsrc =
>> +rsr
Hi Vipin,
>HI Pavan,
>
>snipped
>> Add event dev main loop based on enabled l2fwd options and
>eventdev
>> capabilities.
>>
>> Signed-off-by: Pavan Nikhilesh
>> ---
>> +if (rsrc->event_mode) {
>> +port_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
>> +port_conf.rx_adv_conf.rss_
On Mon, Oct 21, 2019 at 11:52:46AM +0100, Ferruh Yigit wrote:
> On 10/21/2019 10:28 AM, Ferruh Yigit wrote:
> > On 10/21/2019 1:29 PM, Ting Xu wrote:
> >> This patch enables testpmd to forward GTP packet in csum fwd mode.
> >> GTP header structure (without optional fields and extension header)
> >>
Hi,
On Mon, Oct 21, 2019 at 02:46:17PM +0530, kirankum...@marvell.com wrote:
> From: Kiran Kumar K
>
> Add new rte_flow_item_higig2_hdr in order to match higig2 header.
> It is a layer 2.5 protocol and used in Broadcom switches.
> Header format is based on the following document.
> http://read.p
Hi Slava,
On Sat, Oct 19, 2019 at 07:47:59PM +, Slava Ovsiienko wrote:
> Hi, Olivier
>
> Thank you for your comment (and for the dynamic mbuf patch, btw). Please, see
> below.
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Friday, October 18, 2019 12:22
> > To: Slava Ovs
On Mon, Oct 21, 2019 at 05:02:25PM +0100, Ferruh Yigit wrote:
> On 10/21/2019 4:54 PM, Bruce Richardson wrote:
> > On Mon, Oct 21, 2019 at 04:24:26PM +0100, Ferruh Yigit wrote:
> >> On 10/14/2019 3:43 PM, Bruce Richardson wrote:
> >>> On Thu, Oct 03, 2019 at 02:23:07PM +0100, Loftus, Ciara wrote:
>
On 10/17/2019 5:45 PM, Ferruh Yigit wrote:
> On 10/17/2019 5:04 PM, Ferruh Yigit wrote:
>> On 10/17/2019 12:52 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES
>> at
>> Cisco) wrote:
>>>
Hi Jakub,
Just to double check if anyone is looking into the bind() error issue
whi
On 10/21/2019 11:50 AM, Gagandeep Singh wrote:
> for SGMII interfaces, there can be 0 value
> written on MAC registers.
> This patch set the random MAC address for those
> interfaces.
>
> Signed-off-by: Gagandeep Singh
> ---
> drivers/net/enetc/Makefile | 2 +-
> drivers/net/enetc/enetc_e
On 10/21/2019 4:54 PM, Bruce Richardson wrote:
> On Mon, Oct 21, 2019 at 04:24:26PM +0100, Ferruh Yigit wrote:
>> On 10/14/2019 3:43 PM, Bruce Richardson wrote:
>>> On Thu, Oct 03, 2019 at 02:23:07PM +0100, Loftus, Ciara wrote:
> -Original Message- From: Stephen Hemminger
On 10/21/2019 11:50 AM, Gagandeep Singh wrote:
> With this patch, enetc driver would start using the
> physical-virtual library interfaces.
Out of curiosity what does it mean "start using the physical-virtual library
interfaces" ? Can you please provide a little more details how it is done?
>
>
On Mon, Oct 21, 2019 at 3:44 PM Thomas Monjalon wrote:
>
> 26/09/2019 06:04, Wu, Jingjing:
> > From: Li, Xiaoyun
> > > Enable FIFO for NTB rawdev driver to support packet based
> > > processing. And an example is provided to support txonly,
> > > rxonly, iofwd between NTB device and ethdev, and fi
On Mon, Oct 21, 2019 at 04:24:26PM +0100, Ferruh Yigit wrote:
> On 10/14/2019 3:43 PM, Bruce Richardson wrote:
> > On Thu, Oct 03, 2019 at 02:23:07PM +0100, Loftus, Ciara wrote:
> >>
> >>
> >>> -Original Message- From: Stephen Hemminger
> >>> Sent: Monday 30 September 2019 18:12 To:
> >>>
On 10/21/2019 11:50 AM, Gagandeep Singh wrote:
> enetc BD rings should be aligned to 128
> instead of RTE_CACHE_LINE_SIZE.
This looks like a fix, if so can you please update commit log according, via
fixes line etc..
>
> Signed-off-by: Gagandeep Singh
> ---
> drivers/net/enetc/base/enetc_hw.h
On 10/21/2019 12:46 PM, Raslan Darawsheh wrote:
> Fixes: 398b0cdcd ("net/mlx5: add flow match on GENEVE item")
>
> Signed-off-by: Raslan Darawsheh
Squashed into relevant commit in next-net, thanks.
On 10/21/2019 4:19 PM, Pavan Nikhilesh Bhagavatula wrote:
> Hi Ferruh,
>
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Monday, October 21, 2019 8:37 PM
>> To: Andrew Rybchenko ; Pavan Nikhilesh
>> Bhagavatula ; Jerin Jacob Kollanukkaran
>>
>> Cc: dev@dpdk.org; Adrien Mazarguil ;
>
On 10/14/2019 3:43 PM, Bruce Richardson wrote:
> On Thu, Oct 03, 2019 at 02:23:07PM +0100, Loftus, Ciara wrote:
>>
>>
>>> -Original Message- From: Stephen Hemminger
>>> Sent: Monday 30 September 2019 18:12 To:
>>> Loftus, Ciara Cc: dev@dpdk.org; Ye, Xiaolong
>>> ; Laatz, Kevin ;
>>> Richa
Hi Ferruh,
>-Original Message-
>From: Ferruh Yigit
>Sent: Monday, October 21, 2019 8:37 PM
>To: Andrew Rybchenko ; Pavan Nikhilesh
>Bhagavatula ; Jerin Jacob Kollanukkaran
>
>Cc: dev@dpdk.org; Adrien Mazarguil ;
>Thomas Monjalon ; Xiaolong Ye
>; Bruce Richardson
>
>Subject: Re: [dpdk-dev]
On 10/18/2019 11:31 AM, Andrew Rybchenko wrote:
> On 10/18/19 12:42 PM, Ferruh Yigit wrote:
>> On 10/18/2019 8:32 AM, Andrew Rybchenko wrote:
>>> Hi Ferruh,
>>>
>>> since I've reviewed I'll reply as I understand it.
>>>
>>> On 10/17/19 8:43 PM, Ferruh Yigit wrote:
On 10/17/2019 1:02 PM, pbhaga
Hi Olivier, Andrew,
> >>> +#define OPT_LEGACY_KNI "legacy-kni"
> >>> + OPT_LEGACY_KNI_NUM,
> >>> OPT_LONG_MAX_NUM
> >>> };
> >>
> >> Two concerns,
> >>
> >> 1- "legacy-kni" doesn't have enough context
> >>
> >> 2- I prefer to keep existing behavior default, at least for a while,
> >> somet
21/10/2019 12:10, Ray Kinsella:
>
> On 21/10/2019 10:50, Thomas Monjalon wrote:
> > 27/09/2019 18:54, Ray Kinsella:
> >> TL;DR abbreviation:
> >> A major ABI version that all DPDK releases during a one year period
> >> support. ABI versioning is managed at a project-level, in place of
> >> librar
Introduce new application to provide user to evaluate and perform
custom functional and performance tests for IPsec SAD implementation.
Signed-off-by: Vladimir Medvedkin
Acked-by: Akhil Goyal
Acked-by: Konstantin Ananyev
Tested-by: Konstantin Ananyev
---
MAINTAINERS | 1 +
app/
Replace rte_ipsec_sad_create(), rte_ipsec_sad_destroy() and
rte_ipsec_sad_find_existing() API stubs with actual
implementation.
Signed-off-by: Vladimir Medvedkin
Acked-by: Akhil Goyal
Acked-by: Konstantin Ananyev
Tested-by: Konstantin Ananyev
---
doc/guides/prog_guide/ipsec_lib.rst | 27
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and
rte_ipsec_sad_lookup() stubs with actual implementation.
It uses three librte_hash tables each of which contains
an entries for a specific SA type (either it is addressed by SPI only
or SPI+DIP or SPI+DIP+SIP)
Signed-off-by: Vladimir Medvedkin
add unittests for ipsec SAD library
Signed-off-by: Vladimir Medvedkin
Acked-by: Akhil Goyal
Acked-by: Konstantin Ananyev
Tested-by: Konstantin Ananyev
---
MAINTAINERS | 2 +
app/test/Makefile | 1 +
app/test/autotest_data.py | 6 +
app/test/meson.build | 1 +
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD).
For each incoming inbound IPSec-protected packet (ESP or AH) it has to
perform a lookup within it’s SAD.
Lookup should be performed by:
Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP)
or SPI +
Add inbound security association database (SAD) API
and stub implementation.
Signed-off-by: Vladimir Medvedkin
Acked-by: Akhil Goyal
Acked-by: Konstantin Ananyev
---
doc/guides/prog_guide/ipsec_lib.rst| 15 +++
doc/guides/rel_notes/release_19_11.rst | 3 +
lib/librte_ipsec/Makefile
When VIRTIO_F_IN_ORDER feature is negotiated, vhost can optimize dequeue
function by only update first used descriptor.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index ab6726996..5b8cb9e63 100644
--- a/lib/l
Thanks Maxime, has been modified in v8.
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Monday, October 21, 2019 5:47 PM
> To: Liu, Yong ; Bie, Tiwei ; Wang,
> Zhihong ; step...@networkplumber.org;
> gavin...@arm.com
> Cc: dev@dpdk.org
> Subject: Re
Optimize vhost device packed ring enqueue function by splitting batch
and single functions. Packets can be filled into one desc will be
handled by batch and others will be handled by single as before.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/virtio_ne
Add vhost packed ring zero copy batch and single dequeue functions like
normal dequeue path.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 1c63262ce..528e0fab1 100644
--- a/lib/librte_vhost/virtio_net.c
++
Buffer used ring updates as many as possible in vhost dequeue function
for coordinating with virtio driver. For supporting buffer, shadow used
ring element should contain descriptor's flags. First shadowed ring
index was recorded for calculating buffered number.
Signed-off-by: Marvin Liu
Reviewed
Optimize vhost device packed ring dequeue function by splitting batch
and single functions. No-chained and direct descriptors will be handled
by batch and other will be handled by single as before.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/virtio_net.c
Flush used elements when batched enqueue function is finished.
Descriptor's flags are pre-calculated as they will be reset by vhost.
Signed-off-by: Marvin Liu
Reviewed-by: Gavin Hu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index d59446442..f8
Buffer vhost packed ring enqueue updates, flush ring descs if buffered
content filled up one cacheline. Thus virtio can receive packets at a
faster frequency.
Signed-off-by: Marvin Liu
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index 67724c342..d59446442 100644
--- a/lib/li
Add vhost enqueue function for single packet and meanwhile left space
for flush used ring function.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 070d62bc0..4fb6552cc 100644
--- a/lib/librte_vhost/virtio_n
Batch enqueue function will first check whether descriptors are cache
aligned. It will also check prerequisites in the beginning. Batch
enqueue function do not support chained mbufs, single packet enqueue
function will handle it.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git
Add vhost single packet dequeue function for packed ring and meanwhile
left space for shadow used ring update function.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 4ddf26567..87f2ae49e 100644
--- a/lib/l
When enqueuing or dequeuing, the virtqueue's local available and used
indexes are increased.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index c76d40115..02b3c91ff 100644
--- a/lib/librte_vhost/vhost.h
+++ b/lib/librte_
Add batch dequeue function like enqueue function for packed ring, batch
dequeue function will not support chained descritpors, single packet
dequeue function will handle it.
Signed-off-by: Marvin Liu
diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
index a2b9221e0..67724c342 1006
Create macro for adding unroll pragma before for each loop. Batch
functions will be contained of several small loops which can be
optimized by compilers' loop unrolling pragma.
Signed-off-by: Marvin Liu
diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile
index 8623e91c0..87ce1fb27
Packed ring has more compact ring format and thus can significantly
reduce the number of cache miss. It can lead to better performance.
This has been approved in virtio user driver, on normal E5 Xeon cpu
single core performance can raise 12%.
http://mails.dpdk.org/archives/dev/2018-April/095470.ht
On 10/21, Simei Su wrote:
>[PATCH v8 1/2] add teid hash for gtupu and session id hash for pppoe/pppod.
>[PATCH v8 2/2] support input set change and symmetric hash by rte_flow RSS
>action.
>
>v8:
>* Change meta type from uint64_t to void pointer for pattern structure.
>* Modify related code in ice_
On 10/21, Simei Su wrote:
>This patch changes a variable type from uint64_t to void pointer
>to avoid compilation issues for converting a point to uint64_t
>in i686 environment.
>
>Signed-off-by: Simei Su
>---
> drivers/net/ice/ice_generic_flow.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion
13/08/2019 08:38, David Marchand:
> The regexp part of the cleanup routine was not updated accordingly when
> a common prefix for temp files was introduced.
> Set the trap handler only when required.
>
> Fixes: ff37ca5d3773 ("devtools: use a common prefix for temporary files")
> Cc: sta...@dpdk.or
Ok thanks
> -Original Message-
> From: Bruce Richardson
> Sent: Monday, October 21, 2019 7:26 PM
> To: Varghese, Vipin
> Cc: Loftus, Ciara ; 'Stephen Hemminger'
> ; 'dev@dpdk.org' ; Ye,
> Xiaolong ; Laatz, Kevin ;
> Yigit, Ferruh
> Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/af_xdp: supp
12/08/2019 09:00, David Marchand:
> Bare metal support has been gone for quite some time but we still had
> some checks on system includes.
>
> Signed-off-by: David Marchand
> ---
> app/test-pmd/cmdline.c| 6 +-
> app/test/commands.c | 5 -
> app
On Mon, Oct 21, 2019 at 02:45:05PM +0100, Varghese, Vipin wrote:
> Hi Bruce,
>
> snipped
> > > This ability to have the driver pin the interrupts for the
> > > > user would be a big timesaver for developers too, who may be
> > > > constantly re- running apps when testing.
> > > Here my understand
Hi Akhil,
> Added my comments inline with your draft.
> >
> >
> > Hi Akhil,
> >
> > > > BTW, to be honest, I don't consider current rte_cryptodev_sym_session
> > > > construct for multiple device_ids:
> > > > __extension__ struct {
> > > > void *data;
> > > > ui
Hi Bruce,
snipped
> > This ability to have the driver pin the interrupts for the
> > > user would be a big timesaver for developers too, who may be
> > > constantly re- running apps when testing.
> > Here my understanding, user can not or should not pass DPDK cores for
> interrupt pinning. So sho
1 - 100 of 219 matches
Mail list logo
