Re: [dpdk-dev] Testpmd parameter --enable-lro fails on Mellanox ConnectX5

2019-10-17 Thread Georgios Katsikas
Hi Asaf, Unfortunately, this extra parameter did not work., I got the same error as before. However, the result of the command "show port 0 rx_offload configuration" shows that TCP_LRO is "enabled" testpmd> show port 0 rx_offload configuration Rx Offloading Configuration of port 0 : Port : TCP_

Re: [dpdk-dev] [PATCH v7 0/9] net/ice: add ice Flow Director driver

2019-10-17 Thread Ye Xiaolong
On 10/18, Yahui Cao wrote: >This patch series adds Flow Director support for Intel Ethernet >Controller E810 series using RTE_FLOW > >- Patch 01-02 are FDIR init,teardown and configuration >- Remaining patches are FDIR RTE_FLOW enablement > >--- >v7: >* Fix shared library build error > >v6: >* Fix

Re: [dpdk-dev] [PATCH 1/2 v2] event/dpaa2: set priority as per the dpcon device

2019-10-17 Thread Jerin Jacob
On Thu, Oct 17, 2019 at 2:17 PM Nipun Gupta wrote: > > Forgot to add in patch: > > Acked-by: Hemant Agrawal Series applied to dpdk-next-eventdev/master. Thanks. > > > -Original Message- > > From: Nipun Gupta > > Sent: Thursday, October 17, 2019 1:59 PM > > To: dev@dpdk.org > > Cc: jer

Re: [dpdk-dev] [PATCH v7 3/7] spinlock: use wfe to reduce contention on aarch64

2019-10-17 Thread Gavin Hu (Arm Technology China)
Hi David, > -Original Message- > From: David Marchand > Sent: Friday, October 18, 2019 2:28 AM > To: Gavin Hu (Arm Technology China) > Cc: dev ; nd ; tho...@monjalon.net; > Stephen Hemminger ; > hemant.agra...@nxp.com; jer...@marvell.com; Pavan Nikhilesh > ; Honnappa Nagarahalli > ; Ruif

Re: [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo

2019-10-17 Thread Hemant Agrawal
Hi Abhinandan, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Friday, October 4, 2019 3:06 PM > To: Hemant Agrawal ; dev@dpdk.org > Cc: jer...@marvell.com > Subject: RE: [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo > Importance: High > > Hi Hemanth

Re: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration

2019-10-17 Thread Honnappa Nagarahalli
> > On Thu, 2019-08-01 at 07:48 +0800, Gavin Hu wrote: > > Arm N1 SDP is an infrastructure segment development platform based on > > armv8.2-a Neoverse N1 CPU. For more information, refer to: > > https://community.arm.com/developer/tools-software/oss-platforms/w/ > > docs/440/neoverse-n1-sdp > >

Re: [dpdk-dev] [PATCH v2] app/test: add tests for atomic exchanges

2019-10-17 Thread David Marchand
On Fri, Oct 18, 2019 at 12:39 AM David Christensen wrote: > > The test works by creating a token comprised of random data > and a CRC8 value, using the rte_atomicXX_exchange to exchange > the new token for a previously generated token, and then > verifying that the exchanged data is intact (i.e. t

[dpdk-dev] ebpf issues with secondary process.

2019-10-17 Thread Stephen Hemminger
Trying to use the existing BPF code in BPF for packet filter is possible. But one road block is that capture wants to allow a secondary process to insert a packet filter. The current code in bpf_load() won't work for that. The BPF program needs to be in shared area to allow secondary process to wor

[dpdk-dev] [PATCH v5] ethdev: add HIGIG2 key field to flow API

2019-10-17 Thread kirankumark
From: Kiran Kumar K Add new rte_flow_item_higig2_hdr in order to match higig2 header. It is a layer 2.5 protocol and used in Broadcom switches. Header format is based on the following document. http://read.pudn.com/downloads558/doc/comm/2301468/HiGig_protocol.pdf Signed-off-by: Kiran Kumar K --

Re: [dpdk-dev] [PATCH] lib/rcu: fix possible spurious thread unregister

2019-10-17 Thread David Marchand
On Wed, Sep 25, 2019 at 10:01 AM David Marchand wrote: > > On Mon, Sep 9, 2019 at 3:52 PM Ruifeng Wang wrote: > > > > Thread unregister returns success while unregister not been performed. > > This is due to incorrect thread registration status check. > > Fix this issue by correcting bitmap check

Re: [dpdk-dev] [PATCH] service: improve service run performance

2019-10-17 Thread David Marchand
On Mon, Oct 7, 2019 at 5:37 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Monday, October 7, 2019 3:53 PM > > To: Van Haaren, Harry > > Cc: dev ; Rao, Nikhil > > Subject: Re: [dpdk-dev] [PATCH] service: improve

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-17 Thread David Marchand
On Tue, Oct 8, 2019 at 5:16 PM Stephen Hemminger wrote: > > On Tue, 8 Oct 2019 09:36:49 +0100 > Bruce Richardson wrote: > > > On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > > > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > > > wrote: > > > > > > > This code was added 7+ y

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

2019-10-17 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > On 13/10/2019 04:02, Honnappa Nagarahalli wrote: > > Hi Vladimir, > > Apologies for the delayed response, I had to run few experiments. > > > > > > > >> Hi Honnappa, > >> > >> On 01/10/2019 07:29, Honnappa Nagarahalli wrote: > >>> Add resource reclamation APIs to make

[dpdk-dev] [PATCH v7 5/9] net/ice: add FDIR counter resource init/release

2019-10-17 Thread Yahui Cao
The patch integrates the counter resource init/release into fdir's init/release scenario Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.h | 33 +++ drivers/net/ice/ice_fdir_filter.c | 92 +++ 2 files changed, 125 insertions(+)

[dpdk-dev] [PATCH v7 9/9] net/ice: add FDIR GTPU tunnel support

2019-10-17 Thread Yahui Cao
Enable FDIR GTPU matching for RTE_FLOW Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.h | 4 + drivers/net/ice/ice_fdir_filter.c | 147 -- 2 files changed, 141 insertions(+), 10 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.

[dpdk-dev] [PATCH v7 8/9] net/ice: add FDIR vxlan tunnel support

2019-10-17 Thread Yahui Cao
Enable FDIR vxlan tunnel matching for RTE_FLOW Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.h | 8 +++ drivers/net/ice/ice_fdir_filter.c | 108 ++ 2 files changed, 104 insertions(+), 12 deletions(-) diff --git a/drivers/net/ice/i

[dpdk-dev] [PATCH v7 6/9] net/ice: add FDIR counter support

2019-10-17 Thread Yahui Cao
This patch add FDIR statistical counter support and it includes RTE_FLOW count actions support and query support. RTE_FLOW count actions support id and shared. RTE_FLOW query record packet hits by default. Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.h | 7

[dpdk-dev] [PATCH v7 3/9] net/ice: add FDIR create and destroy

2019-10-17 Thread Yahui Cao
Add ice_create_fdir_filter to create a rule. If a flow is matched by flow director filter, filter rule will be set to HW. For now common pattern and queue/passthru/drop/mark actions are supported. Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- doc/guides/rel_notes/release_19_11.rst | 1 + dr

[dpdk-dev] [PATCH v7 7/9] net/ice: reject duplicate flow for FDIR

2019-10-17 Thread Yahui Cao
Enable duplication lookup for existing flow director rule entry. Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- drivers/net/ice/Makefile | 2 +- drivers/net/ice/ice_ethdev.h | 17 +++ drivers/net/ice/ice_fdir_filter.c | 185 -- 3 files changed, 196

[dpdk-dev] [PATCH v7 2/9] net/ice: configure HW FDIR rule

2019-10-17 Thread Yahui Cao
From: Beilei Xing This patch adds a HW FDIR rule to the FDIR HW table without adding a FDIR filter. Signed-off-by: Beilei Xing Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.h | 2 + drivers/net/ice/ice_fdir_filter.c | 277 +- 2 files changed, 278 inserti

[dpdk-dev] [PATCH v7 4/9] net/ice: enable FDIR queue group

2019-10-17 Thread Yahui Cao
FDIR can send packet to a group of queues and distruibte it by RSS. Signed-off-by: Yahui Cao Acked-by: Qi Zhang --- drivers/net/ice/ice_fdir_filter.c | 68 +++ 1 file changed, 68 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdi

[dpdk-dev] [PATCH v7 1/9] net/ice: enable flow director engine

2019-10-17 Thread Yahui Cao
From: Beilei Xing Enable flow director engine, including initialization and teardown. - Control VSI create and release. - Queue pair allocated, set up and release. - Programming packet create and release. - FDIR profile create and release. Signed-off-by: Beilei Xing Acked-by: Qi Zhang ---

[dpdk-dev] [PATCH v7 0/9] net/ice: add ice Flow Director driver

2019-10-17 Thread Yahui Cao
This patch series adds Flow Director support for Intel Ethernet Controller E810 series using RTE_FLOW - Patch 01-02 are FDIR init,teardown and configuration - Remaining patches are FDIR RTE_FLOW enablement --- v7: * Fix shared library build error v6: * Fix build error on different platform v5:

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: integrate RCU QSBR

2019-10-17 Thread Honnappa Nagarahalli
> > > > > Hi guys, > > I have tried to consolidate design related questions here. If I have missed > anything, please add. > > > > > > > > > > > > > From: Ruifeng Wang > > > > > > > > Currently, the tbl8 group is freed even though the readers might > > > > be using the tbl8 group entries. The fr

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-17 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable element > size > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results > >>> are as > >> follows. The numbers in brackets are with the code on master. > >>> gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 > >>> >

[dpdk-dev] [PATCH v2] net/ice: cleanup RSS/FDIR profile when device init

2019-10-17 Thread Ying Wang
When app restart, RSS/FDIR profile ID will increase which may run out of all the profile resources. The patch cleanup RSS/FDIR profile resources when device init to fix this issue. Fixes: d7d150b93070 ("net/ice: enable RSS when device init") Cc: sta...@dpdk.org Signed-off-by: Ying Wang --- ---

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-17 Thread Wang, Haiyue
Hi Olivier > -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Thursday, October 17, 2019 22:42 > To: dev@dpdk.org > Cc: Andrew Rybchenko ; Richardson, Bruce > ; Wang, > Haiyue ; Jerin Jacob Kollanukkaran > ; Wiles, Keith > ; Ananyev, Konstantin ; > Morten

Re: [dpdk-dev] [PATCH] net/ice: cleanup RSS/FDIR profile when device init

2019-10-17 Thread Wang, Ying A
Hi, Xiaolong Thanks for your comments, will fix them in v2. > -Original Message- > From: Ye, Xiaolong > Sent: Monday, September 30, 2019 5:26 PM > To: Wang, Ying A > Cc: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming > ; sta...@dpdk.org > Subject: Re: [PATCH] net/ice: cleanup RSS/FDIR profile

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-17 Thread David Christensen
I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results are as follows. The numbers in brackets are with the code on master. gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 RTE>>ring_perf_elem_autotest ### Testing single element and burst enq/deq ### SP/SC single enq/dequeue: 5 MP/MC sing

[dpdk-dev] [PATCH v2] app/test: add tests for atomic exchanges

2019-10-17 Thread David Christensen
The test works by creating a token comprised of random data and a CRC8 value, using the rte_atomicXX_exchange to exchange the new token for a previously generated token, and then verifying that the exchanged data is intact (i.e. the CRC8 is still correct for the data). Signed-off-by: David Christe

[dpdk-dev] [PATCH] app/test: add tests for atomic exchanges

2019-10-17 Thread David Christensen
The test works by creating a token comprised of random data and a CRC8 value, using the rte_atomicXX_exchange to exchange the new token for a previously generated token, and then verifying that the exchanged data is intact (i.e. the CRC8 is still correct for the data). Signed-off-by: David Christe

Re: [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration

2019-10-17 Thread Ola Liljedahl
On Thu, 2019-08-01 at 07:48 +0800, Gavin Hu wrote: > Arm N1 SDP is an infrastructure segment development platform > based on armv8.2-a Neoverse N1 CPU. For more information, refer to: > https://community.arm.com/developer/tools-software/oss-platforms/w/ > docs/440/neoverse-n1-sdp > > Signed-off-by

Re: [dpdk-dev] [PATCH] maintainers: add net-brcm sub-tree

2019-10-17 Thread Thomas Monjalon
17/10/2019 19:39, Ajit Khaparde: > On Tue, Oct 15, 2019 at 12:38 AM Ferruh Yigit > wrote: > > > Adding vendor specific sub-tree for Broadcom drivers. > > The next-net-brcm sub-tree will be sub-tree of the next-net. > > > > Signed-off-by: Ferruh Yigit > > --- > > Cc: Ajit Khaparde > > Cc: Thomas

Re: [dpdk-dev] [PATCH v4 04/10] timer: remove deprecated code

2019-10-17 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, October 17, 2019 9:32 AM > To: dev@dpdk.org > Cc: Baran, MarcinX ; Robert Sanford > ; Carrillo, Erik G ; > Mcnamara, John ; Richardson, Bruce > ; tho...@monjalon.net; > david.march...@redhat.com > Subject: [PATCH v4 04/10] tim

Re: [dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-17 Thread Thomas Monjalon
17/10/2019 17:32, Ori Kam: > V4: > - update according to ML comments. > > V3: > - update according to ML comments. > > V2: > - update according to ML comments. I would prefer to see a summary of the changes in the changelog, so we can easily track the progress.

[dpdk-dev] [PATCH v4 09/10] build: change ABI version to 20.0

2019-10-17 Thread Anatoly Burakov
From: Pawel Modrak Merge all vesions in linker version script files to DPDK_20.0. This commit was generated by running the following command: :~/DPDK$ buildtools/update-abi.sh 20.0 Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- .../rte_pmd_bbdev_f

Re: [dpdk-dev] [PATCH v5 1/3] lib/ring: apis to support configurable element size

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 15:08:05 -0500 Honnappa Nagarahalli wrote: > /* count must be a power of 2 */ > if ((!POWEROF2(count)) || (count > RTE_RING_SZ_MASK )) { > RTE_LOG(ERR, RING, > - "Requested size is invalid, must be power of 2, and " > -

Re: [dpdk-dev] [PATCH v5 1/3] lib/ring: apis to support configurable element size

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 15:08:05 -0500 Honnappa Nagarahalli wrote: > + if ((esize != 4) && (esize != 8) && (esize != 16)) { > + RTE_LOG(ERR, RING, > + "Unsupported esize value. Supported values are 4, 8 and > 16\n"); > + > + return -EINVAL; > + } >

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-17 Thread Honnappa Nagarahalli
+ David Christensen for Power architecture > > > > > > > It > > > > would mean extra work for the users. > > > > > > > > > 2. A lot of code duplication with these 3 copies of > > > > > ENQUEUE/DEQUEUE macros. > > > > > > > > > > Looking at ENQUEUE/DEQUEUE macros, I can see that main loop > > > >

[dpdk-dev] [PATCH v5 2/3] test/ring: add test cases for configurable element size ring

2019-10-17 Thread Honnappa Nagarahalli
Add test cases to test APIs for configurable element size ring. Signed-off-by: Honnappa Nagarahalli --- app/test/Makefile | 1 + app/test/meson.build | 1 + app/test/test_ring_perf_elem.c | 419 + 3 files changed, 421 insertions(+) crea

[dpdk-dev] [PATCH v5 1/3] lib/ring: apis to support configurable element size

2019-10-17 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

[dpdk-dev] [PATCH v5 3/3] lib/ring: copy ring elements using memcpy partially

2019-10-17 Thread Honnappa Nagarahalli
Copy of ring elements uses memcpy for 32B chunks. The remaining bytes are copied using assignments. Signed-off-by: Honnappa Nagarahalli --- lib/librte_ring/rte_ring_elem.h | 163 +++- 1 file changed, 11 insertions(+), 152 deletions(-) diff --git a/lib/librte_ring/rte

[dpdk-dev] [PATCH v5 0/3] lib/ring: APIs to support custom element size

2019-10-17 Thread Honnappa Nagarahalli
The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

Re: [dpdk-dev] [PATCH v7 0/7] use WFE for aarch64

2019-10-17 Thread David Marchand
On Fri, Sep 27, 2019 at 7:42 AM Gavin Hu wrote: > > V7: > - fix the checkpatch LONG_LINE_COMMENT issue > V6: > - squash the RTE_ARM_USE_WFE configuration entry patch into the new API patch > - move the new configuration to the end of EAL > - add doxygen comments to reflect the relaxed and acquire

Re: [dpdk-dev] [PATCH v7 3/7] spinlock: use wfe to reduce contention on aarch64

2019-10-17 Thread David Marchand
On Fri, Sep 27, 2019 at 7:43 AM Gavin Hu wrote: > > In acquiring a spinlock, cores repeatedly poll the lock variable. > This is replaced by rte_wait_until_equal API. > > Running the micro benchmarking and the testpmd and l3fwd traffic tests > on ThunderX2, Ampere eMAG80 and Arm N1SDP, everything w

Re: [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 1:02 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` and > `DEV_RX_OFFLOAD_FLOW_MARK`. These flags can be used to > enable/disable PMD writes to rte_mbuf fields `hash.rss` and `hash.fdir.hi` > and also `ol_flags:

Re: [dpdk-dev] [PATCH] maintainers: add net-brcm sub-tree

2019-10-17 Thread Ajit Khaparde
On Tue, Oct 15, 2019 at 12:38 AM Ferruh Yigit wrote: > Adding vendor specific sub-tree for Broadcom drivers. > The next-net-brcm sub-tree will be sub-tree of the next-net. > > Signed-off-by: Ferruh Yigit > --- > Cc: Ajit Khaparde > Cc: Thomas Monjalon > Acked-by: Ajit Khaparde > --- > MAIN

Re: [dpdk-dev] [PATCH] usertools: fix py3 syntax errors with dpdk-telemetry-client.py

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 19:32:12 +0200 Robin Jarry wrote: > When running the dpdk-telemetry-client.py with python 3, we get the > following syntax errors: > > File "usertools/dpdk-telemetry-client.py", line 70 > print "\nResponse: \n", str(data) >^ > SyntaxError

[dpdk-dev] [PATCH] usertools: fix py3 syntax errors with dpdk-telemetry-client.py

2019-10-17 Thread Robin Jarry
When running the dpdk-telemetry-client.py with python 3, we get the following syntax errors: File "usertools/dpdk-telemetry-client.py", line 70 print "\nResponse: \n", str(data) ^ SyntaxError: invalid syntax File "usertools/dpdk-telemetry-client.py", line 93

Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-17 Thread Jerin Jacob
On Thu, Oct 17, 2019 at 4:30 PM Shahaf Shuler wrote: > > Thursday, October 17, 2019 11:17 AM, Jerin Jacob: > > Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline > > packet > > > > On Thu, Oct 17, 2019 at 12:57 PM Shahaf Shuler > > wrote: > > > > > > Some PMDs inline the mbuf

Re: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64

2019-10-17 Thread David Christensen
The change itself is not that scary, but just reading this commitlog I fail to see the impact for an application. Can you share some light? As far as I can tell there is no impact on any applications. The old code, which walked through the list in a forward direction, worked perfectly well wit

[dpdk-dev] [BUG] i40e Link Flapping w/dpdk

2019-10-17 Thread Aaron Conole
Greetings, I have a customer issue where the PMD status is intermittently reporting link status failure. According to the customer, the link status on the physical wire doesn't go down (at least the endpoint doesn't report it). This usually gets resolved by restarting the application. On reboot

[dpdk-dev] [PATCH v3] net/octeontx2: add set supported types op

2019-10-17 Thread pbhagavatula
From: Pavan Nikhilesh Add support to set supported ptypes for octeontx2. Signed-off-by: Pavan Nikhilesh --- v3 Changes: -- - Actually update doc file. v2 Changes: -- - Update documentation. - Use positive logic. doc/guides/nics/octeontx2.rst | 5 - d

Re: [dpdk-dev] [PATCH v2] net/octeontx2: add set supported types op

2019-10-17 Thread Pavan Nikhilesh Bhagavatula
>On Thu, Oct 17, 2019 at 5:50 PM wrote: >> >> From: Pavan Nikhilesh >> >> Add support to set supported ptypes for octeontx2. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> v2 Changes: >> -- >> - Update documentation. > >See below. > >> - Use positive logic. >> >> drivers/net/octeont

Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 5:04 PM, Ferruh Yigit wrote: > On 10/17/2019 12:52 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at > Cisco) wrote: >> >>> Hi Jakub, >>> >>> Just to double check if anyone is looking into the bind() error issue which >>> is >>> since following commit, I am waiting for more

Re: [dpdk-dev] [PATCH v7 2/7] eal: add the APIs to wait until equal

2019-10-17 Thread Ananyev, Konstantin
> > Hi Gavin, > > > > > The rte_wait_until_equal_xx APIs abstract the functionality of > > 'polling for a memory location to become equal to a given value'. > > > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled > > by default. When it is enabled, the above APIs will call WFE

Re: [dpdk-dev] [RFC] mempool: introduce indexed memory pool

2019-10-17 Thread Jerin Jacob
On Thu, Oct 17, 2019 at 6:43 PM Xueming(Steven) Li wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, October 17, 2019 3:14 PM > > To: Xueming(Steven) Li > > Cc: Olivier Matz ; Andrew Rybchenko > > ; dpdk-dev ; Asaf Penso > > ; Ori Kam > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64

2019-10-17 Thread David Marchand
On Thu, Oct 17, 2019 at 6:18 PM Burakov, Anatoly wrote: > > On 16-Oct-19 9:45 PM, David Christensen wrote: > >>> An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when > >>> it should actually use "RTE_ARCH_PPC_64". Simple testing revealed > >>> that both the PPC_64 and non-PPC_64 vers

[dpdk-dev] [PATCH v2 2/2] crypto/aesni_gcm: allow device init if no AES-NI is present

2019-10-17 Thread Pablo de Lara
The IPSec Multi buffer library does not require AES-NI instructions to be supported by the CPU, as it can emulate these instructions in software (adding a big performance penalty when using AES algorithms). Signed-off-by: Pablo de Lara --- v2: - Fixed leading whitespaces drivers/crypto/aesni_gc

[dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: allow device init if no AES-NI is present

2019-10-17 Thread Pablo de Lara
The IPSec Multi buffer library does not require AES-NI instructions to be supported by the CPU, as it can emulate these instructions in software (adding a big performance penalty when using AES algorithms). Signed-off-by: Pablo de Lara --- v2: - Fixed leading whitespaces drivers/crypto/aesni_mb

Re: [dpdk-dev] [PATCH v2] net/octeontx2: add set supported types op

2019-10-17 Thread Jerin Jacob
On Thu, Oct 17, 2019 at 5:50 PM wrote: > > From: Pavan Nikhilesh > > Add support to set supported ptypes for octeontx2. > > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > -- > - Update documentation. See below. > - Use positive logic. > > drivers/net/octeontx2/otx2_ethdev.c

Re: [dpdk-dev] Testpmd parameter --enable-lro fails on Mellanox ConnectX5

2019-10-17 Thread Asaf Penso
Hi, For the LRO feature to work in our pmd, please add dv_flow_en=1 as following: sudo ./testpmd -l 0-15 -w :03:00.1,dv_flow_en=1 -v -- --txq=16 --rxq=16 --nb-cores=15 --enable-lro -i Can you try this and let us know the result? Regards, Asaf Penso > -Original Message- > From: dev

[dpdk-dev] [PATCH 2/2] crypto/aesni_gcm: allow device init if no AES-NI is present

2019-10-17 Thread Pablo de Lara
The IPSec Multi buffer library does not require AES-NI instructions to be supported by the CPU, as it can emulate these instructions in software (adding a big performance penalty when using AES algorithms). Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12 ++

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: allow device init if no AES-NI is present

2019-10-17 Thread Pablo de Lara
The IPSec Multi buffer library does not require AES-NI instructions to be supported by the CPU, as it can emulate these instructions in software (adding a big performance penalty when using AES algorithms). Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 13 ++--

Re: [dpdk-dev] [PATCH] eal:ppc: fix incorrect ifdef for ppc_64

2019-10-17 Thread Burakov, Anatoly
On 16-Oct-19 9:45 PM, David Christensen wrote: An ifdef present in eal_memory.c references "RTE_ARCH_PPC64" when it should actually use "RTE_ARCH_PPC_64".  Simple testing revealed that both the PPC_64 and non-PPC_64 versions of the code involved work, but the PPC_64 version of the code is retaine

Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 12:52 PM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > >> Hi Jakub, >> >> Just to double check if anyone is looking into the bind() error issue which >> is >> since following commit, I am waiting for more input on it. >> >> Commit b923866c6974 ("net/memif:

Re: [dpdk-dev] [PATCH v4 07/10] distributor: rename v2.0 ABI to _single suffix

2019-10-17 Thread Hunt, David
On 17/10/2019 15:31, Anatoly Burakov wrote: From: Marcin Baran The original ABI versioning was slightly misleading in that the DPDK 2.0 ABI was really a single mode for the distributor, and is used as such throughout the distributor code. Fix this by renaming all _v20 API's to _single API's,

Re: [dpdk-dev] [PATCH v4 06/10] distributor: remove deprecated code

2019-10-17 Thread Hunt, David
On 17/10/2019 15:31, Anatoly Burakov wrote: From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage Hi Anatoly,

Re: [dpdk-dev] [PATCH v3] doc: add graphic showing layout of mbuf struct

2019-10-17 Thread Olivier Matz
Hi, On Tue, Aug 27, 2019 at 10:02:30AM +0100, A.McLoughlin wrote: > This patch adds a graphical overview of the rte_mbuf struct, showing where > each value is stored within the struct. > > Signed-off-by: A.McLoughlin > --- > v1 -> v2: > * changed uint16_t refcnt(+atomic) to uint16_t refcnt > v2

[dpdk-dev] [PATCH v6 6/6] doc/ipsec: update ipsec programmer's guide

2019-10-17 Thread Vladimir Medvedkin
Add section about ipsec SAD Update release notes Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/ipsec_lib.rst| 152 + doc/guides/rel_notes/release_19_11.rst | 3 + 2 files changed, 155 insertions(+) diff --git a/doc/guides/prog_guide/ipsec_lib.

[dpdk-dev] [PATCH v6 5/6] app: add test-sad application

2019-10-17 Thread Vladimir Medvedkin
Introduce new application to provide user to evaluate and perform custom functional and performance tests for IPsec SAD implementation. Signed-off-by: Vladimir Medvedkin Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev --- app/Makefile | 1 + app/

[dpdk-dev] [PATCH v6 3/6] ipsec: add SAD add/delete/lookup implementation

2019-10-17 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is addressed by SPI only or SPI+DIP or SPI+DIP+SIP) Signed-off-by: Vladimir Medvedkin

[dpdk-dev] [PATCH v6 2/6] ipsec: add SAD create/destroy implementation

2019-10-17 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_create(), rte_ipsec_sad_destroy() and rte_ipsec_sad_find_existing() API stubs with actual implementation. Signed-off-by: Vladimir Medvedkin Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev --- lib/librte_ipsec/Makefile| 2 +- lib/lib

[dpdk-dev] [PATCH v6 4/6] test/ipsec: add ipsec SAD autotests

2019-10-17 Thread Vladimir Medvedkin
add unittests for ipsec SAD library Signed-off-by: Vladimir Medvedkin Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 1 + app/test/test_ipsec_sad.c | 887 +

[dpdk-dev] [PATCH v6 1/6] ipsec: add inbound SAD API

2019-10-17 Thread Vladimir Medvedkin
Add inbound security association database (SAD) API and stub implementation. Signed-off-by: Vladimir Medvedkin Acked-by: Akhil Goyal Acked-by: Konstantin Ananyev --- lib/librte_ipsec/Makefile | 2 + lib/librte_ipsec/ipsec_sad.c | 50 ++ lib/librte_ipsec/meson.

[dpdk-dev] [PATCH v6 0/6] ipsec: add inbound SAD

2019-10-17 Thread Vladimir Medvedkin
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD). For each incoming inbound IPSec-protected packet (ESP or AH) it has to perform a lookup within it’s SAD. Lookup should be performed by: Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP) or SPI +

Re: [dpdk-dev] [PATCH v7 2/7] eal: add the APIs to wait until equal

2019-10-17 Thread David Marchand
On Fri, Sep 27, 2019 at 7:42 AM Gavin Hu wrote: > > The rte_wait_until_equal_xx APIs abstract the functionality of > 'polling for a memory location to become equal to a given value'. > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled > by default. When it is enabled, the above A

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-10-17 Thread Burakov, Anatoly
On 15-Oct-19 6:30 AM, Ajit Khaparde wrote: From: Rajesh Ravi Support external custom memory added to heap to be used with vfio with --iso-cmem option.Type1 memory mapping was by passed for external memory. But an exception is added to allow external custom memory to be used with vfio. Signed-o

Re: [dpdk-dev] [PATCH v4 01/15] ethdev: move queue state defines to private file

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 15:32:03 + Ori Kam wrote: > /** > + * RX/TX queue states > + */ > +#define RTE_ETH_QUEUE_STATE_STOPPED 0 > +#define RTE_ETH_QUEUE_STATE_STARTED 1 Why not make it an enum?

Re: [dpdk-dev] [RFC] net/null: add empty promiscuous mode functions

2019-10-17 Thread Ferruh Yigit
On 10/17/2019 2:43 PM, Bruce Richardson wrote: > On Thu, Oct 17, 2019 at 12:05:56PM +0100, Ferruh Yigit wrote: >> On 10/17/2019 11:51 AM, Andrew Rybchenko wrote: >>> On 10/17/19 1:47 PM, Ferruh Yigit wrote: On 10/17/2019 11:37 AM, Andrew Rybchenko wrote: > On 10/16/19 9:07 PM, Ferruh Yigit

[dpdk-dev] [PATCH v4 15/15] doc: add hairpin feature

2019-10-17 Thread Ori Kam
This commit adds the hairpin feature to the release notes. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_19_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst

[dpdk-dev] [PATCH v4 14/15] net/mlx5: split hairpin flows

2019-10-17 Thread Ori Kam
Since the encap action is not supported in RX, we need to split the hairpin flow into RX and TX. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 10 ++ drivers/net/mlx5/mlx5.h| 10 ++ drivers/net/mlx5/mlx5_flow.c | 281

[dpdk-dev] [PATCH v4 12/15] net/mlx5: add id generation function

2019-10-17 Thread Ori Kam
When splitting flows for example in hairpin / metering, there is a need to combine the flows. This is done using ID. This commit introduce a simple way to generate such IDs. The reason why bitmap was not used is due to fact that the release and allocation are O(n) while in the chosen approch the a

[dpdk-dev] [PATCH v4 13/15] net/mlx5: add default flows for hairpin

2019-10-17 Thread Ori Kam
When using hairpin all traffic from TX hairpin queues should jump to dedecated table where matching can be done using regesters. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_flow.c| 60 +

[dpdk-dev] [PATCH v4 10/15] net/mlx5: add support for hairpin hrxq

2019-10-17 Thread Ori Kam
Add support for rss on hairpin queues. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 3 ++ drivers/net/mlx5/mlx5_ethdev.c | 102 ++-- drivers/net/mlx5/mlx5_rss.c | 1 + drivers/net/mlx5/mlx5_rxq.c |

[dpdk-dev] [PATCH v4 07/15] net/mlx5: add get hairpin capabilities

2019-10-17 Thread Ori Kam
This commits adds the hairpin get capabilities function. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 3 ++- drivers/net/mlx5/mlx5_ethdev.c | 27 +++ 3 files changed, 31 insertions(+)

[dpdk-dev] [PATCH v4 09/15] net/mlx5: add hairpin binding function

2019-10-17 Thread Ori Kam
When starting the port, in addition to creating the queues we need to bind the hairpin queues. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_devx_cmds.c | 1 + drivers/net/mlx5/mlx5_prm.h | 6 +++ drivers/net/m

[dpdk-dev] [PATCH v4 11/15] net/mlx5: add internal tag item and action

2019-10-17 Thread Ori Kam
This commit introduce the setting and matching on regiters. This item and and action will be used with number of different features like hairpin, metering, metadata. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c| 52 + drivers/net/mlx5/

[dpdk-dev] [PATCH v4 08/15] app/testpmd: add hairpin support

2019-10-17 Thread Ori Kam
This commit introduce the hairpin queues to the testpmd. the hairpin queue is configured using --hairpinq= the hairpin queue adds n queue objects for both the total number of TX queues and RX queues. The connection between the queues are 1 to 1, first Rx hairpin queue will be connected to the first

[dpdk-dev] [PATCH v4 02/15] ethdev: add support for hairpin queue

2019-10-17 Thread Ori Kam
This commit introduce hairpin queue type. The hairpin queue in build from Rx queue binded to Tx queue. It is used to offload traffic coming from the wire and redirect it back to the wire. There are 3 new functions: - rte_eth_dev_hairpin_capability_get - rte_eth_rx_hairpin_queue_setup - rte_eth_tx

[dpdk-dev] [PATCH v4 04/15] net/mlx5: support Rx hairpin queues

2019-10-17 Thread Ori Kam
This commit adds the support for creating Rx hairpin queues. Hairpin queue is a queue that is created using DevX and only used by the HW. This results in that all the data part of the RQ is not being used. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v4 06/15] net/mlx5: support Tx hairpin queues

2019-10-17 Thread Ori Kam
This commit adds the support for creating Tx hairpin queues. Hairpin queue is a queue that is created using DevX and only used by the HW. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 36 +- drivers/net/mlx5/mlx5.h | 46

[dpdk-dev] [PATCH v4 05/15] net/mlx5: prepare txq to work with different types

2019-10-17 Thread Ori Kam
Currenlty all Tx queues are created using Verbs. This commit modify the naming so it will not include verbs, since in next commit a new type will be introduce (hairpin) Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v4 03/15] net/mlx5: query hca hairpin capabilities

2019-10-17 Thread Ori Kam
This commit query and store the hairpin capabilities from the device. Those capabilities will be used when creating the hairpin queue. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 4 drivers/net/mlx5/mlx5_devx_cmds.c | 7 +++ 2 files c

[dpdk-dev] [PATCH v4 01/15] ethdev: move queue state defines to private file

2019-10-17 Thread Ori Kam
The queue state defines are internal to the DPDK. This commit moves them to a private header file. Signed-off-by: Ori Kam --- V4: - new file, created due to ML comments. --- lib/librte_ethdev/rte_ethdev.h| 6 -- lib/librte_ethdev/rte_ethdev_driver.h | 6 ++ 2 files changed, 6

[dpdk-dev] [PATCH v4 00/15] add hairpin feature

2019-10-17 Thread Ori Kam
s patch set implements the hairpin feature. The hairpin feature was introduced in RFC[1] The hairpin feature (different name can be forward) acts as "bump on the wire", meaning that a packet that is received from the wire can be modified using offloaded action and then sent back to the wire withou

Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 07:27:34 + Shahaf Shuler wrote: > Some PMDs inline the mbuf data buffer directly to device. This is in > order to save the overhead of the PCI headers involved when the device > DMA read the buffer pointer. For some devices it is essential in order > to reach the pick BW.

Re: [dpdk-dev] rte_eth_dev_count_avail() returns 0 with the MLX5 NIC card

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 18:37:09 +0530 vikram T wrote: > Hi, > I am facing an issue with rte_eth_dev_count_avail() returns 0 on the MLX5 > NIC card. > "dpdk-devbind.py -s" says that the interface is bound to mlx5_core. ( Need > not be bounded to igb_uio) > > *# /var/cache/ocsm/dpdk/dpdk-18.11/userto

Re: [dpdk-dev] [PATCH v7 1/7] bus/fslmc: fix the conflicting dmb function

2019-10-17 Thread David Marchand
On Fri, Sep 27, 2019 at 7:42 AM Gavin Hu wrote: > > There are two definitions conflicting each other, for more > details, refer to [1]. > > include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror] > drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the > previous definition >

[dpdk-dev] [PATCH] vhost: disable host TSO for linear buffers without extbuf

2019-10-17 Thread Ilya Maximets
If linear buffers requested and external buffers are not, vhost will not be able to receive any buffer that doesn't fit in a single mbuf. Moreover, if such a buffer will appear in a vring it will never be dequeued and the whole vring will become dead breaking the network connection. Disable segme

  1   2   3   >