[dpdk-dev] [PATCH v11 1/3] ethdev: decouple flow types and RSS offload types

2019-10-08 Thread Simei Su
This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. The former defines flow types and the latter defines RSS offload types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 49 ---

[dpdk-dev] [PATCH v11 2/3] ethdev: extend RSS offload types

2019-10-08 Thread Simei Su
This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev.c | 5 + lib/librte_ethdev/rte_ethdev.

[dpdk-dev] [PATCH v11 3/3] app/testpmd: add RSS offload types extending support

2019-10-08 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- app/test-pmd/cmdline.c | 14 -- app/test-pmd/config.c | 4 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test

Re: [dpdk-dev] [PATCH v3 13/14] net/ppfe: add link status update

2019-10-08 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Friday, October 4, 2019 9:13 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: tho...@monjalon.net > Subject: Re: [PATCH v3 13/14] net/ppfe: add link status update > > On 10/1/2019 12:02 PM, Gagandeep Singh wrote: > > This patch add link rel

[dpdk-dev] [PATCH v11 0/3] extend RSS offload types

2019-10-08 Thread Simei Su
[PATCH v11 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v11 2/3] ethdev: add several bits for extending rss offload types. [PATCH v11 3/3] app/testpmd: add cmdline support for extending rss types. v11: * Update code logic in rte_eth_dev_configure() and rte_eth_dev_rss_hash_upda

Re: [dpdk-dev] [PATCH v3 03/14] doc: add guide for ppfe net PMD

2019-10-08 Thread Gagandeep Singh
> <...> > > > +Driver compilation and testing > > +~~ > > + > > +Follow instructions available in the document > > +:ref:`compiling and testing a PMD for a NIC ` > > +to launch **testpmd** > > + > > +Additionally, PPFE driver needs `--vdev` as an input with value `eth_p

Re: [dpdk-dev] [PATCH v3 07/14] net/ppfe: add device start stop operations

2019-10-08 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Friday, October 4, 2019 9:13 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: tho...@monjalon.net; Akhil Goyal > Subject: Re: [PATCH v3 07/14] net/ppfe: add device start stop operations > > On 10/1/2019 12:02 PM, Gagandeep Singh wrote: > >

Re: [dpdk-dev] [PATCH v3 02/14] net/ppfe: introduce ppfe net poll mode driver

2019-10-08 Thread Gagandeep Singh
> <...> > > > @@ -0,0 +1,28 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright 2019 NXP > > +# > > + > > +include $(RTE_SDK)/mk/rte.vars.mk > > + > > +# > > +# library name > > +# > > +LIB = librte_pmd_ppfe.a > > + > > +CFLAGS += -O3 $(WERROR_FLAGS) > > +CFLAGS += -I$(RTE_SDK)/drive

Re: [dpdk-dev] [PATCH v4 1/1] mbuf: add bulk free function

2019-10-08 Thread Andrew Rybchenko
On 10/8/19 11:12 PM, Morten Brørup wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko Sent: Tuesday, October 8, 2019 7:26 PM On 10/7/19 1:14 PM, Morten Brørup wrote: Add function for freeing a bulk of mbufs. v4: * Marked as experimental by a

[dpdk-dev] [PATCH v4 12/14] vhost: optimize dequeue function of packed ring

2019-10-08 Thread Marvin Liu
Optimize vhost device Rx datapath by separate functions. No-chained and direct descriptors will be handled by batch and other will be handled one by one as before. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index deb9d0e39..56c2080fb 1006

[dpdk-dev] [PATCH v4 14/14] vhost: optimize packed ring dequeue when in-order

2019-10-08 Thread Marvin Liu
When VIRTIO_F_IN_ORDER feature is negotiated, vhost can optimize dequeue function by only update first used descriptor. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 046e497c2..6f28082bc 100644 --- a/lib/librte_vhost/virtio_net.c +++ b

[dpdk-dev] [PATCH v4 11/14] vhost: add batch and single zero dequeue functions

2019-10-08 Thread Marvin Liu
Optimize vhost zero copy dequeue path like normal dequeue path. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 5f2822ba2..deb9d0e39 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c @@ -1881,6 +1881,141 @@ v

[dpdk-dev] [PATCH v4 13/14] vhost: check whether disable software pre-fetch

2019-10-08 Thread Marvin Liu
Disable software pre-fetch actions on Skylake and later platforms. Hardware can fetch needed data for vhost, additional software pre-fetch will impact performance. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 30839a001..5f3b42e56 100644 --- a

[dpdk-dev] [PATCH v4 09/14] vhost: split enqueue and dequeue flush functions

2019-10-08 Thread Marvin Liu
Vhost enqueue descriptors are updated by batch number, while vhost dequeue descriptors are buffered. Meanwhile in dequeue function only first descriptor is buffered. Due to these differences, split vhost enqueue and dequeue flush functions. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost

[dpdk-dev] [PATCH v4 07/14] vhost: add flush function for batch enqueue

2019-10-08 Thread Marvin Liu
Flush used flags when batched enqueue function is finished. Descriptor's flags are pre-calculated as they will be reset by vhost. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 18a207fc6..7bf9ff9b7 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/

[dpdk-dev] [PATCH v4 10/14] vhost: optimize enqueue function of packed ring

2019-10-08 Thread Marvin Liu
Optimize vhost device Tx datapath by separate functions. Packets can be filled into one descriptor will be handled by batch and others will be handled one by one as before. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 1b0fa2c64..5f282

[dpdk-dev] [PATCH v4 06/14] vhost: flush vhost enqueue shadow ring by batch

2019-10-08 Thread Marvin Liu
Buffer vhost enqueue shadow ring update, flush shadow ring until buffered descriptors number exceed one batch. Thus virtio can receive packets at a faster frequency. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index e50e137ca..18a207fc6 100644 --- a

[dpdk-dev] [PATCH v4 05/14] vhost: add batch dequeue function

2019-10-08 Thread Marvin Liu
Add batch dequeue function like enqueue function for packed ring, batch dequeue function will not support chained descritpors, single packet dequeue function will handle it. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index e241436c7..e50e137ca 1006

[dpdk-dev] [PATCH v4 08/14] vhost: buffer vhost dequeue shadow ring

2019-10-08 Thread Marvin Liu
Buffer used ring updates as many as possible in vhost dequeue function for coordinating with virtio driver. For supporting buffer, shadow used ring element should contain descriptor index and its wrap counter. First shadowed ring index is recorded for calculating buffered number. Signed-off-by: Ma

[dpdk-dev] [PATCH v4 01/14] vhost: add single packet enqueue function

2019-10-08 Thread Marvin Liu
Add vhost enqueue function for single packet and meanwhile left space for flush used ring function. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 5b85b832d..520c4c6a8 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/vi

[dpdk-dev] [PATCH v4 04/14] vhost: add single packet dequeue function

2019-10-08 Thread Marvin Liu
Add vhost single packet dequeue function for packed ring and meanwhile left space for shadow used ring update function. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 5e08f7d9b..17aabe8eb 100644 --- a/lib/librte_vhost/virtio_net.c +++ b

[dpdk-dev] [PATCH v4 02/14] vhost: unify unroll pragma parameter

2019-10-08 Thread Marvin Liu
Add macro for unifying Clang/ICC/GCC unroll pragma format. Batch functions were contained of several small loops which optimized by compiler’s loop unrolling pragma. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index 8623e91c0..30839a001 100644 ---

[dpdk-dev] [PATCH v4 00/14] vhost packed ring performance optimization

2019-10-08 Thread Marvin Liu
Packed ring has more compact ring format and thus can significantly reduce the number of cache miss. It can lead to better performance. This has been approved in virtio user driver, on normal E5 Xeon cpu single core performance can raise 12%. http://mails.dpdk.org/archives/dev/2018-April/095470.ht

[dpdk-dev] [PATCH v4 03/14] vhost: add batch enqueue function for packed ring

2019-10-08 Thread Marvin Liu
Batch enqueue function will first check whether descriptors are cache aligned. It will also check prerequisites in the beginning. Batch enqueue function not support chained mbufs, single packet enqueue function will handle it. Signed-off-by: Marvin Liu diff --git a/lib/librte_vhost/vhost.h b/lib

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/distributor: fix deadlock issue for aarch64

2019-10-08 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: David Marchand > Sent: Wednesday, October 9, 2019 03:47 > To: Aaron Conole > Cc: Ruifeng Wang (Arm Technology China) ; David > Hunt ; dev ; hka...@marvell.com; > Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; nd ; dpdk > stable > Subject: Re: [dp

Re: [dpdk-dev] [PATCH v10 1/5] mempool: populate mempool with the page sized chunks

2019-10-08 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Olivier Matz > Sent: Tuesday, October 8, 2019 2:57 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; ferruh.yi...@intel.com; anatoly.bura...@intel.com; > arybche...@solarflare.com; Kiran Kumar Kokkilagadd

Re: [dpdk-dev] [PATCH v3 1/3] lib/ring: add peek API

2019-10-08 Thread Honnappa Nagarahalli
> > > > > > > Subject: [PATCH v3 1/3] lib/ring: add peek API > > > > > > > > From: Ruifeng Wang > > > > > > > > The peek API allows fetching the next available object in the ring > > > > without dequeuing it. This helps in scenarios where dequeuing of > > > > objects depend on their value. > >

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: integrate RCU QSBR

2019-10-08 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > On 01/10/2019 19:28, Honnappa Nagarahalli wrote: > > From: Ruifeng Wang > > > > Currently, the tbl8 group is freed even though the readers might be > > using the tbl8 group entries. The freed tbl8 group can be reallocated > > quickly. This results in incorrect lookup resul

[dpdk-dev] [PATCH v4 2/2] test/ring: add test cases for configurable element size ring

2019-10-08 Thread Honnappa Nagarahalli
Add test cases to test APIs for configurable element size ring. Signed-off-by: Honnappa Nagarahalli --- app/test/Makefile | 1 + app/test/meson.build | 1 + app/test/test_ring_perf_elem.c | 419 + 3 files changed, 421 insertions(+) crea

[dpdk-dev] [PATCH v3 0/2] lib/ring: APIs to support custom element size

2019-10-08 Thread Honnappa Nagarahalli
The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

[dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-08 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

Re: [dpdk-dev] [PATCH v3 03/15] vhost: add batch enqueue function for packed ring

2019-10-08 Thread Liu, Yong
> -Original Message- > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Thursday, September 26, 2019 3:31 AM > To: Liu, Yong ; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; > step...@networkplumber.org; gavin...@arm.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev

[dpdk-dev] [PATCH v3] build: add emag(arm64) platform and default config

2019-10-08 Thread Gavin Hu
From: Jerry Hao OS config: add emag configuration mk/machine: add emag machine configurations eMAG is Ampere Computing 64-bit ARM processor with 32 Arm v8 64-bit CPU cores. For more information, refer to: https://amperecomputing.com/product/ Signed-off-by: Jerry Hao OS Signed-off-by: Gavin Hu

Re: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier

2019-10-08 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > > Sent: Tuesday, October 8, 2019 7:05 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; Honnappa Nagarahalli > ; Damjan Marion (damarion) > ; n

Re: [dpdk-dev] [PATCH v3 13/15] vhost: cache address translation result

2019-10-08 Thread Liu, Yong
> -Original Message- > From: Bie, Tiwei > Sent: Thursday, September 26, 2019 1:32 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > step...@networkplumber.org; gavin...@arm.com; dev@dpdk.org > Subject: Re: [PATCH v3 13/15] vhost: cache address translation result > >

[dpdk-dev] [PATCH v2] net/memif: optimized with one-way barrier

2019-10-08 Thread Phil Yang
Using 'rte_mb' to synchronize the shared ring head/tail between producer and consumer will stall the pipeline and damage performance on the weak memory model platform such like AArch64. Meanwhile update the shared ring head and tail are observable and ordered between CPUs on IA. Optimized this ful

Re: [dpdk-dev] [PATCH v2 08/10] ipsec: add rte_security cpu_crypto action support

2019-10-08 Thread Ananyev, Konstantin
Hi Fan, Comments for inbound part inline. As I can see majority of my v1 comments still are not addressed. Please check. Konstantin > > This patch updates the ipsec library to handle the newly introduced > RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action. > > Signed-off-by: Fan Zhang > --- > lib/lib

[dpdk-dev] [PATCH v2 7/7] lib/rcu: update QS only when there are updates from writer

2019-10-08 Thread Honnappa Nagarahalli
When the writer is checking the quiescent state status, it is not deleting any entries in the data structure. This means, the readers do not need to update their quiescent state during that period. Readers update the quiescent state only when there are updates available from the writer. Signed-off

[dpdk-dev] [PATCH v2 6/7] lib/rcu: add least acknowledged token optimization

2019-10-08 Thread Honnappa Nagarahalli
When the rte_rcu_qsbr_check API is called, it is possible to calculate the least valued token acknowledged by all the readers. When the API is called next time, the readers' token counters do not need to be scanned if the value of the token being queried is less than the last least token acknowledg

[dpdk-dev] [PATCH v2 5/7] test/rcu: use correct nomenclature while printing results

2019-10-08 Thread Honnappa Nagarahalli
Use 'quiescent state updates' instead of just 'updates'. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/test_rcu_qsbr_perf.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_perf.

[dpdk-dev] [PATCH v2 2/7] doc/rcu: correct the limitation on number of threads

2019-10-08 Thread Honnappa Nagarahalli
There is no limitation of 1024 reader threads. Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu --- doc/guides/prog_guide/rcu_lib.rst | 3 +-- 1 file changed, 1 insert

[dpdk-dev] [PATCH v2 3/7] doc/rcu: add information about storing token and resource

2019-10-08 Thread Honnappa Nagarahalli
After calling rte_rcu_qsbr_start API, the token and the deleted resource need to be stored for subsequent query/free. Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- doc/guides/prog_guide/r

[dpdk-dev] [PATCH v2 1/7] doc/rcu: fix typos

2019-10-08 Thread Honnappa Nagarahalli
Fix typos. Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu --- doc/guides/prog_guide/rcu_lib.rst | 24 1 file changed, 12 insertions(+), 12 d

[dpdk-dev] [PATCH v2 4/7] test/rcu: use size_t instead of int

2019-10-08 Thread Honnappa Nagarahalli
Variables used to store the return value of rte_rcu_qsbr_get_memsize in variables of type 'int'. The variables are of type 'size_t' now. Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- app/test/tes

[dpdk-dev] [PATCH 0/7] typo, doc, simple fixes and some optimizations

2019-10-08 Thread Honnappa Nagarahalli
Few typo fixes, some corrections to the documentation and simple fixes to the test cases. The last 2 commits contain simple optimizations with good amount of performance improvements. v2: All instances of size_t fixed (Ruifeng) Honnappa Nagarahalli (7): doc/rcu: fix typos doc/rcu: correct

Re: [dpdk-dev] [RFC 5/8] pdump: add classic BPF filtering

2019-10-08 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, October 8, 2019 6:23 AM > > On Tue, 8 Oct 2019 09:45:45 +0530 > Jerin Jacob wrote: > > > On Tue, 8 Oct, 2019, 9:31 AM Stephen Hemminger, > > > wrote: > > > > > On Tue, 8 Oct 20

Re: [dpdk-dev] [PATCH v4 1/1] mbuf: add bulk free function

2019-10-08 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Tuesday, October 8, 2019 7:26 PM > > On 10/7/19 1:14 PM, Morten Brørup wrote: > > Add function for freeing a bulk of mbufs. > > > > v4: > > * Marked as experimental by adding __rte_experime

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/distributor: fix deadlock issue for aarch64

2019-10-08 Thread Aaron Conole
David Marchand writes: > On Tue, Oct 8, 2019 at 7:06 PM Aaron Conole wrote: >> >> Ruifeng Wang writes: >> >> > Distributor and worker threads rely on data structs in cache line >> > for synchronization. The shared data structs were not protected. >> > This caused deadlock issue on weaker memory

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/distributor: fix deadlock issue for aarch64

2019-10-08 Thread David Marchand
On Tue, Oct 8, 2019 at 7:06 PM Aaron Conole wrote: > > Ruifeng Wang writes: > > > Distributor and worker threads rely on data structs in cache line > > for synchronization. The shared data structs were not protected. > > This caused deadlock issue on weaker memory ordering platforms as > > aarch6

[dpdk-dev] [PATCH v3 1/2] lib/ring: apis to support configurable element size

2019-10-08 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. Add new APIs to support configurable ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_rin

[dpdk-dev] [PATCH v3 2/2] test/ring: add test cases for configurable element size ring

2019-10-08 Thread Honnappa Nagarahalli
Add test cases to test APIs for configurable element size ring. Signed-off-by: Honnappa Nagarahalli --- app/test/Makefile | 1 + app/test/meson.build | 1 + app/test/test_ring_perf_elem.c | 419 + 3 files changed, 421 insertions(+) crea

[dpdk-dev] [PATCH v3 0/2] lib/ring: APIs to support custom element size

2019-10-08 Thread Honnappa Nagarahalli
The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

Re: [dpdk-dev] [PATCH 1/2] test/bonding: fix LSC related test cases

2019-10-08 Thread Yigit, Ferruh
On 8/23/2019 9:16 AM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > On rare situation test_link_bonding test case fail due to timespec > tv_nsec overflow, which causes pthread_cond_timedwait to return EINVAL > and test to fail. > > Fixes: 76d29903f5f5 ("bond: support link status interrup

Re: [dpdk-dev] [PATCH] app/test-pmd: add support for tx and rx desc statu

2019-10-08 Thread Ferruh Yigit
On 9/3/2019 4:39 AM, kirankum...@marvell.com wrote: > From: Kiran Kumar K > > Adding support to check TX and RX descriptor status. +1 to the command > > Signed-off-by: Kiran Kumar K > --- > app/test-pmd/cmdline.c | 111 > doc/guides/testpmd_app_ug/te

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix RSS setting on v4

2019-10-08 Thread Ferruh Yigit
On 9/16/2019 8:01 PM, Yong Wang wrote: > > From: Eduard Serra Miralles > Date: Friday, September 13, 2019 at 1:10 PM > To: Yong Wang > Cc: "dev@dpdk.org" > Subject: RE: [PATCH] net/vmxnet3: fix RSS setting on v4 > > > I think so too. Apparently however, ESX is mandatorily expecting that > un

Re: [dpdk-dev] [PATCH] kni: support allmulticast mode set

2019-10-08 Thread Yigit, Ferruh
On 8/12/2019 4:06 AM, Xiaolong Ye wrote: > This patch adds support to allow users enable/disable allmulticast mode for > kni interface. > > This requirement comes from bugzilla 312, more details can refer to: > https://bugs.dpdk.org/show_bug.cgi?id=312 > > Bugzilla ID: 312 > > Signed-off-by: Xia

Re: [dpdk-dev] [PATCH v4 1/1] mbuf: add bulk free function

2019-10-08 Thread Andrew Rybchenko
On 10/7/19 1:14 PM, Morten Brørup wrote: Add function for freeing a bulk of mbufs. v4: * Marked as experimental by adding __rte_experimental. * Add function to experimental section of map file. * Fix source code formatting regarding pointer to pointer. * Squashed multiple modifications into one.

Re: [dpdk-dev] [PATCH] lib/distributor: fix deadlock issue for aarch64

2019-10-08 Thread Aaron Conole
Ruifeng Wang writes: > Distributor and worker threads rely on data structs in cache line > for synchronization. The shared data structs were not protected. > This caused deadlock issue on weaker memory ordering platforms as > aarch64. > Fix this issue by adding memory barriers to ensure synchroni

[dpdk-dev] [PATCH v4 5/5] app: add test-sad application

2019-10-08 Thread Vladimir Medvedkin
Introduce new application to provide user to evaluate and perform custom functional and performance tests for IPsec SAD implementation. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev --- app/Makefile | 1 + app/meson.build |

[dpdk-dev] [PATCH v4 1/5] ipsec: add inbound SAD API

2019-10-08 Thread Vladimir Medvedkin
Add inbound security association database (SAD) API and stub implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile | 2 + lib/librte_ipsec/ipsec_sad.c | 50 ++ lib/librte_ipsec/meson.build | 4 +- lib/librte_ipsec/rte_ipsec_

[dpdk-dev] [PATCH v4 2/5] ipsec: add SAD create/destroy implementation

2019-10-08 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_create(), rte_ipsec_sad_destroy() and rte_ipsec_sad_find_existing() API stubs with actual implementation. Signed-off-by: Vladimir Medvedkin --- lib/librte_ipsec/Makefile| 2 +- lib/librte_ipsec/ipsec_sad.c | 225 +-- lib/librte_

[dpdk-dev] [PATCH v4 0/5] ipsec: add inbound SAD

2019-10-08 Thread Vladimir Medvedkin
According to RFC 4301 IPSec implementation needs an inbound SA database (SAD). For each incoming inbound IPSec-protected packet (ESP or AH) it has to perform a lookup within it’s SAD. Lookup should be performed by: Security Parameters Index (SPI) + destination IP (DIP) + source IP (SIP) or SPI +

[dpdk-dev] [PATCH v4 3/5] ipsec: add SAD add/delete/lookup implementation

2019-10-08 Thread Vladimir Medvedkin
Replace rte_ipsec_sad_add(), rte_ipsec_sad_del() and rte_ipsec_sad_lookup() stubs with actual implementation. It uses three librte_hash tables each of which contains an entries for a specific SA type (either it is addressed by SPI only or SPI+DIP or SPI+DIP+SIP) Signed-off-by: Vladimir Medvedkin

[dpdk-dev] [PATCH v4 4/5] test/ipsec: add ipsec SAD autotests

2019-10-08 Thread Vladimir Medvedkin
add unittests for ipsec SAD library Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Tested-by: Konstantin Ananyev --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 1 + app/test/test_ipsec_sad.c | 887

Re: [dpdk-dev] [PATCH v10 2/3] ethdev: extend RSS offload types

2019-10-08 Thread Andrew Rybchenko
On 10/4/19 7:46 AM, Simei Su wrote: This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev.c |

[dpdk-dev] [PATCH v6 5/5] mbuf: add pktmbuf copy test

2019-10-08 Thread Stephen Hemminger
New test for rte_pktmbuf_copy based of the clone tests. Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz --- app/test/test_mbuf.c | 157 +++ 1 file changed, 157 insertions(+) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index aafad0cf6

[dpdk-dev] [PATCH v6 4/5] mbuf: add a pktmbuf copy routine

2019-10-08 Thread Stephen Hemminger
This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine

[dpdk-dev] [PATCH v6 1/5] mbuf: don't generate invalid mbuf in clone test

2019-10-08 Thread Stephen Hemminger
The test for cloning changed mbuf would generate an mbuf whose length and segments were invalid. This would cause a crash if test was run with mbuf debugging enabled. Fixes: f1022aba76a5 ("app/test: rename mbuf variable") Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz --- app/test/test

[dpdk-dev] [PATCH v6 2/5] mbuf: delinline rte_pktmbuf_linearize

2019-10-08 Thread Stephen Hemminger
This copy part of this function is too big to be put inline. The places it is used are only in special exception paths where a highly fragmented mbuf arrives at a device that can't handle it. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko Acked-by: Olivier Matz --- lib/librte_mbuf

[dpdk-dev] [PATCH v6 3/5] mbuf: deinline rte_pktmbuf_clone

2019-10-08 Thread Stephen Hemminger
Cloning mbufs requires allocations and iteration and therefore should not be an inline. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.c | 39 lib/librte_mbuf/rte_mbuf.h | 38 ++---

[dpdk-dev] [PATCH v6 0/5] mbuf: copy/cloning enhancements

2019-10-08 Thread Stephen Hemminger
This patch set is all about improving the mbuf related cloning and copying. They are motivated by seeing issues with mbuf copying in rte_pdump and realized this a wider and more general problem. The pdump copy could not handle different size pools and did not handle meta data, etc. They cause no f

Re: [dpdk-dev] [PATCH v2 05/10] crypto/aesni_mb: add rte_security handler

2019-10-08 Thread Ananyev, Konstantin
Hi Fan, > This patch add rte_security support support to AESNI-MB PMD. The PMD now > initialize security context instance, create/delete PMD specific security > sessions, and process crypto workloads in synchronous mode. > > Signed-off-by: Fan Zhang > --- > drivers/crypto/aesni_mb/meson.buil

Re: [dpdk-dev] [PATCH v2 01/14] ethdev: add support for hairpin queue

2019-10-08 Thread Andrew Rybchenko
Hi Ori, thanks for updated version. See my notes below. There are few style notes about line breaks which are not defined in coding style. Of course, it may be ignored. On 10/4/19 10:54 PM, Ori Kam wrote: This commit introduce hairpin queue type. The hairpin queue in build from Rx queue binde

[dpdk-dev] [PATCH] devtools: check coverity and bugzilla tags

2019-10-08 Thread David Marchand
Let's try to check for discrepancies in covery and bugzilla tags. The contributing guide specifies that: - for coverity issues, the tag is 'Coverity issue:' - for bugzilla issues, the tag is 'Bugzilla ID:' Signed-off-by: David Marchand --- devtools/check-git-log.sh | 18 ++ 1 fil

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-10-08 Thread Ferruh Yigit
On 10/8/2019 4:14 PM, Wangxiaoyun (Cloud, Network Chip Application Development Dept) wrote: > Hi Ferruh, > Thanks for your comments. hinic pmd driver doesn't support 32-bit build, > we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc". > and “defconfig_x86_x32-native-li

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-08 Thread Jerin Jacob
On Tue, 8 Oct, 2019, 8:42 PM Stephen Hemminger, wrote: > On Fri, 6 Sep 2019 14:42:30 +0530 > wrote: > > > From: Vamsi Attunuru > > > > The DPDK use case such as VF representer or OVS offload etc > > would call for PF and VF PCIe devices to bind vfio-pci > > module to enable IOMMU protection. >

Re: [dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

2019-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2019 11:03:34 +0200 Olivier Matz wrote: > > > > +/** > > + * Creates a full copy of a given packet mbuf. > > Although it's not consistent everywhere, I think the imperative > form is preferred ("Create" instead of "Creates"). > > > + * Copies all the data from a given packet m

Re: [dpdk-dev] [PATCH v3 18/19] net/hinic: optimize RX performance

2019-10-08 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. I think you're right, i will modify it with Patch V4. Also I change it with the same structure for X86-64 and ARM platform with cache-aligned, and test the RX performance, all is OK. Best Regards Xiaoyun Wang 在 2019/9/30 23:10, Ferruh Yigit 写道: On 9/3

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2019 09:36:49 +0100 Bruce Richardson wrote: > On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > > wrote: > > > > > This code was added 7+ years ago: > > > > > > commit fb022b85bae4 ("timer: check TSC reliabili

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-10-08 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. hinic pmd driver doesn't support 32-bit build, we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc". and “defconfig_x86_x32-native-linux-gcc”. I don't know why it also build in 32-bit platform, can you tell me where also need me to

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-08 Thread Stephen Hemminger
On Fri, 6 Sep 2019 14:42:30 +0530 wrote: > From: Vamsi Attunuru > > The DPDK use case such as VF representer or OVS offload etc > would call for PF and VF PCIe devices to bind vfio-pci > module to enable IOMMU protection. > > In addition to vSwitch use case, unlike, other PCI class of > device

Re: [dpdk-dev] [PATCH v3 0/3] QAT: handle Single Pass GCM

2019-10-08 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, October 8, 2019 1:45 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, ArkadiuszX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 0/3] QAT: handle Single Pass GCM > > This patch improves the performance of

Re: [dpdk-dev] [PATCH v2 14/14] doc: add hairpin feature

2019-10-08 Thread Andrew Rybchenko
On 10/4/19 10:54 PM, Ori Kam wrote: This commit adds the hairpin feature to the release notes. Signed-off-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_19_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b

Re: [dpdk-dev] [PATCH v9 1/7] ethdev: add set ptype function

2019-10-08 Thread Andrew Rybchenko
On 10/7/19 9:51 AM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add `rte_eth_dev_set_supported_ptypes` function that will allow the application to inform the PMD the packet types it is interested in. Based on the ptypes set PMDs can optimize their Rx path. -If application doesn’t wan

[dpdk-dev] [PATCH 3/3] drivers: process shared lib link dependencies as for libs

2019-10-08 Thread Bruce Richardson
For the public APIs of DPDK libraries we run checks for correct use of experimental tags, and also do dynamic generation of the version file to its window's equivalent. Although must drivers don't export APIs, some do, so these checks are relevant and should be copied from lib/meson.build to driver

[dpdk-dev] [PATCH 2/3] lib: add experimental symbols check to meson build

2019-10-08 Thread Bruce Richardson
Call check-experimental-syms.sh script as part of the meson build to ensure that all functions are correctly tagged. Signed-off-by: Bruce Richardson --- buildtools/meson.build | 2 ++ lib/meson.build| 12 +++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/buildt

[dpdk-dev] [PATCH 0/3] Add scanning for experimental symbols to meson

2019-10-08 Thread Bruce Richardson
The meson builds were missing support for scanning experimental symbols in the .o/.a files and matching that against those tagged as experimental in the version file. This set adds that missing support. Bruce Richardson (3): check-experimental-syms: remove use of environmental var lib: add exp

[dpdk-dev] [PATCH 1/3] check-experimental-syms: remove use of environmental var

2019-10-08 Thread Bruce Richardson
The check-experimental-syms.sh script was finding the map-list-symbol.sh script using $RTE_SDK, which is the variable set when using the "make" build system. To make this script more independent, we just use the current path of the script as the location to find its companion script. Signed-off-by

[dpdk-dev] [PATCH 0/3] Add scanning for experimental symbols to meson

2019-10-08 Thread Bruce Richardson
The meson builds were missing support for scanning experimental symbols in the .o/.a files and matching that against those tagged as experimental in the version file. This set adds that missing support. Bruce Richardson (3): check-experimental-syms: remove use of environmental var lib: add exp

Re: [dpdk-dev] [PATCH 2/2] net/bonding: fix selection logic

2019-10-08 Thread Yigit, Ferruh
On 8/5/2019 3:44 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Fix max_index to return uint16_t as it is valid slave_id type. > > Arrays agg_count and agg_bandwidth should be indexed by slave_id not by > aggregator port_id. The port_id type has been fixed already with another patch

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in selection logic

2019-10-08 Thread Yigit, Ferruh
On 8/5/2019 3:44 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Bonding selection logic uses agg_bandwidth, agg_count indexed by port_id > but those arrays are 8 entries long. > > Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") > Cc: danielx.t.mrzyg...@intel.com > > S

Re: [dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-10-08 Thread Yigit, Ferruh
On 7/30/2019 4:59 PM, Thomas Monjalon wrote: > Since the concept of representors was introduced, > we do not need any specific API for VF ports. > Any VF port should be able to be configured through > its representor port in a more generic fashion. I think we need a confirmation that functionality

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: add bits per second to statistics

2019-10-08 Thread Yigit, Ferruh
On 7/30/2019 12:41 PM, Moti Haimovsky wrote: >> -Original Message- >> From: dev On Behalf Of Matan Azrad >> Sent: Monday, July 29, 2019 3:37 PM >> To: Wenzhuo Lu ; Jingjing Wu >> >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 2/2] app/testpmd: add bits per second to >> statistics >> >>

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix scatter offload configuration

2019-10-08 Thread Yigit, Ferruh
On 7/31/2019 7:11 AM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> On 7/30/2019 7:34 PM, Matan Azrad wrote: >>> >>> >>> From: Ferruh Yigit On 7/30/2019 4:56 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> Sent: Tuesday, July 30, 2019 6:22 PM >> To

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: add NSH key field to flow API

2019-10-08 Thread Ferruh Yigit
On 9/30/2019 4:45 PM, Yigit, Ferruh wrote: > On 7/25/2019 10:03 AM, kirankum...@marvell.com wrote: >> From: Kiran Kumar K >> >> Add new rte_flow_item_nsh in order to match the network service header >> based on RFC 8300. >> >> Signed-off-by: Kiran Kumar K > > Hi Adrien, Ori, > > Any concern/obj

Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless

2019-10-08 Thread Trahe, Fiona
Hi Arek, Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, October 4, 2019 12:34 PM > To: Akhil Goyal ; Anoob Joseph ; > Kusztal, ArkadiuszX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Shally Verma > Subject: RE: [EXT] [PATCH v2] cryptodev: extend api

Re: [dpdk-dev] [PATCH v2 02/10] crypto/aesni_gcm: add rte_security handler

2019-10-08 Thread Ananyev, Konstantin
> > This patch add rte_security support support to AESNI-GCM PMD. The PMD now > initialize security context instance, create/delete PMD specific security > sessions, and process crypto workloads in synchronous mode with > scatter-gather list buffer supported. > > Signed-off-by: Fan Zhang > --

Re: [dpdk-dev] [PATCH v2 01/10] security: introduce CPU Crypto action type and API

2019-10-08 Thread Ananyev, Konstantin
Hi Fan, > > This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action type to > security library. The type represents performing crypto operation with CPU > cycles. The patch also includes a new API to process crypto operations in > bulk and the function pointers for PMDs. > > Signed-o

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-10-08 Thread Slava Ovsiienko
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 8, 2019 15:57 > To: Yongseok Koh ; Adrien Mazarguil > > Cc: Shahaf Shuler ; Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Olivier Matz > ; dev ; Slava Ovsiienko > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add f

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-10-08 Thread Slava Ovsiienko
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 8, 2019 15:51 > To: Adrien Mazarguil ; Andrew Rybchenko > > Cc: Yongseok Koh ; Thomas Monjalon > ; Olivier Matz ; Bruce > Richardson ; Shahaf Shuler > ; Ferruh Yigit ; dev > ; Slava Ovsiienko > Subject: Re: [dpdk-dev] [P

  1   2   >