On 9/16/2019 8:01 PM, Yong Wang wrote: > > From: Eduard Serra Miralles <ese...@vmware.com> > Date: Friday, September 13, 2019 at 1:10 PM > To: Yong Wang <yongw...@vmware.com> > Cc: "dev@dpdk.org" <dev@dpdk.org> > Subject: RE: [PATCH] net/vmxnet3: fix RSS setting on v4 > > > I think so too. Apparently however, ESX is mandatorily expecting that > underneath. If not set, config will fail. > > > > > > ________________________________ > From: Yong Wang <yongw...@vmware.com> > Sent: Friday, September 13, 2019 11:44:38 AM > To: Eduard Serra Miralles <ese...@vmware.com> > Cc: dev@dpdk.org <dev@dpdk.org> > Subject: Re: [PATCH] net/vmxnet3: fix RSS setting on v4 > > -----Original Message----- > From: Eduard Serra Miralles <ese...@vmware.com> > Date: Wednesday, August 21, 2019 at 9:37 AM > To: Yong Wang <yongw...@vmware.com> > Cc: "dev@dpdk.org" <dev@dpdk.org> > Subject: [PATCH] net/vmxnet3: fix RSS setting on v4 > > When calling to setup RSS on v4 API, ESX will expect > IPv4/6 TCP RSS to be set/requested mandatorily. > > This patch will: > - Set IPv4/6 TCP RSS when these have not been set. A warning > message is thrown to make sure we warn the application we are > setting IPv4/6 TCP RSS when not set. > > Why we are enforcing TCP RSS? I would think it's up to the user to decide > what to request based on their specific needs and we should support RSS even > when it does not request TCP RSS. > > - An additional check has been added to dodge RSS configuration > altogether unless MQ_RSS has been requested, similar to v3. > > The alternative (returning error) was considered, the intent > is to ease the task of setting up and running vmxnet3 in situations > where it's supposted to be most strightforward (testpmd, pktgen). > > Signed-off-by: Eduard Serra <ese...@vmware.com> > --- > Acked-by: Yong Wang <yongw...@vmware.com>
Sorry I missed your ack here, since it was not quoted patchwork also missed it. Eduard, Can you please provide a Fixes tag, that will be useful to backport fix to the stable trees? Thanks, ferruh
