Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix address of first segment

2019-09-23 Thread Zhang, Xiao
> -Original Message- > From: Joyce Kong [mailto:joyce.k...@arm.com] > Sent: Tuesday, September 24, 2019 1:49 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; jer...@marvell.com; Zhang, Xiao > ; gavin...@arm.com; honnappa.nagaraha...@arm.com; > sta...@dpdk.org > Subject: [PA

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix address of first segment

2019-09-23 Thread Zhang, Xiao
> -Original Message- > From: Joyce Kong [mailto:joyce.k...@arm.com] > Sent: Tuesday, September 24, 2019 1:49 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; jer...@marvell.com; Zhang, Xiao > ; gavin...@arm.com; honnappa.nagaraha...@arm.com; > sta...@dpdk.org > Subject: [PA

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Andrzej Ostruszka
On 9/23/19 6:13 PM, Bruce Richardson wrote: [...] > However, testing on my system with the meson build, I'm getting lots of > link errors [See below]. Any suggestions? > > /Bruce > > /usr/bin/ld: /tmp/dpdk-testpmd.hncbtE.ltrans93.ltrans.o: in function > `ena_stop': > :(.text+0x9ed6): undefined r

[dpdk-dev] [PATCH v8] net/i40e: limit the number of VF messages

2019-09-23 Thread alvinx . zhang
From: Alvin Zhang PF driver supports counting VF adminQ messages. If any VF driver sends much more adminQ messages to its PF driver in a period of time, it will trigger the PF's message limitation, then in the next certain amount of seconds the PF driver will ignore any new adminQ message from th

[dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment

2019-09-23 Thread Joyce Kong
The series fix (dereference after null check) coverity issue on NEON vPMD. Which for x86 sse/avx2 (commit 4916f63985ddb56af43980252d1134d051523685, commit 739c35f08bc0296ffda47f006f1903a67527063f) have been merged. Joyce Kong (2): net/i40e: fix address of first segment net/ixgbe: fix address o

[dpdk-dev] [PATCH 1/2] net/i40e: fix address of first segment

2019-09-23 Thread Joyce Kong
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343422, 343403 Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver") Cc: s

[dpdk-dev] [PATCH 2/2] net/ixgbe: fix address of first segment

2019-09-23 Thread Joyce Kong
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 13245 Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector driver") Cc: sta...@dp

[dpdk-dev] [PATCH v3] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Wang ShougangX
This patch fixed the reset function to avoid crash when user don't call port stop, port reset functions as sequence. Fixes: 97f1e19679 ("app/testpmd: add port reset command") Cc: sta...@dpdk.org Signed-off-by: Wang ShougangX --- app/test-pmd/cmdline.c | 3 +++ app/test-pmd/

Re: [dpdk-dev] [PATCH v2 0/2] add symmetric toeplitz hash support

2019-09-23 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Friday, July 26, 2019 8:55 AM > To: Zhang, Qi Z ; Wu, Jingjing > ; adrien.mazarg...@6wind.com > Cc: dev@dpdk.org; Su, Simei > Subject: [PATCH v2 0/2] add symmetric toeplitz hash support > > From: Simei Su > > This v2 patch rebase to 19.0

Re: [dpdk-dev] [PATCH v2 0/2] extend RSS offload types

2019-09-23 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, September 23, 2019 10:06 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Ye, Xiaolong > Cc: dev@dpdk.org; Su, Simei > Subject: [PATCH v2 0/2] extend RSS offload types > > [PATCH v2 1/2] ethdev: add several bits for extending rss offload t

Re: [dpdk-dev] [PATCH] vhost: translate incoming log address to gpa

2019-09-23 Thread Tiwei Bie
On Mon, Sep 23, 2019 at 12:28:35PM +0200, Adrian Moreno wrote: > On 9/23/19 9:25 AM, Tiwei Bie wrote: > > On Tue, Sep 17, 2019 at 04:49:00PM +0200, Adrian Moreno wrote: > >> When IOMMU is enabled the incoming log address is in IOVA space. In that > >> case, look in IOTLB table and translate the res

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add RSS offload types extending support

2019-09-23 Thread Simei Su
This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su --- app/test-pmd/config.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1a5a5c1..b95bd43 100644 --- a/app/test-pmd/config.c +++ b/app/test

[dpdk-dev] [PATCH v2 1/2] ethdev: extend RSS offload types

2019-09-23 Thread Simei Su
This patch cover two aspects: (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve different purposes. (2)reserve several bits as input set selection from bottom of the 64 bits. It is combined with exisiting ETH_RSS_* to represent rss types. for example: ETH_RSS_I

[dpdk-dev] [PATCH v2 0/2] extend RSS offload types

2019-09-23 Thread Simei Su
[PATCH v2 1/2] ethdev: add several bits for extending rss offload types. [PATCH v2 2/2] app/testpmd: add cmdline support for extending rss types. v2: - revise annotation. Simei Su (2): ethdev: extend RSS offload types app/testpmd: add RSS offload types extending support app/test-pmd/config.

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-23 Thread Liu, Yong
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, September 23, 2019 11:22 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Bie, Tiwei ; Wang, > Zhihong ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/virtio: fix mbuf data and

Re: [dpdk-dev] [PATCH v2 03/16] vhost: add burst enqueue function for packed ring

2019-09-23 Thread Liu, Yong
Thanks, Gavin. My comments are inline. > -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Monday, September 23, 2019 7:09 PM > To: Liu, Yong ; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong > Cc: dev@dpdk.org; nd > Subject: RE: [dpdk-

Re: [dpdk-dev] [PATCH v2 02/16] vhost: unify unroll pragma parameter

2019-09-23 Thread Liu, Yong
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Monday, September 23, 2019 6:09 PM > To: Liu, Yong ; maxime.coque...@redhat.com; Bie, Tiwei > ; Wang, Zhihong ; Richardson, > Bruce > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 02/16] v

[dpdk-dev] [PATCH v5 6/6] net/ice: remove Rx legacy descriptor definition

2019-09-23 Thread Leyi Rong
From: Haiyue Wang Since now the ice PMD only handles Rx Flex descriptor, so remove the legacy descriptor definition. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_rxtx.c | 25 - drivers/net/ice/ice_rxtx.h | 4 +--- drivers/net/ice/ice_rxtx_vec_av

[dpdk-dev] [PATCH v5 5/6] net/ice: switch to Rx flexible descriptor in AVX path

2019-09-23 Thread Leyi Rong
Switch to Rx flexible descriptor format instead of legacy descriptor format. Signed-off-by: Leyi Rong --- drivers/net/ice/ice_rxtx_vec_avx2.c | 224 ++-- 1 file changed, 109 insertions(+), 115 deletions(-) diff --git a/drivers/net/ice/ice_rxtx_vec_avx2.c b/drivers/net/i

[dpdk-dev] [PATCH v5 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-23 Thread Leyi Rong
From: Haiyue Wang The ice has the feature to extract protocol fields into flex descriptor by programming per queue. Currently, the ice PMD will put the protocol fields into rte_mbuf::udata64 with different type format. Application can access the protocol fields quickly. Signed-off-by: Haiyue Wan

[dpdk-dev] [PATCH v5 2/6] net/ice: handle the Rx flex descriptor

2019-09-23 Thread Leyi Rong
From: Haiyue Wang Set the RXDID with flex descriptor type by default, change the Rx function to support new descriptor handling. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_rxtx.c | 236 + 1 file changed, 111 insertions(+), 125 deletions(-) diff --gi

[dpdk-dev] [PATCH v5 4/6] net/ice: switch to flexible descriptor in SSE path

2019-09-23 Thread Leyi Rong
From: Wenzhuo Lu With this path, the flexible descriptor is supported in SSE path. And the legacy descriptor is not supported. Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx_vec_sse.c | 239 + 1 file changed, 110 insertions(+), 129 deletions(-) diff --git a

[dpdk-dev] [PATCH v5 1/6] net/ice: add Rx flex descriptor definition

2019-09-23 Thread Leyi Rong
From: Haiyue Wang The Rx flex descriptor has 16B and 32B size, with different field definitions compared to legacy type. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_rxtx.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h index

[dpdk-dev] [PATCH v5 0/6] enable Rx flexible descriptor

2019-09-23 Thread Leyi Rong
This patchset enable Rx flexible descriptor for ice PMD in both normal path and vector path. Depends on shared code update patchset. --- v5: - Fix some typo, and enhance the array index access handling. - Move update for release note to `New Features` section. v4: - Handle the ‘proto_xtr’ with er

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Wang, ShougangX
Hi Regards, Ferruh > -Original Message- > From: Iremonger, Bernard > Sent: Monday, September 23, 2019 10:18 PM > To: Yigit, Ferruh ; Wang, ShougangX > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segmen

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Wang, ShougangX
Hi Bernard > The app/test-pmd/cmdline.c file should be updated at line 760 to add help > text > for the "port reset (port_id|all)\n" command. Thank you very much, I will add in next patch. Thanks. Shougang > -Original Message- > From: Iremonger, Bernard > Sent: Monday, September 23, 2

Re: [dpdk-dev] [PATCH v7] net/i40e: limit the number of VF messages

2019-09-23 Thread Ye Xiaolong
On 09/20, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >PF driver supportes counting VF adminQ messages. If any VF driver s/supportes/supports/ >sending much more adminQ messages to it's PF driver in a period of s/sending/sends s/it's/its >time, it will trigger the PF's message limiting,

Re: [dpdk-dev] [PATCH v4 0/2] add GTP/PPPoE to flow API

2019-09-23 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Ying A > Sent: Wednesday, August 28, 2019 2:01 PM > To: Zhang, Qi Z ; Yigit, Ferruh > Cc: dev@dpdk.org; adrien.mazarg...@6wind.com; Ye, Xiaolong > ; Yang, Qiming ; Wang, > Ying A > Subject: [PATCH v4 0/2] add GTP/PPPoE to flow API > > patch 1/2: Add

Re: [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa

2019-09-23 Thread Harris, James R
On 9/23/19, 8:41 AM, "Yigit, Ferruh" wrote: On 9/18/2019 2:12 PM, Maxime Coquelin wrote: > > > On 8/20/19 11:37 AM, Jim Harris wrote: >> This function is listed under EXPERIMENTAL in the >> rte_vhost_version.map, so it needs to be marked >> with __rte_experimental

Re: [dpdk-dev] [PATCH 0/2] add symmetric toeplitz hash support

2019-09-23 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, July 25, 2019 12:57 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; adrien.mazarg...@6wind.com > Cc: dev@dpdk.org; Su, Simei > Subject: [PATCH 0/2] add symmetric toeplitz hash support > > From: Simei Su > > [PATCH 1/2] ethdev: add new

Re: [dpdk-dev] [PATCH v5 00/30] net/ice/base: share code update secend batch.

2019-09-23 Thread Ye Xiaolong
On 09/23, Yang, Qiming wrote: > >> -Original Message- >> From: Zhang, Qi Z >> Sent: Monday, September 23, 2019 3:44 PM >> To: Lu, Wenzhuo ; Yang, Qiming >> >> Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z >> >> Subject: [PATCH v5 00/30] net/ice/base: share code update secend batch. >> >>

[dpdk-dev] [PATCH 7/7] net/ice: reject duplicate flow for FDIR

2019-09-23 Thread Yahui Cao
Enable duplication lookup for existing flow director rule entry. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 17 +++ drivers/net/ice/ice_fdir_filter.c | 186 -- 2 files changed, 196 insertions(+), 7 deletions(-) diff --git a/drivers/net/ice/ice_

[dpdk-dev] [PATCH 6/7] net/ice: add FDIR counter support for flow id

2019-09-23 Thread Yahui Cao
FDIR statistical counter support hits by default. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 7 ++ drivers/net/ice/ice_fdir_filter.c | 179 +- 2 files changed, 185 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.h b/driver

[dpdk-dev] [PATCH 5/7] net/ice: add FDIR counter resource init/release

2019-09-23 Thread Yahui Cao
The patch integrates the counter resource init/release into fdir's init/release scenario Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 33 +++ drivers/net/ice/ice_fdir_filter.c | 97 ++- 2 files changed, 129 insertions(+), 1 deletion(-) dif

[dpdk-dev] [PATCH 4/7] net/ice: enable FDIR queue group

2019-09-23 Thread Yahui Cao
FDIR can send packet to a group of queues and distruibte it by RSS. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index f55

[dpdk-dev] [PATCH 3/7] net/ice: add FDIR create and destroy

2019-09-23 Thread Yahui Cao
Add ice_create_fdir_filter to create a rule. If a flow is matched by flow director filter, filter rule will be set to HW. For now common pattern and queue/passthru/drop/mark actions are supported. Signed-off-by: Yahui Cao --- doc/guides/rel_notes/release_19_11.rst | 1 + drivers/net/ice/ice_et

[dpdk-dev] [PATCH 2/7] net/ice: configure HW FDIR rule

2019-09-23 Thread Yahui Cao
From: Beilei Xing This patch adds a HW FDIR rule to the FDIR HW table without adding a FDIR filter. Change-Id: Iaed0ee1953815559ac4a25da1402c6f9775e78c0 Signed-off-by: Beilei Xing --- drivers/net/ice/ice_fdir_filter.c | 239 ++ 1 file changed, 239 insertions(+) dif

[dpdk-dev] [PATCH 1/7] net/ice: enable flow director engine

2019-09-23 Thread Yahui Cao
From: Beilei Xing Enable flow director engine, including initialization and teardown. - Control VSI create and release. - Queue pair allocated, set up and release. - Programming packet create and release. - FDIR profile create and release. Signed-off-by: Beilei Xing --- drivers/net/ice/Mak

[dpdk-dev] [PATCH 0/7] net/ice: add ice Flow Director driver

2019-09-23 Thread Yahui Cao
This patch series adds Flow Director support for Intel Ethernet Controller E810 series using RTE_FLOW - Patch 01-02 are FDIR init,teardown and configuration - Remaining patches are FDIR RTE_FLOW enablement The patchset depends on: http://patchwork.dpdk.org/project/dpdk/list/?series=6420 --- v2: *

Re: [dpdk-dev] dpdk : windows build issue

2019-09-23 Thread Pallavi Kadam
Hi Srinivas On 9/17/2019 2:34 AM, Revanur Srinivasa Kumar (RBEI/ETA) wrote: Hi, We are evaluating dpdk on windows10 64 bit desktop version ( linux runs fine ). Build system is setup on PC, but I see that dpdk is supported on windows server 2016/2019 only. Can we run dpdk on windows 10 ? Bes

[dpdk-dev] [RFC] Proposals and notes from ABI stability panel @ DPDK Userspace

2019-09-23 Thread Ray Kinsella
Folks, As you may be aware, there was a panel on ABI Stability @ DPDK Userspace. There where a number of proposed amendments to the ABI stability proposal made, as well as a number of points and comments, you will find all these below. The proposals needs further discussion so please chime in bel

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
> On Sep 23, 2019, at 11:16 AM, Olivier Matz wrote: > > Hi, > > (reformated the quotes) > > On Mon, Sep 23, 2019 at 03:14:51PM +, Wiles, Keith wrote: >> >> >> On Sep 23, 2019, at 4:13 AM, Olivier Matz >> mailto:olivier.m...@6wind.com>> wrote: >>> >>> Hi Keith, >>> >>> On Sat, Sep 21,

Re: [dpdk-dev] [PATCH v3 3/3] examples/ipsec-secgw: add offload fallback tests

2019-09-23 Thread Ananyev, Konstantin
> Add tests for offload fallback feature; add inbound config modificator > SGW_CFG_XPRM_IN (offload fallback setting can be set only for inbound > SAs). Tests are using cryptodev for outbound SA. > > To test fragmentation with QAT set: > MULTI_SEG_TEST="--reassemble=4096 --cryptodev_mask=0x

Re: [dpdk-dev] [PATCH v3 2/3] examples/ipsec-secgw: add fallback session feature

2019-09-23 Thread Ananyev, Konstantin
> > Inline processing is limited to a specified subset of traffic. It is > often unable to handle more complicated situations, such as fragmented > traffic. When using inline processing such traffic is dropped. > > Introduce fallback session for inline processing allowing processing > packets

Re: [dpdk-dev] [PATCH v3 1/3] examples/ipsec-secgw: ipsec_sa structure cleanup

2019-09-23 Thread Ananyev, Konstantin
> -Original Message- > From: Smoczynski, MarcinX > Sent: Monday, September 23, 2019 12:44 PM > To: ano...@marvell.com; akhil.go...@nxp.com; Ananyev, Konstantin > > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v3 1/3] examples/ipsec-secgw: ipsec_sa structure cleanup > > Cle

Re: [dpdk-dev] RFC: hiding struct rte_eth_dev

2019-09-23 Thread Bruce Richardson
On Mon, Sep 23, 2019 at 05:19:27PM +0100, Ray Kinsella wrote: > Hi folks, > > The ABI Stability proposals should be pretty well known at this point. > The latest rev is here ... > > http://inbox.dpdk.org/dev/1565864619-17206-1-git-send-email-...@ashroe.eu/ > > As has been discussed public data s

Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

2019-09-23 Thread Ferruh Yigit
On 9/19/2019 10:11 PM, Rasesh Mody wrote: > Hi, > > Currently, BNX2X PMD uses a very old firmware 7.2.51. > This patch series updated the base driver to use to latest > firmware 7.13.11. The latest firmware comprises of enhancements > and fixes. > > v2: > - Squashed pmd version patch into "net/b

[dpdk-dev] RFC: hiding struct rte_eth_dev

2019-09-23 Thread Ray Kinsella
Hi folks, The ABI Stability proposals should be pretty well known at this point. The latest rev is here ... http://inbox.dpdk.org/dev/1565864619-17206-1-git-send-email-...@ashroe.eu/ As has been discussed public data structure's are risky for ABI stability, as any changes to a data structure can

Re: [dpdk-dev] 18.11.3 (LTS) patches review and test

2019-09-23 Thread Kevin Traynor
On 19/09/2019 23:44, Abhishek Marathe wrote: > Hi All, > Hi Abhishek, thanks for testing, some comments below. > While testing 18.11.3-rc1 on Azure we faced following problems: > > 1. VERIFY-DPDK-OVS - This test case builds OVS (OpenVSwitch) with DPDK > support on Ubuntu distro (16.04 and 18.

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Olivier Matz
Hi, (reformated the quotes) On Mon, Sep 23, 2019 at 03:14:51PM +, Wiles, Keith wrote: > > > On Sep 23, 2019, at 4:13 AM, Olivier Matz > mailto:olivier.m...@6wind.com>> wrote: > > > > Hi Keith, > > > > On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: > > > > > > > > > On Se

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Bruce Richardson
On Mon, Sep 23, 2019 at 03:02:25PM +0200, Andrzej Ostruszka wrote: > On 9/23/19 2:06 PM, Bruce Richardson wrote: > > On Mon, Sep 23, 2019 at 02:03:35PM +0200, Andrzej Ostruszka wrote: > [...] > >> So it is similar ~5x increase as Mattias has reported. Have not > >> measured it, but the lion share

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
Sorry, resend in plain text :-( > On Sep 23, 2019, at 4:13 AM, Olivier Matz wrote: > > Hi Keith, > > On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: >> >> >>> On Sep 18, 2019, at 6:54 PM, Olivier Matz wrote: >>> >>> Many features require to store data inside the mbuf. As the r

Re: [dpdk-dev] [PATCH v1 01/14] vhost: add single packet enqueue function

2019-09-23 Thread Stephen Hemminger
This code could be more concise. > +/* > + * Returns -1 on fail, 0 on success > + */ That is standard convention, and probably doesn't need a comment. > +static inline int > +vhost_enqueue_single_packed(struct virtio_net *dev, struct vhost_virtqueue > *vq, > + struct rte_mbuf *pkt, struct b

Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-23 Thread Ye Xiaolong
On 09/23, Wang, Haiyue wrote: >> >+{ >> >+ static uint8_t rxdid_map[] = { >Add this line: > [PROTO_XTR_NONE] = ICE_RXDID_COMMS_GENERIC, This makes sense. >> >+ [PROTO_XTR_VLAN] = ICE_RXDID_COMMS_AUX_VLAN, >> >+ [PROTO_XTR_IPV4] = ICE_RXDID_COMMS

Re: [dpdk-dev] [PATCH v3 0/3] compress/qat: add stateful decompression

2019-09-23 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Friday, September 20, 2019 9:06 PM > To: dev@dpdk.org; Trahe, Fiona ; Trybula, ArturX > ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v3 0/3] compress/qat: add stateful decompression > > This patchset adds the state

Re: [dpdk-dev] [PATCH v4 0/4] add unit tests for eal vfio library

2019-09-23 Thread Burakov, Anatoly
On 04-Sep-19 1:04 PM, Chaitanya Babu Talluri wrote: 1/4: fix vfio unmap that fails unexpectedly 2/4: fix vfio unmap that succeeds unexpectedly 3/4: add API to check iommu type is set 4/4: add unit tests for eal vfio Patch 4/4 depends on 1/4,2/4,3/4 Signed-off-by: Chaitanya Babu Talluri --- A

Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug

2019-09-23 Thread Jerin Jacob
On Mon, Sep 23, 2019 at 7:47 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Friday, September 13, 2019 11:30 AM > > To: Eads, Gage > > Cc: dev@dpdk.org; Richardson, Bruce ; Van > > Haaren, > > Harry ; sta...@dpdk.org >

Re: [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa

2019-09-23 Thread Ferruh Yigit
On 9/18/2019 2:12 PM, Maxime Coquelin wrote: > > > On 8/20/19 11:37 AM, Jim Harris wrote: >> This function is listed under EXPERIMENTAL in the >> rte_vhost_version.map, so it needs to be marked >> with __rte_experimental in the header file as well. >> >> Found by check-experimental-syms.sh when t

Re: [dpdk-dev] [PATCH] net/virtio: fix mbuf data and pkt length mismatch

2019-09-23 Thread Stephen Hemminger
On Mon, 23 Sep 2019 22:05:11 +0800 Marvin Liu wrote: > If reserve virtio header room by function rte_pktmbuf_prepend, both > segment data length and packet length of mbuf will be increased. > Data length will be equal to descriptor length, while packet length > should be decreased as virtio-net h

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
On Sep 23, 2019, at 4:13 AM, Olivier Matz mailto:olivier.m...@6wind.com>> wrote: Hi Keith, On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: On Sep 18, 2019, at 6:54 PM, Olivier Matz mailto:olivier.m...@6wind.com>> wrote: Many features require to store data inside the mbuf. As

Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-23 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, September 23, 2019 22:24 > To: Rong, Leyi > Cc: Wang, Haiyue ; Lu, Wenzhuo ; > Zhang, Qi Z > ; dev@dpdk.org > Subject: Re: [PATCH v4 3/6] net/ice: add protocol extraction support for per > Rx queue > > On 09/19, Leyi Rong wrote:

[dpdk-dev] [PATCH v2 2/2] net/enic: add flow implementation based on Flow Manager API

2019-09-23 Thread Hyong Youb Kim
Flow Manager API is the new firmware interface that exposes match action capabilities in 1400 series VIC adapters. It is intended for virtual switch offloads and enables more advanced features than the existing filter API. For example, it supports VXLAN encap and decap actions, and exposes TCAM and

[dpdk-dev] [PATCH v2 1/2] net/enic: enable Geneve with options offload

2019-09-23 Thread Hyong Youb Kim
Latest firmware supports Geneve with options offload. Current overlay offload only supports Geneve with no options. This new feature is disabled by default, as it is intrusive and cannot be used with flow API. Add a new devarg 'geneve-opt' so the user can explicitly enable it. Signed-off-by: Hyong

[dpdk-dev] [PATCH v2 0/2] net/enic: a couple new features

2019-09-23 Thread Hyong Youb Kim
The first patch enables Geneve offload that supports Geneve header options. Previous Geneve offload does not work when options are present. The second patch adds the new flow implementation based on Flow Manager. So the driver now has two implementations: one based on the old filter API, and this

Re: [dpdk-dev] [PATCH v2 1/1] net/tap: fix blocked rx packets error

2019-09-23 Thread Wiles, Keith
> On Sep 23, 2019, at 8:22 AM, Smoczynski, MarcinX > wrote: > > When OS sends more packets than are being read with a single > 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd > and are unable to receive, because trigger_seen is getting updated > and consecutive calls ar

Re: [dpdk-dev] [PATCH v4 6/6] net/ice: remove Rx legacy descriptor definition

2019-09-23 Thread Ye Xiaolong
On 09/19, Leyi Rong wrote: >From: Haiyue Wang > >Since now the ice PMD only handles Rx Flex descriptor, so remove the >legacy descriptor definition. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_rxtx.c | 25 - > drivers/net/ice/ice_rxtx.h | 4 +

Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-23 Thread Ye Xiaolong
On 09/19, Leyi Rong wrote: >From: Haiyue Wang > [snip] >+static inline uint8_t >+ice_rxdid_to_proto_xtr_type(uint8_t rxdid) >+{ >+ static uint8_t xtr_map[] = { >+ [ICE_RXDID_COMMS_AUX_VLAN] = PROTO_XTR_VLAN, >+ [ICE_RXDID_COMMS_AUX_IPV4] = PROTO_XTR_IPV4

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Iremonger, Bernard
Hi ShougangX, Ferruh, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Monday, September 23, 2019 12:04 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATC

Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug

2019-09-23 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Friday, September 13, 2019 11:30 AM > To: Eads, Gage > Cc: dev@dpdk.org; Richardson, Bruce ; Van Haaren, > Harry ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment >

[dpdk-dev] [PATCH v2 1/1] net/tap: fix blocked rx packets error

2019-09-23 Thread Marcin Smoczynski
When OS sends more packets than are being read with a single 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd and are unable to receive, because trigger_seen is getting updated and consecutive calls are not getting any packets. Do not update trigger_seen unless less than a ma

[dpdk-dev] [PATCH v2 0/1] net/tap: fix blocked rx packets error

2019-09-23 Thread Marcin Smoczynski
When OS sends more packets than are being read with a single 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd and are unable to receive, because trigger_seen is getting updated and consecutive calls are not getting any packets. Do not update trigger_seen unless less than a ma

[dpdk-dev] [PATCH v3 3/3] test/compress: add stateful decompression tests

2019-09-23 Thread Adam Dybkowski
This patch adds two new tests that cover the stateful decompression feature. Signed-off-by: Adam Dybkowski --- app/test/test_compressdev.c | 449 +++- 1 file changed, 394 insertions(+), 55 deletions(-) diff --git a/app/test/test_compressdev.c b/app/test/test_comp

[dpdk-dev] [PATCH v3 2/3] compress/qat: add stateful decompression

2019-09-23 Thread Adam Dybkowski
This patch adds the stateful decompression feature to the DPDK QAT PMD. Signed-off-by: Adam Dybkowski --- doc/guides/compressdevs/features/default.ini | 37 +-- doc/guides/compressdevs/features/qat.ini | 21 +- doc/guides/compressdevs/qat_comp.rst | 5 + doc/guides/rel_notes/rele

[dpdk-dev] [PATCH v3 1/3] common/qat: add QAT RAM bank definitions

2019-09-23 Thread Adam Dybkowski
This patch adds QAT RAM bank definitions and related macros. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 73 1 file changed, 73 insertions(+) diff --git a/drivers/common/qat/qat_adf/icp_qat_fw_comp.h b/drivers/common/qat/qat_adf/icp_qat

[dpdk-dev] [PATCH v3 0/3] compress/qat: add stateful decompression

2019-09-23 Thread Adam Dybkowski
This patchset adds the stateful decompression feature to the QAT PMD, together with the documentation updates and two new unit tests. --- v3: * Minor corrections in features list in the documentation. v2: * Typo correction in the error message. Adam Dybkowski (3): common/qat: add QAT RAM bank d

Re: [dpdk-dev] [PATCH v2 00/15] sched: subport level configuration of pipe nodes

2019-09-23 Thread Dumitrescu, Cristian
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Monday, September 9, 2019 11:05 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2 00/15] sched: subport level configuration of pipe nodes > > This patchset refactors the dpdk qos sched library to allo

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Andrzej Ostruszka
On 9/23/19 2:06 PM, Bruce Richardson wrote: > On Mon, Sep 23, 2019 at 02:03:35PM +0200, Andrzej Ostruszka wrote: [...] >> So it is similar ~5x increase as Mattias has reported. Have not >> measured it, but the lion share of that increase is due to linking of >> 'test' apps. >> > > Interesting. Do

Re: [dpdk-dev] [PATCH v3 0/3] add fallback session

2019-09-23 Thread Smoczynski, MarcinX
Joseph, is this patchset ok with you after changes? I've changed second patch description and sample application documentation regarding this feature. > -Original Message- > From: Smoczynski, MarcinX > Sent: Monday, September 23, 2019 1:44 PM > To: ano...@marvell.com; akhil.go...@nxp.com;

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Ray Kinsella
> If "in or out" means "either accept the patches with LTO on and no > config option or reject them" then I disagree. Even if run time > improvements are questionable I find the additional link time warnings > beneficial and would like to have an easy way to turn them on when doing > final touch

[dpdk-dev] [PATCH v2] doc: add code coverage report generation guide

2019-09-23 Thread Marcin Zapolski
Add unit tests and code coverage reports generation guides to Meson build documentation. Signed-off-by: Marcin Zapolski --- v2: fix trailing whitespaces --- doc/build-sdk-meson.txt | 40 1 file changed, 40 insertions(+) diff --git a/doc/build-sdk-meson.t

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Bruce Richardson
On Mon, Sep 23, 2019 at 02:03:35PM +0200, Andrzej Ostruszka wrote: > On 9/23/19 9:23 AM, Thomas Monjalon wrote: > [...] > > Please can we get some numbers to understand how longer it is? > > Below numbers are for make based (make -j8) clean build on my system: > > non-LTO > real: 144.56s, user:45

Re: [dpdk-dev] [PATCH] app/testpmd: support multiple raw encap/decap

2019-09-23 Thread Jack Min
Hey, Anyone has any comments on this patch? -Jack On Mon, 19-09-16, 17:21, Xiaoyu Min wrote: > In some scenarios, the raw_encap/raw_decap actions could be multiple in > one single flow (e,g. hirepin flow): > > ... actions raw_decap / raw_encap / raw_decap / raw_encap / ... > > This requires

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Andrzej Ostruszka
On 9/23/19 9:23 AM, Thomas Monjalon wrote: [...] > Please can we get some numbers to understand how longer it is? Below numbers are for make based (make -j8) clean build on my system: non-LTO real: 144.56s, user:451.81s, sys:48.46s, CPU:346% LTO real: 607.20s, user:2141.71s, sys:88.36s, CPU:367%

[dpdk-dev] [PATCH v1 1/1] bus/pci: probe PCI devices in whitelisted order

2019-09-23 Thread vattunuru
From: Vamsi Attunuru Current pci bus driver scans pci devices in the order that it read from sysfs. Accordingly all or whitelisted devices are getting probed. Patch modifies the probing order of whitelisted pci devices in a sequence the devices are whitelisted(using EAL flags). It ensures the e

[dpdk-dev] [PATCH v3 0/3] add fallback session

2019-09-23 Thread Marcin Smoczynski
Add fallback session feature allowing to process packets that inline processor is unable to handle (e.g. fragmented traffic). Processing takes place in a secondary session defined for SA in a configuration file. This feature is limited to ingress IPsec traffic only. IPsec anti-replay window and ES

[dpdk-dev] [PATCH v3 2/3] examples/ipsec-secgw: add fallback session feature

2019-09-23 Thread Marcin Smoczynski
Inline processing is limited to a specified subset of traffic. It is often unable to handle more complicated situations, such as fragmented traffic. When using inline processing such traffic is dropped. Introduce fallback session for inline processing allowing processing packets that normally woul

[dpdk-dev] [PATCH v3 1/3] examples/ipsec-secgw: ipsec_sa structure cleanup

2019-09-23 Thread Marcin Smoczynski
Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to direct references to matching fields of rte_ipsec_session

[dpdk-dev] [PATCH v3 3/3] examples/ipsec-secgw: add offload fallback tests

2019-09-23 Thread Marcin Smoczynski
Add tests for offload fallback feature; add inbound config modificator SGW_CFG_XPRM_IN (offload fallback setting can be set only for inbound SAs). Tests are using cryptodev for outbound SA. To test fragmentation with QAT set: MULTI_SEG_TEST="--reassemble=4096 --cryptodev_mask=0x" Signed-off-b

Re: [dpdk-dev] [PATCH v2] test: fix process dup fd close

2019-09-23 Thread Krzysztof Kanas
Ping.. On 19-09-02 11:49, kka...@marvell.com wrote: > From: Krzysztof Kanas > > process_dup was intending to close it's own fd's but failed to do so > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Krzysztof Kanas > --- > v2: > * remove unnecessary commit msg information >

Re: [dpdk-dev] [PATCH v2 03/16] vhost: add burst enqueue function for packed ring

2019-09-23 Thread Gavin Hu (Arm Technology China)
Hi Marvin, Is it possible to vectorize the processing? Other comments inline: /Gavin > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: Friday, September 20, 2019 12:37 AM > To: maxime.coque...@redhat.com; tiwei@intel.com; > zhihong.w...@intel.com > Cc: dev@dpdk.org; Ma

Re: [dpdk-dev] [PATCH v4 2/6] net/ice: handle the Rx flex descriptor

2019-09-23 Thread Ye Xiaolong
On 09/19, Leyi Rong wrote: >From: Haiyue Wang > >Set the RXDID with flex descriptor type by default, change the Rx >function to support new descriptor handling. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_rxtx.c | 236 + > 1 file changed, 111 insert

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Ferruh Yigit
On 9/17/2019 10:22 AM, Wang, ShougangX wrote: >> Let's assume port already stopped before calling the reset, reset will cause >> port >> to be started. > > Indeed, automatically start looks strange in this case. User explicitly do > the > "port start" command should be better. > >> I am for us

Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction support for per Rx queue

2019-09-23 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, September 23, 2019 16:30 > To: Yang, Qiming > Cc: Rong, Leyi ; Wang, Haiyue ; > Lu, Wenzhuo > ; Zhang, Qi Z ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 3/6] net/ice: add protocol extraction > support for per Rx queue > > O

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wang, Haiyue
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, September 23, 2019 16:32 > To: Wang, Haiyue > Cc: dev@dpdk.org; Thomas Monjalon ; Stephen Hemminger > ; Andrew Rybchenko ; > Wiles, Keith > ; Jerin Jacob Kollanukkaran > Subject: Re: [PATCH] mbuf: s

Re: [dpdk-dev] [RFC] Proposal to remove EXPERIMENTAL label from compressdev API

2019-09-23 Thread Trahe, Fiona
Hi all, Taking into account - some discussions I had in Bordeaux - how difficult it will be to API/ABI breakage in non-experimental APIs future - the proposed ARM compression PMD for LZ4 - which may discover a need for API change - the absence of anyone cry

Re: [dpdk-dev] [PATCH 1/5] net/bnx2x: update and reorganize HW registers

2019-09-23 Thread Jerin Jacob
On Fri, Sep 6, 2019 at 12:57 PM Rasesh Mody wrote: > > Update and reorganize HW registers in preparation to update the firmware > to version 7.13.11. > Move HW_INTERRUT_ASSERT_SET_0 out from ecore_reg.h to bnx2x.h. > > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.c |3 +- >

Re: [dpdk-dev] [PATCH] vhost: translate incoming log address to gpa

2019-09-23 Thread Adrian Moreno
On 9/23/19 9:25 AM, Tiwei Bie wrote: > On Tue, Sep 17, 2019 at 04:49:00PM +0200, Adrian Moreno wrote: >> When IOMMU is enabled the incoming log address is in IOVA space. In that >> case, look in IOTLB table and translate the resulting HVA to GPA. >> >> If IOMMU is not enabled, the incoming log addr

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Segment fault when start fwd

2019-09-23 Thread Iremonger, Bernard
Hi Shougangx > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wang ShougangX > Sent: Friday, September 20, 2019 4:14 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Yigit, Ferruh ; Wang, > ShougangX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] ap

Re: [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

2019-09-23 Thread Mattias Rönnblom
On 2019-09-23 11:36, Ray Kinsella wrote: On 23/09/2019 08:23, Thomas Monjalon wrote: 20/09/2019 09:38, Ray Kinsella: On 19/09/2019 16:16, Bruce Richardson wrote: On Thu, Sep 19, 2019 at 02:28:04PM +0100, Ray Kinsella wrote: On 19/09/2019 13:35, Andrzej Ostruszka wrote: On 9/18/19 3:32 P

Re: [dpdk-dev] [PATCH v2 02/16] vhost: unify unroll pragma parameter

2019-09-23 Thread Gavin Hu (Arm Technology China)
Hi Marvin, One general comment and other comments inline: 1. Meson build should also be supported as Makefile is phasing out and Meson is the future in DPDK. /Gavin > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: Friday, September 20, 2019 12:36 AM > To: maxime.coque..

  1   2   >