Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-16 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > > using > the > > > > > same > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > synchronously. > > > > > > > This flexible action type does not r

[dpdk-dev] [PATCH v8] net/ice: support device-specific DDP package loading

2019-09-16 Thread Ting Xu
This patch adds the feature that supports loading DDP package according to the device serial number. Prior to loading the default DDP package (ice.pkg), the driver will check for the presence of a device-specific DDP package with the name containing 64-bit PCIe Device Serial Number (ice-xxx

[dpdk-dev] [PATCH v4 1/2] virtio: one way barrier for packed vring desc avail flags

2019-09-16 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v4 2/2] virtio: one way barrier for packed vring desc used flags

2019-09-16 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v4 0/2] virtio: one way barrier for packed vring flags

2019-09-16 Thread Joyce Kong
This patch set replaces the two-way barriers with C11 one-way barriers for packed vring flags, when the frontend and backend are implemented in software. By doing vhost-user + virtio-user case benchmarking, 9% performance gain in the RFC2544 test was measured on Thunderx2 platform.[1] And by doing

Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier

2019-09-16 Thread Zhang, Qi Z
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Tuesday, September 17, 2019 11:24 AM > To: Gavin Hu (Arm Technology China) ; Zhang, Qi Z > ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.

Re: [dpdk-dev] [PATCH] test/event_crypto: no service core for HW options

2019-09-16 Thread Gujjar, Abhinandan S
Acked-by: abhinandan.guj...@intel.com > -Original Message- > From: Hemant Agrawal > Sent: Friday, September 6, 2019 4:15 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; Gujjar, Abhinandan S ; > Hemant Agrawal > Subject: [PATCH] test/event_crypto: no service core for HW options > > If H

Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier

2019-09-16 Thread Gavin Hu (Arm Technology China)
Hi Qi, > -Original Message- > From: dev On Behalf Of Gavin Hu (Arm > Technology China) > Sent: Tuesday, September 17, 2019 10:08 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, > Yinan ; ajit.khapa...@broadcom.com; > somnath.ko.

Re: [dpdk-dev] [PATCH 1/1] net/ixgbevf: fix stats update after a PF reset

2019-09-16 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thierry Herbelot > Sent: Thursday, September 12, 2019 12:01 AM > To: dev@dpdk.org > Cc: Guo Fengtian ; Thomas Monjalon > ; sta...@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > > Subject: [dpdk-dev] [PATCH 1/1]

Re: [dpdk-dev] [PATCH] net/i40e: set speed to undefined for default case in link update

2019-09-16 Thread Zhang, Qi Z
> -Original Message- > From: Thierry Herbelot [mailto:thierry.herbe...@6wind.com] > Sent: Thursday, September 12, 2019 12:03 AM > To: dev@dpdk.org > Cc: Laurent Hardy ; Thomas Monjalon > ; sta...@dpdk.org; Xing, Beilei > ; Zhang, Qi Z > Subject: [PATCH] net/i40e: set speed to undefined

Re: [dpdk-dev] [RFC v3] net/i40e: enable multi-queue Rx interrupt for VF

2019-09-16 Thread Zhang, Qi Z
> -Original Message- > From: Cui, LunyuanX > Sent: Monday, September 16, 2019 10:43 PM > To: Yang, Qiming ; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; Wang, ShougangX ; > Stillwell Jr, Paul M > Cc: dev@dpdk.org; Cui, LunyuanX > Subject: [RFC v3] net/i40e: enable multi-queue Rx int

Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier

2019-09-16 Thread Gavin Hu (Arm Technology China)
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, September 17, 2019 9:53 AM > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; Honn

Re: [dpdk-dev] [PATCH v2 4/5] net/bnxt: replace with cio barrier for doorbell resp

2019-09-16 Thread Ajit Khaparde
On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu wrote: > To read the doorbell response, which is held in the host CIO memory, > rte_cio_rmb is sufficient. > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > Cc: sta...@dpdk.org > > Signed-off-by: Gavin Hu > Acked-by: Ajit Kha

Re: [dpdk-dev] [PATCH v2 3/5] net/bnxt: remove duplicate barrier

2019-09-16 Thread Ajit Khaparde
On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu wrote: > As there is an inclusive rte_io_wmb within the following rte_write32() > API who rings the doorbell, this makes the above rte_wmb unnecessary and > remove it. > > Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH v2 5/5] net/bnxt: enforce io barrier for doorbell command

2019-09-16 Thread Ajit Khaparde
On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu wrote: > The doorbell ringing operation requires a rte_io_mb immediately to make > the command complete and visible to the device before reading the > response, otherwise it may read stale or invalid responses. > > Fixes: ca241d9a0952 ("net/bnxt: use I/O d

Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier

2019-09-16 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gavin Hu > Sent: Monday, September 16, 2019 7:27 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.khapa...@broadcom.com; > somnath.ko...@broadc

Re: [dpdk-dev] [PATCH v2 2/5] net/ice: use relaxed and remove duplicate barrier

2019-09-16 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gavin Hu > Sent: Monday, September 16, 2019 7:27 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; Richardson, Bruce > ; Liu, Yong ; Wang, Yinan > ; ajit.khapa...@broadcom.com; > somnath.ko...@broadc

[dpdk-dev] [PATCH v7] net/ice: support device-specific DDP package loading

2019-09-16 Thread Ting Xu
This patch adds the feature that supports loading DDP package according to the device serial number. Prior to loading the default DDP package (ice.pkg), the driver will check for the presence of a device-specific DDP package with the name containing 64-bit PCIe Device Serial Number (ice-xxx

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix RSS setting on v4

2019-09-16 Thread Yong Wang
From: Eduard Serra Miralles Date: Friday, September 13, 2019 at 1:10 PM To: Yong Wang Cc: "dev@dpdk.org" Subject: RE: [PATCH] net/vmxnet3: fix RSS setting on v4 I think so too. Apparently however, ESX is mandatorily expecting that underneath. If not set, config will fail. __

Re: [dpdk-dev] [PATCH 0/2] use pkg-config to find Netcope dependencies

2019-09-16 Thread Jan Remeš
On Mon, Sep 16, 2019 at 5:34 PM Ferruh Yigit wrote: > +1 to this patch, unrelated to this patch I remember there was an issue with > the > nfb & szedata2 dependencies, that their dependencies conflict with each other, > so it wasn't possible to enable both at the same time. > > Jan, Rastislav, >

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-16 Thread Ferruh Yigit
On 9/16/2019 4:45 PM, Andrew Rybchenko wrote: > On 9/16/19 4:22 PM, Ferruh Yigit wrote: >> On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: >>> On 9/13/19 7:34 PM, Ferruh Yigit wrote: On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: > On 9/13/19 6:39 PM, Ferruh Yigit wrote: >> On 9/9/2019 12

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/nfb: fix dependency check

2019-09-16 Thread Thomas Monjalon
16/09/2019 17:46, Thomas Monjalon: > 15/09/2019 14:04, Jan Remeš: > > On Sat, Sep 14, 2019 at 11:37 AM Thomas Monjalon > > wrote: > > > > > > The library libnfb is part of netcope-common which provides > > > a pkg-config file: netcope-common.pc. > > > Looking for this .pc file - with dependency()

Re: [dpdk-dev] [PATCH] devtools: fix test of ninja install

2019-09-16 Thread Thomas Monjalon
14/09/2019 11:04, Thomas Monjalon: > When trying to compile some examples with libdpdk.pc, > the right environment (for default target) was not loaded. > The consequence is to not detect some dependencies because > of missing directories in PKG_CONFIG_PATH. > > The environment preparation is moved

Re: [dpdk-dev] [PATCH] devtools: test nfb and AF_XDP build with make

2019-09-16 Thread Thomas Monjalon
14/09/2019 11:16, Thomas Monjalon: > The nfb PMD is disabled by default because of its dependency > on netcope-common package. > The variable DPDK_DEP_NFB was introduced but not used to notify > the dependency availability in the build test script. > > The AF_XDP PMD is disabled by default because

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/nfb: fix dependency check

2019-09-16 Thread Thomas Monjalon
15/09/2019 14:04, Jan Remeš: > On Sat, Sep 14, 2019 at 11:37 AM Thomas Monjalon wrote: > > > > The library libnfb is part of netcope-common which provides > > a pkg-config file: netcope-common.pc. > > Looking for this .pc file - with dependency() - is preferred > > than looking for the library - w

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-16 Thread Andrew Rybchenko
On 9/16/19 4:22 PM, Ferruh Yigit wrote: On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: On 9/13/19 7:34 PM, Ferruh Yigit wrote: On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous

Re: [dpdk-dev] [RFC] ethdev: add new fields for max LRO session size

2019-09-16 Thread Ferruh Yigit
On 9/15/2019 8:48 AM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> On 8/29/2019 8:47 AM, Matan Azrad wrote: >>> It may be needed by the user to limit the LRO session packet size. >>> In order to allow the above limitation, add new Rx configuration for >>> the maximum LRO session size.

Re: [dpdk-dev] [PATCH 0/2] use pkg-config to find Netcope dependencies

2019-09-16 Thread Ferruh Yigit
On 9/14/2019 10:36 AM, Thomas Monjalon wrote: > The libraries required for Netcope PMDs can be found in > https://www.netcope.com/en/company/community-support/dpdk-libsze2 > > These libraries are compatible with pkg-config, which is a better solution > than directly looking for libraries and inclu

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-16 Thread Ferruh Yigit
On 9/16/2019 7:37 AM, Wang, ShougangX wrote: > Hi Ferruh > > Thanks for your reply. > >> Not sure if 'reset' command should do more than it says, if there is a >> requirement that port should be stopped, why not add this condition with an >> error message so that user can stop the port in advance

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-16 Thread Ananyev, Konstantin
> Hi Akhil, > > > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > > using the > > > > > same > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > synchronously. > > > > > > > This flexible action type does not require external hard

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-16 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > using the > > > > same > > > > > > algorithm, key, and direction being processed by CPU cycles > > synchronously. > > > > > > This flexible action type does not require external hardware > > > > > >

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-16 Thread Ferruh Yigit
On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: > On 9/13/19 7:34 PM, Ferruh Yigit wrote: >> On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: >>> On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successf

Re: [dpdk-dev] [PATCH v3 07/13] app/testpmd: check code of promiscuous mode switch

2019-09-16 Thread Iremonger, Bernard
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Saturday, September 14, 2019 12:37 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Ivan Ilchenko > Subject: [PATCH v3 07/13] app/testpmd: check code of promiscuous mod

[dpdk-dev] [PATCH v2 3/5] net/bnxt: remove duplicate barrier

2019-09-16 Thread Gavin Hu
As there is an inclusive rte_io_wmb within the following rte_write32() API who rings the doorbell, this makes the above rte_wmb unnecessary and remove it. Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Steve Capper Reviewed-b

[dpdk-dev] [PATCH v2 4/5] net/bnxt: replace with cio barrier for doorbell resp

2019-09-16 Thread Gavin Hu
To read the doorbell response, which is held in the host CIO memory, rte_cio_rmb is sufficient. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[dpdk-dev] [PATCH v2 5/5] net/bnxt: enforce io barrier for doorbell command

2019-09-16 Thread Gavin Hu
The doorbell ringing operation requires a rte_io_mb immediately to make the command complete and visible to the device before reading the response, otherwise it may read stale or invalid responses. Fixes: ca241d9a0952 ("net/bnxt: use I/O device memory read/write API") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH v2 2/5] net/ice: use relaxed and remove duplicate barrier

2019-09-16 Thread Gavin Hu
To guarantee the orderings of successive stores to CIO and MMIO memory, a lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and since the ICE_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this explicit call can even be saved. [1] http://git.dpdk.org/dpdk/tree/lib/librte_eal/co

[dpdk-dev] [PATCH v2 1/5] net/i40e: use relaxed and remove duplicate barrier

2019-09-16 Thread Gavin Hu
To guarantee the orderings of successive stores to CIO and MMIO memory, a lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and since the I40E_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this explicit call can be even saved. [1] http://git.dpdk.org/dpdk/tree/lib/librte_eal/c

[dpdk-dev] [PATCH v2 0/5] fix and optimize barriers usage with some PMDs

2019-09-16 Thread Gavin Hu
DPDK has well-defined barriers, such as CIO barriers and IO barriers. X86, as a strong ordering model, implements the barriers as compiler barriers, but on aarch64, as a weak memory ordering model, has fine grained barriers. Using correct while as relaxed as possible barriers makes a perf differen

Re: [dpdk-dev] [PATCH v2 1/1] app/testpmd: add console cmd to show port supported ptypes

2019-09-16 Thread Iremonger, Bernard
Hi Vamsi, > -Original Message- > From: vattun...@marvell.com [mailto:vattun...@marvell.com] > Sent: Friday, September 13, 2019 6:41 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; tho...@monjalon.net; Vamsi Attunuru > > Subject: [dpdk-dev] [PATCH v2 1/1]

[dpdk-dev] [Bug 349] i40e/i40evf: Allow bad packets to reach application (SBP)

2019-09-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=349 Bug ID: 349 Summary: i40e/i40evf: Allow bad packets to reach application (SBP) Product: DPDK Version: 18.11 Hardware: All OS: All Status: UNCONFIRMED

[dpdk-dev] [Bug 348] i40e: packets greater than 1024B are dropped due to a integer overflow

2019-09-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=348 Bug ID: 348 Summary: i40e: packets greater than 1024B are dropped due to a integer overflow Product: DPDK Version: 18.11 Hardware: All OS: All Status: UN

[dpdk-dev] [PATCH] config: set RTE_KNI_PREEMPT_DEFAULT in meson

2019-09-16 Thread Igor Ryzhov
Same behavior as in make build system. Signed-off-by: Igor Ryzhov --- config/rte_config.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/rte_config.h b/config/rte_config.h index 0bbbe274f..e6a35a170 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -98,6 +98,9 @@ #def

[dpdk-dev] [PATCH] service: improve service run performance

2019-09-16 Thread Nikhil Rao
For a valid service, the core mask of the service is checked against the current core and the corresponding entry in the active_on_lcore array is set or reset. Upto 8 cores share the same cache line for their service active_on_lcore array entries since each entry is a uint8_t. Some number of these

Re: [dpdk-dev] [PATCH v2 0/6] examples/ioat: sample app on ioat driver usage

2019-09-16 Thread Baran, MarcinX
-Original Message- From: Aaron Conole Sent: Friday, September 13, 2019 8:45 PM To: Baran, MarcinX Cc: dev@dpdk.org; Richardson, Bruce Subject: Re: [dpdk-dev] [PATCH v2 0/6] examples/ioat: sample app on ioat driver usage Marcin Baran writes: > A new sample app demonstrating use of

[dpdk-dev] [PATCH] app/testpmd: support multiple raw encap/decap

2019-09-16 Thread Xiaoyu Min
In some scenarios, the raw_encap/raw_decap actions could be multiple in one single flow (e,g. hirepin flow): ... actions raw_decap / raw_encap / raw_decap / raw_encap / ... This requires the testpmd supports multiple raw_encap/raw_decap data settings as well. With the multiple raw_encap/raw_de

Re: [dpdk-dev] [PATCH 00/12] FIPS improvements

2019-09-16 Thread Akhil Goyal
> > Hi Akhil, > > I send 2 patch sets: one for new functionality support and another one for > fixes. > One patch was sent separately from both of the sets according to your > requirement: Ok will have a look. Thanks. > > >> examples/fips: fix bad return code in fips_test_parse_header() >

[dpdk-dev] [Bug 347] TAPPMD frees buffers it fails to send

2019-09-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=347 Bug ID: 347 Summary: TAPPMD frees buffers it fails to send Product: DPDK Version: 19.08 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priori

Re: [dpdk-dev] [PATCH 4/7] ethdev: change allmulticast callbacks to return status

2019-09-16 Thread Andrew Rybchenko
Hi Hyong, On 9/16/19 10:03 AM, Hyong Youb Kim (hyonkim) wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, September 9, 2019 9:13 PM [...] Subject: [PATCH 4/7] ethdev: change allmulticast callbacks to return status From: Ivan Ilchenko Enabling/disabling of allmulticast

Re: [dpdk-dev] [PATCH 4/7] ethdev: change allmulticast callbacks to return status

2019-09-16 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, September 9, 2019 9:13 PM [...] > Subject: [PATCH 4/7] ethdev: change allmulticast callbacks to return status > > From: Ivan Ilchenko > > Enabling/disabling of allmulticast mode is not always successful and > it should be tak