[dpdk-dev] [PATCH v2 4/5] event/dpaa2: add selftest cases

2019-09-06 Thread Hemant Agrawal
This patch add support for testing dpaa2 eventdev self test for basic sanity for parallel and atomic queues. Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/Makefile | 1 + drivers/event/dpaa2/dpaa2_eventdev.c | 1 + drivers/event/dpaa2/dpaa2_eventdev.h

[dpdk-dev] [PATCH v2 5/5] test/event: enable dpaa2 self test

2019-09-06 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- app/test/test_eventdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c index 783140dfe..427dbbf77 100644 --- a/app/test/test_eventdev.c +++ b/app/test/test_eventdev.c @@ -1020,9 +1020,16 @@ test_eve

[dpdk-dev] [PATCH v2 3/5] event/dpaa2: add destroy support

2019-09-06 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 35 1 file changed, 35 insertions(+) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 98b487603..9255de16f 100644 --- a/drivers/event/dpaa2/dpaa2_e

[dpdk-dev] [PATCH v2 1/5] event/dpaa2: fix def queue conf

2019-09-06 Thread Hemant Agrawal
Test vector expect only one type of scheduling as default. The old code is provide support scheduling types instead of default. Fixes: 13370a3877a5 ("eventdev: fix inconsistency in queue config") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 7 ++---

[dpdk-dev] [PATCH v2 2/5] event/dpaa2: remove conditional compilation

2019-09-06 Thread Hemant Agrawal
This patch removes the conditional compilation for cryptodev event support from RTE_LIBRTE_SECURITY flag. Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/Makefile | 2 -- drivers/event/dpaa2/dpaa2_eventdev.c | 6 -- 2 files changed, 8 deletions(-) diff --git a/drivers/event/dp

[dpdk-dev] [PATCH v2 0/5] NXP DPAA2 EVENTDEV enhancements

2019-09-06 Thread Hemant Agrawal
This patch series has minor fixes in dpaa2 eventdev support - default queue and cleanup logic - introducing selftest for dpaa2 v2: fix compilation issue wit meson and missing selftest file Hemant Agrawal (5): event/dpaa2: fix def queue conf event/dpaa2: remove conditional compilation even

[dpdk-dev] [PATCH v3 22/22] net/ice/base: remove unused DDP package macros

2019-09-06 Thread Qi Zhang
Macros no longer be used and can be removed Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_type.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h index

[dpdk-dev] [PATCH v3 21/22] net/ice/base: fix segment in remove existing RSS rule

2019-09-06 Thread Qi Zhang
Before this patch, RSS tunneled rules can not be destroyed at runtime. This is because it can not find the existing matching profile for tunnels. segs[0] should always be zero and all matched, segs[1] for inner part. It only construct one segment. This patch modifies construct segment in ice_rem_r

[dpdk-dev] [PATCH v3 20/22] net/ice/base: fix the bitmap for TCP in RSS

2019-09-06 Thread Qi Zhang
Before this patch, if set rule for IPv4 first and then set rule for TCP with IPv4. The first rule for inner IP will be overwritten by TCP rule. This is because MAC_IPV6_TUN_MAC_IPV4_PAY using the same ptgs PTG_TUN_INNER_IPV4_OTHER with MAC_IPV4_TUN_MAC_IPV4_PAY, this ptype should not in TCP bitmap.

[dpdk-dev] [PATCH v3 18/22] net/ice/base: replace alloc-followed-by-copy with memdup

2019-09-06 Thread Qi Zhang
ice_memdup() is preferred over an alloc immediately followed by a copy. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 5 ++--- drivers/net/ice/base/ice_switch.c| 7 ++- 2 files changed, 4 insertions(+),

[dpdk-dev] [PATCH v3 19/22] net/ice/base: add FDIR support for GTPU qfi field

2019-09-06 Thread Qi Zhang
Add GTPU qfi field support for flow director. Note that for GTPU pkt, only qfi field (6 bits) can be set for FD. The supported GTPU pkts are defined as: ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_UDP, ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_TCP, ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP, ICE_FLTR_PTYPE_NONF_IPV4_

[dpdk-dev] [PATCH v3 17/22] net/ice/base: enable symmetric hash for RSS

2019-09-06 Thread Qi Zhang
Add parameter "symm" to rss configuration APIs. When symm is 1, Symmetric Teoplitz Hash can be enabled by configuring GLQF_HSYMM properly. NOTE: Symmetric Teoplitz hash will work only if hash schema of VSIQF_HASH_CTL be configured to 01b and it is assumed be enabled in PMD. Signed-off-by: Qi Zhan

[dpdk-dev] [PATCH v3 13/22] net/ice/base: enable fdir queue region

2019-09-06 Thread Qi Zhang
Add fdir queue region support. Signed-off-by: Qi Zhang Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_fdir.c | 3 +++ drivers/net/ice/base/ice_fdir.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c index e

[dpdk-dev] [PATCH v3 14/22] net/ice/base: enable setting up FDIR counters

2019-09-06 Thread Qi Zhang
Enable getting value from input to set up flow director counters, so that the FDIR counters can count none, packets only, bytes only or both packets and bytes as demanded. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c

[dpdk-dev] [PATCH v3 12/22] net/ice/base: enable RSS for PPPoE with SCTP

2019-09-06 Thread Qi Zhang
Add two ptypes(MAC_PPPOE_IPV4_SCTP and MAC_PPPOE_IPV6_SCTP) in sctp ptype bitmap to enable rss. Signed-off-by: Zhirun Yan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/n

[dpdk-dev] [PATCH v3 15/22] net/ice/base: add dest MAC field support for FDIR

2019-09-06 Thread Qi Zhang
Add dest MAC address support so that this field can be matched when we set Flow Director filter with dst addr for MAC. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 19 +++ 1 file changed, 19 insertio

[dpdk-dev] [PATCH v3 16/22] net/ice/base: update FW API minor version

2019-09-06 Thread Qi Zhang
Update FW API minor version to align to current value advertised by FW in NVM images. Signed-off-by: Kevin Scott Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_controlq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ic

[dpdk-dev] [PATCH v3 07/22] net/ice/base: remove pointless NULL check of port info

2019-09-06 Thread Qi Zhang
The code in ice_sched_cleanup_all checks whether the port info is NULL prior to calling ice_sched_clear_port. More importantly, it also checks whether the port structure has been initialized by checking its port_state field as well. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr

[dpdk-dev] [PATCH v3 08/22] net/ice/base: remove RSS code as iavf host

2019-09-06 Thread Qi Zhang
The DPDK PF doesn't support SRIOV so remove the related iavf host code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b

[dpdk-dev] [PATCH v3 11/22] net/ice/base: associate switch recipe to profiles

2019-09-06 Thread Qi Zhang
Properly associate switch recipes to profiles. Previous code was using the wrong bitfield for updating the associations, which was causing other PFs to not properly identify and use existing recipes. This sometimes resulted in rules not being added when it should have been possible. Signed-off-by:

[dpdk-dev] [PATCH v3 06/22] net/ice/base: propagate errors from functions

2019-09-06 Thread Qi Zhang
There could be an error returned from ice_fill_adv_dummy_packet() so we need to propagate that to the caller. Additionally, the call to ice_flow_xtract_pkt_flags() could also return an error so we need to propagate it as well. Also add in the correct offsets for GENEVE and VXLAN_GPE to the dummy p

[dpdk-dev] [PATCH v3 05/22] net/ice/base: correct the mask for checking protocol header

2019-09-06 Thread Qi Zhang
Before this patch, the logic of protocol header checking only support non-tunneled packet. This patch remove the inner protocol in L3/L4 RSS seg hdr mask and change the protocol header validation to reflect this. So, for ice_add_rss_cfg(), the last parameter addl_hdrs could specify the protocol hea

[dpdk-dev] [PATCH v3 10/22] net/ice/base: minor structure refactor

2019-09-06 Thread Qi Zhang
When declaring the ice_prot_ext, and ice_prot_id_tbl structure, we can use a fixed length array instead of a variable length one which helps us catch future code changes that might desynchronize the enum ice_protocol_type and the structs. This change also necessitates removing the last member of t

[dpdk-dev] [PATCH v3 09/22] net/ice/base: add support for switch rule about VLAN PPPoE

2019-09-06 Thread Qi Zhang
Add support for switch rule about single-VLAN-PPPoE. Note that double VLAN is not supported by the hardware at this point, therefore only single-VLAN support for PPPoE is added. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_p

[dpdk-dev] [PATCH v3 04/22] net/ice/base: add non-word aligned ipv6 field support

2019-09-06 Thread Qi Zhang
Add non-word aligned field support for IPv6 with hlim, tc and proto. All these fields are one byte within one word. In order to match bytes within the IPv6 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v3 02/22] net/ice/base: add support for tunnel packets

2019-09-06 Thread Qi Zhang
Add VXLAN tunnel training packets to flow director and change the interface to support tunnel packets. Signed-off-by: Henry Tieman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 266 drivers/net/ice/base

[dpdk-dev] [PATCH v3 03/22] net/ice/base: add non-word aligned ip field support

2019-09-06 Thread Qi Zhang
Add non-word aligned field support for ipv4 with ttl, tos and proto. All these fields are one byte within one word. In order to match bytes within the IPv4 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v3 01/22] net/ice/base: remove redundant empty lines

2019-09-06 Thread Qi Zhang
Remove redundant empty lines Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 111 --- drivers/net/ice/base/ice_bitops.h| 2 - drivers/net/ice/base/ice_common.c| 25 --- drivers/net/ice/b

[dpdk-dev] [PATCH v3 00/22] net/ice/base: share code update secend batch.

2019-09-06 Thread Qi Zhang
The patchset depends on the first batch http://patchwork.dpdk.org/project/dpdk/list/?series=6158&state=* Key Features: 1) Add tunnel support for fdir 2) Add non-word aligned field support for fdir 3) Add dest mac field support for fdir 4) Add flow count support for fdir 5) Add queue region suppor

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-06 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 6, 2019 22:22 > To: Ray Kinsella ; Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace > information > > On 8/13/2019 1:51 PM, Ray Kinsella wrote: > > > > > > On

[dpdk-dev] [PATCH 1/1] net/bnxt: add support for CoS classification

2019-09-06 Thread Ajit Khaparde
From: Venkat Duvvuru Class of Service (CoS) is a way to manage multiple types of traffic over a network to offer different types of services to applications. CoS classification (priority to cosqueue) is determined by the user and configured through the PF driver. DPDK driver queries this configur

[dpdk-dev] [PATCH 0/1] bnxt patch to support CoS classification

2019-09-06 Thread Ajit Khaparde
This patch is dependent on a previous patch submission. http://patches.dpdk.org/project/dpdk/list/?series=6209 Patch against dpdk-next-net. Please apply. Venkat Duvvuru (1): net/bnxt: add support for CoS classification drivers/net/bnxt/bnxt.h| 8 +++- drivers/net/bnxt/bnxt_eth

[dpdk-dev] Issue with DCB with X710 Quad 10Gb NIC

2019-09-06 Thread Mike DeVico
Hello, I am having an issue getting the DCB feature to work with an Intel X710 Quad SFP+ NIC. Here’s my setup: 1. DPDK 18.08 built with the following I40E configs: CONFIG_RTE_LIBRTE_I40E_PMD=y CONFIG_RTE_LIBRTE_I40E_DEBUG_RX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_TX=n CONFIG_RTE_LIBRTE_I40E_DEBUG_

[dpdk-dev] [PATCH] pktgen: fix checksum calculation logic

2019-09-06 Thread Rahul Lakkireddy
Use rte_ipv4_udptcp_cksum() and rte_ipv6_udptcp_cksum() for calculating L4 checksum in IPv4 and IPv6 packets, respectively. Fix the IPv6 address copying logic to keep it consistent in all places. Also, fix the payload length calculation in IPv4 and IPv6 headers. Fixes: 9a43ed448cd1 ("First commit

[dpdk-dev] [PATCH 7/9] eal: add function to detect process type

2019-09-06 Thread Pallavi Kadam
Adding a function to detect process type and include header files to contain suitable function declarations. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c| 51

[dpdk-dev] [PATCH 8/9] build: add additional common files support

2019-09-06 Thread Pallavi Kadam
Support for additional common files in meson build to expand Windows EAL and to support the lcore parsing feature on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/meson.build | 8 +

[dpdk-dev] [PATCH 9/9] eal: add minimum viable code to support parsing

2019-09-06 Thread Pallavi Kadam
Adding specific logic for eal.c to support parsing on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c | 119 +-- 1 file changed, 112 insertions(+), 7 de

[dpdk-dev] [PATCH 5/9] eal: add additional function overrides in windows header files

2019-09-06 Thread Pallavi Kadam
Adding additional function definitions for pthread, cpuset implementation, asprintf implementation, in order to support common code. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/common/include/rte_lcore.h

[dpdk-dev] [PATCH 3/9] eal: add windows compatible header files

2019-09-06 Thread Pallavi Kadam
Adding dlfcn.h on Windows to support common code. Adding eal_filesystem.h to support functions and path defines for files and directories on Windows. Adding getopt.h to support parsing options on Windows. Adding rte_vect.h as Windows fails to compile: \common\include\arch\x86\rte_vect.h. Signed

[dpdk-dev] [PATCH 2/9] eal: syslog implementation for windows

2019-09-06 Thread Pallavi Kadam
Adding syslog.h on Windows for supporting common code. This implementation has BSD-3-Clause licensing. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/include/syslog.h | 213

[dpdk-dev] [PATCH 1/9] eal: eal stub to support parsing feature on windows

2019-09-06 Thread Pallavi Kadam
Adding initial stub to support command line parsing for lcore mask option on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c| 29 ++--- lib/librte_eal/w

[dpdk-dev] [PATCH 6/9] eal: getopt implementation for windows

2019-09-06 Thread Pallavi Kadam
Adding getopt_long.c and getopt.c files to support parsing option on Windows. The original contribution is under MIT license. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/getopt.c | 132 +

[dpdk-dev] [PATCH 4/9] eal: dirent.h implementation for windows

2019-09-06 Thread Pallavi Kadam
Adding dirent.h on Windows to support common code. The original contribution is under MIT license. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/include/dirent.h | 666 1 f

[dpdk-dev] [PATCH 0/9] Windows patchset with additional EAL functionalities

2019-09-06 Thread Pallavi Kadam
This patchset includes additional functionalities to Windows EAL to support command-line parsing feature and EAL common code on Windows. This patchset can be applied to windpdk-next-dev branch in the draft repo. Pallavi Kadam (9): eal: eal stub to support parsing feature on windows eal: syslo

[dpdk-dev] [PATCH 08/12] net/cxgbe: separate VF only devargs

2019-09-06 Thread Rahul Lakkireddy
Rework devargs parsing logic to separate VF only args. Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst | 6 +++ drivers/net/cxgbe/base/adapter.h | 7 +++ drivers/net/cxgbe/cxgbe.h | 9 ++-- drivers/net/cxgbe/cxgbe_ethdev.c | 5 +- drivers/net/cxgbe/cxgbe_m

[dpdk-dev] [PATCH 10/12] net/cxgbe: fetch max Tx coalesce limit from firmware

2019-09-06 Thread Rahul Lakkireddy
Query firmware for max number of packets that can be coalesced by Tx. Signed-off-by: Rahul Lakkireddy --- doc/guides/nics/cxgbe.rst | 18 ++-- drivers/net/cxgbe/base/common.h | 1 + drivers/net/cxgbe/base/t4fw_interface.h | 3 +- drivers/net/cxgbe/cxgbe_main.c

[dpdk-dev] [PATCH 12/12] net/cxgbe: add rte_flow support for setting VLAN PCP

2019-09-06 Thread Rahul Lakkireddy
Add support for setting VLAN PCP field via rte_flow API. Hardware overwrites the entire 16-bit VLAN TCI field. So, both VLAN VID and PCP actions must be specified. Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 27 +++ 1 file changed, 27 insertions(+

[dpdk-dev] [PATCH 09/12] net/cxgbe: add devarg to control Tx coalescing

2019-09-06 Thread Rahul Lakkireddy
Remove compile time option to control Tx coalescing Latency vs Throughput behavior. Add tx_mode_latency devarg instead, to dynamically control Tx coalescing behavior. Signed-off-by: Rahul Lakkireddy --- config/common_base | 1 - doc/guides/nics/cxgbe.rst | 13 +-

[dpdk-dev] [PATCH 11/12] net/cxgbe: add rte_flow support for matching VLAN

2019-09-06 Thread Rahul Lakkireddy
Add support for matching VLAN fields via rte_flow API. When matching VLAN pattern, the ethertype field in hardware filter specification must contain VLAN header's ethertype, and not Ethernet header's ethertype. The hardware automatically searches for ethertype 0x8100 in Ethernet header, when parsi

[dpdk-dev] [PATCH 06/12] net/cxgbe: avoid polling link status before device start

2019-09-06 Thread Rahul Lakkireddy
Link updates come in firmware event queue, which is only created when device starts. So, don't poll for link status if firmware event queue is not yet created. This fixes NULL dereference when accessing non existent firmware event queue. Cc: sta...@dpdk.org Fixes: 265af08e75ba ("net/cxgbe: add li

[dpdk-dev] [PATCH 05/12] net/cxgbe: fix prefetch for non-coalesced Tx packets

2019-09-06 Thread Rahul Lakkireddy
Move prefetch code out of Tx coalesce path to allow prefetching for non-coalesced Tx packets, as well. Cc: sta...@dpdk.org Fixes: bf89cbedd2d9 ("cxgbe: optimize forwarding performance for 40G") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_ethdev.c | 9 +++-- drivers/net/cxgbe

[dpdk-dev] [PATCH 07/12] net/cxgbe: use dynamic logging for debug prints

2019-09-06 Thread Rahul Lakkireddy
Remove compile time flags and use dynamic logging for debug prints. Signed-off-by: Rahul Lakkireddy --- config/common_base | 5 --- doc/guides/nics/cxgbe.rst| 20 --- drivers/net/cxgbe/cxgbe_compat.h | 58 +++- drivers/net/cxgbe/cxgbe_et

[dpdk-dev] [PATCH 04/12] net/cxgbe: fix parsing VLAN ID rewrite action

2019-09-06 Thread Rahul Lakkireddy
Set VLAN action mode to VLAN_REWRITE only if VLAN_INSERT has not been set yet. Otherwise, the resulting VLAN packets will have their VLAN header rewritten, instead of pushing a new outer VLAN header. Also fix the VLAN ID extraction logic and endianness issues. Cc: sta...@dpdk.org Fixes: 1decc62b1

[dpdk-dev] [PATCH 01/12] net/cxgbe: add cxgbe_ prefix to global functions

2019-09-06 Thread Rahul Lakkireddy
To avoid name collisions, add cxgbe_ prefix to some global functions. Also, make some local functions static in cxgbe_filter.c. Cc: sta...@dpdk.org Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") Fixes: 9eb2c9a48072 ("net/cxgbe: implement flow create operation") Fixes: 3a381a4116ed ("n

[dpdk-dev] [PATCH 03/12] net/cxgbe: fix slot allocation for IPv6 flows

2019-09-06 Thread Rahul Lakkireddy
IPv6 flows occupy only 2 slots on Chelsio T6 NICs. Fix the slot calculation logic to return correct number of slots. Cc: sta...@dpdk.org Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") Fixes: 9eb2c9a48072 ("net/cxgbe: implement flow create operation") Fixes: 3f2c1e209cfc ("net/cxgbe: a

[dpdk-dev] [PATCH 02/12] net/cxgbe: fix NULL access when allocating CLIP entry

2019-09-06 Thread Rahul Lakkireddy
Pass correct arguments to CLIP allocation code to avoid NULL pointer dereference. Cc: sta...@dpdk.org Fixes: 3f2c1e209cfc ("net/cxgbe: add Compressed Local IP region") Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH 00/12] net/cxgbe: bug fixes and updates for CXGBE/CXGBEVF PMD

2019-09-06 Thread Rahul Lakkireddy
This series of patches contain bug fixes and feature updates for CXGBE and CXGBEVF PMD. Patches 1 to 6 contain bug fixes. Patches 7 to 12 contain updates and new features for CXGBE/CXGBEVF PMD. Patch 1 adds cxgbe_ prefix to some global functions to avoid name collision. Patch 2 fixes NULL derefer

Re: [dpdk-dev] [PATCH v2 6/6] test/lpm: add RCU integration performance tests

2019-09-06 Thread Honnappa Nagarahalli
Adding Paul for feedback > -Original Message- > From: Ruifeng Wang > Sent: Friday, September 6, 2019 4:46 AM > To: bruce.richard...@intel.com; vladimir.medved...@intel.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org; step...@networkplumber.org; > konstantin.anan...@intel.com; Gavin Hu (A

Re: [dpdk-dev] [PATCH v2 4/6] app/test: add test case for LPM RCU integration

2019-09-06 Thread Honnappa Nagarahalli
Adding Paul for feedback > -Original Message- > From: Ruifeng Wang > Sent: Friday, September 6, 2019 4:46 AM > To: bruce.richard...@intel.com; vladimir.medved...@intel.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org; step...@networkplumber.org; > konstantin.anan...@intel.com; Gavin Hu (A

Re: [dpdk-dev] [PATCH v2 3/6] lib/lpm: integrate RCU QSBR

2019-09-06 Thread Honnappa Nagarahalli
Adding Paul for feedback > -Original Message- > From: Ruifeng Wang > Sent: Friday, September 6, 2019 4:46 AM > To: bruce.richard...@intel.com; vladimir.medved...@intel.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org; step...@networkplumber.org; > konstantin.anan...@intel.com; Gavin Hu (A

Re: [dpdk-dev] [PATCH v2 1/6] doc/rcu: add RCU integration design details

2019-09-06 Thread Honnappa Nagarahalli
Adding Paul for feedback on design > -Original Message- > From: Ruifeng Wang > Sent: Friday, September 6, 2019 4:45 AM > To: bruce.richard...@intel.com; vladimir.medved...@intel.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org; step...@networkplumber.org; > konstantin.anan...@intel.com; G

Re: [dpdk-dev] [PATCH 4/5] event/dpaa2: add selftest cases

2019-09-06 Thread Aaron Conole
Hemant Agrawal writes: > Signed-off-by: Hemant Agrawal > --- > drivers/event/dpaa2/Makefile | 1 + > drivers/event/dpaa2/dpaa2_eventdev.c | 1 + > drivers/event/dpaa2/dpaa2_eventdev.h | 2 ++ > drivers/event/dpaa2/dpaa2_eventdev_logs.h | 6 ++ > drivers/event/dpaa2/me

[dpdk-dev] [PATCH v2 6/6] lib/eventdev: use ring templates for event rings

2019-09-06 Thread Honnappa Nagarahalli
Use rte_ring templates to define ring APIs for 128b ring element type. However, the generic 128b ring APIs are not defined. Doing so, results in changes to 'struct rte_event' which results in API changes. Suggested-by: Jerin Jacob Kollanukkaran Suggested-by: Pavan Nikhilesh Bhagavatula Signed-of

[dpdk-dev] [PATCH v2 5/6] lib/hash: use ring with 32b element size to save memory

2019-09-06 Thread Honnappa Nagarahalli
The freelist and external bucket indices are 32b. Using rings that use 32b element sizes will save memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_hash/rte_cuckoo_hash.c | 55 ++

[dpdk-dev] [PATCH v2 4/6] lib/ring: add ring APIs to support 32b ring elements

2019-09-06 Thread Honnappa Nagarahalli
Add ring APIs to support 32b ring elements using templates. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_ring/Makefile | 3 ++- lib/librte_ring/meson.build | 4 +++- lib/librte_ring/rte_r

[dpdk-dev] [PATCH v2 2/6] lib/ring: add template to support different element sizes

2019-09-06 Thread Honnappa Nagarahalli
Add templates to support creating ring APIs with different ring element sizes. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- lib/librte_ring/Makefile| 4 +- lib/librte_ring/meson.build | 4 +- lib/l

[dpdk-dev] [PATCH v2 1/6] lib/ring: apis to support configurable element size

2019-09-06 Thread Honnappa Nagarahalli
Current APIs assume ring elements to be pointers. However, in many use cases, the size can be different. The new APIs rte_ring_get_memsize_elem and rte_ring_create_elem help reduce code duplication while creating rte_ring templates. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar

[dpdk-dev] [PATCH v2 3/6] tools/checkpatch: relax constraints on __rte_experimental

2019-09-06 Thread Honnappa Nagarahalli
Relax the constraints on __rte_experimental usage, allow redefining to macros. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- devtools/checkpatches.sh | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.

[dpdk-dev] [PATCH v2 0/6] lib/ring: templates to support custom element size

2019-09-06 Thread Honnappa Nagarahalli
The current rte_ring hard-codes the type of the ring element to 'void *', hence the size of the element is hard-coded to 32b/64b. Since the ring element type is not an input to rte_ring APIs, it results in couple of issues: 1) If an application requires to store an element which is not 64b, it

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-06 Thread Stephen Hemminger
On Fri, 6 Sep 2019 15:18:11 +0200 Marcin Zapolski wrote: > +RTE_INIT(rte_eth_dev_init) > +{ > + int i; > + > + for (i = 0; i < RTE_MAX_ETHPORTS; i++) > + rte_eth_dev_functions[i] = > + (struct rte_eth_dev_fcns *)(&rte_eth_devices[i]); Casts are error pron

Re: [dpdk-dev] [PATCH v6 04/10] vhost: add two new messages to support a shared buffer

2019-09-06 Thread Maxime Coquelin
On 8/29/19 4:12 PM, JinYu wrote: > This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD > and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared > buffer between qemu and backend. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-b

Re: [dpdk-dev] [PATCH v6 03/10] vhost: add the inflight structure

2019-09-06 Thread Maxime Coquelin
On 8/29/19 4:12 PM, JinYu wrote: > This patch adds the inflight queue region structure include > the split and packed. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by: Jin Yu > --- > lib/librte_vhost/rte_vhost.h | 43 +

Re: [dpdk-dev] [PATCH v6 02/10] vhost: add packed ring

2019-09-06 Thread Maxime Coquelin
On 8/29/19 4:12 PM, JinYu wrote: > This patch add the packed ring in the rte_vhost_vring. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by: Jin Yu > --- > lib/librte_vhost/rte_vhost.h | 15 --- > 1 file changed, 12 insertions(+), 3 del

[dpdk-dev] [PATCH] net/ixgbe: add security statistics

2019-09-06 Thread Radu Nicolau
Update IXGBE PMD with support for IPsec statistics. Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_ipsec.c| 244 - drivers/net/ixgbe/ixgbe_ipsec.h| 17 ++- drivers/net/ixgbe/ixgbe_rxtx.c | 18 +++ drivers/net/ixgbe/ixgbe_rxtx.h

Re: [dpdk-dev] [PATCH v6 01/10] vhost: add the inflight description

2019-09-06 Thread Maxime Coquelin
On 8/29/19 4:12 PM, JinYu wrote: > This patch add the inflight message description and > the inflight share fd protocol feature flag. > > Signed-off-by: Lin Li > Signed-off-by: Xun Ni > Signed-off-by: Yu Zhang > Signed-off-by: Jin Yu > --- > v1 - specify the APIs are split-ring only > v2 -

Re: [dpdk-dev] [PATCH v6 00/10] vhost: support inflight share memory protocol feature

2019-09-06 Thread Maxime Coquelin
On 8/29/19 4:12 PM, JinYu wrote: > This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD > and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared > buffer between qemu and backend for backend reconnection. > Now It can both support split and packed ring. The example code s

Re: [dpdk-dev] [PATCH] vhost: add device opr when notification to guest is sent

2019-09-06 Thread Maxime Coquelin
Hi Eelco, On 8/28/19 4:49 PM, Eelco Chaudron wrote: > This patch adds an operation callback which gets called every time > the library is waking up the guest trough an eventfd_write() call. > > This can be used by 3rd party application, like OVS, to track the > number of times interrupts where ge

Re: [dpdk-dev] [PATCH] examples/l3fwd: add support for eventdev mode

2019-09-06 Thread Aaron Conole
Sunil Kumar Kori writes: > Signed-off-by: Sunil Kumar Kori > --- > examples/l3fwd/Makefile | 2 +- Please also update the meson.build file so that this example will build properly. > examples/l3fwd/l3fwd.h | 21 +- > examples/l3fwd/l3fwd_common.h | 10 + > examples/l3fw

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-06 Thread Ye Xiaolong
On 09/04, Ying Wang wrote: >The patch reworks the generic flow API (rte_flow) implementation. >It introduces an abstract layer which provides a unified interface >for low-level filter engine (switch, fdir, hash) to register supported >patterns and actions and implement flow validate/create/destroy/

[dpdk-dev] [PATCH v2 3/3] common/qat: add dual thread support

2019-09-06 Thread Fiona Trahe
Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be done in one thread,

[dpdk-dev] [PATCH v2 1/3] common/qat: remove tail write coalescing feature

2019-09-06 Thread Fiona Trahe
The feature Coalescing Tail Writes on Enqueue is removed as it is not thread-safe and a dual-thread feature will be added shortly. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 16 +++- drivers/common/qat/qat_qp.h | 6 -- 2 files changed, 3 insertions(+), 19 delet

[dpdk-dev] [PATCH v2 2/3] common/qat: move max inflights param into qp

2019-09-06 Thread Fiona Trahe
The max_inflights parameter is moved from qat_queue to qat_qp as it's a more appropriate location. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 23 --- drivers/common/qat/qat_qp.h | 2 +- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v2 0/3] Add dual threading in QAT PMD

2019-09-06 Thread Fiona Trahe
Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be done in one thread,

Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for packed vring desc avail flags

2019-09-06 Thread Maxime Coquelin
Hi Joyce, On 9/6/19 1:34 PM, Joyce Kong wrote: > In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend > and backend are assumed to be implemented in software, that is they can > run on identical CPUs in an SMP configuration. Thus a weak form of memory > barriers like rte_smp_r/

[dpdk-dev] [PATCH 2/3] common/qat: move max inflights param into qp

2019-09-06 Thread Fiona Trahe
The max_inflights parameter is moved from qat_queue to qat_qp as it's a more appropriate location. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 23 --- drivers/common/qat/qat_qp.h |2 +- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH 3/3] common/qat: add dual thread support

2019-09-06 Thread Fiona Trahe
Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be done in one thread,

[dpdk-dev] [PATCH 1/3] common/qat: remove tail write coalescing feature

2019-09-06 Thread Fiona Trahe
The feature Coalescing Tail Writes on Enqueue is removed as it is not thread-safe and a dual-thread feature will be added shortly. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 16 +++- drivers/common/qat/qat_qp.h |6 -- 2 files changed, 3 insertions(+), 19 d

[dpdk-dev] [PATCH 0/3] Add dual threading in QAT PMD

2019-09-06 Thread Fiona Trahe
Remove the limitation whereby enqueue and dequeue must be done in same thread. The inflight calculation is reworked to be thread-safe for 2 threads - note this is not general multi-thread support, i.e all enqueues to a qp must still be done in one thread and all dequeues must be done in one thread,

Re: [dpdk-dev] [PATCH v3 17/54] ethdev: change device info get callback to return int

2019-09-06 Thread Ferruh Yigit
On 9/6/2019 3:07 PM, Aaron Conole wrote: > Andrew Rybchenko writes: > >> On 9/6/19 4:29 PM, Aaron Conole wrote: >>> Andrew Rybchenko writes: >>> From: Ivan Ilchenko Change eth_dev_infos_get_t return value from void to int. Make eth_dev_infos_get_t implementations across all

[dpdk-dev] [PATCH 2/2] crypto/qat: handle Single Pass Crypto Requests

2019-09-06 Thread Adam Dybkowski
This patch improves the performance of AES GCM by using the Single Pass Crypto Request functionality when running on GEN3 QAT. Signed-off-by: Adam Dybkowski --- drivers/crypto/qat/qat_sym.c | 36 +--- drivers/crypto/qat/qat_sym_session.c | 2 +- 2 files changed,

[dpdk-dev] [PATCH 1/2] common/qat: add new QAT GEN3 definitions

2019-09-06 Thread Adam Dybkowski
This patch adds few definitions specific to GEN3 QAT. Signed-off-by: Adam Dybkowski --- drivers/common/qat/qat_adf/icp_qat_fw_la.h | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/common/qat/qat_adf/icp_qat_fw_la.h b/drivers/common/qat/qat_adf/icp

[dpdk-dev] [PATCH 0/2] QAT: handle Single Pass GCM

2019-09-06 Thread Adam Dybkowski
This patch improves the performance of AES GCM by using the Single Pass Crypto Request functionality when running on GEN3 QAT. Adam Dybkowski (2): common/qat: add new QAT GEN3 definitions crypto/qat: handle Single Pass Crypto Requests drivers/common/qat/qat_adf/icp_qat_fw_la.h | 19

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-06 Thread Ferruh Yigit
On 9/6/2019 2:18 PM, Marcin Zapolski wrote: > Split rte_eth_dev structure to two parts: head that is available for > user applications, and rest which is DPDK internal. > Make an array of pointers to rte_eth_dev structures available for user > applications. > > Signed-off-by: Marcin Zapolski <..

[dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int

2019-09-06 Thread Andrew Rybchenko
From: Igor Romanov Change return value of the callbacks from void to int. Make implementations across all drivers return negative errno values in case of error conditions. Both callbacks are updated together because a large number of drivers assign the same function to both callbacks. Signed-of

[dpdk-dev] [PATCH 1/2] ethdev: change xstats reset function return value to int

2019-09-06 Thread Andrew Rybchenko
From: Igor Romanov Change rte_eth_xstats_reset() return value from void to int and return negative errno values in case of error conditions. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/proc-info/main.c | 10 +- app/test-pmd/config.c

[dpdk-dev] [PATCH 0/2] ethdev: change xstats reset function return value to int

2019-09-06 Thread Andrew Rybchenko
It is the third patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of the first [2] and the second [3]. It could be applied separately, but few simple conflicts should be resolved. Functions which return void are ba

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-06 Thread Ferruh Yigit
On 8/13/2019 1:51 PM, Ray Kinsella wrote: > > > On 13/08/2019 04:24, Stephen Hemminger wrote: >> On Tue, 13 Aug 2019 11:06:10 +0800 >> Haiyue Wang wrote: >> >>> Enhance the PMD to support retrieving trace information like >>> Rx/Tx burst selection etc. >>> >>> Signed-off-by: Haiyue Wang >>> ---

Re: [dpdk-dev] [PATCH v5] net/ice: support device-specific DDP package loading

2019-09-06 Thread Ye Xiaolong
On 09/06, Ting Xu wrote: >This patch adds the feature that supports loading DDP package >according to the device serial number. Prior to loading the >default DDP package (ice.pkg), the driver will check for the >presence of a device-specific DDP package with the name containing >64-bit PCIe Device

Re: [dpdk-dev] [PATCH v3 17/54] ethdev: change device info get callback to return int

2019-09-06 Thread Aaron Conole
Andrew Rybchenko writes: > On 9/6/19 4:29 PM, Aaron Conole wrote: >> Andrew Rybchenko writes: >> >>> From: Ivan Ilchenko >>> >>> Change eth_dev_infos_get_t return value from void to int. >>> Make eth_dev_infos_get_t implementations across all drivers to return >>> negative errno values if case

Re: [dpdk-dev] [RFC 19.11 v2 0/3] Hide DPDK internal struct from public API

2019-09-06 Thread Bruce Richardson
On Fri, Sep 06, 2019 at 03:18:10PM +0200, Marcin Zapolski wrote: > Several DPDK internal structures are exposed to direct access by user > applications. This patch removes them from public API, and makes core DPDK > functions that use them non-inline. > > v2: > This patch set no longer makes inter

  1   2   3   >