Re: [dpdk-dev] [PATCH 08/22] net/hns3: add support for link update operation

On 2019/8/30 23:04, Ferruh Yigit wrote: > On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: >> This patch adds link update operation to hns3 PMD driver. >> >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Hao Chen >> Signed-off-

[dpdk-dev] [PATCH 3/3] net/enic: fix crash in secondary process

Both primary and secondary processes may call the queue start/stop, link update handlers. These functions use the rte_eth_dev pointer cached in the adapter private data (struct enic). But, this pointer is valid only in the primary process, as rte_eth_dev addresses may differ in different processes.

[dpdk-dev] [PATCH 2/3] net/enic: fix two issues in probe for secondary process

Only the primary process initializes the adapter private data and rte_eth_dev_data. For secondary processes, do not touch them. Secondary processes need to select the right Tx and Rx handlers. Pick the same handlers that the primary process uses. Fixes: fefed3d1e62c ("enic: new driver") Cc: sta..

[dpdk-dev] [PATCH 1/3] net/enic: restrict several handlers to primary process

These eth_dev_ops handlers should run only in the primary process. - filter_ctrl - reta_update - rss_hash_update - set_mc_addr_list - udp_tunnel_port_add - udp_tunnel_port_del Fixes: c2fec27b5cb0 ("net/enic: allow to change RSS settings") Fixes: 8d496995346c ("net/enic: support multicast filtering

[dpdk-dev] [PATCH 0/3] net/enic: fix multi-process isseus

This series fixes a few multi-process issues, mainly discovered by Dirk-Holger Lenz. They manifest clearly when primary and secondary processes use different executable images (hence different rte_eth_dev addresses and so on). Dirk has tested this series, and his app works fine. Below is the origi

Re: [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of hns3 PMD driver

Hi, Ferruh Yigit On 2019/8/30 23:02, Ferruh Yigit wrote: > On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: >> This patch adds support for cmd of hns3 PMD driver, driver can interact >> with firmware through command to complete hardware configuration. >> >> Signed-off-by: Hao Chen >> Signed-off-by:

[dpdk-dev] [PATCH] net/bnxt: fix memory barriers

As there is an inclusive rte_io_wmb within the following rte_write32() API who rings the doorbell, this makes the above rte_wmb unecessary and remove it. The doorbell ringing operation requires a rte_io_wmb immediately to make it complete and visible to the device. To read the doorbell response,

Re: [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver

Hi, Ferruh Yigit On 2019/8/30 23:01, Ferruh Yigit wrote: > On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: >> This patch registers hns3 PMD driver and adds the definition for log >> interfaces. >> >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Min Hu (Connor)

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

Hi Shally, Arek, I still think it's a bit too early to take a decision on this. 'xform' is being used for symmetric operations as well. Everywhere, 'xform' is treated as an input argument to PMD ops. Making this change will define 'xform' in a different way, and that will be applicable only for

[dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite

From: Amit Gupta hash_readwrite_lf test always getting TIMEOUT as required time to finish this test was much longer compare to time required for fast tests(10s). Hence, the test is being moved to perf test category for its execution to complete. Signed-off-by: Amit Gupta --- app/test/meson.bui

[dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests

From: Amit Gupta hash_readwrite meson test was taking longer time to complete. The test always get TIMEOUT, hence test is split into functional and perf test. perf test is being moved under dpdk perf testsuites in meson build. Signed-off-by: Amit Gupta --- app/test/meson.build | 3

[dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure

From: Amit Gupta V1 changes: * hash_readwrite and hash_readwrite lockfree meson test was taking longer time to complete. The test always get TIMEOUT. * hash readwrtie test is split into functional and perf tests and moved to dpdk fast and perf testsuite accordingly. * hash readwrite lockfree is

[dpdk-dev] [PATCH] net/octeontx2: add tx desc status dev ops

From: Kiran Kumar K Adding support for tx descriptor status dev ops for octeontx2. Signed-off-by: Kiran Kumar K --- doc/guides/nics/features/octeontx2.ini | 1 + drivers/net/octeontx2/otx2_ethdev.c | 1 + drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_ethdev_

Re: [dpdk-dev] [v8] net/e1000: fix i219 hang on reset/close

Hi Gavin, > -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Thursday, September 5, 2019 2:07 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei ; > Ye, Xiaolong ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [v8] net/e1000: fix i219

[dpdk-dev] [dpdk-dev 11/12] net/ice: add FDIR counter support for flow shared

Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index a2da40f85..b226ea6d2 100644 --- a/drivers/net/ice/ice_fdir_filter.c +++

[dpdk-dev] [dpdk-dev 10/12] net/ice: add FDIR counter support for flow id

FDIR statistical counter support hits by default. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 7 ++ drivers/net/ice/ice_fdir_filter.c | 147 +- 2 files changed, 152 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.h b/drive

[dpdk-dev] [dpdk-dev 08/12] net/ice: add FDIR dst mac support

Enable FDIR ethernet destination address field matching support Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c i

[dpdk-dev] [dpdk-dev 07/12] net/ice: enable FDIR queue group

FDIR can send packet to a group of queues and distruibte it by RSS. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index df4

[dpdk-dev] [dpdk-dev 09/12] net/ice: add FDIR counter resource init/release

This patch will alloc counter pool at dev init and release counter pool at dev close. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 33 +++ drivers/net/ice/ice_fdir_filter.c | 92 +++ 2 files changed, 125 insertions(+) diff --git a/drivers/

[dpdk-dev] [dpdk-dev 12/12] net/ice: add FDIR non-word aligned field support

Add IPV4 TOS, TTL and Protocol fields support. Add IPV6 version of TOS, TTL and Protocol fields support. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/driver

[dpdk-dev] [dpdk-dev 06/12] net/ice: add hash table for FDIR

Enable quick lookup for existing flow director rule entry. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_ethdev.h | 17 +++ drivers/net/ice/ice_fdir_filter.c | 186 -- 2 files changed, 196 insertions(+), 7 deletions(-) diff --git a/drivers/net/ice/ice_ethdev

[dpdk-dev] [dpdk-dev 04/12] net/ice: add FDIR create and destroy

Add ice_create_fdir_filter to create a rule. If a flow is matched by flow director filter, filter rule will be set to HW. Only basic pattern and queue/passthru/drop are supported. Add ice_destroy_fdir_filter to destroy a rule. If a flow is created before, filter rule will be removed from HW. Sign

[dpdk-dev] [dpdk-dev 03/12] net/ice: enable input set configuration

From: Beilei Xing Configure input set, include: - Parse input set. - Check the segment. - Create profile. Signed-off-by: Beilei Xing --- drivers/net/ice/ice_ethdev.h | 3 + drivers/net/ice/ice_fdir_filter.c | 245 ++ 2 files changed, 248 insertions(+) dif

[dpdk-dev] [dpdk-dev 05/12] net/ice: add FDIR mark action support

FDIR will add mark id in the packet mbuf when flow rule hits. Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 98bc1be49..294678075 1006

[dpdk-dev] [dpdk-dev 01/12] net/ice: initialize and set up flow director

From: Beilei Xing Enable flow director, include: - Create control VSI - Queue pair allocated and set up - Programming packet Signed-off-by: Beilei Xing --- drivers/net/ice/Makefile | 1 + drivers/net/ice/ice_ethdev.c | 107 +-- drivers/net/ice/ice_ethdev.h | 19 ++

[dpdk-dev] [dpdk-dev 02/12] net/ice: tear down flow director

From: Beilei Xing Release resources on flow director, include: - Release queue. - Release VSI. Signed-off-by: Beilei Xing --- drivers/net/ice/ice_fdir_filter.c | 40 ++ drivers/net/ice/ice_rxtx.c| 57 +++ drivers/net/ice/ice_rxtx.h

[dpdk-dev] [dpdk-dev 00/12] net/ice: add ice Flow Director driver

This patch series adds Intel Columbiaville 800 Series Ethernet Flow Director support for RTE_FLOW - Patch 01-03 are FDIR init,teardown and configuration - Remaining patches are FDIR RTE_FLOW enablement The patchset depends on: http://patchwork.dpdk.org/project/dpdk/list/?series=6228 --- Beilei Xi

[dpdk-dev] [PATCH v2] net/iavf: fix multi-queue Rx interrupt for VF

The original issue was that the last queue could not be mapped to the interrupt vector, so the last queue could not receive the package in the interrupt mode. This patch fixes the issue. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Cc: sta...@dpdk.org Signed-off-by: Lunyuan Cui --- driv

[dpdk-dev] [PATCH 4/4] net/ifcvf: enable mutliqueue support

Enable mutliqueue support for ifcvf devices by setting the mutliqueue configuration space. Signed-off-by: Xiaolong Ye Signed-off-by: Andy Pei --- drivers/net/ifc/base/ifcvf.c | 8 drivers/net/ifc/base/ifcvf.h | 5 - drivers/net/ifc/ifcvf_vdpa.c | 31 +-

[dpdk-dev] [PATCH 3/4] vhost: call vDPA callback at the end of vring enable handler

vDPA's set_vring_state callback would need to know the virtqueues' enable status to configure the hardware. Signed-off-by: Xiaolong Ye Signed-off-by: Andy Pei --- lib/librte_vhost/rte_vdpa.h | 4 ++-- lib/librte_vhost/vhost_user.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) d

[dpdk-dev] [PATCH 1/4] vhost: introduce new API to get the active vring number

It's useful for hardware vhost backend (like vDPA devices) to set multiqueue configuration accordingly. Signed-off-by: Xiaolong Ye Signed-off-by: Andy Pei --- lib/librte_vhost/rte_vhost.h | 12 lib/librte_vhost/vhost.c | 19 +++ 2 files changed, 31 insertions(+)

[dpdk-dev] [PATCH 2/4] net/ifcvf: add multiqueue configuration

This is in preparation for multiqueue enabling for vDPA devices. Signed-off-by: Xiaolong Ye Signed-off-by: Andy Pei --- drivers/net/ifc/base/ifcvf.c | 1 + drivers/net/ifc/base/ifcvf.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/ifc/base/ifcvf.c b/drivers/net/ifc/base/ifc

[dpdk-dev] [PATCH v2] net/iavf: enable AVX2 for iavf

This patch enables AVX data path for iavf PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/Makefile | 21 + drivers/net/iavf/iavf_rxtx.c| 99 +-- drivers/net/iavf/iavf_rxtx.h| 12 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 867

Re: [dpdk-dev] [RFC] ethdev: support hairpin queue

Hi, Ori Thanks for the explanation. I have more question below. Thanks Jingjing > -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Thursday, September 5, 2019 1:45 PM > To: Wu, Jingjing ; Thomas Monjalon > ; > Yigit, Ferruh ; arybche...@solarflare.com; Shahaf > Sh

[dpdk-dev] [PATCH v2 4/4] examples/ntb: support more functions for NTB

Support to transmit files between two systems. Support iofwd between one ethdev and NTB device. Support rxonly and txonly for NTB device. Support to set forwarding mode as file-trans, txonly, rxonly or iofwd. Support to show/clear port stats and throughput. Signed-off-by: Xiaoyun Li --- doc/guid

[dpdk-dev] [PATCH v2 3/4] raw/ntb: add enqueue and dequeue functions

Introduce enqueue and dequeue functions to support packet based processing. And enable write-combining for ntb driver since it can improve the performance a lot. Signed-off-by: Xiaoyun Li --- doc/guides/rawdevs/ntb.rst | 28 drivers/raw/ntb/ntb.c | 242

[dpdk-dev] [PATCH v2 2/4] raw/ntb: add xstats support

Add xstats support for ntb rawdev. Support tx-packets, tx-bytes, tx-errors and rx-packets, rx-bytes, rx-missed. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb/ntb.c | 135 -- drivers/raw/ntb/ntb.h | 11 2 files changed, 128 insertions(+), 18 deletions

[dpdk-dev] [PATCH v2 1/4] raw/ntb: setup ntb queue

Setup and init ntb txq and rxq. And negotiate queue information with the peer. If queue size and number of queues are not consistent on both sides, return error. Signed-off-by: Xiaoyun Li --- doc/guides/rawdevs/ntb.rst | 39 +- doc/guides/rel_notes/release_19_11.rst | 4 + drivers

[dpdk-dev] [PATCH v2 0/4] enable FIFO for NTB

Enable FIFO for NTB rawdev driver to support packet based processing. And an example is provided to support txonly, rxonly, iofwd between NTB device and ethdev, and file transmission. Xiaoyun Li (4): raw/ntb: setup ntb queue raw/ntb: add xstats support raw/ntb: add enqueue and dequeue functi

[dpdk-dev] [PATCH] app/testpmd: fix Segment fault when start fwd

This patch fixed the reset function to avoid crash when user don't call port reset , port stop and port start functions as sequence. Fixes: 97f1e19679 ("app/testpmd: add port reset command") Cc: sta...@dpdk.org Signed-off-by: Wang ShougangX --- app/test-pmd/testpmd.c | 6 ++ 1 file changed,

Re: [dpdk-dev] [PATCH v1 02/14] vhost: add burst enqueue function for packed ring

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Thursday, September 05, 2019 6:31 PM > To: Liu, Yong ; Bie, Tiwei ; > maxime.coque...@redhat.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 02/14] vhost: add burst enqueue function > for packed ring

Re: [dpdk-dev] [PATCH 4/4] examples/ntb: support more functions for NTB

Sure. Thanks for reminding. Will fix it in v2. > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Thursday, September 5, 2019 21:57 > To: Li, Xiaoyun > Cc: dev@dpdk.org > Subject: re: [dpdk-dev] [PATCH 4/4] examples/ntb: support more functions for > NTB > > >

[dpdk-dev] [PATCH] net/octeontx2: use updated LB ltypes

From: Vivek Sharma Update LB ltypes and use the updated ones so as replace LB_STAG and LB_QINQ by single LB_STAG_QINQ ltype. Signed-off-by: Vivek Sharma --- drivers/common/octeontx2/hw/otx2_npc.h | 9 +++-- drivers/net/octeontx2/otx2_flow_parse.c | 4 ++-- drivers/net/octeontx2/otx2_loo

[dpdk-dev] [PATCH 2/2] doc: remove comments about deprecated fdir in enic guide

The legacy filter API "flow director" has been superseded by rte_flow since 2017. Remove comments in the enic guide regarding the deprecated feature. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- doc/guides/nics/enic.rst | 33 +++-- 1 file changed, 7 inse

[dpdk-dev] [PATCH 1/2] net/enic: add PCI ID for new virtual function

Probe for the PCI ID of a new mode of VF which will be added to VIC adapter firmware. When fully implemented, the new mode will operate independent of the Cisco Virtual Machine Fabric Extender (VM-FEX) and will not need to be provisioned through libvirt. The new mode is dubbed "Standalone vNic" mod

Re: [dpdk-dev] [RFC 0/3] RCU integration with hash library

>-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dharmik Thakkar >Sent: Saturday, August 31, 2019 11:58 PM >Cc: dev@dpdk.org; honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; Dharmik >Thakkar >Subject: [dpdk-dev] [RFC 0/3] RCU integration with hash library > >T

Re: [dpdk-dev] [PATCH] net/af_xdp: support pinning of IRQs

On 09/04, Ciara Loftus wrote: >Network devices using the AF_XDP PMD will trigger interrupts >on reception of packets. The new PMD argument 'queue_irq' >allows the user to specify a core on which to pin interrupts >for a given queue. Multiple queue_irq arguments can be specified. >For example: > >

Re: [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool'

On Thu, 5 Sep 2019 20:10:05 + Dharmik Thakkar wrote: > > On Sep 5, 2019, at 10:26 AM, Stephen Hemminger > > wrote: > > > > On Sun, 1 Sep 2019 06:58:08 + > > Dharmik Thakkar wrote: > > > >> Compilation issue arises due to multiple definitions of 'bool' > >> in 'ixgbe_ethdev.h'. > >

Re: [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool'

> On Sep 5, 2019, at 10:26 AM, Stephen Hemminger > wrote: > > On Sun, 1 Sep 2019 06:58:08 + > Dharmik Thakkar wrote: > >> Compilation issue arises due to multiple definitions of 'bool' >> in 'ixgbe_ethdev.h'. >> (Please note that this issue showed up when 'rte_rcu_qsbr.h' got included >

Re: [dpdk-dev] [RFC] hash: introduce resizable hash list

>-Original Message- >From: Bing Zhao [mailto:bi...@mellanox.com] >Sent: Tuesday, August 27, 2019 11:52 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; bi...@mellanox.com >Subject: [RFC] hash: introduce resizable hash list > >In the

Re: [dpdk-dev] [PATCH 0/4] enable FIFO for NTB

Acked-by: Omkar Maslekar -Original Message- From: Li, Xiaoyun Sent: Wednesday, September 4, 2019 10:39 PM To: Wu, Jingjing ; Wiles, Keith ; Maslekar, Omkar ; Liang, Cunming Cc: dev@dpdk.org; Li, Xiaoyun Subject: [PATCH 0/4] enable FIFO for NTB Enable FIFO for NTB rawdev driver to su

[dpdk-dev] [PATCH 3/3] net/atlantic: add FW mailbox guard mutex

From: Pavel Belous Driver uses the Firmware mailbox to read statistics and configure some features. This patch introduces a mutex to provide consistent access to the FW mailbox to prevent potential data corruption. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations") Signed-off-b

[dpdk-dev] [PATCH 2/3] net/atlantic: fix reported flow control mode

From: Pavel Belous Driver reports current flow control mode based on internal flow control settings. Currently this logic works incorrectly. Fixes: 921eb6b8ce31 ("net/atlantic: fix flow control by sync settings on Rx") Cc: sta...@dpdk.org Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh

[dpdk-dev] [PATCH 0/3] net/atlantic: Atlantic PMD updates

From: Pavel Belous This patchset provides the various fixes for Atlantic Driver. Pavel Belous (3): net/atlantic: exclude MACSEC counters from xstats net/atlantic: fix reported flow control mode net/atlantic: add FW mailbox guard mutex drivers/net/atlantic/atl_ethdev.c | 60

[dpdk-dev] [PATCH 1/3] net/atlantic: exclude MACSEC counters from xstats

From: Pavel Belous Currently, driver always return full set of xstats counters, including MACSEC counters. But this driver also supports AQC100 chips, which does not have MACSEC feature. This fix adds checking for MACSEC availability (based on FW capability bits) and returns xstats without MACSEC

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

On Thu, 5 Sep 2019 19:49:09 +0300 Andrew Rybchenko wrote: > On 9/5/19 7:40 PM, Stephen Hemminger wrote: > > On Thu, 5 Sep 2019 17:10:40 +0100 > > Andrew Rybchenko wrote: > > > >> From: Ivan Ilchenko > >> > >> rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > >> value was cha

Re: [dpdk-dev] [PATCH] ethdev: fix typos for ENOTSUP

On 9/4/2019 3:59 PM, Stephen Hemminger wrote: > On Wed, 4 Sep 2019 22:05:31 +0800 > Xiaolong Ye wrote: > >> Fixes: af75078fece3 ("first public release") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Xiaolong Ye >> --- >> lib/librte_ethdev/rte_ethdev.h | 8 >> 1 file changed, 4 insertion

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

On 9/5/19 7:40 PM, Stephen Hemminger wrote: On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/failsafe ac

Re: [dpdk-dev] [EXT] [PATCH 07/10] compress/octeontx: fix global variable multiple definitions

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 5, 2019 8:53 PM > To: Ashish Gupta ; Fiona Trahe > ; Pablo de Lara > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [EXT] [PATCH 07/10] compress/octeontx: fix global variable multiple > definitions > > External Email

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across net/failsafe according to new return type. > > Try

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

On 9/5/19 7:36 PM, Stephen Hemminger wrote: On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: + if (ret != 0) { + ERROR("Failed to apply promiscuous mode"); + return ret; + } Just return the error as normal and le

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

On Thu, 5 Sep 2019 17:10:40 +0100 Andrew Rybchenko wrote: > + if (ret != 0) { > + ERROR("Failed to apply promiscuous mode"); > + return ret; > + } Just return the error as normal and let caller deal with it. Additional logging is no

Re: [dpdk-dev] [PATCH 18/28] drivers/virtio_vhost_user: add virtio PCI framework

Hi Nikos, On 6/19/19 5:14 PM, Nikos Dragazis wrote: > The virtio-vhost-user transport requires a driver for the > virtio-vhost-user PCI device, hence it needs a virtio-pci driver. There > is currently no librte_virtio API that we can use. > > This commit is a hack that duplicates the virtio pci

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

On 9/5/19 7:25 PM, Gaëtan Rivet wrote: Hi, On Thu, Sep 05, 2019 at 05:10:40PM +0100, Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/fails

Re: [dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

Hi, On Thu, Sep 05, 2019 at 05:10:40PM +0100, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across net/failsafe according to new return type

Re: [dpdk-dev] [PATCH] maintainers: update stable maintainers

05/09/2019 18:21, Luca Boccassi: > On Thu, 2019-09-05 at 16:49 +0100, Kevin Traynor wrote: > > Yuanhan is no longer maintaining DPDK stable. > > > > Add myself as a stable maintainer. > > > > Signed-off-by: Kevin Traynor > > Acked-by: Luca Boccassi Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH] maintainers: update stable maintainers

On Thu, 2019-09-05 at 16:49 +0100, Kevin Traynor wrote: > Yuanhan is no longer maintaining DPDK stable. > > Add myself as a stable maintainer. > > Signed-off-by: Kevin Traynor < > ktray...@redhat.com > > > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Luca

[dpdk-dev] [PATCH 12/13] test/bonding: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across test/bonding according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/t

[dpdk-dev] [PATCH 13/13] examples: take promiscuous mode switch result into account

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across examples according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/bbdev

[dpdk-dev] [PATCH 11/13] kni: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so modify usage of these functions across lib/librte_kni according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_kni.c

[dpdk-dev] [PATCH 10/13] app/test: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across app/test/test_event_eth_rx_adapter.c and app/test/test_event_eth_tx_adapter.c according to new return type. Signed-off-by

[dpdk-dev] [PATCH 04/13] ethdev: change promiscuous callbacks to return status

Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. Signed-off-by: Andrew Rybchenko --- app/test/virtual_pmd.c| 12 -

[dpdk-dev] [PATCH 01/13] ethdev: change promiscuous mode controllers to return errors

From: Ivan Ilchenko Change rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value from void to int and return negative errno values in case of error conditions. Modify usage of these functions across the ethdev according to new return type. Signed-off-by: Ivan Ilchenko Signed-o

[dpdk-dev] [PATCH 09/13] app/pdump: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across app/pdump according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/pdump/mai

[dpdk-dev] [PATCH 08/13] app/eventdev: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across app/eventdev according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-e

[dpdk-dev] [PATCH 07/13] app/testpmd: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across app/testpmd according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pm

[dpdk-dev] [PATCH 06/13] app/pipeline: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across app/pipeline according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-p

[dpdk-dev] [PATCH 05/13] ethdev: do nothing if promiscuous mode is applied again

Since driver callbacks return status code now, there is no necessity to enable or disable promiscuous mode once again if it is already successfully enabled or disabled. Configuration restore at startup tries to ensure that configured promiscuous mode is applied and start will return error if it fa

[dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/failsafe according to new return type. Try to keep promiscuous mode consistent across all active devices in the case

[dpdk-dev] [PATCH 03/13] net/bonding: check code of promiscuous mode switch

From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across net/bonding according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net

[dpdk-dev] [PATCH 00/13] ethdev: change promiscuous mode functions to return status

It is the second patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of the first one [2]. It could be applied separately, but few simple conflicts should be resolved. Functions which return void are bad since they d

Re: [dpdk-dev] [PATCH 06/10] net/dpaa2: fix possible use of uninitialized vars

On 9/5/19 4:10 PM, Hemant Agrawal wrote: > Hi Andrzei, > >> -Original Message- > >> diff --git a/drivers/net/dpaa2/mc/dpni.c b/drivers/net/dpaa2/mc/dpni.c >> index 362cd476f..b74a1a317 100644 >> --- a/drivers/net/dpaa2/mc/dpni.c >> +++ b/drivers/net/dpaa2/mc/dpni.c >> @@ -1803,10 +1803,13

[dpdk-dev] [PATCH] test/meson: hash lf test moved to dpdk perf testsuite

From: Amit Gupta hash_readwrite_lf test always getting TIMEOUT as required time to finish this test was much longer compare to time required for fast tests(10s). Hence, the test is being moved to perf test category for execution to complete. Change-Id: I64ae14a5ecfbea466d8a057c070579c0794a7377 S

[dpdk-dev] [PATCH] maintainers: update stable maintainers

Yuanhan is no longer maintaining DPDK stable. Add myself as a stable maintainer. Signed-off-by: Kevin Traynor --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 410026086..b3b05fd80 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6

[dpdk-dev] [PATCH 2/2] test/meson: hash test split into shorter subtests

From: Amit Gupta hash_readwrite meson test was taking longer time to complete. The test always get TIMEOUT, hence test is splitted into functional and perf test. perf test is being moved under dpdk perf testsuites in meson build. Signed-off-by: Amit Gupta --- app/test/meson.build |

[dpdk-dev] [PATCH 1/2] version: 19.11-rc0

From: David Marchand Start a new release cycle with empty release notes. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- VERSION| 2 +- doc/guides/rel_notes/index.rst | 1 + doc/guides/rel_notes/release_19_11.rst | 216 ++

Re: [dpdk-dev] [PATCH 10/10] test: fix global variable multiple definitions

> > Multiple global variable are defined in multiple unit test files with same > name, but all unit test files are linked into single executable, which means > those variables share same storage which is not the intention, fixed by > making global variables 'static'. > > Issue has been detected

[dpdk-dev] [Bug 345] rte_hash returns invalid key if the number of entries is not a power of 2

https://bugs.dpdk.org/show_bug.cgi?id=345 Bug ID: 345 Summary: rte_hash returns invalid key if the number of entries is not a power of 2 Product: DPDK Version: 19.08 Hardware: All OS: All Status:

Re: [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool'

On Sun, 1 Sep 2019 06:58:08 + Dharmik Thakkar wrote: > Compilation issue arises due to multiple definitions of 'bool' > in 'ixgbe_ethdev.h'. > (Please note that this issue showed up when 'rte_rcu_qsbr.h' got included > within 'rte_hash.h', because 'rte_rcu_qsbr.h' includes 'stdbool.h'. This

Re: [dpdk-dev] [PATCH 09/10] app/test-pipeline: fix global variable multiple definitions

On 9/5/2019 4:01 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, September 5, 2019 3:53 PM >> To: Dumitrescu, Cristian >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: [PATCH 09/10] app/test-pipeline: fix global variable multiple >> def

Re: [dpdk-dev] [PATCH v2] net/af_xdp: enable support for unaligned umem chunks

Hi, Ciara On 09/05, Ciara Loftus wrote: >This patch enables the unaligned chunks feature for AF_XDP which allows >chunks to be placed at arbitrary places in the umem, as opposed to them >being required to be aligned to 2k. This allows for DPDK application >mempools to be mapped directly into the u

[dpdk-dev] [PATCH 7/7] test/crypto: support wireless algos for dpaa2_sec

SNOW and ZUC plain crypto operations for cipher only and auth only are now supported in dpaa2_sec. Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_crypt

[dpdk-dev] [PATCH 6/7] test/crypto: Add PDCP cases for scatter gather bufs

Test cases for PDCP with scattered input and output buffers are added for both inplace and out of place scenarios. 1. input SG - output non SG 2. input and output both SG and inplace buffers 3. input and output both SG with different segment sizes 4. input SG and output non-SG Signed-off-by: Akhil

[dpdk-dev] [PATCH 5/7] test/crypto: Add PDCP uplane decap cases

This patch add test cases for user plane PDCP 5/7/12/15/18 bit SN test cases for decapsulation of cipher only and 12/18 bit for cipher + integrity for all algo combinations. Test vectors are reused from the encap cases by swapping the input and output data. The case are added to DPAA_SEC and DPAA

[dpdk-dev] [PATCH 3/7] test/crypto: Add PDCP uplane encap cases

PDCP User/Data plane can support 5/7/12/15/18 bit sequence number. This patch add test cases and test vectors for all supported algos for cipher only. (NULL, AES, SNOW, ZUC ciphers) The test cases are added in DPAA_SEC and DPAA2_SEC test suite as a reference. Signed-off-by: Akhil Goyal Signed-of

[dpdk-dev] [PATCH 2/7] test/crypto: Add PDCP cplane decap cases

This patch add test cases for control plane PDCP 5 and 12 bit SN test cases for decapsulation of cipher+integrity for all algo combinations Test vectors are reused from the encap cases by swapping the input and output data. The case are added to DPAA_SEC and DPAA2_SEC testsuite. Signed-off-by: A

[dpdk-dev] [PATCH 1/7] test/crypto: Add PDCP cplane encap cases

PDCP control plane can support 5 bit and 12 bit sequence number. This patch add test cases and test vectors for all supported algo combinations of cipher+integrity (NULL+NULL, NULL+AES, NULL+SNOW, NULL+ZUC, AES+NULL, AES+SNOW, AES+AES, AES+ZUC, SNOW+NULL, SNOW+AES, SNOW+SNOW, SNOW+ZUC, ZUC+NU

[dpdk-dev] [PATCH 0/7] Add PDCP test cases

This patch add test vectors and a test framework for PDCP cplane and uplane protocol processing based on various sequence number sizes(5/7/12/15/18). These test cases and test vectors are validated over NXP DPAA_SEC and DPAA2_SEC platforms. This patchset is a split to the patch [1] which was sent

Re: [dpdk-dev] [PATCH 09/10] app/test-pipeline: fix global variable multiple definitions

> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 5, 2019 3:53 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 09/10] app/test-pipeline: fix global variable multiple > definitions > > 'app' global variable is defined in multiple

[dpdk-dev] [PATCH 10/10] test: fix global variable multiple definitions

Multiple global variable are defined in multiple unit test files with same name, but all unit test files are linked into single executable, which means those variables share same storage which is not the intention, fixed by making global variables 'static'. Issue has been detected by '-fno-common'

  1   2   >