On Thu, 5 Sep 2019 19:49:09 +0300 Andrew Rybchenko <arybche...@solarflare.com> wrote:
> On 9/5/19 7:40 PM, Stephen Hemminger wrote: > > On Thu, 5 Sep 2019 17:10:40 +0100 > > Andrew Rybchenko <arybche...@solarflare.com> wrote: > > > >> From: Ivan Ilchenko <ivan.ilche...@oktetlabs.ru> > >> > >> rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > >> value was changed from void to int, so this patch modify usage > >> of these functions across net/failsafe according to new return type. > >> > >> Try to keep promiscuous mode consistent across all active > >> devices in the case of failure. > >> > >> Signed-off-by: Ivan Ilchenko <ivan.ilche...@oktetlabs.ru> > >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> > > In reality, failsafe's promiscious mode is actually a lie. > > The only common use case of failsafe is on Azure/Hyper-V and in a guest > > setting promiscuous is not allowed. That is why there is no promiscuous > > setting in netvsc PMD. I forgot Hyper-V is not same as Azure. It will always fail on Azure, but will work be allowed on Hyper-V (if enabled on host).
