[dpdk-dev] [PATCH v4 2/2] ethdev: add PPPoE to flow API

2019-08-27 Thread Wang Ying A
- RTE_FLOW_ITEM_TYPE_PPPOES: matches a PPPoE session header. - RTE_FLOW_ITEM_TYPE_PPPOED: matches a PPPoE discovery header. - RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: matches a PPPoE session protocol identifier. Signed-off-by: Wang Ying A --- app/test-pmd/cmdline_flow.c | 57 ++

[dpdk-dev] [PATCH v4 0/2] add GTP/PPPoE to flow API

2019-08-27 Thread Wang Ying A
patch 1/2: Add GTP extension header to flow API. patch 2/2: Add PPPoE to flow API. --- v4: Fix PPPoE testpmd cmdline issue. v3: Split original patch, one for GTP and the other for PPPoE. Add RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID for PPPoE session packets. v2: Remove Gerrit Change-Id's. --- Wang Y

[dpdk-dev] [PATCH v4 1/2] ethdev: add GTP extension header to flow API

2019-08-27 Thread Wang Ying A
- RTE_FLOW_ITEM_TYPE_GTP_PSC: matches a GTP PDU extension header (PDU session container). Signed-off-by: Wang Ying A --- app/test-pmd/cmdline_flow.c | 36 + doc/guides/prog_guide/rte_flow.rst | 9 doc/guides/testpmd_app_ug/testpmd_

Re: [dpdk-dev] [PATCH] doc/compressdev: clarify that structs should be zeroed before use

2019-08-27 Thread Shally Verma
> -Original Message- > From: Fiona Trahe > Sent: Tuesday, August 27, 2019 10:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Shally > Verma ; Fiona Trahe > Subject: [PATCH] doc/compressdev: clarify that structs should be zeroed > before use > > Some structs used on

[dpdk-dev] Arm's roadmap for 19.11

2019-08-27 Thread Honnappa Nagarahalli
Hello, Following are the work items planned for 19.11 release: 1) Integrate WFE/SEV instructions in spinlock and ring library 2) Add support for lock-free stack mempool handler 3) Integrate LPM and Hash libraries with RCU 4) Enable lock-free data path algorithms in L3-Fwd application 5) Te

[dpdk-dev] [PATCH v6] eal: add tsc_hz to rte_mem_config

2019-08-27 Thread Jim Harris
This ensures secondary processes never have to calculate the TSC rate themselves, which can be noticeable in VMs that don't have access to arch-specific detection mechanism (such as CPUID leaf 0x15 or MSR 0xCE on x86). Since rte_mem_config is now internal to the rte_eal library, we can add tsc_hz

[dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug

2019-08-27 Thread Gage Eads
The sw PMD implements xstats reset by having the xstat get operations return a value to the statistic's value at the last reset. The value at the last reset is maintained in the per-xstat reset_value field, but the PMD was setting reset_value = current - reset_value instead of reset_value = current

Re: [dpdk-dev] [PATCH 00/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-08-27 Thread Aaron Conole
Andrew Rybchenko writes: > It is the first patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. This is a huge series, and I suggest to combine some of the work, and/or break it up. Additionally, this patch breaks the ring_pmd_autotest unit

Re: [dpdk-dev] [PATCH 13/51] net/netvsc: check status of getting ethdev info

2019-08-27 Thread Stephen Hemminger
On Tue, 27 Aug 2019 15:25:24 +0100 Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_dev_info_get() return value was changed from void to int, > so this patch modify rte_eth_dev_info_get() usage across > net/netvsc according to its new return type. > > Signed-off-by: Ivan Ilchenko > S

Re: [dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail.

2019-08-27 Thread Stephen Hemminger
On Wed, 28 Aug 2019 01:00:16 +0530 Nitin Katiyar wrote: > Even if whitelist of devices is provided, rte_pci_probe() increments > the probed counter for all the devices present in the system. If probe > fails for all the whitelisted devices it still return success because > failed and probed count

[dpdk-dev] [PATCH] net/szedata2: remove resources when port is closed

2019-08-27 Thread Rastislav Cernay
From: Rastislav Cernay The rte_eth_dev_close() function now handles freeing resources for devices (e.g., mac_addrs). To conform with the new close() behaviour we are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that rte_eth_dev_close() releases all device level dynamic memory. Signed-off-by:

[dpdk-dev] [PATCH v3] net/nfb: remove resources when port is closed

2019-08-27 Thread Rastislav Cernay
From: Rastislav Cernay The rte_eth_dev_close() function now handles freeing resources for devices (e.g., mac_addrs). To conform with the new close() behaviour we are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that rte_eth_dev_close() releases all device level dynamic memory. Signed-off-by:

[dpdk-dev] [RFC] Proposal to remove EXPERIMENTAL label from compressdev API

2019-08-27 Thread Trahe, Fiona
Hi all, Just putting it out there that the DPDK compressdev API has been available since 18.05, has had minimal change in recent releases and can be considered mature enough to have the experimental label removed. I'd like to make this change in the 19.11 release. Opinions? Regards, Fiona

[dpdk-dev] [PATCH] doc/compressdev: clarify that structs should be zeroed before use

2019-08-27 Thread Fiona Trahe
Some structs used on the API are zeroed on creation by API calls, (e.g. rte_comp_op), but a few are allocated in the application domain. Clarify that the application should zero those to enable future extensions without API breakage. Signed-off-by: Fiona Trahe --- doc/guides/prog_guide/compressd

[dpdk-dev] [PATCH] build: add dockerfile for building docker image

2019-08-27 Thread Abdul Halim
Adding a Dockerfile with Ubuntu bionic base image to build dpdk as shared library. This docker image could be used as base image to build and run dpdk applications in containers. Signed-off-by: Abdul Halim --- extras/Dockerfile.ubuntu | 38 ++ extras/README.md

[dpdk-dev] [PATCH v2] app/testpmd: remove duplicated support for Rx offloading

2019-08-27 Thread Flavia Musatescu
The testpmd application provides two sets of commands for RX offload flags configuration. The purpose of this patch is to eliminate this duplication by removing the old set of commands: “port config all crc-strip|scatter|rx-cksum|rx-timestamp|hw-vlan| hw-vlan-filter|hw-vlan-strip|hw-vlan-extend on|

Re: [dpdk-dev] [PATCH 02/13] net/bnxt: prevent device access when device is in reset

2019-08-27 Thread Ferruh Yigit
On 8/22/2019 6:53 AM, Ajit Khaparde wrote: > From: Kalesh AP > > Refactor init and uninit functions so that the driver can fail > the eth_dev_ops callbacks and accessing Tx and Rx queues > when device is in reset or in error state. > > Transmit and receive queues are freed during reset cleanup a

Re: [dpdk-dev] [PATCH 11/51] net/bnxt: check status of getting ethdev info

2019-08-27 Thread Somnath Kotur
On Tue, Aug 27, 2019 at 7:56 PM Andrew Rybchenko wrote: > > From: Ivan Ilchenko > > rte_eth_dev_info_get() return value was changed from void to int, so > this patch modify rte_eth_dev_info_get() usage across > net/bnxt according to its new return type. > > Signed-off-by: Ivan Ilchenko > Signed-

[dpdk-dev] [PATCH 51/51] examples/exception_path: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/exception_path according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/exception_path/mai

[dpdk-dev] [PATCH 50/51] examples/ethtool: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ethtool according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ethtool/ethtool-app/main.

[dpdk-dev] [PATCH 48/51] examples/load_balancer: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/load_balancer according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/load_balancer/init.

[dpdk-dev] [PATCH 49/51] examples/kni: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/kni according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/kni/main.c | 26 +

[dpdk-dev] [PATCH 46/51] examples/l2fwd-keepalive: check dev info get result

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l2fwd-keepalive according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l2fwd-keepalive/m

[dpdk-dev] [PATCH 45/51] examples/netmap_compat: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/netmap_compat according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/netmap_compat/lib/c

[dpdk-dev] [PATCH 47/51] examples/ip_pipeline: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ip_pipeline according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ip_pipeline/kni.c |

[dpdk-dev] [PATCH 44/51] examples/ipsec-secgw: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ipsec-secgw according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ipsec-secgw/ipsec-sec

[dpdk-dev] [PATCH 43/51] examples/multi_process: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/multi_process according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/multi_process/symme

[dpdk-dev] [PATCH 41/51] examples/packet_ordering: check dev info get result

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/packet_ordering according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/packet_ordering/m

[dpdk-dev] [PATCH 40/51] examples/flow_classify: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/flow_classify according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/flow_classify/flow_

[dpdk-dev] [PATCH 19/51] examples/performance-thread: check dev info get result

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/performance-thread according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/performance-th

[dpdk-dev] [PATCH 42/51] examples/l2fwd-crypto: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l2fwd-crypto according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l2fwd-crypto/main.c

[dpdk-dev] [PATCH 38/51] examples/tep_termination: check dev info get result

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/tep_termination according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/tep_termination/v

[dpdk-dev] [PATCH 39/51] examples/server_node_efd: check dev info get result

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/server_node_efd according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/server_node_efd/s

[dpdk-dev] [PATCH 36/51] examples/ptpclient: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ptpclient according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ptpclient/ptpclient.c |

[dpdk-dev] [PATCH 37/51] examples/link_status_interrupt: check dev info get result

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/link_status_interrupt according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/link_status

[dpdk-dev] [PATCH 35/51] examples/vhost: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vhost according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vhost/main.c | 9 -

[dpdk-dev] [PATCH 34/51] examples/ip_reassembly: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ip_reassembly according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ip_reassembly/main.

[dpdk-dev] [PATCH 33/51] examples/eventdev: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/eventdev according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/eventdev_pipeline/main.c

[dpdk-dev] [PATCH 31/51] examples/l2fwd-jobstats: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l2fwd-jobstats according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l2fwd-jobstats/mai

[dpdk-dev] [PATCH 32/51] examples/bond: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/bond according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/bond/main.c | 14 +++

[dpdk-dev] [PATCH 30/51] examples/ipv4_multicast: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ipv4_multicast according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ipv4_multicast/mai

[dpdk-dev] [PATCH 28/51] examples/skeleton: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/skeleton according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/skeleton/basicfwd.c | 8

[dpdk-dev] [PATCH 29/51] examples/vmdq_dcb: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vmdq_dcb according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vmdq_dcb/main.c | 18 +++

[dpdk-dev] [PATCH 27/51] examples/l2fwd: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l2fwd according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l2fwd/main.c | 8 +++-

[dpdk-dev] [PATCH 26/51] examples/l3fwd-power: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l3fwd-power according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l3fwd-power/main.c |

[dpdk-dev] [PATCH 24/51] examples/qos_sched: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/qos_sched according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/qos_sched/init.c | 8 ++

[dpdk-dev] [PATCH 25/51] examples/flow_filtering: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/flow_filtering according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/flow_filtering/mai

[dpdk-dev] [PATCH 23/51] examples/vm_power: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vm_power according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vm_power_manager/main.c

[dpdk-dev] [PATCH 22/51] examples/l3fwd-acl: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l3fwd-acl according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l3fwd-acl/main.c | 22 +

[dpdk-dev] [PATCH 20/51] examples/vmdq: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vmdq according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vmdq/main.c | 16 +++

[dpdk-dev] [PATCH 21/51] examples/distributor: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/distributor according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/distributor/main.c |

[dpdk-dev] [PATCH 01/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko Change rte_eth_dev_info_get() return value from void to int and return negative errno values in case of error conditions. Modify rte_eth_dev_info_get() usage across the ethdev according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- do

[dpdk-dev] [PATCH 14/51] net/softnic: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/softnic according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/softnic/rte_eth_softnic_lin

[dpdk-dev] [PATCH 18/51] examples/ip_frag: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ip_frag according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ip_fragmentation/main.c |

[dpdk-dev] [PATCH 12/51] net/bonding: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/bonding according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_api.c

[dpdk-dev] [PATCH 16/51] examples/l3fwd: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l3fwd according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l3fwd/main.c | 14 +

[dpdk-dev] [PATCH 13/51] net/netvsc: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/netvsc according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/netvsc/hn_vf.c | 10

[dpdk-dev] [PATCH 11/51] net/bnxt: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/bnxt according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/bnxt/rte_pmd_bnxt.c | 122

[dpdk-dev] [PATCH 10/51] app/test: check ethdev info get result in event Rx adapter

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_event_eth_rx_adapter.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_

[dpdk-dev] [PATCH 09/51] app/test: check status of getting ethdev info in bonding

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_link_bonding_rssconf.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_

[dpdk-dev] [PATCH 17/51] examples/qos_meter: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/qos_meter according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/qos_meter/main.c | 16 +

[dpdk-dev] [PATCH 15/51] examples/rxtx_callbacks: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/rxtx_callbacks according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/rxtx_callbacks/mai

[dpdk-dev] [PATCH 06/51] pdump: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across pdump component according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- lib/librte_pdump/rte_pdump.c | 9 ++

[dpdk-dev] [PATCH 04/51] kni: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_kni.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_kni.c | 27 ++

[dpdk-dev] [PATCH 03/51] app/eventdev: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test-eventdev according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-eventdev/test_perf_commo

[dpdk-dev] [PATCH 00/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-08-27 Thread Andrew Rybchenko
It is the first patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. The patch to change dev_infos_get callback prototype to allow driver return error will follow. [1] https://patches.dpdk.org/patch/56969/ Ivan Ilchenko (51): ethdev: change r

[dpdk-dev] [PATCH 08/51] app/procinfo: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/procinfo according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/proc-info/main.c | 15

[dpdk-dev] [PATCH 05/51] latency: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across latency component according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- lib/librte_latencystats/rte_laten

[dpdk-dev] [PATCH 07/51] ring: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_pmd_ring.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_pmd_ring.c |

[dpdk-dev] [PATCH 02/51] app/testpmd: check status of getting ethdev info

2019-08-27 Thread Andrew Rybchenko
From: Ivan Ilchenko Add eth_dev_info_get_print_err() which is a wrapper for rte_eth_dev_info_get() printing error if rte_eth_dev_info_get() fails and returning its status code. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 119 +

Re: [dpdk-dev] [PATCH v2 0/2] add abi version testing to app/test

2019-08-27 Thread Ray Kinsella
On 27/08/2019 09:28, Ray Kinsella wrote: > > > On 27/08/2019 09:17, Bruce Richardson wrote: >> On Mon, Aug 26, 2019 at 05:45:55PM +0100, Ray Kinsella wrote: >>> >>> >>> On 23/08/2019 16:49, Aaron Conole wrote: Ray Kinsella writes: > This patchset adds ABI version testing to the

Re: [dpdk-dev] [PATCH v5] eal: use memzone to share tsc hz with secondary processes

2019-08-27 Thread Bruce Richardson
On Tue, Aug 27, 2019 at 01:04:18PM +0100, Burakov, Anatoly wrote: > On 26-Aug-19 2:44 PM, Jim Harris wrote: > > Ideally, get_tsc_freq_arch() is able to provide the > > TSC rate using arch-specific means. When that is not > > possible, DPDK reverts to calculating the TSC rate with > > a 100ms nanos

Re: [dpdk-dev] [PATCH 2/2] eal: DPDK init doesn't fail even if device probe fails.

2019-08-27 Thread Aaron Conole
Nitin Katiyar writes: > rte_bus_probe() doesn't return error. As a result rte_eal_init() > doesn't catch this error and thus making dpdk initialization > successful despite probe failing for devices. > > This patch returns error if probe fails for any of device. > > Signed-off-by: Nitin Katiyar

Re: [dpdk-dev] [PATCH 01/13] net/bnxt: hsi version update

2019-08-27 Thread Ferruh Yigit
On 8/22/2019 6:53 AM, Ajit Khaparde wrote: > From: Kalesh AP > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/hsi_struct_def_dpdk.h | 137 + > 1 file changed, 137 insertions(+) Hi Kalesh, As far as I can

Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add mbuf RSS update as an offload

2019-08-27 Thread Andrew Rybchenko
On 8/23/19 4:19 AM, Stephen Hemminger wrote: On Thu, 22 Aug 2019 02:17:50 +0530 wrote: From: Pavan Nikhilesh Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to enable/disable PMDs write to `rte_mbuf::hash::rss`. PMDs notify the validity of `rte_mbuf::hash:rss` to the appl

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_packet: fix for stale sockets

2019-08-27 Thread Ferruh Yigit
On 8/23/2019 4:28 PM, John W. Linville wrote: > On Thu, Aug 22, 2019 at 11:55:36AM +0530, Abhishek Sachan wrote: >> af_packet driver is leaving stale socket after device is removed. >> Ring buffers are memory mapped when device is added using rte_dev_probe. >> There is no corresponding munmap call

Re: [dpdk-dev] [PATCH] ethdev: fix endian annotation for spi item

2019-08-27 Thread Ferruh Yigit
On 8/23/2019 11:17 AM, Andrew Rybchenko wrote: > On 8/20/19 4:45 PM, David Marchand wrote: >> spi should be set with network endian values. >> While 0x == htonl(0x), this missing annotation is caught >> by sparse when compiling ovs (dpdk-latest branch). >> >> Fixes: d4b684f7197a ("n

Re: [dpdk-dev] [RFC] net/ena: use dynamic log type for debug logging

2019-08-27 Thread Michał Krawczyk
wt., 16 lip 2019 o 22:43 Stephen Hemminger napisał(a): > > The generic RTE_LOGTYPE_PMD is a historical relic and should > not be used. Every driver must use dynamic logtypes. > > Compile tested only! > > Signed-off-by: Stephen Hemminger Tested-by: Michal Krawczyk > --- > drivers/net/ena/base/e

Re: [dpdk-dev] [PATCH v5] eal: use memzone to share tsc hz with secondary processes

2019-08-27 Thread Bruce Richardson
On Tue, Aug 27, 2019 at 01:04:18PM +0100, Burakov, Anatoly wrote: > On 26-Aug-19 2:44 PM, Jim Harris wrote: > > Ideally, get_tsc_freq_arch() is able to provide the > > TSC rate using arch-specific means. When that is not > > possible, DPDK reverts to calculating the TSC rate with > > a 100ms nanos

Re: [dpdk-dev] [PATCH] ethdev: fix doc reference to FDIR disabled mode

2019-08-27 Thread Ferruh Yigit
On 8/18/2019 10:37 AM, Andrew Rybchenko wrote: > There is no RTE_FDIR_DISABLE. The right name is RTE_FDIR_MODE_NONE. > > Fixes: af75078fece3 ("first public release") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/mlx5: remove unneeded constant definition

2019-08-27 Thread Matan Azrad
From: Dekel Peled > Constant MLX5_GROUP_FACTOR is defined with value 1, and used to > multiply group value in two places. > > This patch removes the unneeded constant definition and use. > > Cc: sta...@dpdk.org > > Signed-off-by: Dekel Peled Acked-by: Matan Azrad

Re: [dpdk-dev] [PATCH v2] net/nfb: remove resources when port is closed

2019-08-27 Thread Ferruh Yigit
On 8/12/2019 12:19 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > The rte_eth_dev_close() function now handles freeing resources for > devices (e.g., mac_addrs). To conform with the new close() behaviour we > are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that > rte_eth_dev_close()

Re: [dpdk-dev] [PATCH v5] eal: use memzone to share tsc hz with secondary processes

2019-08-27 Thread Burakov, Anatoly
On 26-Aug-19 2:44 PM, Jim Harris wrote: Ideally, get_tsc_freq_arch() is able to provide the TSC rate using arch-specific means. When that is not possible, DPDK reverts to calculating the TSC rate with a 100ms nanosleep or 1s sleep. The latter occurs more frequently in VMs which often do not hav

[dpdk-dev] [PATCH v3 4/4] app/test: add unit tests for eal vfio

2019-08-27 Thread Chaitanya Babu Talluri
Unit test cases are added for eal vfio library. eal_vfio_autotest added to meson build file. Signed-off-by: Chaitanya Babu Talluri --- app/test/Makefile| 1 + app/test/meson.build | 2 + app/test/test_eal_vfio.c | 736 +++ 3 files changed, 739

[dpdk-dev] [PATCH v3 1/4] lib/eal: fix vfio unmap that fails unexpectedly

2019-08-27 Thread Chaitanya Babu Talluri
Unmap fails when there are duplicate entries in user_mem_maps. The fix is to validate if the input VA, IOVA exists or overlaps in user_mem_maps before creating map. Fixes: 73a63908 ("vfio: allow to map other memory regions") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/lib

[dpdk-dev] [PATCH v3 3/4] lib/eal: add API to check iommu type is set

2019-08-27 Thread Chaitanya Babu Talluri
Add rte_vfio_iommu_type_is_set() to check IOMMU type for default container. Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/common/include/rte_vfio.h | 10 ++ lib/librte_eal/linux/eal/eal_vfio.c | 16 2 files changed, 26 insertions(+) diff --git a/lib/libr

[dpdk-dev] [PATCH v3 2/4] lib/eal: fix vfio unmap that succeeds unexpectedly

2019-08-27 Thread Chaitanya Babu Talluri
Unmapping page with a VA that is found in the list of current mappings will succeed even if the IOVA for the chunk that is being unmapped,is mismatched. Fix it by checking if IOVA address matches the expected IOVA address exactly. Fixes: 73a6390859 ("vfio: allow to map other memory regions") Cc:

[dpdk-dev] [PATCH v3 0/4] add unit tests for eal vfio library

2019-08-27 Thread Chaitanya Babu Talluri
1/4: fix vfio unmap that fails unexpectedly 2/4: fix vfio unmap that succeeds unexpectedly 3/4: add API to check iommu type is set 4/4: add unit tests for eal vfio Patch 4/4 depends on 1/4,2/4,3/4 Signed-off-by: Chaitanya Babu Talluri --- v3: Added API to check iommu type. v2: Updated commit mes

Re: [dpdk-dev] [PATCH v2] net/pcap: propagate timestamp from pcap_pkthdr to mbuf

2019-08-27 Thread Ferruh Yigit
On 8/2/2019 9:57 AM, Sylvain Rodon wrote: > From: Sylvain Rodon > > Timestamp is always set in PCAP header, whether it reads a file or > listen on an interface. This information can be important for some > applications and it cannot be obtained otherwise (especially when > reading a PCAP file, wh

[dpdk-dev] [PATCH 2/2] eal: DPDK init doesn't fail even if device probe fails.

2019-08-27 Thread Nitin Katiyar
rte_bus_probe() doesn't return error. As a result rte_eal_init() doesn't catch this error and thus making dpdk initialization successful despite probe failing for devices. This patch returns error if probe fails for any of device. Signed-off-by: Nitin Katiyar --- lib/librte_eal/common/eal_commo

[dpdk-dev] [PATCH 1/2] bus/pci: Fail rte_pci_probe if probing all whitelisted devices fail.

2019-08-27 Thread Nitin Katiyar
Even if whitelist of devices is provided, rte_pci_probe() increments the probed counter for all the devices present in the system. If probe fails for all the whitelisted devices it still return success because failed and probed counts don't match. This patch increments probed count only when devic

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 devices

2019-08-27 Thread Jiang, JunyuX
Hi, > Could you elaborate more about the issue that this patch trying to solve? this issue is:start l3fwd-power with pf port0 bind to vfio-pci,there was no response when send packets to l3fwd-power in x552/x557. > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, August 27, 2019

[dpdk-dev] [PATCH] net/mlx5: remove unneeded constant definition

2019-08-27 Thread Dekel Peled
Constant MLX5_GROUP_FACTOR is defined with value 1, and used to multiply group value in two places. This patch removes the unneeded constant definition and use. Cc: sta...@dpdk.org Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_flow_dv.c | 5 ++---

[dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process

2019-08-27 Thread dirk
net/enic: enic driver doesn't work with 2nd process. the problem is that the private data structure enic uses pointers to rte_eth_dev and rte_pci_device which are overwritten when a 2nd process starts using this device. given patch removes these two pointers from the private data and uses the corre

[dpdk-dev] [PATCH 0/1] net/enic: enic driver doesn't work with 2nd process

2019-08-27 Thread dirk
dirk (1): net/enic: enic driver doesn't work with 2nd process. the problem is that the private data structure enic uses pointers to rte_eth_dev and rte_pci_device which are overwritten when a 2nd process starts using this device. given patch removes these two pointers from the private data

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: remove duplicated support for Rx offloading

2019-08-27 Thread Ferruh Yigit
On 8/5/2019 1:25 PM, Flavia Musatescu wrote: > The testpmd application provides two sets of commands for RX offload > flags configuration. The purpose of this patch is to eliminate this > duplication by removing the old set of commands: > “port config all crc-strip|scatter|rx-cksum|rx-timestamp|hw-

Re: [dpdk-dev] [PATCH] net/ark: implement dynamic log type

2019-08-27 Thread Ferruh Yigit
On 7/16/2019 7:55 PM, Stephen Hemminger wrote: > The generic RTE_LOGTYPE_PMD is a historical relic and should > will be deprecated in near future. Every driver must register its own logtype. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH 0/1] net/enic: enic driver doesn't work with 2nd process

2019-08-27 Thread dirk
dirk (1): net/enic: enic driver doesn't work with 2nd process. the problem is that the private data structure enic uses pointers to rte_eth_dev and rte_pci_device which are overwritten when a 2nd process starts using this device. given patch removes these two pointers from the private data

[dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process

2019-08-27 Thread dirk
Signed-off-by: dirk --- drivers/net/enic/enic.h | 36 --- drivers/net/enic/enic_clsf.c | 5 +- drivers/net/enic/enic_ethdev.c| 79 ++- drivers/net/enic/enic_main.c | 177 +++--- drivers/net/enic/enic_res.c

Re: [dpdk-dev] [PATCH v2 0/2] add abi version testing to app/test

2019-08-27 Thread Ray Kinsella
On 27/08/2019 09:17, Bruce Richardson wrote: > On Mon, Aug 26, 2019 at 05:45:55PM +0100, Ray Kinsella wrote: >> >> >> On 23/08/2019 16:49, Aaron Conole wrote: >>> Ray Kinsella writes: >>> This patchset adds ABI version testing to the app/test unit test framework, addressing two issues

  1   2   >