Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-24 Thread Anoob Joseph
Hi Shally, Please see inline. Thanks, Anoob > -Original Message- > From: Shally Verma > Sent: Thursday, July 25, 2019 10:52 AM > To: Anoob Joseph ; Ayuj Verma > ; akhil.go...@nxp.com > Cc: arkadiuszx.kusz...@intel.com; Sunila Sahu ; Kanaka > Durga Kotamarthy ; dev@dpdk.org; Fiona > Trahe

Re: [dpdk-dev] [PATCH v2] net/iavf: fix endless loop

2019-07-24 Thread Ye Xiaolong
On 07/25, Qi Zhang wrote: >Change loop index from uint16_t to uint32_t since max >index 65535 could be exceeded when ring size is 2k+. > >Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") >Cc: sta...@dpdk.org > >Reported-by: Lei Yao >Signed-off-by: Qi Zhang >--- >v2: >- add missing fix in

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Hemant Agrawal
HI Matan, > > On Wed, 24 Jul 2019 15:37:40 + > > Matan Azrad wrote: > > > > > Hi Hemant, Sachin > > > > > > Looks like issue in dpaa. > > > Please check. > > > > > > > -Original Message- > > > > From: dev On Behalf Of bugzi...@dpdk.org > > > > Sent: Wednesday, July 24, 2019 6:35 PM >

[dpdk-dev] [PATCH v2 1/1] examples/ip_frag: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag

2019-07-24 Thread Sunil Kumar Kori
Application uses different pool to allocate direct and indirect mbufs which are further spliced together to consturct a fragmented packet and same is transmitted over the port which is configured with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments must belong to the same pool. But construc

[dpdk-dev] [PATCH] examples/ip_fragmentation: fix DEV_TX_OFFLOAD_MBUF_FAST_FREE flag

2019-07-24 Thread Sunil Kumar Kori
Application uses different pool to allocate direct and indirect mbufs which are further spliced together to consturct a fragmented packet and same is transmitted over the port which is configured with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments must belong to the same pool. But construc

[dpdk-dev] [PATCH] net/octeontx2: fix handling indirect mbufs during TX

2019-07-24 Thread Sunil Kumar Kori
Multi segmented packet may be spliced with indirect mbufs also. Currently driver causes buffer leak for indirect mbufs as they were not being freed to packet pool. Patch fixes handling of indirect mbufs for following use cases: - packet contains all indirect mbufs only. - packet contains mixed mbu

[dpdk-dev] [PATCH 2/2] app/testpmd: add symmetric toeplitz hash support

2019-07-24 Thread simei
From: Simei Su This patch adds command line support for Symmetric Toeplitz hash configuration. Signed-off-by: Simei Su --- app/test-pmd/cmdline.c | 12 +--- app/test-pmd/cmdline_flow.c | 12 +++- doc/guides/testpmd_app_ug/testpmd_funcs.rst |

[dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support

2019-07-24 Thread simei
From: Simei Su Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. To support symmetric hash by rte_flow RSS action, this patch adds new hash function "Symmetric Toeplitz" which is supported by some hardware. Signed-off-by: Simei Su --- lib/librte_ethdev/rte_flow.h | 1 + 1 file

[dpdk-dev] [PATCH 0/2] add symmetric toeplitz hash support

2019-07-24 Thread simei
From: Simei Su [PATCH 1/2] ethdev: add new hash function "Symmetric Toeplitz" supported by hardware. [PATCH 2/2] app/testpmd: add command line support for symmetric toeplitz hash configuration. Simei Su (2): ethdev: add symmetric toeplitz hash support app/testpmd: add symmetric toeplitz ha

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-24 Thread Anoob Joseph
Hi Shally, Oh yeah! Should've noticed. My settings is to use the incoming mail's formatting. Mail Ayuj created the issue. Thanks, Anoob > -Original Message- > From: Shally Verma > Sent: Thursday, July 25, 2019 10:52 AM > To: Anoob Joseph ; Ayuj Verma > ; akhil.go...@nxp.com > Cc: arkadi

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-24 Thread Shally Verma
Hi Anoob Seems your reply is not in plaintext which will make it difficult for inline response. So, please take care of that when you reply. Rest, please see my response inline. From: Anoob Joseph Sent: Thursday, July 25, 2019 9:46 AM To: Ayuj Verma ; akhil.go...@nxp.com Cc: arkadiuszx.kusz...@

Re: [dpdk-dev] [PATCH 0/5] bnxt patches

2019-07-24 Thread Somnath Kotur
Ferruh, Please ignore this set as i have sent a v2 with just 4 of the patches below...the 1st patch in this set got pulled in to Lance's latest patch ( (net/bnxt: use dedicated cpr for async events) Thanks and apologies for any confusion -Som On Wed, Jul 24, 2019 at 11:37 AM Somnath Ko

[dpdk-dev] [PATCH 2/4] net/bnxt: fix to use chimp hwrm channel for few commands

2019-07-24 Thread Somnath Kotur
From: Kalesh AP Modified to send the tunnel redirect commands to Chimp as Kong does not support these commands. Fixes: 11e5e19695c7bfb3 ("net/bnxt: support redirecting tunnel packets to VF") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnx

[dpdk-dev] [PATCH 4/4] net/bnxt: reduce verbosity of a message

2019-07-24 Thread Somnath Kotur
From: Kalesh AP Change verbosity of a message to DEBUG from ERROR. This is just debug message. Fixes: 3e92fd4e4ec0c7b ("net/bnxt: use dynamic log type") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed,

[dpdk-dev] [PATCH 3/4] net/bnxt: fix endianness issue

2019-07-24 Thread Somnath Kotur
From: Kalesh AP Use rte_cpu_to_le_16/32 while parsing the hwrm command response. Fixes: 11e5e19695c7bfb3 ("net/bnxt: support redirecting tunnel packets to VF") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file

[dpdk-dev] [PATCH v2 0/4] bnxt patches

2019-07-24 Thread Somnath Kotur
This set contains bug fixes for commits that made it into 19.08, so it's imperative that these go into 19.08 as well Please apply Kalesh AP (3): net/bnxt: fix to use chimp hwrm channel for few commands net/bnxt: fix endianness issue net/bnxt: reduce verbosity of a message Santoshkumar Kara

[dpdk-dev] [PATCH 1/4] net/bnxt: fix extended port counter statistics

2019-07-24 Thread Somnath Kotur
From: Santoshkumar Karanappa Rastapur We were trying to fill in more rx extended stats than the size allocated for stats causing segfault. Fixed this by adding an explicit check. Rearranged the code to return statistic values in xstats_get as per the names returned in xstats_get_names. Fixes: f5

Re: [dpdk-dev] [v3] net/ice: enable multi-process support

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Xiao > Sent: Thursday, July 25, 2019 7:19 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Zhang, Xiao ; > sta...@dpdk.org > Subject: [v3] net/ice: enable multi-process support > > Add multiple processes support for ice, secondary processes

[dpdk-dev] [PATCH v2] net/iavf: fix endless loop

2019-07-24 Thread Qi Zhang
Change loop index from uint16_t to uint32_t since max index 65535 could be exceeded when ring size is 2k+. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Reported-by: Lei Yao Signed-off-by: Qi Zhang --- v2: - add missing fix in reset_tx_queue. drivers/net/iavf/ia

[dpdk-dev] [PATCH] net/iavf: fix endless loop

2019-07-24 Thread Qi Zhang
Change loop index from uint16_t to uint32_t since max index 65535 could be exceeded when ring size is 2k+. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Reported-by: Lei Yao Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 3 ++- 1 file changed, 2 inser

[dpdk-dev] [PATCH] net/iavf: fix endless loop

2019-07-24 Thread Qi Zhang
Change loop index from uint16_t to uint32_t since max index 65535 could be exceeded when ring size is 2k+. Fixes: 69dd4c3d0898 ("net/avf: enable queue and device") Cc: sta...@dpdk.org Reported-by: Lei Yao Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 3 ++- 1 file changed, 2 inser

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-24 Thread Anoob Joseph
Hi Ayuj, I believe there are couple of issues with this patch. Are these experimental APIs? I believe they were made stable this release and I'm not sure if it is a right practice to edit an API without deprecation notice after it is made stable. Especially now that RC2 is done. @Akhil, what i

Re: [dpdk-dev] [v3] net/ice: enable multi-process support

2019-07-24 Thread Ye Xiaolong
On 07/25, Xiao Zhang wrote: >Add multiple processes support for ice, secondary processes will share >memory and configuration with primary process, do not need further >initialization for secondary processes. > >Cc: sta...@dpdk.org This is a new feature, it's no need to cc sta...@dpdk.org. Thanks

[dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-24 Thread John Daley
Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd by default. After the fix, using dynamic logging, only NOTICE level and higher were displayed by default and INFO level were not. Change the messages to NOTICE level so they continue to display. DTS uses testpmd and parses messages a

[dpdk-dev] [v3] net/ice: enable multi-process support

2019-07-24 Thread Xiao Zhang
Add multiple processes support for ice, secondary processes will share memory and configuration with primary process, do not need further initialization for secondary processes. Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- v3 Update the title and commit message. v2 Remove limitation for sec

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Thomas Monjalon
24/07/2019 18:28, Morrissey, Sean: > > Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" > > 24/07/2019 17:20, Sean Morrissey: > > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > > > Reverting this patch as it currently breaks the initialization of > > telem

[dpdk-dev] [PATCH 1/2] mk: fix missing pci bus with shared library build

2019-07-24 Thread Stephen Hemminger
If DPDK is built as a shared library, then any application linked with rte.app.mk will not find any buses (including PCI devices). This is because the linker will not call the initializers of the bus libraries since they are not directly called by application or EAL. Bugzilla ID: 333 Fixes: c7529

[dpdk-dev] [PATCH 2/2] mk: fix missing mempool driver registration

2019-07-24 Thread Stephen Hemminger
Since mempool driver is now registered during constructor, the mempool driver must always be linked in during shared library build. Otherwise, application will fail because of missing default mbuf pool operations. Fixes: c6b3570f9e14 ("mk: link app with ring mempool by default") Cc: stable.dpdk.or

[dpdk-dev] [PATCH 0/2] mk: fix build with shared library

2019-07-24 Thread Stephen Hemminger
If RTE_BUILD_SHARED_LIB is enabled, then there a couple of places in the mk scripts where constructors are not called but need to be. Stephen Hemminger (2): mk: fix missing pci bus with shared library build mk: fix missing mempool driver registration mk/rte.app.mk | 9 + 1 file chang

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources

2019-07-24 Thread Matan Azrad
השג את Outlook עבור Android מאת: Dekel Peled נשלח: יום רביעי, 24 ביולי, 12:05 נושא: [dpdk-dev] [PATCH v3] net/mlx5: fix Rx queue release of resources אל: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler עותק: Ori Kam, dev@dpdk.org Function rxq_release_rq_resources() relea

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release

2019-07-24 Thread Matan Azrad
השג את Outlook עבור Android מאת: Dekel Peled נשלח: יום רביעי, 24 ביולי, 12:05 נושא: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queuerelease אל: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler עותק: Ori Kam, dev@dpdk.org Function mlx5_rxq_release() calls m

Re: [dpdk-dev] [PATCH v1 4/4] net/i40e: replace license text with SPDX tag

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 6:34 PM, David Christensen wrote: >> Signed-off-by: Xiaolong Ye >> --- >> drivers/net/i40e/i40e_rxtx_vec_altivec.c | 35 ++-- >> drivers/net/i40e/i40e_rxtx_vec_avx2.c| 33 ++ >> 2 files changed, 5 insertions(+), 63 deletions(-) > > Revi

Re: [dpdk-dev] [PATCH v3 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 7:41 PM, Andrew Rybchenko wrote: > On 7/24/19 7:57 PM, Ferruh Yigit wrote: >> On 7/24/2019 2:16 PM, Andrew Rybchenko wrote: >>> Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() >>> defined in libefx. >>> >>> Cast value and alignment to one specified type to guarantee result

Re: [dpdk-dev] [PATCH v3 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 2:16 PM, Andrew Rybchenko wrote: > P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller > than type of the value to be aligned. > > IS_P2ALIGNED() has no the problem since it cast its arugments > to uintptr_t inside, but fixed anyway to follow the same approach as

Re: [dpdk-dev] [PATCH 3/3] net/pcap: fix concurrent multiseg packet transmits

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:54 PM, David Marchand wrote: > Two cores can send multi segment packets on two different pcap ports. > Because of this, we can't have one single buffer to linearize packets. +1, you are right. > > Use rte_pktmbuf_read() to copy the packet into a buffer on the stack > and remove e

Re: [dpdk-dev] [PATCH v3 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
On 7/24/19 7:57 PM, Ferruh Yigit wrote: On 7/24/2019 2:16 PM, Andrew Rybchenko wrote: Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc

Re: [dpdk-dev] [PATCH 2/3] net/pcap: fix transmit return count in error conditions

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:54 PM, David Marchand wrote: > When a packet cannot be transmitted, the driver is supposed to free this > packet and report it as handled. > This is to prevent the application from retrying to send the same packet > and ending up in a liveloop since the driver will never manage to s

Re: [dpdk-dev] [PATCH 1/3] net/pcap: fix Rx with small buffers

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:54 PM, David Marchand wrote: > If the pkt pool contains only buffers smaller than the default headroom, > then the driver will compute an invalid buffer size (negative value cast > to an uint16_t). > Rely on the mbuf api to check how much space is available in the mbuf. > > Fixes:

Re: [dpdk-dev] [EXT] [PATCH v3 1/5] eal: add the APIs to wait until equal

2019-07-24 Thread Gavin Hu (Arm Technology China)
Hi Jerin, > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 24, 2019 7:53 PM > To: Gavin Hu (Arm Technology China) ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; > step...@networkplumber.org; Pavan Nikhilesh Bhagavatula > ; Honnappa Nagarahalli > > Subject: RE

Re: [dpdk-dev] [PATCH v1] test/rcu: remove redundant header file

2019-07-24 Thread Honnappa Nagarahalli
> > RCU library now includes stdbool.h header itself. > There is no need to include this header file in RCU user files. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > --- > app/test/test_rcu_qsbr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/app/test/test_rcu_qsbr.c b/a

Re: [dpdk-dev] [PATCH v3 5/5] config: add WFE config entry for aarch64

2019-07-24 Thread Gavin Hu (Arm Technology China)
Hi Stephen, > -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, July 24, 2019 3:10 AM > To: Stephen Hemminger ; Gavin Hu (Arm > Technology China) > Cc: dev@dpdk.org; nd ; tho...@monjalon.net; > jer...@marvell.com; pbhagavat...@marvell.com; Honnappa Nagarahalli > ; nd > S

Re: [dpdk-dev] [PATCH v1 4/4] net/i40e: replace license text with SPDX tag

2019-07-24 Thread David Christensen
Signed-off-by: Xiaolong Ye --- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 35 ++-- drivers/net/i40e/i40e_rxtx_vec_avx2.c| 33 ++ 2 files changed, 5 insertions(+), 63 deletions(-) Reviewed-by: David Christensen

[dpdk-dev] [PATCH] eal/interrupts: add function to allow interruptible epoll

2019-07-24 Thread Stephen Hemminger
The existing definition of rte_epoll_wait retries if interrupted by a signal. This behavior makes it hard to use rte_epoll_wait for applications that want to use signals do do things like exit polling loop and shutdown. Since changing existing semantic might break applications, add a new rte_epoll

Re: [dpdk-dev] [PATCH v3 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 2:16 PM, Andrew Rybchenko wrote: > Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() > defined in libefx. > > Cast value and alignment to one specified type to guarantee result > correctness. > > Fixes: e1b944598579 ("net/sfc: build libefx") > Cc: sta...@dpdk.org > > Sign

[dpdk-dev] [[PATCH v2]] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
This commit enables the creation of a dedicated completion ring for asynchronous event handling instead of handling these events on a receive completion ring. For the stingray platform and other platforms needing tighter control of resource utilization, we retain the ability to process async event

Re: [dpdk-dev] [PATCH 1/2] usertools/devbind: add error on forgetting to specify driver

2019-07-24 Thread Burakov, Anatoly
On 24-Jul-19 5:29 PM, Stephen Hemminger wrote: On Wed, 24 Jul 2019 16:34:43 +0100 Anatoly Burakov wrote: A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but pe

Re: [dpdk-dev] [PATCH v1 0/4] Replace license text with SPDX tag for intel drivers

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:30 PM, Xiaolong Ye wrote: > This patchset replaces the remaining full license headers in a number > of intel driver files with SPDX tags to achieve DPDK-license compliance. > > Xiaolong Ye (4): > net/iavf: replace license text with SPDX tag > net/fm10k: replace license text wit

Re: [dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded before binding

2019-07-24 Thread Burakov, Anatoly
On 24-Jul-19 5:28 PM, Stephen Hemminger wrote: On Wed, 24 Jul 2019 16:34:44 +0100 Anatoly Burakov wrote: +# check if a specific kernel module is loaded +def module_is_loaded(module): +# Get list of sysfs modules (both built-in and dynamically loaded) +sysfs_path = '/sys/module/' + +

[dpdk-dev] [PATCH] eal: pick IOVA as PA if IOMMU is not available

2019-07-24 Thread Anatoly Burakov
When IOMMU is not available, /sys/kernel/iommu_groups will not be populated. This is happening since at least 3.6 when VFIO support was added. If the directory is empty, EAL should not pick IOVA as VA as the default IOVA mode. We also assume that VFIO equals IOMMU, so if VFIO support is not compil

[dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-24 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Matan Azrad
From: Stephen Hemminger > Sent: Wednesday, July 24, 2019 7:24 PM > To: Matan Azrad > Cc: Hemant Agrawal ; sachin.sax...@nxp.com; > dev@dpdk.org > Subject: Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 > > On Wed, 24 Jul 2019 15:37:40 + > Matan Azrad wrote: > > > Hi Heman

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Morrissey, Sean
Subject: Re: [PATCH v2] Revert "eal: fix parsing option --telemetry" 24/07/2019 17:20, Sean Morrissey: > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > Reverting this patch as it currently breaks the initialization of > telemetry, more investigation is ongoing to fix the iss

Re: [dpdk-dev] [PATCH] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
On Wed, Jul 24, 2019 at 12:14 PM Lance Richardson wrote: > process async events on a receive completion ring. This behavior > is controlled by a compile-time configuration variable. I will follow up with a v2 to correct the above statement in the commit log and to squash with these follow-up pat

Re: [dpdk-dev] [PATCH 1/2] usertools/devbind: add error on forgetting to specify driver

2019-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2019 16:34:43 +0100 Anatoly Burakov wrote: > A common user error is to forget driver to which the PCI devices should > be bound to. Currently, the error message in this case looks unhelpful > misleading and indecipherable to anyone but people who know how devbind > works. > > Fix

Re: [dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded before binding

2019-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2019 16:34:44 +0100 Anatoly Burakov wrote: > +# check if a specific kernel module is loaded > +def module_is_loaded(module): > +# Get list of sysfs modules (both built-in and dynamically loaded) > +sysfs_path = '/sys/module/' > + > +# Get the list of directories in sysf

Re: [dpdk-dev] [PATCH] app/crypto-perf: disable asymmetric crypto

2019-07-24 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anoob Joseph > Sent: Wednesday, July 24, 2019 10:04 AM > To: Akhil Goyal ; Doherty, Declan > ; De Lara Guarch, > Pablo > Cc: Anoob Joseph ; Jerin Jacob ; > Narayana Prasad > ; Shally Verma ; dev@dpdk.org > Sub

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Stephen Hemminger
On Wed, 24 Jul 2019 15:37:40 + Matan Azrad wrote: > Hi Hemant, Sachin > > Looks like issue in dpaa. > Please check. > > > -Original Message- > > From: dev On Behalf Of bugzi...@dpdk.org > > Sent: Wednesday, July 24, 2019 6:35 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [Bug 335

[dpdk-dev] [PATCH] net/bnxt: use dedicated cpr for async events

2019-07-24 Thread Lance Richardson
This commit enables the creation of a dedicated completion ring for asynchronous event handling instead of handling these events on a receive completion ring. For the stingray platform and other platforms needing tighter control of resource utilization, we retain the ability to process async event

Re: [dpdk-dev] [PATCH v1 4/4] net/i40e: replace license text with SPDX tag

2019-07-24 Thread Ferruh Yigit
On 7/24/2019 12:30 PM, Xiaolong Ye wrote: > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/i40e_rxtx_vec_altivec.c | 35 ++-- > drivers/net/i40e/i40e_rxtx_vec_avx2.c| 33 ++ > 2 files changed, 5 insertions(+), 63 deletions(-) > > diff --git a/driv

[dpdk-dev] [PATCH v4] eal: fix proc type auto detection

2019-07-24 Thread Anatoly Burakov
Currently, primary process holds an exclusive lock on the config file, thereby preventing other primaries from spinning up. However, when the primary dies, the lock is no longer being held, even though there might be other secondary processes still running. The fix is two-fold. First of all, downg

[dpdk-dev] [PATCH v3] eal: fix proc type auto detection

2019-07-24 Thread Anatoly Burakov
Currently, primary process holds an exclusive lock on the config file, thereby preventing other primaries from spinning up. However, when the primary dies, the lock is no longer being held, even though there might be other secondary processes still running. The fix is two-fold. First of all, downg

Re: [dpdk-dev] [PATCH] test: enable installing test app with meson

2019-07-24 Thread Bruce Richardson
On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote: > Currently, the test app is not being installed by default when > built and installed with meson build system. Fix that to enable > installation of the test app alongside other DPDK apps. > > Fixes: b5dc795a8a55 ("test: build app wi

[dpdk-dev] [PATCH] test: enable installing test app with meson

2019-07-24 Thread Anatoly Burakov
Currently, the test app is not being installed by default when built and installed with meson build system. Fix that to enable installation of the test app alongside other DPDK apps. Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test") Cc: harry.van.haa...@intel.com Cc: bruce.richard...

Re: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread Matan Azrad
Hi Hemant, Sachin Looks like issue in dpaa. Please check. > -Original Message- > From: dev On Behalf Of bugzi...@dpdk.org > Sent: Wednesday, July 24, 2019 6:35 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0 > > https://eur03.safelinks.protecti

[dpdk-dev] [Bug 335] Compilation fails when HEADROOM is 0

2019-07-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=335 Bug ID: 335 Summary: Compilation fails when HEADROOM is 0 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal P

[dpdk-dev] [PATCH 2/2] usertools/devbind: check if module is loaded before binding

2019-07-24 Thread Anatoly Burakov
Currently, if an attempt is made to bind a device to a driver that is not loaded, a confusing and misleading error message appears. Fix it so that, before binding to the driver, we actually check if it is loaded in the kernel first. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py |

[dpdk-dev] [PATCH 1/2] usertools/devbind: add error on forgetting to specify driver

2019-07-24 Thread Anatoly Burakov
A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but people who know how devbind works. Fix this by checking if the driver string is actually a valid device string.

[dpdk-dev] [PATCH 0/2] Small usability improvements for devbind

2019-07-24 Thread Anatoly Burakov
Over the course of using devbind, i find myself frequently bumping up against two common errors (with the assumption being that i'm not the only person who hits these errors). First happens when i forget to specify the driver. The error message in this case looks something like the following: ana

Re: [dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Thomas Monjalon
24/07/2019 17:20, Sean Morrissey: > This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. > > Reverting this patch as it currently breaks the initialization of > telemetry, more investigation is ongoing to fix the issue for the > printed error message for unrecognized argument. > > Signed

[dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Sean Morrissey
This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. Reverting this patch as it currently breaks the initialization of telemetry, more investigation is ongoing to fix the issue for the printed error message for unrecognized argument. Signed-off-by: Sean Morrissey --- v2: Adding sign o

[dpdk-dev] [PATCH] Revert "eal: fix parsing option --telemetry"

2019-07-24 Thread Sean Morrissey
This reverts commit debacba0297fbe214b4185a9791e6a9fdf6642ba. Reverting this patch as it currently breaks the initialization of telemetry, more investigation is ongoing to fix the issue for the printed error message for unrecognized argument. --- lib/librte_eal/common/eal_common_options.c | 3 ---

Re: [dpdk-dev] [PATCH] examples/qos_sched: add more tc to red configuration

2019-07-24 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 24, 2019 1:27 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/qos_sched: add more tc to red configuration > > Add RED configuration to more traffic classes in app configuration > files. >

Re: [dpdk-dev] [PATCH] app/testpmd: fix eth packet dump for small buffers

2019-07-24 Thread Iremonger, Bernard
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, July 24, 2019 11:59 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; sta...@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard > Subject: [PATCH] app/testpmd: fix eth packet dump

[dpdk-dev] [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-07-24 Thread Anoob Joseph
The rte_security API which enables inline protocol/crypto feature mandates that for every security session an rte_flow is created. This would internally translate to a rule in the hardware which would do packet classification. In rte_securty, one SA would be one security session. And if an rte_flo

[dpdk-dev] [PATCH v7 1/1] app/test-compress-perf: provide more detailed report

2019-07-24 Thread Adam Dybkowski
From: Artur Trybula This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out. Information about threads, cores, devices and queue-pairs is also printed. Signed-off-by: Artur Tr

[dpdk-dev] [PATCH v7 0/1] add extra features to test-compress-perf

2019-07-24 Thread Adam Dybkowski
v7 changes: - one more special character replaced with a minus sign v6 changes: - replace special bullet characters with normal asterisks v5 changes: - some minor changes (rewording, structure renaming, etc.) v4 changes: - information about compression threads pri

[dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations

2019-07-24 Thread David Hunt
The branch ratio algorithm in the vm_power_manager sample application can be very sensitive at patricular loads in a workload, causing oscillations between min and max frequency. For example, if a workload is at 50%, scaling up may change the ratio enough that it immediately thinks it needs to scal

[dpdk-dev] [PATCH v3 3/3] net/sfc: unify power of 2 alignment check macro

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined IS_P2ALIGNED() with EFX_IS_P2ALIGNED() defined in libefx. Add type argument and cast value and alignment to one specified type. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 4 ++

[dpdk-dev] [PATCH v3 2/3] net/sfc: fix align to power of 2 when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ALIGN() with EFX_P2ALIGN() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 2 +-

[dpdk-dev] [PATCH v3 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h

[dpdk-dev] [PATCH v3 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P2ROUNDUP() and EFX_P2ALIGN(). Patches have ch

Re: [dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset match

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, July 24, 2019 9:07 PM > To: Wang, Ying A > Cc: Yang, Qiming ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset > match

[dpdk-dev] [PATCH v6 1/1] app/test-compress-perf: provide more detailed report

2019-07-24 Thread Adam Dybkowski
From: Artur Trybula This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out. Information about threads, cores, devices and queue-pairs is also printed. Signed-off-by: Artur Tr

[dpdk-dev] [PATCH v6 0/1] add extra features to test-compress-perf

2019-07-24 Thread Adam Dybkowski
v6 changes: - replace special bullet characters with normal asterisks v5 changes: - some minor changes (rewording, structure renaming, etc.) v4 changes: - information about compression threads printed on screen v3 changes: - commented code removed v2 changes:

[dpdk-dev] [PATCH v2 3/3] net/sfc: unify power of 2 alignment check macro

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined IS_P2ALIGNED() with EFX_IS_P2ALIGNED() defined in libefx. Add type argument and cast value and alignment to one specified type. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 4 ++

[dpdk-dev] [PATCH v2 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P2ROUNDUP() and EFX_P2ALIGN(). Patches have ch

[dpdk-dev] [PATCH v2 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h

Re: [dpdk-dev] [PATCH] net/ice: add vni/tni support for flow inputset match

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Ying A > Sent: Wednesday, July 24, 2019 7:21 AM > To: Zhang, Qi Z > Cc: Yang, Qiming ; dev@dpdk.org; Wang, Ying A > ; sta...@dpdk.org > Subject: [PATCH] net/ice: add vni/tni support for flow inputset match > > For VXLAN/NVGRE packet, vni/tni should be

Re: [dpdk-dev] [PATCH 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
On 7/24/19 3:59 PM, Andrew Rybchenko wrote: P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P

Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in rx/tx ring setup

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ye Xiaolong > Sent: Wednesday, July 24, 2019 4:18 PM > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: remove unnecessary type cast in > rx/tx ring setup Should be "Rx/Tx" > >

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix RSS hash update problem for X722 VF

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Huang, Peng > Sent: Monday, July 22, 2019 9:50 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Xing, Beilei ; Huang, Peng > ; sta...@dpdk.org > Subject: [PATCH v2 2/2] net/i40e: fix RSS hash update problem for X722 VF > > This patch fixes X722 VF problem when rece

[dpdk-dev] [PATCH 3/3] net/sfc: unify power of 2 alignment check macro

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined IS_P2ALIGNED() with EFX_IS_P2ALIGNED() defined in libefx. Add type argument and cast value and alignment to one specified type. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 4 ++

[dpdk-dev] [PATCH 2/3] net/sfc: fix align to power of 2 when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ALIGN() with EFX_P2ALIGN() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_rx.c | 2 +-

[dpdk-dev] [PATCH 1/3] net/sfc: fix power of 2 round up when align has smaller type

2019-07-24 Thread Andrew Rybchenko
Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP() defined in libefx. Cast value and alignment to one specified type to guarantee result correctness. Fixes: e1b944598579 ("net/sfc: build libefx") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_impl.h

[dpdk-dev] [PATCH 0/3] net/sfc: fix power of 2 alignment macros

2019-07-24 Thread Andrew Rybchenko
P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller than type of the value to be aligned. IS_P2ALIGNED() has no the problem since it cast its arugments to uintptr_t inside, but fixed anyway to follow the same approach as new EFX_P2ROUNDUP() and EFX_P2ALIGN(). Patches have ch

Re: [dpdk-dev] [PATCH v3] net/i40e: fix request queue fail in VF

2019-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhu, TaoX > Sent: Wednesday, July 24, 2019 4:33 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhu, TaoX ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix request queue fail in VF > > From: Zhu Tao > > When the VF configuration is larger than

[dpdk-dev] [PATCH] examples/qos_sched: add more tc to red configuration

2019-07-24 Thread Jasvinder Singh
Add RED configuration to more traffic classes in app configuration files. Signed-off-by: Jasvinder Singh --- examples/qos_sched/profile.cfg| 20 examples/qos_sched/profile_ov.cfg | 20 2 files changed, 40 insertions(+) diff --git a/examples/qos_sche

Re: [dpdk-dev] [EXT] [PATCH v3 5/5] config: add WFE config entry for aarch64

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Gavin Hu > Sent: Tuesday, July 23, 2019 9:14 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; step...@networkplumber.org; > Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula ; > honnappa.nagaraha...@arm.com; gavin...@arm.com > Subject: [EX

Re: [dpdk-dev] [EXT] [PATCH v3 4/5] spinlock: use wfe to reduce contention on aarch64

2019-07-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Gavin Hu > Sent: Tuesday, July 23, 2019 9:14 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; step...@networkplumber.org; > Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula ; > honnappa.nagaraha...@arm.com; gavin...@arm.com > Subject: [EX

[dpdk-dev] [PATCH v2] event/octeontx2: fix NULL dereference

2019-07-24 Thread pbhagavatula
From: Pavan Nikhilesh Fix NULL dereference after rte_realloc and add extra NULL checks. Fix few memory leak with kvargs. Coverity issue: 345023, 345022, 345009, 345011, 345026, 344997, 344990 Fixes: ffa4ec0b6063 ("event/octeontx2: allow adapters to resize inflight buffers") Signed-off-by: Pava

  1   2   >