[dpdk-dev] [PATCH v3 1/1] app/test: fix --socket-mem option in eal flag autotest

2019-07-11 Thread vattunuru
From: Vamsi Attunuru eal flag autotest fails when multiple mem size flags are passed to --socket-mem option irrespective of RTE_MAX_NUMA_NODES. Patch fixes --socket-mem option by setting enough numbers of numa node mem flags based on RTE_MAX_NUMA_NODES config. Fixes: 45f1b6e8680a ("app: add new

Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam

2019-07-11 Thread Akhil Goyal
Hi Fan, > > 08/07/2019 12:26, Thomas Monjalon: > > 07/07/2019 07:41, Liron Himi: > > > From: Akhil Goyal > > > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform key > > > > data type change for mvsam driver. > > > > > > > > Fixes: f3390532cf6a ("cryptodev: make xform key point

[dpdk-dev] [PATCH 15/15] net/bnxt: fix to avoid sending invalid VNIC id to firmware

2019-07-11 Thread Ajit Khaparde
From: Jay Ding Add checking for vinc id before sending message to chimp in bnxt_hwrm_vnic_plcmode_cfg(). Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Reviewed-by: Ajit Khaparde Reviewed-by: Randy Schacher Signed-off-by: Jay Ding --- drivers/net/bnxt/bnxt_hwrm.c | 5 + 1 file

[dpdk-dev] [PATCH 14/15] net/bnxt: fix rxq count if ntuple filtering is disabled

2019-07-11 Thread Ajit Khaparde
From: Qingmin Liu If ntuple filtering is disabled, FW will return max_vnics=1. Due to this only single Rxq is created. Change to max_rx_rings = RTE_MIN(bp->max_rx_rings, bp->max_stat_ctx) to fix it. Fixes: 6d8109bcb398 ("net/bnxt: check VF resources if resource manager is enabled") Signed-off-b

[dpdk-dev] [PATCH 13/15] net/bnxt: fix a compilation warning

2019-07-11 Thread Ajit Khaparde
Compiler complains of an uninitialized variable. Initializing it to avoid the issue. Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH 12/15] net/bnxt: fix to check for invalid VNIC in cleanup path

2019-07-11 Thread Ajit Khaparde
From: Kalesh AP The cleanup/rollback operation post rte_eth_dev_start failure might end up invoking an HWRM cmd even on an invalid vNIC resulting in error messages being logged needlessly. Fix to check for the same before issuing the HWRM cmd. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link

[dpdk-dev] [PATCH 07/15] net/bnxt: fix for doorbell register offset for Tx ring.

2019-07-11 Thread Ajit Khaparde
For Tx-ring # 104 and higher, the doorbell register was incorrectly configured due to which FW was not able to receive the notification of packet to transmit. With this fix, user can run traffic upto 256 rings. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Signed-off-by: Rahul Gupta Sign

[dpdk-dev] [PATCH 11/15] net/bnxt: fix to enable disable interrupts correctly in start stop

2019-07-11 Thread Ajit Khaparde
From: Kalesh AP 1. disable interrupts in dev_stop_op() 2. enable interrupts in dev_start_op() 3. Clean queue intr-vector mapping in dev_stop_op() and thus fix a possible memory leak. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations") Signed-off-by: Kalesh AP Reviewed-by

[dpdk-dev] [PATCH 08/15] net/bnxt: save the number of EM flow count

2019-07-11 Thread Ajit Khaparde
Save the number of EM flow count returned by the FW in HWRM_FUNC_QCFG and use it to calculate the overall pool of L2 contexts supported by FW. Fixes: 6d8109bcb398 ("net/bnxt: check VF resources if resource manager is enabled") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh Anakkur Purayil --

[dpdk-dev] [PATCH 10/15] net/bnxt: avoid null pointer dereference

2019-07-11 Thread Ajit Khaparde
From: Lance Richardson Avoid null pointer dereference when allocating an insolated completion ring by basing nq ring allocation on whether an nq ring was requested instead of whether the device supports nq rings. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance Rich

[dpdk-dev] [PATCH 09/15] net/bnxt: nq doorbell cleanups

2019-07-11 Thread Ajit Khaparde
From: Lance Richardson Simplify nq doorbell handling code by removing redundant db parameter and consolidating NQ doorbell macro into the inline function that uses it. Add "enable interrupt" variant of nq write. This will be used in a subsequent commit. When initializing nq doorbell, don't assu

[dpdk-dev] [PATCH 06/15] net/bnxt: correctly set L4 checksum error for tunnel and non-tunnel packets

2019-07-11 Thread Ajit Khaparde
From: Rahul Gupta Update ol_flags correctly for checksum errors in case of tunnel and non-tunnel packet. Fixes: 65ee636872eb ("net/bnxt: fix Rx checksum flags) Signed-off-by: Rahul Gupta Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 43 ++--- drivers/net/bnxt/bnxt_r

[dpdk-dev] [PATCH 01/15] net/bnxt: fix extended port counter statistics

2019-07-11 Thread Ajit Khaparde
From: Kalesh AP 1. refactor stats allocation code to new routine 2. check for extended statistics support depends on "hwrm_spec_code" which is set in bnxt_hwrm_ver_get called later. Hence we were never querying extended port stats as flags field was not updated. Fixed this by moving the

[dpdk-dev] [PATCH 00/15] bnxt patch series

2019-07-11 Thread Ajit Khaparde
Patchset fixing various bugs in bnxt PMD based on recent patch submission. https://patchwork.dpdk.org/patch/56311/ Ajit Khaparde (3): net/bnxt: fix for doorbell register offset for Tx ring. net/bnxt: save the number of EM flow count net/bnxt: fix a compilation warning Jay Ding (1): net/bn

[dpdk-dev] [PATCH 04/15] net/bnxt: fix Tx hang after port stop/start

2019-07-11 Thread Ajit Khaparde
From: Lance Richardson Initialize the state of the the completion valid indicator when a completion ring is freed, otherwise completions may not be processed when a new ring is allocated. Fixes: 5735eb241947 ("net/bnxt: support Tx batching") Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: La

[dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart

2019-07-11 Thread Ajit Khaparde
From: Lance Richardson Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb and rxq->rxrearm_start are reinitialized correctly when a port is restarted. Fixes: af3ed597e305 ("net/bnxt: initial vector-mode driver") Reviewed-by: Christopher Reder Signed-off-by: Lance Richardson

[dpdk-dev] [PATCH 03/15] net/bnxt: do not fail VF probe when the MAC address is zero

2019-07-11 Thread Ajit Khaparde
From: Kalesh AP VF driver should not fail probe if the host PF driver has not assigned any MAC address for the VF. It should generate a random MAC address and configure the MAC and then continue probing the device. Fixes: be160484a48d ("net/bnxt: check if MAC address is all zeros") Signed-off-by

[dpdk-dev] [PATCH 02/15] net/bnxt: fix possible segfault in case of probe failure

2019-07-11 Thread Ajit Khaparde
From: Kalesh AP Fixed couple of possible segfaults due to NULL pointer dereference in case of probe failure. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations") Signed-off-by: Kalesh AP Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 3 +++ drivers/net/bnx

[dpdk-dev] [PATCH v5 6/6] lib/lpm: data update optimization for v20

2019-07-11 Thread Ruifeng Wang
The table entries were updated field by field. There were two issues: 1. bitwise operations are read-modify-write sequences and not atomic, nor efficient. 2. the above non-atomic operations causes entries out of synchronization and inconsistency. This patch combines the fields into a one-go 3

[dpdk-dev] [PATCH v5 4/6] lib/lpm: use atomic store to avoid partial update

2019-07-11 Thread Ruifeng Wang
Compiler could generate non-atomic stores for whole table entry updating. This may cause incorrect nexthop to be returned, if the byte with valid flag is updated prior to the byte with nexthop is updated. Changed to use atomic store to update whole table entry. Suggested-by: Medvedkin Vladimir S

[dpdk-dev] [PATCH v5 5/6] lib/lpm: data update optimization for v1604

2019-07-11 Thread Ruifeng Wang
The table entries were updated field by field. There were two issues: 1. bitwise operations are read-modify-write sequences and not atomic, nor efficient. 2. the above non-atomic operations causes entries out of synchronization and inconsistency. This patch combines the fields into a one-go 3

[dpdk-dev] [PATCH v5 2/6] lib/lpm: memory orderings to avoid race conditions for v1604

2019-07-11 Thread Ruifeng Wang
When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v5 0/6] LPM4 memory ordering changes

2019-07-11 Thread Ruifeng Wang
LPM4 uses DIR24-8 method of routing info data organization. Routing rule with prefix longer than 24 bits will be stored in a tbl24 entry together with an associated tbl8 group. When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the tabl

[dpdk-dev] [PATCH v5 1/6] lib/lpm: not inline unnecessary functions

2019-07-11 Thread Ruifeng Wang
Tests showed that the function inlining caused performance drop on some x86 platforms with the memory ordering patches applied. By force no-inline functions, the performance was better than before on x86 and no impact to arm64 platforms. Besides inlines of other functions are removed to let compil

[dpdk-dev] [PATCH v5 3/6] lib/lpm: memory orderings to avoid race conditions for v20

2019-07-11 Thread Ruifeng Wang
When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

Re: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated

2019-07-11 Thread Wang, Haiyue
Hi Xiaolong, > -Original Message- > From: Wang, Haiyue > Sent: Friday, July 12, 2019 10:12 > To: Ye, Xiaolong > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of > phys_addr which is > deprecated > > > -Original Message

Re: [dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread Yasufumi Ogawa
On 2019/07/11 22:14, Burakov, Anatoly wrote: On 11-Jul-19 12:57 PM, Yasufumi Ogawa wrote: On 2019/07/11 19:53, Burakov, Anatoly wrote: On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa <...> +    if (getpid() == 1) { +    FILE *hn_fp; +    hn_fp = fopen("/etc/

Re: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated

2019-07-11 Thread Wang, Haiyue
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 12, 2019 16:30 > To: Wang, Haiyue > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of > phys_addr which is > deprecated > > Hi, Haiyue > > On 07/12, Haiyue Wang wro

Re: [dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue

2019-07-11 Thread Ye Xiaolong
Hi, qiming On 07/12, Qiming Yang wrote: >The return value of function ice_flow_valid_attr should >be non-zero. This patch fixed this issue. > Minor nit about the title, 'issue' is never needed after word 'fix', what about net/ice: fix flow validation failure ? And for the commit log, it's uncle

Re: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated

2019-07-11 Thread Ye Xiaolong
Hi, Haiyue On 07/12, Haiyue Wang wrote: >The phys_addr concept is deprecated in rte_memzone, change it to access >iova member, and use the type 'rte_iova_t'. > It seems this issue also exists in other PMDs, like ixgbe, i40e, iavf..., do you have plan to fix them all? For the patch, Reviewed-by:

[dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue

2019-07-11 Thread Qiming Yang
The return value of function ice_flow_valid_attr should be non-zero. This patch fixed this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/ice/ice_generic_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations

2019-07-11 Thread Wiles, Keith
> On Jul 11, 2019, at 3:03 PM, Stephen Hemminger > wrote: > > The rte_vdev_drivers are declared twice. > The first one is not necessary. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth_tap.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/tap/rte_e

[dpdk-dev] [PATCH 9/9] raw/dpaa2_cmif: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c index 05960cca95e

[dpdk-dev] [PATCH 7/9] net/virtio_user: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 0a57db

[dpdk-dev] [PATCH 8/9] raw/skeleton_rawdev: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_ra

[dpdk-dev] [PATCH 6/9] net/ring: remove redundant rte_vdev_drive declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 65c2813ba1bc..eb347bce61b7 1006

[dpdk-dev] [PATCH 3/9] net/vhost: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/vhost/rte_eth_vhost.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 0b61e37a1995..57f382c65f

[dpdk-dev] [PATCH 5/9] net/pcap: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/pcap/rte_eth_pcap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 26e85183e524..7ff6dc38dc9a 1006

[dpdk-dev] [PATCH 4/9] net/null: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index f1b521a7564a..31cbb84d031d 1006

[dpdk-dev] [PATCH 2/9] net/af_packet: remove redundant rte_vdev_driver declaration

2019-07-11 Thread Stephen Hemminger
The rte_vdev_driver is declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/af_packet/rte_eth_af_packet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index

[dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations

2019-07-11 Thread Stephen Hemminger
The rte_vdev_drivers are declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3841842f01f8..64bd049110e1 100644 -

[dpdk-dev] [PATCH 0/9] redundant rte_vdev_driver declarations

2019-07-11 Thread Stephen Hemminger
Many drivers declare the local rte_vdev_driver structure multiple times. This is unnecessary. Surprised it is so common, I guess everyone copies the same code. Stephen Hemminger (9): net/tap: remove redundant declarations net/af_packet: remove redundant rte_vdev_driver declaration net/vhos

Re: [dpdk-dev] [PATCH] net/tap: remove redundant declarations

2019-07-11 Thread Stephen Hemminger
On Thu, 11 Jul 2019 12:48:05 -0700 Stephen Hemminger wrote: > The rte_vdev_drivers are declared twice. > The first one is not necessary. > > Signed-off-by: Stephen Hemminger Many drivers have same problem. Will send new series

[dpdk-dev] [PATCH] net/tap: remove redundant declarations

2019-07-11 Thread Stephen Hemminger
The rte_vdev_drivers are declared twice. The first one is not necessary. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3841842f01f8..64bd049110e1 100644 -

[dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of phys_addr which is deprecated

2019-07-11 Thread Haiyue Wang
The phys_addr concept is deprecated in rte_memzone, change it to access iova member, and use the type 'rte_iova_t'. Also rename the rx/tx_ring_phys_addr definitions to rx/tx_ring_dma that matches the IOVA concept design. Fixes: 50370662b727 ("net/ice: support device and queue ops") Cc: sta...@dpd

Re: [dpdk-dev] [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni module

2019-07-11 Thread Stephen Hemminger
On Tue, 25 Jun 2019 09:27:00 +0530 wrote: > diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c > index 1fc5eeb..b70c827 100644 > --- a/kernel/linux/kni/kni_misc.c > +++ b/kernel/linux/kni/kni_misc.c > @@ -294,6 +294,9 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, >

Re: [dpdk-dev] [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni module

2019-07-11 Thread Ferruh Yigit
On 6/25/2019 4:57 AM, vattun...@marvell.com wrote: > From: Kiran Kumar K > > Patch adds support for kernel module to work in IOVA = VA mode, > the idea is to get physical address from iova address using > iommu_iova_to_phys API and later use phys_to_virt API to > convert the physical address to k

Re: [dpdk-dev] [PATCH v6 3/4] example/kni: add IOVA support for kni application

2019-07-11 Thread Ferruh Yigit
On 6/25/2019 4:56 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Current KNI implementation operates in IOVA = PA mode, > Patch adds support for IOVA = VA mode by addressing > the issues with page address translations(IOVA <==> KVA). > > In this patch KNI application creates mempool

Re: [dpdk-dev] [PATCH v6 2/4] lib/kni: add PCI related information

2019-07-11 Thread Ferruh Yigit
On 6/25/2019 4:56 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > PCI related information is needed in KNI kernel module, > since it requires iommu domain info for address > translations(using iommu_iova_to_phys() call) when > KNI runs in IOVA = VA mode. > > Signed-off-by: Vamsi Attu

Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI

2019-07-11 Thread Ferruh Yigit
On 7/4/2019 10:48 AM, Jerin Jacob Kollanukkaran wrote: >> From: Vamsi Krishna Attunuru >> Sent: Thursday, July 4, 2019 12:13 PM >> To: dev@dpdk.org >> Cc: ferruh.yi...@intel.com; olivier.m...@6wind.com; >> arybche...@solarflare.com; Jerin Jacob Kollanukkaran ; >> Burakov, Anatoly >> Subject: Re

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/af_packet: add string error for system errors

2019-07-11 Thread Stephen Hemminger
On Thu, 11 Jul 2019 09:56:32 + Krzysztof Kanas wrote: > On 19-07-10 09:04, Stephen Hemminger wrote: > > External Email > > > > -- > > On Wed, 10 Jul 2019 16:46:30 +0200 > > wrote: > > > > > > > > +#define PMD_LOG_ERRNO

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-11 Thread Stephen Hemminger
On Thu, 11 Jul 2019 09:26:19 +0200 Olivier Matz wrote: > For generic fields, I think they should be declared in this file. For > instance, if we decide to replace the current m->timestamp field by a > dynamic field, we should add like this: > > #define RTE_MBUF_DYN_TIMESTAMP_ID "rte_timestamp" >

Re: [dpdk-dev] [PATCH] doc: remove invalid parameter from af_xdp example

2019-07-11 Thread Ye Xiaolong
On 07/11, David Marchand wrote: >queue= parameter does not exist. >It might have been the previous name of the queue_count parameter, but >anyway, the default value 1 for the number of queues works fine. > >Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >Cc: sta...@dpdk.org > >Signed-off-

Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow

2019-07-11 Thread Stephen Hemminger
On Thu, 11 Jul 2019 13:35:07 +0100 Ferruh Yigit wrote: > 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for > that case will be wrong and some values can cause buffer overflow > in destination mbuf data. > > Signed-off-by: Ferruh Yigit > --- > kernel/linux/kni/kni_net.c | 2

Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers

2019-07-11 Thread Thomas Monjalon
I was expecting some replies / reviews of this patch today. 10/07/2019 23:48, David Marchand: > The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which > was intended to mean "driver only supports VA" but had been understood > as "driver supports both PA and VA" by most net drivers

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-11 Thread Wiles, Keith
> On Jul 11, 2019, at 2:53 AM, Olivier Matz wrote: > > Hi Keith, > > On Wed, Jul 10, 2019 at 06:12:16PM +, Wiles, Keith wrote: >> >> >>> On Jul 10, 2019, at 12:49 PM, Stephen Hemminger >>> wrote: >>> >>> On Wed, 10 Jul 2019 11:29:07 +0200 >>> Olivier Matz wrote: >>> /** *

[dpdk-dev] [PATCH v3] devtools: better freebsd support

2019-07-11 Thread Olivier Matz
- As "readlink -e" and "readlink -m" do not exist on freebsd, use "readlink -f", it should not have any impact in these cases. - "sed -ri" is invalid on freebsd and should be replaced by "sed -ri=''" - Use gmake instead of make. This fixes the following command: SYSDIR=/usr/src/sys ./devtool

Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support

2019-07-11 Thread Olivier Matz
Hi, On Tue, Jul 09, 2019 at 12:05:59PM +0100, Musatescu, Flavia wrote: > > On 05/07/2019 14:58, Olivier Matz wrote: > > - As "readlink -e" and "readlink -m" do not exist on freebsd, > >use "readlink -f", it should not have any impact in these cases. > > - "sed -ri" is invalid on freebsd and s

Re: [dpdk-dev] [PATCH] net/pcap: fix issue with unnecessary mbufs freeing

2019-07-11 Thread Ferruh Yigit
On 7/11/2019 2:59 PM, A.McLoughlin wrote: > In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed > without incrementing num_tx. To fix the issue, the mbuf freeing was > removed as it was not of any benefit. > > Fixes: 6db141c91e1f ("pcap: support jumbo frames") > Cc: sta...@dpd

Re: [dpdk-dev] Dpdk version 17.11.4 (i40e) switchover is not working

2019-07-11 Thread Bruce Richardson
On Thu, Jul 11, 2019 at 06:54:31PM +0530, chetan bhasin wrote: > Hello Everyone, > > I have figured out the DPDK version , i.e 18.11.2 , where LSC is working > fine for i40e (X722) under bond setup. > > So command-line I am using is > ./testpmd -c f -n 4 --vdev > 'net_bonding0,mode=1,slave=

[dpdk-dev] [PATCH] net/pcap: fix issue with unnecessary mbufs freeing

2019-07-11 Thread A.McLoughlin
In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed without incrementing num_tx. To fix the issue, the mbuf freeing was removed as it was not of any benefit. Fixes: 6db141c91e1f ("pcap: support jumbo frames") Cc: sta...@dpdk.org Cc: tero@coriant.com Signed-off-by: A.McLou

Re: [dpdk-dev] [PATCH v6 14/15] net/hinic: add Rx/Tx package burst

2019-07-11 Thread Ferruh Yigit
On 6/27/2019 9:19 AM, Ziyang Xuan wrote: > This patch add package sending and receiving function codes. > > Signed-off-by: Ziyang Xuan Hi Ziyang, The lgtm.com tool is reporting some errors on this patch, can you please check: https://lgtm.com/projects/g/DPDK/dpdk/snapshot/b3d3e3a1c7ad57931c28c

Re: [dpdk-dev] [PATCH v2 1/1] app/test: fix --socket-mem option in eal flag autotest

2019-07-11 Thread Aaron Conole
writes: > From: Vamsi Attunuru > > eal flag autotest fails when multiple mem size flags are passed > to --socket-mem option irrespective of RTE_MAX_NUMA_NODES. > > Patch fixes --socket-mem option by setting enough numbers > of numa node mem flags based on RTE_MAX_NUMA_NODES config. > > Fixes: 45

[dpdk-dev] [Bug 319] dpdk-i40e could not receive vlan packet whose ip_len was bigger than 1496

2019-07-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=319 Bug ID: 319 Summary: dpdk-i40e could not receive vlan packet whose ip_len was bigger than 1496 Product: DPDK Version: 19.05 Hardware: x86 OS: Linux Statu

Re: [dpdk-dev] Dpdk version 17.11.4 (i40e) switchover is not working

2019-07-11 Thread chetan bhasin
Hello Everyone, I have figured out the DPDK version , i.e 18.11.2 , where LSC is working fine for i40e (X722) under bond setup. So command-line I am using is ./testpmd -c f -n 4 --vdev 'net_bonding0,mode=1,slave=:009:00.2,slave=:009:00.0,primary=:009:00.2' -- -I Can anybody please

[dpdk-dev] [PATCH v1 2/2] test/crypto: add tests for RSA key type CRT

2019-07-11 Thread Ayuj Verma
Added RSA sign/verify and enc/dec tests for RSA key type CRT(quintuple) and associated test vectors. Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- app/test/test_cryptodev_asym.c | 97 ++ app/test/test_cr

[dpdk-dev] [PATCH v1 1/2] test/crypto: move rsa enqueue/dequeue into separate functions

2019-07-11 Thread Ayuj Verma
Move common code of enqueue/dequeue into separate functions. Signed-off-by: Kanaka Durga Kotamarthy Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- app/test/test_cryptodev_asym.c | 413 - 1 file changed, 199 insertions(+), 214 deletions(-) dif

[dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT

2019-07-11 Thread Ayuj Verma
This patch series add new RSA CRT key based test cases, improve code organization and also rebase it to latest changes. It covers following changes: * Add crt key based rsa sign/verify, enc/decrypt test cases * Move common code of enqueue/dequeue into separate function * Configure device with ff_d

Re: [dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread Burakov, Anatoly
On 11-Jul-19 12:57 PM, Yasufumi Ogawa wrote: On 2019/07/11 19:53, Burakov, Anatoly wrote: On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa <...> +    if (getpid() == 1) { +    FILE *hn_fp; +    hn_fp = fopen("/etc/hostname", "r"); +    if (hn_fp == NULL) {

Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support

2019-07-11 Thread Olivier Matz
On Mon, Jul 08, 2019 at 06:35:25PM +0200, Thomas Monjalon wrote: > 05/07/2019 15:58, Olivier Matz: > > - As "readlink -e" and "readlink -m" do not exist on freebsd, > > use "readlink -f", it should not have any impact in these cases. > > - "sed -ri" is invalid on freebsd and should be replaced by

[dpdk-dev] Failed to hotplug add a device from secondary process

2019-07-11 Thread Ogawa Yasufumi
Hi all, I have developed a multi-process app and am struggling to fix an error while adding PMD from secondary process with hotplug feature. As we reported in [1], I think it is because initializing hogplugged device is changed to be done by primary first, then secondary. However, initialization i

[dpdk-dev] [PATCH] kni: fix possible buffer overflow

2019-07-11 Thread Ferruh Yigit
'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for that case will be wrong and some values can cause buffer overflow in destination mbuf data. Signed-off-by: Ferruh Yigit --- kernel/linux/kni/kni_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/

Re: [dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight

2019-07-11 Thread Yu, Jin
> -Original Message- > From: Bie, Tiwei > Sent: Thursday, July 11, 2019 12:08 PM > To: Yu, Jin > Cc: dev@dpdk.org; Liu, Changpeng ; > maxime.coque...@redhat.com; Wang, Zhihong > Subject: Re: [PATCH v2 2/2] vhost: Add vhost-user-blk example which > support inflight > > On Thu, Jul 11, 2

Re: [dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread Yasufumi Ogawa
On 2019/07/11 19:53, Burakov, Anatoly wrote: On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa <...> +    if (getpid() == 1) { +    FILE *hn_fp; +    hn_fp = fopen("/etc/hostname", "r"); +    if (hn_fp == NULL) { +    RTE_LOG(ERR, EAL, + 

Re: [dpdk-dev] [PATCH] common/octeontx2: add CNF95xx SoC support

2019-07-11 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 10, 2019 10:32 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > ; John McNamara ; > Marko Kovacevic ; Pavan Nikhilesh > Bhagavatula ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.o

Re: [dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread Burakov, Anatoly
On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized se

[dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized secondary has PID 1. To reserve unique name, use hostn

[dpdk-dev] [PATCH v3 0/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread yasufum . o
From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if secondary is run as app container because each of containerized secondary has PID 1. To reserve unique name, use hostn

[dpdk-dev] DPDK Release Status Meeting 11/7/2019

2019-07-11 Thread Ferruh Yigit
Minutes 11 July 2019 Agenda: * Release Dates * RC1 Status * Subtrees * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Mellanox * Red Hat Release Dates - * v19.08 dates: * RC1 is released on Monday 08 July * https://mails.dpdk.org/archives/a

[dpdk-dev] [PATCH v3 11/11] sched: remove redundant macros

2019-07-11 Thread Jasvinder Singh
Remove unused macros from the library, and update release notes. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- doc/guides/rel_notes/release_19_08.rst | 10 +- lib/librte_sched/rte_sched.h | 10 -- 2 files changed, 9 in

[dpdk-dev] [PATCH v3 10/11] examples/qos_sched: add tc and queue config flexibility

2019-07-11 Thread Jasvinder Singh
Update qos sched sample app for configuration flexibility of pipe traffic classes and queues. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/qos_sched/app_thread.c | 9 +- examples/qos_sched/cfg_file.c | 119 +--- examples/q

[dpdk-dev] [PATCH v3 09/11] examples/ip_pipeline: add config flexibility to tm function

2019-07-11 Thread Jasvinder Singh
Update ip pipeline sample app for configuration flexiblity of pipe traffic classes and queues. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/ip_pipeline/cli.c | 45 +++--- examples/ip_pipeline/tmgr.c

[dpdk-dev] [PATCH v3 08/11] test_sched: modify tests for config flexibility

2019-07-11 Thread Jasvinder Singh
update unit tests for configuration flexibility of pipe traffic classes and queues size. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test

[dpdk-dev] [PATCH v3 06/11] sched: improve doxygen comments

2019-07-11 Thread Jasvinder Singh
Improve doxygen comments. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.h | 145 ++- 1 file changed, 93 insertions(+), 52 deletions(-) diff --git a/lib/librte_sched/rte_sched.h b/lib/l

[dpdk-dev] [PATCH v3 07/11] net/softnic: add config flexibility to softnic tm

2019-07-11 Thread Jasvinder Singh
Update softnic tm function for configuration flexiblity of pipe traffic classes and queues size. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- drivers/net/softnic/rte_eth_softnic.c | 131 ++ drivers/net/softnic/rte_eth_softnic_cli.c

[dpdk-dev] [PATCH v3 05/11] sched: improve error log messages

2019-07-11 Thread Jasvinder Singh
Replace hard-coded numbers for reporting errors with error messages. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 295 ++- 1 file changed, 221 insertions(+), 74 deletions(-) diff

[dpdk-dev] [PATCH v3 01/11] sched: remove wrr from strict priority tc queues

2019-07-11 Thread Jasvinder Singh
All higher priority traffic classes contain only one queue, thus remove wrr function for them. The lowest priority best-effort traffic class conitnue to have multiple queues and packet are scheduled from its queues using wrr function. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar S

[dpdk-dev] [PATCH v3 04/11] sched: rename tc3 params to best-effort tc

2019-07-11 Thread Jasvinder Singh
Change the traffic class 3 related params name to best-effort(be) traffic class. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 48 ++-- 1 file changed, 24 insertions(+), 24 deletion

[dpdk-dev] [PATCH v3 03/11] sched: add max pipe profiles config in run time

2019-07-11 Thread Jasvinder Singh
Allow setting the maximum number of pipe profiles in run time. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 8 +--- lib/librte_sched/rte_sched.h | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH v3 00/11] sched: feature enhancements

2019-07-11 Thread Jasvinder Singh
This patchset refactors the dpdk qos sched library to allow flexibile configuration of the pipe traffic classes and queue sizes. Currently, each pipe has 16 queues hardwired into 4 TCs scheduled with strict priority, and each TC has exactly with 4 queues that are scheduled with Weighted Fair Queui

[dpdk-dev] [PATCH v3 02/11] sched: add config flexibility to tc queue sizes

2019-07-11 Thread Jasvinder Singh
Add support for zero queue sizes of the traffic classes. The queues which are not used can be set to zero size. This helps in reducing memory footprint of the hierarchical scheduler. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sche

Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/af_packet: add string error for system errors

2019-07-11 Thread Krzysztof Kanas
On 19-07-10 09:04, Stephen Hemminger wrote: > External Email > > -- > On Wed, 10 Jul 2019 16:46:30 +0200 > wrote: > > > > > +#define PMD_LOG_ERRNO(level, fmt, args...) \ > > + rte_log(RTE_LOG_ ## level, af_packet_logtype, \

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-11 Thread Jason Wang
On 2019/7/11 下午5:49, Liu, Yong wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, July 11, 2019 12:11 PM To: Liu, Yong ; Bie, Tiwei ; maxime.coque...@redhat.com; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqu

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-11 Thread Liu, Yong
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, July 11, 2019 12:11 PM > To: Liu, Yong ; Bie, Tiwei ; > maxime.coque...@redhat.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue > function > > > On 2019

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-11 Thread Jason Wang
On 2019/7/11 下午5:37, Liu, Yong wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Thursday, July 11, 2019 4:35 PM To: Liu, Yong ; Bie, Tiwei ; maxime.coque...@redhat.com; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enque

Re: [dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread Burakov, Anatoly
On 11-Jul-19 10:37 AM, Yasufumi Ogawa wrote: On 2019/07/09 19:26, Burakov, Anatoly wrote: On 09-Jul-19 11:24 AM, Burakov, Anatoly wrote: On 09-Jul-19 11:22 AM, Yasufumi Ogawa wrote: Hi Anatoly, On 2019/07/05 17:53, Burakov, Anatoly wrote: On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wr

Re: [dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-07-11 Thread Yasufumi Ogawa
On 2019/07/09 19:26, Burakov, Anatoly wrote: On 09-Jul-19 11:24 AM, Burakov, Anatoly wrote: On 09-Jul-19 11:22 AM, Yasufumi Ogawa wrote: Hi Anatoly, On 2019/07/05 17:53, Burakov, Anatoly wrote: On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wrote: From: Yasufumi Ogawa In secondary_msl_

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-11 Thread Liu, Yong
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, July 11, 2019 4:35 PM > To: Liu, Yong ; Bie, Tiwei ; > maxime.coque...@redhat.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue > function > > > On 2019/

Re: [dpdk-dev] [PATCH] vfio: fix build errors on old Linux

2019-07-11 Thread Thomas Monjalon
11/07/2019 11:17, Burakov, Anatoly: > On 11-Jul-19 3:22 AM, Takeshi Yoshimura wrote: > > The commit db90b4969e2e ("vfio: retry creating sPAPR DMA window") > > introduced a build breakage on old Linux. Linux <4.2 does not define ddw in > > struct vfio_iommu_spapr_tce_info. Without ddw, we cannot cha

[dpdk-dev] [PATCH v4 2/2] test/metrics: fix metrics autotest failure

2019-07-11 Thread Harman Kalra
Issue is observed while running 'metrics_autotest' continuously without quiting. During first execution all test cases pass but second run onwards first test case fails as library is already initialized. To resolve, introduced a new API to deinitialise the library after all test cases are executed

  1   2   >