Re: [dpdk-dev] [v4] net/e1000: i219 unit hang issue fix on reset/close

2019-07-09 Thread Anand H. Krishnan
More comments inline: On Tue, Jul 9, 2019 at 9:16 PM Xiao Zhang wrote: > > Unit hang may occur if multiple descriptors are available in the rings > during reset or close. This state can be detected by configure status > by bit 8 in register. If the bit is set and there are pending descriptors > i

Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue function

2019-07-09 Thread Jason Wang
On 2019/7/9 上午1:13, Marvin Liu wrote: In fast enqueue function, will first check whether descriptors are cache aligned. Fast enqueue function will check prerequisites in the beginning. Fast enqueue function do not support chained mbufs, normal function will handle that. Signed-off-by: Marvin L

[dpdk-dev] [Bug 312] i40evf could not receive mulicast packets

2019-07-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=312 Bug ID: 312 Summary: i40evf could not receive mulicast packets Product: DPDK Version: 19.05 Hardware: x86 OS: Linux Status: CONFIRMED Severity: major Pri

[dpdk-dev] [PATCH v3 2/2] net/ice: add safe mode support devarg

2019-07-09 Thread Qi Zhang
Safe mode support is not necessary by default. Driver be initialized without OS package silently may confuse users since most advanced feature are disabled. Add devarg for safe mode enabling only for when user intend to do this. Signed-off-by: Qi Zhang --- -v3: fix wrong logic in parse_bool. -

[dpdk-dev] [PATCH v3 1/2] net/ice: remove unused devargs

2019-07-09 Thread Qi Zhang
Remove devarg "max_queue_pair_num" related code since it is not complete implemented. Fixes: f9cf4f864150 ("net/ice: support device initialization") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 8 -- drivers/net/ice/ice_ethdev.c | 66 ++

[dpdk-dev] [PATCH v2 1/2] net/ice: remove unused devargs

2019-07-09 Thread Qi Zhang
Remove devarg "max_queue_pair_num" related code since it is not complete implemented. Fixes: f9cf4f864150 ("net/ice: support device initialization") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 8 -- drivers/net/ice/ice_ethdev.c | 66 ++

[dpdk-dev] [PATCH v2 2/2] net/ice: add safe mode support devarg

2019-07-09 Thread Qi Zhang
Safe mode support is not necessary by default. Driver be initialized without OS package silently may confuse users since most advanced feature are disabled. Add devarg for safe mode enabling only for when user intend to do this. Signed-off-by: Qi Zhang --- -v2: fix missing return value check f

[dpdk-dev] [PATCH 2/2] net/ice: add safe mode support devarg

2019-07-09 Thread Qi Zhang
Safe mode support is not necessary by default. Driver be initialized without OS package silently may confuse users since most advanced feature are disabled. Add devarg for safe mode enabling only for when user intend to do this. Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 10 +

[dpdk-dev] [PATCH 1/2] net/ice: remove unused devargs

2019-07-09 Thread Qi Zhang
Remove devarg "max_queue_pair_num" related code since it is not complete implemented. Fixes: f9cf4f864150 ("net/ice: support device initialization") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 8 -- drivers/net/ice/ice_ethdev.c | 66 ++

[dpdk-dev] [PATCH v2 2/2] vhost: Add vhost-user-blk example which support inflight

2019-07-09 Thread JinYu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so It can show how there APIs work to support inflight feature. Signed-off-by: JinYu --- V1 - add the case. --- examples/vhost_blk/Makefile | 67 +++ examples/vhost_blk/blk

[dpdk-dev] [PATCH v2 1/2] vhost: support inflight share memory protocol feature

2019-07-09 Thread JinYu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the shared buffer from backend. Then qemu should send it back through VHOST_USER_S

Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide

2019-07-09 Thread Michael Santana Francisco
On Mon, Jul 8, 2019 at 4:18 PM Aaron Conole wrote: > > Thomas Monjalon writes: > > > Hi please find some comments below: > > > > 06/06/2019 13:59, Hari Kumar Vemula: > >> +++ b/doc/guides/prog_guide/meson_ut.rst > >> @@ -0,0 +1,151 @@ > >> +.. SPDX-License-Identifier: BSD-3-Clause > >> + > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 9, 2019 8:07 PM > To: Jerin Jacob Kollanukkaran ; David Marchand > > Cc: dev ; Thomas Monjalon ; Ben > Walker > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode > selection issue. > >> > >> I wouldn

Re: [dpdk-dev] [PATCH] doc: fix PDF build

2019-07-09 Thread Ferruh Yigit
On 7/9/2019 2:11 PM, Thomas Monjalon wrote: > The command "make doc-guides-pdf" is failing because > there are more than 1500 lines in the file MAINTAINERS > which is included in the contributing guide. > > We are facing the issue mentioned in this comment: > https://github.com/sphinx-doc/sphinx/i

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-07-09 Thread Michael Santana Francisco
On 7/1/19 2:07 PM, Michael Santana Francisco wrote: On Mon, Jul 1, 2019 at 6:04 PM Aaron Conole wrote: - rwlock_autotest and hash_readwrite_lf_autotest are taking a little more than 10s, Occasionally the distributor test times out as well. I've moved them as part of a separate patch, tha

Re: [dpdk-dev] [v3] net/e1000: i219 unit hang issue fix on reset/close

2019-07-09 Thread Zhang, Xiao
The tail index was missing in this patch, and a new patch is sent out. -Original Message- From: Anand H. Krishnan [mailto:anandhkrish...@gmail.com] Sent: Tuesday, July 9, 2019 2:37 PM To: Zhang, Xiao Cc: dev@dpdk.org; Zhao1, Wei Subject: Re: [dpdk-dev] [v3] net/e1000: i219 unit hang is

[dpdk-dev] [v4] net/e1000: i219 unit hang issue fix on reset/close

2019-07-09 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. This state can be detected by configure status by bit 8 in register. If the bit is set and there are pending descriptors in one of the rings, we must flush them before reset or close. Signed-off-by: Xiao

Re: [dpdk-dev] [PATCH v6] power: add fifo per core for JSON interface

2019-07-09 Thread Thomas Monjalon
09/07/2019 17:27, Hunt, David: > Hi Thomas, > > Fyi, I am unable mark v4 as superseded in patchwork > (http://patches.dpdk.org/project/dpdk/list/?series=4997), although I've > done that with v5, v6 is the latest version. OK, done, thanks

Re: [dpdk-dev] [PATCH v6] power: add fifo per core for JSON interface

2019-07-09 Thread Hunt, David
Hi Thomas,    Fyi, I am unable mark v4 as superseded in patchwork (http://patches.dpdk.org/project/dpdk/list/?series=4997), although I've done that with v5, v6 is the latest version. Rgds, Dave. On 09/07/2019 16:21, David Hunt wrote: From: Marcin Hajkowski This patch implements a separat

Re: [dpdk-dev] [PATCH v5] power: add fifo per core for JSON interface

2019-07-09 Thread Hunt, David
Hi Anatoly, On 09/07/2019 16:12, Burakov, Anatoly wrote: On 09-Jul-19 4:07 PM, David Hunt wrote: From: Marcin Hajkowski This patch implements a separate FIFO for each cpu core to improve the previous functionality where anyone with access to the FIFO could affect any core on the system. By us

[dpdk-dev] [PATCH v6] power: add fifo per core for JSON interface

2019-07-09 Thread David Hunt
From: Marcin Hajkowski This patch implements a separate FIFO for each cpu core to improve the previous functionality where anyone with access to the FIFO could affect any core on the system. By using appropriate permissions, fifo interfaces can be configured to only affect the particular cores.

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 4:12 PM, Thomas Monjalon wrote: 09/07/2019 17:02, Burakov, Anatoly: When IOMMU is fully enabled (iommu=on at boot time), igb_uio will simply not work. VFIO will work, whichever address mode you use. When IOMMU is in pass-through mode (iommu=pt at boot time), both igb_uio and VFIO w

Re: [dpdk-dev] [PATCH v5] power: add fifo per core for JSON interface

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 4:07 PM, David Hunt wrote: From: Marcin Hajkowski This patch implements a separate FIFO for each cpu core to improve the previous functionality where anyone with access to the FIFO could affect any core on the system. By using appropriate permissions, fifo interfaces can be configu

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Thomas Monjalon
09/07/2019 17:02, Burakov, Anatoly: > When IOMMU is fully enabled (iommu=on at boot time), igb_uio will simply > not work. VFIO will work, whichever address mode you use. > > When IOMMU is in pass-through mode (iommu=pt at boot time), both igb_uio > and VFIO will work, although igb_uio will only

[dpdk-dev] [PATCH v3 2/2] examples/multi_process - fix crash in mp_client with sparse ports

2019-07-09 Thread Stephen Hemminger
From: Stephen Hemminger The mp_client crashes if run on Azure or any system where ethdev ports are owned. In that case, the tx_buffer and tx_stats for the real port were initialized correctly, but the wrong port was used. For example if the server has Ports 3 and 5. Then calling rte_eth_tx_buffe

[dpdk-dev] [PATCH v3 1/2] examples/multi_process/client_server_mp: check port validity

2019-07-09 Thread Stephen Hemminger
From: Stephen Hemminger The mp_server incorrectly allows a port mask that included hidden ports and which later caused either lost packets or failed initialization. This fixes explicitly checking that each bit in portmask is a valid port before using it. The max_ports parameter is no longer nec

[dpdk-dev] [PATCH v3 0/2] examples/client_server_mp: fix port issues

2019-07-09 Thread Stephen Hemminger
The client_server_mp application does not work correctly Azure/Hyper-V because it does not handle the concept of some ports being hidden and unavailable. Stephen Hemminger (2): examples/multi_process/client_server_mp: check port validity examples/multi_process - fix crash in mp_client with spa

[dpdk-dev] [PATCH v5] power: add fifo per core for JSON interface

2019-07-09 Thread David Hunt
From: Marcin Hajkowski This patch implements a separate FIFO for each cpu core to improve the previous functionality where anyone with access to the FIFO could affect any core on the system. By using appropriate permissions, fifo interfaces can be configured to only affect the particular cores.

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 4:04 PM, Thomas Monjalon wrote: 09/07/2019 16:37, Burakov, Anatoly: My view would be to always run in IOVA as VA by default and only falling back to IOVA as PA if there is a need to do that. Yet, it seems that whenever i try to bring this up, the response (not necessarily from you,

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Thomas Monjalon
09/07/2019 16:37, Burakov, Anatoly: > My view would be to always run in IOVA as VA by default and only falling > back to IOVA as PA if there is a need to do that. Yet, it seems that > whenever i try to bring this up, the response (not necessarily from you, > so this is not directed at you specif

Re: [dpdk-dev] [PATCH] doc: deprecation notice for change of ether struct alignment

2019-07-09 Thread Bruce Richardson
On Tue, Jul 09, 2019 at 07:59:53AM -0700, Stephen Hemminger wrote: > On Tue, 9 Jul 2019 15:58:36 +0100 > Bruce Richardson wrote: > > > The ethernet address structure alignment will be changed to 2B alignment in > > 19.11. Flag this to users. > > > > Impact is expected to be minimal for this cha

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 3:58 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 9, 2019 8:24 PM To: Jerin Jacob Kollanukkaran ; David Marchand Cc: dev ; Thomas Monjalon ; Ben Walker Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA m

Re: [dpdk-dev] [PATCH v9 00/11] ether: improvements and optimizations

2019-07-09 Thread Bruce Richardson
On Mon, Jul 08, 2019 at 08:13:06PM +0100, Ferruh Yigit wrote: > On 7/8/2019 7:26 PM, Stephen Hemminger wrote: > > This is a collection of patches around the ethernet address > > manipulation routines in librte_net/rte_ether. > > > > v9 > >add missing librte_net for new octoeonx2 > > v8 > >

Re: [dpdk-dev] [PATCH] doc: deprecation notice for change of ether struct alignment

2019-07-09 Thread Stephen Hemminger
On Tue, 9 Jul 2019 15:58:36 +0100 Bruce Richardson wrote: > The ethernet address structure alignment will be changed to 2B alignment in > 19.11. Flag this to users. > > Impact is expected to be minimal for this change since ethernet addresses > are generally 2B aligned anyway. > > Signed-off-b

[dpdk-dev] [PATCH] doc: deprecation notice for change of ether struct alignment

2019-07-09 Thread Bruce Richardson
The ethernet address structure alignment will be changed to 2B alignment in 19.11. Flag this to users. Impact is expected to be minimal for this change since ethernet addresses are generally 2B aligned anyway. Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/deprecation.rst | 5 + 1

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 9, 2019 8:24 PM > To: Jerin Jacob Kollanukkaran ; David Marchand > > Cc: dev ; Thomas Monjalon ; Ben > Walker > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode > selection > > On 09-Jul-19 3:00 PM

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 3:00 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 9, 2019 7:00 PM To: Jerin Jacob Kollanukkaran ; David Marchand Cc: dev ; Thomas Monjalon ; Ben Walker Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA m

Re: [dpdk-dev] [PATCH] doc: update release notes for OCTEON TX2 support

2019-07-09 Thread Thomas Monjalon
09/07/2019 15:35, jer...@marvell.com: > Update release notes for various OCTEON TX2 drivers supported for 19.08. Sorry Jerin, I really forgot to mention OCTEON TX2 in the -rc1 announce. 2 advices to avoid such miss: - update release notes with code patches - announce features in a roadmap email

Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"

2019-07-09 Thread Stephen Hemminger
On Fri, 7 Jun 2019 16:08:41 -0700 Stephen Hemminger wrote: > From: Stephen Hemminger > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. > That commit breaks support for netvsc PMD with MLX SRIOV > on both Hyper-V and Azure. > > Signed-off-by: Stephen Hemminger DPDK 19.08-rc i

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 3:00 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 9, 2019 7:00 PM To: Jerin Jacob Kollanukkaran ; David Marchand Cc: dev ; Thomas Monjalon ; Ben Walker Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA m

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 9, 2019 7:21 PM > To: Jerin Jacob Kollanukkaran ; David Marchand > > Cc: dev ; Thomas Monjalon ; Ben > Walker > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode > selection > > On 09-Jul-19 2:30

Re: [dpdk-dev] [PATCH] net/softnic: fix pipeline time calculation

2019-07-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Wang, Xiao W > Sent: Tuesday, July 9, 2019 3:00 PM > To: Dumitrescu, Cristian ; Singh, Jasvinder > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/softnic: fix pipeline time calculation > > > > > -Original Message- > > From: Dumitre

[dpdk-dev] [PATCH] fbarray: fix fbarray destruction

2019-07-09 Thread Anatoly Burakov
Currently, when fbarray is destroyed, the fbarray structure is not zeroed out, which leads to stale data being there and confusing secondary process init in legacy mem mode. Fix it by always memsetting the fbarray to zero when destroying it. Fixes: 5b61c62cfd76 ("fbarray: add internal tailq for ma

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 9, 2019 7:00 PM > To: Jerin Jacob Kollanukkaran ; David Marchand > > Cc: dev ; Thomas Monjalon ; Ben > Walker > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode > selection > > On 09-Jul-19 1:11 PM

Re: [dpdk-dev] [PATCH] net/softnic: fix pipeline time calculation

2019-07-09 Thread Wang, Xiao W
> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, July 9, 2019 6:32 PM > To: Wang, Xiao W ; Singh, Jasvinder > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/softnic: fix pipeline time calculation > > > > > -Original Message- > > From: Wang, X

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 2:30 PM, Burakov, Anatoly wrote: On 09-Jul-19 1:11 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 9, 2019 5:10 PM To: Jerin Jacob Kollanukkaran ; David Marchand Cc: dev ; Thomas Monjalon ; Ben Walker Subject: Re: [EXT] R

Re: [dpdk-dev] [EXT] [RFC PATCH] vfio: move eventfd/interrupt pairing at setup time

2019-07-09 Thread Shahed Shaikh
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, July 2, 2019 6:18 PM > To: dev@dpdk.org > Cc: anatoly.bura...@intel.com; alex.william...@redhat.com; > maxime.coque...@redhat.com; tho...@monjalon.net; > step...@networkplumber.org > Subject: [EXT] [dpdk-dev] [RF

[dpdk-dev] [PATCH] doc: update release notes for OCTEON TX2 support

2019-07-09 Thread jerinj
From: Jerin Jacob Update release notes for various OCTEON TX2 drivers supported for 19.08. Signed-off-by: Jerin Jacob --- doc/guides/rel_notes/release_19_08.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 1:11 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 9, 2019 5:10 PM To: Jerin Jacob Kollanukkaran ; David Marchand Cc: dev ; Thomas Monjalon ; Ben Walker Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA m

[dpdk-dev] [PATCH] doc: fix PDF build

2019-07-09 Thread Thomas Monjalon
The command "make doc-guides-pdf" is failing because there are more than 1500 lines in the file MAINTAINERS which is included in the contributing guide. We are facing the issue mentioned in this comment: https://github.com/sphinx-doc/sphinx/issues/3099#issuecomment-256440704 Anyway the file MAINT

Re: [dpdk-dev] [PATCH v2 1/1] net/hinic: use mutex replace spin lock

2019-07-09 Thread Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)
> On 7/5/2019 7:47 AM, Ziyang Xuan wrote: > > Using spin lock to protect critical resources of sending mgmt > > messages. This will make high CPU usage for rte_delay_ms when sending > > mgmt messages frequently. We can use mutex to protect the critical > > resources and usleep to reduce CPU usage w

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic: use mutex replace spin lock

2019-07-09 Thread Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)
> On Wed, 3 Jul 2019 23:35:42 +0800 > Ziyang Xuan wrote: > > > > > +static inline int hinic_mutex_init(pthread_mutex_t *pthreadmutex, > > + const pthread_mutexattr_t *mattr) { > > + int err; > > + > > + err = pthread_mutex_init(pthreadmutex, mattr); > > + i

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 9, 2019 5:10 PM > To: Jerin Jacob Kollanukkaran ; David Marchand > > Cc: dev ; Thomas Monjalon ; Ben > Walker > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode > selection > >>> ___

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 12:13 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 9, 2019 3:15 PM To: Jerin Jacob Kollanukkaran ; David Marchand Cc: dev ; Thomas Monjalon ; Ben Walker Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Phil Yang (Arm Technology China) > Sent: Tuesday, July 9, 2019 2:58 PM > To: Pavan Nikhilesh Bhagavatula ; Honnappa > Nagarahalli ; Jerin Jacob Kollanukkaran > ; dev@dpdk.org > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Gavin Hu (Arm > Technology China) ;

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 9, 2019 3:15 PM > To: Jerin Jacob Kollanukkaran ; David Marchand > > Cc: dev ; Thomas Monjalon ; Ben > Walker > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] bus/pci: fix IOVA as VA mode > selection > > On 08-Jul-19 8:13 PM

[dpdk-dev] [PATCH] librte_flow_classify: fix out-of-bounds access

2019-07-09 Thread Bernard Iremonger
This patch fixes the out-of-bounds coverity issue by removing the offending line of code at line 107 in rte_flow_classify_parse.c which is never executed. Coverity issue: 343454 Fixes: be41ac2a330f ("flow_classify: introduce flow classify library") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremo

Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support

2019-07-09 Thread Musatescu, Flavia
On 05/07/2019 14:58, Olivier Matz wrote: - As "readlink -e" and "readlink -m" do not exist on freebsd, use "readlink -f", it should not have any impact in these cases. - "sed -ri" is invalid on freebsd and should be replaced by "sed -ri=''" - Use gmake instead of make. This fixes the fol

Re: [dpdk-dev] [PATCH] net/octeontx2: add PF and VF action support

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Jerin Jacob Kollanukkaran > Sent: Monday, July 8, 2019 10:26 AM > To: Kiran Kumar Kokkilagadda ; dev@dpdk.org > Cc: Kiran Kumar Kokkilagadda > Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: add PF and VF action > support > > > -Original M

[dpdk-dev] [PATCH v9 2/2] net/mlx5: match GRE's key and present bits

2019-07-09 Thread Xiaoyu Min
support matching on the present bits (C,K,S) as well as the optional key field. If the rte_flow_item_gre_key is specified in pattern, it will set K present match automatically. Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_19_08.rst | 1 + drivers/n

[dpdk-dev] [PATCH v9 0/2] match on GRE's key

2019-07-09 Thread Xiaoyu Min
This series patchs are based on RFC [1], which enable the matching on GRE's key field. And enabled MLX5 device supports on this. [1] https://patches.dpdk.org/patch/53432/ --- v2: * remove struct rte_flow_item_gre_key in order to comply new convention v3: * updated release note * fixed one b

[dpdk-dev] [PATCH v9 1/2] net/mlx5: support match GRE protocol on DR engine

2019-07-09 Thread Xiaoyu Min
DR engine support matching on GRE protocol field without MPLS supports. So bypassing the MPLS check when DR is enabled. Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/

Re: [dpdk-dev] [PATCH v8 2/2] net/mlx5: match GRE's key and present bits

2019-07-09 Thread Jack Min
On Tue, 19-07-09, 11:54, Thomas Monjalon wrote: > 09/07/2019 11:02, Xiaoyu Min: > > --- a/doc/guides/rel_notes/release_19_08.rst > > +++ b/doc/guides/rel_notes/release_19_08.rst > > @@ -191,6 +191,11 @@ New Features > >Added telemetry mode to l3fwd-power application to report > >application

Re: [dpdk-dev] [PATCH 1/3] net/bnx2x: fix read VF id

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Rasesh Mody > Sent: Thursday, July 4, 2019 5:13 AM > To: dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yi...@intel.com; GR- > Everest-DPDK-Dev ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/3] net/bnx2x: fix read VF id > > The logic, to read vf_id

Re: [dpdk-dev] [PATCH] net/softnic: fix pipeline time calculation

2019-07-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Wang, Xiao W > Sent: Sunday, June 2, 2019 11:46 AM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > sta...@dpdk.org > Subject: RE: [PATCH] net/softnic: fix pipeline time calculation > > > > > -Original Message- > > From: Singh,

Re: [dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 11:24 AM, Burakov, Anatoly wrote: On 09-Jul-19 11:22 AM, Yasufumi Ogawa wrote: Hi Anatoly, On 2019/07/05 17:53, Burakov, Anatoly wrote: On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays

Re: [dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-07-09 Thread Burakov, Anatoly
On 09-Jul-19 11:22 AM, Yasufumi Ogawa wrote: Hi Anatoly, On 2019/07/05 17:53, Burakov, Anatoly wrote: On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among sec

Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-07-09 Thread Burakov, Anatoly
On 08-Jul-19 6:45 PM, Thomas Monjalon wrote: 08/07/2019 18:47, David Christensen: Please, any review or ack for this patch? 07/06/2019 04:28, Takeshi Yoshimura: sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. However, Linux 4.17 or before returns incorrect page_shift for

Re: [dpdk-dev] [PATCH v2 1/1] fbarray: get fbarrays from containerized secondary

2019-07-09 Thread Yasufumi Ogawa
Hi Anatoly, On 2019/07/05 17:53, Burakov, Anatoly wrote: On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wrote: From: Yasufumi Ogawa In secondary_msl_create_walk(), it creates a file for fbarrays with its PID for reserving unique name among secondary processes. However, it does not work if

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: rework api of rsa algorithm

2019-07-09 Thread Kusztal, ArkadiuszX
To clarify bit more With [AK2] > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kusztal, ArkadiuszX > Sent: Monday, July 8, 2019 7:44 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shally.ve...@caviumnetworks.com > Subject: Re: [

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

2019-07-09 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, July 9, 2019 12:43 > To: Ruifeng Wang (Arm Technology China) ; > vladimir.medved...@intel.com; bruce.richard...@intel.com > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > Honnappa Nagarahalli ; nd > ; nd > Subject

Re: [dpdk-dev] /run/dpdk cleanup

2019-07-09 Thread Burakov, Anatoly
On 08-Jul-19 4:00 PM, Shubhachint, Chaitanya wrote: Hello, I run my dpdk applications with "file-prefix" option, so I can run them concurrently. I see that it creates a runtime directory under /var/run/dpdk. This directory still persists after the application has terminated. The code calls rt

Re: [dpdk-dev] [PATCH v8 2/2] net/mlx5: match GRE's key and present bits

2019-07-09 Thread Thomas Monjalon
09/07/2019 11:02, Xiaoyu Min: > --- a/doc/guides/rel_notes/release_19_08.rst > +++ b/doc/guides/rel_notes/release_19_08.rst > @@ -191,6 +191,11 @@ New Features >Added telemetry mode to l3fwd-power application to report >application level busyness, empty and full polls of rte_eth_rx_burst().

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Burakov, Anatoly
On 08-Jul-19 8:13 PM, Jerin Jacob Kollanukkaran wrote: See below, Please send the email as text to avoid formatting issue.(No HTML) From: David Marchand Sent: Tuesday, July 9, 2019 12:09 AM To: Jerin Jacob Kollanukkaran Cc: dev ; Thomas Monjalon ; Ben Walker ; Burakov, Anatoly Subject: [EXT

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Bruce Richardson
On Tue, Jul 09, 2019 at 09:05:07AM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, July 9, 2019 2:10 PM > > To: Jerin Jacob Kollanukkaran > > Cc: David Marchand ; dev ; > > Thomas Monjalon ; Ben Walker > > ; Burakov, Anatoly > >

Re: [dpdk-dev] [PATCH] examples: modify error message for ip pipeline

2019-07-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Babu Radhakrishnan, AgalyaX > Sent: Friday, June 14, 2019 3:06 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Dumitrescu, Cristian > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH] examples: modify error message for ip pipeline > > From: Agalya Babu RadhaK

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-09 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Friday, July 5, 2019 12:37 PM > To: Honnappa Nagarahalli ; > jer...@marvell.com; Phil Yang (Arm Technology China) > ; dev@dpdk.org > Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Gavin Hu (Arm > Technology China) ; nd ; >

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, July 9, 2019 2:10 PM > To: Jerin Jacob Kollanukkaran > Cc: David Marchand ; dev ; > Thomas Monjalon ; Ben Walker > ; Burakov, Anatoly > > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode > selection > >

[dpdk-dev] [PATCH v8 2/2] net/mlx5: match GRE's key and present bits

2019-07-09 Thread Xiaoyu Min
support matching on the present bits (C,K,S) as well as the optional key field. If the rte_flow_item_gre_key is specified in pattern, it will set K present match automatically. Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko --- doc/guides/rel_notes/release_19_08.rst | 5 ++ drivers/

[dpdk-dev] [PATCH v8 0/2] match on GRE's key

2019-07-09 Thread Xiaoyu Min
This series patchs are based on RFC [1], which enable the matching on GRE's key field. And enabled MLX5 device supports on this. [1] https://patches.dpdk.org/patch/53432/ --- v2: * remove struct rte_flow_item_gre_key in order to comply new convention v3: * updated release note * fixed one b

[dpdk-dev] [PATCH v8 1/2] net/mlx5: support match GRE protocol on DR engine

2019-07-09 Thread Xiaoyu Min
DR engine support matching on GRE protocol field without MPLS supports. So bypassing the MPLS check when DR is enabled. Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/

[dpdk-dev] [PATCH v3] app/pdump: enforcing pdump to use sw mempool

2019-07-09 Thread Harman Kalra
A secondary process cannot access HW mempool already initiazed by primary, and neither it can setup its own HW mempool due to its own restrictions. Since dpdk-pdump creates mempool for managing its local mbufs, SW mempool is capable enough to solve this purpose. Signed-off-by: Harman Kalra ---

Re: [dpdk-dev] [EXT] Re: [PATCH] bus/pci: fix IOVA as VA mode selection

2019-07-09 Thread Bruce Richardson
On Mon, Jul 08, 2019 at 07:13:28PM +, Jerin Jacob Kollanukkaran wrote: > See below, > > Please send the email as text to avoid formatting issue.(No HTML) > > From: David Marchand > Sent: Tuesday, July 9, 2019 12:09 AM > To: Jerin Jacob Kollanukkaran > Cc: dev ; Thomas Monjalon ; Ben Walker

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-09 Thread Adrien Mazarguil
On Fri, Jul 05, 2019 at 06:05:50PM +, Yongseok Koh wrote: > > On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil > > wrote: > > > > On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: > >> A tag is a transient data which can be used during flow match. This can be > >> used to store match

[dpdk-dev] [PATCH v4] net/memif: zero-copy slave

2019-07-09 Thread Jakub Grajciar
Zero-copy slave support for memif PMD. Slave interface exposes DPDK memory to master interface. Only single file segments are supported (EAL option --single-file-segments). Signed-off-by: Jakub Grajciar --- doc/guides/nics/memif.rst | 29 ++ drivers/net/memif/Makefile

Re: [dpdk-dev] [RFC] ethdev: support input set change by RSS action

2019-07-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Zhang, Qi Z > Sent: Tuesday, July 9, 2019 11:11 AM > To: Adrien Mazarguil > Cc: Su, Simei ; Wu, Jingjing ; > Xing, Beilei ; Yang, Qiming ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] ethdev: support input set change by RSS action > > Right,

[dpdk-dev] dpdk-i40e could not receive vlan packet whose ip_len was bigger than 1496

2019-07-09 Thread tb.bingel
Hi all, I found dpdk-i40e could not receive vlan packet whose ip_len was bigger than 1496, and I tested the same test cases with i350(igb) network card, NO such issue. Was it a bug in DPDK? Thanks! Test Environment?? * netcard : Ethernet controller: Intel Corporation Ethernet Controller