Re: [dpdk-dev] [PATCH v2] net/ice: add link-up and link-down functions

2019-05-03 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Friday, May 3, 2019 1:59 PM > To: dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > > Cc: Huang, Peng ; Wang, Haiyue > > Subject: [PATCH v2] net/ice: add link-up and link-down functions > > Support link up and down functions for ice, and when

[dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-03 Thread Erik Gabriel Carrillo
The finalize function should free the memzone created in the init function, rather than freeing the allocation the memzone references, otherwise a memzone descriptor can be leaked. Fixes: c0749f7096c7 ("timer: allow management in shared memory") Signed-off-by: Erik Gabriel Carrillo --- changes i

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Dharmik Thakkar
Hi Yongseok, Thank you for the patch! I have tested it on Bluefield reference platform. It works fine. One observation: Even though I used 'make config T=arm64-bluefield-linuxapp-gcc’, at the end of the build process it said 'Build complete [arm64-armv8a-linuxapp-gcc]’ Tested-by: Dharmik Thakk

Re: [dpdk-dev] [PATCH] timer: fix reset/stop in callback for new API

2019-05-03 Thread Thomas Monjalon
26/04/2019 16:41, Erik Gabriel Carrillo: > The rte_timer_alt_manage function should track which is the running > timer and whether or not it was updated by a callback in the priv_timer > structure that corresponds to the running lcore, so that restarting > or stopping the timer from the callback wo

Re: [dpdk-dev] [PATCH] timer: fix pointer to local outside scope

2019-05-03 Thread Thomas Monjalon
24/04/2019 16:33, Erik Gabriel Carrillo: > A null array is allowed to be passed as one of the parameters to > rte_timer_alt_manage() as a convenience. When that happened, an > anonymous array was created using compound literal syntax, and Coverity > detected that the object was out of scope in lat

Re: [dpdk-dev] [PATCH] event/dsw: fix dsw capabilities

2019-05-03 Thread Thomas Monjalon
03/05/2019 21:18, Jerin Jacob Kollanukkaran: > From: dev On Behalf Of Mattias Rönnblom > > > > The DSW event device didn't set > > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT > > and RTE_EVENT_DEV_CAP_NONSEQ_MODE, even though it has both these > > capabilities. > > > > Cc: sta...@dpdk.org > > > Fixe

Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message

2019-05-03 Thread Thomas Monjalon
27/04/2019 08:58, Rami Rosen: > > On 26-Apr-19 5:22 PM, Kevin Traynor wrote: > > > "VFIO group is not viable" error message is correct > > > but not very user friendly for something which can > > > usually be easily rectified. > > > > > > Add some additional text to give more of a hint. > > > > > >

Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process

2019-05-03 Thread Thomas Monjalon
29/04/2019 12:02, Ruifeng Wang: > Replaced multiple neon instructions with single equivalent instruction. > This made simpler code and a bit higher performance. > Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 > platforms. As it is an improvement (with small benefit), I don't

Re: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

2019-05-03 Thread Thomas Monjalon
02/05/2019 17:55, Mcnamara, John: > From: David Hunt > > In the Power Library, a new bit has been added to the mask returned by > > rte_power_get_capabilities which indicates whether the core is an Intel > > SST-BF high frequency core. > > > > The Distributor sample app has also been enhanced to m

Re: [dpdk-dev] [PATCH] event/dsw: fix dsw capabilities

2019-05-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Mattias Rönnblom > Sent: Friday, May 3, 2019 10:16 PM > To: dev@dpdk.org > Cc: Mattias Rönnblom > Subject: [dpdk-dev] [PATCH] event/dsw: fix dsw capabilities > > The DSW event device didn't set > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT > and RT

Re: [dpdk-dev] Memory footprint of a PMD

2019-05-03 Thread Stephen Hemminger
On Fri, 3 May 2019 11:02:15 +0100 "Burakov, Anatoly" wrote: > On 03-May-19 10:37 AM, P Smith wrote: > > Hi, Given that a dpdk driver uses rte_malloc_xx() and friends to > > allocate/free its memory what is the best way to find out the runtime > > memory footprint of a PMD ? One can use 'mal

Re: [dpdk-dev] [PATCH 1/3] doc: fix typo in ipc doc

2019-05-03 Thread Rami Rosen
Anatoly Burakov ‏: > The word "syncrhonous" appears twice. Fix it. > > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > Reviewed-by: Rami Rosen

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

2019-05-03 Thread Trahe, Fiona
Forwarding to maintainers of the following crypto PMDs which may be affected by this: mvsam ccp openssl Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed This is the related API change targeted at 19.08: https://patches.dpdk.org/patch/52886/

Re: [dpdk-dev] [PATCH] test: load tests symbols from binary at init

2019-05-03 Thread Aaron Conole
David Marchand writes: > Rather than call nm on the test application binary for each test to > consider, call it once at the object init. > > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Yongseok Koh
On Fri, May 03, 2019 at 04:10:47PM +, Honnappa Nagarahalli wrote: > > > > Hi Yongseok, > > We need to enable 'CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO' > > (which would require a documentation change in [1]). > I enabled this and compiled, the compilation fails. Ideally (as discussed in > other

[dpdk-dev] [PATCH v3 4/5] examples/bond: use lcore accessor

2019-05-03 Thread Stephen Hemminger
Referring to lcore_config directly is no longer recommended. Also remove unnecessary assignment of slave_core_id. Signed-off-by: Stephen Hemminger --- examples/bond/main.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/examples/bond/main.c b/examples/bond/main.

[dpdk-dev] [PATCH v3 1/5] eal: use unsigned int in rte_lcore.h functions

2019-05-03 Thread Stephen Hemminger
Purely cosmetic change, use unsigned int instead of unsigned alone. Signed-off-by: Stephen Hemminger Reviewed-by: David Marchand --- lib/librte_eal/common/include/rte_lcore.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/include/rte_lcore

[dpdk-dev] [PATCH v3 2/5] eal: add accessor functions for lcore_config

2019-05-03 Thread Stephen Hemminger
The fields of the internal EAL core configuration are currently laid bare as part of the API. This is not good practice and limits fixing issues with layout and sizes. Make new accessor functions for the fields used by current drivers and examples. Mark return code functions as experimental since

Re: [dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero

2019-05-03 Thread Thomas Monjalon
03/05/2019 17:52, Burakov, Anatoly: > On 03-May-19 4:35 PM, Thomas Monjalon wrote: > > The function check_input() was returning a bool as error code. > > It is changed to return an int, semantically more correct. > > While at it, make checks of validate_action_name() return > > explicit as describe

[dpdk-dev] [PATCH v3 3/5] bus: use lcore accessor functions

2019-05-03 Thread Stephen Hemminger
The lcore_config structure will be hidden in future release. Signed-off-by: Stephen Hemminger Reviewed-by: David Marchand --- drivers/bus/dpaa/dpaa_bus.c | 6 -- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH v3 5/5] app/test: use lcore accessor functions

2019-05-03 Thread Stephen Hemminger
Don't refer to lcore_config directly. Signed-off-by: Stephen Hemminger Reviewed-by: David Marchand --- app/test/test_cryptodev.c | 2 +- app/test/test_hash_readwrite_lf.c | 14 +++--- app/test/test_ring_perf.c | 22 -- app/test/test_stack_perf.c

[dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI

2019-05-03 Thread Stephen Hemminger
This set of patches makes the lcore_config structure less visible as part of the ABI. This version does not break the ABI (yet) follow on patch moves lcore_config into eal_private.h Changes for v3 (based on David's feedback): - rte_lcore_index should not be experimental - eal map should chain

Re: [dpdk-dev] [EXT] Re: [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Friday, May 3, 2019 9:55 PM > To: Jerin Jacob Kollanukkaran > Cc: Thomas Monjalon ; Reshma Pattan > ; dev@dpdk.org; David Marchand > ; vikto...@rehivetech.com; Gavin Hu (Arm > Technology China) > Subject: [EXT] Re: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression

2019-05-03 Thread David Marchand
On Fri, May 3, 2019 at 5:18 PM Neil Horman wrote: > On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: > > Even if rare, the check script should handle removing a section. > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: sta...@dpdk.org > > > > Sig

Re: [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols

2019-05-03 Thread David Marchand
Hello Ray, On Fri, May 3, 2019 at 6:16 PM Ray Kinsella wrote: > Do you have this script wired into the DPDK CI? > Or is this purely for testing before packaging? > Iirc, Thomas has this script running on the server side. See for example the report for this very patch on the dpdk-test ml: http:

[dpdk-dev] [PATCH] event/dsw: fix dsw capabilities

2019-05-03 Thread Mattias Rönnblom
The DSW event device didn't set RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT and RTE_EVENT_DEV_CAP_NONSEQ_MODE, even though it has both these capabilities. Fixes: 4540ee9c68 ("event/dsw: add device and queue configuration") Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 4 +++- 1

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-03 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, May 3, 2019 5:25 PM > To: Jerin Jacob Kollanukkaran > Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora > 30 > > On Fri, May 03, 2019 at 04:01:38PM +, Je

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-03 Thread Bruce Richardson
On Fri, May 03, 2019 at 04:01:38PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Thursday, May 2, 2019 9:27 PM > > To: Reshma Pattan > > Cc: dev@dpdk.org; David Marchand > > Subject: Re: [dpdk-dev] [PATCH] mk: disable

Re: [dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols

2019-05-03 Thread Ray Kinsella
Hi David, Do you have this script wired into the DPDK CI? Or is this purely for testing before packaging? Ray K On 03/05/2019 15:34, David Marchand wrote: > No need to shout when we are just reordering symbols in a section. > > Signed-off-by: David Marchand > --- > devtools/check-symbol-chang

[dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs

2019-05-03 Thread Fiona Trahe
Added release note entry for QAT compression PMD Clarified that previous entry was for QAT sym crypto PMD Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- doc/guides/rel_notes/release_19_05.rst | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Honnappa Nagarahalli
> > Hi Yongseok, > We need to enable 'CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO' > (which would require a documentation change in [1]). I enabled this and compiled, the compilation fails. Ideally (as discussed in other threads), the PMD code itself does not make use of the crypto instructions, so

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, May 3, 2019 5:58 PM > To: Jerin Jacob Kollanukkaran ; tho...@monjalon.net > Cc: dev@dpdk.org; bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula > ; shah...@mellanox.com; gavin...@arm.com; > honnappa.nagaraha...@arm.com; sta...

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, May 2, 2019 9:27 PM > To: Reshma Pattan > Cc: dev@dpdk.org; David Marchand > Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30 > > 02/05/2019 17:00, David Marchand: > > On Thu, May

Re: [dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero

2019-05-03 Thread Burakov, Anatoly
On 03-May-19 4:35 PM, Thomas Monjalon wrote: The function check_input() was returning a bool as error code. It is changed to return an int, semantically more correct. While at it, make checks of validate_action_name() return explicit as described in the coding guidelines. Signed-off-by: Thomas M

Re: [dpdk-dev] [PATCH] maintainers: claim maintainership of ipc

2019-05-03 Thread Thomas Monjalon
25/04/2019 15:17, Anatoly Burakov: > IPC is a big part of secondary process infrastructure now, > and I have been de-facto maintainer for it since 18.05. > Update MAINTAINERS file to match. > > Signed-off-by: Anatoly Burakov > --- > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -202,6 +202,7 @@ F: d

[dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero

2019-05-03 Thread Thomas Monjalon
The function check_input() was returning a bool as error code. It is changed to return an int, semantically more correct. While at it, make checks of validate_action_name() return explicit as described in the coding guidelines. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_

Re: [dpdk-dev] [PATCH] ipc: handle more invalid parameter cases

2019-05-03 Thread Thomas Monjalon
29/04/2019 15:59, Anatoly Burakov: > Length of buffer and number of fd's to send are signed values, so > they can be negative, but the API doesn't check for that. Fix it > by checking for negative values as well. > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > Cc: st

Re: [dpdk-dev] [PATCH 2/4] devtools: handle section suppression

2019-05-03 Thread Neil Horman
On Fri, May 03, 2019 at 04:34:18PM +0200, David Marchand wrote: > Even if rare, the check script should handle removing a section. > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > devtools/check-symbol-chang

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Honnappa Nagarahalli
Hi Yongseok, We need to enable 'CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO' (which would require a documentation change in [1]). I think this change might have an impact on the existing users. Does this change need to be documented somewhere (at least in the release notes)? [1] https://doc.dpdk

[dpdk-dev] [PATCH 1/4] devtools: do not complain when reordering symbols

2019-05-03 Thread David Marchand
No need to shout when we are just reordering symbols in a section. Signed-off-by: David Marchand --- devtools/check-symbol-change.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 40eb953..8da7650 100755 --- a/dev

Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional tests

2019-05-03 Thread David Marchand
On Wed, May 1, 2019 at 5:55 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > From: Dharmik Thakkar > > Add API positive/negative test cases, functional tests and > performance tests. > > Signed-off-by: Malvika Gupta > Signed-off-by: Dharmik Thakkar > Signed-off-by: Honnappa Naga

[dpdk-dev] [PATCH 2/4] devtools: handle section suppression

2019-05-03 Thread David Marchand
Even if rare, the check script should handle removing a section. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- devtools/check-symbol-change.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-symbol-c

[dpdk-dev] [PATCH 4/4] devtools: fix direct additions to stable API

2019-05-03 Thread David Marchand
The incriminated commit broke the detection of new symbols skipping the EXPERIMENTAL step before entering a stable abi section. sed won't return an error, check a null output instead. Fixes: 3630757803ab ("devtools: accept experimental symbol promotion") Cc: sta...@dpdk.org Signed-off-by: David M

[dpdk-dev] [PATCH 3/4] devtools: fix symbol name in log message

2019-05-03 Thread David Marchand
We have an incorrect variable name in this log. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- devtools/check-symbol-change.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/check-symbol-ch

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-03 Thread Honnappa Nagarahalli
> On Fri, May 03, 2019 at 03:54:09AM +, Honnappa Nagarahalli wrote: > > > >>> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli > > > >>> wrote: > > > >>> > > > >>> Subject: [EXT] [PATCH 5/6] build: add option for armv8 > > > >>> crypto extension > > > >>> > > > >>> CONFIG_RTE_

[dpdk-dev] [RFC PATCH 3/4] examples/vm_power_manager: always compile all C files

2019-05-03 Thread Bruce Richardson
Rather than having an "if" statement in the makefile to select one of two files to build, we can put #ifdefs into the C files themselves so that all files are always built. This is a better approach as the makefile-based approach relies on having the DPDK build system with all it's config settings

[dpdk-dev] [RFC PATCH 4/4] examples/vm_power_manager: support build using pkg-config

2019-05-03 Thread Bruce Richardson
The vm_power_manager example app did not check for a libdpdk pkg-config file and attempt to build using that. Add support for that method of compile to align the app with the other examples. Signed-off-by: Bruce Richardson --- examples/vm_power_manager/Makefile | 80 +++--

[dpdk-dev] [RFC PATCH 1/4] power: make channel commands header public

2019-05-03 Thread Bruce Richardson
The channel_commands.h header file is required by applications wanting to use the power management capabilities - as evidenced by the fact that the vm_power_manager example app needs to include it. Therefore we should make the header file public. Signed-off-by: Bruce Richardson --- examples/vm_p

[dpdk-dev] [RFC PATCH 2/4] power: add namespace prefix to public header elements

2019-05-03 Thread Bruce Richardson
Now that the rte_channel_commands.h header file is public, we need to ensure that all structs and defines there start with an rte_ prefix - in many cases, with an rte_power prefix. Signed-off-by: Bruce Richardson --- examples/vm_power_manager/channel_monitor.c | 72 +-- example

[dpdk-dev] [RFC PATCH 0/4] allow vm_power_manager to build using pkg-config

2019-05-03 Thread Bruce Richardson
The vm_power_manager builds using meson as part of a DPDK build, but did not support building using make and the libdpdk.pc file. Unfortunately, adding this support was not as easy as for other examples, as the vm_power_manager example was depending on a non-public header file in the power library.

[dpdk-dev] [PATCH 19.08 0/6] improve building examples

2019-05-03 Thread Bruce Richardson
This patchset adds support for testing a number of examples using the DPDK pkgconfig file, allowing us to check that the file works. It also includes some more general cleanups for the examples, including adding support for building from pkg-config to a couple of examples which were missing that.

[dpdk-dev] [PATCH 19.08 5/6] examples/vdpa: support building from pkg-config info

2019-05-03 Thread Bruce Richardson
The vdpa example app did not check for a libdpdk pkg-config file and attempt to build using that. Add support for that method of compile to align the app with the other examples. Signed-off-by: Bruce Richardson --- examples/vdpa/Makefile | 55 -- 1 file ch

[dpdk-dev] [PATCH 19.08 6/6] examples/vhost_crypto: support building from pkg-config info

2019-05-03 Thread Bruce Richardson
The vhost_crypto example app did not check for a libdpdk pkg-config file and attempt to build using that. Add support for that method of compile to align the app with the other examples. Signed-off-by: Bruce Richardson --- examples/vhost_crypto/Makefile | 55 +- 1

[dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-03 Thread Bruce Richardson
For testing of DPDK, we want to override the prefix given by the pkg-config file, so that we can get correct paths for DPDK installed in an unusual location. Signed-off-by: Bruce Richardson --- examples/bbdev_app/Makefile | 13 + examples/bond/Makefile |

[dpdk-dev] [PATCH 19.08 3/6] devtools/test-meson-builds: remove dependency on clang

2019-05-03 Thread Bruce Richardson
Allow the script to run with a reduced set of builds if clang, or other compilers, are missing. Signed-off-by: Bruce Richardson --- devtools/test-meson-builds.sh | 38 ++- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/devtools/test-meson-builds.s

[dpdk-dev] [PATCH 19.08 4/6] devtools/test-meson-builds: add testing of pkg-config file

2019-05-03 Thread Bruce Richardson
The pkg-config file generated as part of the build of DPDK should allow applications to be built with an installed DPDK. We can test this as part of the build by doing an install of DPDK to a temporary directory within the build folder, and by then compiling up a few sample apps using make working

[dpdk-dev] [PATCH 19.08 1/6] examples: remove auto-generation of examples list

2019-05-03 Thread Bruce Richardson
The examples/meson.build file scanned the filesystem to find all examples to build (for examples=all option) and install. However, using run_command and scanning the filesystem prevented ninja from properly detecting the addition or removal of any examples - one had to recreate the build directory

Re: [dpdk-dev] [PATCH] ipc: harden message receive function

2019-05-03 Thread Thomas Monjalon
29/04/2019 16:22, Anatoly Burakov: > Currently, IPC does not check received messages for invalid data > and passes them to user code unchanged. This may result in buffer > overruns on reading message data. Fix this by checking the message > length and fd number on receive, and discard any messages

[dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Yongseok Koh
Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. It is known that not all the armv8 platforms have the crypto extension. For example, Mellanox B

Re: [dpdk-dev] [PATCH] ipc: fix send error handling

2019-05-03 Thread Thomas Monjalon
26/04/2019 12:27, Anatoly Burakov: > According to manpage, ENOBUFS error indicates that either the > input or the output queue is full. This should be considered > an error, but it is treated as an "ignore" condition. Fix the > code to report an error instead. > > Fixes: bacaa2754017 ("eal: add ch

[dpdk-dev] [PATCH 3/3] ipc: add warnings about correct API usage

2019-05-03 Thread Anatoly Burakov
When handling synchronous or asynchronous requests, the reply must be sent explicitly even if the result of the operation is an error, to avoid the other side timing out. Make note of this in documentation explicitly. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- doc/guides/prog_guide/

[dpdk-dev] [PATCH 1/3] doc: fix typo in ipc doc

2019-05-03 Thread Anatoly Burakov
The word "syncrhonous" appears twice. Fix it. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- doc/guides/prog_guide/multi_proc_support.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi

[dpdk-dev] [PATCH 2/3] ipc: add warnings about not using ipc with memory API's

2019-05-03 Thread Anatoly Burakov
IPC and memory-related API's should not be mixed because memory relies on IPC internally. Add explicit warnings to IPC API and to the documentation about this. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- doc/guides/prog_guide/env_abstraction_layer.rst | 8 doc/guides/prog_gu

Re: [dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks

2019-05-03 Thread Thomas Monjalon
03/05/2019 12:28, Herakliusz Lipiec: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were

[dpdk-dev] [PATCH v5 2/2] net/tap: fix ipc related memory leak

2019-05-03 Thread Herakliusz Lipiec
When sending synchronous IPC requests, the caller must free the response buffer if the request was successful and reply is no longer needed. Fix the code to correctly use the IPC API. Bugzilla ID: 228 Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Cc: rasl...@mellano

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-03 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, May 3, 2019 5:03 AM > To: Jerin Jacob Kollanukkaran > Cc: Honnappa Nagarahalli ; > bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula > ; Shahaf Shuler ; > dev@dpdk.org; Thomas Monjalon ; Gavin Hu (Arm > Technology China) ; nd

[dpdk-dev] [PATCH v5 1/2] ipc: fix memory leak in sync request

2019-05-03 Thread Herakliusz Lipiec
When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH v5 0/2] ipc: fix possible memory leaks

2019-05-03 Thread Herakliusz Lipiec
When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

Re: [dpdk-dev] Memory footprint of a PMD

2019-05-03 Thread Burakov, Anatoly
On 03-May-19 10:37 AM, P Smith wrote: Hi, Given that a dpdk driver uses rte_malloc_xx() and friends to allocate/free its memory what is the best way to find out the runtime memory footprint of a PMD ? One can use 'malloc_info' to dump the malloc output in case of general 'malloc' ...but wh

Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-03 Thread Yongseok Koh
On Fri, May 03, 2019 at 03:57:20AM +, Honnappa Nagarahalli wrote: > > > On May 1, 2019, at 9:13 PM, Honnappa Nagarahalli > > wrote: > > > > > >> Per armv8 crypto extension support, make build always enable it by > > >> default as long as compiler supports the feature while meson build > > >> o

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-03 Thread Yongseok Koh
On Fri, May 03, 2019 at 03:54:09AM +, Honnappa Nagarahalli wrote: > > >>> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli > > >>> wrote: > > >>> > > >>> Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto > > >>> extension > > >>> > > >>> CONFIG_RTE_MACHINE="armv8a"

[dpdk-dev] Memory footprint of a PMD

2019-05-03 Thread P Smith
Hi, Given that a dpdk driver uses rte_malloc_xx() and friends to allocate/free its memory what is the best way to find out the runtime memory footprint of a PMD ? One can use 'malloc_info' to dump the malloc output in case of general 'malloc' ...but what is the way here since it's all hugepa

Re: [dpdk-dev] DPDK 17.11.5 (LTS) on centos 7.6

2019-05-03 Thread Bruce Richardson
On Fri, May 03, 2019 at 09:14:08AM +, Bhutani, Sudhanshu wrote: > Hi, > > We want to compile DPDK Source code on centos 7.6 and dpdk 17.11.5 release > has to be tested with openvswitch 2.9.3 on centos 7.6 > > > Our kernel version is 3.10.0-957.12.1.el7.x86_64 > > But, DPDK/SPEC/dpdk.spec f

Re: [dpdk-dev] [PATCH v2] power: fix coverity issue

2019-05-03 Thread Hunt, David
On 8/4/2019 5:19 PM, Liang Ma wrote: Fix the resource leaking issue Coverity issue: 337668 Fixes: b60fd5f8b1ce8f0a2c ("power: add bit for high frequency cores") Signed-off-by: Liang Ma --- lib/librte_power/power_pstate_cpufreq.c | 11 --- 1 file changed, 8 insertions(+), 3 deleti

[dpdk-dev] DPDK 17.11.5 (LTS) on centos 7.6

2019-05-03 Thread Bhutani, Sudhanshu
Hi, We want to compile DPDK Source code on centos 7.6 and dpdk 17.11.5 release has to be tested with openvswitch 2.9.3 on centos 7.6 Our kernel version is 3.10.0-957.12.1.el7.x86_64 But, DPDK/SPEC/dpdk.spec file requires below packages for build to be successful: BuildRequires: inkscape Bui

Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks

2019-05-03 Thread Burakov, Anatoly
On 03-May-19 9:34 AM, Thomas Monjalon wrote: 25/04/2019 14:48, Herakliusz Lipiec: When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently han

Re: [dpdk-dev] [PATCH v4 0/2] ipc: fix possible memleaks

2019-05-03 Thread Thomas Monjalon
25/04/2019 14:48, Herakliusz Lipiec: > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this case as if no messages were

Re: [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message

2019-05-03 Thread Thomas Monjalon
24/04/2019 18:46, Stephen Hemminger: > This message was missing newline, and should capitalize > "Cannot" like all the others in this area. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-03 Thread Burakov, Anatoly
On 02-May-19 7:54 PM, Stephen Hemminger wrote: On Thu, 2 May 2019 16:53:50 +0100 "Burakov, Anatoly" wrote: On 02-May-19 3:13 PM, Reshma Pattan wrote: gcc 9 on Fedora 30 gives an error "taking address of packed member may result in an unaligned pointer value" for -Waddress-of-packed-member. R

Re: [dpdk-dev] [PATCH v2 4/5] examples/bond: use lcore accessor

2019-05-03 Thread David Marchand
On Wed, Apr 10, 2019 at 7:16 PM Stephen Hemminger < step...@networkplumber.org> wrote: > Referring to lcore_config directly is no longer recommended. > > Signed-off-by: Stephen Hemminger > --- > examples/bond/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/ex

Re: [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for lcore_config

2019-05-03 Thread David Marchand
On Wed, Apr 10, 2019 at 7:16 PM Stephen Hemminger < step...@networkplumber.org> wrote: > The fields of the internal EAL core configuration are currently > laid bare as part of the API. This is not good practice and limits > fixing issues with layout and sizes. > > Make new accessor functions for t

Re: [dpdk-dev] [PATCH v2 1/5] eal: use unsigned int in rte_lcore.h functions

2019-05-03 Thread David Marchand
On Wed, Apr 10, 2019 at 7:16 PM Stephen Hemminger < step...@networkplumber.org> wrote: > Purely cosmetic change, use unsigned int instead of unsigned alone. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/include/rte_lcore.h | 12 ++-- > 1 file changed, 6 insertions(+)