Re: [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/8] ipc: fix vdev memleak > > When sendi

Re: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:44 PM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 4/8] ipc: fix vfio

Re: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; Zhang, > Qi Z ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak > > When sending sync

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-24 Thread Ye Xiaolong
Hi, Markus On 04/24, Markus Theil wrote: >Hi Xiaolong, > >I also tested with i40e devices, with the same result. > >./dpdk-testpmd -n 4 --log-level=pmd.net.af_xdp:debug --no-pci --vdev >net_af_xdp0,iface=enp36s0f0 --vdev net_af_xdp1,iface=enp36s0f1 >EAL: Detected 16 lcore(s) >EAL: Detected 1 NUMA

[dpdk-dev] [PATCH v3] eventdev: add experimental tag back

2019-04-24 Thread Nikhil Rao
Add the experimental tag back to the Rx event adapter callback, the Rx event callback register and the Rx event adapter statistics retrieval functions due to API change to be proposed in a future patch. This patch also adds the experimental tag to these function definition and adds the functions t

Re: [dpdk-dev] [PATCH v7 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-24 Thread Honnappa Nagarahalli
> > > > > > On Mon, Apr 22, 2019 at 11:31:28PM -0500, Honnappa Nagarahalli > wrote: > > > > Add RCU library supporting quiescent state based memory > > > > reclamation > > > method. > > > > This library helps identify the quiescent state of the reader > > > > threads so that the writers can free th

[dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-24 Thread Ferruh Yigit
This reverts commit bdca79053b6aea504d02691d9319fa976062457f. Not all PMDs support the fixed link speed set, and link speed can be set even with auto negotiation enabled. Reverting the patch to not break existing usage. Signed-off-by: Ferruh Yigit --- Cc: Andrew Rybchenko Cc: WenjieX A Li Cc:

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-04-24 Thread Ido Goshen
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, April 24, 2019 2:47 PM > To: Ido Goshen ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support > > > > > > > From: Ido Goshen > > > > 10BASE-T SFP+ copper transceivers bec

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-24 Thread Markus Theil
Hi Xiaolong, with only one vdev everything works. It stops working if I use two vdevs. Both interfaces were brought up before testing. Best regards, Markus On 24.04.19 16:47, Ye Xiaolong wrote: > Hi, Markus > > On 04/24, Markus Theil wrote: >> Hi Xiaolong, >> >> I also tested with i40e devices,

Re: [dpdk-dev] [PATCH v7 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Wednesday, April 24, 2019 2:53 AM > To: paul...@linux.ibm.com > Cc: konstantin.anan...@intel.com; step...@networkplumber.org; > marko.kovace...@intel.com; dev@dpdk.org; Gavin Hu (Arm Technology China) > ; Dharmik Th

[dpdk-dev] [PATCH v3] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-24 Thread Ayuj Verma
- Return -ENOTSUP for unsupported tests - add NULL check for rte_cryptodev_asym_capability_get() - Typo correction Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- app/test/test_cryptodev_asym.c | 45 ++ 1 file changed, 32 insertions(+), 13 delet

[dpdk-dev] [PATCH v3] fix return value for skipped tests

2019-04-24 Thread Ayuj Verma
Currently some tests return TEST_SKIPPED/-1 when tests or params are not supported for particular PMD because of which tests adds to FAILED test counter in place of Skipped/Unsupported counter. Since unsupported test is not a failure case, replace return value TEST_SKIPPED/-1 with -ENOTSUP Change

Re: [dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references

2019-04-24 Thread Rami Rosen
Acked-by: Rami Rosen

Re: [dpdk-dev] [PATCH] eal: fix formatting of hotplug error message

2019-04-24 Thread Rami Rosen
Acked-by: Rami Rosen

Re: [dpdk-dev] [EXT] Re: ABI and inline functions

2019-04-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ray Kinsella > Sent: Tuesday, April 23, 2019 7:54 PM > To: Jerin Jacob Kollanukkaran ; Stephen Hemminger > > Cc: Bruce Richardson ; Honnappa Nagarahalli > ; dev@dpdk.org; Ananyev, Konstantin > ; tho...@monjalon.net; nd > Subject: Re: [EXT] Re: [dpdk-dev] ABI

Re: [dpdk-dev] [PATCH v2] eventdev: add experimental tag back

2019-04-24 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Nikhil Rao > Sent: Wednesday, April 24, 2019 11:04 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Nikhil Rao ; Jerin Jacob Kollanukkaran > > Subject: [EXT] [PATCH v2] eventdev: add experimental tag back > Add the experimental tag back to the Rx event adapt

[dpdk-dev] [PATCH v3 1/3] rte_ethdev: Add API function to read dev clock

2019-04-24 Thread Tom Barbette
Add rte_eth_read_clock to read the raw clock of a devide. The main use is to get the device clock conversion co-efficients to be able to translate the raw clock of the timestamp field of the pkt mbuf to a local synced time value. This function was missing to allow users to convert the RX timestam

[dpdk-dev] [PATCH v3 3/3] rxtx_callbacks: Add support for HW timestamp

2019-04-24 Thread Tom Barbette
Use rxtx callback to demonstrate a way to use rte_eth_read_clock to convert the hardware timestamps to an amount of cycles. This allows to get the amount of time the packet spent since its entry in the device. While the regular latency only shows the latency from when it entered the software stack

[dpdk-dev] [PATCH v3 2/3] mlx5: Implement support for read_clock

2019-04-24 Thread Tom Barbette
Implements support for read_clock for the mlx5 driver. mlx5 supports hardware timestamp offload, setting packets timestamp field to the device clock. rte_eth_read_clock allows to read the device's current clock value and therefore compare values on similar time base. See rxtx_callbacks for an exam

[dpdk-dev] [PATCH v3 0/3] Add rte_eth_read_clock API

2019-04-24 Thread Tom Barbette
Some NICs allow to timestamp packets, but do not support the full PTP synchronization process. Hence, the value set in the mbuf timestamp field is only the raw value of an internal clock. To make sense of this value, one at least needs to be able to query the current hardware clock value. This pat

[dpdk-dev] [PATCH v2] eventdev: add experimental tag back

2019-04-24 Thread Nikhil Rao
Add the experimental tag back to the Rx event adapter callback and the Rx event callback register functions due to API change to be proposed in a future patch. This patch also adds the experimental tag in the callback register function definition and adds the function to the EXPERIMENTAL section

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix unintentional integer overflow

2019-04-24 Thread Ferruh Yigit
On 4/24/2019 1:41 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Bie, Tiwei >> Sent: Wednesday, April 24, 2019 3:30 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard ; >> dev@dpdk.org >> Cc: sta...@dpdk.org >> Subject: [PATCH] app/testpmd: fix unintentional integer

Re: [dpdk-dev] [PATCH] net/ring: fix return value check

2019-04-24 Thread Ferruh Yigit
On 4/23/2019 4:49 PM, Bruce Richardson wrote: > On Tue, Apr 23, 2019 at 04:31:00PM +0100, Ferruh Yigit wrote: >> 'rte_eth_dev_get_port_by_name()' return value is not checked caught by >> coverity, adding return value check. >> >> Coverity issue: 305853 >> Fixes: 96cb19521147 ("net/ring: use EAL API

Re: [dpdk-dev] [PATCH] net/kni: fix return value check

2019-04-24 Thread Ferruh Yigit
On 4/23/2019 4:43 PM, Ferruh Yigit wrote: > 'rte_kni_release()' return value is not checked, adding it. > > Coverity issue: 336837 > Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 0/4] net/ring: driver fixes

2019-04-24 Thread Ferruh Yigit
On 4/23/2019 5:53 PM, Stephen Hemminger wrote: > Minor fixes and cleanups for the net/ring driver. > > Stephen Hemminger (4): > net/ring: fix coding style > net/ring: use sizeof() with snprintf > net/ring: use rte_calloc_socket > net/ring: check length of ring name For series, Reviewed-by

[dpdk-dev] [PATCH] eal: fix formatting of hotplug error message

2019-04-24 Thread Stephen Hemminger
This message was missing newline, and should capitalize "Cannot" like all the others in this area. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/hotplug_mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/comm

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ice: fix possible null pointer dereference

2019-04-24 Thread Ferruh Yigit
On 4/24/2019 3:43 AM, Wenzhuo Lu wrote: > Fix the issues reported by Coverity check, "Null-checking > vsi suggests that it may be null, but it has already been > dereferenced on all paths leading to the check." > > Coverity issue: 328509 > Coverity issue: 328519 > Coverity issue: 328523 > Fixes: e

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Stephen Hemminger
On Wed, 24 Apr 2019 13:54:51 +0100 "Burakov, Anatoly" wrote: > On 24-Apr-19 1:22 PM, Ray Kinsella wrote: > > > > On 24/04/2019 12:08, Burakov, Anatoly wrote: > >> On 23-Apr-19 3:12 PM, Ray Kinsella wrote: > >>> > >>> > >>> On 18/04/2019 11:28, Bruce Richardson wrote: > On Thu, Apr 18,

[dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references

2019-04-24 Thread Herakliusz Lipiec
Bugzilla ID: 235 Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: bernard.iremon...@intel.com Cc: sta...@dpdk.org Signed-off-by: Herakliusz Lipiec --- doc/guides/prog_guide/lpm_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/lpm_lib.rst b/doc/g

[dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode

2019-04-24 Thread Anatoly Burakov
In no-shconf mode, there is no need to clean runtime directory because it's not created in the first place. Fixes: 0a529578f162 ("eal: clean up unused files on initialization") Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal.c | 5 - 1 file changed, 4 insertions(+), 1 del

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-24 Thread Ye Xiaolong
Hi, Markus On 04/24, Markus Theil wrote: >Hi Xiaolong, > >I also tested with i40e devices, with the same result. > >./dpdk-testpmd -n 4 --log-level=pmd.net.af_xdp:debug --no-pci --vdev >net_af_xdp0,iface=enp36s0f0 --vdev net_af_xdp1,iface=enp36s0f1 >EAL: Detected 16 lcore(s) >EAL: Detected 1 NUMA

[dpdk-dev] [PATCH] timer: fix pointer to local outside scope

2019-04-24 Thread Erik Gabriel Carrillo
A null array is allowed to be passed as one of the parameters to rte_timer_alt_manage() as a convenience. When that happened, an anonymous array was created using compound literal syntax, and Coverity detected that the object was out of scope in later uses of it. Create an object in the proper sco

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-04-24 Thread Luca Boccassi
On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > > On Tue, 2019-04-23 at 23:06 +0100,

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Burakov, Anatoly
On 24-Apr-19 1:22 PM, Ray Kinsella wrote: On 24/04/2019 12:08, Burakov, Anatoly wrote: On 23-Apr-19 3:12 PM, Ray Kinsella wrote: On 18/04/2019 11:28, Bruce Richardson wrote: On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: On Wed, Apr 17, 2019 at 05:12:43AM +, Hon

Re: [dpdk-dev] [PATCH] app/testpmd: fix unintentional integer overflow

2019-04-24 Thread Iremonger, Bernard
> -Original Message- > From: Bie, Tiwei > Sent: Wednesday, April 24, 2019 3:30 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix unintentional integer overflow > > Fix the potential overflow in expression 1

[dpdk-dev] [PATCH] doc: add deprecation notice for sched changes

2019-04-24 Thread Jasvinder Singh
Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to improvements suggested in the RFC- https://mails.

[dpdk-dev] [RFC v3 2/2] eal: introduce random generator function with upper bound

2019-04-24 Thread Mattias Rönnblom
Add a function rte_rand_max() which generates an uniformly distributed pseudo-random number less than a user-specified upper bound. The commonly used pattern rte_rand() % SOME_VALUE creates biased results (as in some values in the range are more frequently occurring than others) if SOME_VALUE is n

[dpdk-dev] [RFC v3 0/2] Pseudo-random number generation improvements

2019-04-24 Thread Mattias Rönnblom
Make rte_rand() multi-thread safe, go faster and produce better-quality pseudo-random numbers. Thanks to Stephen Hemminger, Keith Wiles and Neil Horman for valuable feedback. v3: * Since rte_rand() and rte_srand() have been a part of the API since long, the experimental attribute was removed an

[dpdk-dev] [RFC v3 1/2] eal: replace libc-based random number generation with LFSR

2019-04-24 Thread Mattias Rönnblom
This commit replaces rte_rand()'s use of lrand48() with a DPDK-native combined Linear Feedback Shift Register (LFSR) (also known as Tausworthe) pseudo-number generator, with five sequences. This generator is faster and produces better quality random numbers than libc's lrand48() implementation. Th

Re: [dpdk-dev] [DPDK] devtools: change for ABI back-compatibility checking

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 03:11:59PM +, Peng Huang wrote: > The new default-taget "linux" is introduced in v19.05-rc1 > but not exist in before release such as v19.02 which have > default-target "linuxapp", there is no compatibility report > when run validate-abi.sh to check ABI compatibility bet

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > > The pkg-config file generated as pa

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Ray Kinsella
On 24/04/2019 12:08, Burakov, Anatoly wrote: > On 23-Apr-19 3:12 PM, Ray Kinsella wrote: >> >> >> On 18/04/2019 11:28, Bruce Richardson wrote: >>> On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote

Re: [dpdk-dev] [DPDK] devtools: change for ABI back-compatibility checking

2019-04-24 Thread Neil Horman
On Wed, Apr 24, 2019 at 03:11:59PM +, Peng Huang wrote: > The new default-taget "linux" is introduced in v19.05-rc1 > but not exist in before release such as v19.02 which have > default-target "linuxapp", there is no compatibility report > when run validate-abi.sh to check ABI compatibility bet

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-04-24 Thread Ananyev, Konstantin
> > From: Ido Goshen > > 10BASE-T SFP+ copper transceivers become cheaper and popular > So far those were blocked by ixgbe as “unsupported”. > e.g. > eth_ixgbe_dev_init(): Unsupported SFP+ Module > eth_ixgbe_dev_init(): Hardware Initialization Failure: -19 > EAL: Requested de

[dpdk-dev] [PATCH 5/5] raw/dpaa2_cmdif: remove driver name assignment

2019-04-24 Thread Hemant Agrawal
vdev driver names are not available in create if called from probe. Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 1 - drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/raw

[dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides

2019-04-24 Thread Hemant Agrawal
Update the dpaa platform guides with latest SDK dependency. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst | 4 ++-- doc/guides/eventdevs/dpaa2.rst | 4 ++-- doc/guides/nics/dpaa.rst| 1 + doc/guides/nics/dpaa2.rst | 5 ++--- doc/guides/platform/

[dpdk-dev] [PATCH 3/5] net/dpaa2: fix the loopback spelling

2019-04-24 Thread Hemant Agrawal
Fixes: a3a997f02d07 ("net/dpaa2: support low level loopback tester") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c inde

[dpdk-dev] [PATCH 2/5] raw/dpaa2_qdma: fix spin lock

2019-04-24 Thread Hemant Agrawal
This shall be unlock post the lock Fixes: 4d9a3f2a0159 ("raw/dpaa2_qdma: support RBP mode") Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpa

[dpdk-dev] [PATCH 1/5] raw/dpaa2_qdma: fix spin lock release condition

2019-04-24 Thread Hemant Agrawal
The code shall be unlock post the lock. Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_qdma/dpaa2_q

Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR

2019-04-24 Thread Neil Horman
On Tue, Apr 23, 2019 at 07:13:24PM +0200, Mattias Rönnblom wrote: > On 2019-04-23 13:33, Neil Horman wrote: > > On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote: > > > On 2019-04-22 17:52, Mattias Rönnblom wrote: > > > > On 2019-04-22 13:34, Neil Horman wrote: > > > > > > > > > > +

[dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-04-24 Thread Ido Goshen
From: Ido Goshen 10BASE-T SFP+ copper transceivers become cheaper and popular So far those were blocked by ixgbe as “unsupported”. e.g. eth_ixgbe_dev_init(): Unsupported SFP+ Module eth_ixgbe_dev_init(): Hardware Initialization Failure: -19 EAL: Requested device :0a:00

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Burakov, Anatoly
On 23-Apr-19 3:12 PM, Ray Kinsella wrote: On 18/04/2019 11:28, Bruce Richardson wrote: On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: Hello, There was a conversation [1] in the context of RC

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-04-24 Thread Luca Boccassi
On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote: > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > > The pkg-config file generated as part of the build of DPDK should > > > allow > > > applications to be bui

Re: [dpdk-dev] [PATCH v2 0/3] improve IPsec_MB dependency checks

2019-04-24 Thread Luca Boccassi
On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > For both meson and make builds, the version checks for IPsec_MB > library > were incomplete. This fixes both and makes the checks consistent. > > Bruce Richardson (3): > crypto/aesni_gcm: add dependency version check > crypto/aesni_m

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check

2019-04-24 Thread Luca Boccassi
On Wed, 2019-04-24 at 11:38 +0100, Bruce Richardson wrote: > On Wed, Apr 24, 2019 at 10:19:20AM +0100, Luca Boccassi wrote: > > On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > > > The aesni_mb driver and the aesni_gcm driver both require the > > > same > > > version > > > of the IPSec_

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > > The pkg-config file generated as part of the build of DPDK should allow > > applications to be built with an installed DPDK. We can test this as > > part of the build by d

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

2019-04-24 Thread Iremonger, Bernard
Hi Akhil > > > > > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st > > > > > > packet > > dropped > > > > for > > > > > > inline crypto > > > > > > > > > > > > Hi Bernard, > > > > > > > > > > > > > - RTE_LOG_DP(DEBUG, IPSEC, "Create session for SA spi %u on > > > > cryptodev "

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 10:19:20AM +0100, Luca Boccassi wrote: > On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > > The aesni_mb driver and the aesni_gcm driver both require the same > > version > > of the IPSec_MB library, but only the former has a check of the > > library > > found by

Re: [dpdk-dev] [PATCH v2] lib/crypto: include dependency in asym header

2019-04-24 Thread Trahe, Fiona
> -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Tuesday, April 23, 2019 4:41 PM > To: akhil.go...@nxp.com; Kusztal, ArkadiuszX ; > Trahe, Fiona > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade...@marvell.com; > dev@dpdk.org; A

Re: [dpdk-dev] [PATCH v7 3/3] doc/rcu: add lib_rcu documentation

2019-04-24 Thread Ruifeng Wang (Arm Technology China)
Hi Honnappa, > -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Tuesday, April 23, 2019 12:32 > To: konstantin.anan...@intel.com; step...@networkplumber.org; > paul...@linux.ibm.com; marko.kovace...@intel.com; dev@dpdk.org > Cc: Honnappa Nagarahalli ; Gavin Hu (Arm

Re: [dpdk-dev] [PATCH v7 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-24 Thread Ruifeng Wang (Arm Technology China)
Hi Honnappa, > -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Tuesday, April 23, 2019 12:31 > To: konstantin.anan...@intel.com; step...@networkplumber.org; > paul...@linux.ibm.com; marko.kovace...@intel.com; dev@dpdk.org > Cc: Honnappa Nagarahalli ; Gavin Hu (Arm

Re: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memleak

2019-04-24 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/8] ipc: fix rte_mp_request_sync memlea

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-04-24 Thread Luca Boccassi
On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson wrote: > The pkg-config file generated as part of the build of DPDK should > allow > applications to be built with an installed DPDK. We can test this as > part of the build by doing an install of DPDK to a temporary > directory > within the build

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

2019-04-24 Thread Markus Theil
Hi Xiaolong, I also tested with i40e devices, with the same result. ./dpdk-testpmd -n 4 --log-level=pmd.net.af_xdp:debug --no-pci --vdev net_af_xdp0,iface=enp36s0f0 --vdev net_af_xdp1,iface=enp36s0f1 EAL: Detected 16 lcore(s) EAL: Detected 1 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check

2019-04-24 Thread Luca Boccassi
On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > The aesni_mb driver and the aesni_gcm driver both require the same > version > of the IPSec_MB library, but only the former has a check of the > library > found by meson to see if it's the correct version. Add a similar > check to > the a

Re: [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 09:54:05AM +0100, Bruce Richardson wrote: > On Tue, Apr 23, 2019 at 04:04:49PM -0700, Stephen Hemminger wrote: > > On Tue, 23 Apr 2019 23:06:40 +0100 Bruce Richardson > > wrote: > > > > > As part of the meson build, a pkg-config file for libdpdk is created, > > > which all

Re: [dpdk-dev] [DPDK] changed default-target from linux to linuxapp for back-compatibility of validate-abi.sh

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 08:18:09AM +, Peng Huang wrote: > Signed-off-by: Peng Huang > --- I think you need a fuller description of the problem here - that although "linux" is the new target name, we still need to use "linuxapp" for testing historical versions. Fixes tag also needed. /Bruce

Re: [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file

2019-04-24 Thread Bruce Richardson
On Tue, Apr 23, 2019 at 04:04:49PM -0700, Stephen Hemminger wrote: > On Tue, 23 Apr 2019 23:06:40 +0100 > Bruce Richardson wrote: > > > As part of the meson build, a pkg-config file for libdpdk is created, which > > allows apps to be compiled and linked against DPDK by taking the cflags and > > l

Re: [dpdk-dev] [PATCH v2] net/mlx5: share Memory Regions for multiport device

2019-04-24 Thread Yongseok Koh
> On Apr 24, 2019, at 1:44 AM, Viacheslav Ovsiienko > wrote: > > The multiport Infiniband device support was introduced [1]. > All active ports, belonging to the same Infiniband device use the signle > shared Infiniband context of that device and share the resources: > - QPs are created withi

Re: [dpdk-dev] ABI and inline functions

2019-04-24 Thread Bruce Richardson
On Wed, Apr 24, 2019 at 05:08:46AM +, Honnappa Nagarahalli wrote: > > > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli > > wrote: > > > > > Hello, > > > > > > > > 2. If the situation is as in #1, but the structures in question are > > > > passed to non-inline DPDK functions.

[dpdk-dev] [PATCH] net/mlx5: update memory event callback for shared context

2019-04-24 Thread Viacheslav Ovsiienko
Mellanox mlx5 PMD implements the list of devices to process the memory free event to reflect the actual memory state to Memory Regions. Because this list contains the devices and devices may share the same context the callback routine may be called multiple times with the same parameter, that is no

Re: [dpdk-dev] [PATCH v5 0/4] bidirect guest channel

2019-04-24 Thread Thomas Monjalon
24/04/2019 10:38, Hunt, David: > On 22/4/2019 9:36 PM, Thomas Monjalon wrote: > > 05/04/2019 15:24, Hajkowski: > >> From: Marcin Hajkowski > >> > >> Extend guest channel API to allow bidirectional > >> communication. Modify power manager host and guest > >> side to communicate in both directions.

[dpdk-dev] [PATCH v2] net/mlx5: share Memory Regions for multiport device

2019-04-24 Thread Viacheslav Ovsiienko
The multiport Infiniband device support was introduced [1]. All active ports, belonging to the same Infiniband device use the signle shared Infiniband context of that device and share the resources: - QPs are created within shared context - Verbs flows are also created with specifying port inde

Re: [dpdk-dev] [PATCH v5 0/4] bidirect guest channel

2019-04-24 Thread Hunt, David
On 22/4/2019 9:36 PM, Thomas Monjalon wrote: 05/04/2019 15:24, Hajkowski: From: Marcin Hajkowski Extend guest channel API to allow bidirectional communication. Modify power manager host and guest side to communicate in both directions. This patchset is deferred to 19.08 because of a lack of r

[dpdk-dev] [DPDK] devtools: change for ABI back-compatibility checking

2019-04-24 Thread Peng Huang
The new default-taget "linux" is introduced in v19.05-rc1 but not exist in before release such as v19.02 which have default-target "linuxapp", there is no compatibility report when run validate-abi.sh to check ABI compatibility between v19.05-rc1 and v19.02, changed default-target from "linux" to "

[dpdk-dev] [PATCH v3 0/2] add fifo per core for JSON interface

2019-04-24 Thread Lukasz Gosiewski
From: root Lukasz Krakowiak (2): power: add fifo per core for JSON interface doc: update according to the fifo per core impl .../sample_app_ug/vm_power_management.rst | 53 +++ examples/vm_power_manager/channel_manager.c | 85 +++-- examples/vm_power_manager/channe

[dpdk-dev] [PATCH v3 2/2] doc: update according to the fifo per core impl

2019-04-24 Thread Lukasz Gosiewski
From: Lukasz Krakowiak Updated power management docs for fifo JSON API. Removed from JSON API: * 'name' * 'resource_id' * 'core_list' Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- .../sample_app_ug/vm_power_management.rst | 53 --- 1 file changed, 11

[dpdk-dev] [PATCH v3 1/2] power: add fifo per core for JSON interface

2019-04-24 Thread Lukasz Gosiewski
From: Lukasz Krakowiak This patch implement a separate FIFO for each cpu core. For proper handling JSON interface, removed fields from cmds: core_list, resource_id, name. Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- v2: * updated handling vm_name (use proper buff size)

[dpdk-dev] [PATCH] net/fm10k: support Rx queue count API

2019-04-24 Thread Xiao Wang
Some application, e.g. the l3fwd-power sample uses rte_eth_rx_queue_count() API to get the get the number of used descriptors of a Rx queue. This patch adds fm10k implementation for this API. Signed-off-by: Xiao Wang --- drivers/net/fm10k/fm10k.h| 3 +++ drivers/net/fm10k/fm10k_ethdev.c

Re: [dpdk-dev] [PATCH v2 3/3] crypto/aesni_gcm: add check for build dependency

2019-04-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, April 23, 2019 4:44 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH v2 3/3] crypto/aesni_gcm: add check for build dependency > > The aesni_mb driver has a check in its Makefile for t

Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check

2019-04-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, April 23, 2019 4:44 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check > > The aesni_mb driver and the aesni_gcm driver both requi

Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR

2019-04-24 Thread Mattias Rönnblom
On 2019-04-23 19:17, Mattias Rönnblom wrote: On 2019-04-23 17:31, Stephen Hemminger wrote: On Mon, 22 Apr 2019 19:44:39 +0200 Mattias Rönnblom wrote: On 2019-04-22 17:52, Mattias Rönnblom wrote: On 2019-04-22 13:34, Neil Horman wrote: +uint64_t __rte_experimental +rte_rand(void) Do you rea

[dpdk-dev] [DPDK] net/ice: fix Rx statistics

2019-04-24 Thread simei
The RX stats will increase even no packets sent, this patch fix this issue by modifying ipackets and ibytes statistics based on vsi instead of port to avoid statistics error. Fixes: a37bde56314d ("net/ice: support statistics") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/ice_