[dpdk-dev] [PATCH v3 4/4] net/mlx4: remove device register remap

2019-04-04 Thread Yongseok Koh
UAR (User Access Region) register does not need to be remapped for primary process but it should be remapped only for secondary process. UAR register table is in the process private structure in rte_eth_devices[], (struct mlx4_proc_priv *)rte_eth_devices[port_id].process_private The actual

[dpdk-dev] [PATCH v3 3/4] net/mlx5: remove device register remap

2019-04-04 Thread Yongseok Koh
UAR (User Access Region) register does not need to be remapped for primary process but it should be remapped only for secondary process. UAR register table is in the process private structure in rte_eth_devices[], (struct mlx5_proc_priv *)rte_eth_devices[port_id].process_private The actual

[dpdk-dev] [PATCH v3 1/4] net/mlx5: fix recursive inclusion of header file

2019-04-04 Thread Yongseok Koh
mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively. Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h| 1 - drivers/net/mlx5/mlx5_flow.c | 5 +++-- drivers/net/mlx5/mlx5_flow_dv.c| 4 +++- drivers/net/mlx5/mlx5_flow_verbs.

[dpdk-dev] [PATCH v3 2/4] net/mlx5: remove redundant queue index

2019-04-04 Thread Yongseok Koh
Queue index is redundantly stored for both Rx and Tx structures. E.g. txq_ctrl->idx and txq->stats.idx. Both are consolidated to single storage - rxq->idx and txq->idx. Also, rxq and txq are moved to the beginning of its control structure (rxq_ctrl and txq_ctrl) for cacheline alignment. Signed-of

[dpdk-dev] [PATCH v3 0/4] net/mlx: remove device register remap

2019-04-04 Thread Yongseok Koh
This patchset lifts the requirement of reserving huge virtual address space and remapping device UAR register on to it in order to use the same address between primary and secondary process. v3: * move UAR table to per-process storage v2: * rebase on the latest branch tip * fix a bug Yongseok Ko

Re: [dpdk-dev] [PATCH v3 0/3] DMA map anonymous memory to eth devices

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 8:34 PM, Shahaf Shuler wrote: > Small series to use the APIs introduced by commit c33a675b6276 ("bus: > introduce device level DMA memory mapping") > > On v3: > * remove redundant return. > > On v2: > * enforcing parameter validity at option parse time. > * precede unmap to be bef

Re: [dpdk-dev] [PATCH v6] net/nfb: new netcope driver

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 10:05 AM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay <...> > @@ -0,0 +1,18 @@ > +; > +; Supported features of the 'nfb' network poll mode driver. > +; > +; Refer to default.ini for the full li

[dpdk-dev] [PATCH] virtio: fix buffer leak on vlan insert

2019-04-04 Thread Stephen Hemminger
The function rte_vlan_insert may allocate a new buffer for the vlan header and return a different mbuf than originally passed. In this case, the stored mbuf in txm[] array could point to wrong buffer. Fixes: dd856dfcb9e7 ("virtio: use any layout on Tx") Signed-off-by: Stephen Hemminger --- drive

Re: [dpdk-dev] [PATCH v3] app/test/hash: fix sprintf with snprintf

2019-04-04 Thread Thomas Monjalon
26/03/2019 11:27, Pallantla Poornima: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 473d1bebce ("hash: allow to store data in hash table") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima > Acked-by: Yipe

Re: [dpdk-dev] [PATCH v2] test/distributor: fix sprintf with strlcpy

2019-04-04 Thread Thomas Monjalon
25/03/2019 16:11, Hunt, David: > On 14/2/2019 9:45 AM, Pallantla Poornima wrote: > > sprintf function is not secure as it doesn't check the length of string. > > replaced sprintf with strlcpy. > > > > Fixes: f74df2c57e ("test/distributor: test single and burst API") > > Cc: sta...@dpdk.org > > > >

Re: [dpdk-dev] [RFC v2] net: fix rte_vlan_insert with shared mbuf

2019-04-04 Thread Stephen Hemminger
On Sat, 30 Mar 2019 08:41:33 -0400 Chas Williams <3ch...@gmail.com> wrote: > Unfortunately, I think the complete fix is more complicated than this. > Drivers that use rte_vlan_insert don't anticipate that the mbuf might > change and that (hardware) transmit can fail. > > They make a copy of the m

Re: [dpdk-dev] [PATCH v11 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 9:51 AM, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the umem. > > [1] htt

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] power: fix to remove unused variable

2019-04-04 Thread Thomas Monjalon
15/02/2019 12:41, Hunt, David: > > On 15/2/2019 10:28 AM, Pallantla Poornima wrote: > > Variable pfi_str is removed since it is unused. > > > > Fixes: 450f0791312c ("power: add traffic pattern aware power control") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Pallantla Poornima > > Reviewed-by:

Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address

2019-04-04 Thread Thomas Monjalon
24/01/2019 04:53, Jie Pan: > The type for mac address in struct rte_kni_conf should be unsigned. > > Signed-off-by: Jie Pan > --- > lib/librte_kni/rte_kni.h | 2 +- > - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ > + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address as

Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread

2019-04-04 Thread Thomas Monjalon
Hi, 03/04/2019 08:59, Phil Yang: > The current implementation using the '__sync' built-ins to synchronize > statistics within worker threads. The '__sync' built-ins functions are > full barriers which will affect the performance, so add a per worker > packets statistics to remove the synchronisati

Re: [dpdk-dev] [PATCH v3 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Thomas Monjalon
04/04/2019 15:04, Bruce Richardson: > On Thu, Apr 04, 2019 at 11:50:18AM +, Hemant Agrawal wrote: > > The current value is 10, which is not sufficient for many use-cases. > > e.g. NXP LX2 with raw qdma devices can use 32-48 raw devices in some > > use-cases. So, making it to 64 to cover various

Re: [dpdk-dev] [PATCH v7 0/6] Add lock-free ring and mempool handler

2019-04-04 Thread Eads, Gage
> On Mon, 2019-04-01 at 19:23 +, Eads, Gage wrote: > > > > > > > > > On Mon, 18 Mar 2019 21:49:44 + > > > "Eads, Gage" wrote: > > > > > > > > > > > Hi all, > > > > > > > > Friendly reminder that in order to get this feature into 19.08 > > > > (assuming > > > folks also want that :)), the A

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: fix DMA zone reserve not honoring size

2019-04-04 Thread Thomas Monjalon
Hi, 02/04/2019 10:44, Andrew Rybchenko: > On 4/2/19 11:25 AM, Jerin Jacob Kollanukkaran wrote: > > On Tue, 2019-04-02 at 10:36 +0300, Andrew Rybchenko wrote: > >> On 4/2/19 3:47 AM, Jerin Jacob Kollanukkaran wrote: > >>> On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybchenko wrote: > On 3/31/19

Re: [dpdk-dev] [PATCH] ethdev: claim device reset as async

2019-04-04 Thread Thomas Monjalon
Hi, You forgot to Cc Andrew, co-maintainer of ethdev. 20/03/2019 05:54, Qi Zhang: > Device reset should be implemented in an async way since it is > possible to be invoked in interrupt thread and sometimes to reset a > device need to wait for some dependency, for example, a VF expects for > PF re

Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-04 Thread Thomas Monjalon
04/04/2019 23:29, Ferruh Yigit: > On 4/4/2019 8:23 AM, Shreyansh Jain wrote: > > Removes some unused firmware code which was added in last bump > > of the firmware version. No current features uses these APIs. > > > > Signed-off-by: Shreyansh Jain > > <...> > > > diff --git a/drivers/bus/fslmc/

Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 8:23 AM, Shreyansh Jain wrote: > Removes some unused firmware code which was added in last bump > of the firmware version. No current features uses these APIs. > > Signed-off-by: Shreyansh Jain <...> > diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h >

Re: [dpdk-dev] [PATCH] net/vmxnet3: synchronize vmxnet definitions with 6.7 public

2019-04-04 Thread Thomas Monjalon
Hi, > From: Eduard Serra > > Synchronize new definitions made public defs on ESX 6.7, which > include support for variety of new features and fixes on vmxnet3 > driver. Please, would it be possible to split this patch, and add explanations in each patch for each feature or cleanup? Thank you

Re: [dpdk-dev] [PATCH v2 0/3] Update FSLMC bus firmware

2019-04-04 Thread Thomas Monjalon
04/04/2019 09:23, Shreyansh Jain: > Based on net-next: 69f805ac18abe > > All the patches are strictly within DPAA2/FSLMC driver area. > > MC firmware is the core component of FSLMC bus which enables > all the dpaa2 devices (eth, crypto etc). > With recent release of NXP's layerscape SDK, the MC f

[dpdk-dev] [PATCH] net/vmxnet3: synchronize vmxnet definitions with 6.7 public

2019-04-04 Thread eduser25
From: Eduard Serra Synchronize new definitions made public defs on ESX 6.7, which include support for variety of new features and fixes on vmxnet3 driver. Signed-off-by: Eduard Serra --- drivers/net/vmxnet3/base/vmxnet3_defs.h | 296 ++-- 1 file changed, 245 inserti

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Kevin Traynor
On 04/04/2019 20:08, Wiles, Keith wrote: > > >> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote: >> >> On 04/04/2019 11:54, Bruce Richardson wrote: >> >> >>> >>> My thoughts on the matter are: >>> 1. I think we really need to do work to start hiding more of our data >>> structures - like what

Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying

2019-04-04 Thread Thomas Monjalon
03/04/2019 16:45, Bruce Richardson: > There are quite a few instances remaining in DPDK where snprintf is being > used for string copying. These were not being picked up by our existing > coccinelle script, but that can be fixed by editing the script and running > it against our code. In the proces

Re: [dpdk-dev] [PATCH v5 03/14] drivers/net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-04 Thread Ferruh Yigit
On 4/3/2019 12:47 PM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE ethdev PMD driver. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > Signed-off-by: Dan Wei <...> > +Config File Options > +~~~ > + > +The following options can be modified in the ``config`` fi

[dpdk-dev] [PATCH v3 0/3] DMA map anonymous memory to eth devices

2019-04-04 Thread Shahaf Shuler
Small series to use the APIs introduced by commit c33a675b6276 ("bus: introduce device level DMA memory mapping") On v3: * remove redundant return. On v2: * enforcing parameter validity at option parse time. * precede unmap to be before unregister. * extended debug log verbosity to include e

[dpdk-dev] [PATCH v3 3/3] app/testpmd: map anonymous memory for eth devices

2019-04-04 Thread Shahaf Shuler
Mempools can be populated with anonymous memory when using command line parameter --mp-alloc=anon. Considering the mempools are going to be used by the net devices, it is better to DMA map this memory. This patch add such mapping now that we have the APIs in place[1]. [1] commit c33a675b6276 ("b

[dpdk-dev] [PATCH v3 1/3] app/testpmd: fix mempool free on exit

2019-04-04 Thread Shahaf Shuler
Allocated mempools were never free. it is bad practice. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- app/test-pmd/testpmd.c | 25 +++-- app/test-pmd/testpmd.h | 2 ++ 2 files changed, 21 insertions(+), 6 deletions(-) dif

[dpdk-dev] [PATCH v3 2/3] app/testpmd: support creation of no IOVA contig mempools

2019-04-04 Thread Shahaf Shuler
providing a command line parameter to set the mempool flags accordingly. This mode is relevant only when creating an empty mempool and then populating with memory. Signed-off-by: Shahaf Shuler Acked-by: Anatoly Burakov --- app/test-pmd/parameters.c | 13 + app/test-pmd/t

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-04 Thread Mattias Rönnblom
On 2019-04-04 20:13, Venky Venkatesh wrote: On a side note on the design, suppose you have 1 massive flow in terms of work per packet and is "long" lived. Then 1 core would be super busy while others would be idle. Then would it constantly consider migrating that flow since the busy-ness of the

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Wiles, Keith
> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote: > > On 04/04/2019 11:54, Bruce Richardson wrote: > > >> >> My thoughts on the matter are: >> 1. I think we really need to do work to start hiding more of our data >> structures - like what Stephen's latest RFC does. This hiding should redu

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: fix device probing for old kernel drivers

2019-04-04 Thread David Christensen
Retrieving network interface index via Netlink fails in case of old mlx5 kernel drivers installedCan you put a boundary on this statement with a kernel driver version? Dave

Re: [dpdk-dev] [PATCH v5 04/14] drivers/net/ipn3ke: add IPN3KE representor of PMD driver

2019-04-04 Thread Ferruh Yigit
On 4/3/2019 12:47 PM, Rosen Xu wrote: > Add Intel FPGA Acceleration NIC IPN3KE representor of PMD driver. > > Signed-off-by: Rosen Xu > Signed-off-by: Andy Pei > Signed-off-by: Dan Wei <...> > +static void > +ipn3ke_rpst_dev_stop(__rte_unused struct rte_eth_dev *dev) > +{ 'dev' is used in th

Re: [dpdk-dev] [PATCH v2 0/2] support Direct Rules flows over shared IB context

2019-04-04 Thread Shahaf Shuler
Thursday, April 4, 2019 4:04 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 0/2] support Direct Rules flows over shared IB > context > > The Direct Rules/Direct Verbs flows support is going to be added [1]. The > master/representor over multiport IB device is added [2]. This patchset ad

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix SPD no-match is misinterpreted

2019-04-04 Thread Zhang, Roy Fan
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Thursday, April 4, 2019 1:13 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix SPD no

Re: [dpdk-dev] [PATCH v5 00/14] Add patch set for IPN3KE

2019-04-04 Thread Ferruh Yigit
On 4/3/2019 12:47 PM, Rosen Xu wrote: > v5 updates: > == > - Fix EXPERIMENTAL symbol definition issue > > v4 updates: > == > - Fix coding style issues > > v3 updates: > == > - Fix v2 comments > - Update MAC BAR of AFU index get ops > - Remove OPAE share code dependenc

Re: [dpdk-dev] DSW eventdev is getting "stuck"?

2019-04-04 Thread Venky Venkatesh
On 4/4/19, 12:40 AM, "Mattias Rönnblom" wrote: On 2019-04-04 07:39, Venky Venkatesh wrote: > > > On 4/3/19, 12:02 PM, "Mattias Rönnblom" wrote: > > On 2019-04-03 20:36, Venky Venkatesh wrote: > > > > > > On 4/3/19, 11:34 AM, "Mattias

Re: [dpdk-dev] [PATCH 4/5] replace snprintf with strlcpy without adding extra include

2019-04-04 Thread Thomas Monjalon
03/04/2019 17:56, Bruce Richardson: > On Wed, Apr 03, 2019 at 08:51:32AM -0700, Stephen Hemminger wrote: > > On Wed, 3 Apr 2019 15:45:04 +0100 > > Bruce Richardson wrote: > > > > > diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c > > > index d215acecc..a542f6f5d 100644 > > >

Re: [dpdk-dev] [PATCH] eal: tighten permissions on shared memory files

2019-04-04 Thread Thomas Monjalon
03/04/2019 18:02, Bruce Richardson: > Adding sta...@dpdk.org since this is suitable for backporting > > On Wed, Apr 03, 2019 at 05:00:34PM +0100, Bruce Richardson wrote: > > When creating files on disk, e.g. for EAL configuration or shared memory > > locks, etc., there is no need to grant any perm

Re: [dpdk-dev] [PATCH] drivers: remove Linux EAL from headers include path

2019-04-04 Thread Thomas Monjalon
03/04/2019 10:52, David Marchand: > None of those drivers require EAL linux specific headers. > > Signed-off-by: David Marchand > --- > drivers/bus/dpaa/Makefile | 1 - > drivers/bus/pci/Makefile | 1 - > drivers/bus/vmbus/Makefile| 1 - > drivers/crypto/caam_jr/Makefile

Re: [dpdk-dev] [PATCH] net/softnic: fix unchecked return value

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 4:45 PM, Jasvinder Singh wrote: > Fix unchecked return value issue reported by Coverity. > > Coverity ID 336852 > Fixes: a958a5c07f4b ("net/softnic: support service cores") > > Signed-off-by: Jasvinder Singh Acked-by: Rami Rosen Applied to dpdk-next-net/master, thanks.

[dpdk-dev] DPDK Release Status Meeting 4/4/2019

2019-04-04 Thread Ferruh Yigit
Minutes 4 April 2019 Agenda: * Release Dates * Subtrees * OvS * Opens Participants: * Debian * Intel * Mellanox * NXP * RedHat Release Dates - * v19.05 dates, rc1 date pushed to Friday: * RC1: *Friday, 5 April* * RC2: Wednesday, 17 April * Release: Frida

Re: [dpdk-dev] [PATCH] net/softnic: fix unchecked return value

2019-04-04 Thread Rami Rosen
Acked-by: Rami Rosen

Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs

2019-04-04 Thread Stephen Hemminger
On Thu, 4 Apr 2019 11:45:45 + Hemant Agrawal wrote: > These APIs are available in DPDK for last 4 releases > and used by multiple drivers. > > Cc: gaetan.ri...@6wind.com > > Signed-off-by: Hemant Agrawal Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH] net: fix Tx VLAN flag for offload emulation

2019-04-04 Thread Ferruh Yigit
On 3/25/2019 3:05 PM, Chas Williams wrote: > From: Bill Hong > > A PMD might use rte_vlan_insert to implement Tx VLAN offload. Typically > the PMD will insert the VLAN header in the transmit path and then attempt > to send the packets. If this fails, the packets are returned to > the application

Re: [dpdk-dev] [PATCH v11 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 5:41 PM, Stephen Hemminger wrote: > On Thu, 04 Apr 2019 17:20:43 +0100 > Luca Boccassi wrote: > >> On Thu, 2019-04-04 at 16:51 +0800, Xiaolong Ye wrote: >>> Add a new PMD driver for AF_XDP which is a proposed faster version of >>> AF_PACKET interface in Linux. More info about AF_XDP,

Re: [dpdk-dev] [PATCH] reta_query: Doc requirements on reta_conf

2019-04-04 Thread Ferruh Yigit
On 4/3/2019 9:48 AM, Tom Barbette wrote: > As the librte function checks that bits of up to reta_size in reta_conf > are set, the arg passed must have the mask set to 1. I spent quite some > time before finding the issue here, so I thought updating the doc may > help other people. In 'reta_conf' t

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Kevin Traynor
On 04/04/2019 11:54, Bruce Richardson wrote: > > My thoughts on the matter are: > 1. I think we really need to do work to start hiding more of our data > structures - like what Stephen's latest RFC does. This hiding should reduce > the scope for ABI breaks. > 2. Once done, I think we should commi

Re: [dpdk-dev] [PATCH v11 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Stephen Hemminger
On Thu, 04 Apr 2019 17:20:43 +0100 Luca Boccassi wrote: > On Thu, 2019-04-04 at 16:51 +0800, Xiaolong Ye wrote: > > Add a new PMD driver for AF_XDP which is a proposed faster version of > > AF_PACKET interface in Linux. More info about AF_XDP, please refer to > > [1] > > [2]. > > > > This is the

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 4:51 PM, Stephen Hemminger wrote: On Thu, 4 Apr 2019 11:54:47 +0100 Bruce Richardson wrote: My thoughts on the matter are: 1. I think we really need to do work to start hiding more of our data structures - like what Stephen's latest RFC does. This hiding should reduce the scope fo

Re: [dpdk-dev] [PATCH v6 1/4] app/testpmd: move eth header generation outside the loop

2019-04-04 Thread Ferruh Yigit
On 4/2/2019 10:53 AM, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Testpmd txonly copies the src/dst mac address of the port being > processed to ethernet header structure on the stack for every packet. > Move it outside the loop and reuse it. > > Signed-off-by: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH v11 1/1] net/af_xdp: introduce AF XDP PMD driver

2019-04-04 Thread Luca Boccassi
On Thu, 2019-04-04 at 16:51 +0800, Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to > [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer > registered as > the

Re: [dpdk-dev] [PATCH v11 0/1] Introduce AF_XDP PMD

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 9:51 AM, Xiaolong Ye wrote: > Overview > > > This patchset adds a new PMD driver for AF_XDP which is a proposed > faster version of AF_PACKET interface in Linux, see below links [1] [2] for > details of AF_XDP introduction: > > AF_XDP roadmap > == > - AF_XDP is in

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Stephen Hemminger
On Thu, 4 Apr 2019 11:54:47 +0100 Bruce Richardson wrote: > My thoughts on the matter are: > 1. I think we really need to do work to start hiding more of our data > structures - like what Stephen's latest RFC does. This hiding should reduce > the scope for ABI breaks. > 2. Once done, I think we s

[dpdk-dev] [PATCH] net/softnic: fix unchecked return value

2019-04-04 Thread Jasvinder Singh
Fix unchecked return value issue reported by Coverity. Coverity ID 336852 Fixes: a958a5c07f4b ("net/softnic: support service cores") Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_thread.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH] ring: fix namesize macro documentation block

2019-04-04 Thread Thomas Monjalon
04/04/2019 14:34, Gage Eads: > '/**<' style comments apply to the previous member, which caused doxygen to > emit the RTE_RING_NAMESIZE documentation for RTE_RING_MZ_PREFIX. > > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") > Cc: sta...@dpdk.org > > Signed-off-by: Gage E

Re: [dpdk-dev] [PATCH v10 0/8] Add stack library and new mempool handler

2019-04-04 Thread Thomas Monjalon
04/04/2019 12:01, Gage Eads: > This patchset introduces a stack library, supporting both lock-based and > lock-free stacks, and a lock-free stack mempool handler. > > The lock-based stack code is derived from the existing stack mempool handler, > and that handler is refactored to use the stack lib

Re: [dpdk-dev] [PATCH v3 2/3] test/distributor: replace sync builtins with atomic builtins

2019-04-04 Thread Honnappa Nagarahalli
> > '__sync' built-in functions are deprecated, should use the '__atomic' > built-in instead. the sync built-in functions are full barriers, while atomic > built-in functions offer less restrictive one-way barriers, which help > performance. > > Here is the example test result on TX2: > sudo ./ar

Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Thomas Monjalon
04/04/2019 17:13, Ferruh Yigit: > On 4/4/2019 3:14 PM, Eads, Gage wrote: > >> 04/04/2019 15:00, Thomas Monjalon: > >>> When enabling pedantic compilation with > >> CONFIG_RTE_LIBRTE_MLX5_DEBUG, > >>> the compiler complains about non standard 128-bit integer type: > >>> > >>> include/rte_atomic_64.h

Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 3:14 PM, Eads, Gage wrote: > >> 04/04/2019 15:00, Thomas Monjalon: >>> When enabling pedantic compilation with >> CONFIG_RTE_LIBRTE_MLX5_DEBUG, >>> the compiler complains about non standard 128-bit integer type: >>> >>> include/rte_atomic_64.h:223:3: error: >>> ISO C does not support ‘

[dpdk-dev] [PATCH v3] app/test/ipsec: fix test initialisation

2019-04-04 Thread Bernard Iremonger
Fix xform initialisation. Fix testsuite_setup. Remove unused variables. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Signed-off-by: Bernard Iremonger --- Changes in v3: drop changes to logic around rte_cryptodev_dequeue_bu

Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Eads, Gage
> 04/04/2019 15:00, Thomas Monjalon: > > When enabling pedantic compilation with > CONFIG_RTE_LIBRTE_MLX5_DEBUG, > > the compiler complains about non standard 128-bit integer type: > > > > include/rte_atomic_64.h:223:3: error: > > ISO C does not support ‘__int128’ types [-Werror=pedantic] > > > >

Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 4, 2019 8:30 AM > To: Eads, Gage > Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ; gavin...@arm.com; > honnappa.nagaraha..

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 1:52 PM, Ray Kinsella wrote: On 04/04/2019 11:54, Bruce Richardson wrote: On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: On 03-Apr-19 4:42 PM, Ray Kinsella wrote: Hi folks, [SNIP] Hi Ray, My somewhat rambly 2 cents :) While i think some solution has to b

Re: [dpdk-dev] [PATCH v2] test/ipsec: fix test initialisation

2019-04-04 Thread Iremonger, Bernard
Hi Akhil, > On 3/22/2019 7:17 PM, Bernard Iremonger wrote: > > Fix xform initialisation. > > Fix testsuite_setup. > > Loop on rte_cryptodev_dequeue_burst() calls. > > Remove unused variables. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Fixes: 59d7353b0df0 ("test/ip

Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library

2019-04-04 Thread Thomas Monjalon
04/04/2019 01:20, Gage Eads: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -87,6 +87,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY) += > -lrte_security > _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV)+= -lrte_compressdev > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += -lrte_eventdev > _LDLI

Re: [dpdk-dev] [EXT] Re: [PATCH v2] kni: add IOVA va support for kni

2019-04-04 Thread Burakov, Anatoly
On 04-Apr-19 12:20 PM, Ferruh Yigit wrote: On 4/4/2019 6:03 AM, Kiran Kumar Kokkilagadda wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, April 3, 2019 9:59 PM To: Kiran Kumar Kokkilagadda Cc: dev@dpdk.org; Jerin Jacob Subject: [EXT] Re: [dpdk-dev] [PATCH v2] kni: add

[dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw/test: fix inline test scripts

2019-04-04 Thread Bernard Iremonger
Remove workaround in tun_aesgcm_defs.sh and trs_aesgcm_defs.sh to get around the bug where the first inbound packet is dropped for inline crypto. Fixes: 929784452094 ("examples/ipsec-secgw: add scripts for functional test") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- examples/ipsec

[dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

2019-04-04 Thread Bernard Iremonger
Inline crypto installs a flow rule in the NIC. This flow rule must be installed before the first inbound packet is received. The create_session() function installs the flow rule. Refactor ipsec-secgw.c, sa.c, ipsec.h and ipsec.c to create sessions at startup to fix the issue of the first packet b

[dpdk-dev] [PATCH v3 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-04-04 Thread Bernard Iremonger
This patchset fixes the issue of the first inbound packet being dropped for inline crypto. Changes in v3: -- The previous refactoring of the create_session() function has been dropped. The create_session() function is now called from sa_init() at startup. The following functions hav

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields

2019-04-04 Thread Adrien Mazarguil
Hi Ori, (trimming message down a bit) On Thu, Apr 04, 2019 at 09:01:52AM +, Ori Kam wrote: > Hi Adrien, > > PSB > > > From: Adrien Mazarguil > > On Wed, Apr 03, 2019 at 10:49:09AM +, Dekel Peled wrote: > > > Thanks, PSB. > > > > From: Adrien Mazarguil > > > > I still don't agree w

Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Thomas Monjalon
04/04/2019 15:00, Thomas Monjalon: > When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG, > the compiler complains about non standard 128-bit integer type: > > include/rte_atomic_64.h:223:3: error: > ISO C does not support ‘__int128’ types [-Werror=pedantic] > > It must be marked

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Luca Boccassi
On Thu, 2019-04-04 at 14:05 +0100, Ray Kinsella wrote: > > > Question for Kevin, Luca and others who look at distro-packaging: > > > is > > > it the > > > case that each distro will only ship one version of DPDK, or is > > > it > > > possible > > > that if we have ABI breaks, a distro will provide

Re: [dpdk-dev] DPDK ABI/API Stability

2019-04-04 Thread Ray Kinsella
On 04/04/2019 10:47, Kevin Traynor wrote: > On 03/04/2019 16:42, Ray Kinsella wrote: >> Hi folks, >> [SNIP] >> >> The DPDK ABI churn has the following affects for users:- >> >> 1. The churn obliges users of DPDK to commit to a constant >> re-integration and re-validation effort for new versions

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Bruce Richardson
On Thu, Apr 04, 2019 at 02:05:27PM +0100, Ray Kinsella wrote: > > > On 04/04/2019 13:02, Luca Boccassi wrote: > > On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: > >> On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > >>> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: > [SN

[dpdk-dev] [PATCH v2 2/2] net/mlx5: share Direct Rules/Verbs flow related structures

2019-04-04 Thread Viacheslav Ovsiienko
Direct Rules/Verbs related structures are moved to the shared context: - rx/tx namespaces, shared by master and representors - rx/tx flow tables - matchers - encap/decap action resources - flow tags (MARK actions) - modify action resources - jump tables Signed-off-by: Viacheslav Ovsi

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add Direct Rules flow data alloc/free routines

2019-04-04 Thread Viacheslav Ovsiienko
We are going to share the Direct Rules and Direct Verbs flow device data structures between master and representors in the E-Switch configurations over multiport IB device. The code of initializing and destroying these data is moved to dedicated routines, this is just a preparation step for actual

[dpdk-dev] [PATCH v2 0/2] support Direct Rules flows over shared IB context

2019-04-04 Thread Viacheslav Ovsiienko
The Direct Rules/Direct Verbs flows support is going to be added [1]. The master/representor over multiport IB device is added [2]. This patchset adds support for DR/DV flows with shared IB context over multiport IB device. The DV/DR flows applied to the master/representors on the same IB device s

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Ray Kinsella
On 04/04/2019 13:02, Luca Boccassi wrote: > On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: >> On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: >>> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: [SNIP] >>> >> >> Actually, I think we *do* need to constrain the pace of devel

Re: [dpdk-dev] [PATCH v3 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Bruce Richardson
On Thu, Apr 04, 2019 at 11:50:18AM +, Hemant Agrawal wrote: > The current value is 10, which is not sufficient for many use-cases. > e.g. NXP LX2 with raw qdma devices can use 32-48 raw devices in some > use-cases. So, making it to 64 to cover various cases. > > Signed-off-by: Hemant Agrawal

[dpdk-dev] [PATCH] eal/x86: fix pedantic build

2019-04-04 Thread Thomas Monjalon
When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG, the compiler complains about non standard 128-bit integer type: include/rte_atomic_64.h:223:3: error: ISO C does not support ‘__int128’ types [-Werror=pedantic] It must be marked as an extension of the standard C language to be

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Ray Kinsella
On 04/04/2019 11:54, Bruce Richardson wrote: > On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: >> On 03-Apr-19 4:42 PM, Ray Kinsella wrote: >>> Hi folks, >>> [SNIP] >> >> Hi Ray, >> >> My somewhat rambly 2 cents :) >> >> While i think some solution has to be found for the situa

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Ferruh Yigit
On 4/4/2019 1:18 PM, Thomas Monjalon wrote: > 04/04/2019 14:14, Eads, Gage: >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >>> 04/04/2019 14:08, Thomas Monjalon: 04/04/2019 13:47, Ferruh Yigit: > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: > error: ISO C d

[dpdk-dev] [PATCH] ring: fix namesize macro documentation block

2019-04-04 Thread Gage Eads
'/**<' style comments apply to the previous member, which caused doxygen to emit the RTE_RING_NAMESIZE documentation for RTE_RING_MZ_PREFIX. Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") Cc: sta...@dpdk.org Signed-off-by: Gage Eads --- lib/librte_ring/rte_ring.h | 2 +-

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Eads, Gage > Sent: Thursday, April 4, 2019 7:23 AM > To: 'Thomas Monjalon' ; Yigit, Ferruh > > Cc: Shahaf Shuler ; Matan Azrad > ; Yongseok Koh ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > ;

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 4, 2019 7:18 AM > To: Eads, Gage ; Yigit, Ferruh > > Cc: Shahaf Shuler ; Matan Azrad > ; Yongseok Koh ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ;

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Thomas Monjalon
04/04/2019 14:14, Eads, Gage: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 04/04/2019 14:08, Thomas Monjalon: > > > 04/04/2019 13:47, Ferruh Yigit: > > > > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: > > > > error: ISO C does not support ‘__int128’ types [-Werror=

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix SPD no-match is misinterpreted

2019-04-04 Thread Ananyev, Konstantin
Hi Akhil, > > > > acl_classify() returns zero value when no matching rule was found. > > > > Currently ipsec-secgw treats it as a valid SPI value, though it has > > > > to discard such packets. > > > > Error could be easily observed by sending outbound unmatched packets, > > > > user will see som

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Eads, Gage
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, April 4, 2019 7:13 AM > To: Yigit, Ferruh ; Eads, Gage > > Cc: Shahaf Shuler ; Matan Azrad > ; Yongseok Koh ; > dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix SPD no-match is misinterpreted

2019-04-04 Thread Konstantin Ananyev
acl_classify() returns zero value when no matching rule was found. Currently ipsec-secgw treats it as a valid SPI value, though it has to discard such packets. Error could be easily observed by sending outbound unmatched packets, user will see something like that in the log: IPSEC: No cryptodev: co

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Thomas Monjalon
04/04/2019 14:08, Thomas Monjalon: > 04/04/2019 13:47, Ferruh Yigit: > > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: error: > > ISO C > > does not support ‘__int128’ types [-Werror=pedantic] > > We can try this kind of workaround (disable pedantic locally): > https://github

Re: [dpdk-dev] mlx5 FDIR rule comparison issue

2019-04-04 Thread benli ye
Thanks Dekel for your information. I will have a try. Bests, Daniel > On Apr 4, 2019, at 7:18 PM, Dekel Peled wrote: > > Hi Daniel, > > The flow_director API will be deprecated in the near future. > It was replaced by rte_flow API, which contains much more features, and is > fully supported b

Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange

2019-04-04 Thread Thomas Monjalon
04/04/2019 13:47, Ferruh Yigit: > .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:223:3: error: ISO > C > does not support ‘__int128’ types [-Werror=pedantic] We can try this kind of workaround (disable pedantic locally): https://github.com/HowardHinnant/date/pull/38/commits/177032852

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Luca Boccassi
On Thu, 2019-04-04 at 11:54 +0100, Bruce Richardson wrote: > On Thu, Apr 04, 2019 at 10:29:19AM +0100, Burakov, Anatoly wrote: > > On 03-Apr-19 4:42 PM, Ray Kinsella wrote: > > > Hi folks, > > > > > > Recently I started a discussion with the DPDK Technical Board on > > > DPDK > > > ABI/API stabili

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-04 Thread Hemant Agrawal
ping On 03-Jan-19 5:00 PM, Shreyansh Jain wrote: > Traditionally, only a single buffer pool per port > (or, per-port-per-socket) is created in l3fwd application. > > If separate pools are created per-port, it might lead to gain in > performance as packet alloc/dealloc requests would be isolated >

Re: [dpdk-dev] [PATCH v2 1/7] config: increase the num of rawdev to be 64

2019-04-04 Thread Hemant Agrawal
On 04-Apr-19 4:37 PM, Richardson, Bruce wrote: > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal >> Sent: Thursday, April 4, 2019 12:04 PM >> To: dev@dpdk.org >> Cc: tho...@monjalon.net; Shreyansh Jain >> Subject: [dpdk-dev] [PATCH v2 1/7] conf

[dpdk-dev] [PATCH v3 7/7] raw/dpaa2_qdma: add support for non prefetch mode

2019-04-04 Thread Hemant Agrawal
This patch add support for non prefetch mode in Rx functions. Signed-off-by: Hemant Agrawal --- drivers/raw/dpaa2_qdma/Makefile | 1 + drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 215 +++- drivers/raw/dpaa2_qdma/meson.build | 2 +- 3 files changed, 212 insertions(+), 6

[dpdk-dev] [PATCH v3 6/7] raw/dpaa2x: remove rte logs from data path

2019-04-04 Thread Hemant Agrawal
From: Nipun Gupta The runtime traces shall not be present in datapath Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 4 drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 8 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 2 +- 3 files changed, 1 insertion(

  1   2   >