[dpdk-dev] help

2019-03-13 Thread Yubin
- 本邮件及其附件含有新华三集团的保密信息,仅限于发送给上面地址中列出 的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、 或散发)本邮件中的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本 邮件! This e-mail and its attachments contain conf

Re: [dpdk-dev] [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-13 Thread Liron Himi
-Original Message- From: Ferruh Yigit Sent: Wednesday, March 13, 2019 18:58 To: Liron Himi Cc: dev@dpdk.org; Alan Winkowski Subject: Re: [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool On 3/10/2019 2:27 PM, Liron Himi wrote: > Adding Alan. > > -Original Message-

Re: [dpdk-dev] [PATCH v3 3/3] doc: add notes about eventdev producer consumer dependency

2019-03-13 Thread Gujjar, Abhinandan S
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, March 13, 2019 2:11 AM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > ; Rao, Nikhil ; Carrillo, > Erik G ; Gujjar, Abhinandan S > ; Mcnamara, John > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > Subje

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Hyong Youb Kim
On Wed, Mar 13, 2019 at 10:29:53PM +0100, Thomas Monjalon wrote: > 13/03/2019 22:11, John Daley (johndale): > > From: Thomas Monjalon > > > 13/03/2019 19:32, Ferruh Yigit: > > > > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > > > > The driver currently has a devarg to set the rewrite mode during

Re: [dpdk-dev] [EXT] [PATCH v8 3/3] spinlock: reimplement with atomic one-way barrier builtins

2019-03-13 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, March 14, 2019 8:31 AM > To: jer...@marvell.com; Gavin Hu (Arm Technology China) > ; dev@dpdk.org > Cc: i.maxim...@samsung.com; chao...@linux.vnet.ibm.com; nd > ; nipun.gu...@nxp.com; tho...@monjalon.net; > hemant.agra..

Re: [dpdk-dev] [PATCH] ethdev: check for invalid device name

2019-03-13 Thread Zhang, Qi Z
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, March 14, 2019 1:33 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: check for invalid device name > > On Wed, 13 Mar 2019 12:52:50 + > "Zhang, Qi Z

Re: [dpdk-dev] [EXT] [PATCH v8 3/3] spinlock: reimplement with atomic one-way barrier builtins

2019-03-13 Thread Honnappa Nagarahalli
> > --- > > --- > > The __sync builtin based implementation generates full memory barriers > > ('dmb ish') on Arm platforms. Using C11 atomic builtins to generate > > one way barriers. > > > > > > lib/librte_eal/common/include/generic

Re: [dpdk-dev] [PATCH v2 6/6] doc: add documention for windows

2019-03-13 Thread Anand Rawat
On 3/11/2019 5:45 AM, Jerin Jacob Kollanukkaran wrote: On Tue, 2019-03-05 at 20:16 -0800, Anand Rawat wrote: Added documentation to build helloworld example on windows using meson and clang. Updated the maintainers list to include windows maintainers. Signed-off-by: Anand Rawat Signed-off-by:

Re: [dpdk-dev] [PATCH v3 3/3] doc: add notes about eventdev producer consumer dependency

2019-03-13 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Tuesday, March 12, 2019 3:41 PM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > ; Rao, Nikhil ; Carrillo, > Erik G ; Gujjar, Abhinandan S > ; Mcnamara, John > > Cc: dev@dpdk.org; Pav

[dpdk-dev] [PATCH v2] net/octeontx: fix vdev name

2019-03-13 Thread Stephen Hemminger
The octeontx driver is creating vdev with name "OCTEONTX_PMD" which is an artifact from how RTE_PMD_REGISTER_VDEV arguments work. Change to use the same convention as all the other network drivers ie "net_octeontx"). Signed-off-by: Stephen Hemminger Reviewed-by: Ramil Rosen --- v2 - fix typo i

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Thomas Monjalon
13/03/2019 22:11, John Daley (johndale): > From: Thomas Monjalon > > 13/03/2019 19:32, Ferruh Yigit: > > > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > > > The driver currently has a devarg to set the rewrite mode during > > > > init. Some apps want to programatically set it after running > > >

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread John Daley (johndale)
Due to time zone differences, I'll answer for Hyong (below). -john > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 13, 2019 1:36 PM > To: Ferruh Yigit ; Hyong Youb Kim (hyonkim) > > Cc: Andrew Rybchenko ; Qi Zhang > ; dev@dpdk.org; John Daley (johndale) > ; Shahaf S

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Thomas Monjalon
13/03/2019 19:32, Ferruh Yigit: > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > > The driver currently has a devarg to set the rewrite mode during > > init. Some apps want to programatically set it after running > > rte_eal_init() and finding that ports are VIC. Add a private function > > to support

Re: [dpdk-dev] [PATCH] net/octeontx: fix vdev name

2019-03-13 Thread Rami Rosen
> The octeontx driver is creating vdev with name "OCTEONTX_PMD" > which is an artifact from how RTE_PMD_REGISTER_VDEV arguments > work. > > Change to use the same convention as all the other network > driverse ("net_octeontx"). > > Signed-off-by: Stephen Hemminger > --- > 1. Actuaully in the pa

Re: [dpdk-dev] [PATCH v2 0/3] adding rsa priv key feature flag

2019-03-13 Thread Kusztal, ArkadiuszX
V2 will be needed as test directory apparently changed its location. Iam acking anyway. > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Wednesday, February 27, 2019 2:34 PM > To: akhil.go...@nxp.com > Cc: Kusztal, ArkadiuszX ; Trahe, Fiona > ; Shally Verma ; Su

Re: [dpdk-dev] [PATCH v2 0/3] adding rsa priv key feature flag

2019-03-13 Thread Kusztal, ArkadiuszX
Hi Ayuj, Sorry for delayed answer. For me it is perfectly fine, I will ack it. Thanks, Arek From: Ayuj Verma [mailto:ayve...@marvell.com] Sent: Wednesday, March 13, 2019 8:30 AM To: akhil.go...@nxp.com Cc: Kusztal, ArkadiuszX ; Trahe, Fiona ; Shally Verma ; Sunila Sahu ; Kanaka Durga Kotamart

Re: [dpdk-dev] [PATCH v5] drivers: fix possible overflow with strcat

2019-03-13 Thread Ferruh Yigit
On 3/7/2019 12:56 PM, Chaitanya Babu Talluri wrote: > strcat does not check the destination length and there might be > chances of string overflow so instead of strcat, strlcat is used. > > Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") > Fixes: 540a211084 ("bnx2x: driver core") >

Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

2019-03-13 Thread Ferruh Yigit
On 3/5/2019 7:11 AM, Hyong Youb Kim wrote: > The driver currently has a devarg to set the rewrite mode during > init. Some apps want to programatically set it after running > rte_eal_init() and finding that ports are VIC. Add a private function > to support such applications. It is not good idea t

Re: [dpdk-dev] [PATCH 0/2] ethdev: use strlcpy

2019-03-13 Thread Ferruh Yigit
On 2/28/2019 10:47 PM, Stephen Hemminger wrote: > A couple of places in ethdev are clearer if strlcpy is used. > > Stephen Hemminger (2): > ethdev: replace snprintf with strlcpy > ethdev: use strlcpy instead of snprintf on initialization Series applied to dpdk-next-net/master, thanks. (2/2 u

Re: [dpdk-dev] [PATCH] bonding: fix lacp negotiation failed

2019-03-13 Thread Chas Williams
At a minimum you need to address the long lines in your patch. See http://mails.dpdk.org/archives/test-report/2019-March/076663.html otherwise this looks fine to me. On 3/13/19 9:23 AM, Liang Zhang wrote: When monitor(port-mirroring) traffic from other lacp port-channel, rx_machine_update may

Re: [dpdk-dev] [PATCH 1/1] net/qede: fix receive packet drop

2019-03-13 Thread Rasesh Mody
>From: dev On Behalf Of Shahed Shaikh >Sent: Tuesday, March 12, 2019 9:51 AM > >There is a corner case in which driver won't post receive buffers when driver >has processed all received packets in single loop (i.e. hw_consumer == >sw_consumer) and then HW will start dropping packets since it did n

Re: [dpdk-dev] [PATCH v2 0/3] add XTS support for Intel QAT

2019-03-13 Thread Trahe, Fiona
> -Original Message- > From: Nowak, DamianX > Sent: Wednesday, March 13, 2019 2:52 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; Nowak, DamianX > > Subject: [PATCH v2 0/3] add XTS support for Intel QAT > > This patchset adds XTS support for Intel > QuickAssist Technology. > > Following

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-13 Thread Rami Rosen
On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: > > The default config is used if the setup parameter is NULL. > > No need to query the default config with rte_eth_dev_info_get(). > > The function call will be removed with another useless info. > > > > Signed-off-by: Thomas Monjalo

Re: [dpdk-dev] [PATCH] ethdev: check for invalid device name

2019-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2019 12:52:50 + "Zhang, Qi Z" wrote: > HI > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, March 12, 2019 2:16 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH] ethde

[dpdk-dev] [PATCH v3 15/15] eal/linux: simplify debug message in sigbus_handler

2019-03-13 Thread Natanael Copa
There is no guarantee that pthread_self() returns the thread ID or that pthread_t is an integer. The thread ID is not that useful so simply remove it. This fixes the following warning when building with musl libc: ../lib/librte_eal/linuxapp/eal/eal_dev.c: In function 'sigbus_handler': ../lib/libr

Re: [dpdk-dev] [PATCH v2 03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc

2019-03-13 Thread Natanael Copa
On Wed, 13 Mar 2019 11:13:40 + Ferruh Yigit wrote: > On 3/12/2019 10:16 AM, Natanael Copa wrote: > > Add a fallback for non-GNU libc systems like musl libc for the > > non-standard functions outl_p, outw_p and outb_p. > > > > This ifixes the following buildtime errors when building with mus

[dpdk-dev] [PATCH v3 14/15] net/netvsc: fix compile warning for fcntl.h include

2019-03-13 Thread Natanael Copa
Fix the following warning when building with musl libc: In file included from ../drivers/net/netvsc/hn_vf.c:14: /usr/include/sys/fcntl.h:1:2: warning: #warning redirecting incorrect #include to [-Wcpp] #warning redirecting incorrect #include to ^~~ Signed-off-by: Natanael Copa --- d

[dpdk-dev] [PATCH v3 13/15] crypto/dpaa2_sec: simplify pr_{debug, err, warn} macros

2019-03-13 Thread Natanael Copa
Simplify pr_debug, pr_err and pr_warn macros by add an intermediate pr_msg macro. This way we only need test for SUPPRESS_PRINTS once. Signed-off-by: Natanael Copa --- drivers/crypto/dpaa2_sec/hw/compat.h | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff

[dpdk-dev] [PATCH v3 11/15] bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0

2019-03-13 Thread Natanael Copa
There is no standard saying that __WORDSIZE should be be defined or in what include it should be defined. Use a portable way to detect 64 bit environment. This fixes a warning when building with musl libc: warning: "__WORDSIZE" is not defined, evaluates to 0 [-Wundef] Signed-off-by: Natanael Co

[dpdk-dev] [PATCH v3 12/15] crypto/dpaa2_sec: build fix for musl libc

2019-03-13 Thread Natanael Copa
The swab16/swab32/swab64 are Linux specific and nog GNU libc specific. Keep the check for __GLIBC__ just in case other GNU systems depends on this (Hurd or GNU/kFreeBSD). This fixes a build error with musl libc. Signed-off-by: Natanael Copa --- drivers/crypto/dpaa2_sec/hw/compat.h | 10 +---

[dpdk-dev] [PATCH v3 09/15] app/test: fix setting of -D_GNU_SOURCE with meson

2019-03-13 Thread Natanael Copa
in app/test/meson.build the default_cflag is never used so the -D_GNU_SOURCE was never passed as intended. Fixes the following build error with musl libc: ../lib/librte_eal/common/include/rte_lcore.h:26:9: error: unknown type name 'cpu_set_t' typedef cpu_set_t rte_cpuset_t; ^

[dpdk-dev] [PATCH v3 10/15] bus/dpaa: use warn(3) instead of error(3) to improve portability

2019-03-13 Thread Natanael Copa
Fix build with musl libc by using warn(3) instead of error(3). This also fixes error message for kzmalloc failures which previously would have given "Unknown error -1". Signed-off-by: Natanael Copa --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 4 ++-- drivers/bus/dpaa/base/qbman/bman_driver.

[dpdk-dev] [PATCH v3 08/15] app/test: include fcntl.h due to use of O_RDONLY

2019-03-13 Thread Natanael Copa
Fix following build error with musl libc: ../app/test/test_eal_flags.c:152:55: error: 'O_RDONLY' undeclared (first use in this function) fd = openat(dirfd(hugepage_dir), dirent->d_name, O_RDONLY); ^~~~ Signed-off-by: Natanael Copa

[dpdk-dev] [PATCH v3 05/15] bus/fslmc: fix compile error with musl libc

2019-03-13 Thread Natanael Copa
This fixes the following compile error with musl libc: ../drivers/bus/fslmc/qbman/include/compat.h:41:10: error: 'stdout' undeclared (first use in this function) fflush(stdout); \ ^~ Signed-off-by: Natanael Copa --- drivers/bus/fslmc/qbman/include/compat.h | 1 + 1 file change

[dpdk-dev] [PATCH v3 07/15] net/nfp: build fix for musl libc

2019-03-13 Thread Natanael Copa
Fixes following build error on systems without execinfo.h: ../drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c:19:10: fatal error: execinfo.h: No such file or directory #include ^~~~ Signed-off-by: Natanael Copa --- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 2 ++ 1 file change

[dpdk-dev] [PATCH v3 06/15] bus/fslmc: remove unused include of error.h

2019-03-13 Thread Natanael Copa
Fixes following build error with musl libc: In file included from ../drivers/bus/fslmc/qbman/qbman_debug.c:6: ../drivers/bus/fslmc/qbman/include/compat.h:21:10: fatal error: error.h: No such file or directory #include ^ Apparently it is not used anywere in qbman so simply rem

[dpdk-dev] [PATCH v3 04/15] bus/pci: factor out various ifdefs in pci_uio_ioport_{read, write}

2019-03-13 Thread Natanael Copa
define the macros so we can remove various #if defined(RTE_ARCH_X86) Ref: https://bugs.dpdk.org/show_bug.cgi?id=35#c6 Signed-off-by: Natanael Copa --- drivers/bus/pci/linux/pci_uio.c | 54 +++-- 1 file changed, 24 insertions(+), 30 deletions(-) diff --git a/drivers/

[dpdk-dev] [PATCH v3 03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc

2019-03-13 Thread Natanael Copa
Add a fallback for non-GNU libc systems like musl libc for the non-standard functions outl_p, outw_p and outb_p. This ifixes the following buildtime errors when building with musl libc: pci_uio.c:(.text+0xaa1): undefined reference to `outw_p' pci_uio.c:(.text+0xac5): undefined reference to `outl_

[dpdk-dev] [PATCH v3 02/15] net/cxgbe: replace uint with unsigned int

2019-03-13 Thread Natanael Copa
Improve portability and fix build error with musl libc: In file included from ../drivers/net/cxgbe/cxgbe_filter.c:7: ../drivers/net/cxgbe/base/common.h:201:4: error: unknown type name 'uint' uint synmapen:1; /* SYN Map Enable */ ^~~~ Signed-off-by: Natanael Copa --- drivers/net/cxgbe/ba

[dpdk-dev] [PATCH v3 00/15] Build fixes for musl libc

2019-03-13 Thread Natanael Copa
A set of patches to fix build with musl libc. I also did a few cleanups wrt macros and fixed a few scary compiler warnings while at it. Please note that those are only compile tested on x86_64 with musl libc. v2 has some code style fixes reported by checkpatch v3 is a full reroll of the entire pa

[dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with unsigned int

2019-03-13 Thread Natanael Copa
Improve portability by avoid use non-standard 'uint'. This fixes following build error when building with musl libc: In file included from ../app/test-pmd/cmdline.c:75: ../app/test-pmd/testpmd.h:809:29: error: unknown type name 'uint'; did you mean 'int'? uint8_t *hash_key, uint hash_k

Re: [dpdk-dev] [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-13 Thread Ferruh Yigit
On 3/10/2019 2:27 PM, Liron Himi wrote: > Adding Alan. > > -Original Message- > From: Liron Himi > Sent: Monday, February 25, 2019 13:30 > To: ferruh.yi...@intel.com > Cc: dev@dpdk.org; Liron Himi ; Liron Himi > > Subject: RE: [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

Re: [dpdk-dev] [PATCH 00/15] Build fixes for musl libc

2019-03-13 Thread Natanael Copa
On Wed, 13 Mar 2019 11:45:09 + "Sirvys, Andrius" wrote: > I'm trying on Alpine Linux to build using make with the patches, and > there are quite a few errors saying argp.h doesn't exist. > > In file included from > /root/dpdk/drivers/bus/dpaa/base/fman/netcfg_layer.c:19: > /root/dpdk/drive

Re: [dpdk-dev] [PATCH v2 2/2] vhost: support requests only handled by external backend

2019-03-13 Thread Ilya Maximets
On 13.03.2019 18:55, Maxime Coquelin wrote: > External backends may have specific requests to handle, and so > we don't want the vhost-user lib to handle these requests as > errors. > > This patch also changes the experimental API by introducing > RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-use

[dpdk-dev] [PATCH v2 2/2] vhost: support requests only handled by external backend

2019-03-13 Thread Maxime Coquelin
External backends may have specific requests to handle, and so we don't want the vhost-user lib to handle these requests as errors. This patch also changes the experimental API by introducing RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib can report an error if a message is handled neithe

[dpdk-dev] [PATCH v2 1/2] vhost: add API to set protocol features flags

2019-03-13 Thread Maxime Coquelin
rte_vhost_driver_set_protocol_features API is to be used by external backends to advertize vhost-user protocol features it supports. It has to be called after rte_vhost_driver_register() and before rte_vhost_driver_start(). Example of usage to advertize VHOST_USER_PROTOCOL_F_FOOBAR protocol featu

[dpdk-dev] [PATCH v2 0/2] vhost: Support external backend only vhost-user requests

2019-03-13 Thread Maxime Coquelin
The goals of this series is to provide more flexibility to external backends to implement their specific vhost-user request handling without having to patch vhost-user library. First patch implements a new API for external backend to advertize its specific protocol features to vhost-user master.

Re: [dpdk-dev] [PATCH 2/2] vhost: support requests only handled by external backend

2019-03-13 Thread Maxime Coquelin
On 3/12/19 5:14 PM, Ilya Maximets wrote: On 12.03.2019 17:54, Maxime Coquelin wrote: External backends may have specific requests to handle, and so we don't want the vhost-user lib to handle these requests as errors. This patch also changes the experimental API by introducing RTE_VHOST_MSG_R

Re: [dpdk-dev] [PATCH v5 1/2] eal/ticketlock: ticket based to improve fairness

2019-03-13 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-11 at 13:52 +0800, Joyce Kong wrote: > The spinlock implementation is unfair, some threads may take locks > aggressively while leaving the other threads starving for long time. > > This patch introduces ticketlock which gives each waiting thread a > ticket and they can take the loc

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 03:14:27PM +, Ferruh Yigit wrote: > On 3/13/2019 2:43 PM, Bruce Richardson wrote: > > On Wed, Mar 13, 2019 at 02:21:31PM +, Ferruh Yigit wrote: > >> On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > >>> 13/03/2019 14:41, Ferruh Yigit: > On 3/12/2019 10:13 PM, Thoma

[dpdk-dev] [RFC] net/vdev_netvsc: check for required related drivers

2019-03-13 Thread Stephen Hemminger
The vdev_netvsc virtual driver that is used to do initialization on Hyper-V/Azure won't work without failsafe and tap device. If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't ther

Re: [dpdk-dev] [PATCH] devtools: fix invalid config check when building tags

2019-03-13 Thread Ferruh Yigit
On 3/13/2019 3:09 PM, Bruce Richardson wrote: > The check for a valid configuration in build-tags.sh relied on the output > of "make showconfig" rather than checking directly for a config file of > that name. This broke when as part of the rename of the linuxapp/bsdapp > configs to just linux/freeb

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Ferruh Yigit
On 3/13/2019 2:43 PM, Bruce Richardson wrote: > On Wed, Mar 13, 2019 at 02:21:31PM +, Ferruh Yigit wrote: >> On 3/13/2019 1:59 PM, Thomas Monjalon wrote: >>> 13/03/2019 14:41, Ferruh Yigit: On 3/12/2019 10:13 PM, Thomas Monjalon wrote: >> Bruce Richardson (6): >> eal/bsdapp: rena

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 03:02:57PM +, Bruce Richardson wrote: > On Wed, Mar 13, 2019 at 02:21:31PM +, Ferruh Yigit wrote: > > On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > > > 13/03/2019 14:41, Ferruh Yigit: > > >> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > > Bruce Richardson (6)

[dpdk-dev] [PATCH] devtools: fix invalid config check when building tags

2019-03-13 Thread Bruce Richardson
The check for a valid configuration in build-tags.sh relied on the output of "make showconfig" rather than checking directly for a config file of that name. This broke when as part of the rename of the linuxapp/bsdapp configs to just linux/freebsd, as we stopped advertising the old names even if th

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 02:21:31PM +, Ferruh Yigit wrote: > On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > > 13/03/2019 14:41, Ferruh Yigit: > >> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > Bruce Richardson (6): > eal/bsdapp: rename to freebsd > eal/linuxapp: rename to li

[dpdk-dev] [PATCH v2 3/3] cryptodev: remove XTS text duplication

2019-03-13 Thread Damian Nowak
This patch removes duplicated text about AES-XTS mode. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index eb5afc5..

[dpdk-dev] [PATCH v2 1/3] test/crypto: add tests for XTS on QAT

2019-03-13 Thread Damian Nowak
This patch adds test vectors for AES XTS mode on QAT. It uses different plaintext sizes and AES keys sizes of 128 and 256 bits. Signed-off-by: Damian Nowak --- app/test/test_cryptodev_aes_test_vectors.h | 223 - 1 file changed, 222 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v2 2/3] crypto/qat: add XTS for QAT session config

2019-03-13 Thread Damian Nowak
This patch adds XTS capabilities and enables XTS cipher mode on QAT. It also updates the documentation for newly supported AES XTS mode on QAT. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/features/qat.ini| 2 ++ doc/guides/cryptodevs/qat.rst | 3 ++- doc/guides/rel_no

[dpdk-dev] [PATCH v2 0/3] add XTS support for Intel QAT

2019-03-13 Thread Damian Nowak
This patchset adds XTS support for Intel QuickAssist Technology. Following cipher algorithms are available with this patchset: * AES XTS (128) * AES XTS (256) --- v2: - update release notes Damian Nowak (3): test/crypto: add tests for XTS on QAT crypto/qat: add XTS for QAT sessio

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 02:21:31PM +, Ferruh Yigit wrote: > On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > > 13/03/2019 14:41, Ferruh Yigit: > >> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > Bruce Richardson (6): > eal/bsdapp: rename to freebsd > eal/linuxapp: rename to li

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf

2019-03-13 Thread Aaron Conole
Ferruh Yigit writes: > On 3/13/2019 1:43 PM, Aaron Conole wrote: >> Ferruh Yigit writes: >> >>> On 3/12/2019 2:44 PM, Aaron Conole wrote: "Parthasarathy, JananeeX M" writes: > Hi > >> -Original Message- >> From: Parthasarathy, JananeeX M >> Sent: Tuesday,

[dpdk-dev] Statistics consistency

2019-03-13 Thread Matteo Croce
Hi, I noticed that the statistics field for short packet is spelled differently between drivers: src/dpdk$ git grep -E '"rx_undersized?_errors"' drivers/net/e1000/igb_ethdev.c: {"rx_undersize_errors", offsetof(struct e1000_hw_stats, ruc)}, drivers/net/i40e/i40e_ethdev.c: {"rx_undersized_errors",

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Ferruh Yigit
On 3/13/2019 1:59 PM, Thomas Monjalon wrote: > 13/03/2019 14:41, Ferruh Yigit: >> On 3/12/2019 10:13 PM, Thomas Monjalon wrote: Bruce Richardson (6): eal/bsdapp: rename to freebsd eal/linuxapp: rename to linux build/linux: rename macro from LINUXAPP to LINUX build/f

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf

2019-03-13 Thread Ferruh Yigit
On 3/13/2019 1:43 PM, Aaron Conole wrote: > Ferruh Yigit writes: > >> On 3/12/2019 2:44 PM, Aaron Conole wrote: >>> "Parthasarathy, JananeeX M" writes: >>> Hi > -Original Message- > From: Parthasarathy, JananeeX M > Sent: Tuesday, February 19, 2019 6:33 PM > To:

Re: [dpdk-dev] [PATCH v2 2/2] bus/fslmc: remove unneeded strdup

2019-03-13 Thread Hemant Agrawal
 Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 1/2] bus/fslmc: don't log error for other devices

2019-03-13 Thread Hemant Agrawal
Thanks  Acked-by: Hemant Agrawal

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Thomas Monjalon
13/03/2019 14:41, Ferruh Yigit: > On 3/12/2019 10:13 PM, Thomas Monjalon wrote: > >> Bruce Richardson (6): > >> eal/bsdapp: rename to freebsd > >> eal/linuxapp: rename to linux > >> build/linux: rename macro from LINUXAPP to LINUX > >> build/freebsd: rename macro from BSDPAPP to FREEBSD > >

Re: [dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat

2019-03-13 Thread Aaron Conole
Pallantla Poornima writes: > sprintf function is not secure as it doesn't check the length of string. > More secure function strlcat is used. > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima > --- > v2: Used strlcat t

Re: [dpdk-dev] [PATCH 1/3] eal: remove useless checks for already probed device

2019-03-13 Thread Zhang, Qi Z
Hi: > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, March 2, 2019 10:43 AM > To: dev@dpdk.org > Cc: Stojaczyk, Dariusz ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: [PATCH 1/3] eal: remove useless checks for already probed device > > The function

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf

2019-03-13 Thread Aaron Conole
Ferruh Yigit writes: > On 3/12/2019 2:44 PM, Aaron Conole wrote: >> "Parthasarathy, JananeeX M" writes: >> >>> Hi >>> -Original Message- From: Parthasarathy, JananeeX M Sent: Tuesday, February 19, 2019 6:33 PM To: Aaron Conole ; Poornima, PallantlaX Cc: de

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-13 Thread Ferruh Yigit
On 3/12/2019 10:13 PM, Thomas Monjalon wrote: >> Bruce Richardson (6): >> eal/bsdapp: rename to freebsd >> eal/linuxapp: rename to linux >> build/linux: rename macro from LINUXAPP to LINUX >> build/freebsd: rename macro from BSDPAPP to FREEBSD >> build/meson: change linuxapp to linux in m

Re: [dpdk-dev] [PATCH v5 2/2] test/ticketlock: add ticket lock test case

2019-03-13 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-03-11 at 13:52 +0800, Joyce Kong wrote: > Add test cases for ticket lock, recursive ticket lock, > and ticket lock performance. > > Signed-off-by: Joyce Kong > Reviewed-by: Gavin Hu > Reviewed-by: Phil Yang > --- > index 000..dfa818c > --- /dev/null > +++ b/app/test/test_ticket

[dpdk-dev] [PATCH] bonding: fix lacp negotiation failed

2019-03-13 Thread Liang Zhang
When monitor(port-mirroring) traffic from other lacp port-channel, rx_machine_update may recieving other lacp negotiation packets. Thus bond mode 4 will negotiation failed. Signed-off-by: Liang Zhang --- drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++-- drivers/net/bonding/rte_eth

Re: [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy

2019-03-13 Thread Jozwiak, TomaszX
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, February 24, 2019 11:42 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Jozwiak, TomaszX > Subject: [PATCH] app/compress-perf: call generic strlcpy > > The call to strlcpy uses either libc, li

Re: [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after eth adapter setup

2019-03-13 Thread Rao, Nikhil
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Wednesday, March 13, 2019 2:11 AM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > ; Rao, Nikhil ; Carrillo, > Erik G ; Gujjar, Abhinandan S > ; Mcnamara, John > > Cc: dev@dpdk.org; Pa

Re: [dpdk-dev] [PATCH] ethdev: check for invalid device name

2019-03-13 Thread Zhang, Qi Z
HI > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, March 12, 2019 2:16 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH] ethdev: check for invalid device name > > Do not allow creating a ethernet dev

Re: [dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping

2019-03-13 Thread Burakov, Anatoly
On 13-Mar-19 11:19 AM, Thomas Monjalon wrote: 13/03/2019 12:12, Shahaf Shuler: From: Thomas Monjalon +/** + * Device level DMA map function. + * After a successful call, the memory segment will be mapped to the + * given device. + * + * @note: Memory must be registered in advance using rte_ext

Re: [dpdk-dev] [PATCH 00/15] Build fixes for musl libc

2019-03-13 Thread Sirvys, Andrius
I'm trying on Alpine Linux to build using make with the patches, and there are quite a few errors saying argp.h doesn't exist. In file included from /root/dpdk/drivers/bus/dpaa/base/fman/netcfg_layer.c:19: /root/dpdk/drivers/bus/dpaa/include/netcfg.h:12:10: fatal error: argp.h: No such file or

Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 12:23:16PM +0100, Thomas Monjalon wrote: > 13/03/2019 12:17, Bruce Richardson: > > On Wed, Mar 13, 2019 at 12:06:38PM +0100, Thomas Monjalon wrote: > > > 07/03/2019 14:34, Bruce Richardson: > > > > Add a new file DPDK_VERSION to hold the current DPDK version number. > > > >

Re: [dpdk-dev] [PATCH v2 2/4] build: use version number from config file

2019-03-13 Thread Thomas Monjalon
13/03/2019 12:20, Bruce Richardson: > On Wed, Mar 13, 2019 at 12:13:52PM +0100, Thomas Monjalon wrote: > > 07/03/2019 14:35, Bruce Richardson: > > > +# > > > +# Version information completed when this file is processed for a build > > > +# > > > +CONFIG_RTE_VER_YEAR=__YEAR > > > +CONFIG_RTE_VER_MON

Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number

2019-03-13 Thread Thomas Monjalon
13/03/2019 12:17, Bruce Richardson: > On Wed, Mar 13, 2019 at 12:06:38PM +0100, Thomas Monjalon wrote: > > 07/03/2019 14:34, Bruce Richardson: > > > Add a new file DPDK_VERSION to hold the current DPDK version number. > > > Have meson use this file for it's project version, and have make use > > >

Re: [dpdk-dev] [PATCH v2 2/4] build: use version number from config file

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 12:13:52PM +0100, Thomas Monjalon wrote: > 07/03/2019 14:35, Bruce Richardson: > > +# > > +# Version information completed when this file is processed for a build > > +# > > +CONFIG_RTE_VER_YEAR=__YEAR > > +CONFIG_RTE_VER_MONTH=__MONTH > > +CONFIG_RTE_VER_MINOR=__MINOR > > +

Re: [dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping

2019-03-13 Thread Thomas Monjalon
13/03/2019 12:12, Shahaf Shuler: > From: Thomas Monjalon > > > +/** > > > + * Device level DMA map function. > > > + * After a successful call, the memory segment will be mapped to the > > > + * given device. > > > + * > > > + * @note: Memory must be registered in advance using rte_extmem_* > > AP

Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 12:06:38PM +0100, Thomas Monjalon wrote: > 07/03/2019 14:34, Bruce Richardson: > > Add a new file DPDK_VERSION to hold the current DPDK version number. > > Have meson use this file for it's project version, and have make use > > it for reporting out "showversion" and "showve

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-13 Thread Ye Xiaolong
On 03/13, Ferruh Yigit wrote: > >>> <...> >>> +Prerequisites +- + +This is a Linux-specific PMD, thus the following prerequisites apply: + +* A Linux Kernel with XDP sockets configuration enabled; >>> >>> Can you please give more details of what exact vani

Re: [dpdk-dev] [PATCH v2 2/4] build: use version number from config file

2019-03-13 Thread Thomas Monjalon
07/03/2019 14:35, Bruce Richardson: > +# > +# Version information completed when this file is processed for a build > +# > +CONFIG_RTE_VER_YEAR=__YEAR > +CONFIG_RTE_VER_MONTH=__MONTH > +CONFIG_RTE_VER_MINOR=__MINOR > +CONFIG_RTE_VER_SUFFIX=__SUFFIX > +CONFIG_RTE_VER_RELEASE=__RELEASE [...] > -/** >

Re: [dpdk-dev] [PATCH v2 03/15] bus/pci: add fallback for out[lwb]_p for non GNU libc

2019-03-13 Thread Ferruh Yigit
On 3/12/2019 10:16 AM, Natanael Copa wrote: > Add a fallback for non-GNU libc systems like musl libc for the > non-standard functions outl_p, outw_p and outb_p. > > This ifixes the following buildtime errors when building with musl libc: > pci_uio.c:(.text+0xaa1): undefined reference to `outw_p'

Re: [dpdk-dev] [PATCH v4 3/6] bus: introduce device level DMA memory mapping

2019-03-13 Thread Shahaf Shuler
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 13, 2019 11:56 AM > To: Shahaf Shuler ; anatoly.bura...@intel.com > Cc: dev@dpdk.org; Yongseok Koh ; > ferruh.yi...@intel.com; nhor...@tuxdriver.com; gaetan.ri...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v4 3/6] bus

[dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat

2019-03-13 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function strlcat is used. Fixes: 727909c592 ("app/test: introduce dynamic commands list") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: Used strlcat to avoid buffer overflow. --- app/test/comman

Re: [dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number

2019-03-13 Thread Thomas Monjalon
07/03/2019 14:34, Bruce Richardson: > Add a new file DPDK_VERSION to hold the current DPDK version number. > Have meson use this file for it's project version, and have make use > it for reporting out "showversion" and "showversionum". > > Signed-off-by: Bruce Richardson > Acked-by: Luca Boccassi

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eventdev: fix sprintf with snprintf

2019-03-13 Thread Ferruh Yigit
On 3/12/2019 2:44 PM, Aaron Conole wrote: > "Parthasarathy, JananeeX M" writes: > >> Hi >> >>> -Original Message- >>> From: Parthasarathy, JananeeX M >>> Sent: Tuesday, February 19, 2019 6:33 PM >>> To: Aaron Conole ; Poornima, PallantlaX >>> >>> Cc: dev@dpdk.org; Pattan, Reshma ; Rao, N

Re: [dpdk-dev] [PATCH v2 1/4] .gitignore: add section header comments

2019-03-13 Thread Thomas Monjalon
11/03/2019 11:57, Bruce Richardson: > Split the ignored file list into section based on logical groups of files, > putting a comment at the top of each section clarifying what it is. > > Signed-off-by: Bruce Richardson Series applied, thanks

Re: [dpdk-dev] [PATCH v1 1/6] net/af_xdp: introduce AF_XDP PMD driver

2019-03-13 Thread Ferruh Yigit
>> <...> >> >>> +Prerequisites >>> +- >>> + >>> +This is a Linux-specific PMD, thus the following prerequisites apply: >>> + >>> +* A Linux Kernel with XDP sockets configuration enabled; >> >> Can you please give more details of what exact vanilla kernel version? > > Do you mean I s

Re: [dpdk-dev] [PATCH 2/2] examples/ethtool: allocate only one mempool

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 11:09:10AM +0100, Thomas Monjalon wrote: > No need to allocate one mempool per port. > The number of mbufs is fixed for simplicity. > While it's simpler to use a fixed number of mbufs, having a fixed number of mbufs multiplied by the number of ports is safer IMHO, and not re

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: remove query of default config

2019-03-13 Thread Bruce Richardson
On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote: > The default config is used if the setup parameter is NULL. > No need to query the default config with rte_eth_dev_info_get(). > The function call will be removed with another useless info. > > Signed-off-by: Thomas Monjalon Acked

[dpdk-dev] [Bug 226] Cryptodevs instruction for Kasumi isn't correct

2019-03-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=226 Bug ID: 226 Summary: Cryptodevs instruction for Kasumi isn't correct Product: DPDK Version: 19.02 Hardware: x86 OS: Linux Status: CONFIRMED Severity: minor

Re: [dpdk-dev] [PATCH v1 0/6] Introduce AF_XDP PMD

2019-03-13 Thread Karlsson, Magnus
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, March 12, 2019 2:52 AM > To: Thomas Monjalon ; Yigit, Ferruh > ; Ye, Xiaolong > Cc: dev@dpdk.org; Richardson, Bruce ; > Karlsson, Magnus ; Topel, Bjorn > > Subject: RE: [dpdk-dev] [PATCH v1 0/6] Introduce AF_XDP PMD > > + Magnu

Re: [dpdk-dev] [PATCH] net/i40e: fix time sync for 25G

2019-03-13 Thread Luo, Michael
Verified the patch on DPDK 18.11. Best regards, Michael -Original Message- From: Zhang, Qi Z Sent: Monday, March 11, 2019 3:42 PM To: dev@dpdk.org Cc: Luo, Michael ; Zhang, Qi Z ; sta...@dpdk.org Subject: [PATCH] net/i40e: fix time sync for 25G Time sync increment value is not configu

[dpdk-dev] [PATCH 2/2] examples/ethtool: allocate only one mempool

2019-03-13 Thread Thomas Monjalon
No need to allocate one mempool per port. The number of mbufs is fixed for simplicity. Signed-off-by: Thomas Monjalon --- examples/ethtool/ethtool-app/main.c | 32 - 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/examples/ethtool/ethtool-app/main.c b/

  1   2   >