13/03/2019 12:12, Shahaf Shuler: > From: Thomas Monjalon <tho...@monjalon.net> > > > +/** > > > + * Device level DMA map function. > > > + * After a successful call, the memory segment will be mapped to the > > > + * given device. > > > + * > > > + * @note: Memory must be registered in advance using rte_extmem_* > > APIs. > > > > Could we make more explicit that this function is part of the "external > > memory API"? > > How do you suggest?
There could be an explicit comment. > This function belongs to rte_dev therefore the rte_dev prefix. better > rte_dev_extmem_dma_map ? Not sure about the prefix. Anatoly?