Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

2019-03-08 Thread Stephen Hemminger
On Sat, 09 Mar 2019 01:47:32 +0100 Thomas Monjalon wrote: > 06/03/2019 18:05, Bruce Richardson: > > test-meson-build.sh generates multiple build directories for various > > targets. As these follow a few known patterns of reasonable lengths, > > and since they don't need to be tracked in git, we

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Stephen Hemminger
On Fri, 8 Mar 2019 13:00:16 -0500 olegpoly123 wrote: > long iov_max = sysconf(_SC_IOV_MAX); > + > + if (iov_max <= 0) { > + TAP_LOG(WARNING, > + "_SC_IOV_MAX is not defined. Using %d as default\n", > TAP_IOV_DEFAULT_MAX); > + iov_max = TAP_I

Re: [dpdk-dev] [PATCH v1 1/4] baseband/fpga_lte_fec: addition of driver for 4G turbo FEC with PAC N300 FPGA card

2019-03-08 Thread Thomas Monjalon
Hi, 01/03/2019 18:23, Smith, Eleanor: > Addition of a FPGA driver for acceleration of 4G turbo encoding and > decoding. > > Signed-off-by: Smith, Eleanor I'm really not comfortable adding a new Intel bbdev driver, while the turbo sw driver cannot be freely compiled. I know some work is in progr

Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

2019-03-08 Thread Thomas Monjalon
06/03/2019 17:22, Bruce Richardson: > The terms linuxapp and bsdapp are legacy names in DPDK that are equivalent > to the more usual names of "linux" and "freebsd". Therefore, we can > replace the instances of the "app" names with the more usual variants. The > only issue in maintaining backward co

Re: [dpdk-dev] [PATCH v4] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Stephen Hemminger
On Fri, 8 Mar 2019 14:06:58 -0500 olegpoly123 wrote: > struct rx_queue *rxq = &internals->rxq[rx_queue_id]; > struct rte_mbuf **tmp = &rxq->pool; > long iov_max = sysconf(_SC_IOV_MAX); > + > + if (iov_max <= 0) { > + TAP_LOG(WARNING, > + "_SC

[dpdk-dev] replacing snprintf with strlcpy where possible

2019-03-08 Thread Stephen Hemminger
If someone is familiar with coccinelle it should be possible to replace all uses of: snprintf(buf, sizeof(buf), "%s", foo); with: strlcpy(buf, foo, sizeof(buf)); using semantic patch $ git grep snprintf | grep '"%s"' | grep -v ' = ' | wc -l 114 This could go on the cleanup dpdk-ne

Re: [dpdk-dev] [PATCH 4/4] .gitignore: ignore build directories from test-meson-build

2019-03-08 Thread Thomas Monjalon
06/03/2019 18:05, Bruce Richardson: > test-meson-build.sh generates multiple build directories for various > targets. As these follow a few known patterns of reasonable lengths, > and since they don't need to be tracked in git, we can add them to > the gitignore file. > > Signed-off-by: Bruce Rich

Re: [dpdk-dev] [PATCH v8] eal_interrupts: add option for pending callback unregister

2019-03-08 Thread Thomas Monjalon
Sorry for the delay in review. I hoped someone else would review this patch. Let's get this patch in DPDK 19.05, after doing some small changes (see below). 17/12/2018 13:30, Jakub Grajciar: > use case: if callback is used to receive message form socket, > and the message received is disconnect/er

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-08 Thread Honnappa Nagarahalli
> 08/03/2019 16:50, Ananyev, Konstantin: > > 08/03/2019 16:05, Gavin Hu (Arm Technology China): > > > Anyway, on x86, smp_rmb, as a compiler barrier, applies to load/store, not > only load/load. > > > > Yes, that's true, but I think that's happened by coincidence, not > > intentionally. > > > > > T

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-08 Thread Thomas Monjalon
08/03/2019 16:50, Ananyev, Konstantin: > 08/03/2019 16:05, Gavin Hu (Arm Technology China): > > Anyway, on x86, smp_rmb, as a compiler barrier, applies to load/store, not > > only load/load. > > Yes, that's true, but I think that's happened by coincidence, > not intentionally. > > > This is the

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Thomas Monjalon
08/03/2019 20:29, olegpoly123: > From: Oleg Polyakov > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: Oleg Polyakov Please add the "Fixes:" line and the "Acked-by" line from Keith

[dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-08 Thread David Harton
ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable these offloads at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- v2: removed unused

[dpdk-dev] [PATCH v5] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
From: Oleg Polyakov If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: Oleg Polyakov --- drivers/net/tap/rte_eth_tap.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/tap

[dpdk-dev] [launchTime] [DPDK] [i210]

2019-03-08 Thread Siddiqui, Tariq
Hi Community, I am looking for any "Launchtime"(Qbv) feature's equivalent functionality support with i210 driver with DPDK. Has anyone worked on it and familiar with what is best way to achieve above with dpdk ? Thanks in advance.

Re: [dpdk-dev] [PATCH v4] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 1:06 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: Oleg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 8 > 1 file chang

[dpdk-dev] [PATCH v4] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: Oleg Polyakov --- drivers/net/tap/rte_eth_tap.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/driver

Re: [dpdk-dev] [PATCH] app/eventdev: configure optimum event timers per timer adapter

2019-03-08 Thread Jerin Jacob Kollanukkaran
On Thu, 2019-02-28 at 18:48 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Previously, the total number of event timers per adapter was set to > an > arbitrary value, set it to mempool size instead as it defines the max > event timers that can be armed. > > Signed-off-by:

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Thomas Monjalon
Thanks for contributing. Please find two comments below. > > On Mar 8, 2019, at 12:00 PM, olegpoly123 wrote: > > > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > > In this case, iov_max is set to a default value of 1024. > > > > Cc: sta...@dpdk.org Is there any specific commit we

Re: [dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info

2019-03-08 Thread Jerin Jacob Kollanukkaran
On Fri, 2019-03-01 at 07:16 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Some eventdevs support configuring max events to be -1 (open system). > Check eventdev and event port configuration with eventdev info before > configuring them. > > Signed-off-by: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH 1/2] app/eventdev: start event producers after eventdev is started

2019-03-08 Thread Jerin Jacob Kollanukkaran
On Wed, 2019-02-27 at 20:00 +, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh > > Start event producers after eventdev i.e. consumer is started as in > some > architectures it might lead to undefined behaviour or events being > dropped. > > Signed-off-by: Pavan Nikhilesh > ---

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 12:00 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: olegpoly123 > --- > drivers/net/tap/rte_eth_tap.c | 8 > 1 file change

[dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: olegpoly123 --- drivers/net/tap/rte_eth_tap.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/

Re: [dpdk-dev] [PATCH v2] lib/cfgfile: replace strcat with strlcat

2019-03-08 Thread Ferruh Yigit
On 3/8/2019 2:02 PM, Bruce Richardson wrote: > On Fri, Mar 08, 2019 at 12:45:50PM +, Chaitanya Babu Talluri wrote: >> Replace strcat with strlcat to avoid buffer overflow. >> >> Fixes: a6a47ac9c2 ("cfgfile: rework load function") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Chaitanya Babu Tallur

Re: [dpdk-dev] [PATCH v2 1/2] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Stephen Hemminger
On Fri, 8 Mar 2019 10:55:46 -0500 olegpoly123 wrote: > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 6f5109fca..cd48b2b2a 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -1326,6 +1326,11 @@ tap_rx_queue_setup(struct rte

[dpdk-dev] [PATCH v2 2/2] Define macro for iov_max default value

2019-03-08 Thread olegpoly123
Cc: sta...@dpdk.org Signed-off-by: Oeg Polyakov --- drivers/net/tap/rte_eth_tap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index cd48b2b2a..e7da73509 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/dr

[dpdk-dev] [PATCH v2 1/2] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: Oeg Polyakov --- drivers/net/tap/rte_eth_tap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/ne

Re: [dpdk-dev] [PATCH v2 2/2] Define macro for iov_max default value

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 9:55 AM, olegpoly123 wrote: > > Cc: sta...@dpdk.org > > Signed-off-by: Oeg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-08 Thread Ananyev, Konstantin
> > > > > >>> In weak memory models, like arm64, reading the {prod,cons}.tail > > > > > >>> may get reordered after reading or writing the ring slots, which > > > > > >>> corrupts the ring and stale data is observed. > > > > > >>> > > > > > >>> This issue was reported by NXP on 8-A72 DPAA2 board.

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-08 Thread Ananyev, Konstantin
> > > > > >>> In weak memory models, like arm64, reading the {prod,cons}.tail > > may > > > > get > > > > > >>> reordered after reading or writing the ring slots, which corrupts > > the > > > > ring > > > > > >>> and stale data is observed. > > > > > >>> > > > > > >>> This issue was reported by N

[dpdk-dev] [PATCH 1/1] net/nfp: fix set_mac_addr

2019-03-08 Thread Pablo Cascón
Some firmwares, mostly for VFs, do not advertise the feature / capability of changing the MAC address while the interface is up. With such firmware a request to change the MAC address that at the same time also tries to enable the not available feature will be denied by the firmware resulting in an

Re: [dpdk-dev] [PATCH v2 0/2] examples/ipsec-secgw: fix 1st pkt dropped

2019-03-08 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, March 7, 2019 2:58 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard > Subject: [PATCH v2 0/2] examples/ipsec-secgw: fix 1st pkt dropped > > This patchset fixes the issue of the

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app

2019-03-08 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, March 7, 2019 10:35 AM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: [PATCH] examples/ipsec-secgw: fix debug in ipsec-secgw app > > Improve debug co

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-08 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 8, 2019 8:13 PM > To: Gavin Hu (Arm Technology China) ; Ilya > Maximets ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Honnappa Nagaraha

Re: [dpdk-dev] [PATCH v2] lib/cfgfile: replace strcat with strlcat

2019-03-08 Thread Bruce Richardson
On Fri, Mar 08, 2019 at 12:45:50PM +, Chaitanya Babu Talluri wrote: > Replace strcat with strlcat to avoid buffer overflow. > > Fixes: a6a47ac9c2 ("cfgfile: rework load function") > Cc: sta...@dpdk.org > > Signed-off-by: Chaitanya Babu Talluri > --- > v2: Instead of strcat, used strlcat. > -

Re: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment and layout

2019-03-08 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin Ananyev > Sent: Thursday, March 7, 2019 2:13 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; umesh.kar...@caviumnetworks.com; De Lara Guarch, > Pablo > ; shally.ve...@caviumnetworks.com; Ananyev, >

[dpdk-dev] [PATCH v2] lib/cfgfile: replace strcat with strlcat

2019-03-08 Thread Chaitanya Babu Talluri
Replace strcat with strlcat to avoid buffer overflow. Fixes: a6a47ac9c2 ("cfgfile: rework load function") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- v2: Instead of strcat, used strlcat. --- lib/librte_cfgfile/rte_cfgfile.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixgbvef

2019-03-08 Thread David Harton (dharton)
Hi > -Original Message- > From: Zhao1, Wei > Sent: Friday, March 08, 2019 1:35 AM > To: David Harton (dharton) ; dev@dpdk.org; Lu, Wenzhuo > ; Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for > ixgbvef > > Hi, David Harton > > > -Orig

Re: [dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations

2019-03-08 Thread Ananyev, Konstantin
> -Original Message- > From: Gavin Hu (Arm Technology China) [mailto:gavin...@arm.com] > Sent: Friday, March 8, 2019 4:23 AM > To: Ilya Maximets ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; nipun.gu...@nxp.com; Honnappa > Nagarahalli ; oliv

[dpdk-dev] How to send packet with line rate on I350-DA2, but not care rx speed

2019-03-08 Thread hfli
Wenzhuo, >From "MAINTAINERS" file in package of dpdk source code, I know that you maintain e1000e driver now, could you help me for an question? I use DPDK-pktgen based on Intel I350-DA2 network adapters, when I loopback two ports on one NIC(I350_eth1 <-> I350_eth2), I got 1Gbps line rate T

Re: [dpdk-dev] [EXT] [PATCH] net/qede: support IOVA VA mode

2019-03-08 Thread Rasesh Mody
>From: Kevin Traynor >Sent: Thursday, March 07, 2019 10:39 AM > >-- >Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags. This allows initializing qede PMD >as non-root also on Linux v4.x, where /proc/self/pagemap can't be acccessed >without

[dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread olegpoly123
If the value _SC_IOV_MAX is missing, sysconf returns -1. In this case, iov_max is set to a default value of 1024. Cc: sta...@dpdk.org Signed-off-by: Oeg Polyakov --- drivers/net/tap/rte_eth_tap.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/ne

[dpdk-dev] Intel XXV710 NIC drops K8S IPIP Over GRE packet

2019-03-08 Thread kai xi fan
Hi, Recently our customers complained that their pod could not ping each other in their k8s group. After some debug, we found that pod sends ' IPIP Over GRE ' packet. And DPDK fetch pkt_type from packet descriptor, and it's always zero for this type of packet without IPV4 flag set. The packet desc

[dpdk-dev] [PATCH v2] net/nfp: fix possible buffer overflow

2019-03-08 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 896c265ef9 ("net/nfp: use new CPP interface") Fixes: c4171b520b ("net/nfp: support PF multiport") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- v2: updated title as

Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend

2019-03-08 Thread Maxime Coquelin
On 3/8/19 10:18 AM, Stojaczyk, Dariusz wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin Sent: Thursday, February 28, 2019 4:32 PM To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei ; i.maxim...@samsung.com Cc: Maxime Coquelin Subject: [dpdk-dev

Re: [dpdk-dev] [PATCH] eal: unmap unneed dpdk VA spaces for legacy mem

2019-03-08 Thread Burakov, Anatoly
On 08-Mar-19 5:38 AM, Lilijun wrote: Comparing dpdk VA spaces to dpdk 16.11, the dpdk app process's VA spaces increase to above 30G. Here we can unmap the unneed VA spaces in rte_memseg_list. Signed-off-by: Lilijun --- lib/librte_eal/linuxapp/eal/eal_memory.c | 13 - 1 file chan

[dpdk-dev] [PATCH v2] net/qede: support IOVA VA mode

2019-03-08 Thread Kevin Traynor
Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags. This allows initializing qede PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be acccessed without CAP_SYS_ADMIN privileges. The flag was introduced generically but not in pmds in commit: 815c7deaed2d ("pci: get IOMMU class on Linux") Cc

Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend

2019-03-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, February 28, 2019 4:32 PM > To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei > ; i.maxim...@samsung.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [RFC v2 2/2] vhost: support request

Re: [dpdk-dev] [RFC v2 1/2] vhost: add API to set protocol features flags

2019-03-08 Thread Stojaczyk, Dariusz
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, February 28, 2019 4:32 PM > To: dev@dpdk.org; Liu, Changpeng ; Bie, Tiwei > ; i.maxim...@samsung.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [RFC v2 1/2] vhost: add API to se

[dpdk-dev] [dpdk-announce] Bangalore DPDM summit 9th March and DPDK Hands on March 8th

2019-03-08 Thread Tibrewala, Sujata
Hi, Last few seats remaining at the summit and the hands on Training, please hurry as we have barely two days to go. Registration link to the DPDK summit March 9th: https://www.dpdk.org/event/dpdk-summit-bangalore-2019/ Registration link to the DPDK hands on training March 8th : https://www.me

Re: [dpdk-dev] [dpdk-announce] DPDK development process and tools survey

2019-03-08 Thread Honnappa Nagarahalli
So far I have got 27 responses. This survey should not take more than 10mns. I kindly request you to take the survey to provide the feedback. Thank you, Honnappa > -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, February 27, 2019 3:08 PM > To: annou...@dpdk.org > Cc: