Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: promiscuous mode enable on VF

2019-02-28 Thread Zhang, Qi Z
HI > -Original Message- > From: Zhao1, Wei > Sent: Wednesday, February 13, 2019 3:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v3 1/2] net/ixgbe: promiscuous mode enable on VF > > There is need to enable two ops of promiscuous_enable and >

Re: [dpdk-dev] [PATCH 2/2] ethdev: use strlcpy instead of snprintf on initialization

2019-02-28 Thread Andrew Rybchenko
On 3/1/19 1:47 AM, Stephen Hemminger wrote: Don't need to use snprintf for simple name copy. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c

Re: [dpdk-dev] [PATCH v3 2/2] net/ixgbe: add support of loopback for X540/X550

2019-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, February 21, 2019 10:31 AM > To: Julien Meunier ; Zhang, Qi Z > ; Lu, Wenzhuo ; Ananyev, > Konstantin > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 2/2] net/ixgbe: add support of loopback for X540/X550 > > Acked-by: Wei Zhao Applie

Re: [dpdk-dev] [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback mode

2019-02-28 Thread Zhang, Qi Z
> -Original Message- > From: Julien Meunier [mailto:julien.meun...@nokia.com] > Sent: Thursday, February 21, 2019 5:05 AM > To: Zhao1, Wei ; Zhang, Qi Z ; Lu, > Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org > Subject: [PATCH v3 1/2] net/ixgbe: do not start on unsupported loopback m

Re: [dpdk-dev] [PATCH 1/2] ethdev: replace snprintf with strlcpy

2019-02-28 Thread Andrew Rybchenko
On 3/1/19 1:47 AM, Stephen Hemminger wrote: The set_port_owner was copying a string between structures of the same type, therefore the name could never be truncated (unless source string was not null terminated). Use strlcpy which does it better. Signed-off-by: Stephen Hemminger Acked-by: An

Re: [dpdk-dev] [PATCH] app/testpmd: use mempool bulk get for txonly mode

2019-02-28 Thread Andrew Rybchenko
On 2/28/19 10:42 PM, Pavan Nikhilesh Bhagavatula wrote: From: Pavan Nikhilesh Use mempool bulk get ops to alloc burst of packets and process them instead of calling pktalloc for every packet. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 139 +---

[dpdk-dev] [PATCH 6/6] doc: add documention for windows

2019-02-28 Thread Anand Rawat
Add documentation to build helloworld example on windows using meson and clang. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- doc/guides/index.rst | 1 + doc/guides/windows_gsg/build_dpdk.rst | 76 +

[dpdk-dev] [PATCH 5/6] examples: Add meson changes for windows

2019-02-28 Thread Anand Rawat
Add meson changes to build helloworld example on windows. Only EAL is supported currently. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- examples/meson.build | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) di

[dpdk-dev] [PATCH 4/6] eal: add minimum viable code for eal on windows

2019-02-28 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Update meson logic to build eal on windows. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/common/meson.build | 43 +

[dpdk-dev] [PATCH 2/6] eal: Add header files to support windows

2019-02-28 Thread Anand Rawat
Added header files to support windows on x86 platforms. Updated rte_config to include rte_windows.h for windows build. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- config/rte_config.h | 15

[dpdk-dev] [PATCH 3/6] eal: Add headers for compatibility with windows environment

2019-02-28 Thread Anand Rawat
Added headers to support windows environment for common source. These headers will have windows specific implementions of the system library apis provided in linux and freebsd. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- .

[dpdk-dev] [PATCH 0/6] HelloWorld example for Windows

2019-02-28 Thread Anand Rawat
Helloworld example for Windows. Includes Windows-specific EAL changes and meson changes to build the code on Windows. Anand Rawat (6): eal: eal stub to add windows support eal: Add header files to support windows eal: Add headers for compatibility with windows environment eal: add minimum

[dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support

2019-02-28 Thread Anand Rawat
Added initial stub source files for windows support and meson changes to build them. Signed-off-by: Anand Rawat Signed-off-by: Kadam, Pallavi Reviewed-by: Jeffrey B Shaw Reviewed-by: Ranjit Menon --- config/meson.build| 28 +-- config/x86/meson.build

[dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown sequence

2019-02-28 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Stop eventdev before closing it. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index 5db3ffde1..1e525643d

[dpdk-dev] [PATCH 1/3] examples/eventdev_pipeline: configure max events based on dev info

2019-02-28 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Some eventdevs support configuring max events to be -1 (open system). Check eventdev and event port configuration with eventdev info before configuring them. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/pipeline_worker_generic.c | 6 ++ examples/event

[dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: follow proper teardown sequence

2019-02-28 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Stop eventdev before closing it. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_pipeline/main.c index 92e08bc0c..2ad7d24e2 100644 --- a/example

[dpdk-dev] [PATCH v1] maintainers: resign all maintainerships

2019-02-28 Thread Remy Horton
After today I will no longer be with Intel, so I am removing my name from all related maintainer roles. Signed-off-by: Remy Horton --- MAINTAINERS | 4 1 file changed, 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b39bc6..f13c241 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @

Re: [dpdk-dev] [PATCH 2/2] ethdev: use strlcpy instead of snprintf on initialization

2019-02-28 Thread Rami Rosen
Reviewed-by: Rami Rosen

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Anoob Joseph
Hi Fiona, Akhil, > -Original Message- > From: dev On Behalf Of Trahe, Fiona > Sent: Thursday, February 28, 2019 8:00 PM > To: Akhil Goyal ; Anoob Joseph > ; Doherty, Declan ; De > Lara Guarch, Pablo ; Yigit, Ferruh > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raj

Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support for testpmd

2019-02-28 Thread Xu, Rosen
Hi, From: David Marchand [mailto:david.march...@redhat.com] Sent: Thursday, February 28, 2019 16:48 To: Xu, Rosen Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Tianfei ; Wei, Dan ; Pei, Andy ; Yang, Qiming ; Wang, Haiyue ; Chen, Santos ; Zhang, Zhang Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/t

[dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode

2019-02-28 Thread Qiming Yang
As some advanced features are not supported in safe mode, this patch disabled them when safe mode flags is set. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/n

[dpdk-dev] [PATCH 1/2] net/ice: suppport package download

2019-02-28 Thread Qiming Yang
Columbiaville requires a package to be downloaded if need advanced features. This patch add package download support in two ways. If it configured package path in devargs, will use this path, if not, will load the package at /lib/firmware/intel/ice/ddp/ice.pkg. When package download failed, will i

Re: [dpdk-dev] [PATCH 3/8] net/ice: support RX SSE vector

2019-02-28 Thread Zhang, Qi Z
Hi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, February 28, 2019 3:49 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH 3/8] net/ice: support RX SSE vector > > Signed-off-by: Wenzhuo Lu > --- > config/commo

Re: [dpdk-dev] [PATCH 0/8] Support vector instructions on ICE

2019-02-28 Thread Zhang, Qi Z
HI Wenzhuo: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Thursday, February 28, 2019 3:49 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH 0/8] Support vector instructions on ICE > > Use SSE and AVX2 instructions in IC

[dpdk-dev] [RFC] net/mlx: enable DMA memory registration from secondary process

2019-02-28 Thread Yongseok Koh
For both mlx4 and mlx5, the Memory Region (MR) for DMA memory can't be created from secondary process due to lib/driver limitation. It is prohibited in the code for now, thus all the memory being used by secondary process should be registered on initialization. mlx5_mr_create(...) { [...]

[dpdk-dev] [RFC] net/mlx4: add secondary process support

2019-02-28 Thread Yongseok Koh
In 19.05, mlx4 PMD will start to support secondary process. This will need new rdma-core API and small fix in kernel driver, in order for Verbs to allow using external (rte_malloc) memory allocator and remapping UAR space because secondary process has to access device queues and UAR for Tx doorbell

[dpdk-dev] [RFC] net/mlx5: improve out of box performance

2019-02-28 Thread Yongseok Koh
Hi, This one could never be done last time, but this will be tried again for v19.05. Thanks, Yongseok > On Jun 7, 2018, at 5:38 PM, Yongseok Koh wrote: > > In mlx5 PMD, there are multiple Tx burst functions, > mlx5_tx_burst() > mlx5_tx_burst_mpw() > mlx5_tx_burst_mpw_inline() > mlx5_tx

Re: [dpdk-dev] [dpdk-announce] DPDK summit March 9th and Hands on Session March 8th Bangalore Schedule announced

2019-02-28 Thread Tibrewala, Sujata
Hi, A reminder to register before the seats fill up DPDK summit Bangalore March 9th and DPDK hands on session the day before on March 8th at Bangalore. https://www.dpdk.org/event/dpdk-summit-bangalore-2019/ Nivruti Rai who is leading Intel India into an era of all-pervasive technology has

Re: [dpdk-dev] [PATCH v2 1/2] Enable codespell by default. Can be disabled from config file.

2019-02-28 Thread Thomas Monjalon
28/02/2019 23:09, Michael Santana Francisco: > On 2/28/19 6:21 AM, Thomas Monjalon wrote: > > 14/02/2019 20:35, Michael Santana: > >> Enable codespell by default. > >> codespell is a feature by checkpatch.pl that > >> checks for common spelling mistakes in patches. > > What is the difference betwee

[dpdk-dev] [PATCH 0/2] ethdev: use strlcpy

2019-02-28 Thread Stephen Hemminger
A couple of places in ethdev are clearer if strlcpy is used. Stephen Hemminger (2): ethdev: replace snprintf with strlcpy ethdev: use strlcpy instead of snprintf on initialization lib/librte_ethdev/rte_ethdev.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) -- 2.17.1

[dpdk-dev] [PATCH 1/2] ethdev: replace snprintf with strlcpy

2019-02-28 Thread Stephen Hemminger
The set_port_owner was copying a string between structures of the same type, therefore the name could never be truncated (unless source string was not null terminated). Use strlcpy which does it better. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 8 ++-- 1 file cha

[dpdk-dev] [PATCH 2/2] ethdev: use strlcpy instead of snprintf on initialization

2019-02-28 Thread Stephen Hemminger
Don't need to use snprintf for simple name copy. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 95889ed206db..8bd54dcf58c1 100644 --- a/l

Re: [dpdk-dev] [PATCH v2 1/2] Enable codespell by default. Can be disabled from config file.

2019-02-28 Thread Michael Santana Francisco
On 2/28/19 6:21 AM, Thomas Monjalon wrote: 14/02/2019 20:35, Michael Santana: Enable codespell by default. codespell is a feature by checkpatch.pl that checks for common spelling mistakes in patches. What is the difference between codespell and spelling.txt included with checkpatch? Is it just

Re: [dpdk-dev] Encountering ninja test failures?

2019-02-28 Thread Aaron Conole
David Marchand writes: > On Thu, Feb 28, 2019 at 10:31 PM Aaron Conole wrote: > > Greetings dev, > > I'm trying to test out the latest iteration of travis support, and as > part of that I've added the ability to execute tests. > > I can't seem to get the tests to execute correctly under trav

Re: [dpdk-dev] Encountering ninja test failures?

2019-02-28 Thread David Marchand
On Thu, Feb 28, 2019 at 10:31 PM Aaron Conole wrote: > Greetings dev, > > I'm trying to test out the latest iteration of travis support, and as > part of that I've added the ability to execute tests. > > I can't seem to get the tests to execute correctly under travis. The > build I have is here:

[dpdk-dev] Encountering ninja test failures?

2019-02-28 Thread Aaron Conole
Greetings dev, I'm trying to test out the latest iteration of travis support, and as part of that I've added the ability to execute tests. I can't seem to get the tests to execute correctly under travis. The build I have is here: https://travis-ci.org/orgcandman/dpdk/jobs/500014191 Based on

[dpdk-dev] [PATCH] app/testpmd: use mempool bulk get for txonly mode

2019-02-28 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Use mempool bulk get ops to alloc burst of packets and process them instead of calling pktalloc for every packet. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/txonly.c | 139 +- 1 file changed, 71 insertions(+), 68 deletions(-)

Re: [dpdk-dev] [PATCH v2 2/3] pipeline: add implementation for DSCP action

2019-02-28 Thread Dumitrescu, Cristian
> -Original Message- > From: Sheehan, Georgina > Sent: Sunday, February 11, 2018 1:29 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Sheehan, > Georgina > Subject: [PATCH v2 2/3] pipeline: add implementation for DSCP action According to DPDK conventions, the title should be: "examp

[dpdk-dev] [PATCH 6/6] ipsec: reorder packet check for esp inbound

2019-02-28 Thread Konstantin Ananyev
Right now check for packet length and padding is done inside cop_prepare(). It makes sense to have all necessary checks in one place at early stage: inside pkt_prepare(). That allows to simplify (and later hopefully) optimize cop_prepare() part. Signed-off-by: Konstantin Ananyev --- lib/librte_i

Re: [dpdk-dev] [PATCH v2 1/3] librte_pipeline: add support for DSCP action

2019-02-28 Thread Dumitrescu, Cristian
Hi Georgina, Thanks for your patch set and sorry for my delayed reply! > -Original Message- > From: Sheehan, Georgina > Sent: Sunday, February 11, 2018 1:29 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Sheehan, > Georgina > Subject: [PATCH v2 1/3] librte_pipeline: add support for D

[dpdk-dev] [PATCH 4/6] ipsec: change the way unprocessed mbufs are accounted

2019-02-28 Thread Konstantin Ananyev
As was pointed in one of previous reviews - we can avoid updating contents of mbuf array for successfully processed packets. Instead store indexes of failed packets, to move them beyond the good ones later. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 166 +++

[dpdk-dev] [PATCH 5/6] ipsec: move inbound and outbound code into different files

2019-02-28 Thread Konstantin Ananyev
sa.c becomes too big, so decided to split it into 3 chunks: - sa.c - control path related functions (init/fini, etc.) - esp_inb.c - ESP inbound packet processing - esp_outb.c - ESP outbound packet processing Plus few changes in internal function names to follow the same code convention. No func

[dpdk-dev] [PATCH 2/6] ipsec: add Tx offload template into SA

2019-02-28 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To avoid such negative effect, use tx_offload raw value and mask to update l2_len and l3_len fields within mbufs. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 23 ++- lib/l

[dpdk-dev] [PATCH 3/6] ipsec: change the order in filling crypto op

2019-02-28 Thread Konstantin Ananyev
Right now we first fill crypto_sym_op part of crypto_op, then in a separate cycle we fill crypto op fields. It makes more sense to fill whole crypto-op in one go instead. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/sa.c | 46 --- 1 file changed,

[dpdk-dev] [PATCH 0/6] Few small improvements for ipsec library

2019-02-28 Thread Konstantin Ananyev
The first patch in this series introduce new function to set raw value for rte_mbuf tx_offload. Remaining ones are cleanups and small performance improvements (on IA ~3-5% depending on the test-case) for ipsec library. Konstantin Ananyev (6): mbuf: new function to generate raw Tx offload value

[dpdk-dev] [PATCH 1/6] mbuf: new function to generate raw Tx offload value

2019-02-28 Thread Konstantin Ananyev
Operations to set/update bit-fields often cause compilers to generate suboptimal code. To help avoid such situation for tx_offload fields: introduce new enum for tx_offload bit-fields lengths and offsets, and new function to generate raw tx_offload value. Signed-off-by: Konstantin Ananyev --- li

Re: [dpdk-dev] [PATCH v2] lib/librte_meter: fix divide by zero for RFC4115 meter

2019-02-28 Thread Dumitrescu, Cristian
Hi Eelco, Sorry for my delayed reply, > -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Friday, February 1, 2019 4:07 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: [PATCH v2] lib/librte_meter: fix divide by zero for RFC4115 meter > > RFC 4115

[dpdk-dev] [PATCH] app/eventdev: configure optimum event timers per timer adapter

2019-02-28 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Previously, the total number of event timers per adapter was set to an arbitrary value, set it to mempool size instead as it defines the max event timers that can be armed. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 2 +- 1 file changed, 1 i

[dpdk-dev] [RFC 07/10] net/mlx5: switch to the shared Protection Domain

2019-02-28 Thread Viacheslav Ovsiienko
The PMD code is updated to use Protected Domain from the the shared IB device context. The Domain is shared between all devices belonging to the same multiport Infiniband device. If IB device has only one port, the PD is not shared, because there is only ethernet device created over IB one. Signed

[dpdk-dev] [RFC 10/10] net/mlx5: provide IB port for the object being created

2019-02-28 Thread Viacheslav Ovsiienko
The code is updated to provide IB port index for the Verbs objects being created - QP and Verbs Flows. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 2 ++ drivers/net/mlx5/mlx5_flow_verbs.c | 1 + drivers/net/mlx5/mlx5_txq.c| 4 ++-- 3 files changed, 5 inse

[dpdk-dev] [RFC 09/10] net/mlx5: switch to the shared IB device context

2019-02-28 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device context and device handles. The IB device context is shared between reprentors created over the single multiport IB device. All Verbs and DevX objects will be created whithin this shared context. Signed-off-by: Viacheslav Ovsiienko Conflicts:

[dpdk-dev] [RFC 06/10] net/mlx5: switch to the names in the shared IB context

2019-02-28 Thread Viacheslav Ovsiienko
The IB device names are moved from device private data to the shared context, code involving the names is updated. The IB port index treatment is added where it is relevant. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h| 2 -- drivers/net/mlx5/mlx5_ethdev.c | 10 ++

[dpdk-dev] [RFC 08/10] net/mlx5: switch to the shared context IB attributes

2019-02-28 Thread Viacheslav Ovsiienko
The code is updated to use the shared IB device attributes, located in the shared IB context. It saves some memory if there are representors created over the single Infiniband device with multuple ports. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c| 1 - drivers/net/m

[dpdk-dev] [RFC 05/10] net/mlx5: add IB shared context alloc/free functions

2019-02-28 Thread Viacheslav Ovsiienko
The functions to allocate and free shared IB context for multiport is added. The IB device context, Protection Domain, device attributes, Infiniband names are going to be relocated to the shared structure from the device private one. mlx5_dev_spawn() is updated to create shared context. Signed-off

[dpdk-dev] [RFC 03/10] net/mlx5: add getting IB ports number for multiport IB

2019-02-28 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_portnum() added to get the number of ports of multiport Infiniband device. It is assumed the Uplink/VF representors are attached on this ports. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_nl.c | 45

[dpdk-dev] [RFC 04/10] net/mlx5: add multiport IB device support to probing

2019-02-28 Thread Viacheslav Ovsiienko
mlx5_pci_probe() routine is refactored to probe the ports of found Infiniband devices. All active ports (with attached network interface), belonging to the same Infiniband device will use the signle shared Infiniband context of that device. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx

[dpdk-dev] [RFC 02/10] net/mlx5: modify get ifindex routine for multiport IB

2019-02-28 Thread Viacheslav Ovsiienko
There is the routine mlx5_nl_ifindex() returning the network interface index associated with Infiniband device. We are going to support multiport IB devices, now function takes the IB port as argument and returns ifindexassociated with tuple Signed-off-by: Viacheslav Ovsiienko --- drivers/net/m

[dpdk-dev] [RFC 00/10] net/mlx5: add support for multiport IB devices

2019-02-28 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implemen

[dpdk-dev] [RFC 01/10] net/mlx5: add multiport IB device port structure

2019-02-28 Thread Viacheslav Ovsiienko
The Mellanox NICs support SR-IOV and have E-Switch feature. When SR-IOV is set up in switchdev mode and E-Switch is enabled we have so called VF representors in the system. All representors belonging to the same E-Switch are created on the basis of the single PCI function and with current implement

[dpdk-dev] [PATCH v2] vhost: prevent disabled rings to be processed with zero-copy

2019-02-28 Thread Maxime Coquelin
The vhost-user spec says that once the vring is disabled, the client has to stop processing it. But it can happen when dequeue zero-copy is enabled if outstanding descriptors buffers are still being processed by an external NIC or another guest. The fix consists in draining the zmbufs list to ensu

Re: [dpdk-dev] [PATCH 0/5] no longer use RTE_LOGTYPE_PMD

2019-02-28 Thread Ferruh Yigit
On 2/28/2019 5:46 PM, Ferruh Yigit wrote: > On 2/26/2019 9:34 PM, Stephen Hemminger wrote: >> Almost all usages of RTE_LOGTYPE_PMD have been replaced by per >> driver log types in current version. This patch series fixes the >> few remaining stragglers to use local logging. >> >> Stephen Hemminger

Re: [dpdk-dev] [PATCH 0/5] no longer use RTE_LOGTYPE_PMD

2019-02-28 Thread Ferruh Yigit
On 2/26/2019 9:34 PM, Stephen Hemminger wrote: > Almost all usages of RTE_LOGTYPE_PMD have been replaced by per > driver log types in current version. This patch series fixes the > few remaining stragglers to use local logging. > > Stephen Hemminger (5): > eal: drop unused RTE_PROC_PRIMARY_OR ma

Re: [dpdk-dev] [PATCH v8 6/6] build: use dependency for pcap and fallback to find_library

2019-02-28 Thread Bruce Richardson
On Wed, Feb 27, 2019 at 01:53:32PM +, Bruce Richardson wrote: > On Wed, Feb 27, 2019 at 12:03:48PM +, Luca Boccassi wrote: > > On Wed, 2019-02-27 at 11:56 +0100, Thomas Monjalon wrote: > > > 27/02/2019 11:50, Luca Boccassi: > > > > On Wed, 2019-02-27 at 09:47 +, Bruce Richardson wrote:

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Stephen Hemminger
On Thu, 28 Feb 2019 15:49:28 + Raslan Darawsheh wrote: > + eth_dev->rx_pkt_burst = (eth_rx_burst_t)&failsafe_rx_burst; > + eth_dev->tx_pkt_burst = (eth_tx_burst_t)&failsafe_tx_burst; Why is cast necessary here. The function signature should match.

Re: [dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Stephen Hemminger
On Thu, 28 Feb 2019 15:49:28 + Raslan Darawsheh wrote: > > static int > +devargs_already_listed(struct rte_devargs *devargs) Why not make this function bool? static bool devargs_already_listed(...)

Re: [dpdk-dev] [PATCH 3/4] net/failsafe: replace local sub-device with shared data

2019-02-28 Thread Stephen Hemminger
On Thu, 28 Feb 2019 15:49:27 + Raslan Darawsheh wrote: > > /* sdev: (struct sub_device *) */ > #define ETH(sdev) \ > - ((sdev)->edev) > + (sdev->data == NULL ? NULL : &rte_eth_devices[sdev->data->port_id]) Macro arguments should always be parenthesised and you can shorten by usin

Re: [dpdk-dev] [PATCH 2/4] net/failsafe: change back-reference from sub-device

2019-02-28 Thread Stephen Hemminger
On Thu, 28 Feb 2019 15:49:26 + Raslan Darawsheh wrote: > +/* sdev: (struct sub_device *) */ > +#define FSDEV_FROM_SUBDEV(sdev) \ > + (&rte_eth_devices[sdev->fs_port_id]) If at all possible, inline functions are preferable to macros because inline functions don't allow side effects and ke

[dpdk-dev] [PATCH 0/3] Add XTS support for Intel QuickAssist Technology

2019-02-28 Thread Damian Nowak
This patchset adds XTS support for Intel QuickAssist Technology. Following cipher algorithms are available with this patchset: * AES XTS (128) * AES XTS (256) Damian Nowak (3): test/crypto: add tests for XTS on QAT crypto/qat: add XTS for QAT session config cryptodev: remove XTS

Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend

2019-02-28 Thread Maxime Coquelin
On 2/28/19 4:31 PM, Maxime Coquelin wrote: + handled = false; if (dev->extern_ops.pre_msg_handle) { ret = (*dev->extern_ops.pre_msg_handle)(dev->vid, - (void *)&msg, &skip_master); - if (ret == RTE_VHOST_MSG_RESULT_ERR)

Re: [dpdk-dev] [RFC] net/mlx5: support new naming scheme for representors

2019-02-28 Thread Rami Rosen
Hi, Dekel, It seems that the link to the patch in your post is broken. Regards, Rami Rosen בתאריך יום ה׳, 28 בפבר׳ 2019, 12:04, מאת Dekel Peled ‏: > In current kernel implementation, the physical port name for representors > is a numeric string (i.e. '0', '1', etc.). > > Kernel patch [1] implem

[dpdk-dev] [PATCH 4/4] crypto/qat: add modular multiplicative inverse to qat asym pmd

2019-02-28 Thread Arek Kusztal
This commit adds modular multiplicative inverse to Intel QuickAssist Technology driver. For capabilities or limitations refer to qat.rst or qat_asym_capabilities.h. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 + drivers/crypto/qat/qat_asym.c | 61

[dpdk-dev] [PATCH 3/4] crypto/qat: add modular exponentiation to qat asym pmd

2019-02-28 Thread Arek Kusztal
This commit adds modular exponentiation to Intel QuickAssist Technology driver. For capabilities or limitations refer to qat.rst or qat_asym_capabilities.h. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 2 + drivers/crypto/qat/qat_asym.c | 117 +

[dpdk-dev] [PATCH 2/4] crypto/qat: add asymmetric cryptography PMD

2019-02-28 Thread Arek Kusztal
This patch adds Poll Mode Driver for asymmetric crypto functions of Intel QuickAssist Technology hardware. It contains plain driver with no functions implmented, specific algorithms will be introduced in separate patches. This patch depends on a QAT PF driver for device initialization. See the fi

[dpdk-dev] [PATCH 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices

2019-02-28 Thread Arek Kusztal
This patchset adds Poll Mode Driver to use asymmetric cryptography functions using Intel QuickAssist Techology devices. Following functions are available with this patchset: * Modular Exponentiation * Modular Inverse This patch depends on a QAT PF driver for device initialization. See

[dpdk-dev] [PATCH 1/4] common/qat: add headers for asymmetric crypto

2019-02-28 Thread Arek Kusztal
This commit adds headers to be used in conjunction with asymmetric cryptography operations using Intel QuickAssist Technology driver Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_adf/icp_qat_fw_mmp_ids.h| 1538 drivers/common/qat/qat_adf/icp_qat_fw_pke.h

Re: [dpdk-dev] [PATCH 1/4] net/failsafe: replace local device with shared data

2019-02-28 Thread Thomas Monjalon
28/02/2019 16:49, Raslan Darawsheh: > In multiprocess context, the private structure is shared between > processes. The back reference from private to generic data was using > a pointer to a per process eth_dev. It's now changed to a reference of > the shared data. > > Signed-off-by: Raslan Daraws

[dpdk-dev] [PATCH 3/3] cryptodev: remove XTS text duplication

2019-02-28 Thread Damian Nowak
This patch removes duplicated text about AES-XTS mode. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h index eb5afc5..

[dpdk-dev] [PATCH 2/3] crypto/qat: add XTS for QAT session config

2019-02-28 Thread Damian Nowak
This patch adds XTS capabilities and enables XTS cipher mode on QAT. It also updates the documentation for newly supported AES XTS mode on QAT. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/features/qat.ini| 2 ++ doc/guides/cryptodevs/qat.rst | 3 ++- drivers/crypto/qa

[dpdk-dev] [PATCH 1/3] test/crypto: add tests for XTS on QAT

2019-02-28 Thread Damian Nowak
This patch adds test vectors for AES XTS mode on QAT. It uses different plaintext sizes and AES keys sizes of 128 and 256 bits. Signed-off-by: Damian Nowak --- test/test/test_cryptodev_aes_test_vectors.h | 223 +++- 1 file changed, 222 insertions(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH 0/3] Add XTS support for Intel QuickAssist Technology

2019-02-28 Thread Damian Nowak
This patchset adds XTS support for Intel QuickAssist Technology. Following cipher algorithms are available with this patchset: * AES XTS (128) * AES XTS (256) Damian Nowak (3): test/crypto: add tests for XTS on QAT crypto/qat: add XTS for QAT session config cryptodev: remove XTS

[dpdk-dev] [PATCH 4/4] net/failsafe: support secondary process

2019-02-28 Thread Raslan Darawsheh
Add implementation for probe in secondary. Failsafe will attempt to attach all the sub-devices in secondary process. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- drivers/net/failsafe/failsafe.c | 43 - 1 file changed, 42 insertions(

[dpdk-dev] [PATCH 3/4] net/failsafe: replace local sub-device with shared data

2019-02-28 Thread Raslan Darawsheh
In multiprocess context, the pointer to sub-device is shared between processes. Previously, it was a pointer to per process eth_dev so it's needed to replace this dependency. Signed-off-by: Thomas Monjalon Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c | 2 +- driv

[dpdk-dev] [PATCH 2/4] net/failsafe: change back-reference from sub-device

2019-02-28 Thread Raslan Darawsheh
In multiprocess context, the sub-device structure is shared between processes. The reference to the failsafe device was a per process pointer. It's changed to port id which is the same for all processes. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- drivers/net/failsafe/fai

[dpdk-dev] [PATCH 1/4] net/failsafe: replace local device with shared data

2019-02-28 Thread Raslan Darawsheh
In multiprocess context, the private structure is shared between processes. The back reference from private to generic data was using a pointer to a per process eth_dev. It's now changed to a reference of the shared data. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- driver

[dpdk-dev] [PATCH 0/4] support secondary process for failsafe

2019-02-28 Thread Raslan Darawsheh
this set of patches are intended to support secondary process for failsafe. Raslan Darawsheh (4): net/failsafe: replace local device with shared data net/failsafe: change back-reference from sub-device net/failsafe: replace local sub-device with shared data net/failsafe: support secondary

[dpdk-dev] [PATCH 0/2] dpdk-draft-windows X710-DA2 compatibility

2019-02-28 Thread Martin Birks
An effort was made to get dpdk working on Windows Server 2019 with an X710-DA2 card. This required the minimal changes as in the patches Martin Birks (2): kernel/windows: Added support for X710-DA2 to inf file. kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that SDDL string

[dpdk-dev] [PATCH 1/2] kernel/windows: Added support for X710-DA2 to inf file.

2019-02-28 Thread Martin Birks
Signed-off-by: Martin Birks --- kernel/windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/windows/netuio/netuio.inf b/kernel/windows/netuio/netuio.inf index 0453b371a..cf7c71345 100644 --- a/kernel/windows/netuio/netuio.inf +++ b/kernel/windows/netuio/netuio.in

[dpdk-dev] [PATCH 2/2] kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that SDDL string can be set successfully. Fixes: 9087d5ff8375 ("doc: change the Windows UIO driver's default securi

2019-02-28 Thread Martin Birks
Signed-off-by: Martin Birks --- kernel/windows/netuio/netuio_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/windows/netuio/netuio_dev.c b/kernel/windows/netuio/netuio_dev.c index f5d41cb65..1f01e2324 100644 --- a/kernel/windows/netuio/netuio_dev.c +++ b/kernel/windows/netuio

[dpdk-dev] [PATCH 2/2] kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that SDDL string can be set successfully. Fixes: 9087d5ff8375 ("doc: change the Windows UIO driver's default securi

2019-02-28 Thread Martin Birks
--- kernel/windows/netuio/netuio_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/windows/netuio/netuio_dev.c b/kernel/windows/netuio/netuio_dev.c index f5d41cb65..1f01e2324 100644 --- a/kernel/windows/netuio/netuio_dev.c +++ b/kernel/windows/netuio/netuio_dev.c @@ -33,6 +33,9

[dpdk-dev] [PATCH 1/2] kernel/windows: Added support for X710-DA2 to inf file.

2019-02-28 Thread Martin Birks
--- kernel/windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/windows/netuio/netuio.inf b/kernel/windows/netuio/netuio.inf index 0453b371a..cf7c71345 100644 --- a/kernel/windows/netuio/netuio.inf +++ b/kernel/windows/netuio/netuio.inf @@ -55,6 +55,7 @@ DriverVer

[dpdk-dev] [PATCH 0/2] *** dpdk-draft-windows X710-DA2 compatibility ***

2019-02-28 Thread Martin Birks
*** An effort was made to get dpdk working on Windows Server 2019 with an X710-DA2 card. This required the minimal changes as in the patches. *** Martin Birks (2): kernel/windows: Added support for X710-DA2 to inf file. kernel/windows: set FILE_AUTOGENERATED_DEVICE_NAME to true so that SD

[dpdk-dev] [RFC v2 0/2] vhost: Support external backend only vhost-user requests

2019-02-28 Thread Maxime Coquelin
The goals of this series is to provide more flexibility to external backends to implement their specific vhost-user request handling without having to patch vhost-user library. First patch implements a new API for external backend to advertize its specific protocol features to vhost-user master.

[dpdk-dev] [RFC v2 1/2] vhost: add API to set protocol features flags

2019-02-28 Thread Maxime Coquelin
rte_vhost_driver_set_protocol_features API is to be used by external backends to advertize vhost-user protocol features it supports. It has to be called after rte_vhost_driver_register() and before rte_vhost_driver_start(). Example of usage to advertize VHOST_USER_PROTOCOL_F_FOOBAR protocol featu

[dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend

2019-02-28 Thread Maxime Coquelin
External backends may have specific requests to handle, and so we don't want the vhost-user lib to handle these requests as errors. This patch also changes the experimental API by introducing RTE_VHOST_MSG_RESULT_NOT_HANDLED so that vhost-user lib can report an error if a message is handled neithe

[dpdk-dev] [PATCH] net/mlx5: support new representors' naming format

2019-02-28 Thread Dekel Peled
Kernel update [1] introduce new format of representors names. This patch updates MLX5 PMD to support the new format, while maintaining support of the existing format. [1] upstream kernel commit c12ecc230564 "net/mlx5e: Move to use common phys port names for vport representors" http://l-gerrit.mtl.

[dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx completions

2019-02-28 Thread Dekel Peled
Function mlx5_tx_complete() reads completion entry information from Tx queue. For some processors not having strongly-ordered memory model, there has to be a memory barrier between reading the entry index and the entry fields, in order to guarantee data is valid. Fixes: 54d3fe948dba ("net/mlx5: po

[dpdk-dev] [PATCH] net/mlx5: fix hex dump of error CQE

2019-02-28 Thread Dekel Peled
struct mlx5_cqe is defined in MLX5 PMD code (mlx5_prm.h). It includes 64 bytes padding in case of (RTE_CACHE_LINE_SIZE == 128). struct mlx5_err_cqe is defined in kernel, and doesn't include padding. When running in debug mode, in case an error CQE is detected it is printed using rte_hexdump(). T

Re: [dpdk-dev] [PATCH v2] net/sfc: do not use PMD logtype

2019-02-28 Thread Andrew Rybchenko
On 2/27/19 7:08 PM, Ferruh Yigit wrote: From: Stephen Hemminger The sfc driver was still using RTE_LOGTYPE_PMD which was superseded by local logging. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 3/6] bus: introduce device level DMA memory mapping

2019-02-28 Thread Burakov, Anatoly
On 28-Feb-19 12:14 PM, Burakov, Anatoly wrote: On 21-Feb-19 2:50 PM, Shahaf Shuler wrote: The DPDK APIs expose 3 different modes to work with memory used for DMA: 1. Use the DPDK owned memory (backed by the DPDK provided hugepages). This memory is allocated by the DPDK libraries, included in th

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-28 Thread Trahe, Fiona
Hi Akhil, Anoob, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, February 28, 2019 10:20 AM > To: Anoob Joseph ; Trahe, Fiona ; > Doherty, Declan > ; De Lara Guarch, Pablo > ; Yigit, Ferruh > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Nar

  1   2   >