Re: [dpdk-dev] [PATCH] power: fix sprintf with snprintf

2019-02-08 Thread Aaron Conole
Pallantla Poornima writes: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 450f079131 ("power: add traffic pattern aware power control") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima > --- > lib/librte_

Re: [dpdk-dev] [PATCH] test/eventdev: fix sprintf with snprintf

2019-02-08 Thread Aaron Conole
Pallantla Poornima writes: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 2a9c83ae3b ("test/eventdev: add multi-ports test") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima > --- > test/test/test_event_e

Re: [dpdk-dev] [PATCH] vhost: remove available ring relay helper

2019-02-08 Thread Maxime Coquelin
On 1/23/19 2:02 PM, Xiao Wang wrote: We don't need to relay available ring and check the desc, vdpa device can access the available ring in the guest directly. With this patch, we can achieve better throughput and lower CPU usage. Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c

Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration

2019-02-08 Thread Maxime Coquelin
On 1/23/19 6:29 PM, Rami Rosen wrote: This minor cleanup patch removes an unecessary forward declaration of virtio_intr_enable() in net/virtio PMD. Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO") Cc: sta...@dpdk.org Signed-off-by: Rami Rosen --- drivers/net/virtio/virtio_eth

Re: [dpdk-dev] [PATCH v5] net/virtio: set offload flag for jumbo frames

2019-02-08 Thread Maxime Coquelin
On 2/5/19 12:17 PM, Jens Freimann wrote: Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. The .dev_infos_get callback can be called before the configure callback. At that ti

Re: [dpdk-dev] [PATCH v3] vhost: add external message handling callbacks to the public API

2019-02-08 Thread Maxime Coquelin
On 1/17/19 4:32 PM, Darek Stojaczyk wrote: External message callbacks are used e.g. by vhost crypto to parse crypto-specific vhost-user messages. We are now publishing the API to register those callbacks, so that other backends outside of DPDK can use them as well. Signed-off-by: Darek Stoja

Re: [dpdk-dev] [PATCH 0/3] net/virtio: missing/wrong read barriers.

2019-02-08 Thread Maxime Coquelin
On 1/24/19 5:58 PM, Ilya Maximets wrote: Ilya Maximets (3): net/virtio: fix improper read barriers on packed Tx cleanup net/virtio: add barriers for extra descriptors on Rx split net/virtio: add missing read barrier for packed dequeue drivers/net/virtio/virtio_rxtx.c | 6 -- 1

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Stephen Hemminger
On Fri, 08 Feb 2019 12:04:22 -0500 Aaron Conole wrote: > Pallantla Poornima writes: > > > sprintf function is not secure as it doesn't check the length of string. > > More secure function snprintf is used. > > > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > > Cc: sta...@dp

Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary forward declaration

2019-02-08 Thread Maxime Coquelin
On 1/23/19 6:29 PM, Rami Rosen wrote: This minor cleanup patch removes an unecessary forward s/unecessary/unnecessary/ declaration of virtio_intr_enable() in net/virtio PMD. Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO") Cc: sta...@dpdk.org Signed-off-by: Rami Rosen ---

Re: [dpdk-dev] [PATCH] vhost: remove available ring relay helper

2019-02-08 Thread Maxime Coquelin
On 1/23/19 2:02 PM, Xiao Wang wrote: We don't need to relay available ring and check the desc, vdpa device can access the available ring in the guest directly. With this patch, we can achieve better throughput and lower CPU usage. Signed-off-by: Xiao Wang --- drivers/net/ifc/ifcvf_vdpa.c

Re: [dpdk-dev] [PATCH v3] compat: merge compat library into EAL

2019-02-08 Thread Bruce Richardson
On Fri, Feb 08, 2019 at 11:55:09AM -0500, Neil Horman wrote: > On Fri, Feb 08, 2019 at 04:18:38PM +, Bruce Richardson wrote: > > On Fri, Feb 08, 2019 at 10:37:40AM -0500, Neil Horman wrote: > > > On Thu, Feb 07, 2019 at 03:03:28PM +, Bruce Richardson wrote: > > > > On Thu, Feb 07, 2019 at 0

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Aaron Conole
Pallantla Poornima writes: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima > --- > test/test/comman

Re: [dpdk-dev] [PATCH v3] compat: merge compat library into EAL

2019-02-08 Thread Neil Horman
On Fri, Feb 08, 2019 at 04:18:38PM +, Bruce Richardson wrote: > On Fri, Feb 08, 2019 at 10:37:40AM -0500, Neil Horman wrote: > > On Thu, Feb 07, 2019 at 03:03:28PM +, Bruce Richardson wrote: > > > On Thu, Feb 07, 2019 at 09:34:26AM -0500, Neil Horman wrote: > > > > On Wed, Feb 06, 2019 at 0

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Stephen Hemminger
On Fri, 8 Feb 2019 13:27:37 + Pallantla Poornima wrote: > diff --git a/test/test/commands.c b/test/test/commands.c > index 94fbc310e..5aeb35498 100644 > --- a/test/test/commands.c > +++ b/test/test/commands.c > @@ -367,6 +367,8 @@ int commands_init(void) > struct test_command *t; >

Re: [dpdk-dev] [PATCH v3] compat: merge compat library into EAL

2019-02-08 Thread Bruce Richardson
On Fri, Feb 08, 2019 at 10:37:40AM -0500, Neil Horman wrote: > On Thu, Feb 07, 2019 at 03:03:28PM +, Bruce Richardson wrote: > > On Thu, Feb 07, 2019 at 09:34:26AM -0500, Neil Horman wrote: > > > On Wed, Feb 06, 2019 at 02:17:45PM +, Bruce Richardson wrote: > > > > On Wed, Feb 06, 2019 at 0

Re: [dpdk-dev] [PATCH v3] compat: merge compat library into EAL

2019-02-08 Thread Neil Horman
On Thu, Feb 07, 2019 at 03:03:28PM +, Bruce Richardson wrote: > On Thu, Feb 07, 2019 at 09:34:26AM -0500, Neil Horman wrote: > > On Wed, Feb 06, 2019 at 02:17:45PM +, Bruce Richardson wrote: > > > On Wed, Feb 06, 2019 at 07:22:54AM -0500, Neil Horman wrote: > > > > On Wed, Feb 06, 2019 at 1

Re: [dpdk-dev] [PATCH] service: fix parameter type

2019-02-08 Thread Ferruh Yigit
On 1/21/2019 11:43 AM, Van Haaren, Harry wrote: >> -Original Message- >> From: Rao, Nikhil >> Sent: Saturday, January 19, 2019 2:01 PM >> To: Van Haaren, Harry >> Cc: dev@dpdk.org; Rao, Nikhil >> Subject: [PATCH] service: fix parameter type >> >> The type of value parameter to rte_service

Re: [dpdk-dev] [dpdk-stable] v17.11.5-rc2 patches review and test

2019-02-08 Thread Yongseok Koh
Hi, all 17.11.5 is so much delayed and according to Intel, their verification for 17.11.5 would be done in late Feb. As I got okay from Mellanox and RedHat, I'd like to release it without more test results. As 19.02 has already been released, I should work on 17.11.6 right now. Given that, vendor

Re: [dpdk-dev] [PATCH v6 5/5] build: use integers for numerical options

2019-02-08 Thread Bruce Richardson
On Wed, Feb 06, 2019 at 05:08:48PM +, Luca Boccassi wrote: > Now that the minimum Meson version has been bumped past 0.45 we can use > integer as an option type directly. > > Signed-off-by: Luca Boccassi > --- > v6: added following Bruce's suggestion > Since I suggested it, I naturally think

Re: [dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf

2019-02-08 Thread Ferruh Yigit
On 2/4/2019 7:15 AM, Pallantla Poornima wrote: > @@ -825,7 +825,7 @@ > > test_bbdev_driver_init(void) > > TEST_ASSERT_FAIL(rte_bbdev_release(NULL), > "Failed to uninitialize bbdev driver with NULL bbdev"); > - sprintf(name_tmp, "%s", "invalid_name"); > + snprintf(name_tmp, sizeof(name_tmp), "%s"

Re: [dpdk-dev] [PATCH] vhost: fix deadlock when vhost unregister

2019-02-08 Thread Maxime Coquelin
On 1/28/19 7:55 AM, sunwenjie wrote: When rte_vhost_driver_unregister delete the connection fd, fdset_try_del will always try and donot release the vhostuser.mutex if the fd is busy, but the fdset_event_dispatch will set the fd to busy and call vhost_user_msg_handler to get vhostuser.mutex,

Re: [dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Bruce Richardson
On Fri, Feb 08, 2019 at 01:27:37PM +, Pallantla Poornima wrote: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf is used. > > Fixes: 727909c592 ("app/test: introduce dynamic commands list") > Cc: sta...@dpdk.org > > Signed-off-by: Pall

[dpdk-dev] [PATCH] test: fix sprintf with snprintf

2019-02-08 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf is used. Fixes: 727909c592 ("app/test: introduce dynamic commands list") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima --- test/test/commands.c | 7 ++- 1 file changed, 6 insertion

Re: [dpdk-dev] [PATCH 00/38] net/sfc: update base driver

2019-02-08 Thread Ferruh Yigit
On 2/7/2019 4:29 PM, Andrew Rybchenko wrote: > Update Solarflare libefx and make related changes in the PMD itself. > > Andrew Lee (1): > net/sfc/base: add Rx parse incomplete event queue statistic > > Andrew Rybchenko (9): > net/sfc/base: update auto-generated MCDI definition headers > net

Re: [dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

2019-02-08 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, February 8, 2019 11:14 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shally.ve...@caviumnetworks.com; > Kusztal, ArkadiuszX > Subject: [PATCH v2 0/3] crypotodev: add result field to modular operations

Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

2019-02-08 Thread Medvedkin, Vladimir
Hi Yipeng, Yes, I agree with you point. So keep me in mind if you decide to split hash table and functions someday :) Thomas, I think this patch could be rejected. Thanks! -Original Message- From: Wang, Yipeng1 Sent: Thursday, February 7, 2019 11:14 PM To: Gobriel, Sameh ; Thomas Monj

[dpdk-dev] [PATCH] doc: add cryptodev xform deprecation notice

2019-02-08 Thread Fan Zhang
This patch adds the deprecation notice of changing Cryptodev symmetric xform structure for DPDK 19.05. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecat

[dpdk-dev] [PATCH v2 3/3] test: add result field to mod exp and mod inv

2019-02-08 Thread Arek Kusztal
This patch adds result field to modular exponentiation and modular multiplicative inverse tests Signed-off-by: Arek Kusztal --- test/test/test_cryptodev_asym.c | 6 ++ test/test/test_cryptodev_asym_util.h | 8 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/test

[dpdk-dev] [PATCH v2 2/3] openssl: add result field to mod exp and mod inv operations

2019-02-08 Thread Arek Kusztal
This patch adds result field to modular exponentiation and modular multiplicative inverse operations in openssl pmd functions Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rt

[dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

2019-02-08 Thread Arek Kusztal
This commit adds result field to be used when modular exponentiation or modular multiplicative inverse operation is used Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/librte_cryptodev/rte_crypto_asym.h

[dpdk-dev] [PATCH v2 0/3] crypotodev: add result field to modular operations

2019-02-08 Thread Arek Kusztal
This patchset adds result field to modular exponentiation and modular inverse operations This patchset depends on following patches: [1] - "[v3] cryptodev: rework mod exp and mod inv comments" (http://patchwork.dpdk.org/patch/50139/) [2] - "openssl: fix bad reference of modinv" (http://patchwork.

Re: [dpdk-dev] [PATCH 01/30] net/sfc: log port ID as 16-bit unsigned integer on panic

2019-02-08 Thread Andrew Rybchenko
Hi Ferruh, On 2/8/19 1:13 PM, Ferruh Yigit wrote: On 2/7/2019 12:17 PM, Andrew Rybchenko wrote: From: Ivan Malov Fixes: f8244c6399d9 ("ethdev: increase port id range") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_debug.h | 3 ++-

Re: [dpdk-dev] [PATCH 01/30] net/sfc: log port ID as 16-bit unsigned integer on panic

2019-02-08 Thread Ferruh Yigit
On 2/7/2019 12:17 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > drivers/net/sfc/sfc_debug.h | 3 ++- > 1 file changed, 2 insertions(+), 1 d

Re: [dpdk-dev] [PATCH v5] net/virtio: set offload flag for jumbo frames

2019-02-08 Thread Maxime Coquelin
On 2/5/19 12:17 PM, Jens Freimann wrote: Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. The .dev_infos_get callback can be called before the configure callback. At that ti

Re: [dpdk-dev] [PATCH v5 2/2] doc: add guide for debug and troubleshoot

2019-02-08 Thread Varghese, Vipin
Hi Thomas, John and Marko, I am working on sharing the next version with grammar checks done with Grammarly. Will update ASAP. Thanks Vipin Varghese > -Original Message- > From: Thomas Monjalon > Sent: Monday, January 28, 2019 9:30 PM > To: Varghese, Vipin > Cc: Mcnamara, John ; Kovac

Re: [dpdk-dev] [dpdk-web] Ideas page

2019-02-08 Thread Maxime Coquelin
On 2/6/19 12:57 AM, Stephen Hemminger wrote: Google Summer of Code wants an Ideas List web page. That seems like a good idea to have anyway. I just posted a patch to w...@dpdk.org adding a section in the roadmap page for internship topics. Regards, Maxime

Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt

2019-02-08 Thread Ayuj Verma
Hi Pablo,Fiona Did you get a chance to look into these. Thanks and regards Ayuj Verma From: Ayuj Verma Sent: 06 February 2019 16:46:17 To: pablo.de.lara.gua...@intel.com Cc: fiona.tr...@intel.com; dev@dpdk.org; Shally Verma; Sunila Sahu; Kanaka Durga Kotamar

[dpdk-dev] [PATCH 3/3] test: add result field to mod exp and mod inv

2019-02-08 Thread Arek Kusztal
This patch adds result field to modular exponentiation and modular multiplicative inverse tests Signed-off-by: Arek Kusztal --- test/test/test_cryptodev_asym.c | 6 ++ test/test/test_cryptodev_asym_util.h | 8 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/test

[dpdk-dev] [PATCH 2/3] openssl: add result field to mod exp and mod inv operations

2019-02-08 Thread Arek Kusztal
This patch adds result field to modular exponentiation and modular multiplicative inverse operations in openssl pmd functions Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rt

[dpdk-dev] [PATCH 0/3] crypotodev: add result field to modular operations

2019-02-08 Thread Arek Kusztal
This patchset adds result field to modular exponentiation and modular inverse operations This patchset depends on following patches: [1] - "[v3] cryptodev: rework mod exp and mod inv comments" (http://patchwork.dpdk.org/patch/50139/) [2] - "openssl: fix bad reference of modinv" (http://patchwork.

[dpdk-dev] [PATCH 1/3] cryptodev: add result field to mod exp and inverse operations

2019-02-08 Thread Arek Kusztal
This commit adds result field to be used when modular exponentiation or modular multiplicative inverse operation is used This patch depends on "cryptodev: rework mod exp and mod inv comments" (http://patchwork.dpdk.org/patch/50132/) Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypt