On 2/7/2019 12:17 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.ma...@oktetlabs.ru>
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.ma...@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
> ---
> drivers/net/sfc/sfc_debug.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
> index 6b600ff4d..62f3937e8 100644
> --- a/drivers/net/sfc/sfc_debug.h
> +++ b/drivers/net/sfc/sfc_debug.h
> @@ -27,7 +27,8 @@
> do { \
> const struct sfc_adapter *_sa = (sa); \
> \
> - rte_panic("sfc " PCI_PRI_FMT " #%" PRIu8 ": " fmt "\n", \
> + rte_panic("sfc " PCI_PRI_FMT \
> + " #%" PRIu16 ": " fmt "\n", \
> _sa->pci_addr.domain, _sa->pci_addr.bus, \
> _sa->pci_addr.devid, _sa->pci_addr.function, \
> _sa->port_id, ##args); \
>
Overall it may not be good idea to call rte_panic() from driver. rte_panic()
cause the DPDK application to terminate, if a driver fails application may
prefer to handle that error and continue to run, so terminate decision should be
from application not library.
Can you please double check if rte_panic() usages in the driver can be converted
to error reporting?
