Re: [dpdk-dev] [EXT] [PATCH] openssl: fix bad reference of modinv

2019-02-05 Thread Shally Verma
>-Original Message- >From: dev On Behalf Of Arek Kusztal >Sent: 05 February 2019 14:43 >To: dev@dpdk.org >Cc: sunila.s...@caviumnetworks.com; akhil.go...@nxp.com; >shally.ve...@caviumnetworks.com; >ashish.gu...@caviumnetworks.com; Arek Kusztal >Subject: [EXT] [dpdk-dev] [PATCH] openss

Re: [dpdk-dev] [PATCH v2] cryptodev: rework mod exp and mod inv comments

2019-02-05 Thread Shally Verma
HI Arek, Acked with minor feedback. >-Original Message- >From: Arek Kusztal >Sent: 05 February 2019 23:50 >To: dev@dpdk.org >Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; >shally.ve...@caviumnetworks.com; sunila.s...@caviumnetworks.com; >ashish.gu...@caviumnetworks.com; umesh.kar...@c

[dpdk-dev] Ideas page

2019-02-05 Thread Stephen Hemminger
Google Summer of Code wants an Ideas List web page. That seems like a good idea to have anyway.

Re: [dpdk-dev] [PATCH] kni: fix rte_kni_update_link

2019-02-05 Thread Stephen Hemminger
On Thu, 24 Jan 2019 23:47:49 +0300 Igor Ryzhov wrote: > After read, file offset must be set to 0 before write. > Otherwise, the third byte will be overwritten instead of the first. > > Fixes: c6fd54f28c24 ("kni: add function to set link state on kernel > interface") > Cc: sta...@dpdk.org > > S

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Wiles, Keith
> On Feb 5, 2019, at 3:49 PM, Iain Barker wrote: > > >> >> Maybe I do not see the full problem here. If DPDK used poll instead of >> select it would solve the 1024 problem as poll has a high limit to the >> number of file descriptors at least that was my assumption. >>> > > Thanks Keith.

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Iain Barker
> > Maybe I do not see the full problem here. If DPDK used poll instead of select > it would solve the 1024 problem as poll has a high limit to the number of > file descriptors at least that was my assumption. >> Thanks Keith. The issue is not whether DPDK is using poll or select on the f

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Wiles, Keith
> On Feb 5, 2019, at 3:27 PM, Iain Barker wrote: > >> >> Would poll work here instead? > > Poll (or epoll) would definitely work - if we controlled the source and > compilation of all the libraries that the application links against. > > But an app doesn’t know how the libraries in the OS a

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Iain Barker
> > Would poll work here instead? Poll (or epoll) would definitely work - if we controlled the source and compilation of all the libraries that the application links against. But an app doesn’t know how the libraries in the OS are implemented. We’d have no way to ensure select() isn’t called b

Re: [dpdk-dev] [PATCH 1/2 v2] build: add option to override max ethports

2019-02-05 Thread Chas Williams
On 2/4/19 4:49 AM, Bruce Richardson wrote: On Thu, Jan 31, 2019 at 06:53:25PM -0500, Chas Williams wrote: Allow users and packagers to override the default RTE_MAX_ETHPORTS. This adds a new meson option, max_ethports which defaults to the current value. Actually in this v2, you have change

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Wiles, Keith
> On Feb 5, 2019, at 12:56 PM, Iain Barker wrote: > > Hi everyone, > > We just updated our application from DPDK 17.11.4 (LTS) to DPDK 18.11 (LTS) > and we noticed a regression. > > Our host platform is providing 2MB huge pages, so for 8GB reservation this > means 4000 pages are allocated.

[dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Iain Barker
Hi everyone, We just updated our application from DPDK 17.11.4 (LTS) to DPDK 18.11 (LTS) and we noticed a regression. Our host platform is providing 2MB huge pages, so for 8GB reservation this means 4000 pages are allocated. This worked fine in the prior LTS, but after upgrading DPDK what we a

[dpdk-dev] [PATCH v2] cryptodev: rework mod exp and mod inv comments

2019-02-05 Thread Arek Kusztal
This patch changes modular exponentiation and modular multiplicative inverse API comments to make it more precise. Signed-off-by: Arek Kusztal --- v2: - grammar fixes lib/librte_cryptodev/rte_crypto_asym.h | 44 ++ 1 file changed, 29 insertions(+), 15 deletions(-

Re: [dpdk-dev] [PATCH] openssl: fix bad reference of modinv

2019-02-05 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Arek Kusztal > Sent: Tuesday, February 5, 2019 9:13 AM > To: dev@dpdk.org > Cc: sunila.s...@caviumnetworks.com; akhil.go...@nxp.com; > shally.ve...@caviumnetworks.com; > ashish.gu...@caviumnetworks.com; Kusztal,

[dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash

2019-02-05 Thread Vladimir Medvedkin
Signed-off-by: Vladimir Medvedkin --- v2: - remove mail footer MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eef480a..81affda 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1131,6 +1131,9 @@ F: doc/guides/prog_guide/hash_lib.rst F: test/test/

[dpdk-dev] [PATCH v2] rte_thash: replace license text with SPDX tag

2019-02-05 Thread Vladimir Medvedkin
Signed-off-by: Vladimir Medvedkin --- v2: - remove mail footer lib/librte_hash/rte_thash.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h index a6ddb7b..1b33f48 100644 --- a/lib/libr

[dpdk-dev] [PATCH v2] maintainers: claim co-maintainership of LPM

2019-02-05 Thread Vladimir Medvedkin
Signed-off-by: Vladimir Medvedkin --- v2: - remove mail footer MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 835d8a2..eef480a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c LPM M: Bruce Ri

[dpdk-dev] [PATCH v3] net/bonding: fix create bonded device test failure

2019-02-05 Thread Hari Kumar Vemula
test_create_bonded_device is failing due to improper initialisation in bonded device configuration. Which leads to crash while setting up queues. The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of bonded device which fails. This is due to "rx_desc_lim" is set to 0 as defaul

Re: [dpdk-dev] [PATCH] cryptodev: rework mod exp and mod inv comments

2019-02-05 Thread Trahe, Fiona
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, February 5, 2019 11:13 AM > To: dev@dpdk.org > Cc: shally.ve...@caviumnetworks.com; sunila.s...@caviumnetworks.com; > ashish.gu...@caviumnetworks.com; umesh.kar...@caviumnetworks.com; Trahe, Fiona > ; akhil.go...@nx

[dpdk-dev] [PATCH v5] net/virtio: set offload flag for jumbo frames

2019-02-05 Thread Jens Freimann
Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. The .dev_infos_get callback can be called before the configure callback. At that time we don't know the maximum packet size yet b

[dpdk-dev] [PATCH] cryptodev: rework mod exp and mod inv comments

2019-02-05 Thread Arek Kusztal
This patch changes modular exponentiation and modular multiplicative inverse API comments to make it more precise. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 42 ++ 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/lib/l

[dpdk-dev] [PATCH] openssl: fix bad reference of modinv

2019-02-05 Thread Arek Kusztal
Fixes bad reference of modinv struct in openssl pmd Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations") Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/openssl/r

Re: [dpdk-dev] [PATCH v2] lib/librte_meter: fix divide by zero for RFC4115 meter

2019-02-05 Thread Jens Freimann
On Fri, Feb 01, 2019 at 04:07:16PM +, Eelco Chaudron wrote: RFC 4115 allows a meter with either cir and/or eir configured. When only one is configured a divide by zero would occur. Fixes: 655796d2b5fb ("meter: support RFC4115 trTCM") Cc: echau...@redhat.com Signed-off-by: Eelco Chaudron --