Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2019-01-11 Thread Verma, Shally
HI Pablo Sorry for delay in response. >-Original Message- >From: De Lara Guarch, Pablo >Sent: 11 January 2019 00:17 >To: Trahe, Fiona ; Verma, Shally >; Stephen Hemminger > >Cc: dev@dpdk.org; akhil.go...@nxp.com; Jozwiak, TomaszX >; Gupta, Ashish >; Daly, Lee ; Luse, Paul E >; Trahe,

Re: [dpdk-dev] [PATCH 3/4] net/enic: support multicast filtering

2019-01-11 Thread Hyong Youb Kim
On Fri, Jan 11, 2019 at 03:46:47PM +, Ferruh Yigit wrote: > On 12/10/2018 6:28 PM, Hyong Youb Kim wrote: > > The VIC hardware has 64 MAC filters per vNIC, which can be either > > unicast or multicast. Use one half for unicast and the other half for > > multicast, as the VIC kernel drivers for L

Re: [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function

2019-01-11 Thread Ye Xiaolong
On 01/11, Tiwei Bie wrote: >> vhost_user: remove statement for non-existed function > >s/vhost_user/vhost/ > >On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote: >> vhost_user_host_notifier_ctrl is not existed anymore, its statement in >> header file should be removed accordingly. >> >> F

Re: [dpdk-dev] TX unable to enqueue packets to NIC due to no free TX descriptor

2019-01-11 Thread Soni, Shivam
Hi Stephen, Thanks for the reply. Our mbuf pool is big enough. We have 2 RX cores, 2 TX cores and 8 worker cores. NTxd and NRxd is 1024 each and we have 16 Rx rings (shared between Rx and workers) and 8 Tx rings (between Tx and workers) Mempool cache size is 256 and burst size is 32. So overall

Re: [dpdk-dev] TX unable to enqueue packets to NIC due to no free TX descriptor

2019-01-11 Thread Stephen Hemminger
On Fri, 11 Jan 2019 22:10:39 + "Soni, Shivam" wrote: > Hi All, > > We are trying to debug and fix an issue. After the deployment, in few of the > hosts we see an issue where TX is unable to enqueue packets to NIC. On > rebouncing or restarting our packet processor daemon, issue gets resolv

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Luse, Paul E
Thanks Jim!! -from my iPhone > On Jan 11, 2019, at 11:37 AM, Wiles, Keith wrote: > > > >> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger >> wrote: >> >> If interface name is passed to remote or iface then check >> the length and for invalid characters. This avoids problems where >> name

Re: [dpdk-dev] [PATCH] mk: remove make target for examples

2019-01-11 Thread Thomas Monjalon
11/01/2019 23:01, Ferruh Yigit: > On 11/22/2016 11:49 AM, ferruh.yigit at intel.com (Ferruh Yigit) wrote: > > On 11/22/2016 9:38 AM, Thomas Monjalon wrote: > >> 2016-11-22 00:34, Ferruh Yigit: > >>> On 11/21/2016 11:47 PM, Thomas Monjalon wrote: > The command > make examples > work

[dpdk-dev] TX unable to enqueue packets to NIC due to no free TX descriptor

2019-01-11 Thread Soni, Shivam
Hi All, We are trying to debug and fix an issue. After the deployment, in few of the hosts we see an issue where TX is unable to enqueue packets to NIC. On rebouncing or restarting our packet processor daemon, issue gets resolved. We are using IntelDPDK version 17.11.4 and i40e drivers. On loo

Re: [dpdk-dev] [PATCH] mk: remove make target for examples

2019-01-11 Thread Ferruh Yigit
On 11/22/2016 11:49 AM, ferruh.yigit at intel.com (Ferruh Yigit) wrote: > On 11/22/2016 9:38 AM, Thomas Monjalon wrote: >> 2016-11-22 00:34, Ferruh Yigit: >>> On 11/21/2016 11:47 PM, Thomas Monjalon wrote: The command make examples works only if target directories have the exact na

Re: [dpdk-dev] [PATCH v3] mempool: Add sanity check when secondary link-in less mempools than primary

2019-01-11 Thread Ferruh Yigit
On 11/10/2016 11:25 PM, jt at labs.hpe.com (Jean Tourrilhes) wrote: > If the mempool ops the caller wants to use is not registered, the > library will segfault in an obscure way when trying to use that > mempool. It's better to catch it early and warn the user. > > If the primary and secondary pro

Re: [dpdk-dev] [PATCH] eal: avoid unnecessary conflicts over rte_config file

2019-01-11 Thread Ferruh Yigit
On 10/14/2016 5:27 PM, ouster at cs.stanford.edu (John Ousterhout) wrote: > It sounds like my patch would break some existing software, so it probably > doesn't make sense right now. > > I'd still argue that the current mechanism has a number of problems, and it > should probably undergo a compreh

Re: [dpdk-dev] [PATCH v3 2/4] build: use dependency() instead of find_library()

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 06:16:23PM +, Luca Boccassi wrote: > On Fri, 2019-01-11 at 17:21 +, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 04:26:06PM +, Luca Boccassi wrote: > > > Whenever possible (if the library ships a pkg-config file) use > > > meson's > > > dependency() functi

Re: [dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2019-01-11 Thread Ferruh Yigit
On 1/11/2019 5:51 PM, Thomas Monjalon wrote: > 11/01/2019 16:22, Ferruh Yigit: >> On 12/19/2018 9:20 PM, Thomas Monjalon wrote: >>> 19/12/2018 22:09, Ferruh Yigit: This patch is sitting on patchwork since 2015, I am updating it as rejected, if it is still relevant please let us know

[dpdk-dev] [Bug 187] Merge linux and bsd eal_thread.c which are same

2019-01-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=187 Bug ID: 187 Summary: Merge linux and bsd eal_thread.c which are same Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal

[dpdk-dev] [PATCH v2 4/7] net/tap: lower the priority of log messages

2019-01-11 Thread Stephen Hemminger
Any messages that normally occur during probe should be at DEBUG level (not NOTICE). This reduces overall log clutter. Signed-off-by: Stephen Hemminger Acked-by Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/tap

[dpdk-dev] [PATCH v2 5/7] net/tap: let kernel choose tun device name

2019-01-11 Thread Stephen Hemminger
Assigning tun and tap index in DPDK tap device driver is racy and fails if used with primary/secondary. Instead use the kernel feature of device wildcarding where if a name with %d is used the kernel will fill in the next available device. Reported-by: h...@netitest.com Fixes: 02f96a0a82d1 ("net/t

[dpdk-dev] [PATCH v2 6/7] net/tap: get rid of global tuntap_name

2019-01-11 Thread Stephen Hemminger
Having a global variable which is set to "TUN" or "TAP" during probe is a potential bug if probing is ever done in different processes or contexts. Let's fix it now by using existing enum that has type of connection. Signed-off-by: Stephen Hemminger Acked-by Keith Wiles --- drivers/net/tap/rte_

[dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message

2019-01-11 Thread Stephen Hemminger
Printing pointer in log is uninformative (unless in a debugger), instead print the assigned kernel device name which correlates well with what TAP is doing. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff -

[dpdk-dev] [PATCH v2 2/7] net/tap: allow full length names

2019-01-11 Thread Stephen Hemminger
The code for set_interface_name was incorrectly assuming that space for null byte was necessary with snprintf/strlcpy. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Signed-off-by: Stephen Hemminger Acked-by Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 6 +++--- 1 file changed, 3 in

[dpdk-dev] [PATCH v2 3/7] net/tap: check interface name in kvargs

2019-01-11 Thread Stephen Hemminger
If interface name is passed to remote or iface then check the length and for invalid characters. This avoids problems where name gets truncated or rejected by kernel. Signed-off-by: Stephen Hemminger Acked-by Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 38 +++

[dpdk-dev] [PATCH v2 1/7] net/tap: use strlcpy for interface name

2019-01-11 Thread Stephen Hemminger
snprintf is not needed here, use strlcpy instead. Signed-off-by: Stephen Hemminger Acked-by Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 0ec030bef63c..1c00681

[dpdk-dev] [PATCH v2 0/6] net/tap: fixes and cleanups

2019-01-11 Thread Stephen Hemminger
The tap device (used by vdev_netvsc on Azure) has a bug that prevents it working with primary/secondary process model because the device name generation assumed a single process. The fix for this is to have the kernel assign the device name (patch #5). While investigating this, found a number of

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-11 Thread Stephen Hemminger
On Fri, 11 Jan 2019 19:12:40 + "Eads, Gage" wrote: > > -Original Message- > > From: Burakov, Anatoly > > Sent: Friday, January 11, 2019 4:25 AM > > To: Eads, Gage ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > > ; Ananyev, Konstantin > >

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 1:49 PM, Stephen Hemminger > wrote: > > On Fri, 11 Jan 2019 19:37:00 + > "Wiles, Keith" wrote: > >>> +/* make sure name is a possible Linux network device name */ >>> +static bool is_valid_iface(const char *name) >> >> I am sorry, but the function name must be o

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Stephen Hemminger
On Fri, 11 Jan 2019 19:37:00 + "Wiles, Keith" wrote: > > +/* make sure name is a possible Linux network device name */ > > +static bool is_valid_iface(const char *name) > > I am sorry, but the function name must be on the next line as per the style. > I know you do not like it, but that i

Re: [dpdk-dev] [PATCH 2/6] net/tap: allow full length names

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 1:48 PM, Stephen Hemminger > wrote: > > On Fri, 11 Jan 2019 19:32:39 + > "Wiles, Keith" wrote: > >>> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger >>> wrote: >>> >>> The code for set_interface_name was incorrectly assuming that >>> space for null byte was nece

Re: [dpdk-dev] [PATCH 2/6] net/tap: allow full length names

2019-01-11 Thread Stephen Hemminger
On Fri, 11 Jan 2019 19:32:39 + "Wiles, Keith" wrote: > > On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > > wrote: > > > > The code for set_interface_name was incorrectly assuming that > > space for null byte was necessary with snprintf/strlcpy. > > > > Fixes: 02f96a0a82d1 ("net/tap: add

Re: [dpdk-dev] [PATCH 0/6] net/tap: fixes and cleanups

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > The tap device (used by vdev_netvsc on Azure) has a bug that > prevents it working with primary/secondary process model because > the device name generation assumed a single process. The fix for > this is to have the kernel assig

Re: [dpdk-dev] [PATCH 5/6] net/tap: let kernel choose tun device name

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > Assigning tun and tap index in DPDK tap device driver is racy and > fails if used with primary/secondary process model. Instead, use the > kernel feature of device wildcarding where if a name with %d is used > the kernel will fill

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > If interface name is passed to remote or iface then check > the length and for invalid characters. This avoids problems where > name gets truncated or rejected by kernel. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/

Re: [dpdk-dev] [PATCH 2/6] net/tap: allow full length names

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > The code for set_interface_name was incorrectly assuming that > space for null byte was necessary with snprintf/strlcpy. > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > Signed-off-by: Stephen Hemminger > --- > driv

Re: [dpdk-dev] [PATCH 6/6] doc: add NB ring comment to EAL "known issues"

2019-01-11 Thread Eads, Gage
> Hi Gage, > > Humble suggestion from my end, as per DPDK 19.02-rc1 the documentation and > code change have to be in same patch. Can you please take a look into it. > Certainly, and I'll fix this in my other docs change patch (http://mails.dpdk.org/archives/dev/2019-January/122926.html). Thank

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-11 Thread Eads, Gage
> -Original Message- > From: Richardson, Bruce > Sent: Friday, January 11, 2019 5:59 AM > To: Burakov, Anatoly > Cc: Eads, Gage ; dev@dpdk.org; > olivier.m...@6wind.com; arybche...@solarflare.com; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-11 Thread Eads, Gage
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, January 11, 2019 4:25 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-11 Thread Eads, Gage
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, January 10, 2019 10:39 PM > To: Eads, Gage > Cc: dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; > Richardson, Bruce ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/hash: reset iter and found in perf test

2019-01-11 Thread Wang, Yipeng1
Thanks for the bug fix! Nice catch! >-Original Message- >From: Yigit, Ferruh >Sent: Friday, January 11, 2019 9:10 AM >To: Dharmik Thakkar ; Richardson, Bruce >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; sta...@dpdk.org; Wang, Yipeng1 >Subject: Re: [dpdk-stable] [PATCH] test/hash: reset

[dpdk-dev] [PATCH v4 1/4] build: bump minimum Meson version to 0.47.1

2019-01-11 Thread Luca Boccassi
Meson 0.47.1 fixed a bug that is difficult to work around, which causes the linker flag of dependencies to be repeated dozens of times, which causes issues especially when using the built-in dependency() API. Bump the minimum version and remove obsolete version checks. Signed-off-by: Luca Boccassi

[dpdk-dev] [PATCH v4 4/4] build: use dependency() for libbsd instead of manual append to ldflags

2019-01-11 Thread Luca Boccassi
Move libbsd inclusion to librte_eal, so that all other libraries and PMDs will inherit it. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v3: only add dependency to librte_eal and let it propagate from there v4: add acked-by config/meson.build | 10 +- lib/librte_e

[dpdk-dev] [PATCH v4 2/4] build: use dependency() instead of find_library()

2019-01-11 Thread Luca Boccassi
Whenever possible (if the library ships a pkg-config file) use meson's dependency() function to look for it, as it will automatically add it to the Requires.private list if needed, to allow for static builds to succeed for reverse dependencies of DPDK. Otherwise the recursive dependencies are not p

[dpdk-dev] [PATCH v4 3/4] build: reorder libraries and build eal before cmdline

2019-01-11 Thread Luca Boccassi
Most libraries and PMDs depend on eal, and eal depends only on kvargs, so reorder the list in Meson to reflect this and take advantage of this dependency chain. Signed-off-by: Luca Boccassi Acked-by: Bruce Richardson --- v3: added this patch to let the next just update librte_eal instead of

Re: [dpdk-dev] [PATCH v3 2/4] build: use dependency() instead of find_library()

2019-01-11 Thread Luca Boccassi
On Fri, 2019-01-11 at 17:21 +, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 04:26:06PM +, Luca Boccassi wrote: > > Whenever possible (if the library ships a pkg-config file) use > > meson's > > dependency() function to look for it, as it will automatically add > > it > > to the Require

[dpdk-dev] [PATCH 6/6] net/tap: get rid of global tuntap_name

2019-01-11 Thread Stephen Hemminger
Having a global variable which is set to "TUN" or "TAP" during probe is a potential bug if probing is ever done in different processes or contexts. Let's fix it now by using existing enum that has type of connection. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 30 +++

[dpdk-dev] [PATCH 5/6] net/tap: let kernel choose tun device name

2019-01-11 Thread Stephen Hemminger
Assigning tun and tap index in DPDK tap device driver is racy and fails if used with primary/secondary process model. Instead, use the kernel feature of device wildcarding where if a name with %d is used the kernel will fill in the next available device. Reported-by: h...@netitest.com Fixes: 02f96

[dpdk-dev] [PATCH 4/6] net/tap: lower the priority of log messages

2019-01-11 Thread Stephen Hemminger
Any messages that normally occur during probe should be at DEBUG level (not NOTICE). This reduces overall log clutter. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drive

[dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Stephen Hemminger
If interface name is passed to remote or iface then check the length and for invalid characters. This avoids problems where name gets truncated or rejected by kernel. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 37 +++ 1 file changed, 33 i

[dpdk-dev] [PATCH 2/6] net/tap: allow full length names

2019-01-11 Thread Stephen Hemminger
The code for set_interface_name was incorrectly assuming that space for null byte was necessary with snprintf/strlcpy. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletio

[dpdk-dev] [PATCH 1/6] net/tap: use strlcpy for interface name

2019-01-11 Thread Stephen Hemminger
snprintf is not needed here, use strlcpy instead. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 0ec030bef63c..1c00681ba0eb 100644 --- a/dri

[dpdk-dev] [PATCH 0/6] net/tap: fixes and cleanups

2019-01-11 Thread Stephen Hemminger
The tap device (used by vdev_netvsc on Azure) has a bug that prevents it working with primary/secondary process model because the device name generation assumed a single process. The fix for this is to have the kernel assign the device name (patch #5). While investigating this, found a number of

[dpdk-dev] [PATCH v3] pdump: fix vdev cleanup

2019-01-11 Thread Reshma Pattan
Virtual devices added in pdump application using rte_eal_hotplug_add should be removed explicitly while existing the pdump application, otherwise the subsequent run of the pdump application will fail with the reason that virtual devices with the same name already exists in primary. Fixes: 6362f362

Re: [dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2019-01-11 Thread Thomas Monjalon
11/01/2019 16:22, Ferruh Yigit: > On 12/19/2018 9:20 PM, Thomas Monjalon wrote: > > 19/12/2018 22:09, Ferruh Yigit: > >> This patch is sitting on patchwork since 2015, I am updating it as > >> rejected, if > >> it is still relevant please let us know. > > > > Most of the functions in lib/librte_e

Re: [dpdk-dev] [pull-request] next-crypto 19.02 rc2

2019-01-11 Thread Thomas Monjalon
11/01/2019 07:08, Pablo de Lara: > http://dpdk.org/git/next/dpdk-next-crypto "Meson" compilation is not working if IPSec_MB is not installed. "Make" compilation has no such big issue but it does not respect EXTRA_CFLAGS when assuming IMB_HDR = /usr/include/intel-ipsec-mb.h

[dpdk-dev] [PATCH v2] pdump: fix vdev cleanup

2019-01-11 Thread Reshma Pattan
From: reshmapa Virtual devices added in pdump application using rte_eal_hotplug_add should be removed explicitly while existing the pdump application, otherwise the subsequent run of the pdump application will fail with the reason that virtual devices with the same name already exists in primary.

[dpdk-dev] [PATCH] pdump: fix vdev cleanup

2019-01-11 Thread Reshma Pattan
From: reshmapa Virtual devices added in pdump application using rte_eal_hotplug_add should be removed explicitly while existing the pdump application, otherwise the subsequent run of the pdump application will fail with the reason that virtaul devices with the same name already exists in primary.

Re: [dpdk-dev] [PATCH v3 4/4] build: use dependency() for libbsd instead of manual append to ldflags

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 04:26:08PM +, Luca Boccassi wrote: > Move libbsd inclusion to librte_eal, so that all other libraries and > PMDs will inherit it. > > Signed-off-by: Luca Boccassi > --- > v3: only add dependency to librte_eal and let it propagate from there > > config/meson.build

Re: [dpdk-dev] [PATCH v3 3/4] build: reorder libraries and build eal before cmdline

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 04:26:07PM +, Luca Boccassi wrote: > Most libraries and PMDs depend on eal, and eal depends only on kvargs, > so reorder the list in Meson to reflect this and take advantage of this > dependency chain. > > Signed-off-by: Luca Boccassi > --- > v3: added this patch to le

Re: [dpdk-dev] [PATCH v3 2/4] build: use dependency() instead of find_library()

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 04:26:06PM +, Luca Boccassi wrote: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for rever

Re: [dpdk-dev] [PATCH v2] ethdev: declare Tx prepare API as not experimental

2019-01-11 Thread David Marchand
On Fri, Jan 11, 2019 at 5:52 PM Ferruh Yigit wrote: > On 1/11/2019 2:11 PM, David Marchand wrote: > > The Tx prepare API was introduced at a time when the experimental API > > tag mechanism did not exist yet and is missing the tag. > > However, this API has been there since 17.02 and did not suff

Re: [dpdk-dev] [PATCH v3 1/4] build: bump minimum Meson version to 0.47.1

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 04:26:05PM +, Luca Boccassi wrote: > Meson 0.47.1 fixed a bug that is difficult to work around, which causes > the linker flag of dependencies to be repeated dozens of times, which > causes issues especially when using the built-in dependency() API. > Bump the minimum ve

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/hash: reset iter and found in perf test

2019-01-11 Thread Ferruh Yigit
On 11/29/2018 6:38 PM, Dharmik Thakkar wrote: > Reset 'iter' and 'tbl_rw_test_param.found' on each iteration > to give correct result for lost and duplicated keys. > > Fixes: 0eb3726ebcf14 ("test/hash: add test for read/write concurrency") > Cc: sta...@dpdk.org > > Signed-off-by: Dharmik Thakkar

Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation

2019-01-11 Thread Ferruh Yigit
On 1/10/2019 6:16 PM, Kevin Traynor wrote: > On 01/09/2019 11:37 AM, Dekel Peled wrote: >> This patch fixes a typo in SET_MAC_DST action description. >> It also adds restriction note for set MAC src/dst actions description. >> >> Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions

Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation

2019-01-11 Thread Ferruh Yigit
On 1/9/2019 9:12 PM, Ori Kam wrote: > > >> -Original Message- >> From: dev On Behalf Of Dekel Peled >> Sent: Wednesday, January 9, 2019 1:38 PM >> To: Adrien Mazarguil >> Cc: dev@dpdk.org; Ori Kam ; Dekel Peled >> ; Jack Min >> Subject: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrit

[dpdk-dev] [PATCH v4 3/3] test/compress: add varied buffer input/outputs

2019-01-11 Thread Kovacevic, Marko
Added unit test to check if a SGL buffer was added as an input and a Linear Buffer as output and vice versa so we can test if the application would process the different buffers properly. Signed-off-by: Kovacevic, Marko Acked-by: Fiona Trahe Acked-by: Lee Daly --- v4: Added Acks resolved che

[dpdk-dev] [PATCH v4 1/3] test/compress: refactor main test function

2019-01-11 Thread Kovacevic, Marko
From: Pablo de Lara Since the start of the compression tests, the main test function, test_deflate_comp_decomp, has increased its parameter with each new test added. In order to make the code cleaner, and more scalable, these parameters have been divided into two structures, which are now passed

[dpdk-dev] [PATCH v4 2/3] test/compress: add out of space test

2019-01-11 Thread Kovacevic, Marko
This patch adds new out of space testcase to check that the destination mbuf is smaller than required for the output of compression to ensure the driver doesn't crash and returns the valid error case. Signed-off-by: Kovacevic, Marko Acked-by: Lee Daly Acked-by: Fiona Trahe --- v4: Added Acks

[dpdk-dev] [PATCH v4 0/3] Compression Unit Tests

2019-01-11 Thread Kovacevic, Marko
Made changes to the two unit tests for the out of space i have added proper checkes for all the cases compressing with compress dev and decompressing with compress dev. Varied buffer patch i have removed the extra unit test and merged it into the sgl test as one. Added a third patch into my patch

Re: [dpdk-dev] [PATCH v2] ethdev: declare Tx prepare API as not experimental

2019-01-11 Thread Ferruh Yigit
On 1/11/2019 2:11 PM, David Marchand wrote: > The Tx prepare API was introduced at a time when the experimental API > tag mechanism did not exist yet and is missing the tag. > However, this API has been there since 17.02 and did not suffer any > change since its introduction. > > Let's just remove

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-11 Thread Ferruh Yigit
On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > The Netronome's Network Flow Processor chip is highly programmable > with the goal of processing packets at high speed. Processing units > and other chip components are available from the host through the > PCIe CPP(Command Push Pull bus) interface. T

Re: [dpdk-dev] [PATCH 0/3] Replace compilation time options with log level

2019-01-11 Thread Ferruh Yigit
On 11/29/2018 8:31 PM, Dharmik Thakkar wrote: > Currently, in test code, for printing extra information, > compilation time options are used. This approach does not compile the > code always. Macro needs to be set for the code to compile. > > This patchset replaces compilation time option with log

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-11 Thread Luca Boccassi
On Fri, 2019-01-11 at 15:49 +, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 02:56:28PM +, Luca Boccassi wrote: > > On Fri, 2019-01-11 at 14:24 +, Bruce Richardson wrote: > > > On Fri, Jan 11, 2019 at 12:39:23PM +, Luca Boccassi wrote: > > > > On Fri, 2019-01-11 at 11:52 +,

[dpdk-dev] [PATCH v3 4/4] build: use dependency() for libbsd instead of manual append to ldflags

2019-01-11 Thread Luca Boccassi
Move libbsd inclusion to librte_eal, so that all other libraries and PMDs will inherit it. Signed-off-by: Luca Boccassi --- v3: only add dependency to librte_eal and let it propagate from there config/meson.build | 10 +- lib/librte_eal/meson.build | 3 +++ 2 files changed, 8 i

[dpdk-dev] [PATCH v3 3/4] build: reorder libraries and build eal before cmdline

2019-01-11 Thread Luca Boccassi
Most libraries and PMDs depend on eal, and eal depends only on kvargs, so reorder the list in Meson to reflect this and take advantage of this dependency chain. Signed-off-by: Luca Boccassi --- v3: added this patch to let the next just update librte_eal instead of also having to update rte_cm

[dpdk-dev] [PATCH v3 2/4] build: use dependency() instead of find_library()

2019-01-11 Thread Luca Boccassi
Whenever possible (if the library ships a pkg-config file) use meson's dependency() function to look for it, as it will automatically add it to the Requires.private list if needed, to allow for static builds to succeed for reverse dependencies of DPDK. Otherwise the recursive dependencies are not p

[dpdk-dev] [PATCH v3 1/4] build: bump minimum Meson version to 0.47.1

2019-01-11 Thread Luca Boccassi
Meson 0.47.1 fixed a bug that is difficult to work around, which causes the linker flag of dependencies to be repeated dozens of times, which causes issues especially when using the built-in dependency() API. Bump the minimum version and remove obsolete version checks. Signed-off-by: Luca Boccassi

Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd

2019-01-11 Thread Luca Boccassi
On Fri, 2019-01-11 at 15:50 +, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 03:04:38PM +, Luca Boccassi wrote: > > On Fri, 2019-01-11 at 14:30 +, Bruce Richardson wrote: > > > On Fri, Jan 11, 2019 at 02:27:01PM +, Bruce Richardson wrote: > > > > On Fri, Jan 11, 2019 at 12:38:09

Re: [dpdk-dev] [PATCH v3 00/20] NXP DPAA2 fixes and enhancements

2019-01-11 Thread Ferruh Yigit
On 1/11/2019 3:51 PM, Ferruh Yigit wrote: > On 1/11/2019 12:24 PM, Shreyansh Jain wrote: >> (N: Original series was by Hemant - due to RC window timeline and >> his unavailability, respining on his behalf) >> >> This patch set covers following: >> >> 1. Fixes in the existing NXP DPAA2 bus and n

[dpdk-dev] [PATCH] build: use static deps of libs for pkg-config libs.private

2019-01-11 Thread Luca Boccassi
Dependencies of the RTE libraries were not being added to the Requires.private field of the pc file since the variable used for dynamic linking was passed to the related field of pkg.generate. Use the static one so that dependencies are included. Fixes: 57ae0ec62620 ("build: add dependency on tele

Re: [dpdk-dev] [PATCH v3 00/20] NXP DPAA2 fixes and enhancements

2019-01-11 Thread Ferruh Yigit
On 1/11/2019 12:24 PM, Shreyansh Jain wrote: > (N: Original series was by Hemant - due to RC window timeline and > his unavailability, respining on his behalf) > > This patch set covers following: > > 1. Fixes in the existing NXP DPAA2 bus and net pmd > 2. New object (DPDMUX) support in NIC d

Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 03:04:38PM +, Luca Boccassi wrote: > On Fri, 2019-01-11 at 14:30 +, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 02:27:01PM +, Bruce Richardson wrote: > > > On Fri, Jan 11, 2019 at 12:38:09PM +, Luca Boccassi wrote: > > > > Move libbsd inclusion to lib

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 02:56:28PM +, Luca Boccassi wrote: > On Fri, 2019-01-11 at 14:24 +, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 12:39:23PM +, Luca Boccassi wrote: > > > On Fri, 2019-01-11 at 11:52 +, Bruce Richardson wrote: > > > > On Fri, Jan 11, 2019 at 11:10:28AM

Re: [dpdk-dev] [PATCH 3/4] net/enic: support multicast filtering

2019-01-11 Thread Ferruh Yigit
On 12/10/2018 6:28 PM, Hyong Youb Kim wrote: > The VIC hardware has 64 MAC filters per vNIC, which can be either > unicast or multicast. Use one half for unicast and the other half for > multicast, as the VIC kernel drivers for Linux and Windows do. > > Signed-off-by: Hyong Youb Kim > Reviewed-by

Re: [dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2019-01-11 Thread Ferruh Yigit
On 12/19/2018 9:20 PM, Thomas Monjalon wrote: > 19/12/2018 22:09, Ferruh Yigit: >> This patch is sitting on patchwork since 2015, I am updating it as rejected, >> if >> it is still relevant please let us know. > > Most of the functions in lib/librte_eal/bsdapp/eal/eal_thread.c > and lib/librte_ea

[dpdk-dev] [PATCH v3 3/3] test/compress: add varied buffer input/outputs

2019-01-11 Thread Kovacevic, Marko
Added unit test to check if a SGL buffer was added as an input and a Linear Buffer as output and vice versa so we can test if the application would process the different buffers properly. Signed-off-by: Kovacevic, Marko --- test/test/test_compressdev.c | 123 ++---

[dpdk-dev] [PATCH v3 2/3] test/compress: add out of space test

2019-01-11 Thread Kovacevic, Marko
This patch adds new out of space testcase to check that the destination mbuf is smaller than required for the output of compression to ensure the driver doesn't crash and returns the valid error case. Signed-off-by: Kovacevic, Marko --- test/test/test_compressdev.c | 178

[dpdk-dev] [PATCH v3 1/3] test/compress: refactor main test function

2019-01-11 Thread Kovacevic, Marko
From: Pablo de Lara Since the start of the compression tests, the main test function, test_deflate_comp_decomp, has increased its parameter with each new test added. In order to make the code cleaner, and more scalable, these parameters have been divided into two structures, which are now passed

[dpdk-dev] [PATCH v3 0/3] Compression Unit Tests

2019-01-11 Thread Kovacevic, Marko
Made changes to the two unit tests for the out of space i have added proper checkes for all the cases compressing with compress dev and decompressing with compress dev. Varied buffer patch i have removed the extra unit test and merged it into the sgl test as one. Added a third patch into my patch

Re: [dpdk-dev] [PATCH v4] eal: fix core number validation

2019-01-11 Thread David Marchand
On Fri, Jan 11, 2019 at 3:15 PM Hari Kumar Vemula < hari.kumarx.vem...@intel.com> wrote: > > diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c > index 2acab9d69..fc45bf953 100644 > --- a/test/test/test_eal_flags.c > +++ b/test/test/test_eal_flags.c > @@ -18,6 +18,7 @@ > #includ

Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd

2019-01-11 Thread Luca Boccassi
On Fri, 2019-01-11 at 14:30 +, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 02:27:01PM +, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 12:38:09PM +, Luca Boccassi wrote: > > > Move libbsd inclusion to librte_eal, so that all other libraries > > > and > > > PMDs will inherit

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-11 Thread Luca Boccassi
On Fri, 2019-01-11 at 14:24 +, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 12:39:23PM +, Luca Boccassi wrote: > > On Fri, 2019-01-11 at 11:52 +, Bruce Richardson wrote: > > > On Fri, Jan 11, 2019 at 11:10:28AM +, Luca Boccassi wrote: > > > > On Mon, 2019-01-07 at 16:55 +,

Re: [dpdk-dev] [PATCH v9 0/6] app/proc-info: enhance debug of proc-info tool

2019-01-11 Thread Thomas Monjalon
10/01/2019 22:36, Vipin Varghese: > This patch adds new debug functions to existing proc-info tool. > > Motivation > == > > DPDK proc-info tool is been widely used as secondary process to collect > stats for any primary process. But these are limited to DPDK NIC ports and > basic memory u

Re: [dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible

2019-01-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Van Haaren, Harry > Sent: Friday, January 11, 2019 11:33 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Pattan, Reshma > ; Dumitrescu, Cristian > ; olivier.m...@6wind.com; > tho...@monjalon.net; step...@networkplumber.org; > gavin...@arm.com; honnappa.nagara

Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 02:27:01PM +, Bruce Richardson wrote: > On Fri, Jan 11, 2019 at 12:38:09PM +, Luca Boccassi wrote: > > Move libbsd inclusion to librte_eal, so that all other libraries and > > PMDs will inherit it, and librte_cmdline which is built before > > librte_eal. > > Bump Mes

Re: [dpdk-dev] [PATCH v2 3/3] build: bump minimum Meson to 0.47.1 and use dependency() for libbsd

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 12:38:09PM +, Luca Boccassi wrote: > Move libbsd inclusion to librte_eal, so that all other libraries and > PMDs will inherit it, and librte_cmdline which is built before > librte_eal. > Bump Meson dependency to 0.47.1, to avoid bug where the linker flag of > the depende

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] build: use dependency() instead of find_library()

2019-01-11 Thread Bruce Richardson
On Fri, Jan 11, 2019 at 12:39:23PM +, Luca Boccassi wrote: > On Fri, 2019-01-11 at 11:52 +, Bruce Richardson wrote: > > On Fri, Jan 11, 2019 at 11:10:28AM +, Luca Boccassi wrote: > > > On Mon, 2019-01-07 at 16:55 +, Bruce Richardson wrote: > > > > On Mon, Jan 07, 2019 at 04:39:34PM

[dpdk-dev] [pull-request] next-crypto 19.02 rc2

2019-01-11 Thread Pablo de Lara
The following changes since commit a958a5c07f4b5e715921a2f22c931142417287a5: net/softnic: support service cores (2019-01-10 16:04:44 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 91ed77bbe00512330e69636abc0c939c5de4c

[dpdk-dev] [PATCH v4] eal: fix core number validation

2019-01-11 Thread Hari Kumar Vemula
When incorrect core value or range provided, as part of -l command line option, a crash occurs. Added valid range checks to fix the crash. Added ut check for negative core values. Added unit test case for invalid core number range. Fixes: d888cb8b9613 ("eal: add core list input format") Cc: sta.

[dpdk-dev] [PATCH v2] ethdev: declare Tx prepare API as not experimental

2019-01-11 Thread David Marchand
The Tx prepare API was introduced at a time when the experimental API tag mechanism did not exist yet and is missing the tag. However, this API has been there since 17.02 and did not suffer any change since its introduction. Let's just remove the warning from the documentation. Signed-off-by: Dav

Re: [dpdk-dev] [PATCH v4 0/2] net/virtio-user: add packed vq support

2019-01-11 Thread Tiwei Bie
On Fri, Jan 11, 2019 at 10:39:27AM +0100, Jens Freimann wrote: > Patch 1 fixes a bug in virtio_pq_send_command(). When we wait for > a descriptor to be marked as used we need to consider that the ring > might have wrapped and use the previous wrap counter. > > Patch 2 reverts the patch to error ou

Re: [dpdk-dev] [PATCH] ethdev: declare tx prepare api as not experimental

2019-01-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Friday, January 11, 2019 1:15 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; > arybche...@solarflare.com > Subject: [dpdk-dev] [PATCH] ethdev: declare tx prepare api as n

Re: [dpdk-dev] [EXT] [PATCH v3 5/6] spinlock: reimplement with atomic one-way barrier builtins

2019-01-11 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Thursday, December 27, 2018 3:42 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: david.march...@redhat.com; chao...@linux.vnet.ibm.com; nd > ; bruce.richard...@intel.com; tho...@monjalon.net; > hemant.agra...@

Re: [dpdk-dev] [PATCH] vhost_user: remove statement for non-existed function

2019-01-11 Thread Tiwei Bie
> vhost_user: remove statement for non-existed function s/vhost_user/vhost/ On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote: > vhost_user_host_notifier_ctrl is not existed anymore, its statement in > header file should be removed accordingly. > > Fixes: 43f34e35663f ("vhost: provide

  1   2   >