On Fri, Jan 11, 2019 at 02:27:01PM +0000, Bruce Richardson wrote:
> On Fri, Jan 11, 2019 at 12:38:09PM +0000, Luca Boccassi wrote:
> > Move libbsd inclusion to librte_eal, so that all other libraries and
> > PMDs will inherit it, and librte_cmdline which is built before
> > librte_eal.
> > Bump Meson dependency to 0.47.1, to avoid bug where the linker flag of
> > the dependency gets replicated again and again.
> >
> > Signed-off-by: Luca Boccassi <bl...@debian.org>
> > ---
> > v2: bump meson minimum version to 0.47.1 to avoid meson bug, and move
> > libbsd dependency to eal and cmdline
> >
> > config/meson.build | 10 +++++-----
> > lib/librte_cmdline/meson.build | 4 ++++
> > lib/librte_eal/meson.build | 3 +++
> > meson.build | 2 +-
> > 4 files changed, 13 insertions(+), 6 deletions(-)
> >
> There are some meson version checks in the code that can be removed as
> part of this change:
>
> $ git grep meson.version
> drivers/meson.build: if meson.version().version_compare('>=0.47')
> kernel/linux/meson.build: if meson.version().version_compare('>=0.44')
> kernel/linux/meson.build: if
> meson.version().version_compare('>=0.44')
> meson.build: meson_version: '>= 0.41'
> meson.build:if meson.version().version_compare('>=0.47')
>
Thinking on this more, I think the version bump to 0.47 should be done in a
separate standalone patch at the start of this set. Then the other patches
can be based on that.
/Bruce
