[dpdk-dev] [PATCH] net/mlx4: support flow w/o ETH spec and with VLAN

2018-12-19 Thread Dekel Peled
This patch adds to MLX4 PMD the option to set flow rules with wildcard ether MAC and specific VLAN ID. Note that this fix works with 1. CX-3 FW 2.42.5016 or higher. 2. mlxconfig configuration STEER_FORCE_VLAN set to 1. Signed-off-by: Dekel Peled --- drivers/net/mlx4/mlx4_flow.c | 10 +++---

Re: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free

2018-12-19 Thread Shahaf Shuler
Wednesday, December 12, 2018 1:12 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool free > > When MPRQ mempool is freed, the pointer stored in priv structure must be > reset to null. Otherwise, the mempool can be freed again if the port is > restarted. > > Fixe

Re: [dpdk-dev] [PATCH 2/3] mlx5: Implement support for read_clock

2018-12-19 Thread Shahaf Shuler
Wednesday, December 19, 2018 3:50 PM, Tom Barbette: > Subject: [PATCH 2/3] mlx5: Implement support for read_clock Implement -> implement (lower case) > > Signed-off-by: Tom Barbette Acked-by: Shahaf Shuler > --- > drivers/net/mlx5/Makefile | 2 +- > drivers/net/mlx5/meson.build |

Re: [dpdk-dev] [PATCH 1/3] rte_ethdev: Add API function to read dev clock

2018-12-19 Thread Shahaf Shuler
Wednesday, December 19, 2018 3:50 PM, Tom Barbette: > Subject: [PATCH 1/3] rte_ethdev: Add API function to read dev clock > > Add rte_eth_read_clock to read the raw clock of a devide. > > The main use is to get the device clock conversion co-efficients to be able to > translate the raw clock of t

[dpdk-dev] DPDK Governing Board - meeting minutes 03 Dec 2018

2018-12-19 Thread St Leger, Jim
DPDK Community: What a great year we've had! The development community continues to raise the bar with the biggest ever release in 18.05 and another very big release in 18.11. I'm guessing the 19.xx releases will continue the trend as DPDK sees increasing adoption and usage across the networki

Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-19 Thread Tiwei Bie
On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: > Instead of writing back descriptors chains in order, let's > write the first chain flags last in order to improve batching. > > With Kernel's pktgen benchmark, ~3% performance gain is measured. > > Signed-off-by: Maxime Coquelin

Re: [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching

2018-12-19 Thread Tiwei Bie
On Wed, Dec 19, 2018 at 09:21:09AM +0100, Maxime Coquelin wrote: > This series adds missing read barriers after reading avail index > for split ring and desc flags for packed ring. > > Also, it turns out that some descriptors prefetching are either > badly placed, or useless, last part of the seri

Re: [dpdk-dev] [PATCH v2 0/4] net/cxgbe: fix build for Microsoft Windows OS support

2018-12-19 Thread Rahul Lakkireddy
On Thursday, December 12/20/18, 2018 at 03:09:44 +0530, Ferruh Yigit wrote: > On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote: > > This series of patches fix compilation warning and errors seen while > > building CXGBE PMD in preparation for Microsoft Windows OS support. > > > > Patch 1 uses relativ

[dpdk-dev] [PATCH v9 3/3] doc: update queue number per vf for i40e

2018-12-19 Thread Zhirun Yan
Updated the doc and release notes on the support for requesting more queues. Signed-off-by: Zhirun Yan --- doc/guides/nics/i40e.rst | 15 +-- doc/guides/rel_notes/release_19_02.rst | 8 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH v9 0/3] Support request more queues

2018-12-19 Thread Zhirun Yan
V9 - Rebase to latest DPDK VF send VIRTCHNL_OP_REQUEST_QUEUES to kernel PF or DPDK VF for requesting more queues, then PF will allocate more queues. Zhirun Yan (3): net/i40e: support VF request more queues net/i40e: support PF respond VF request more queues doc: update queue number per vf f

[dpdk-dev] [PATCH v9 2/3] net/i40e: support PF respond VF request more queues

2018-12-19 Thread Zhirun Yan
This patch respond the VIRTCHNL_OP_REQUEST_QUEUES msg from VF, and process to allocated more queues for the requested VF. If successful, PF will notify VF to reset. If unsuccessful, PF will send message to inform VF. Signed-off-by: Zhirun Yan Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e

[dpdk-dev] [PATCH v9 1/3] net/i40e: support VF request more queues

2018-12-19 Thread Zhirun Yan
Before this patch, VF gets a default number of queues from the PF. This patch enables VF to request a different number. When VF configures more queues, it will send VIRTCHNL_OP_REQUEST_QUEUES to PF to request more queues, if success, PF will reset the VF. User can run "port stop all", "port config

Re: [dpdk-dev] [PATCH v1 1/2] test/rwlock: add perf test case

2018-12-19 Thread Honnappa Nagarahalli
> > > > Hi, > > > > > > > > Add performance test on all available cores to benchmark the scaling > > > up performance and fairness of rw_lock. > > > > > > Fixes: af75078faf ("first public release") > > > Cc: sta...@dpdk.org > > > > > > Suggested-by: Gavin Hu > > > Signed-off-by: Joyce Kong > > >

Re: [dpdk-dev] [PATCH v1 1/2] test/rwlock: add perf test case

2018-12-19 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, December 20, 2018 7:35 AM > To: Joyce Kong (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; tho...@monjalon.net; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; Honnappa > Nagarahalli ; Gavin Hu (Arm Technolo

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: support bigger packets

2018-12-19 Thread Ananyev, Konstantin
Hi, > > Adding MTU and mbuf size configuration to the application's command > line, in order to be able to receive all packet sizes by the NIC and > DPDK application. > The maximum transmission unit (MTU) is the largest size packet in > bytes that can be sent on the network, therefore before add

Re: [dpdk-dev] [PATCH v1 2/2] rwlock: reimplement with __atomic builtins

2018-12-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > Sent: Thursday, December 13, 2018 3:38 AM > To: dev@dpdk.org > Cc: n...@arm.com; Gavin Hu ; tho...@monjalon.net; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > honnappa.nagaraha...@arm.

[dpdk-dev] [PATCH v2] examples/fips_validate: add power on self test

2018-12-19 Thread Fan Zhang
This patch adds a sample power on self-test to fips_validate sample application. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- v2: - fixed clang build error. examples/fips_validation/Makefile |1 + examples/fips_validation/fips_dev_self_test.c | 1680 +

Re: [dpdk-dev] [PATCH v1 1/2] test/rwlock: add perf test case

2018-12-19 Thread Ananyev, Konstantin
Hi, > > Add performance test on all available cores to benchmark > the scaling up performance and fairness of rw_lock. > > Fixes: af75078faf ("first public release") > Cc: sta...@dpdk.org > > Suggested-by: Gavin Hu > Signed-off-by: Joyce Kong > Reviewed-by: Honnappa Nagarahalli > Reviewed-

[dpdk-dev] [PATCH v3 0/3] crypto/aesni_mb: add plain sha support

2018-12-19 Thread Fan Zhang
This patchset adds the plain SHA1, SHA224, SHA256, SHA384, and SHA512 algorithm support to AESNI-MB PMD. The crypto unit tests and documentation are updated accordingly. This patchset depends on the following patchset: "[PATCH v5 0/3] crypto/aesni_mb: add gmac support" (https://mails.dpdk.org/arch

[dpdk-dev] [PATCH v3 2/3] test: add aesni-mb sha test

2018-12-19 Thread Fan Zhang
This patch adds the plain SHA* test cases to AESNI-MB crypto unit test. The tests are enabled only for intel-ipsec-mb library version 0.52 or older. Signed-off-by: Damian Nowak Signed-off-by: Lukasz Krakowiak Signed-off-by: Fan Zhang --- test/test/test_cryptodev_hash_test_vectors.h | 65 ++

[dpdk-dev] [PATCH v3 3/3] doc: update release note and PMD information

2018-12-19 Thread Fan Zhang
This patch updates the release note and AESNI-MD PMD documentation. Signed-off-by: Damian Nowak Signed-off-by: Lukasz Krakowiak Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/aesni_mb.rst | 6 ++ doc/guides/rel_notes/release_19_02.rst | 4 ++-- 2 files changed, 8 insertions(+), 2 d

[dpdk-dev] [PATCH v3 1/3] crypto/aesni_mb: add plain sha support

2018-12-19 Thread Fan Zhang
This patch adds the plain SHA1, SHA224, SHA256, SHA384, and SHA512 algorithm support to AESNI-MB PMD. Signed-off-by: Damian Nowak Signed-off-by: Lukasz Krakowiak Signed-off-by: Fan Zhang --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 25 + drivers/crypto/aesni_mb/rte_aesni_mb_pm

Re: [dpdk-dev] [PATCH v4] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-12-19 Thread Thomas Monjalon
12/12/2018 12:27, Burakov, Anatoly: > On 12-Dec-18 11:25 AM, tone.zhang wrote: > > With a larger PAGE_SIZE it is possible for the MSI table to very > > close to the end of the BAR s.t. when we align the start and end > > of the MSI table to the PAGE_SIZE, the end offset of the MSI > > table is out

Re: [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection

2018-12-19 Thread Thomas Monjalon
17/12/2018 11:19, David Marchand: > On Mon, Dec 17, 2018 at 10:26 AM Gaetan Rivet > wrote: > > > Missing brackets around the if means that the loop will end at its first > > iteration. > > > > Cc: sta...@dpdk.org > > > > Fixes: 2395332798d0 ("eal: add option register infrastructure") > > Signed-o

Re: [dpdk-dev] [PATCH] eal:missing newline on RTE_LOG msg

2018-12-19 Thread Thomas Monjalon
17/12/2018 10:25, Gaëtan Rivet: > Hi Keith, > > On Sun, Dec 16, 2018 at 05:01:03PM -0600, Keith Wiles wrote: > > Add a missing newline to a RTE_LOG message. > > > > I think it might interest sta...@dpdk.org, and you might as well include > a fixline reference. Fixes: 2395332798d0 ("eal: add

Re: [dpdk-dev] [PATCH] eal: Add the check for null peer pointer in mp request handler

2018-12-19 Thread Thomas Monjalon
10/12/2018 17:41, Burakov, Anatoly: > On 05-Dec-18 6:19 AM, gfree.w...@vip.163.com wrote: > > From: Gao Feng > > > > Add the check for null peer pointer like the bundle pointer in the mp > > request > > handler. They should follow same style. And add some logs for nomem cases. > > > > Signed-of

[dpdk-dev] [PATCH v5 3/3] doc: update release note and pmd info

2018-12-19 Thread Fan Zhang
This patch updates the release note and AESNI-MD PMD documentation. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- doc/guides/cryptodevs/aesni_mb.rst | 2 ++ doc/guides/rel_notes/release_19_02.rst | 5 + 2 files changed, 7 insertions(+) diff --git a/doc/guides/cryptodevs/aesni_mb.

[dpdk-dev] [PATCH v5 1/3] crypto/aesni_mb: add gmac support

2018-12-19 Thread Fan Zhang
This patch updates the AESNI-MB PMD to add AES-GMAC support. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 126 +++- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c | 127 - drivers/crypto/aesni_mb

[dpdk-dev] [PATCH v5 2/3] test: add aesni-mb gmac test

2018-12-19 Thread Fan Zhang
This patch adds the GMAC test cases to AESNI-MB crypto unit test. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- test/test/test_cryptodev.c | 15 +++ test/test/test_cryptodev_hash_test_vectors.h | 9 + 2 files changed, 24 insertions(+) diff --git a/t

[dpdk-dev] [PATCH v5 0/3] crypto/aesni_mb: add gmac support

2018-12-19 Thread Fan Zhang
This patchset adds the AES-GMAC authentication only support to AESNI-MB PMD, including the driver code, cryptodev unit test, and documentation updates. This patchset is built on top of the patchset "use architecure independent macros" (https://mails.dpdk.org/archives/dev/2018-December/121680.html)

Re: [dpdk-dev] [PATCH] eal: fix memleak on mp request error handler

2018-12-19 Thread Thomas Monjalon
10/12/2018 17:38, Burakov, Anatoly: > On 05-Dec-18 2:50 AM, gfree.w...@vip.163.com wrote: > > From: Gao Feng > > > > When rte_eal_alarm_set failed, need to free the bundle mem in the > > error handler of handle_primary_request and handle_secondary_request. > > > > Signed-off-by: Gao Feng > > A

Re: [dpdk-dev] [PATCH v3 0/2] add rte ring reset api and use it to flush a ring by hash

2018-12-19 Thread Thomas Monjalon
+Cc Olivier, maintainer of the ring library. 12/12/2018 12:15, Gavin Hu: > V3: Allow experimental API for meson build > > V2: Fix the coding style issue(commit message line too long) > > V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles. > The patch is to just resetting th

Re: [dpdk-dev] [PATCH] eal: remove variable length array

2018-12-19 Thread Thomas Monjalon
14/12/2018 21:28, Mattias Rönnblom: > On 2018-12-14 20:07, Jeff Shaw wrote: > >>> The code prior to this commit produced the following warning when > >>> compiled with "-Wvla -std=c90". > >>> > >>> warning: ISO C90 forbids variable length array ‘array’ [-Wvla] > >>> > >>> This commit removes th

[dpdk-dev] [PATCH v4 1/3] crypto/aesni_mb: add gmac support

2018-12-19 Thread Fan Zhang
This patch updates the AESNI-MB PMD to add AES-GMAC support. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 126 +++- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_compat.c | 127 - drivers/crypto/aesni_mb

[dpdk-dev] [PATCH v4 2/3] test: add aesni-mb gmac test

2018-12-19 Thread Fan Zhang
This patch adds the GMAC test cases to AESNI-MB crypto unit test. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- test/test/test_cryptodev.c | 24 1 file changed, 24 insertions(+) diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index 84065eb49.

[dpdk-dev] [PATCH v4 3/3] doc: update release note and PMD information

2018-12-19 Thread Fan Zhang
This patch updates the release note and AESNI-MD PMD documentation. Signed-off-by: Fan Zhang Acked-by: Damian Nowak --- doc/guides/cryptodevs/aesni_mb.rst | 2 ++ doc/guides/rel_notes/release_19_02.rst | 5 + 2 files changed, 7 insertions(+) diff --git a/doc/guides/cryptodevs/aesni_mb.

[dpdk-dev] [PATCH v4 0/3] crypto/aesni_mb: add gmac support

2018-12-19 Thread Fan Zhang
This patchset adds the AES-GMAC authentication only support to AESNI-MB PMD, including the driver code, cryptodev unit test, and documentation updates. This patchset is built on top of the patchset "use architecure independent macros" (https://mails.dpdk.org/archives/dev/2018-December/121680.html)

Re: [dpdk-dev] [PATCH v2 0/4] net/cxgbe: fix build for Microsoft Windows OS support

2018-12-19 Thread Ferruh Yigit
On 12/19/2018 4:28 PM, Rahul Lakkireddy wrote: > This series of patches fix compilation warning and errors seen while > building CXGBE PMD in preparation for Microsoft Windows OS support. > > Patch 1 uses relative paths for including header files. > Patch 2 fixes macros related to rte_log(). > Pat

Re: [dpdk-dev] [PATCH] lib/librte_lpm: remove recursively included header file

2018-12-19 Thread Thomas Monjalon
30/11/2018 08:57, Congwen Zhang: > includes itself: rte_lpm.h -> rte_lpm_sse.h -> rte_lpm.h It is the same in rte_lpm_neon.h

Re: [dpdk-dev] [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned to 8 bytes

2018-12-19 Thread Thomas Monjalon
> > The same issue was fixed on for the ipv4 version of this routine in > > commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8 bytes"). > > Briefly, the size of an ipv6 header is always 40 bytes. With an MTU of > > 1500, this will never produce a multiple of 8 bytes for the frag_size

Re: [dpdk-dev] [PATCH] examples/ip_fragmentation: support bigger packets

2018-12-19 Thread Thomas Monjalon
13/12/2018 13:17, Noa Ezra: > Adding MTU and mbuf size configuration to the application's command > line, in order to be able to receive all packet sizes by the NIC and > DPDK application. > The maximum transmission unit (MTU) is the largest size packet in > bytes that can be sent on the network, t

Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy

2018-12-19 Thread Thomas Monjalon
21/11/2018 11:17, Zhao1, Wei: > Add the background for this patch > https://mails.dpdk.org/archives/dev/2018-November/119391.html > > > There is not need for these useless information and it had better be > > removed in oder not to confusing users. > > > > Signed-off-by: Wei Zhao Applied, than

Re: [dpdk-dev] [PATCH v3 0/4] examples/power: allow use of more than 64 cores

2018-12-19 Thread Thomas Monjalon
14/12/2018 14:37, Burakov, Anatoly: > On 14-Dec-18 1:31 PM, David Hunt wrote: > > First of all we convert all the relevant uint64_t's to char arrays. Then > > we remove the unneeded mask functions that were limited to 64 cores. Also > > extend the guest functionality and finally rause the number of

Re: [dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2018-12-19 Thread Thomas Monjalon
19/12/2018 22:09, Ferruh Yigit: > This patch is sitting on patchwork since 2015, I am updating it as rejected, > if > it is still relevant please let us know. Most of the functions in lib/librte_eal/bsdapp/eal/eal_thread.c and lib/librte_eal/linuxapp/eal/eal_thread.c are the same. We must merge t

Re: [dpdk-dev] [PATCH v2] ethdev: Prefetch driver variable structure

2018-12-19 Thread Ferruh Yigit
On 11/11/2015 1:59 PM, mike.a.polehn at intel.com (Polehn, Mike A) wrote: > Adds ethdev driver prefetch of variable structure to CPU cache 0 > while calling into tx or rx device driver operation. > > RFC 2544 test of NIC task test measurement points show improvement > of lower latency and/or bette

Re: [dpdk-dev] [PATCH v2] Move common functions in eal_thread.c

2018-12-19 Thread Ferruh Yigit
On 8/19/2015 9:46 PM, rkerur at gmail.com (Ravi Kerur) wrote: > v2: >> Remove un-needed header file eal_private.h from freeBSD > eal_thread.c after code movement. > > v1: > Changes include >> Moving common functions in eal_thread.c in > linuxapp and bsdapp into common/eal_common_

[dpdk-dev] [PATCH v2] mk: fix scope of disabling AVX512F support

2018-12-19 Thread Ferruh Yigit
AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://g

Re: [dpdk-dev] [PATCH] mk: fix scope of disabling AVX512F support

2018-12-19 Thread Ferruh Yigit
On 12/19/2018 8:28 PM, Thomas Monjalon wrote: > 19/12/2018 21:20, Ferruh Yigit: >> On 12/19/2018 7:58 PM, Thomas Monjalon wrote: >>> 19/12/2018 20:29, Ferruh Yigit: AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that th

Re: [dpdk-dev] Eventdev DSW correctness and pathologies

2018-12-19 Thread Mattias Rönnblom
On 2018-12-19 19:53, Venky Venkatesh wrote: Couple of questions on DSW scheduling: 1. how was the correctness of the scheduling verified -- specifically the fact that ATOMIC is not scheduled simultaneously to 2 cores? I can think of feeding the same flowid on all cores and see where the va

Re: [dpdk-dev] [PATCH v1 0/2] reimplement rwlock and add relevant perf test case

2018-12-19 Thread Thomas Monjalon
17/12/2018 06:16, Honnappa Nagarahalli: > Adding other platform maintainers as it affects all platforms. There is no other comment. I am not sure what to do with this patch. > From: Gavin Hu (Arm Technology China) > > > > Hi Stephen, > > > > Thanks for your comment and sharing the link! > > W

Re: [dpdk-dev] [PATCH] eal: turn off getopt_long error messages

2018-12-19 Thread Thomas Monjalon
16/12/2018 17:45, Keith Wiles: > When using dpdk register option api when parsing for log level > the opterr flags was still set to one causing an error message > from getopt_long(). Set opterr to zero to disable error messages. Please could you be more specific? Which function call? Which error m

Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility

2018-12-19 Thread Thomas Monjalon
19/12/2018 10:09, Hunt, David: > On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > > 14/12/2018 14:11, Liang Ma: > >> Previously, in order to use the power library, it was necessary > >> for the user to disable the intel_pstate driver by adding > >> “intel_pstate=disable” to the kernel command line f

Re: [dpdk-dev] [PATCH] mk: fix scope of disabling AVX512F support

2018-12-19 Thread Thomas Monjalon
19/12/2018 21:20, Ferruh Yigit: > On 12/19/2018 7:58 PM, Thomas Monjalon wrote: > > 19/12/2018 20:29, Ferruh Yigit: > >> AVX512 was disabled for GCC because of Bugzilla issue 97 [1], > >> the GCC defect submitted for the issue [2] highlighted that this is > >> a known binutils version 2.30 issue. >

Re: [dpdk-dev] [PATCH] mk: fix scope of disabling AVX512F support

2018-12-19 Thread Ferruh Yigit
On 12/19/2018 7:58 PM, Thomas Monjalon wrote: > 19/12/2018 20:29, Ferruh Yigit: >> AVX512 was disabled for GCC because of Bugzilla issue 97 [1], >> the GCC defect submitted for the issue [2] highlighted that this is >> a known binutils version 2.30 issue. >> >> Narrowed the scope of no-avx512 to th

[dpdk-dev] [PATCH v3 2/4] crypto/aesni_mb: use architecture independent macros

2018-12-19 Thread Fan Zhang
This patch duplicates the original rte_aesni_mb_pmd*.c files and replaces the function calls provided by intel-ipsec-mb library into architecture-independent macros. The build systems are updated to choose compiling either rte_aesni_mb_pmd*.c or rte_aesni_mb_pmd*_compat.c based on the installed int

[dpdk-dev] [PATCH v3 4/4] doc: update deprecation notice

2018-12-19 Thread Fan Zhang
>From 19.05 the AESNI-MB PMD will not support the intel-ipsec-mb library version older than 0.52.0. Signed-off-by: Fan Zhang --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rs

[dpdk-dev] [PATCH v3 3/4] doc: update library support version

2018-12-19 Thread Fan Zhang
This patch updates the AESNI-MB PMD document with the new intel-ipsec-mb version number. Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/aesni_mb.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rs

[dpdk-dev] [PATCH v3 0/4] use architecure independent macros

2018-12-19 Thread Fan Zhang
This patch updates the aesni_mb to use IMB_* arch independent macros to reduce the code size and future maintaining effort. In intel-ipsec-mb library 0.52 all supported algorithms now have the IMB_* arch independent macros enabled. The macros help reducing the application's code size and remove th

[dpdk-dev] [PATCH v3 1/4] crypto/aesni_mb: rename files to compatible

2018-12-19 Thread Fan Zhang
This patch renames the rte_aesni_mb_pmd*.c to rte_aesni_mb_pmd*_compat.c to indicate those files are for compatible with older versoin of intel-ipsec-mb library only. Signed-off-by: Fan Zhang Signed-off-by: Lukasz Krakowiak Acked-by: Damian Nowak --- drivers/crypto/aesni_mb/Makefile

Re: [dpdk-dev] Eventdev DSW and eth_rx_adapters

2018-12-19 Thread Mattias Rönnblom
On 2018-12-19 19:37, Venky Venkatesh wrote: On 12/18/18, 10:53 PM, "Mattias Rönnblom" wrote: On 2018-12-18 02:46, Venky Venkatesh wrote: > Hi, > I am relatively new to DPDK and am trying to use the eventdev library. > The sw_evdev runs on a single core (service core). An

Re: [dpdk-dev] [PATCH] mk: fix scope of disabling AVX512F support

2018-12-19 Thread Thomas Monjalon
19/12/2018 20:29, Ferruh Yigit: > AVX512 was disabled for GCC because of Bugzilla issue 97 [1], > the GCC defect submitted for the issue [2] highlighted that this is > a known binutils version 2.30 issue. > > Narrowed the scope of no-avx512 to the this specific binutils version. [...] > # disable

Re: [dpdk-dev] [PATCH v2 0/2] Add 'try' semantics for RD and WR locking

2018-12-19 Thread Thomas Monjalon
19/12/2018 19:07, Konstantin Ananyev: > Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock() > and new UT test-case for it. > > v1 -> v2 > Changes per Honnappa and Gavin comments: > - remove cycle in rte_rwlock_write_trylock() > - remove static inline functions from .map file > -

[dpdk-dev] [PATCH] mk: fix scope of disabling AVX512F support

2018-12-19 Thread Ferruh Yigit
AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://g

Re: [dpdk-dev] [PATCH v2] timer: fix race condition

2018-12-19 Thread Thomas Monjalon
19/12/2018 17:09, Erik Gabriel Carrillo: > rte_timer_manage() adds expired timers to a "run list", and walks the > list, transitioning each timer from the PENDING to the RUNNING state. > If another lcore resets or stops the timer at precisely this > moment, the timer state would instead be set to C

[dpdk-dev] Eventdev DSW correctness and pathologies

2018-12-19 Thread Venky Venkatesh
Couple of questions on DSW scheduling: 1. how was the correctness of the scheduling verified -- specifically the fact that ATOMIC is not scheduled simultaneously to 2 cores? I can think of feeding the same flowid on all cores and see where the various cores are busy. Any other test cases tha

Re: [dpdk-dev] Eventdev DSW and eth_rx_adapters

2018-12-19 Thread Venky Venkatesh
On 12/18/18, 10:53 PM, "Mattias Rönnblom" wrote: On 2018-12-18 02:46, Venky Venkatesh wrote: > Hi, > I am relatively new to DPDK and am trying to use the eventdev library. > The sw_evdev runs on a single core (service core). And then there is rte_event_eth_rx_adapter_ which l

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bbdev: add missing APIs to map file and tag all experimental

2018-12-19 Thread Thomas Monjalon
19/12/2018 11:00, Amr Mokhtar: > - add missing APIs to map file > - add experimental tag to all bbdev APIs > > Signed-off-by: Amr Mokhtar Applied, thanks Please do not forget --in-reply-to when sending a v2.

Re: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Reshma Pattan > Sent: Wednesday, December 19, 2018 3:43 PM > To: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Rao, Nikhil > ; olivier.m...@6wind.com; > tho...@monjalon.net; Singh, Jasvinder ; > Dumitrescu, Cri

[dpdk-dev] [PATCH v2 0/2] Add 'try' semantics for RD and WR locking

2018-12-19 Thread Konstantin Ananyev
Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock() and new UT test-case for it. v1 -> v2 Changes per Honnappa and Gavin comments: - remove cycle in rte_rwlock_write_trylock() - remove static inline functions from .map file - update comments Konstantin Ananyev (2): rwlock: in

[dpdk-dev] [PATCH v2 2/2] test: add new test-cases for rwlock autotest

2018-12-19 Thread Konstantin Ananyev
Add few functional and perfomance tests for rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). Signed-off-by: Konstantin Ananyev Reviewed-by: Gavin Hu --- test/test/test_rwlock.c | 409 ++-- 1 file changed, 390 insertions(+), 19 deletions(-) diff --gi

[dpdk-dev] [PATCH v2 1/2] rwlock: introduce 'try' semantics for RD and WR locking

2018-12-19 Thread Konstantin Ananyev
Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). Signed-off-by: Konstantin Ananyev Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- .../common/include/generic/rte_rwlock.h | 56 +++ 1 file changed, 56 insertions(+) diff --git a/lib/librte_ea

Re: [dpdk-dev] [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK

2018-12-19 Thread Wiles, Keith
> On Dec 17, 2018, at 9:01 AM, Wiles, Keith wrote: > > > >> On Dec 17, 2018, at 5:45 AM, Thomas Monjalon wrote: >> >> Hi Keith, >> >> 16/12/2018 18:46, Keith Wiles: >>> DFS stands for DPDK Filesystem, which helps expose data >>> and control files in a FUSE based filesystem. The dfs require

Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done

2018-12-19 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, December 18, 2018 10:48 PM > To: Trahe, Fiona ; Stephen Hemminger > > Cc: dev@dpdk.org; akhil.go...@nxp.com; Jozwiak, TomaszX > ; Gupta, > Ashish ; Daly, Lee ; Luse, Paul E > > Subje

Re: [dpdk-dev] [PATCH v2] vhost: batch used descs chains write-back with packed ring

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 10:29:52AM +0100, Maxime Coquelin wrote: > Instead of writing back descriptors chains in order, let's > write the first chain flags last in order to improve batching. > > With Kernel's pktgen benchmark, ~3% performance gain is measured. > > Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH v2 4/4] net/cxgbe: fix other misc build issues for Windows

2018-12-19 Thread Rahul Lakkireddy
Fix following build errors reported by Intel C++ compiler in Windows build. C:\> t4_hw.c(5105): warning #147: declaration is incompatible with "int t4_bar2_sge_qregs(struct adapter *, unsigned int, unsigned int, u64={uint64_t={unsigned __int64}} *, unsigned int *)" (declared at line 524 of "..\..\

[dpdk-dev] [PATCH v2 3/4] net/cxgbe: only define symbols when not available

2018-12-19 Thread Rahul Lakkireddy
Define symbols only when they are not available. This fixes following types of issues reported by Intel C++ compiler in Windows build. C:\> cxgbe_compat.h(154): warning #47: incompatible redefinition of macro "min" #define min(a, b) RTE_MIN(a, b) ^ C:\> t4_hw.c(338): warn

[dpdk-dev] [PATCH v2 2/4] net/cxgbe: fix macros related to logs for Windows

2018-12-19 Thread Rahul Lakkireddy
Replace "args..." with "fmt, ..." and directly use __VA_ARGS__. This fixes following errors reported by Intel C++ compiler in Windows build. C:\> cxgbe_compat.h(28): error : expected a ")" #define dev_printf(level, fmt, args...) \ ^ C:\> cxgbe_compa

[dpdk-dev] [PATCH v2 1/4] net/cxgbe: use relative paths for including header files

2018-12-19 Thread Rahul Lakkireddy
The Intel C++ compiler is not able to locate the header files without relative paths in Windows build. Following errors are seen for these header files. C:\> base\common.h(9): error : cannot open source file "cxgbe_compat.h" #include "cxgbe_compat.h" ^ [...

[dpdk-dev] [PATCH v2 0/4] net/cxgbe: fix build for Microsoft Windows OS support

2018-12-19 Thread Rahul Lakkireddy
This series of patches fix compilation warning and errors seen while building CXGBE PMD in preparation for Microsoft Windows OS support. Patch 1 uses relative paths for including header files. Patch 2 fixes macros related to rte_log(). Patch 3 only redefines symbols when they are not available. Pa

Re: [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching

2018-12-19 Thread Ilya Maximets
On 19.12.2018 18:50, Michael S. Tsirkin wrote: > On Wed, Dec 19, 2018 at 09:21:09AM +0100, Maxime Coquelin wrote: >> This series adds missing read barriers after reading avail index >> for split ring and desc flags for packed ring. >> >> Also, it turns out that some descriptors prefetching are eith

Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking

2018-12-19 Thread Ananyev, Konstantin
> > > + * try to take a write lock. > > > + * > > > + * @param rwl > > > + * A pointer to a rwlock structure. > > > + * @return > > > + * - zero if the lock is successfully taken > > > + * - -EBUSY if lock could not be acquired for writing because > > > + * it was already locked for re

Re: [dpdk-dev] [PATCH 1/1] timer: fix race condition

2018-12-19 Thread Carrillo, Erik G
> > > However, if a timer expires quickly enough, there exists the > > > following race condition that causes the timer_manage() routine to > > > misinterpret a timer in CONFIG state, resulting in lost timers: > > > > > > - Thread A: > > > - starts a timer with rte_timer_reset() > > > - the tim

Re: [dpdk-dev] [PATCH] vhost: batch used descriptors chains write-back with packed ring

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 10:16:24AM +0100, Maxime Coquelin wrote: > > > On 12/12/18 7:53 PM, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 05:34:31PM +0100, Maxime Coquelin wrote: > > > Hi Ilya, > > > > > > On 12/12/18 4:23 PM, Ilya Maximets wrote: > > > > On 12.12.2018 11:24, Maxime Coqu

[dpdk-dev] [PATCH v2] timer: fix race condition

2018-12-19 Thread Erik Gabriel Carrillo
rte_timer_manage() adds expired timers to a "run list", and walks the list, transitioning each timer from the PENDING to the RUNNING state. If another lcore resets or stops the timer at precisely this moment, the timer state would instead be set to CONFIG by that other lcore, which would cause time

Re: [dpdk-dev] [PATCH v4 10/10] doc: add IPsec library guide

2018-12-19 Thread Akhil Goyal
On 12/14/2018 9:57 PM, Konstantin Ananyev wrote: > Add IPsec library guide and update release notes. > > Signed-off-by: Bernard Iremonger > Signed-off-by: Konstantin Ananyev > --- > doc/guides/prog_guide/index.rst| 1 + > doc/guides/prog_guide/ipsec_lib.rst| 74 +

Re: [dpdk-dev] [PATCH v4 09/10] test/ipsec: introduce functional test

2018-12-19 Thread Akhil Goyal
On 12/14/2018 9:53 PM, Konstantin Ananyev wrote: > +static struct unit_test_suite ipsec_testsuite = { > + .suite_name = "IPsec NULL Unit Test Suite", > + .setup = testsuite_setup, > + .teardown = testsuite_teardown, > + .unit_test_cases = { > + TEST_CASE_ST(ut_setup,

Re: [dpdk-dev] [PATCH v2 0/4] vhost: add missing barriers, move prefetching

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 09:21:09AM +0100, Maxime Coquelin wrote: > This series adds missing read barriers after reading avail index > for split ring and desc flags for packed ring. > > Also, it turns out that some descriptors prefetching are either > badly placed, or useless, last part of the seri

Re: [dpdk-dev] [PATCH v2 1/4] vhost: enforce avail index and desc read ordering

2018-12-19 Thread Maxime Coquelin
On 12/19/18 4:47 PM, Michael S. Tsirkin wrote: On Wed, Dec 19, 2018 at 09:21:10AM +0100, Maxime Coquelin wrote: A read barrier is required to ensure the ordering between available index and the descriptor reads is enforced. 1. read avail_head = avail->idx 2. read cur_idx = last_avail_idx if

Re: [dpdk-dev] [PATCH v2 4/4] vhost: remove useless prefetch for packed ring descriptor

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 09:21:13AM +0100, Maxime Coquelin wrote: > This prefetch does not show any performance improvement. > > Signed-off-by: Maxime Coquelin Likely because of the RMB. Try prefetching the *next* descriptor maybe? > --- > lib/librte_vhost/virtio_net.c | 2 -- > 1 file changed,

[dpdk-dev] [PATCH v5 3/3] doc: update ISA-L guide to reflect checksum support

2018-12-19 Thread Lee Daly
This updates the ISA-L compression driver guide on how to enable and use checksums and release notes. Signed-off-by: Lee Daly Acked-by: Fiona Trahe --- doc/guides/compressdevs/features/isal.ini | 2 ++ doc/guides/compressdevs/isal.rst | 30 -- doc/guides/re

[dpdk-dev] [PATCH v5 2/3] test/compress: add checksum tests

2018-12-19 Thread Lee Daly
This patch adds a test which examines what type of checksum the PMD supports, adler, crc32 or alder32_crc32 and tests that feature if the PMD supports it. V2: Documentation Changes V3: Added Release note V4: Removed dependency on offset unit test V5: If checksum type is incorrect, compression will

[dpdk-dev] [PATCH v5 1/3] compress/isal: enable checksum support in driver

2018-12-19 Thread Lee Daly
This patch adds checksum support in the ISA-L PMD for both compression and decompression. CRC32 is supported as well as Adler32. V2: Documentation Changes V3: Added Release note V4: Removed dependency on offset unit test V5: If checksum type is incorrect, compression will continue without checksu

Re: [dpdk-dev] [PATCH v2 1/4] vhost: enforce avail index and desc read ordering

2018-12-19 Thread Michael S. Tsirkin
On Wed, Dec 19, 2018 at 09:21:10AM +0100, Maxime Coquelin wrote: > A read barrier is required to ensure the ordering between > available index and the descriptor reads is enforced. > > 1. read avail_head = avail->idx > 2. read cur_idx = last_avail_idx > if (cur_idx != avail_head) { > 3. read i

Re: [dpdk-dev] [PATCH v4 08/10] ipsec: helper functions to group completed crypto-ops

2018-12-19 Thread Akhil Goyal
On 12/14/2018 9:53 PM, Konstantin Ananyev wrote: > Introduce helper functions to process completed crypto-ops > and group related packets by sessions they belong to. > > Signed-off-by: Konstantin Ananyev > Acked-by: Declan Doherty > --- > lib/librte_ipsec/Makefile | 1 + > lib

[dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-19 Thread Reshma Pattan
This patch implements the changes proposed in the deprecation notes [1][2]. librte_mbuf changes: The mbuf::hash::sched field is updated to support generic definition in line with the ethdev TM and MTR APIs. The new generic format contains: queue ID, traffic class, color. Added public APIs to set

[dpdk-dev] [PATCH v6 1/2] meter: add new rte color definition

2018-12-19 Thread Reshma Pattan
Added new rte_color definition in librte_meter to consolidate color definition which is currently replicated in various places such as rte_meter.h, rte_tm.h and rte_mtr.h Created aliases for rte_tm_color, rte_mtr_color and rte_meter_color to use new rte_color values. The definitions of rte_tm_col

[dpdk-dev] [PATCH v5 1/2] meter: add new rte color definition

2018-12-19 Thread Reshma Pattan
Added new rte_color definition in librte_meter to consolidate color definition which is currently replicated in various places such as rte_meter.h, rte_tm.h and rte_mtr.h Created aliases for rte_tm_color, rte_mtr_color and rte_meter_color to use new rte_color values. The definitions of rte_tm_col

[dpdk-dev] [PATCH v5 2/2] mbuf: implement generic format for sched field

2018-12-19 Thread Reshma Pattan
This patch implements the changes proposed in the deprecation notes [1][2]. librte_mbuf changes: The mbuf::hash::sched field is updated to support generic definition in line with the ethdev TM and MTR APIs. The new generic format contains: queue ID, traffic class, color. Added public APIs to set

Re: [dpdk-dev] [PATCH v4 06/10] ipsec: implement SA data-path API

2018-12-19 Thread Akhil Goyal
On 12/14/2018 9:53 PM, Konstantin Ananyev wrote: > Provide implementation for rte_ipsec_pkt_crypto_prepare() and > rte_ipsec_pkt_process(). > Current implementation: > - supports ESP protocol tunnel mode. > - supports ESP protocol transport mode. > - supports ESN and replay window. > - su

Re: [dpdk-dev] [PATCH 1/2] rwlock: introduce 'try' semantics for RD and WR locking

2018-12-19 Thread Honnappa Nagarahalli
> > > > > This patch targets 19.02 release. > > > > Introduce rte_rwlock_read_trylock() and rte_rwlock_write_trylock(). > > Signed-off-by: Konstantin Ananyev > > --- > > .../common/include/generic/rte_rwlock.h | 54 +++ > > lib/librte_eal/rte_eal_version.map| 2

  1   2   >