Re: [dpdk-dev] [PATCH v3 5/9] ipsec: add SA data-path API

> -Original Message- > From: Doherty, Declan > Sent: Tuesday, December 11, 2018 5:26 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Awal, Mohammad Abdul > Subject: Re: [dpdk-dev] [PATCH v3 5/9] ipsec: add SA data-path API > > On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: > > Intro

[dpdk-dev] [PATCH v3 34/34] net/ice: support meson build

Signed-off-by: Wenzhuo Lu --- drivers/net/ice/base/meson.build | 30 ++ drivers/net/ice/meson.build | 15 +++ drivers/net/meson.build | 1 + 3 files changed, 46 insertions(+) create mode 100644 drivers/net/ice/base/meson.build create mode 1

[dpdk-dev] [PATCH v3 32/34] net/ice: support descriptor ops

Add below ops, rx_descriptor_done rx_descriptor_status tx_descriptor_status Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 3 ++ drivers/net/ice/ice_lan_rxtx.c | 84 +++

[dpdk-dev] [PATCH v3 33/34] doc: add ICE description and update release note

Signed-off-by: Wenzhuo Lu --- MAINTAINERS| 1 + doc/guides/nics/features/ice.ini | 38 + doc/guides/nics/ice.rst| 101 + doc/guides/rel_notes/release_19_02.rst | 4 ++ 4 files changed, 144 insertion

[dpdk-dev] [PATCH v3 31/34] net/ice: support advance RX/TX

Add RX functions, scatter and bulk. Add TX function, simple. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_lan_rxtx.c | 660 - 1 file changed, 658 insertions(+), 2 delet

[dpdk-dev] [PATCH v3 28/34] net/ice: support statistics

Add below ops, stats_get stats_reset xstats_get xstats_get_names xstats_reset Signed-off-by: Wenzhuo Lu Signed-off-by: Jia Guo --- drivers/net/ice/ice_ethdev.c | 566 +++ 1 file changed, 566 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drive

[dpdk-dev] [PATCH v3 29/34] net/ice: support queue information getting

Add below ops, rxq_info_get txq_info_get rx_queue_count Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 3 ++ drivers/net/ice/ice_lan_rxtx.c | 66 ++ drivers

[dpdk-dev] [PATCH v3 30/34] net/ice: support basic RX/TX

Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 5 + drivers/net/ice/ice_lan_rxtx.c | 568 - drivers/net/ice/ice_rxtx.h | 8 + 3 files changed, 579 ins

[dpdk-dev] [PATCH v3 27/34] net/ice: support EEPROM information getting

Add below ops, get_eeprom_length get_eeprom Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 45 1 file changed, 45 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index aae2

[dpdk-dev] [PATCH v3 25/34] net/ice: support RX queue interruption

Add below ops, rx_queue_intr_enable rx_queue_intr_disable Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 230 +++ 1 file changed, 230 insertions(+) diff --git

[dpdk-dev] [PATCH v3 22/34] net/ice: support MAC ops

Add below ops, mac_addr_set mac_addr_add mac_addr_remove Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 233 +++ 1 file changed, 233 insertions(+) diff --git

[dpdk-dev] [PATCH v3 21/34] net/ice: support MTU setting

Add ops mtu_set. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ic

[dpdk-dev] [PATCH v3 26/34] net/ice: support FW version getting

Add ops fw_version_get. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethd

[dpdk-dev] [PATCH v3 24/34] net/ice: support RSS

Add below ops, reta_update reta_query rss_hash_update rss_hash_conf_get Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 242 +++ 1 file changed, 242 insertions(

[dpdk-dev] [PATCH v3 23/34] net/ice: support VLAN ops

Add below ops, ice_vlan_filter_set ice_vlan_offload_set ice_vlan_tpid_set ice_vlan_pvid_set Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 590 +++ 1 file chan

[dpdk-dev] [PATCH v3 20/34] net/ice: support link update

Add ops link_update. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 332 +++ 1 file changed, 332 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/dri

[dpdk-dev] [PATCH v3 19/34] net/ice: support packet type getting

Add ops dev_supported_ptypes_get. Signed-off-by: Wei Zhao Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_ethdev.c | 2 + drivers/net/ice/ice_lan_rxtx.c | 601 + drivers/net/ice/ice_rxtx.h | 2 + 3 files changed, 605 insertions(+) diff --git

[dpdk-dev] [PATCH v3 17/34] net/ice: support device and queue ops

Normally when starting/stopping the device the queue should be started and stopped. Support them both in this patch. Below ops are added, dev_configure dev_start dev_stop dev_close dev_reset rx_queue_start rx_queue_stop tx_queue_start tx_queue_stop rx_queue_setup rx_queue_release tx_queue_setup tx

[dpdk-dev] [PATCH v3 18/34] net/ice: support getting device information

Add ops dev_infos_get. Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- drivers/net/ice/ice_ethdev.c | 123 +++ 1 file changed, 123 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/d

[dpdk-dev] [PATCH v3 16/34] net/ice: support device initialization

Signed-off-by: Wenzhuo Lu Signed-off-by: Qiming Yang Signed-off-by: Xiaoyun Li Signed-off-by: Jingjing Wu --- config/common_base | 9 + drivers/net/Makefile| 1 + drivers/net/ice/Makefile| 75 drivers/net/ice/ice_ethdev.c

[dpdk-dev] [PATCH v3 15/34] net/ice: add OS specific implementation

Add some MACRO defination and small functions which are specific for DPDK. Add readme too. Signed-off-by: Wenzhuo Lu --- drivers/net/ice/base/README | 22 ++ drivers/net/ice/base/ice_osdep.h | 524 +++ 2 files changed, 546 insertions(+) create mode 1006

[dpdk-dev] [PATCH v3 14/34] net/ice: Add structures for RX/TX queues

From: Paul M Stillwell Jr Add the structures that define how the RX/TX queues are used. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_lan_tx_rx.h | 2291 ++ 1 file changed, 2291 insertions(+) create mode 100644 drivers/net/ice/base/ice_lan_tx_

[dpdk-dev] [PATCH v3 12/34] net/ice: Add various headers

From: Paul M Stillwell Jr Add various headers that define status codes and basic defines for use in the code. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_alloc.h | 22 ++ drivers/net/ice/base/ice_flex_type.h | 19 +++ drivers/net/ice/base/ice

[dpdk-dev] [PATCH v3 13/34] net/ice: Add protocol structures and defines

From: Paul M Stillwell Jr Add the structures and defines that define what protocols the NIC can handle. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_protocol_type.h | 248 +++ 1 file changed, 248 insertions(+) create mode 100644 drivers/net/ice/b

[dpdk-dev] [PATCH v3 11/34] net/ice: Add common functions

From: Paul M Stillwell Jr Add code that multiple other features use. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_common.c | 3521 + drivers/net/ice/base/ice_common.h | 186 ++ 2 files changed, 3707 insertions(+) create mode 100644 drive

[dpdk-dev] [PATCH v3 09/34] net/ice: Add virtual switch code

From: Paul M Stillwell Jr Add code to handle the virtual switch within the NIC. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_switch.c | 2812 + drivers/net/ice/base/ice_switch.h | 333 + 2 files changed, 3145 insertions(+) create mod

[dpdk-dev] [PATCH v3 10/34] net/ice: Add code to work with the NVM

From: Paul M Stillwell Jr Add code to read/write/query the NVM image. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_nvm.c | 387 + 1 file changed, 387 insertions(+) create mode 100644 drivers/net/ice/base/ice_nvm.c diff --git a/driver

[dpdk-dev] [PATCH v3 07/34] net/ice: Add data center bridging (DCB)

From: Paul M Stillwell Jr Add the code to handle DCB. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_dcb.c | 1385 drivers/net/ice/base/ice_dcb.h | 220 +++ 2 files changed, 1605 insertions(+) create mode 100644 drivers/net/ice/ba

[dpdk-dev] [PATCH v3 04/34] net/ice: Add sideband queue info

From: Paul M Stillwell Jr Add the commands, error codes, and structures for the sideband queue. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_sbq_cmd.h | 93 ++ 1 file changed, 93 insertions(+) create mode 100644 drivers/net/ice/base/ice_s

[dpdk-dev] [PATCH v3 05/34] net/ice: Add device IDs for Intel(r) E800 Series NICs

From: Paul M Stillwell Jr Add all the device IDs that represent the NIC. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_devids.h | 17 + 1 file changed, 17 insertions(+) create mode 100644 drivers/net/ice/base/ice_devids.h diff --git a/drivers/net/ice/base/ic

[dpdk-dev] [PATCH v3 06/34] net/ice: Add control queue information

From: Paul M Stillwell Jr Add the structures for the control queues. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_controlq.c | 1098 +++ drivers/net/ice/base/ice_controlq.h | 97 2 files changed, 1195 insertions(+) create mode 100644 d

[dpdk-dev] [PATCH v3 03/34] net/ice: Add admin queue structures and commands

From: Paul M Stillwell Jr Add the commands, error codes, and structures for the admin queue. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_adminq_cmd.h | 1891 + 1 file changed, 1891 insertions(+) create mode 100644 drivers/net/ice/base/ice_ad

[dpdk-dev] [PATCH v3 02/34] net/ice: Add basic structures

From: Paul M Stillwell Jr Add the structures required by the NIC. Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/base/ice_type.h | 869 1 file changed, 869 insertions(+) create mode 100644 drivers/net/ice/base/ice_type.h diff --git a/drivers/n

[dpdk-dev] [PATCH v3 00/34] A new net PMD - ice

This patch set adds the support of a new net PMD, Intel® Ethernet Network Adapters E810, also called ice. Besides enabling this new NIC, also some other features supported on this NIC. Like below, Basic features: 1, Basic device operations: probe, initialization, start/stop, configure, info get.

Re: [dpdk-dev] [PATCH 6/9] net/ifc: add devarg for LM mode

Hi, > -Original Message- > From: Bie, Tiwei > Sent: Monday, December 3, 2018 10:32 PM > To: Wang, Xiao W > Cc: maxime.coque...@redhat.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH 6/9] net/ifc: add devarg for LM mode > > On Wed, Nov 28, 2018 at 05:46:04PM +0800

Re: [dpdk-dev] [PATCH 2/9] vhost: provide helpers for virtio ring relay

Hi, > -Original Message- > From: Bie, Tiwei > Sent: Monday, December 3, 2018 10:23 PM > To: Wang, Xiao W > Cc: maxime.coque...@redhat.com; dev@dpdk.org; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH 2/9] vhost: provide helpers for virtio ring relay > > On Wed, Nov 28, 2018 at 05:

[dpdk-dev] [PATCH v2 1/2] ring: add reset api to flush the ring when not in use

Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_ring/rte_ring.h | 20 ++

[dpdk-dev] [PATCH v2 2/2] hash: flush the rings instead of dequeuing one by one

Within rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles. Fixes: b26473ff8f4a ("hash: add reset function") Fixes: 75706568a7eb ("hash: add extendable b

[dpdk-dev] [PATCH v2 0/2] add rte ring reset api and use it to flush a ring by hash

V2: fix the coding style issue(commit message line too long) V1: To flush a ring not in use, dequeue one by one is wasting cpu cycles. The patch is to just resetting the head and tail indices to save cpu cycle. Gavin Hu (2): ring: add reset api to flush the ring when not in use hash: flush th

[dpdk-dev] [PATCH v1 2/2] hash: flush the rings instead of dequeuing one by one

Within rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles. Fixes: b26473ff8f4a ("hash: add reset function") Fixes: 75706568a7eb ("hash: add extendable b

[dpdk-dev] [PATCH v1 0/2] add rte_ring_reset and use it to flush a ring

To flush a ring not in use, dequeue one by one is wasting cpu cycles. The patch is to just resetting the head and tail indices to save cpu cycle. Gavin Hu (2): ring: add rte_ring_reset api to flush the ring hash: flush the rings instead of dequeuing one by one lib/librte_hash/Makefile

[dpdk-dev] [PATCH v1 1/2] ring: add rte_ring_reset api to flush the ring

Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_ring/rte_ring.h | 20 ++

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: revert fix offload not supported mask

On 12/11, Ferruh Yigit wrote: >On 12/11/2018 5:25 PM, Didier Pallard wrote: >> This reverts >> commit 09a62d75691f ("net/i40e: fix offload not supported mask") >> >> Contrary to what is said in above patch commit log, >> I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part >> o

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: revert fix offload not supported mask

> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 12, 2018 6:01 AM > To: Didier Pallard ; dev@dpdk.org > Cc: sta...@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Xing, Beilei > Subject: Re: [dpdk-stable] [PATCH] net/i40e: revert fix offload not supported > mask > > On 12

Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

> -Original Message- > From: Hyong Youb Kim > Sent: Tuesday, December 11, 2018 10:56 PM > To: Varghese, Vipin > Cc: Yigit, Ferruh ; dev@dpdk.org; John Daley > > Subject: Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic > > On Tue, Dec 11, 2018 at 04:49:26PM +, Varghe

Re: [dpdk-dev] [PATCH v2 3/3] doc: update ISA-L guide to reflect checksum support

> -Original Message- > From: Daly, Lee > Sent: Wednesday, November 28, 2018 3:42 AM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH v2 3/3] doc: update ISA-L guide to reflect checksum support > > This updates the ISA-L compression driver guide o

Re: [dpdk-dev] [PATCH v2 2/3] test/compress: add checksum tests

> -Original Message- > From: Daly, Lee > Sent: Wednesday, November 28, 2018 3:42 AM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH v2 2/3] test/compress: add checksum tests > > This patch adds a test which examines what type of checksum the PMD

Re: [dpdk-dev] [PATCH v2 1/3] compress/isal: enable checksum support in driver

> -Original Message- > From: Daly, Lee > Sent: Wednesday, November 28, 2018 3:42 AM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH v2 1/3] compress/isal: enable checksum support in driver > > This patch adds checksum support in the ISA-L PMD f

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: revert fix offload not supported mask

On 12/11/2018 5:25 PM, Didier Pallard wrote: > This reverts > commit 09a62d75691f ("net/i40e: fix offload not supported mask") > > Contrary to what is said in above patch commit log, > I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part > of PKT_TX_OFFLOAD_MASK but not include

Re: [dpdk-dev] [PATCH v2 1/3] mbuf: implement generic format for sched field

> -Original Message- > From: Pattan, Reshma > Sent: Friday, December 7, 2018 2:32 PM > To: dev@dpdk.org; Dumitrescu, Cristian ; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Cc: Pattan, Reshma > Subject: [PATCH v2 1/3] mbuf: implement generic format for sched field > > This p

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix bracket

On 12/11/18 4:09 PM, Fan Zhang wrote: This patch fixes a missed bracket bug in the code. Fixes: e1d90eaa83ff ("examples/vhost_crypto: fix zero copy") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- examples/vhost_crypto/main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(

Re: [dpdk-dev] [PATCH] vhost: fix double read of descriptor flags

On 12/5/18 4:09 PM, Ilya Maximets wrote: Flags could be updated in a separate process leading to the inconsistent check. Additionally, read marked as 'volatile' to highlight the shared nature of the variable and avoid such issues in the future. Fixes: d3211c98c456 ("vhost: add helpers for pa

Re: [dpdk-dev] [PATCH] net/virtio: move bytes accounting to common function

On 12/3/18 5:20 PM, Ilya Maximets wrote: There is no need to count 'bytes' separately. Signed-off-by: Ilya Maximets --- drivers/net/virtio/virtio_rxtx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Applied to dpdk-next-virtio. Thanks, Maxime

Re: [dpdk-dev] [PATCH] net/virtio: allocate vrings on device NUMA node

On 11/27/18 11:54 AM, Maxime Coquelin wrote: When a guest is spanned on multiple NUMA nodes and multiple Virtio devices are spanned onto these nodes, we expect that their ring memory is allocated in the right memory node. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.

Re: [dpdk-dev] [PATCH v2] vhost: fix possible null pointer dereferencing

On 11/27/18 11:30 AM, Jens Freimann wrote: On Tue, Nov 27, 2018 at 10:54:51AM +0100, Maxime Coquelin wrote: If mmap() call fails in vhost_user_set_mem_table, dev->mem is set to NULL. If later, qva_to_vva() is called, a segfault occurs. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: st

Re: [dpdk-dev] [PATCH] ethdev: add siblings iterator

11/12/2018 17:31, Ferruh Yigit: > On 11/30/2018 12:27 AM, Thomas Monjalon wrote: > > If multiple ports share the same hardware device (rte_device), > > they are siblings and can be found thanks to the new function > > and loop macro. > > > > The ownership is not checked because siblings may have >

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix bracket

On 12/11/18 4:09 PM, Fan Zhang wrote: This patch fixes a missed bracket bug in the code. Fixes: e1d90eaa83ff ("examples/vhost_crypto: fix zero copy") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- examples/vhost_crypto/main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(

Re: [dpdk-dev] [PATCH] vhost: fix race condition in fdset_add

Hi Matthias, On 12/6/18 5:00 PM, Matthias Gatto wrote: fdset_add can call fdset_shrink_nolock which call fdset_move concurrently to poll that is call in fdset_event_dispatch. This patch add a mutex to protect poll from been call at the same time fdset_add call fdset_shrink_nolock. Signed-off-b

[dpdk-dev] [PATCH 5/6] testpmd: use library implementation of 64-bit log2

Remove duplicated code and use library version of 64-bit log2. Signed-off-by: Anatoly Burakov --- app/test-pmd/testpmd.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4c75587d0..0c75e123b 100644 --- a/a

[dpdk-dev] [PATCH 6/6] test/common: extend autotest to newly added functions

Add a new autotest for bsf32, bsf64, bsf32_safe and bsf64_safe functions, and extend existing fls and log2 autotests to also cover 64-bit versions. Signed-off-by: Anatoly Burakov --- test/test/test_common.c | 82 +++-- 1 file changed, 79 insertions(+), 3 delet

[dpdk-dev] [PATCH 2/6] common: add bsf64 function similar to existing bsf32

Implement a new rte_bsf64 function that is following convention set by existing rte_bsf32 function. Also, document the change in release notes. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_19_02.rst | 4 +++- lib/librte_eal/common/include/rte_common.h | 19 +++

[dpdk-dev] [PATCH 1/6] bitmap: remove deprecated bsf64 function

The function rte_bsf64 was deprecated in a previous release, so remove the function, and the deprecation notice associated with it. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_19_02.rst | 4 lib/librte_eal/common/

[dpdk-dev] [PATCH 3/6] common: add missing implementations

Implement missing functions for 32-bit safe bsf, as well as 64-bit fls and log2. Signed-off-by: Anatoly Burakov --- Notes: v4: - Fixed to use proper rte_bsf64 v3: - Added clarification that pos is not checked lib/librte_eal/common/include/rte_common.h | 62

[dpdk-dev] [PATCH 4/6] memalloc: use library implementation of 64-bit log2

Remove duplicated code and use library version of 64-bit log2. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_memalloc.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp

Re: [dpdk-dev] [PATCH] doc: remove redundant "OF" prefix from testpmd doc

On 12/6/2018 12:18 PM, Rahul Lakkireddy wrote: > On Thursday, December 12/06/18, 2018 at 17:36:14 +0530, Dekel Peled wrote: >> testpmd actions set_tp_src and set_tp_dst documentation adds the >> of_ prefix to action names, while the implementation doesn't add it. >> >> This patch removes the prefix

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: fix a typo in testpmd guide

On 12/5/2018 5:05 PM, Rami Rosen wrote: > Signed-off-by: Rami Rosen > Acked-by: Bernard Iremonger > > Acked-by: Marko Kovacevic Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoGRE encapsulation

On 12/6/2018 9:38 AM, Ori Kam wrote: <...> Subject: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoGRE encapsulation In function cmd_set_mplsogre_encap_parsed(), MPLS label value was set in mplsogre_encap_conf struct without the required offset. As a result the value was copied

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix MPLSoUDP encapsulation

On 12/6/2018 9:38 AM, Ori Kam wrote: <...> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix MPLSoUDP encapsulation In function cmd_set_mplsoudp_encap_parsed(), MPLS label value was set in mplsoudp_encap_conf struct without the required offset. As a result the value was copi

Re: [dpdk-dev] [PATCH v3 5/9] ipsec: add SA data-path API

On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authentic

[dpdk-dev] [PATCH] net/i40e: revert fix offload not supported mask

This reverts commit 09a62d75691f ("net/i40e: fix offload not supported mask") Contrary to what is said in above patch commit log, I40E_TX_OFFLOAD_NOTSUP_MASK is the mask of Tx offload bits that are part of PKT_TX_OFFLOAD_MASK but not included in I40E_TX_OFFLOAD_MASK. Above patch erroneously includ

Re: [dpdk-dev] [PATCH v3 4/9] lib: introduce ipsec library

On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Associati

Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

On Tue, Dec 11, 2018 at 04:49:26PM +, Varghese, Vipin wrote: > snipped [...] > > Apologies if the question was not clear, Let me try again 'Is there plan add > test cases under dpdk/test/test folder?' Not in this cycle. Thanks. -Hyong

Re: [dpdk-dev] [PATCH v3 3/9] net: add ESP trailer structure definition

On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1

Re: [dpdk-dev] [PATCH v3 2/9] security: add opaque userdata pointer into security session

On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Mohammad Abdul Awal --- lib/librte_security/rte_sec

Re: [dpdk-dev] [PATCH v3 1/9] cryptodev: add opaque userdata pointer into crypto sym session

On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev Acked-by: Fiona Trahe Acked-by: Mohammad Abdul Awal ---

Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

snipped > > Hi Hyong, > > > > snipped > > > > Hi Hyong, > > > > > > > > Thanks for sharing the information a query 'is ENIC Poll Mode > > > > Driver is been > > > updated too?'(Section 16 under Network Interface Controller). > > > > a. If yes is it ok to link the patchwork in comment section? > > >

[dpdk-dev] [PATCH v2] malloc: fix duplicate mem event notification

We already trigger a mem event notification inside the walk function, no need to do it twice. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: - Fixed code style lib/librte_eal/common/rte_mallo

[dpdk-dev] [PATCH v2 2/5] memalloc: check for memfd support in segment fd API

If memfd support was not compiled, or hugepage memfd support is not available at runtime, the API will now return proper error code, indicating that this API is unsupported. This changes the API, so document the changes. Fixes: 41dbdb68723b ("mem: add external API to retrieve page fd") Fixes: 3a44

[dpdk-dev] [PATCH v2 4/5] mem: use memfd for no-huge mode

When running in no-huge mode, we anonymously allocate our memory. While this works for regular NICs and vdev's, it's not suitable for memory sharing scenarios such as virtio with vhost_user backend. To fix this, allocate no-huge memory using memfd, and register it with memalloc just like any other

[dpdk-dev] [PATCH v2 1/5] mem: fix error code for segment fd API for external segs

Segment fd API does not support getting segment fd's from externally allocated memory, so return proper error code on any attempts to do so. This changes API behavior, so document the change as well. Fixes: 5282bb1c3695 ("mem: allow memseg lists to be marked as external") Cc: sta...@dpdk.org Sign

[dpdk-dev] [PATCH v2 5/5] test: add segment fd API test

Use memory autotest to also test segment fd API. This will not do any checks - just see if the relevant API's return success or indicate that the API is not supported. Signed-off-by: Anatoly Burakov --- test/test/test_memory.c | 43 + 1 file changed, 43 in

[dpdk-dev] [PATCH v2 0/5] Allow using virtio without hugepages

It is already possible to use both DPDK in general and virtio specifically, without hugetlbfs mounts, but currently virtio cannot be used without hugepage memory (i.e. with a --no-huge EAL switch) due to the fact that it needs to share memory with the backend. This patchset uses memfd to create ac

[dpdk-dev] [PATCH v2 3/5] memalloc: allow setting up segment list fd's

Currently, only segment fd's for multi-file segments are supported, while for memfd-backed no-huge memory we need single-file segments mode. Add support for single-file segments in the internal API. Signed-off-by: Anatoly Burakov --- Notes: v2: - Add missing fd list allocation on setting

Re: [dpdk-dev] [PATCH] librte_ethdev: Fix typo in error message of invalid nb_rx_desc or nb_tx_desc

On 12/3/2018 9:54 AM, Yaroslav Brustinov wrote: > Signed-off-by: Yaroslav Brustinov Updated commit log as following: ethdev: fix typo in error message in queue setup '=' should be '>=" for '[rt]x_desc_lim.nb_min' check. Fixes: 386c993e95f1 ("ethdev: add a missing sanity check for Tx

Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

On Tue, Dec 11, 2018 at 04:31:50PM +, Varghese, Vipin wrote: > Hi Hyong, > > snipped > > > Hi Hyong, > > > > > > Thanks for sharing the information a query 'is ENIC Poll Mode Driver is > > > been > > updated too?'(Section 16 under Network Interface Controller). > > > a. If yes is it ok to lin

Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

Hi Hyong, snipped > > Hi Hyong, > > > > Thanks for sharing the information a query 'is ENIC Poll Mode Driver is been > updated too?'(Section 16 under Network Interface Controller). > > a. If yes is it ok to link the patchwork in comment section? > > b. If no, will you be updating the documentation

Re: [dpdk-dev] [PATCH] ethdev: add siblings iterator

On 11/30/2018 12:27 AM, Thomas Monjalon wrote: > If multiple ports share the same hardware device (rte_device), > they are siblings and can be found thanks to the new function > and loop macro. > > The ownership is not checked because siblings may have > different owners. Looks good on its own, b

[dpdk-dev] [Bug 164] configure rx queue for JUMBO frame returns warning as offload is 0x0, but eth_pcap_rx_jumbo is present

https://bugs.dpdk.org/show_bug.cgi?id=164 Bug ID: 164 Summary: configure rx queue for JUMBO frame returns warning as offload is 0x0, but eth_pcap_rx_jumbo is present Product: DPDK Version: 18.11 Hardware: All

Re: [dpdk-dev] [PATCH 4/4] doc: update release notes for enic

On Tue, Dec 11, 2018 at 02:44:43AM +, Varghese, Vipin wrote: > Hi Hyong, > > Thanks for sharing the information a query 'is ENIC Poll Mode Driver is been > updated too?'(Section 16 under Network Interface Controller). > a. If yes is it ok to link the patchwork in comment section? > b. If no

Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: code refactory for macswap

On 12/11/2018 5:55 AM, Qi Zhang wrote: > Move macswap workload to dedicate function, so we can further enable > platform specific optimized version. > > Signed-off-by: Qi Zhang <...> > +} > + > +#endif /* _BPF_CMD_H_ */ Comment is remaining from copy-pate, there are a few more in the patchset.

[dpdk-dev] [PATCH] examples/vhost_crypto: fix bracket

This patch fixes a missed bracket bug in the code. Fixes: e1d90eaa83ff ("examples/vhost_crypto: fix zero copy") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- examples/vhost_crypto/main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/examples/vhost_crypto/main.c

Re: [dpdk-dev] [PATCH v2 3/3] doc: add deprecation notice to remove rte meter color

> -Original Message- > From: Pattan, Reshma > Sent: Friday, December 7, 2018 2:32 PM > To: dev@dpdk.org; Dumitrescu, Cristian ; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Cc: Pattan, Reshma > Subject: [PATCH v2 3/3] doc: add deprecation notice to remove rte meter > color >

Re: [dpdk-dev] [PATCH] vhost: fix double read of descriptor flags

On 12/5/18 4:09 PM, Ilya Maximets wrote: Flags could be updated in a separate process leading to the inconsistent check. Additionally, read marked as 'volatile' to highlight the shared nature of the variable and avoid such issues in the future. Fixes: d3211c98c456 ("vhost: add helpers for pa

Re: [dpdk-dev] [1/5] vhost: enforce avail index and desc read ordering

On 12/11/18 11:38 AM, Ilya Maximets wrote: On 05.12.2018 12:49, Maxime Coquelin wrote: A read barrier is required to ensure the ordering between available index and the descriptor reads is enforced. Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application") Cc: sta...@dpdk.or

Re: [dpdk-dev] Flow Director vs. 5-tuple filters on a 10GbE Intel 82599 ES NIC

?CC-ing maintainers. De : Georgios Katsikas Envoyé : mardi 4 décembre 2018 11:41 À : dev@dpdk.org Cc : Tom Barbette Objet : Flow Director vs. 5-tuple filters on a 10GbE Intel 82599 ES NIC Dear all, I am performing rule installation/deletion benchmarks on a dual

[dpdk-dev] [PATCH v2] crypto/aesni_mb: add gmac support

This patch adds AES-GMAC authentication only support to AESNI-MB PMD. The unit test is updated accordingly. Signed-off-by: Fan Zhang --- v2: - updated documentation doc/guides/cryptodevs/aesni_mb.rst | 3 + drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 127 +++--

[dpdk-dev] [PATCH] doc: fix aesni mb documentation.

This patch fixes the incorrect intel multi buffer library support version and missed limitation of GCM algorithm support. Fixes: 0e9f8507afcb ("crypto/aesni_mb: support AES-GCM algorithm") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/aesni_mb.rst | 6 -- 1 file cha

[dpdk-dev] [PATCH v2 0/3] net/virtio: Rx paths improvements

Initial version of this series did merge out-of-order mergeable and non-mergeable receive paths, but Intel STV team highlighted some performance regression when using multiqueue with two cores enqueueing descs on host, while a single core dequeues the two queues. I didn't manage to close the perfo

[dpdk-dev] [PATCH v2 1/3] net/virtio: inline refill and offload helpers

Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index eb891433e..e1c270b1c 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/driver

[dpdk-dev] [PATCH v2 3/3] net/virtio: improve batching in mergeable path

This patch improves both descriptors dequeue and refill, by using the same bathing strategy as done in in-order path. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 237 --- 1 file changed, 126 insertions(+), 111 deletions(-) diff --git a/drive

  1   2   >