Re: [dpdk-dev] [dpdk-stable] [PATCH v1] devargs: fix variadic parsing memory leak

2018-10-24 Thread Thomas Monjalon
17/10/2018 16:30, Gaetan Rivet: > rte_devargs_parsef will leak memory each time it is called. > The device string must be freed. > > Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function") > CC: sta...@dpdk.org > Signed-off-by: Gaetan Rivet Applied, thanks

[dpdk-dev] [PATCH v5 5/5] test: add dump test cases under debug-tests suite

2018-10-24 Thread Hari Kumar Vemula
From: Hari Kumar Vemula Grouped logging or dump related test cases to test debug category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index dd54800dd..c5b10e153

[dpdk-dev] [PATCH v5 4/5] test: add driver dependent tests under driver-tests suite

2018-10-24 Thread Hari Kumar Vemula
From: Hari Kumar Vemula Added test cases that depend on specific drivers Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 27 +++ 1 file changed, 27 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 217e4d3de..dd54800dd 100644 -

[dpdk-dev] [PATCH v5 3/5] test: add performance tests under perf-tests suite

2018-10-24 Thread Hari Kumar Vemula
From: Hari Kumar Vemula Grouped performace test cases under perf tests category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index b59c87493..217e

[dpdk-dev] [PATCH v5 1/5] test: remove existing testcases for categorization

2018-10-24 Thread Hari Kumar Vemula
From: Hari Kumar Vemula Removed testcase list from meson build to categorize testcases into suites Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 111 -- 1 file changed, 111 deletions(-) diff --git a/test/test/meson.build b/test/te

[dpdk-dev] [PATCH v5 2/5] test: add quick run tests under fast-tests suite

2018-10-24 Thread Hari Kumar Vemula
From: Hari Kumar Vemula Added test cases that runs quickly under fast tests category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 99 --- 1 file changed, 94 insertions(+), 5 deletions(-) diff --git a/test/test/meson.build b/test/

[dpdk-dev] [PATCH v5 0/5] create different meson test targets

2018-10-24 Thread Hari Kumar Vemula
From: Hari Kumar Vemula 1/5: remove existing test cases to reorganize further 2/5: add fast-tests suite to meson targets 3/5: add perf-tests suite to meson targets 4/5: add driver-tests suite to meson targets 5/5: add debug-tests suite to meson targets -- v5: Renamed test suite names Removed

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-24 Thread Thomas Monjalon
25/10/2018 04:54, Hideyuki Yamashita: > Hi, > > > Yes it may work with most of the drivers. > Question for my understadnding. > You said that most of the drivers assign only one > port when hotplug_add is called, right? > Then what is the exception? > What kind of device/driver assign multiple po

Re: [dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding

2018-10-24 Thread Thomas Monjalon
25/10/2018 02:40, Trahe, Fiona: > I'll send a v6. > On which OS/compiler did this fail to compile? It fails on i686 of course. I already sent some general notes in the past, explaining how %lx is most of the time wrong. %PRIu64 is the right specifier. https://www.mail-archive.com/dev@dpdk.org/ms

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-24 Thread Mattias Rönnblom
On 2018-10-24 20:09, Yipeng Wang wrote: There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. I'm guessing the include is longer needed.

[dpdk-dev] [PATCH] net/mlx5: add 128B padding of Rx completion entry

2018-10-24 Thread Yongseok Koh
A PMD parameter (rxq_cqe_pad_en) is added to enable 128B padding of CQE on RX side. The size of CQE is aligned with the size of a cacheline of the core. If cacheline size is 128B, the CQE size is configured to be 128B even though the device writes only 64B data on the cacheline. This is to avoid un

Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask

2018-10-24 Thread Ye Xiaolong
On 10/25, Zhirun Yan wrote: >Tx offload mask is updated in following commit: >commit 1037ed842c37 ("mbuf: fix Tx offload mask") >Currently, the new added offload flags will be s/will be/are Thanks, Xiaolong >not supported in PMD and application will fail to >call PMD transmit prepare function. >

[dpdk-dev] [PATCH] app/testpmd: replace Y with R in RED bytes statistics

2018-10-24 Thread Leah Tekoa
From: Leah Tekoa Y stands for Yellow, R stands for Red. Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Cc: sta...@dpdk.org Signed-off-by: Leah Tekoa --- app/test-pmd/cmdline_mtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd

[dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask

2018-10-24 Thread Zhirun Yan
Tx offload mask is updated in following commit: commit 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new added offload flags will be not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates IXGBE_TX_OFFFLOAD_MASK. Fixes: b161f72107 ("mbuf

Re: [dpdk-dev] [PATCH] bus/pci: use device driver name instead of handler type

2018-10-24 Thread Alejandro Lucero
On Thu, Oct 25, 2018 at 6:30 AM Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > > > On Thu, Oct 25, 2018 at 12:11 AM Thomas Monjalon > wrote: > >> Hi, >> >> 19/10/2018 18:43, Alejandro Lucero: >> > --- a/drivers/bus/pci/linux/pci.c >> > +++ b/drivers/bus/pci/linux/pci.c >> > + cha

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add VXLAN encap decap to Direct Verbs

2018-10-24 Thread Dekel Peled
Thanks. I deferred the series, will send revised series later. > -Original Message- > From: Ori Kam > Sent: Wednesday, October 24, 2018 3:59 PM > To: Dekel Peled ; Yongseok Koh > ; Shahaf Shuler > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/2] net/mlx5: add VXLAN encap decap to Direct Verbs

Re: [dpdk-dev] [PATCH] net/i40e: update Tx offload mask

2018-10-24 Thread Ye Xiaolong
On 10/23, Beilei Xing wrote: >Tx offload mask is updated in following commit: >commit 1037ed842c37 ("mbuf: fix Tx offload mask"). >Currently, the new added offload flags will be >not supported in PMD and application will fail Shouldn't it be "the new added offlaod flags are not supported in PMD an

Re: [dpdk-dev] [PATCH] bus/pci: use device driver name instead of handler type

2018-10-24 Thread Alejandro Lucero
On Thu, Oct 25, 2018 at 12:11 AM Thomas Monjalon wrote: > Hi, > > 19/10/2018 18:43, Alejandro Lucero: > > --- a/drivers/bus/pci/linux/pci.c > > +++ b/drivers/bus/pci/linux/pci.c > > + char devname[RTE_DEV_NAME_MAX_LEN] = {0}; > > I think "" would be more appropriate than {0}. > > > cons

[dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-24 Thread Qi Zhang
It's not necessary to insert device argment to devargs_list during bus scan, but this happens when we try to attach a device on secondary process. The patch fix the issue. Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/bus

Re: [dpdk-dev] [PATCH] eal: fix floating device argument pointer

2018-10-24 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, October 24, 2018 10:34 AM > To: Thomas Monjalon > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH] eal: fix floating device argument pointer > > On Wed, Oct 24, 2018 at 04:43:45

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-24 Thread Hideyuki Yamashita
Hi, > Yes it may work with most of the drivers. Question for my understadnding. You said that most of the drivers assign only one port when hotplug_add is called, right? Then what is the exception? What kind of device/driver assign multiple ports? My program attach to - vhost pmd - pcap pmd

[dpdk-dev] [PATCH] net/ixgbe: enable detach from secondary

2018-10-24 Thread Qi Zhang
Since we have enabled the hotplug mechanism for multi-process, it's not necessary to return -EPERM when try detaches a device from a secondary process. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port

2018-10-24 Thread Zhao1, Wei
> -Original Message- > From: Wang, Dong1 > Sent: Wednesday, October 24, 2018 4:51 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Thomas Monjalon > Subject: RE: [PATCH] examples/ipv4_multicast: enable multicast promiscuous > for all port > > Te

[dpdk-dev] [PATCH v6] compress/qat: enable dynamic huffman encoding

2018-10-24 Thread Fiona Trahe
Enable dynamic huffman encoding in the QAT comp PMD. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe Acked-by: Arek Kusztal --- v6 changes: - replace %lx with PRIx64 to fix compiler issue - reorder entry in release notes so above

[dpdk-dev] [PATCH v2 4/4] test/hash: remove hash scaling unit test

2018-10-24 Thread Yipeng Wang
The hash scaling unit test is not really needed any more since the multi-writer is supported now inside the library and it is tested by multi-writer unit test. Signed-off-by: Yipeng Wang --- test/test/Makefile| 1 - test/test/autotest_data.py| 6 -- test/test/meson.build

[dpdk-dev] [PATCH v2 3/4] test/hash: add readwrite test for ext table

2018-10-24 Thread Yipeng Wang
This commit improves the readwrite test to consider extendable table feature and add more functional tests to cover more corner cases. Signed-off-by: Yipeng Wang --- test/test/test_hash_readwrite.c | 70 ++--- 1 file changed, 58 insertions(+), 12 deletions(-)

[dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-24 Thread Yipeng Wang
There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c | 4 ++-- 1 file c

[dpdk-dev] [PATCH v2 2/4] test/hash: change multiwriter test to use jhash

2018-10-24 Thread Yipeng Wang
With sequential key, the test will cover more corner cases with jhash instead of crc hash, since jhash generates more random hash pattern on sequential key. It is useful for functional verification. Signed-off-by: Yipeng Wang --- test/test/test_hash_multiwriter.c | 10 +- 1 file changed,

[dpdk-dev] [PATCH v2 0/4] hash: improve multiple places

2018-10-24 Thread Yipeng Wang
This patch set depends on Honnappa's patch set: http://patchwork.dpdk.org/cover/47268/ This patch set fixes/improves a couple of places mostly on unit tests: commit 1: remove unnecessary code in hash library. commit 2: use jhash in multiwriter unit test. commit 3: improve readwrite test to consid

Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table

2018-10-24 Thread Wang, Yipeng1
Thanks for the comment Bruce, I agree with you. As I think about it, I believe the old scaling test can be removed since currently the multiwriter is supported inside the library, and we already have the multiwriter test. I will post a V2 version of this patch series to remove that test. >---

Re: [dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding

2018-10-24 Thread Trahe, Fiona
I'll send a v6. On which OS/compiler did this fail to compile? > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 2:30 PM > To: Trahe, Fiona > Cc: dev@dpdk.org; Akhil Goyal ; Jozwiak, TomaszX > ; > Kusztal, ArkadiuszX > Subject:

Re: [dpdk-dev] [PATCH v2 7/7] net/mlx5: e-switch VXLAN rule cleanup routines

2018-10-24 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:35PM +, Viacheslav Ovsiienko wrote: > The last part of patchset contains the rule cleanup routines. > These ones is the part of outer interface initialization at > the moment of VXLAN VTEP attaching. These routines query > the list of attached VXLAN devices, the li

Re: [dpdk-dev] [PATCH v2 6/7] net/mlx5: e-switch VXLAN encapsulation rules management

2018-10-24 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:34PM +, Viacheslav Ovsiienko wrote: > VXLAN encap rules are applied to the VF ingress traffic and have the > VTEP as actual redirection destinations instead of outer PF. > The encapsulation rule should provide: > - redirection action VF->PF > - VF port ID > - some

Re: [dpdk-dev] [PATCH v2 5/7] net/mlx5: e-switch VXLAN tunnel devices management

2018-10-24 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:33PM +, Viacheslav Ovsiienko wrote: > VXLAN interfaces are dynamically created for each local UDP port > of outer networks and then used as targets for TC "flower" filters > in order to perform encapsulation. These VXLAN interfaces are > system-wide, the only one d

Re: [dpdk-dev] [PATCH 6/6] doc: remove internal libs from release notes

2018-10-24 Thread Thomas Monjalon
16/10/2018 13:52, Shreyansh Jain: > On Monday 15 October 2018 08:20 PM, Ferruh Yigit wrote: > > These libraries has exported functions but the target of those functions > > are not user but other libraries. > > > > The version of these libraries doesn't mean much to the user so can be > > dropped

Re: [dpdk-dev] [PATCH v2] add shorthand support for __rte_weak macro

2018-10-24 Thread Thomas Monjalon
05/10/2018 16:48, Keith Wiles: > eal: add shorthand __rte_weak macro > qat: update code to use __rte_weak macro > avf: update code to use __rte_weak macro > fm10k: update code to use __rte_weak macro > i40e: update code to use __rte_weak macro > ixgbe: update code to use __rte_weak macro > mlx5: up

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-10-24 Thread Thomas Monjalon
18/09/2018 12:16, Burakov, Anatoly: > On 18-Sep-18 10:43 AM, Thomas Monjalon wrote: > > 26/07/2018 11:41, Burakov, Anatoly: > >> On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: > >>> There is no need to call rte_exit and crash the application here; > >>> better to let the application handle the erro

Re: [dpdk-dev] [PATCH 1/4] arm: remove profanity in comment

2018-10-24 Thread Thomas Monjalon
25/07/2018 20:20, Stephen Hemminger: > Update comment to describe the problem better without > risk of being offensive. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH 0/2] eal: hexcump trivial changes

2018-10-24 Thread Thomas Monjalon
16/08/2018 17:31, Stephen Hemminger: > Minor cleanups of the hexdump routines > > Stephen Hemminger (2): > hexdump: whitespace cleanup > hexdump: align output of string > > lib/librte_eal/common/eal_common_hexdump.c | 116 + > 1 file changed, 50 insertions(+), 66 deletion

Re: [dpdk-dev] [PATCH] eal: eliminate cast of hpet_msb_inc

2018-10-24 Thread Thomas Monjalon
11/10/2018 01:22, Stephen Hemminger: > The cast of hpet_msb_inc is causing a warning in some compilations. > Yet the cast is unnecessary, the function is used only one place > just use the correct signature. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug

2018-10-24 Thread Thomas Monjalon
22/10/2018 13:13, Ferruh Yigit: > On 10/19/2018 9:35 AM, Jeff Guo wrote: > > > > On 10/19/2018 12:06 AM, Ferruh Yigit wrote: > >> On 10/18/2018 7:27 AM, Jeff Guo wrote: > >>> When a device is hot-unplugged, pci_remove will be invoked unexpectedly > >>> before pci_release, it will caused kernel hun

Re: [dpdk-dev] [PATCH] bus/pci: use device driver name instead of handler type

2018-10-24 Thread Thomas Monjalon
Hi, 19/10/2018 18:43, Alejandro Lucero: > --- a/drivers/bus/pci/linux/pci.c > +++ b/drivers/bus/pci/linux/pci.c > + char devname[RTE_DEV_NAME_MAX_LEN] = {0}; I think "" would be more appropriate than {0}. > const struct rte_intr_handle *intr_handle = &device->intr_handle; > > - s

Re: [dpdk-dev] [PATCH] eal: don't double space init alert messages

2018-10-24 Thread Thomas Monjalon
24/10/2018 13:17, Shreyansh Jain: > On Tuesday 23 October 2018 09:59 PM, Stephen Hemminger wrote: > > rte_init_alert already adds a newline, don't do it twice. > > > > Signed-off-by: Stephen Hemminger > > Reviewed-by: Shreyansh Jain Applied, thanks

Re: [dpdk-dev] [PATCH] raw/skeleton_rawdev: fix memory leak on test failure

2018-10-24 Thread Thomas Monjalon
24/10/2018 07:33, Shreyansh Jain: > In skeleton_rawdev unit tests, a malloc'd memory was leaking in case > the next sequential test fails. This fix moves the free of the > malloc'd memory above the failing test. > > Coverity issue: 260402 > > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") >

Re: [dpdk-dev] [PATCH] common/dpaax: fix incorrect error case

2018-10-24 Thread Thomas Monjalon
24/10/2018 07:44, Shreyansh Jain: > In case the memory for nodes cannot be allocated, there is no need > to check for the length. Also, `node_count` is an unsigned value > and cannot be less than 0. > > Coverity issue: 323521 > > Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translati

Re: [dpdk-dev] [PATCH] common/dpaax: fix uninitialized table case

2018-10-24 Thread Thomas Monjalon
17/10/2018 11:05, Shreyansh Jain: > There is a possibility that either because of missing device tree entry > or lack of memory, the PA-VA table might not be available. But, the > table being transparent, the callers don't necessary check for its > initialization state. This is explicitly done duri

[dpdk-dev] [PATCH v7 5/5] examples/kni: improve zeroing statistics

2018-10-24 Thread Dan Gora
The worker threads incrementing the rx/tx_packets race with the signal handler from the main thread zeroing the entire statistics structure. This can cause the statistics to fail to be zeroed, even when there is no traffic on those interfaces. Improve zeroing the statistics by only incrementing rx

[dpdk-dev] [PATCH v7 2/5] kni: set default carrier state of interface

2018-10-24 Thread Dan Gora
Add module parameter 'carrier='on|off' to set the default carrier state for linux network interfaces created by the KNI module. The default carrier state is 'off'. For KNI interfaces which need to reflect the carrier state of a physical Ethernet port controlled by the DPDK application, the defaul

[dpdk-dev] [PATCH v7 3/5] examples/kni: monitor and update link status continually

2018-10-24 Thread Dan Gora
Update KNI example to add the command line flag '-m' to enable a function to continuously monitor the Ethernet link status of the physical link and update the link status of the corresponding interfaces with rte_kni_update_link(). Signed-off-by: Dan Gora --- .../sample_app_ug/kernel_nic_interfac

[dpdk-dev] [PATCH v7 4/5] examples/kni: add log msgs to show and clear stats

2018-10-24 Thread Dan Gora
Add logging messages showing the commands necessary for the user to have the application display and zero the statistics. Signed-off-by: Dan Gora --- examples/kni/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.

[dpdk-dev] [PATCH v7 1/5] kni: add API to set link status on kernel interface

2018-10-24 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 41 lib/librte_kni/rte_kni.h | 20 lib/li

[dpdk-dev] [PATCH v7 0/5] kni: add API to set link status on kernel interface

2018-10-24 Thread Dan Gora
Hi All, Attached is version 7 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. v7 * Add commands to check/clear statistics in kni sample app in KNI sample app documentation. > v6 > > * Update info about callback f

Re: [dpdk-dev] [PATCH v2 0/3] Reduce logging level for dpaax and fslmc

2018-10-24 Thread Thomas Monjalon
17/10/2018 12:10, Shreyansh Jain: > Shreyansh Jain (3): > common/dpaax: reduce logging level > bus/fslmc: ignore dpaax pa-va table errors > net/dpaa2: convert logs from errors to debug Applied, thanks

Re: [dpdk-dev] [PATCH] mk: use EXTRA_CFLAGS for pmdinfogen

2018-10-24 Thread Thomas Monjalon
05/10/2018 13:32, Neil Horman: > On Fri, Oct 05, 2018 at 12:12:41PM +0100, Ferruh Yigit wrote: > > Currently not able to pass EXTRA_CFLAGS while building *.pmd.c file, > > adding it. > > > > Signed-off-by: Ferruh Yigit > > --- > Acked-by: Neil Horman Applied, thanks

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

2018-10-24 Thread Dan Gora
On Wed, Oct 24, 2018 at 6:18 PM Stephen Hemminger wrote: > > > > > > This seems like an overly wordy message which should really be in the > > > documentation > > > not a billboard in the code. > > > > > > In my opinion, having verbose messages is unhelpful since it just clutters > > > the experi

Re: [dpdk-dev] [pull-request] next-crypto 18.11 rc1

2018-10-24 Thread Thomas Monjalon
16/10/2018 16:50, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks One last commit for compressdev cannot be integrated because of compilation issue.

Re: [dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding

2018-10-24 Thread Thomas Monjalon
24/10/2018 16:15, Akhil Goyal: > > On 10/18/2018 2:18 AM, Fiona Trahe wrote: > > Enable dynamic huffman encoding in the QAT comp PMD. > > > > Signed-off-by: Tomasz Jozwiak > > Signed-off-by: Fiona Trahe > > Acked-by: Arek Kusztal > > --- > Applied to dpdk-next-crypto error: format ‘%lx’ expects a

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

2018-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2018 17:56:50 -0300 Dan Gora wrote: > On Wed, Oct 24, 2018 at 5:46 PM Stephen Hemminger > wrote: > > > + pid = getpid(); > > > + RTE_LOG(INFO, APP, "\n"); > > > + RTE_LOG(INFO, APP, "KNI Running\n"); > > > + RTE_LOG(INFO, APP, "kill -SIGUSR1

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

2018-10-24 Thread Dan Gora
On Wed, Oct 24, 2018 at 5:46 PM Stephen Hemminger wrote: > > + pid = getpid(); > > + RTE_LOG(INFO, APP, "\n"); > > + RTE_LOG(INFO, APP, "KNI Running\n"); > > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > > + RTE_LOG(INFO, APP, "Show KNI Statisti

Re: [dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

2018-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2018 17:27:18 -0300 Dan Gora wrote: > + pid = getpid(); > + RTE_LOG(INFO, APP, "\n"); > + RTE_LOG(INFO, APP, "KNI Running\n"); > + RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid); > + RTE_LOG(INFO, APP, "Show KNI Statistics.\n"); > +

Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix redefinition error

2018-10-24 Thread Thomas Monjalon
23/10/2018 13:54, Gagandeep Singh: > dma_addr_t is already defined in compat.h. > so removing the local definition from caam_jr_config.h > > Fixes: b70a67ab70 ("crypto/caam_jr: add HW tuning options") > > Signed-off-by: Gagandeep Singh Applied, thanks

Re: [dpdk-dev] [PATCH] net/i40e: update Tx offload mask

2018-10-24 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, October 23, 2018 1:15 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: update Tx offload mask > > Tx offload mask is updated in following commit: > commit 1037ed842c37 ("mbuf: fix Tx offload

Re: [dpdk-dev] [PATCH] drivers: fix compilation if security disabled

2018-10-24 Thread Thomas Monjalon
23/10/2018 15:47, Akhil Goyal: > RTE_SECURITY is enabled by default. If it is disabled, dpaa2_sec, > dpaa_sec and caam_jr compilation fails. > > This patch fixes compilation by disabling these drivers > when rte_security is not available. > > Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for

Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table

2018-10-24 Thread Bruce Richardson
On Wed, Oct 10, 2018 at 02:48:05PM -0700, Yipeng Wang wrote: > This commit improves the readwrite test to consider extendable table > feature and add more functional tests to cover more corner cases. > > Signed-off-by: Yipeng Wang --- > test/test/test_hash_readwrite.c | 70 > +

[dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

2018-10-24 Thread Dan Gora
Add logging messages showing the commands necessary for the user to have the application display and zero the statistics. Signed-off-by: Dan Gora --- examples/kni/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.

[dpdk-dev] [PATCH v6 5/5] examples/kni: improve zeroing statistics

2018-10-24 Thread Dan Gora
The worker threads incrementing the rx/tx_packets race with the signal handler from the main thread zeroing the entire statistics structure. This can cause the statistics to fail to be zeroed, even when there is no traffic on those interfaces. Improve zeroing the statistics by only incrementing rx

[dpdk-dev] [PATCH v6 0/5] kni: add API to set link status on kernel interface

2018-10-24 Thread Dan Gora
Hi All, Attached is version 6 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. v6 * Update info about callback functions in KNI library documentation. * Minor fixup to module parameter formatting in KNI kernel module. (a

[dpdk-dev] [PATCH v6 2/5] kni: set default carrier state of interface

2018-10-24 Thread Dan Gora
Add module parameter 'carrier='on|off' to set the default carrier state for linux network interfaces created by the KNI module. The default carrier state is 'off'. For KNI interfaces which need to reflect the carrier state of a physical Ethernet port controlled by the DPDK application, the defaul

[dpdk-dev] [PATCH v6 3/5] examples/kni: monitor and update link status continually

2018-10-24 Thread Dan Gora
Update KNI example to add the command line flag '-m' to enable a function to continuously monitor the Ethernet link status of the physical link and update the link status of the corresponding interfaces with rte_kni_update_link(). Signed-off-by: Dan Gora --- .../sample_app_ug/kernel_nic_interfac

[dpdk-dev] [PATCH v6 1/5] kni: add API to set link status on kernel interface

2018-10-24 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 41 lib/librte_kni/rte_kni.h | 20 lib/li

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: setup attached ports on probe event

2018-10-24 Thread Thomas Monjalon
24/10/2018 18:13, Iremonger, Bernard: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > +set port setup on > > +~ > > + > > +Select how to retrieve new ports created after "port attach" command. > > + > > +For each new port, a setup is done. > > +It will find the probed ports

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration

2018-10-24 Thread Thomas Monjalon
24/10/2018 17:55, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > +/* Pretty printing of ethdev events */ > > +static const char * const eth_event_desc[] = { > > + [RTE_ETH_EVENT_UNKNOWN] = "unknown", > > + [RTE_ETH_EVENT_INTR_LSC] = "LSC", > > How

Re: [dpdk-dev] [RFC 00/14] prefix network structures

2018-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2018 10:18:19 +0200 Olivier Matz wrote: > This RFC targets 19.02. > > The rte_net headers conflict with the libc headers, because > some definitions are duplicated, sometimes with few differences. > This was discussed in [1], and more recently at the techboard. > > Before sending

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter API

2018-10-24 Thread Shahaf Shuler
Hi Ferruh, Wednesday, October 24, 2018 7:36 PM, Ferruh Yigit > Subject: Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter > API > > On 10/24/2018 5:31 PM, Ferruh Yigit wrote: > > On 10/23/2018 11:04 AM, Slava Ovsiienko wrote: > >> @@ -1012,9 +1079,12 @@ > >>

Re: [dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues

2018-10-24 Thread Maxime Coquelin
On 10/24/18 4:32 PM, Jens Freimann wrote: diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index eb891433e..837457243 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -88,6 +88,42 @@ vq_ring_free_chain(struct virtqueue *vq,

Re: [dpdk-dev] [RFC 00/14] prefix network structures

2018-10-24 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 10:18:19AM +0200, Olivier Matz wrote: > This RFC targets 19.02. > > The rte_net headers conflict with the libc headers, because > some definitions are duplicated, sometimes with few differences. > This was discussed in [1], and more recently at the techboard. > > Before se

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter API

2018-10-24 Thread Ferruh Yigit
On 10/24/2018 5:31 PM, Ferruh Yigit wrote: > On 10/23/2018 11:04 AM, Slava Ovsiienko wrote: >> @@ -1012,9 +1079,12 @@ >>" context."); >> } >> *action_flags |= MLX5_FLOW_ACTION_COUNT; >> -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42 >> +#if define

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter API

2018-10-24 Thread Ferruh Yigit
On 10/23/2018 11:04 AM, Slava Ovsiienko wrote: > @@ -1012,9 +1079,12 @@ > " context."); > } > *action_flags |= MLX5_FLOW_ACTION_COUNT; > -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42 > +#if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42) > coun

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: setup attached ports on probe event

2018-10-24 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.c

Re: [dpdk-dev] Change ether_addr to avoid conflict

2018-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2018 07:35:28 -0500 Lewis Donzis wrote: > Please consider changing "struct ether_addr" in rte_ether.h to "struct > rte_ether_addr", in order to avoid conflicts with the same structure name > /usr/include/net/ethernet.h. > > Sometimes, there is need to include /usr/include/net/et

Re: [dpdk-dev] [RFC 00/14] prefix network structures

2018-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2018 10:18:19 +0200 Olivier Matz wrote: > This RFC targets 19.02. > > The rte_net headers conflict with the libc headers, because > some definitions are duplicated, sometimes with few differences. > This was discussed in [1], and more recently at the techboard. > > Before sending

[dpdk-dev] [PATCH v8 12/13] usertools: add client python script for telemetry

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds a python script which can be used as a demo client. The script is interactive and will allow the user to register, request statistics, and unregister. To run the script, an argument for the client file path must be passed in: "python telemetry_client.py ". This

[dpdk-dev] [PATCH v8 10/13] telemetry: add ability to disable selftest

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to enable/disable the selftest. This functionality will be extended in future to make the enabling/disabling more dynamic and remove this 'hardcoded' approach. We are temporarily using this approach due to the design changes (vdev vs eal) made to t

[dpdk-dev] [PATCH v8 13/13] build: add dependency on telemetry to apps in meson

2018-10-24 Thread Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these changes, the --telemetry flag will not be recognised and applications will fail to run if they want to enable telemetry. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- app/mes

[dpdk-dev] [PATCH v8 11/13] doc: add telemetry documentation

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. It also adds the MAINTAINERS file entry and a release notes update for telemetry. Signed-off-by: Ciara Power Signed-off-by: Brian

[dpdk-dev] [PATCH v8 09/13] telemetry: add tests for telemetry api

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds all tests for the Telemetry API. The tests added include a parser test, selftest, and socket messaging tests. The parser tests pass valid and invalid messages to the parser to ensure the correct return values are received. The selftest tests basic functions in t

[dpdk-dev] [PATCH v8 08/13] telemetry: format json response when sending stats

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by

[dpdk-dev] [PATCH v8 07/13] telemetry: update metrics before sending stats

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to update the statistics in the metrics library with values from the ethdev stats. Values need to be updated before they are encoded into a JSON message and sent to the client that requested them. The JSON encoding will be added in a subsequent pat

[dpdk-dev] [PATCH v8 06/13] telemetry: add parser for client socket messages

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds the parser file. This is used to parse any messages that are received on any of the client sockets. Currently, the unregister functionality works using the parser. Functionality relating to getting statistic values for certain ports will be added in a subsequent

[dpdk-dev] [PATCH v8 04/13] telemetry: add initial connection socket

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-

[dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to enable clients to register and have a clien

[dpdk-dev] [PATCH v8 03/13] telemetry: initial telemetry infrastructure

2018-10-24 Thread Kevin Laatz
From: Ciara Power This patch adds the infrastructure and initial code for the telemetry library. The telemetry init is registered with eal_init(). We can then check to see if --telemetry was passed as an eal option. If --telemetry was parsed, then we call telemetry init at the end of eal init.

[dpdk-dev] [PATCH v8 02/13] eal: make get runtime dir function public

2018-10-24 Thread Kevin Laatz
This patch makes the eal_get_runtime_dir() API public so it can be used from outside EAL. Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/common/eal_filesystem.h | 15 --- lib/librte_eal/common/include/rte_ea

[dpdk-dev] [PATCH v8 01/13] eal: add option register infrastructure

2018-10-24 Thread Kevin Laatz
This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of EAL init. This infrastructure allows libraries that depend on EAL to be initialized as part of EAL init, removing circular dependency iss

[dpdk-dev] [PATCH v8 00/13] introduce telemetry library

2018-10-24 Thread Kevin Laatz
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: check not configuring port twice

2018-10-24 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.c

Re: [dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug

2018-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2018 05:41:32 + "Varghese, Vipin" wrote: > Hi Stephen, > > > > > > > > + " --dbg-port to display information for all available ports\n" > > > + " --dbg-tm to display information for traffic manager\n" > > > + " --dbg-crypto to display informatio

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration

2018-10-24 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.c

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: merge ports list update functions

2018-10-24 Thread Iremonger, Bernard
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.com > Subje

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: check not detaching device twice

2018-10-24 Thread Iremonger, Bernard
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophi...@mellanox.com; wis...@mellanox.com; Yigit, > Ferruh ; arybche...@solarflare.com > Subject

  1   2   3   >