25/10/2018 02:40, Trahe, Fiona: > I'll send a v6. > On which OS/compiler did this fail to compile?
It fails on i686 of course. I already sent some general notes in the past, explaining how %lx is most of the time wrong. %PRIu64 is the right specifier. https://www.mail-archive.com/dev@dpdk.org/msg90644.html > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/10/2018 16:15, Akhil Goyal: > > > > > > On 10/18/2018 2:18 AM, Fiona Trahe wrote: > > > > Enable dynamic huffman encoding in the QAT comp PMD. > > > > > > > > Signed-off-by: Tomasz Jozwiak<tomaszx.jozw...@intel.com> > > > > Signed-off-by: Fiona Trahe<fiona.tr...@intel.com> > > > > Acked-by: Arek Kusztal<arkadiuszx.kusz...@intel.com> > > > > --- > > > Applied to dpdk-next-crypto > > > > error: format ‘%lx’ expects argument of type ‘long unsigned int’, but > > argument 7 has type ‘phys_addr_t’ > > {aka ‘long long unsigned int’} [-Werror=format=] > > "%s(): " fmt "\n", __func__, ## args) > > ^~~~~~~~ > > drivers/compress/qat/qat_comp_pmd.c:194:2: note: in expansion of macro > > ‘QAT_LOG’ > > QAT_LOG(DEBUG, "Memzone %s: addr = %p, phys = %lx, size required %d," > > > > > > One more comment about the release notes, please try to integrate > > compressdev features between cryptodev and eventdev. > > > >
