Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-22 Thread Shreyansh Jain
On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: > This patch fixes rte_eal_hotplug_add without checking return value issue > > Signed-off-by: Rosen Xu > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen...@intel.com > --- Fixes comes *before* signed-off. ..

Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS

2018-10-22 Thread Peng, Yuan
Tested-by: Peng, Yuan - Tested Branch: master - Tested Commit: 739e13bcc98f562d3301f808ec76507ebae82e63 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Conne

Re: [dpdk-dev] [PATCH] net/ixgbe: fix RSS flow return error

2018-10-22 Thread Peng, Yuan
Tested-by: Peng, Yuan - Tested Branch: master - Tested Commit: 739e13bcc98f562d3301f808ec76507ebae82e63 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Conne

[dpdk-dev] [PATCH] net/i40e: update Tx offload mask

2018-10-22 Thread Beilei Xing
Tx offload mask is updated in following commit: commit 1037ed842c37 ("mbuf: fix Tx offload mask"). Currently, the new added offload flags will be not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates PMD Tx offload mask. Cc: sta...@dpdk.org Signe

[dpdk-dev] [PATCH] vhost: fix vector filling for packed ring

2018-10-22 Thread Tiwei Bie
We should return the length of the buffers described by the current descriptor chain after filling the buffer vector. So we need to zero the *len first. Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/vi

[dpdk-dev] [PATCH v5 4/5] hash: add lock-free read-write concurrency

2018-10-22 Thread Honnappa Nagarahalli
Add lock-free read-write concurrency. This is achieved by the following changes. 1) Add memory ordering to avoid race conditions. The only race condition that can occur is - using the key store element before the key write is completed. Hence, while inserting the element the release memory order

[dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-22 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Unit tests to check for hash lookup and bulk-lookup perf with lock-free enabled and with lock-free disabled. Unit tests performed with readers running in parallel with writers. Tests include: - hash lookup on existing keys with: - hash add causing NO key-shifts of existi

[dpdk-dev] [PATCH v5 3/5] hash: fix key store element alignment

2018-10-22 Thread Honnappa Nagarahalli
Fix the key store array element alignment such that every array element is aligned on KEY_ALIGNMENT boundary. This is required to make 'pdata' in 'struct rte_hash_key' align on its natural boundary for atomic load/store. Fixes: 473d1bebce43 ("hash: allow to store data in hash table") Cc: Pablo de

[dpdk-dev] [PATCH v5 2/5] hash: support do not free on delete

2018-10-22 Thread Honnappa Nagarahalli
rte_hash_lookup_xxx APIs return the index of slot in the key store. Application(reader) can use that index to reference other data structures in its scope. Because of this, the index should not be freed till the application completes using the index. RTE_HASH_EXTRA_FLAGS_NO_FREE_ON_DEL is introduce

[dpdk-dev] [PATCH v5 0/5] Address reader-writer concurrency in rte_hash

2018-10-22 Thread Honnappa Nagarahalli
This patch has dependency on the following patches in the order: http://patchwork.dpdk.org/cover/45611/ http://patchwork.dpdk.org/patch/47196/ Currently, reader-writer concurrency problems in rte_hash are addressed using reader-writer locks. Use of reader-writer locks resul

[dpdk-dev] [PATCH v5 1/5] hash: separate multi-writer from rw-concurrency

2018-10-22 Thread Honnappa Nagarahalli
RW concurrency is required with single writer and multiple reader usecase as well. Hence, multi-writer should not be enabled by default when RW concurrency is enabled. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: yipeng1.w...@intel.com Signed-off-by: Honnappa Nagarahalli Revi

[dpdk-dev] [PATCH] net/ixgbe: fix RSS flow return error

2018-10-22 Thread Wei Zhao
If hash function is 0, it should disable RSS then return 0. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/i

[dpdk-dev] [PATCH] net/ixgbe: fix RSS flow return error

2018-10-22 Thread Wei Zhao
From: Zhao Wei If hash function is 0, it should disable RSS then return 0. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/dr

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-22 Thread Hideyuki Yamashita
Hi, Thanks for your guidance again. Q1. Is following my understanding correct? If a device has multiple port, then "rte_eth_dev_get_port_by_name" will NOT work becauase it uses strcmp and needs "exact match" of the device name. New iterator RTE_ETH_FOREACH_MATCHING_DEV takes care of this issue a

[dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-22 Thread Rosen Xu
This patch fixes rte_eal_hotplug_add without checking return value issue Signed-off-by: Rosen Xu Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: rosen...@intel.com --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v8 4/4] hash: use partial-key hashing

2018-10-22 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Basically the idea is to use "xor" to derive alternative

[dpdk-dev] [PATCH v8 2/4] hash: add extendable bucket feature

2018-10-22 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

[dpdk-dev] [PATCH v8 3/4] test/hash: implement extendable bucket hash test

2018-10-22 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Dharmik Thakkar --- test/test/test_hash.c | 159 +++-- test/test/test_has

[dpdk-dev] [PATCH v8 1/4] hash: fix race condition in iterate

2018-10-22 Thread Yipeng Wang
In rte_hash_iterate, the reader lock did not protect the while loop which checks empty entry. This created a race condition that the entry may become empty when enters the lock, then a wrong key data value would be read out. This commit reads out the position in the while condition, which makes su

[dpdk-dev] [PATCH v8 0/4] hash: add extendable bucket and partial key hashing

2018-10-22 Thread Yipeng Wang
This patch has dependency on another bug fix patch set: http://patchwork.dpdk.org/cover/45611/ This patch set makes two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-10-22 Thread Lu, Wenzhuo
Hi Thomas, Ferruh, Andrew, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, October 22, 2018 8:13 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Andrew Rybchenko > ; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting > >

[dpdk-dev] [PATCH] net/i40e: cancel alarm handler at the end of device closure

2018-10-22 Thread Xiaolong Ye
Some operations in i40evf_dev_close like i40evf_dev_promiscuous_disable still need alarm handler to clear the pending cmd, if alarm handler is canceled in early stage of i40evf_dev_close, i40evf_dev_promiscuous_disable will result in failure. Fixes: 864a800d706d ("net/i40e: remove VF interrupt han

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-22 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, October 22, 2018 3:02 PM > To: Andrew Rybchenko > Cc: dev@dpdk.org; gaetan.ri...@6wind.com; ophi...@mellanox.com; Yigit, Ferruh > ; olivier.m...@6wind.com; > Horton, Remy ; Richa

Re: [dpdk-dev] Issues configuring OVS-DPDK in openstack queens

2018-10-22 Thread Song, Kee SangX
BTW, We are using the latest driver for the NIC. From the physical nic, it shows this firmware version which seems to be the latest for XL710 NIC ubuntu@dskl12:~$ ethtool -i eth10 driver: i40e version: 2.4.10 firmware-version: 6.01 0x80003554 1.1747.0 One of vf interfaces, it shows the latest v

Re: [dpdk-dev] Issues configuring OVS-DPDK in openstack queens

2018-10-22 Thread Song, Kee SangX
Hi DPDK developers, While preparing NDA training at Intel, we are blocked due to this issue. So we need your input, and we will appreciate your help as soon as possible. Thanks in advance. -Original Message- From: dev On Behalf Of Manojawa Paritala To: Richardson, Bruce ; De Lara Guarc

[dpdk-dev] Memory allocation in dpdk at basic level

2018-10-22 Thread Avinash Chaurasia
Hello, I am not sure whether this is right list for posting this problem. I am trying to understand how dpdk allocate memory. I tried digging code to understand memory allocation of DPDK. So far I understood that memory is allocated from a heap that dpdk maintains. However, this heap must be alloca

[dpdk-dev] [PATCH] doc/hash: add lock free read write concurrency

2018-10-22 Thread Honnappa Nagarahalli
Add details of enabling lock free read write concurrency. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu --- doc/guides/prog_guide/hash_lib.rst | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/doc/guides/prog_guide/hash_lib.rst b

Re: [dpdk-dev] [PATCH] mem: fix resource leak

2018-10-22 Thread Thomas Monjalon
22/10/2018 14:57, Anatoly Burakov: > Segment preallocation code allocates an array of structures on the > heap but does not free the memory afterwards. Fix it by freeing it > at the end of the function, and changing control flow to always go > through that code path. > > Fixes: 1dd342d0fdc4 ("mem:

Re: [dpdk-dev] [PATCH v5 00/15] Introducing the NXP CAAM job ring driver

2018-10-22 Thread Thomas Monjalon
22/10/2018 16:57, Gagandeep Singh: > v4->v5 change-log: > * compilation issue fixed > > v3->v4 change-log: > * local dma_addr_t definition removed > > v2->v3 change-log: > * fix CONFIG_RTE_LIBRTE_SECURITY=n compilation. Thanks for all the fixes. The v2 of this series was applied to dpdk-next-cr

Re: [dpdk-dev] [PATCH v5 4/4] net/mlx5: support e-switch flow count action

2018-10-22 Thread Shahaf Shuler
Ferruh, Monday, October 22, 2018 12:15 PM, Ferruh Yigit: > Subject: Re: [dpdk-dev] [PATCH v5 4/4] net/mlx5: support e-switch flow > count action > > Getting following build error with clang, will not pull from mlx tree until > issue > resolved, thanks. > > .../drivers/net/mlx5/mlx5_flow_tcf.c:2

Re: [dpdk-dev] [PATCH v5 3/5] examples/kni: monitor and update link status continually

2018-10-22 Thread Dan Gora
On Mon, Oct 22, 2018 at 9:51 AM Ferruh Yigit wrote: > > +Running the kni Example Application > > +--- > > > > -Loading the KNI kernel module without any parameter is the typical way a > > DPDK application > > -gets packets into and out of the kernel net stack. > >

Re: [dpdk-dev] Build DPDK for different target machine.

2018-10-22 Thread Shubhachint, Chaitanya
Hello Ferruh, Thanks for all your help. Yes, the x86_64-native-linuxapp-gcc/.config still had the 'native' setup. I was doing the 'make config' with the hope that it would set up all the required config files but that didn't work. Modifying x86_64-native-linuxapp-gcc/.config and building works.

Re: [dpdk-dev] [PATCH v5] net/mlx5: support metadata as flow rule criteria

2018-10-22 Thread Yongseok Koh
> On Oct 21, 2018, at 7:04 AM, Dekel Peled wrote: > > As described in series starting at [1], it adds option to set > metadata value as match pattern when creating a new flow rule. > > This patch adds metadata support in mlx5 driver, in two parts: > - Add the validation and setting of metadata

[dpdk-dev] [PATCH v6 3/3] app/testpmd: add MPLSoGRE encapsulation

2018-10-22 Thread Ori Kam
Example for MPLSoGRE tunnel: ETH / IPV4 / GRE / MPLS / IP / L4..L7 In order to encapsulate such a tunnel there is a need to remove L2 of the inner packet and encap the remaining tunnel, this is done by applying 2 rte flow commands l2_decap followed by mplsogre_encap. Both commands must appear in t

[dpdk-dev] [PATCH v6 2/3] app/testpmd: add MPLSoUDP encapsulation

2018-10-22 Thread Ori Kam
MPLSoUDP is an example for L3 tunnel encapsulation. L3 tunnel type is a tunnel that is missing the layer 2 header of the inner packet. Example for MPLSoUDP tunnel: ETH / IPV4 / UDP / MPLS / IP / L4..L7 In order to encapsulate such a tunnel there is a need to remove L2 of the inner packet and enc

[dpdk-dev] [PATCH v6 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Ori Kam
Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, while L3 encapsulation is where the inner packet doesn't have the Ethernet header). In addtion the parameter to to the encap action is

[dpdk-dev] [PATCH v6 0/3] ethdev: add generic raw tunnel encapsulation

2018-10-22 Thread Ori Kam
This series implement the raw tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, wh

Re: [dpdk-dev] [PATCH v6 0/2] support metadata as flow rule criteria

2018-10-22 Thread Ferruh Yigit
On 10/21/2018 3:22 PM, Dekel Peled wrote: > This series implements the match-metadata feature described in [1]. > > [1] "[RFC v2] ethdev: support metadata as flow rule criteria" > http://mails.dpdk.org/archives/dev/2018-August/110194.html > > --- > v6: > Apply code review comments:

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: support metadata as flow rule item

2018-10-22 Thread Ferruh Yigit
On 10/21/2018 3:22 PM, Dekel Peled wrote: > As described in [1], this series adds option to set metadata value > as match pattern when creating a new flow rule. > > This patch introduces additional options in testpmd commands: > - New item type "meta" "data" > - New per-port offload flag "match_me

Re: [dpdk-dev] Build DPDK for different target machine.

2018-10-22 Thread Ferruh Yigit
On 10/22/2018 4:49 PM, Shubhachint, Chaitanya wrote: > Hello, > > My objective is to build a shared dpdk library on a build machine and copy it > over to target machine of similar hardware specs. > I am building with steps below: > 1. untar dpdk source. > 2. modify config/common_base as => >

Re: [dpdk-dev] Build DPDK for different target machine.

2018-10-22 Thread Shubhachint, Chaitanya
Yes, that is exactly what am I trying to do. Build on a designated build machine, copy dpdk libs over to target machine and use them. Upon usage I get the 'Illegal instruction' error. From: Shyam Shrivastav Sent: Saturday, October 20, 2018 12:07 AM To: Shubhachint, Chaitanya Cc: dev@dpdk.org S

Re: [dpdk-dev] Build DPDK for different target machine.

2018-10-22 Thread Shubhachint, Chaitanya
Hello, My objective is to build a shared dpdk library on a build machine and copy it over to target machine of similar hardware specs. I am building with steps below: 1. untar dpdk source. 2. modify config/common_base as => CONFIG_RTE_BUILD_SHARED_LIB=y CONFIG_RTE_MACHINE=“defaul

Re: [dpdk-dev] [PATCH v6 0/6] ethdev port freeing

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 3:07 AM, Thomas Monjalon wrote: > The function rte_eth_dev_detach() is freeing a port and its underlying > rte_device object. The issue is that we may have several ports > associated to the same rte_device. > > The right replacement is to free the port, and free the rte_device > if n

Re: [dpdk-dev] [PATCH v6 0/7] replace attach/detach functions

2018-10-22 Thread Thomas Monjalon
22/10/2018 17:11, Iremonger, Bernard: > Hi Thomas, > > The following patch fails to apply to the latest master branch, a rebase may > be needed. > > v6-5-7-ethdev-remove-deprecated-attach-detach-functions.patch > > The remaining two patches of this patch set then fail to apply. I think it is b

Re: [dpdk-dev] [PATCH v6 0/7] replace attach/detach functions

2018-10-22 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, October 22, 2018 1:31 PM > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com; ophi...@mellanox.com; > wis...@mellanox.com; Yigit, Ferruh ; > arybche...@solarflare.com; Iremonger, Bernard > > S

Re: [dpdk-dev] Change ether_addr to avoid conflict

2018-10-22 Thread Wiles, Keith
> On Oct 21, 2018, at 8:39 AM, Lewis Donzis wrote: > > Please consider changing “struct ether_addr” in rte_ether.h to “struct > rte_ether_addr”, in order to avoid conflicts with the same structure name > /usr/include/net/ethernet.h. > > This is kind of a pain for us since we would like to in

[dpdk-dev] [PATCH v5 15/15] test/crypto: add CAAM JR driver validation test cases

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the validation test cases for CAAM JR driver Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh Reviewed-by: Akhil Goyal --- test/test/test_cryptodev.c | 138 +++ test/test/test_cryptodev.h |

[dpdk-dev] [PATCH v5 14/15] doc: add caam jr cryptodev details

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal add caam jr driver details, supported features and algorithms in the document. release note and MAINTAINERS are also updated. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal --- MAINTAINERS| 2 + doc/g

[dpdk-dev] [PATCH v5 12/15] crypto/caam_jr: add statistics ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the following statistics operations: - stats_get - stats_reset Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 54 1 file changed, 54 insertions(+

[dpdk-dev] [PATCH v5 11/15] crypto/caam_jr: add scatter gather

2018-10-22 Thread Gagandeep Singh
This patch add the scatter gather feature for auth-only, cipher-only and cipher-auth operations Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 375 ++- 1 file changed, 374 insertions(+), 1 de

[dpdk-dev] [PATCH v5 10/15] crypto/caam_jr: add enqueue dequeue operations

2018-10-22 Thread Gagandeep Singh
This patch add support for : 1. creating run time sec hw decriptors for a given request. 2. enqueue operation to the caam jr ring 3. dequeue operation from the caam jr ring in poll mode 4. creating a crypto protocol descriptor for session - first time. Signed-off-by: Gagandeep Singh Signed-off-by

[dpdk-dev] [PATCH v5 13/15] crypto/caam_jr: add security offload

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch provides the support for protocol offload to the hardware. following security operations are added: - session_create - session_destroy - capabilities_get Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal --- drivers/crypto/c

[dpdk-dev] [PATCH v5 08/15] crypto/caam_jr: add session configuration methods

2018-10-22 Thread Gagandeep Singh
This patch add support to create session configuration of various types i.e. cipher, auth and aead etc. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 214 +++ 1 file changed, 214 insertions(

[dpdk-dev] [PATCH v5 09/15] crypto/caam_jr: add device cababilities

2018-10-22 Thread Gagandeep Singh
add device capabilities for supported algorithms, key length etc. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/Makefile | 1 + drivers/crypto/caam_jr/caam_jr.c | 2 + drivers/crypto/caam_jr/caam_jr_

[dpdk-dev] [PATCH v5 07/15] crypto/caam_jr: add queue pair config ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal add following ops for configuring queues - queue_pair_setup - queue_pair_release - queue_pair_count Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 64 1 file ch

[dpdk-dev] [PATCH v5 06/15] crypto/caam_jr: add device basic ops

2018-10-22 Thread Gagandeep Singh
This patch adds following device operations - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 98 +++- 1 file changed, 97

[dpdk-dev] [PATCH v5 05/15] crypto/caam_jr: add basic job ring routines

2018-10-22 Thread Gagandeep Singh
This patch adds following job ring routines - init_job_ring (configure hw/sw resources) - shutdown_job_ring (releases hw/sw resources) - close_job_ring (flush job ring) Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c |

[dpdk-dev] [PATCH v5 03/15] crypto/caam_jr: add routines to configure HW

2018-10-22 Thread Gagandeep Singh
This patch add routines for configuring the hw to support various features. These routines will be used by the PMD ops. The patch also defines structure and macros used to access hw capabilities. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/cry

[dpdk-dev] [PATCH v5 01/15] crypto/caam_jr: introduce basic driver

2018-10-22 Thread Gagandeep Singh
The caam_jr poll mode crypto driver is supported for NXP SEC 4.x+ (CAAM) hardware accelerator. This driver is by default supported on LE platforms, if it is used on BE platforms like LS104X, config option CONFIG_RTE_LIBRTE_PMD_CAAM_JR_BE can be enabled. This patch add skeleton for caam jobring dri

[dpdk-dev] [PATCH v5 04/15] crypto/caam_jr: add UIO specific operations

2018-10-22 Thread Gagandeep Singh
caam_jr need support from kernel caam driver for job ring initialisation. So to access register space for job ring and allow re configure and map to userspace UIO interface is used. This also allows to handle the caam interrupts from the user space. This patch adds UIO specific operations Signed-

[dpdk-dev] [PATCH v5 02/15] crypto/caam_jr: add HW tuning options

2018-10-22 Thread Gagandeep Singh
caam_jr hardware can be tuned for multiple settings like ring depth, coalescing, notification types, cache size etc. These parameter can be used for performance tuning for various platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/

[dpdk-dev] [PATCH v5 00/15] Introducing the NXP CAAM job ring driver

2018-10-22 Thread Gagandeep Singh
v4->v5 change-log: * compilation issue fixed v3->v4 change-log: * local dma_addr_t definition removed v2->v3 change-log: * fix CONFIG_RTE_LIBRTE_SECURITY=n compilation. v1->v2 change-log: * Most of the checkpatch warnings and erros are removed * CONFIG_RTE_CAAM_JR_PMD_MAX_NB_SESSIONS and CONFI

Re: [dpdk-dev] [PATCH v4 00/15] Introducing the NXP CAAM job ring driver

2018-10-22 Thread Gagandeep Singh
> -Original Message- > From: Gagandeep Singh > Sent: Monday, October 22, 2018 7:48 PM > To: dev@dpdk.org; Akhil Goyal > Cc: Gagandeep Singh > Subject: [PATCH v4 00/15] Introducing the NXP CAAM job ring driver > > v3->v4 change-log: > * local dma_addr_t definition removed > Self NACK

Re: [dpdk-dev] [PATCH v5 0/3] ethdev: add generic raw tunnel encapsulation actions

2018-10-22 Thread Ferruh Yigit
On 10/17/2018 6:07 PM, Ori Kam wrote: > This series implement the raw tunnel encapsulation actions > and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" > > Currenlty the encap/decap actions only support encapsulation > of VXLAN and NVGRE L2 packets (L2 encapsulation is where

Re: [dpdk-dev] [RFC] ethdev: make offload name API non-experimental

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 6:35 PM, Stephen Hemminger wrote: > The offload name functions are useful, but since they are > marked experimental they can not be used by upstream projects. > For example, VPP duplicates the same table in its code. > > Signed-off-by: Stephen Hemminger +1, they have been added on

[dpdk-dev] Issues configuring OVS-DPDK in openstack queens

2018-10-22 Thread Manojawa Paritala
Hello All, On a 3 node (one controller + 2 compute), we configured Openstack Queens using OSA with OVS. On all the nodes, we defined br-mgmt as linux bridge, br-tun as private network and br-flat as external. Installation was successful and we could create networks and instances on Openstack. Bel

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Ori Kam
Just a clarification, Following a talk with Andrew regarding his comments about missing documentation in V4 it was agreed that no documentation change is needed. The only comment is the typo, which Ferruh agreed to correct when applying the patch. Thanks, Ori > -Original Message- > Fr

Re: [dpdk-dev] [PATCH 0/3] net/enic: minor bug fixes

2018-10-22 Thread Ferruh Yigit
On 10/20/2018 9:32 AM, Hyong Youb Kim wrote: > Fix a couple bugs found during internal testing, and update the > release notes, which was missing in previous patches. > > The second patch ("net/enic: add missing Tx offload flags") addresses > a side effect from the following commit, which adds sev

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-22 Thread Andrew Rybchenko
On 10/22/18 4:15 PM, Thomas Monjalon wrote: The MAC addresses of a port can be matched with devargs. As the conflict between rte_ether.h and netinet/ether.h is not resolved, the MAC parsing is done with a rte_cmdline function. As a result, cmdline library becomes a dependency of ethdev. Signed-

Re: [dpdk-dev] [PATCH 1/3] net/enic: fix supported packet types

2018-10-22 Thread Ferruh Yigit
On 10/20/2018 9:32 AM, Hyong Youb Kim wrote: > The handler for dev_supported_ptypes_get currently returns null when > the vectorized Rx handler is used. It is also missing tunnel packet > types. Add the missing packet types to the supported list, and return > the right list for the vectorized Rx ha

[dpdk-dev] [PATCH v4 14/15] doc: add caam jr cryptodev details

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal add caam jr driver details, supported features and algorithms in the document. release note and MAINTAINERS are also updated. Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal --- MAINTAINERS| 2 + doc/g

[dpdk-dev] [PATCH v4 15/15] test/crypto: add CAAM JR driver validation test cases

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the validation test cases for CAAM JR driver Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh Reviewed-by: Akhil Goyal --- test/test/test_cryptodev.c | 138 +++ test/test/test_cryptodev.h |

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-22 Thread Andrew Rybchenko
On 10/22/18 5:02 PM, Thomas Monjalon wrote: 22/10/2018 15:37, Andrew Rybchenko: On 10/22/18 4:15 PM, Thomas Monjalon wrote: The MAC addresses of a port can be matched with devargs. As the conflict between rte_ether.h and netinet/ether.h is not resolved, the MAC parsing is done with a rte_cmdli

[dpdk-dev] [PATCH v4 13/15] crypto/caam_jr: add security offload

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch provides the support for protocol offload to the hardware. following security operations are added: - session_create - session_destroy - capabilities_get Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal --- drivers/crypto/c

[dpdk-dev] [PATCH v4 11/15] crypto/caam_jr: add scatter gather

2018-10-22 Thread Gagandeep Singh
This patch add the scatter gather feature for auth-only, cipher-only and cipher-auth operations Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 375 ++- 1 file changed, 374 insertions(+), 1 de

[dpdk-dev] [PATCH v4 12/15] crypto/caam_jr: add statistics ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the following statistics operations: - stats_get - stats_reset Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 54 1 file changed, 54 insertions(+

[dpdk-dev] [PATCH v4 09/15] crypto/caam_jr: add device cababilities

2018-10-22 Thread Gagandeep Singh
add device capabilities for supported algorithms, key length etc. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/Makefile | 1 + drivers/crypto/caam_jr/caam_jr.c | 2 + drivers/crypto/caam_jr/caam_jr_

[dpdk-dev] [PATCH v4 10/15] crypto/caam_jr: add enqueue dequeue operations

2018-10-22 Thread Gagandeep Singh
This patch add support for : 1. creating run time sec hw decriptors for a given request. 2. enqueue operation to the caam jr ring 3. dequeue operation from the caam jr ring in poll mode 4. creating a crypto protocol descriptor for session - first time. Signed-off-by: Gagandeep Singh Signed-off-by

[dpdk-dev] [PATCH v4 08/15] crypto/caam_jr: add session configuration methods

2018-10-22 Thread Gagandeep Singh
This patch add support to create session configuration of various types i.e. cipher, auth and aead etc. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 214 +++ 1 file changed, 214 insertions(

[dpdk-dev] [PATCH v4 07/15] crypto/caam_jr: add queue pair config ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal add following ops for configuring queues - queue_pair_setup - queue_pair_release - queue_pair_count Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 64 1 file ch

[dpdk-dev] [PATCH v4 06/15] crypto/caam_jr: add device basic ops

2018-10-22 Thread Gagandeep Singh
This patch adds following device operations - dev_configure - dev_start - dev_stop - dev_close - dev_infos_get Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 98 +++- 1 file changed, 97

[dpdk-dev] [PATCH v4 05/15] crypto/caam_jr: add basic job ring routines

2018-10-22 Thread Gagandeep Singh
This patch adds following job ring routines - init_job_ring (configure hw/sw resources) - shutdown_job_ring (releases hw/sw resources) - close_job_ring (flush job ring) Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c |

[dpdk-dev] [PATCH v4 04/15] crypto/caam_jr: add UIO specific operations

2018-10-22 Thread Gagandeep Singh
caam_jr need support from kernel caam driver for job ring initialisation. So to access register space for job ring and allow re configure and map to userspace UIO interface is used. This also allows to handle the caam interrupts from the user space. This patch adds UIO specific operations Signed-

[dpdk-dev] [PATCH v4 03/15] crypto/caam_jr: add routines to configure HW

2018-10-22 Thread Gagandeep Singh
This patch add routines for configuring the hw to support various features. These routines will be used by the PMD ops. The patch also defines structure and macros used to access hw capabilities. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/cry

[dpdk-dev] [PATCH v4 02/15] crypto/caam_jr: add HW tuning options

2018-10-22 Thread Gagandeep Singh
caam_jr hardware can be tuned for multiple settings like ring depth, coalescing, notification types, cache size etc. These parameter can be used for performance tuning for various platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/

[dpdk-dev] [PATCH v4 01/15] crypto/caam_jr: introduce basic driver

2018-10-22 Thread Gagandeep Singh
The caam_jr poll mode crypto driver is supported for NXP SEC 4.x+ (CAAM) hardware accelerator. This driver is by default supported on LE platforms, if it is used on BE platforms like LS104X, config option CONFIG_RTE_LIBRTE_PMD_CAAM_JR_BE can be enabled. This patch add skeleton for caam jobring dri

[dpdk-dev] [PATCH v4 00/15] Introducing the NXP CAAM job ring driver

2018-10-22 Thread Gagandeep Singh
v3->v4 change-log: * local dma_addr_t definition removed v2->v3 change-log: * fix CONFIG_RTE_LIBRTE_SECURITY=n compilation. v1->v2 change-log: * Most of the checkpatch warnings and erros are removed * CONFIG_RTE_CAAM_JR_PMD_MAX_NB_SESSIONS and CONFIG_RTE_PMD_CAAM_JR_DEBUG flags removed * local

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Andrew Rybchenko
On 10/17/18 8:07 PM, Ori Kam wrote: Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, while L3 encapsulation is where the inner packet doesn't have the Ethernet header). In addtion th

Re: [dpdk-dev] [PATCH v6 05/13] telemetry: add client feature and sockets

2018-10-22 Thread Mattias Rönnblom
On 2018-10-22 13:00, Kevin Laatz wrote: From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to e

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-22 Thread Thomas Monjalon
22/10/2018 15:37, Andrew Rybchenko: > On 10/22/18 4:15 PM, Thomas Monjalon wrote: > > The MAC addresses of a port can be matched with devargs. > > > > As the conflict between rte_ether.h and netinet/ether.h is not resolved, > > the MAC parsing is done with a rte_cmdline function. > > As a result, c

Re: [dpdk-dev] [PATCH] examples/vdpa: fix spelling error in message

2018-10-22 Thread Ferruh Yigit
On 10/19/2018 6:20 PM, Stephen Hemminger wrote: > On Thu, 18 Oct 2018 23:19:18 + > "Van Haaren, Harry" wrote: > >>> -Original Message- >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger >>> Sent: Thursday, October 18, 2018 3:35 PM >>> To: dev@dpdk.org >>> Cc: S

Re: [dpdk-dev] [PATCH v6 04/13] telemetry: add initial connection socket

2018-10-22 Thread Mattias Rönnblom
On 2018-10-22 13:00, Kevin Laatz wrote: From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage

Re: [dpdk-dev] [PATCH] doc: spelling fixes

2018-10-22 Thread Ferruh Yigit
On 10/22/2018 9:52 AM, Kovacevic, Marko wrote: >> Trivial pelling errors found by codespell. >> >> Signed-off-by: Stephen Hemminger >> --- >> doc/guides/eventdevs/opdl.rst | 2 +- >> doc/guides/nics/axgbe.rst | 2 +- >> doc/guides/nics/enic.rst | 2 +- >> doc/guides/nics/mvpp2.rst |

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-22 Thread Andrew Rybchenko
On 10/22/18 4:15 PM, Thomas Monjalon wrote: The MAC addresses of a port can be matched with devargs. As the conflict between rte_ether.h and netinet/ether.h is not resolved, the MAC parsing is done with a rte_cmdline function. As a result, cmdline library becomes a dependency of ethdev. Signed-

[dpdk-dev] [PATCH v3 15/15] test/crypto: add CAAM JR driver validation test cases

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the validation test cases for CAAM JR driver Signed-off-by: Hemant Agrawal Reviewed-by: Akhil Goyal --- test/test/test_cryptodev.c | 138 +++ test/test/test_cryptodev.h | 1 + test/test/test_cryptodev_a

[dpdk-dev] [PATCH v3 14/15] doc: add caam jr cryptodev details

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal add caam jr driver details, supported features and algorithms in the document. release note and MAINTAINERS are also updated. Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- MAINTAINERS| 2 + doc/guides/cryptodevs/caam_jr.rst

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add raw encapsulation action

2018-10-22 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 22, 2018 4:28 PM > To: Ori Kam ; wenzhuo...@intel.com; > jingjing...@intel.com; bernard.iremon...@intel.com; ferruh.yi...@intel.com; > step...@networkplumber.org; Adrien Mazarguil > > Cc: dev@dpdk.org; Dekel Peled ; T

Re: [dpdk-dev] [PATCH v2 02/14] crypto/caam_jr: add HW tuning options

2018-10-22 Thread Ali Alnubani
Hi Gagandeep, I was able to reproduce with: ./devtools/test-build.sh x86_64-native-linuxapp-clang+MLX4_PMD+MLX5_PMD~KMOD~SOFTNIC~UIO Environment info: OS: RHEL7.4 (with kernel 4.19.0-rc7-mlnx) and RHEL7.5 (with kernel 3.10.0-862.el7.x86_64) Clang: clang version 3.4.2 (tags/RELEASE_34/

[dpdk-dev] [PATCH v3 13/15] crypto/caam_jr: add security offload

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch provides the support for protocol offload to the hardware. following security operations are added: - session_create - session_destroy - capabilities_get Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c |

[dpdk-dev] [PATCH v3 12/15] crypto/caam_jr: add statistics ops

2018-10-22 Thread Gagandeep Singh
From: Hemant Agrawal This patch adds the following statistics operations: - stats_get - stats_reset Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal Acked-by: Akhil Goyal --- drivers/crypto/caam_jr/caam_jr.c | 54 1 file changed, 54 insertions(+

  1   2   >