Re: [dpdk-dev] [PATCH 2/2] devargs: rename enum items with singular form

2018-10-09 Thread Andrew Rybchenko
On 10/3/18 10:40 PM, Thomas Monjalon wrote: The enum names are *_params (plural form). And the items are also using the plural form: *_PARAMS_*. It looks more natural to use the singular form *_PARAM_* for items. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 1/2] bus/pci: rename devargs parameter id to addr

2018-10-09 Thread Andrew Rybchenko
On 10/3/18 10:40 PM, Thomas Monjalon wrote: We could match devices by their PCI id (vendor id, device id, etc). But for now, only matching by PCI address is implemented. The devargs parameter "id" is renamed "addr" to reflect its real meaning. Signed-off-by: Thomas Monjalon Reviewed-by: Andre

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-09 Thread Andrew Rybchenko
On 10/9/18 7:48 PM, Ferruh Yigit wrote: On 10/7/2018 1:57 PM, Ori Kam wrote: This series implement the generic L2/L3 tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NV

[dpdk-dev] [PATCH] net/ifc: invoke ifcvf HW init function in probe

2018-10-09 Thread Xiaolong Ye
As ifcvf_init_hw is independent with ifcvf_vfio_setup, it's better to invoke it directly in probe func. Signed-off-by: Xiaolong Ye --- drivers/net/ifc/ifcvf_vdpa.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa

Re: [dpdk-dev] [PATCH] fix static variables

2018-10-09 Thread Zhang, Tianfei
> diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > index f0939dc32..848e5183a 100644 > --- a/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > +++ b/drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c > @@ -104,14 +104,14 @@ static struc

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-09 Thread Gavin Hu (Arm Technology China)
Hi Jerin, Following the guide to use the PMU counters(KO inserted and DPDK recompiled), the numbers increased 10+ folds(bigger numbers here mean more precise?), is this valid and expected? No significant difference was seen. gavin@net-arm-thunderx2:~/community/dpdk$ sudo ./test/test/test -l

Re: [dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-09 Thread Andrew Rybchenko
On 10/10/18 1:17 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should che

Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-09 Thread Zhang, Tianfei
> .../raw/ifpga_rawdev/base/ifpga_enumerate.c | 8 ++-- > .../raw/ifpga_rawdev/base/ifpga_feature_dev.h | 8 ++-- > drivers/raw/ifpga_rawdev/base/ifpga_port.c| 6 +-- > .../raw/ifpga_rawdev/base/ifpga_port_error.c | 2 +- For ifpga_rawdev part, it looks good for me. Acked-by: Tianfei z

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: fixes for the new flow engine

2018-10-09 Thread Shahaf Shuler
Tuesday, October 9, 2018 6:49 PM, Ferruh Yigit: > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: fixes for the new flow engine > > On 10/9/2018 9:58 AM, Shahaf Shuler wrote: > > Monday, October 8, 2018 9:02 PM, Yongseok Koh: > >> Subject: [PATCH 0/7] net/mlx5: fixes for the new flow engine [...]

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-09 Thread Joseph, Anoob
Hi Fiona, We were following the QAT approach for defining the capabilities. OCTEON TX crypto PMD has similar number of capabilities and QAT was the close model that we could follow. I can see the advantages of the macro approach, but that would give a checkpatch warning. Also, Thomas didn't r

Re: [dpdk-dev] [PATCH v2] net/mlx5: support multiple groups and jump action

2018-10-09 Thread Shahaf Shuler
Wednesday, October 10, 2018 5:48 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: support multiple groups and jump action > On Tue, Oct 09, 2018 at 05:50:30AM -0700, Shahaf Shuler wrote: > > Hi Koh, > > Few comments. > > > > Monday, October 8, 2018 9:06 PM¸ Yongseok Koh: > > > Subject: [PATCH

Re: [dpdk-dev] [PATCH v2] crypto: fix element size for undefined crypto op

2018-10-09 Thread Akhil Goyal
On 10/10/2018 10:40 AM, Akhil Goyal wrote: On 10/9/2018 7:46 PM, Junxiao Shi wrote: The documentation of rte_crypto_op_pool_create indicates that specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that supports all operation types. This change makes the code consistent with documen

Re: [dpdk-dev] [PATCH v2] crypto: fix element size for undefined crypto op

2018-10-09 Thread Akhil Goyal
On 10/9/2018 7:46 PM, Junxiao Shi wrote: The documentation of rte_crypto_op_pool_create indicates that specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that supports all operation types. This change makes the code consistent with documentation. Fixes: c0f87eb5252b ("cryptodev: chan

Re: [dpdk-dev] Correct use of Arm related names

2018-10-09 Thread Honnappa Nagarahalli
Apologies, removing the disclaimer at the bottom. > -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Tuesday, October 9, 2018 11:37 PM > To: dev@dpdk.org > Cc: Jacob, Jerin ; Gavin Hu (Arm > Technology China) ; Hemant Agrawal > ; debayang.qdt > ; Thomas Monjalon >

[dpdk-dev] Correct use of Arm related names

2018-10-09 Thread Honnappa Nagarahalli
Hi, This email was triggered by a request to change ARM to Arm in the dpdk.org webpage. I went down the path of finding out the correct names to use. There has not been consistency in using these names across all other projects. So, the recommendation I have got is, 'choose something and use it

Re: [dpdk-dev] [PATCH] net/ifc: fix function name

2018-10-09 Thread Ye Xiaolong
Acked-by: Ye Xiaolong Thanks, Xiaolong On 09/25, Xiao Wang wrote: >The address translation from user virtual address to guest physical >address should not be named as qva_to_gpa. > >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > >Signed-off-by: Xiao Wang >--- > drivers/net/ifc/ifcvf

Re: [dpdk-dev] [PATCH v4 2/2] hash table: add an iterator over conflicting entries

2018-10-09 Thread Wang, Yipeng1
Hi, Qiaobin, Could you try to rebase on this patch set? (http://patchwork.dpdk.org/cover/46106/) I checked your patch and I think there won't be many functional issues merging our patches. Let's coordinate to make sure the final merge is easier. Other comments inlined: >-Original Messag

[dpdk-dev] [PATCH v3] net/mlx5: support multiple groups and jump action

2018-10-09 Thread Yongseok Koh
rte_flow has 'group' attribute and 'jump' action in order to support multiple groups. This feature is known as multi-table support ('chain' in linux TC flower) in general because a group means a table of flows. Example commands are: flow create 0 transfer priority 1 ingress pa

[dpdk-dev] [PATCH] net/enic: fix counter action

2018-10-09 Thread John Daley
- track whether counter DMAs are active or not so they can be stopped if needed before DMA memory is freed - fix counter DMA shut-down by changing vnic_dev_counter_dma_cfg() to take the number of counters to DMA instead of high counter index and use num counters = 0 to shut off DMAs - remove

[dpdk-dev] [PATCH] maintainers: use registered name for OCTEON TX references

2018-10-09 Thread Anoob Joseph
'OCTEON TX' is the registered name. All other usages need to be fixed. Signed-off-by: Anoob Joseph --- MAINTAINERS | 8 doc/guides/compressdevs/features/octeontx.ini | 2 +- doc/guides/compressdevs/octeontx.rst | 24

Re: [dpdk-dev] [PATCH v2] net/mlx5: support multiple groups and jump action

2018-10-09 Thread Yongseok Koh
On Tue, Oct 09, 2018 at 05:50:30AM -0700, Shahaf Shuler wrote: > Hi Koh, > Few comments. > > Monday, October 8, 2018 9:06 PM¸ Yongseok Koh: > > Subject: [PATCH v2] net/mlx5: support multiple groups and jump action > > > > rte_flow has 'group' attribute and 'jump' action in order to support > >

[dpdk-dev] [PATCH] vhost: add doxygen comment to vDPA header

2018-10-09 Thread Xiaolong Ye
As APIs in rte_vdpa.h are public, we need to add doxygen comments to all APIs and structures. Signed-off-by: Xiaolong Ye --- doc/api/doxy-api-index.md | 1 + lib/librte_vhost/rte_vdpa.h | 54 + 2 files changed, 50 insertions(+), 5 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH v4 1/2] hash table: fix a bug in rte_hash_iterate()

2018-10-09 Thread Wang, Yipeng1
Hi Qiaobin, This patch: http://patchwork.dpdk.org/patch/46105/ covers the bug. Honnappa suggested a fix that would work well for the lock free implementation as well. >-Original Message- >From: Qiaobin Fu [mailto:qiaob...@bu.edu] >Sent: Tuesday, October 9, 2018 12:29 PM >To: Richardson,

Re: [dpdk-dev] [PATCH v3 4/4] net/mlx5: add L2 and L3 decap to Direct Verbs flow

2018-10-09 Thread Yongseok Koh
On Tue, Oct 09, 2018 at 10:25:37PM +0300, Dekel Peled wrote: > This patch adds support for Direct Verbs decap operations, L2 and L3. > > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh Thanks > drivers/net/mlx5/mlx5_flow_dv.c | 215 > > 1 fil

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx5: add L2 and L3 encap to Direct Verbs flow

2018-10-09 Thread Yongseok Koh
On Tue, Oct 09, 2018 at 10:25:36PM +0300, Dekel Peled wrote: > This patch adds support for Direct Verbs encap operations, L2 and L3. > > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh Thanks > drivers/net/mlx5/mlx5_flow_dv.c | 227 > +++- > 1 fil

Re: [dpdk-dev] [PATCH v3 2/4] net/mlx5: add Direct Verbs encap and decap defs

2018-10-09 Thread Yongseok Koh
On Tue, Oct 09, 2018 at 10:25:35PM +0300, Dekel Peled wrote: > This patch adds the required definitions for DV encap/decap actions. > It also adds usage of the new actions definition in validation > function of existing drop operation. > > Signed-off-by: Dekel Peled > --- I've acked it in v2. So

Re: [dpdk-dev] [PATCH v3 1/4] net/mlx5: add flow action functions to glue

2018-10-09 Thread Yongseok Koh
On Tue, Oct 09, 2018 at 10:25:34PM +0300, Dekel Peled wrote: > This patch adds glue functions for operations: > - Create packet reformat (encap/decap) flow action. > - Destroy flow action. > > The new operations depend on HAVE_IBV_FLOW_ACTION_DV_SUPPORT. > > Signed-off-by: Dekel Peled > --- > d

Re: [dpdk-dev] [PATCH v3 1/4] net/mlx5: add flow action functions to glue

2018-10-09 Thread Yongseok Koh
On Tue, Oct 09, 2018 at 10:25:34PM +0300, Dekel Peled wrote: > This patch adds glue functions for operations: > - Create packet reformat (encap/decap) flow action. > - Destroy flow action. > > The new operations depend on HAVE_IBV_FLOW_ACTION_DV_SUPPORT. > > Signed-off-by: Dekel Peled > --- > d

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-10-09 Thread Wiles, Keith
> On Oct 8, 2018, at 5:42 PM, Wiles, Keith wrote: > > Hi Everyone, > > I would like to request comments on DFS as I presented at the DPDK summit in > Ireland. Here is a repo you can look at and play with. The code is mostly ready for upstream but still more work needs to be done. https://

[dpdk-dev] [PATCH] app/testpmd: fix flow list command

2018-10-09 Thread John Daley
This patch fixes the 'flow list ' command which caused a segfault when passing the action or item 'type' field instead of the action or item struct pointer in the call to rte_flow_conv. Fixes: 7d94dcedf7ce ("app/testpmd: rely on flow API conversion function") Signed-off-by: John Daley --- app/t

[dpdk-dev] [PATCH v4 4/6] doc: replace doxygen example in contribution guide

2018-10-09 Thread Thomas Monjalon
The provided example of doxygen header is about a deprecated function. It is replaced by rte_spinlock_trylock() which is small and good enough for the purpose. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/contributing/documentation.rst | 15 +-- 1 file

[dpdk-dev] [PATCH v4 5/6] ethdev: remove deprecated attach/detach functions

2018-10-09 Thread Thomas Monjalon
The hotplug attach/detach features are implemented in EAL layer. There is a new ethdev iterator to retrieve ports from ethdev layer. As announced earlier, the (buggy) ethdev functions are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v4 6/6] eal: remove deprecated attach/detach functions

2018-10-09 Thread Thomas Monjalon
These hotplug functions were deprecated and have some new replacements. As announced earlier, the oldest ones are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst| 5 --- doc/guides/rel_notes/release_18_11.rst | 6 +++ lib

[dpdk-dev] [PATCH v4 0/6] replace attach/detach functions

2018-10-09 Thread Thomas Monjalon
The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RT

[dpdk-dev] [PATCH v4 3/6] ethdev: allow iterating with pure class filter

2018-10-09 Thread Thomas Monjalon
If no rte_device is given in the iterator, eth_dev_match() is looking at all ports without any restriction, except the ethdev kvargs filter. It allows to iterate with a devargs filter referencing only some ethdev parameters. The format (from the new devargs syntax) is: class=eth,paramY=Y

[dpdk-dev] [PATCH v4 2/6] ethdev: add iterator to match devargs input

2018-10-09 Thread Thomas Monjalon
The iterator will return the ethdev port ids matching a devargs string. It is recommended to use the macro RTE_ETH_FOREACH_MATCHING_DEV() for usage convenience. The class string is prefixed with '+' in order to skip the validation of the parameter keys. It is tolerated for the compatibility with t

[dpdk-dev] [PATCH v4 1/6] bus/vdev: add iteration filter on name

2018-10-09 Thread Thomas Monjalon
A virtual device can be matched with following syntax: bus=vdev,name=X Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- drivers/bus/vdev/vdev_params.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_params.c

Re: [dpdk-dev] [PATCH v2] net/mlx5: allow multiple probing for representor

2018-10-09 Thread Ophir Munk
PATCH v3 is expected to accommodate more updates in hotplug series by Thomas. Please do not merge this patch. > -Original Message- > From: Yongseok Koh > Sent: Friday, October 05, 2018 9:06 PM > To: Ophir Munk > Cc: dev@dpdk.org; Asaf Penso ; Shahaf Shuler > ; Thomas Monjalon ; > Olga She

[dpdk-dev] [PATCH v2] ethdev: complete closing of port

2018-10-09 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-10-09 Thread Thomas Monjalon
28/09/2018 14:46, Ferruh Yigit: > On 9/8/2018 12:39 AM, Thomas Monjalon wrote: > > After closing a port, it cannot be restarted. > > So there is no reason to not free all associated resources. > > > > The last step was done with rte_eth_dev_detach() which is deprecated. > > Instead of removing the

[dpdk-dev] [PATCH v5 18/19] net/vhost: add parameter to enable postcopy support

2018-10-09 Thread Maxime Coquelin
Introduce a new postcopy-support parameter to Vhost PMD that passes the RTE_VHOST_USER_POSTCOPY_SUPPORT flag at vhost device register time. Flag should only be set if application does not prefault guest memory using, for example, mlockall() syscall. Default value is 0, meaning that postcopy suppo

[dpdk-dev] [PATCH v5 19/19] vhost: enable postcopy protocol feature

2018-10-09 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h index aa8374ee2..14dccdedf 100644 --- a/lib/librte_vhost/vhos

[dpdk-dev] [PATCH v5 17/19] vhost: restrict postcopy live-migration enablement

2018-10-09 Thread Maxime Coquelin
Postcopy live-migration feature requires the application to not populate the guest memory. As the vhost library cannot prevent the application to that (e.g. preventing the application to call mlockall()), the feature is disabled by default. The application should only enable the feature if it does

[dpdk-dev] [PATCH v5 15/19] vhost: send userfault range addresses back to qemu

2018-10-09 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 49 --- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 96290fdb4..170d258c4

[dpdk-dev] [PATCH v5 13/19] vhost: register new regions with userfaultfd

2018-10-09 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 35fb4a773..54c0210fb 100644 --- a/lib/librte_

[dpdk-dev] [PATCH v5 16/19] vhost: add support to postcopy's end request

2018-10-09 Thread Maxime Coquelin
The master sends this message before stopping handling userfaults, so that the backend closes the userfaultfd. The master waits for the slave to acknowledge the request with an empty 64bits payload for synchronization purpose. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH v5 14/19] vhost: avoid useless VhostUserMemory copy

2018-10-09 Thread Maxime Coquelin
The VHOST_USER_SET_MEM_TABLE payload is copied when handled, whereas it could directly be referenced. This is not very important, but next, we'll need to update the payload and send it back to Qemu. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin Acked-by: Ilya Maximets --

[dpdk-dev] [PATCH v5 12/19] vhost: add support for postcopy's listen message

2018-10-09 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 21 + lib/librte_vhost/vhost_user.h | 3 ++- 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h

[dpdk-dev] [PATCH v5 09/19] vhost: enable fds passing when sending vhost-user messages

2018-10-09 Thread Maxime Coquelin
Passing userfault fds to Qemu will be required for postcopy live-migration feature. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v5 11/19] vhost: introduce postcopy's advise message

2018-10-09 Thread Maxime Coquelin
This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE request. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 2 ++ lib/librte_vhost/vhost_user.c | 50 +++ lib/librte_vhost

[dpdk-dev] [PATCH v5 10/19] vhost: add config flag for postcopy feature

2018-10-09 Thread Maxime Coquelin
Postcopy live-migration features relies on userfaultfd, which was only introduced in kernel v4.3. This patch introduces a new define to allow building vhost library on kernels not supporting userfaultfd. With legacy build system, user has to explicitly set CONFIG_RTE_LIBRTE_VHOST_POSTCOPY to 'y'.

[dpdk-dev] [PATCH v5 08/19] vhost: pass socket fd to message handling callbacks

2018-10-09 Thread Maxime Coquelin
This is not used for now, but will be needed for the special handling of VHOST_USER_SET_MEM_TABLE message once postcopy will be supported. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 71 +++ 1 file changed, 47 insertions(+), 24 deletions(-)

[dpdk-dev] [PATCH v5 04/19] vhost: fix payload size of reply

2018-10-09 Thread Maxime Coquelin
QEMU doesn't expect any payload for the reply of VHOST_USER_SET_LOG_BASE request, so don't send any. Note that the Vhost-user specification isn't clear about it and would need to be fixed. Fixes: 54f9e32305d4 ("vhost: handle dirty pages logging request") Cc: sta...@dpdk.org Reported-by: Ilya Maxi

[dpdk-dev] [PATCH v5 07/19] vhost: add number of fds to vhost-user messages and use it

2018-10-09 Thread Maxime Coquelin
As soons as some anciliarry datai (fds) are received, it is copied without checking its length. This patch adds adds the number of fds received to the message, which is set in read_vhost_message(). This is preliminary work to support sending fds to Qemu. Signed-off-by: Dr. David Alan Gilbert Si

[dpdk-dev] [PATCH v5 06/19] vhost: define postcopy protocol flag

2018-10-09 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin Acked-by: Ilya Maximets Reviewed-by: Tiwei Bie --- lib/librte_vhost/rte_vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index b02673d4a..9292c89c5 10

[dpdk-dev] [PATCH v5 05/19] vhost: fix error handling when mem table gets updated

2018-10-09 Thread Maxime Coquelin
When the memory table gets updated, the rings addresses need to be translated again. If it fails, we need to exit cleanly by unmapping memory regions. Fixes: d5022533c20a ("vhost: retranslate vring addr when memory table changes") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin Acked-by: Ilya

[dpdk-dev] [PATCH v5 01/19] vhost: fix messages results handling

2018-10-09 Thread Maxime Coquelin
Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being treated as errors. External post and pre callbacks retur

[dpdk-dev] [PATCH v5 00/19] vhost: add postcopy live-migration support

2018-10-09 Thread Maxime Coquelin
In this v5: - Move VHOST_USER_PROTOCOL_F_PAGEFAULT disablement if zero copy is requested to socket.c, and emit a warning if it happens (Ilya) - Reset postcopy_ufd after it is closed in vhost_user_postcopy_advise error path (Ilya) - Rework pre/post message handler callback to return vh_result

[dpdk-dev] [PATCH v5 03/19] vhost: clarify reply-ack in case a reply was already sent

2018-10-09 Thread Maxime Coquelin
For messages that require a reply, a second ack should not be sent when reply-ack protocol feature is negotiated, even if the corresponding flag is set in the message. The code is compliant with the spec but it isn't clear it is, so this patch adds a comment to make it explicit. Suggested-by: Ily

[dpdk-dev] [PATCH v5 02/19] vhost: fix return code of messages requiring replies

2018-10-09 Thread Maxime Coquelin
VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_LOG_BASE require replies, so their handlers should return VH_RESULT_REPLY, not VH_RESULT_OK. Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature") Signed-off-by: Maxime Coquelin Acked-by: Ilya Maxim

[dpdk-dev] [PATCH v2 3/3] doc: update cryptodev and release note

2018-10-09 Thread Fan Zhang
Signed-off-by: Fan Zhang --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/rel_notes/release_18_11.rst | 4 2 files changed, 5 insertions(+) diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rst index c29295002..63e060d75 100644 --- a/doc/guides/cr

[dpdk-dev] [PATCH v2 0/3] crypto/aesni_mb: add aes-gcm support

2018-10-09 Thread Fan Zhang
This patchset adds the AES-GCM algorithm support to AESNI-MB Cryptodev PMD and updates the unit test and documentations along. v2: - rebased on top of latest dpdk-next-crypto. - removed incorrect __rte_unused macros. Fan Zhang (3): crypto/aesni_mb: add aes-gcm algorithm support test/test_cryp

[dpdk-dev] [PATCH v2 2/3] test/test_cryptodev: add AES-GCM tests to AESNI-MB

2018-10-09 Thread Fan Zhang
Signed-off-by: Fan Zhang --- test/test/test_cryptodev.c | 114 + 1 file changed, 114 insertions(+) diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index e9f2c8f94..32600dea2 100644 --- a/test/test/test_cryptodev.c +++ b/test/test/t

[dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: add aes-gcm algorithm support

2018-10-09 Thread Fan Zhang
This patch adds AES-GCM algorithm support to AESNI-MB PMD. Signed-off-by: Fan Zhang --- drivers/crypto/aesni_mb/aesni_mb_ops.h | 28 +++- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 160 +++-- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 30 dr

Re: [dpdk-dev] [PATCH v3 8/8] doc: add guides for fips validation

2018-10-09 Thread Zhang, Roy Fan
Hi Akhil, To obtain request files the applicant has to fill the validation request to FIPS lab. However to test the application the response files can be used. The application will attach an extra line with computed results of the test cases and it will be fairly easy to check :-). Please be su

[dpdk-dev] [PATCH v3 2/4] net/mlx5: add Direct Verbs encap and decap defs

2018-10-09 Thread Dekel Peled
This patch adds the required definitions for DV encap/decap actions. It also adds usage of the new actions definition in validation function of existing drop operation. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow.c | 8 drivers/net/mlx5/mlx5_flow.h | 6 ++ 2 files chan

[dpdk-dev] [PATCH v3 4/4] net/mlx5: add L2 and L3 decap to Direct Verbs flow

2018-10-09 Thread Dekel Peled
This patch adds support for Direct Verbs decap operations, L2 and L3. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow_dv.c | 215 1 file changed, 215 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c i

[dpdk-dev] [PATCH v3 3/4] net/mlx5: add L2 and L3 encap to Direct Verbs flow

2018-10-09 Thread Dekel Peled
This patch adds support for Direct Verbs encap operations, L2 and L3. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow_dv.c | 227 +++- 1 file changed, 222 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/

[dpdk-dev] [PATCH v3 1/4] net/mlx5: add flow action functions to glue

2018-10-09 Thread Dekel Peled
This patch adds glue functions for operations: - Create packet reformat (encap/decap) flow action. - Destroy flow action. The new operations depend on HAVE_IBV_FLOW_ACTION_DV_SUPPORT. Signed-off-by: Dekel Peled --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/meson.build | 2 ++ d

[dpdk-dev] [PATCH v3 0/4] add support of Direct Verbs encap and decap actions

2018-10-09 Thread Dekel Peled
This series adds support of encap and decap actions in DV format. It is using the generic encapsulation framework from [1]. Note that encap action is relevant for egress only. Hence this series should be merged on top of [2]. [1] "ethdev: add generic L2/L3 tunnel encapsulation actions" http://

[dpdk-dev] [PATCH v4 1/2] hash table: fix a bug in rte_hash_iterate()

2018-10-09 Thread Qiaobin Fu
In current implementation of rte_hash_iterate(), it tries to obtain the lock after the while loop. However, this may lead to a bug. Notice the following racing condition: 1. The while loop above finishes because it finds a not empty slot. But it does so without a lock. 2. Then we get the lock.

[dpdk-dev] [PATCH v4 2/2] hash table: add an iterator over conflicting entries

2018-10-09 Thread Qiaobin Fu
Function rte_hash_iterate_conflict_entries_with_hash() iterates over the entries that conflict with an incoming entry. Iterating over conflicting entries enables one to decide if the incoming entry is more valuable than the entries already in the hash table. This is particularly useful after an in

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: add flow action functions to glue

2018-10-09 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Yongseok Koh > Sent: Monday, October 8, 2018 10:43 PM > To: Dekel Peled > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH v2 1/4] net/mlx5: add flow action functions to glue > > On Sun, Oct 07, 2018 at 05:25:05PM +0300, Dekel P

Re: [dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API

2018-10-09 Thread Rahul Lakkireddy
On Tuesday, October 10/09/18, 2018 at 20:19:54 +0530, Ferruh Yigit wrote: > On 9/24/2018 9:29 AM, Rahul Lakkireddy wrote: > > This action is useful for offloading loopback mode, where the hardware > > will swap source and destination MAC addresses in the outermost Ethernet > > header before looping

[dpdk-dev] [RFC v2 4/9] lib: introduce ipsec library

2018-10-09 Thread Konstantin Ananyev
Introduce librte_ipsec library. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. That initial commit provides some base API to manage IPsec Security Association (SA) object. Signed-off-by: Mohammad Abdul Awal

[dpdk-dev] [RFC v2 8/9] ipsec: helper functions to group completed crypto-ops

2018-10-09 Thread Konstantin Ananyev
Introduce helper functions to process completed crypto-ops and group related packets by sessions they belong to. Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/Makefile | 1 + lib/librte_ipsec/meson.build | 2 +- lib/librte_ipsec/rte_ipsec.h | 2 +

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-10-09 Thread Ananyev, Konstantin
Hi Jerin, > > > > > static inline rte_ipsec_add_tunnel_hdr(struct rte_mbuf *mbuf); > > > static inline rte_ipsec_update_sqn(struct rte_mbuf *mbuf, &seq_no); > > > ... > > > > > > For the regular use case, a fat > > > rte_ipsec_(inbound/outbound)_(prepare/process) can be provided. The > > > worker

[dpdk-dev] [RFC v2 9/9] test/ipsec: introduce functional test

2018-10-09 Thread Konstantin Ananyev
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Bernard Iremonger --- test/test/Makefile |3 + test/test/meson.build |3 + test/test/test_ipsec.c | 1329 3 files changed, 1335 insertions(+) create mode 100644 test/test/test_ipsec.c

[dpdk-dev] [RFC v2 6/9] ipsec: implement SA data-path API

2018-10-09 Thread Konstantin Ananyev
Provide implementation for rte_ipsec_crypto_prepare() and rte_ipsec_process(). Current implementation: - supports ESP protocol tunnel mode only. - supports ESN and replay window. - supports algorithms: AES-CBC, AES-GCM, HMAC-SHA1, NULL. - covers all currently defined security session types:

[dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API

2018-10-09 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related

[dpdk-dev] [RFC v2 0/9] ipsec: new library for IPsec data-path processing

2018-10-09 Thread Konstantin Ananyev
This RFC targets 19.02 release. This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transpare

[dpdk-dev] [RFC v2 7/9] ipsec: rework SA replay window/SQN for MT environment

2018-10-09 Thread Konstantin Ananyev
With these changes functions: - rte_ipsec_crypto_prepare - rte_ipsec_process can be safely used in MT environment, as long as the user can guarantee that they obey multiple readers/single writer model for SQN+replay_window operations. To be more specific: for outbound SA there are no restr

[dpdk-dev] [RFC v2 3/9] net: add ESP trailer structure definition

2018-10-09 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2dd 100644 --- a/lib/librte_net/rte_esp.h +++ b/lib/librte_net/rte_esp.h @@ -11,7

[dpdk-dev] [RFC v2 2/9] security: add opaque userdata pointer into security session

2018-10-09 Thread Konstantin Ananyev
Add 'uint64_t userdata' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_security/rte_

[dpdk-dev] [RFC v2 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-10-09 Thread Konstantin Ananyev
Add 'uint64_t userdata' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_crypto

Re: [dpdk-dev] [PATCH 2/4] mk: remove broken check

2018-10-09 Thread Neil Horman
On Tue, Oct 09, 2018 at 01:53:46PM +0200, Thomas Monjalon wrote: > 09/10/2018 13:43, Neil Horman: > > On Tue, Oct 09, 2018 at 04:18:56AM +0200, Thomas Monjalon wrote: > > > Next patch does not pass the experimental check > > > because it has an (unrelated) experimental function in his context. > >

Re: [dpdk-dev] [PATCH v4 01/19] vhost: fix messages error checks

2018-10-09 Thread Maxime Coquelin
On 10/09/2018 02:54 PM, Tiwei Bie wrote: On Tue, Oct 09, 2018 at 02:20:47PM +0200, Maxime Coquelin wrote: On 10/09/2018 10:03 AM, Tiwei Bie wrote: On Mon, Oct 08, 2018 at 05:25:39PM +0200, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negativ

Re: [dpdk-dev] [PATCH 1/4] kvargs: support list value

2018-10-09 Thread Thomas Monjalon
09/10/2018 17:11, Stephen Hemminger: > On Tue, 09 Oct 2018 16:31:24 +0200 > Thomas Monjalon wrote: > > > 09/10/2018 16:14, Gaëtan Rivet: > > > Hi Thomas, > > > > > > On Tue, Oct 09, 2018 at 04:18:55AM +0200, Thomas Monjalon wrote: > > > > If a value contains a comma, rte_kvargs_tokenize() will

Re: [dpdk-dev] [PATCH v2 00/10] introduce telemetry library

2018-10-09 Thread Thomas Monjalon
09/10/2018 16:56, Bruce Richardson: > On Tue, Oct 09, 2018 at 01:41:10PM +0200, Thomas Monjalon wrote: > > I think it is not clean. > > We should really split EAL in two parts: > > - low level routines > > - high level init. > > > > About telemetry, you can find any workaround, but it must

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: add L2 and L3 decap to Direct Verbs flow

2018-10-09 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Yongseok Koh > Sent: Tuesday, October 9, 2018 12:19 AM > To: Dekel Peled > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: Re: [PATCH v2 4/4] net/mlx5: add L2 and L3 decap to Direct Verbs > flow > > On Sun, Oct 07, 2018 at 05:25:08PM +030

Re: [dpdk-dev] [PATCH v2 0/3] app/testpmd: add l3 encap/decap cmd

2018-10-09 Thread Ferruh Yigit
On 10/7/2018 3:41 PM, Ori Kam wrote: > Currently testpmd have support only for encapsulation and decapsulation > for L2 tunnels. > > This series adds commands for L3 tunnels types, L3 tunnel is a tunnel > that the inner packet is missing the L2 part. The encapsulation uses > the encap_l3 command i

Re: [dpdk-dev] [PATCH v3 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-10-09 Thread Ferruh Yigit
On 10/7/2018 1:57 PM, Ori Kam wrote: > This series implement the generic L2/L3 tunnel encapsulation actions > and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" > > Currenlty the encap/decap actions only support encapsulation > of VXLAN and NVGRE L2 packets (L2 encapsulation

Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add Rx offload outer UDP checksum definition

2018-10-09 Thread Ferruh Yigit
On 10/9/2018 3:18 PM, Jerin Jacob wrote: > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > PKT_RX_OUTER_L4_CKSUM_* mbuf ol_flags to detect outer UDP checksum > status. > > - To use hardware Rx outer UDP checksum offload, the user needs to > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM

[dpdk-dev] [PATCH v2] drivers/net: fix log type string

2018-10-09 Thread Ferruh Yigit
Syntax for log type string is "pmd..[.]" Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type") Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging") Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver") Fixes: 7db274b9ada2 ("doc: describe dynamic logging format") Fi

Re: [dpdk-dev] [PATCH] drivers/net: fix log type string

2018-10-09 Thread Ferruh Yigit
On 10/9/2018 4:07 PM, Stephen Hemminger wrote: > On Tue, 9 Oct 2018 12:52:38 +0100 > Ferruh Yigit wrote: > >> Syntax for log type string is "pmd..[.]" >> >> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type") >> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging") >> Fixes: 6086ab3

Re: [dpdk-dev] [PATCH v4 0/3] add AES-CMAC support

2018-10-09 Thread Trahe, Fiona
> -Original Message- > From: Cel, TomaszX > Sent: Tuesday, October 9, 2018 5:08 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com; Kovacevic, Marko > ; Kusztal, ArkadiuszX > ; > mattias.ronnb...@ericsson.com; Cel, TomaszX > Subject: [PATCH v4 0/3] add A

[dpdk-dev] [PATCH 1/3] compress/isal: enable checksum support in driver

2018-10-09 Thread Lee Daly
This patch adds checksum support in the ISA-L PMD for both compression and decompression. CRC32 is supported as well as Adler32. Signed-off-by: Lee Daly --- drivers/compress/isal/isal_compress_pmd.c | 82 +++ drivers/compress/isal/isal_compress_pmd_ops.c | 4 +- 2 f

[dpdk-dev] [PATCH 2/3] test/compress: add checksum tests

2018-10-09 Thread Lee Daly
This patch adds a test which examines what type of checksum the PMD supports, adler, crc32 or alder32_crc32 and tests that feature if the PMD supports it. Signed-off-by: Lee Daly --- test/test/test_compressdev.c | 205 ++- 1 file changed, 202 insertions(+)

[dpdk-dev] [PATCH 3/3] doc: update ISA-L guide to reflect checksum support

2018-10-09 Thread Lee Daly
This updates the ISA-L compression driver guide on how to enable and use checksums. This also updates the compression drivers features matrix. Signed-off-by: Lee Daly --- doc/guides/compressdevs/features/isal.ini | 2 ++ doc/guides/compressdevs/isal.rst | 32 ++

[dpdk-dev] [PATCH v4 2/3] test/qat: test for AES-CMAC

2018-10-09 Thread Tomasz Cel
Enable tests for AES-CMAC authentication algorithm. Signed-off-by: Tomasz Cel --- test/test/test_cryptodev_hash_test_vectors.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/test/test/test_cryptodev_hash_test_vectors.h b/test/test/test_cryptodev_hash_test_vecto

  1   2   3   >