Re: [dpdk-dev] [PATCH] bus/pci: fix unexpected resource mapping override

2018-09-28 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, September 26, 2018 9:51 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Yigit, > Ferruh ; geoffrey...@gmail.com; > ajit.khapa...@broadcom.com; sta...@dpdk.org > Subject: Re: [dpdk-de

Re: [dpdk-dev] [PATCH v1 4/5] pci: add req handler field to generic pci device

2018-09-28 Thread Jeff Guo
On 9/26/2018 8:22 PM, Burakov, Anatoly wrote: On 17-Aug-18 11:51 AM, Jeff Guo wrote: There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, it could be useful for device error monitoring. And these corresponding interrupt

Re: [dpdk-dev] [PATCH v1 5/5] vfio: enable vfio hotplug by req notifier handler

2018-09-28 Thread Jeff Guo
Anatoly, thanks for your review, please see comment as below. On 9/26/2018 8:28 PM, Burakov, Anatoly wrote: On 17-Aug-18 11:51 AM, Jeff Guo wrote: This patch will add req notifier processing to enable hotplug for vfio. When device is be hotplug-out, the vfio kernel module will sent req notifier

[dpdk-dev] [PATCH v2 5/5] net/bnx2x: fix to add phy lock

2018-09-28 Thread Mody, Rasesh
This patch adds phy_lock, acquire/release the lock when performing PHY transactions. Without this fix driver can run into synchronization issues with management FW when modifying PHY settings. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/

[dpdk-dev] [PATCH v2 3/5] net/bnx2x: fix to disable further interrupts

2018-09-28 Thread Mody, Rasesh
Fix to disable further fastpath/slowpath interrupts. These will be enabled again by their respective handlers Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH v2 4/5] net/bnx2x: fix call to link handling periodic function

2018-09-28 Thread Mody, Rasesh
If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. This change makes sure link handling periodic function is not called in interrupt context. Fixes: 540a211084a7 (

Re: [dpdk-dev] [PATCH 0/2] remove unnecessary call of rte intr enable

2018-09-28 Thread Zhang, Qi Z
> -Original Message- > From: Li, Xiaoyun > Sent: Thursday, September 27, 2018 5:22 PM > To: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > ; Lu, Wenzhuo ; Wu, Jingjing > > Cc: Li, Xiaoyun > Subject: [PATCH 0/2] remove unnecessary call of rte intr enable > > Since rte_intr_enable is called

Re: [dpdk-dev] [PATCH v5 10/10] doc/vm_power_manager: add JSON interface API info

2018-09-28 Thread Yao, Lei A
> +:Pair Name: "avg_packet_thresh" > +:Description: Threshold below which the frequency will be set to min for > + the TRAFFIC policy. If the traffic rate is above this and below max, the > + frequency will be set to medium. > +:Type: integer > +:Values: The number of packets below which the TRAF

[dpdk-dev] [PATCH v3] ethdev: get rxq interrupt fd

2018-09-28 Thread Xiaoyun Li
Some users want to use their own epoll instances to control both DPDK rxq interrupt fds and their own other fds. So added a function to get rxq interrupt fd based on port id and queue id. Signed-off-by: Xiaoyun Li --- v3: * Since the API only wants to return fd, return fd or -1. v2: * Added mis

Re: [dpdk-dev] [PATCH 00/20] base code update

2018-09-28 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, September 27, 2018 3:39 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin > ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH 00/20] base code update > > > > > -Original Message- > > From: dev [mail

Re: [dpdk-dev] [PATCH] net/i40e: fix send admin queue command before init

2018-09-28 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Friday, September 28, 2018 2:11 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yigit, Ferruh ; Wu, Jingjing > ; Rawat, Anand ; Menon, > Ranjit ; sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix send admin queue command before init > > >

[dpdk-dev] [PATCH v3 15/15] net/bnxt: reduce the polling interval for valid bit

2018-09-28 Thread Ajit Khaparde
From: Xiaoxin Peng Change polling interval for valid bit in bnxt_hwrm_send_message Poll every 1us instead of 600us. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Cc: sta...@dpdk.org Signed-off-by: Xiaoxin Peng Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_h

[dpdk-dev] [PATCH v3 14/15] net/bnxt: remove excess log messages

2018-09-28 Thread Ajit Khaparde
When the firmware version and the driver HWRM version do not match, we are logging some messages. These messages unnecessarily clutter the logs and can add to the noise. We are logging the HWRM version and the firmware version anyway. The difference in version numbers can be gleaned from that. Remo

[dpdk-dev] [PATCH v3 11/15] net/bnxt: set MAC filtering as outer for non tunnel frames

2018-09-28 Thread Ajit Khaparde
We need to set HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST bit in L2_FILTER_ALLOC for filtering non-tunnel packets based on outermost MAC. Fixes: f92735db1e4c ("net/bnxt: add L2 filter alloc/init/free") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde -- v1->v2: Add "Fixes" to the commit mess

[dpdk-dev] [PATCH v3 09/15] net/bnxt: add support for trusted VF

2018-09-28 Thread Ajit Khaparde
In the current model, VFs are not trusted. So it is not allowed to send many HWRM commands. Newer firmware has added support to allow VF to be trusted. Now the VF queries if it is a trusted entity and based on that it can send HWRM commands to the firmware. Signed-off-by: Ajit Khaparde --- drive

[dpdk-dev] [PATCH v3 12/15] net/bnxt: set a VNIC as default only once

2018-09-28 Thread Ajit Khaparde
If a vnic is configured as default and the setting has not changed, there is no need to issue this setting again to the FW. Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde -- v1->v2: Add "Fixes" to commit message --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v3 13/15] net/bnxt: set VLAN strip mode before default VNIC cfg

2018-09-28 Thread Ajit Khaparde
From: Bei Sun Firmware sets pf pair in default VNIC cfg. If the VLAN strip setting is not available at this time, it will not be configured correctly in the CFA. Set the desired VLAN strip mode before default VNIC configuration. Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") Cc:

[dpdk-dev] [PATCH v3 10/15] net/bnxt: fix registration of VF async event completion ring

2018-09-28 Thread Ajit Khaparde
From: yongping While registering vf's event completion ring to FW, use the wrong macro, FW doesn't set up the event completion ring successfully, VF can't receive any async event. Fixes: 4535cad39515 ("net/bnxt: handle VF/PF initialization appropriately") Cc: sta...@dpdk.org Signed-off-by: Yong

[dpdk-dev] [PATCH v3 07/15] net/bnxt: add support for extended port counters

2018-09-28 Thread Ajit Khaparde
This patch adds support extended port statistics like COS bytes, packets, XON -> XOFF and XOFF -> XON transitions in Tx and Rx path. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 8 ++ drivers/net/bnxt/bnxt_ethdev.c | 30 - drivers/net/bnxt/bnxt_hwrm.c | 44 +++

[dpdk-dev] [PATCH v3 08/15] net/bnxt: add support to enable new mailbox channel

2018-09-28 Thread Ajit Khaparde
For hardware having multiple embedded management processors the firmware has added support to indicate if the comm channel to the processor has been enabled. If the channel is enabled, switch the CFA NTUPLE and EM filtering commands to use the kong channel. Signed-off-by: Ajit Khaparde --- drive

[dpdk-dev] [PATCH v3 01/15] net/bnxt: get rid of ff pools and use VNIC info array

2018-09-28 Thread Ajit Khaparde
From: Somnath Kotur There was no direct association between the rxq's VNIC and the vnic_info[]. Explicitly associate the two in bnxt_mq_rx_configure(). Fixes: 0a256e4a548b ("net/bnxt: fix Rx ring count limitation") Cc: sta...@dpdk.org Signed-off-by: Somnath Kotur -- v1->v2: - Fix access to unin

[dpdk-dev] [PATCH v3 05/15] net/bnxt: update HWRM version part 2

2018-09-28 Thread Ajit Khaparde
Update the HWRM API to version 1.9.2.53 This is second part of the patch. Signed-off-by: Ajit Khaparde -- v1->v2: Update from 1.9.2.45 to version 1.9.2.53 v2->v3: Split the patch into smaller patches --- drivers/net/bnxt/hsi_struct_def_dpdk.h | 1153 1 file changed, 1153

[dpdk-dev] [PATCH v3 00/15] bnxt patchset

2018-09-28 Thread Ajit Khaparde
Patchset against dpdk-next-net. v1->v2: net/bnxt: get rid of ff pools array and use the vnic info array instead - Fix access to uninitialized variable. - Rectify the wrong 'Fixes' reference. net/bnxt: update HWRM version - Update from 1.9.2.45 to version 1.9.2.53 v2->v3: net/bnxt: update HWRM ve

[dpdk-dev] [PATCH v3 02/15] net/bnxt: fix uninitialized ptr access in transmit handler

2018-09-28 Thread Ajit Khaparde
From: Somnath Kotur bnxt_start_xmit() was attempting to access an uninitialized ptr - txbd1 which would lead to segmentation fault. Fix to initialize ptr to NULL and check for the same before access. Fixes: f10258e39ec2 ("net/bnxt: fix HW Tx checksum offload check") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH v3 03/15] net/bnxt: fix MTU setting

2018-09-28 Thread Ajit Khaparde
The HW can support maximum frame length of 9600 bytes. And we are currently capping the max frame size to 9500 bytes. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 1

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-28 Thread Li, Xiaoyun
Sure. Anyway there is an error log to indicate the error. I will send v3 later. Thanks. From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Friday, September 28, 2018 20:47 To: Li, Xiaoyun Cc: Yigit, Ferruh ; Thomas Monjalon ; Zhang, Helin ; damar...@cisco.com; Kinsella, Ray ; dev

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> >> Extendable bucket table composes of buckets that can be linked list to >> current >> main table. When extendable bucket is enabled, the table utilization can >> always acheive 100%. >IMO, referring

Re: [dpdk-dev] [PATCH v2 7/7] hash: use partial-key hashing

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Wednesday, September 26, 2018 9:24 PM >To: Wang, Yipeng1 ; Richardson, Bruce > >Cc: dev@dpdk.org; mic...@digirati.com.br >Subject: RE: [PATCH v2 7/7] hash: use partial-key hashing > > >> +static in

Re: [dpdk-dev] [PATCH v2 6/7] test/hash: implement extendable bucket hash test

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Wednesday, September 26, 2018 9:24 PM >To: Wang, Yipeng1 ; Richardson, Bruce > >Cc: dev@dpdk.org; mic...@digirati.com.br >Subject: RE: [PATCH v2 6/7] test/hash: implement extendable bucket hash

Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> Second, the patch set changes the current hashing algorithm to be "partial- >> key hashing". Partial-key hashing is the concept from Bin Fan, et al.'s paper >> "MemC3: Compact and Concurrent MemCache wi

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> several times */ -#define BUCKET_SIZE 4 >> +#define BUCKET_SIZE 8 >May be we should add a comment to warn that it should be same as ' >RTE_HASH_BUCKET_ENTRIES'? > [Wang, Yipeng] Done in V4, Thanks for

[dpdk-dev] [PATCH v4 2/4] hash: add extendable bucket feature

2018-09-28 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

[dpdk-dev] [PATCH v4 3/4] test/hash: implement extendable bucket hash test

2018-09-28 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang --- test/test/test_hash.c | 159 +++-- test/test/test_hash_perf.c | 114 +++- 2 files chang

[dpdk-dev] [PATCH v4 1/4] hash: fix race condition in iterate

2018-09-28 Thread Yipeng Wang
In rte_hash_iterate, the reader lock did not protect the while loop which checks empty entry. This created a race condition that the entry may become empty when enters the lock, then a wrong key data value would be read out. This commit extends the protected region. Fixes: f2e3001b53ec ("hash: su

[dpdk-dev] [PATCH v4 0/4] hash: add extendable bucket and partial key hashing

2018-09-28 Thread Yipeng Wang
This patch set made two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into the main hash table due to the unlikely event of excessive hash collisions. The hash table bucke

[dpdk-dev] [PATCH v4 4/4] hash: use partial-key hashing

2018-09-28 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Bascially the idea is to use "xor" to derive alternative

Re: [dpdk-dev] [PATCH] test: reduce test time for hash multiwriter ut

2018-09-28 Thread Wang, Yipeng1
>-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jananee Parthasarathy >Sent: Wednesday, September 26, 2018 11:41 PM >To: dev@dpdk.org >Cc: Richardson, Bruce ; De Lara Guarch, Pablo >; Pattan, Reshma >; Somarowthu, Naga SureshX > >Subject: [dpdk-dev] [PATCH] test:

Re: [dpdk-dev] [PATCH v6 02/21] mem: allow memseg lists to be marked as external

2018-09-28 Thread Yongseok Koh
On Thu, Sep 27, 2018 at 11:40:59AM +0100, Anatoly Burakov wrote: > When we allocate and use DPDK memory, we need to be able to > differentiate between DPDK hugepage segments and segments that > were made part of DPDK but are externally allocated. Add such > a property to memseg lists. > > This bre

Re: [dpdk-dev] [PATCH] net/mlx5: eswitch-IP address UDP/TCP port rewrite

2018-09-28 Thread Yongseok Koh
On Tue, Sep 25, 2018 at 07:51:06PM +0800, Xiaoyu Min wrote: > Offload the following rte_flow actions by inserting accordingly > E-Switch rules via TC Flower driver > > - RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > - RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > - RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > - RTE_FLOW_A

[dpdk-dev] [PATCH] test --transfer-encoding=base64

2018-09-28 Thread Yongseok Koh
rte_flow has 'group' attribute and 'jump' action in order to support multiple groups. This feature is known as multi-table support ('chain' in linux TC flower) in general because a group means a table of flows. Example commands are: flow create 0 transfer priority 1 ingress pa

[dpdk-dev] [PATCH] test original

2018-09-28 Thread Yongseok Koh
rte_flow has 'group' attribute and 'jump' action in order to support multiple groups. This feature is known as multi-table support ('chain' in linux TC flower) in general because a group means a table of flows. Example commands are: flow create 0 transfer priority 1 ingress pa

[dpdk-dev] [PATCH] test --transfer-encoding=quoted-printable

2018-09-28 Thread Yongseok Koh
rte_flow has 'group' attribute and 'jump' action in order to support multiple groups. This feature is known as multi-table support ('chain' in linux TC flower) in general because a group means a table of flows. Example commands are: flow create 0 transfer priority 1 ingress pa

[dpdk-dev] [PATCH v4 1/5] test/hash: fix bucket size in hash perf test

2018-09-28 Thread Yipeng Wang
The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys i

[dpdk-dev] [PATCH v4 3/5] test/hash: fix rw test with non-consecutive cores

2018-09-28 Thread Yipeng Wang
the multi-reader and multi-writer rte_hash unit test does not work correctly with non-consecutive core ids. This commit fixes the issue. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang Tested-by: Bruce Richardson Acked-by: Br

[dpdk-dev] [PATCH v4 2/5] test/hash: more accurate hash perf test output

2018-09-28 Thread Yipeng Wang
Edit the printf information when error happens to be more accurate and informative. Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- test/test/test_hash_perf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_has

[dpdk-dev] [PATCH v4 5/5] hash: fix unused define

2018-09-28 Thread Yipeng Wang
Since the depth-first search of cuckoo path is removed, we do not need the macro anymore which specifies the depth of the cuckoo search. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- lib/librte_hash/rt

[dpdk-dev] [PATCH v4 4/5] test/hash: fix missing file in meson build file

2018-09-28 Thread Yipeng Wang
The test_hash_readwrite.c was not in the meson.build file. This commit adds the missing test into the file. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- test/test/meson.build | 1 + 1 file c

[dpdk-dev] [PATCH v4 0/5] hash: fix multiple issues

2018-09-28 Thread Yipeng Wang
This patch set was part of extendable hash table patch set before V2. According to Bruce's comment, this patch set is now separated from the original patch set for easier review and merge. https://mails.dpdk.org/archives/dev/2018-September/112555.html This patch set fixes multiple issues/bugs from

Re: [dpdk-dev] [PATCH 0/4] Address reader-writer concurrency in rte_hash

2018-09-28 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > Reply inlined: Hi Yipeng, Thank you so much for reviewing. > > >-Original Message- > > > >Currently, reader-writer concurrency problems in rte_hash are > >addressed using reader-writer locks. Use of reader-writer locks > >results in following issues: > >

[dpdk-dev] [PATCH v2 2/2] net/enic: add AVX2 based vectorized Rx handler

2018-09-28 Thread John Daley
From: Hyong Youb Kim Add the vectorized version of the no-scatter Rx handler. It aims to process 8 descriptors per loop using AVX2 SIMD instructions. This handler is in its own file enic_rxtx_vec_avx2.c, and makefile and meson.build are modified to compile it when the compiler supports AVX2. Unde

[dpdk-dev] [PATCH v2 1/2] net/enic: move common Rx functions to a new header file

2018-09-28 Thread John Daley
From: Hyong Youb Kim Move a number of Rx functions to the header file so that the avx2 based Rx handler can use them. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- v3: re-add Reviewed-by drivers/net/enic/enic_rxtx.c| 263 +- drivers/net/en

[dpdk-dev] [PATCH v2 2/2] net/enic: add AVX2 based vectorized Rx handler

2018-09-28 Thread John Daley
From: Hyong Youb Kim Add the vectorized version of the no-scatter Rx handler. It aims to process 8 descriptors per loop using AVX2 SIMD instructions. This handler is in its own file enic_rxtx_vec_avx2.c, and makefile and meson.build are modified to compile it when the compiler supports AVX2. Unde

[dpdk-dev] [PATCH v2 1/2] net/enic: move common Rx functions to a new header file

2018-09-28 Thread John Daley
From: Hyong Youb Kim Move a number of Rx functions to the header file so that the avx2 based Rx handler can use them. Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_rxtx.c| 263 +- drivers/net/enic/enic_rxtx_common.h | 271 ++

[dpdk-dev] [PATCH 3/3] doc/qat: add AES-CMAC to the QAT feature list

2018-09-28 Thread Tomasz Cel
Update the QAT documentation to show that it supports AES-CMAC. Signed-off-by: Tomasz Cel --- doc/guides/cryptodevs/features/qat.ini | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/doc/guides/cryptodevs/features/qat.ini b/doc/guides/cryptodevs/fea

[dpdk-dev] [PATCH 1/3] crypto/qat: add support AES-CMAC

2018-09-28 Thread Tomasz Cel
This patch add AES-CMAC support. CMAC is a keyed hash function that is based on a symmetric key block cipher. It is One-Key CBC MAC improvement over XCBC-MAC. RFC 4493. NIST SP 800-38B. Signed-off-by: Tomasz Cel Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_session.c | 190

[dpdk-dev] [PATCH 2/3] test/qat: test for AES-CMAC

2018-09-28 Thread Tomasz Cel
Enable tests for AES-CMAC authentication algorithm. Signed-off-by: Tomasz Cel --- test/test/test_cryptodev_hash_test_vectors.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/test/test/test_cryptodev_hash_test_vectors.h b/test/test/test_cryptodev_hash_test_vecto

[dpdk-dev] [PATCH 0/3] add AES-CMAC support

2018-09-28 Thread Tomasz Cel
This patch add support, update QAT documentation and enable tests for AES-CMAC. Tomasz Cel (3): crypto/qat: add support AES-CMAC test/qat: test for AES-CMAC doc/qat: add AES-CMAC to the QAT feature list doc/guides/cryptodevs/features/qat.ini | 25 ++-- drivers/crypto/qat/qat_sym_ses

[dpdk-dev] [PATCH] build: add drivers_install_subdir meson option

2018-09-28 Thread Luca Boccassi
Allow users and packagers to override the default dpdk/drivers subdirectory where the PMDs get installed under $lib. Signed-off-by: Luca Boccassi --- meson.build | 3 ++- meson_options.txt | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-28 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, September 27, 2018 12:22 PM > To: Richardson, Bruce > Cc: Wang, Yipeng1 ; dev@dpdk.org; > mic...@digirati.com.br > Subject: RE: [PATCH v2 5/7] hash: add extendable bucket feature > >

[dpdk-dev] [PATCH v2 3/3] eal: allow probing a device again

2018-09-28 Thread Thomas Monjalon
In the devargs syntax for device representors, it is possible to add several devices at once: -w dbdf,representor=[0-3] It will become a more frequent case when introducing wildcards and ranges in the new devargs syntax. If a devargs string is provided for probing, and updated with a bigger range

[dpdk-dev] [PATCH v2 2/3] eal: add function to query device status

2018-09-28 Thread Thomas Monjalon
The function rte_dev_is_probed() is added in order to improve semantic and enforce proper check of the probing status of a device. It will answer this rte_device query: Is it already successfully probed or not? Signed-off-by: Thomas Monjalon --- drivers/bus/ifpga/ifpga_bus.c | 4 ++--

[dpdk-dev] [PATCH v2 0/3] eal: allow hotplug to skip an already probed device

2018-09-28 Thread Thomas Monjalon
This is a follow-up of an idea presented at Dublin during the "hotplug talk". The idea is to ease probing of range of ports attached to the same rte_device. I becomes possible to allow probing again the same device but with a bigger range of ports in the devargs. Instead of adding a parameter to

[dpdk-dev] [PATCH v2 1/3] drivers/bus: move driver assignment to end of probing

2018-09-28 Thread Thomas Monjalon
The PCI mapping requires to know the PCI driver to use, even before the probing is done. That's why the PCI driver is referenced early inside the PCI device structure. See 1d20a073fa5e ("bus/pci: reference driver structure before mapping") However the rte_driver does not need to be referenced in r

[dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions

2018-09-28 Thread Thomas Monjalon
These functions are quite old and are the only available replacement for the deprecated attach/detach functions. Note: some new functions may (again) replace these hotplug functions, in future, with better parameters. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v3 4/4] eal: simplify parameters of hotplug functions

2018-09-28 Thread Thomas Monjalon
All information about a device to probe can be grouped in a common string, which is what we usually call devargs. An application should not have to parse this string before calling the EAL probe function. And the syntax could evolve to be more complex and support matching multiple devices in one st

[dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions

2018-09-28 Thread Thomas Monjalon
rte_eal_parse_devargs_str() does not support parsing the bus name at the start of devargs. So it has been renamed and deprecated. rte_eal_devargs_add(), rte_eal_devargs_type_count() and rte_eal_devargs_dump() were declared deprecated and had their implementation body renamed. All these functions

[dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function

2018-09-28 Thread Thomas Monjalon
The function rte_devargs_remove(), which is intended to be internal, can take a devargs structure as argument. The matching is still using string comparison of bus name and device name. It is simpler and may allow a different devargs matching in future. Signed-off-by: Thomas Monjalon --- drivers

[dpdk-dev] [PATCH v3 0/4] eal: simplify devargs and hotplug functions

2018-09-28 Thread Thomas Monjalon
This is a follow-up of an idea presented at Dublin during the "hotplug talk". Instead of changing the existing hotplug functions, as in the RFC, some new experimental functions are added. The old functions lose their experimental status in order to provide a non-experimental replacement for deprec

[dpdk-dev] [PATCH] net/softnic: fix ipv6 address from big endian to cpu order

2018-09-28 Thread Reshma Pattan
Fix ipv6 endianness from big endian to cpu order. Fixes: ee19326a4b ("net/softnic: add command for pipeline table entries") Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic_thread.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/dr

[dpdk-dev] [PATCH] examples/ip_pipeline: fix ipv6 address endianness

2018-09-28 Thread Reshma Pattan
Fix ipv6 endianness from big endian to cpu order. Fixes: a3a95b7d58 ("examples/ip_pipeline: add table entry commands") Signed-off-by: Reshma Pattan --- examples/ip_pipeline/thread.c | 40 +-- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/example

Re: [dpdk-dev] [PATCH v4 3/4] app/test-eventdev: add Tx adapter support

2018-09-28 Thread Jerin Jacob
-Original Message- > Date: Mon, 24 Sep 2018 13:32:19 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, nikhil@intel.com, > anoob.jos...@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 3/4] app/test-eventdev: add Tx adapter supp

Re: [dpdk-dev] [PATCH 1/2] drivers/net: remove double assignment of driver

2018-09-28 Thread Thomas Monjalon
28/09/2018 14:26, Shreyansh Jain: > Removing double copy of driver information. 04664e5c8346 has shifted > that from driver's probe to bus's probe. > > Fixes: 04664e5c8346 ("drivers/bus: fill driver reference after NXP probing") > Cc: tho...@monjalon.net > > Signed-off-by: Shreyansh Jain For th

Re: [dpdk-dev] [PATCH 0/7] Improve core EAL musl compatibility

2018-09-28 Thread Bruce Richardson
On Wed, Aug 29, 2018 at 12:56:14PM +0100, Anatoly Burakov wrote: > This patchset fixes numerous issues with musl compatibility > in the core EAL libraries. It does not fix anything beyond > core EAL (so, PCI driver is still broken, so are a few other > drivers), but it's a good start. > > Tested o

[dpdk-dev] [PATCH v8 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-28 Thread Xiaolong Ye
The vdpa sample application creates vhost-user sockets by using the vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes virtio ring compatible devices to serve virtio driver directly to enable datapath acceleration. As vDPA driver can help to set up vhost datapath, this applic

[dpdk-dev] [PATCH v8 1/2] vhost: introduce API to get vDPA device number

2018-09-28 Thread Xiaolong Ye
It's used to get number of available registered vDPA devices. Signed-off-by: Xiaolong Ye Acked-by: Xiao Wang Reviewed-by: Maxime Coquelin --- lib/librte_vhost/rte_vdpa.h| 3 +++ lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/vdpa.c| 6 ++ 3 files

[dpdk-dev] [PATCH v8 0/2] introduce vdpa sample

2018-09-28 Thread Xiaolong Ye
Hi, This patchset introduces vdpa sample to demonstrate the vDPA use case. v8 changes: * move body of data_init to the main function * adjust Reviewed-by/Acked-by tag postion v7 changes: * make vports static * avoid unnecessary static variable initialization v6 changes: * improve the document a

[dpdk-dev] [PATCH v9 1/4] lib/librte_power: traffic pattern aware power control

2018-09-28 Thread Liang Ma
1. Abstract For packet processing workloads such as DPDK polling is continuous. This means CPU cores always show 100% busy independent of how much work those cores are doing. It is critical to accurately determine how busy a core is hugely important for the following reasons: * No indication o

[dpdk-dev] [PATCH v9 3/4] doc/guides/pro_guide/power-man: update the power API

2018-09-28 Thread Liang Ma
Update the document for empty poll API. Change Logs: v9: minor changes for syntax. Update document. Signed-off-by: Liang Ma --- doc/guides/prog_guide/power_man.rst | 86 + 1 file changed, 86 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/d

[dpdk-dev] [PATCH v9 2/4] examples/l3fwd-power: simple app update for new API

2018-09-28 Thread Liang Ma
Add the support for new traffic pattern aware power control power management API. Example: ./l3fwd-power -l xxx -n 4 -w :xx:00.0 -w :xx:00.1 -- -p 0x3 -P --config="(0,0,xx),(1,0,xx)" --empty-poll="0,0,0" -l 14 -m 9 -h 1 Please Reference l3fwd-power document for full parameter usage T

Re: [dpdk-dev] [PATCH v3] eventdev: fix port id argument in Rx adapter caps API

2018-09-28 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 15:19:05 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org > Subject: [PATCH v3] eventdev: fix port id argument in Rx adapter caps API > X-Mailer: git-send-email 1.8.3.1 > > Make the e

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

2018-09-28 Thread Maxime Coquelin
On 09/28/2018 03:24 PM, Bruce Richardson wrote: On Fri, Sep 28, 2018 at 04:17:34PM +0300, Ilya Maximets wrote: On 28.09.2018 15:13, Bruce Richardson wrote: On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote: On 27.09.2018 11:28, Ilya Maximets wrote: On 26.09.2018 10:26, Maxime C

Re: [dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support

2018-09-28 Thread Jerin Jacob
-Original Message- > Date: Fri, 28 Sep 2018 17:11:33 +0530 > From: pavan.bhagavat...@cavium.com > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2] event/octeontx: add Tx adapter support > X-Mailer: git-send-email 2.19.0 > > From: Pava

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

2018-09-28 Thread Bruce Richardson
On Fri, Sep 28, 2018 at 04:17:34PM +0300, Ilya Maximets wrote: > On 28.09.2018 15:13, Bruce Richardson wrote: > > On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote: > >> On 27.09.2018 11:28, Ilya Maximets wrote: > >>> On 26.09.2018 10:26, Maxime Coquelin wrote: > This patch opens a

Re: [dpdk-dev] [04/12] vhost: introduce postcopy's advise message

2018-09-28 Thread Ilya Maximets
On 28.09.2018 15:13, Bruce Richardson wrote: > On Fri, Sep 28, 2018 at 01:40:25PM +0300, Ilya Maximets wrote: >> On 27.09.2018 11:28, Ilya Maximets wrote: >>> On 26.09.2018 10:26, Maxime Coquelin wrote: This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE

[dpdk-dev] [PATCH] compressdev: fix compression api description

2018-09-28 Thread Tomasz Jozwiak
This patch fixes description of API functions: - rte_comp_op_raw_bulk_alloc - rte_comp_op_bulk_alloc Fixes: 96086db5a369 ("compressdev: add operation management") Signed-off-by: Tomasz Jozwiak --- lib/librte_compressdev/rte_comp.c | 4 ++-- lib/librte_compressdev/rte_comp.h | 4 ++-- 2 fil

Re: [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx adapter test

2018-09-28 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 08:45:49 +0530 > From: Jerin Jacob > To: Nikhil Rao > CC: dev@dpdk.org, sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx > adapter test > User-Agent: Mutt/1.10.1 (2018-07-13) > > > -Original Messag

[dpdk-dev] [PATCH] compressdev: fix compression api description

2018-09-28 Thread Tomasz Jozwiak
This patch fixes descripton of API functions: - rte_comp_op_raw_bulk_alloc - rte_comp_op_bulk_alloc Fixes: 96086db5a369 ("compressdev: add operation management") Signed-off-by: Tomasz Jozwiak --- lib/librte_compressdev/rte_comp.c | 4 ++-- lib/librte_compressdev/rte_comp.h | 4 ++-- 2 file

Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

2018-09-28 Thread Liang, Ma
Hi Dave, thanks for your feedback. I will update document in v9. O 28 Sep 13:43, Hunt, David wrote: > Hi Liang, > > > I think section 21.4 "Running the Application" needs mention the empty > poll feature. Maybe just add a mention > > *   --empty-poll: Traffic Aware power management. See be

Re: [dpdk-dev] [PATCH] ethdev: get rxq interrupt fd

2018-09-28 Thread Stephen Hemminger
In general, an API is less error prone if it only does return by value. What about just returning fd or -1? On Fri, Sep 28, 2018, 5:55 AM Xiaoyun Li wrote: > Some users want to use their own epoll instances to control both > DPDK rxq interrupt fds and their own other fds. So added a function >

Re: [dpdk-dev] [RFC] ethdev: complete closing to free all resources

2018-09-28 Thread Ferruh Yigit
On 9/8/2018 12:39 AM, Thomas Monjalon wrote: > After closing a port, it cannot be restarted. > So there is no reason to not free all associated resources. > > The last step was done with rte_eth_dev_detach() which is deprecated. > Instead of removing the associated rte_device, the driver should ch

Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

2018-09-28 Thread Hunt, David
Hi Liang, I think section 21.4 "Running the Application" needs mention the empty poll feature. Maybe just add a mention *   --empty-poll: Traffic Aware power management. See below for details. On 25/9/2018 2:20 PM, Kovacevic, Marko wrote: Add empty poll mode command line example Signed-o

[dpdk-dev] [PATCH v2 7/7] doc: update action documentation

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- doc/guides/prog_guide/packet_framework.rst | 11 ++- doc/guides/sample_app_ug/ip_pipeline.rst | 23 +++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/doc/guide

[dpdk-dev] [PATCH v2 5/7] examples/ip_pipeline: update cli parsing

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" This patch updates the cli parsing of ip_pipeline application with extra symmetric crypto, port, session, and action support. Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- examples/ip_pipeline/cli.c | 577 -

[dpdk-dev] [PATCH v2 6/7] examples/ip_pipeline: add script

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- examples/ip_pipeline/examples/flow_crypto.cli | 58 +++ 1 file changed, 58 insertions(+) create mode 100644 examples/ip_pipeline/examples/flow_crypto.cli diff --git a/examples/ip_p

[dpdk-dev] [PATCH v2 3/7] examples/ip_pipeline: configure crypto port

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" This patch adds symmetric crypto port configuration to ip_pipeline sample application. Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- examples/ip_pipeline/pipeline.c | 60 + examples/ip_pipeline/pipeline.h | 13 +

[dpdk-dev] [PATCH v2 4/7] examples/ip_pipeline: add symmetric crypto action

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" This patch adds symmetric crypto action support to ip_pipeline application. Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- examples/ip_pipeline/action.c | 11 +++ examples/ip_pipeline/action.h | 1 + examples/ip_pipeline/pipeline.h | 1 +

[dpdk-dev] [PATCH v2 1/7] pipeline: add symmetric crypto to action

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" This patch adds the symmetric crypto action support to pipeline library. The symmetric crypto action works as the shim layer between pipeline and DPDK cryptodev and is able to interact with cryptodev with the control path requests such as session creation/deletion and data

[dpdk-dev] [PATCH v2 2/7] examples/ip_pipeline: add cryptodev

2018-09-28 Thread Fan Zhang
From: "Zhang, Roy Fan" This patch adds symmetric crypto device abstraction to ip_pipeline sameple application. Signed-off-by: Zhang, Roy Fan Acked-by: Dumitrescu, Cristian --- examples/ip_pipeline/Makefile| 1 + examples/ip_pipeline/cryptodev.c | 117

[dpdk-dev] [PATCH v2 0/7] pipeline: add symmetric crypto to action

2018-09-28 Thread Fan Zhang
This patchset creates an abstraction layer of DPDK Cryptodev to the pipeline library to enable its symmetric cryptographic capability. The ip_pipeline sample application is updated accordingly. v2: - Fixed bugs. - Updated data structure. - Updated IP-pipeline sample application. Zhang, Roy Fan (7

Re: [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API

2018-09-28 Thread Hunt, David
Hi Liang, On 17/9/2018 2:30 PM, Liang Ma wrote: Update the document for empty poll API. Signed-off-by: Liang Ma --- doc/guides/prog_guide/power_man.rst | 90 + 1 file changed, 90 insertions(+) diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guid

  1   2   >