[dpdk-dev] [PATCH v2] net/failsafe: report actual device capabilities

2018-09-25 Thread Andrew Rybchenko
From: Igor Romanov Failsafe device capabilities depend on supported by the failsafe itself plus capabilities supported by sub-devices. Make fs_dev_infos_get() take failsafe device capabilities into account. Fixes: cac923cfea47 ("ethdev: support runtime queue setup") Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH] net/failsafe: limit device capabilities to really supported

2018-09-25 Thread Andrew Rybchenko
On 9/25/18 6:48 PM, Gaëtan Rivet wrote: Hi, Sorry I had forgotten this one. I would rename the title, something like: net/failsafe: report actual device capabilities And a few edits in the commit log: On Wed, Aug 29, 2018 at 08:45:36AM +0100, Andrew Rybchenko wrote: From: Igor Romanov Fail

[dpdk-dev] [PATCH v6] doc: Clarify IOMMU usage with "uio_pci_generic" kernel module

2018-09-25 Thread tone.zhang
If the devices used for DPDK are bound to the "uio_pci_generic" kernel module, the IOMMU should be disabled in order not to break the IO transmission because of the virtual / physical address mapping. The patch clarifies the IOMMU configurations on both x86_64 and arm64 systems. Signed-off-by: to

Re: [dpdk-dev] [PATCH v6 0/2] introduce vdpa sample

2018-09-25 Thread Wang, Xiao W
Hi, > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 26, 2018 5:07 PM > To: dev@dpdk.org; Maxime Coquelin ; Bie, > Tiwei ; Wang, Zhihong > Cc: Wang, Xiao W ; Rami Rosen > ; Wang, Haiyue ; Ye, > Xiaolong > Subject: [PATCH v6 0/2] introduce vdpa sample > > Hi, > > T

[dpdk-dev] [PATCH] app/testpmd: check Rx VLAN offload flag to print VLAN TCI

2018-09-25 Thread John Daley
From: Hyong Youb Kim Since the following commit, PKT_RX_VLAN indicates the presence of mbuf's vlan_tci, not PKT_RX_VLAN_STRIPPED. commit 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") Cc: olivier.m...@6wind.com Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- app/test-pmd/rxonl

[dpdk-dev] [PATCH 6/6] net/enic: explicitly disable overlay offload

2018-09-25 Thread John Daley
From: Hyong Youb Kim Reopening vNIC does not automatically disable overlay offload. If it is previously enabled, it remains enabled even when the user restarts DPDK and requests overlay offload to be disabled via devarg disable-overlay=1. So explicitly disable overlay offload when requested. Fix

[dpdk-dev] [PATCH 5/6] net/enic: add VLAN and csum offloads to simple Tx handler

2018-09-25 Thread John Daley
From: Hyong Youb Kim Currently the simple Tx handler supports no offloads, which makes it usable only for a small number of benchmarks. Add vlan and checksum offloads to the handler, as cycles/packet increases only by about 3 cycles, and applications commonly use those offloads. Signed-off-by: H

[dpdk-dev] [PATCH 4/6] net/enic: do not use deprecated Tx VLAN packet flag

2018-09-25 Thread John Daley
From: Hyong Youb Kim Replace PKT_TX_VLAN_PKT (deprecated) with PKT_TX_VLAN. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_res.c | 2 +- drivers/net/enic/enic_rxtx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enic/eni

[dpdk-dev] [PATCH 3/6] net/enic: set Rx VLAN offload flag for non-stripped packets

2018-09-25 Thread John Daley
From: Hyong Youb Kim The NIC indicates VLAN TCI to the driver even when VLAN stripping is disabled. The driver sets mbuf's vlan_tci but not PKT_RX_VLAN. Set PKT_RX_VLAN to indicate that vlan_tci is valid. Fixes: c6f455507411 ("net/enic: add ethernet VLAN packet type") Cc: sta...@dpdk.org Signed

[dpdk-dev] [PATCH 1/6] net/enic: do not use non-standard integer types

2018-09-25 Thread John Daley
From: Hyong Youb Kim Bugzilla ID: 39 Fixes: 9913fbb91df0 ("enic/base: common code") Fixes: 322b355f2183 ("net/enic/base: bring NIC interface functions up to date") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_devcmd.h | 16 1 file chang

[dpdk-dev] [PATCH 2/6] net/enic: enable IOVA mode

2018-09-25 Thread John Daley
From: Hyong Youb Kim Cisco VIC models support RTE_IOVA_VA, so enable it. This change allows the driver to work properly when --no-huge is used, in combination with vfio and iommu. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 3 ++- 1 file changed,

[dpdk-dev] [PATCH] net/avf: remove keeping CRC configuration

2018-09-25 Thread Beilei Xing
Remove keeping CRC configuration as it's not supported by AVF. Signed-off-by: Beilei Xing --- drivers/net/avf/avf_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index a7d6982..c5cf5a2 100644 --- a/drivers/net/avf/avf_ethdev

[dpdk-dev] [PATCH v6 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-25 Thread Xiaolong Ye
The vdpa sample application creates vhost-user sockets by using the vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes virtio ring compatible devices to serve virtio driver directly to enable datapath acceleration. As vDPA driver can help to set up vhost datapath, this applic

[dpdk-dev] [PATCH v6 0/2] introduce vdpa sample

2018-09-25 Thread Xiaolong Ye
Hi, This patchset introduces vdpa sample to demonstrate the vDPA use case. v6 changes: * improve the document according to Xiao's comments * fix a typo, PRIu64 -> PRIx64 v5 changes: * improve print format and correct from "PRIu64" to "PRIx64" * use "-c 0x2" to better demonstrate app doesn't need

[dpdk-dev] [PATCH v6 1/2] vhost: introduce API to get vDPA device number

2018-09-25 Thread Xiaolong Ye
It's used to get number of available registered vDPA devices. Signed-off-by: Xiaolong Ye --- lib/librte_vhost/rte_vdpa.h| 3 +++ lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/vdpa.c| 6 ++ 3 files changed, 10 insertions(+) diff --git a/lib/librte

[dpdk-dev] [PATCH] net/i40e: remove keeping CRC configuration for VF

2018-09-25 Thread Beilei Xing
Remove keeping CRC configuration since it's not supported by i40e VF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index

[dpdk-dev] MTU vs MRU

2018-09-25 Thread Chas Williams
What does (or should) rte_eth_dev_set_mtu() do? The documentation says "Change the MTU of an Ethernet device." At least of few of the PMDs do something similar to the following: eth_em_infos_get(dev, &dev_info); frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + ... /*

Re: [dpdk-dev] [PATCH] bus/ifpga: remove useless driver cast

2018-09-25 Thread Xu, Rosen
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, September 26, 2018 6:08 > To: Xu, Rosen ; Zhang, Tianfei > > Cc: dev@dpdk.org > Subject: [PATCH] bus/ifpga: remove useless driver cast > > The rte_afu_driver is assigned to rte_afu_device.driver

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

2018-09-25 Thread Wang, Xiao W
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, September 26, 2018 1:16 AM > To: Wang, Xiao W > Cc: Ye, Xiaolong ; Bie, Tiwei ; > dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready > > O

[dpdk-dev] [PATCH] bus/ifpga: remove useless driver cast

2018-09-25 Thread Thomas Monjalon
The rte_afu_driver is assigned to rte_afu_device.driver during probing. There is no need of accessing the rte_afu_driver via rte_device.driver and type casting to its container. Signed-off-by: Thomas Monjalon --- drivers/bus/ifpga/ifpga_bus.c | 6 ++ drivers/bus/ifpga/rte_bus_ifpga.h | 3

Re: [dpdk-dev] [PATCH v2 2/2] eal: force IOVA to particular mode

2018-09-25 Thread Zhang, Qing Long (Eric)
Hi Anatoly/Bruce, Need your comments since you are the maintainers. Thanks Eric -Original Message- From: Santosh Shukla [mailto:santosh.shu...@caviumnetworks.com] Sent: Tuesday, September 25, 2018 3:16 AM To: Zhang, Qing Long (Eric); anatoly.bura...@intel.com Cc: dev@dpdk.org; Legacy, Al

[dpdk-dev] [PATCH] drivers/bus: fill driver reference after NXP probing

2018-09-25 Thread Thomas Monjalon
The probing functions of NXP buses were missing to set the driver used for successfully probing a device. The NXP driver and the generic rte_driver are now set in the device structures. Signed-off-by: Thomas Monjalon --- drivers/bus/dpaa/dpaa_bus.c | 6 +- drivers/bus/fslmc/fslmc_bus.c |

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

2018-09-25 Thread Kevin Traynor
On 09/14/2018 02:25 AM, Xiao Wang wrote: > If the device is not clearly reset by the previous driver and holds > some invalid ring addr, and the relay thread kicks it before HW is > properly re-configured, a bad DMA request may happen. > > Besides, the notify_addr which is used by the relay thread

Re: [dpdk-dev] cppcheck on dpdk

2018-09-25 Thread Ferruh Yigit
On 5/31/2018 12:22 PM, Ferruh Yigit wrote: > On 5/16/2018 1:41 PM, Ferruh Yigit wrote: >> Today after listening Colin's Static Analysis talk, I run cppcheck on >> v18.05-rc4 >> code and it revealed some issues, sharing here for anyone to interested in >> fixing them. At least I encourage to check

Re: [dpdk-dev] [PATCH v4 3/3] net/softnic: modify to use new table lib headers

2018-09-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 16:32:30 +0100 > From: Kevin Laatz > To: dev@dpdk.org > CC: jianbo@arm.com, gavin...@arm.com, jerin.ja...@caviumnetworks.com, > cristian.dumitre...@intel.com, Kevin Laatz > Subject: [PATCH v4 3/3] net/softnic: modify to use new table lib he

Re: [dpdk-dev] [PATCH v4 2/3] examples/ip_pipeline: modify to use new table lib headers

2018-09-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 16:32:29 +0100 > From: Kevin Laatz > To: dev@dpdk.org > CC: jianbo@arm.com, gavin...@arm.com, jerin.ja...@caviumnetworks.com, > cristian.dumitre...@intel.com, Kevin Laatz > Subject: [PATCH v4 2/3] examples/ip_pipeline: modify to use new tab

Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_table: add hash func header files

2018-09-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 16:32:28 +0100 > From: Kevin Laatz > To: dev@dpdk.org > CC: jianbo@arm.com, gavin...@arm.com, jerin.ja...@caviumnetworks.com, > cristian.dumitre...@intel.com, Kevin Laatz > Subject: [PATCH v4 1/3] lib/librte_table: add hash func header file

Re: [dpdk-dev] [PATCH v3 00/13] net/mvpp2: add new features

2018-09-25 Thread Ferruh Yigit
On 9/25/2018 8:04 AM, Andrzej Ostruszka wrote: > This patch series introduces fixes and adds support for traffic metering, > traffic manager and Tx S/G. Additionally it aligns with for MUSDK 18.09. > > Changes in v3: > * change the format of image referred in doc (png -> svg) > * "cherry-pick" htt

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix printf format specifiers

2018-09-25 Thread Iremonger, Bernard
> -Original Message- > From: Lipiec, Herakliusz > Sent: Tuesday, September 25, 2018 12:23 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: fix printf format specifiers > > change PRIu

Re: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-25 Thread Ferruh Yigit
On 9/25/2018 4:35 PM, Kevin Traynor wrote: > On 09/21/2018 08:36 AM, Beilei Xing wrote: >> HW supports Rx scatter offload, this patch updates >> Rx scatter offload for PF. >> > > Should this be for stable branch also? I think it should, I will update in next-net, Thanks for reminder. > >> Signe

Re: [dpdk-dev] [PATCH] net/failsafe: limit device capabilities to really supported

2018-09-25 Thread Gaëtan Rivet
Hi, Sorry I had forgotten this one. I would rename the title, something like: net/failsafe: report actual device capabilities And a few edits in the commit log: On Wed, Aug 29, 2018 at 08:45:36AM +0100, Andrew Rybchenko wrote: > From: Igor Romanov > > Failsafe driver does not support any devi

Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure

2018-09-25 Thread Ferruh Yigit
On 9/25/2018 2:44 PM, Thomas Monjalon wrote: > 25/09/2018 16:31, Ferruh Yigit: >> From: Paul M Stillwell Jr >> >> The doxygen comment describing the rte_eth_dev_info structure >> was separated from the structure itself so move the comment >> back to be with the structure. >> >> Fixes: 7238e63bce52

Re: [dpdk-dev] [PATCH v6 2/5] vhost: make message handling functions prepare the reply

2018-09-25 Thread Burakov, Anatoly
On 24-Sep-18 9:17 PM, Nikolay Nikolaev wrote: As VhostUserMsg structure is reused to generate the reply, move the relevant fields update into the respective message handling functions. Signed-off-by: Nikolay Nikolaev --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v6 3/5] vhost: handle unsupported message types in functions

2018-09-25 Thread Burakov, Anatoly
On 24-Sep-18 9:17 PM, Nikolay Nikolaev wrote: Add new functions to handle the unsupported vhost message types: - vhost_user_set_vring_err - vhost_user_set_log_fd Signed-off-by: Nikolay Nikolaev --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v6 1/5] vhost: unify struct VhostUserMsg usage

2018-09-25 Thread Burakov, Anatoly
On 24-Sep-18 9:17 PM, Nikolay Nikolaev wrote: Do not use the typedef version of struct VhostUserMsg. Also unify the related parameter name. Signed-off-by: Nikolay Nikolaev --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-25 Thread Kevin Traynor
On 09/21/2018 08:36 AM, Beilei Xing wrote: > HW supports Rx scatter offload, this patch updates > Rx scatter offload for PF. > Should this be for stable branch also? > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dr

[dpdk-dev] [PATCH v4 1/3] lib/librte_table: add hash func header files

2018-09-25 Thread Kevin Laatz
This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h to librte_table. This reduces code duplication by removing duplicate header files within two folders and consolidating them into a single one. This also adds a scalar implementation of the x86_64 intrinsic for crc32 as a generic

[dpdk-dev] [PATCH v4 3/3] net/softnic: modify to use new table lib headers

2018-09-25 Thread Kevin Laatz
This commit modifies SoftNIC to make use of the new header files in librte_table. As we are now using the new header files in librte_table in SoftNIC, we no longer need the old header files so they can be removed. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kevin Laatz Acked-by: Gavin Hu

[dpdk-dev] [PATCH v4 2/3] examples/ip_pipeline: modify to use new table lib headers

2018-09-25 Thread Kevin Laatz
This commit modifies the IP Pipeline application to use the new header files in librte_table. As we are now using the new header files, we can remove the old ones from the application directory. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kevin Laatz Acked-by: Gavin Hu --- examples/ip_p

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 4:15 PM, Hunt, David wrote: What happens if someone sends a string with a "{" or "}" inside? If we get to the end of the buffer without a "}", it calls the library to convert, will fail, and move on.  No damage done (I hope). Also, a short un-terminated (by "}") string will also

[dpdk-dev] [PATCH v1] doc: remove unused release note file

2018-09-25 Thread John McNamara
Remove unused file from the release notes docs. This file was used to display a hierarchy in older releases, circa 2015, but doesn't seem useful in the current structure. Signed-off-by: John McNamara --- doc/guides/rel_notes/index.rst | 1 - doc/guides/rel_notes/rel_description.rst |

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-09-25 Thread Akhil Goyal
Hi Andrzej, On 9/21/2018 8:23 PM, Andrzej Ostruszka wrote: This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. v2: * added Cc: sta...@dpdk.org to couple o

Re: [dpdk-dev] [PATCH] latencystats: fix timestamp marking and latency calculation

2018-09-25 Thread longtb5
Hi Reshma, I mean in the latencystats document. A few lines about what is taken away by the library (the mbuf timestamp when PKT_RX_TIMESTAMP is set) would be very helpful. Best regards, BL - Original Message - From: "reshma pattan" To: long...@viettel.com.vn Cc: "Konstantin Ananyev" ,

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Hunt, David
On 25/9/2018 3:15 PM, Burakov, Anatoly wrote: On 25-Sep-18 3:00 PM, Hunt, David wrote: Now you're removing those newlines you added in previous commit :) Fixed in previous patch in the next version.   if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {   /*    * If the co

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: add sanity checks on received/sent packets

2018-09-25 Thread David Marchand
On Tue, Sep 25, 2018 at 3:17 PM, Iremonger, Bernard wrote: > Hi David, > >> -Original Message- >> From: David Marchand [mailto:david.march...@6wind.com] >> Sent: Monday, September 10, 2018 6:46 AM >> To: dev@dpdk.org >> Cc: olivier.m...@6wind.com; Lu, Wenzhuo ; Wu, >> Jingjing ; Iremonger,

Re: [dpdk-dev] [PATCH] doc: announce CRC strip changes in release notes

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 6:12 PM, David Marchand wrote: > On Mon, Sep 24, 2018 at 7:31 PM, Ferruh Yigit wrote: >> Document changes done in >> commit 323e7b667f18 ("ethdev: make default behavior CRC strip on Rx") >> >> Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon > Reviewed-by: David Marchand Ap

[dpdk-dev] [PATCH 3/3] net/mlx5: eswitch-modify MAC address actions

2018-09-25 Thread Xiaoyu Min
Offload following modify MAC address actions to E-Switch via TC-Flower driver - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST The corresponding rte_flow_item_eth must be present in rte_flow pattern Only support modify outer layer MAC address Signed-off-by: Xiaoyu Min ---

[dpdk-dev] [PATCH 1/3] ethdev: add generic MAC address rewrite actions

2018-09-25 Thread Xiaoyu Min
rte_flow actions: - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST added in order to offload to NIC The rte_flow_itme_eth must be present in rte_flow pattern Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 30 ++ lib/librte_eth

[dpdk-dev] [PATCH 0/3] ethdev: add generic MAC address rewrite actions

2018-09-25 Thread Xiaoyu Min
This series is for RFC[1] Patch 1 adds generic MAC address rewrite actions to flow API Patch 2 adds testpmd commands for that Patch 3 offloads these actions on Mellanox MLX5 by using E-Switch rule [1]: https://patches.dpdk.org/patch/44005/ Xiaoyu Min (3): ethdev: add generic MAC address rewrit

[dpdk-dev] [PATCH 2/3] app/testpmd: add commands of modify MAC address

2018-09-25 Thread Xiaoyu Min
add commands to support following actions: - RTE_FLOW_ACTION_TYPE_SET_MAC_SRC - RTE_FLOW_ACTION_TYPE_SET_MAC_DST Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 50 + app/test-pmd/config.c | 4 ++ doc/guides/testpmd_app_ug/t

Re: [dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-09-25 Thread Kevin Traynor
On 09/21/2018 02:26 PM, Jens Freimann wrote: > This adds a new forwarding mode to testpmd to simulate > more realistic behavior of a guest machine engaged in receiving > and sending packets performing Virtual Network Function (VNF). > > The goal is to enable a simple way of measuring performance i

[dpdk-dev] [PATCH v3] latencystats: fix timestamp marking and latency calculation

2018-09-25 Thread Reshma Pattan
Latency calculation logic is not correct for the case where packets gets dropped before TX. As for the dropped packets, the timestamp is not cleared, and such packets still gets counted for latency calculation in next runs, that will result in inaccurate latency measurement. So fix this issue as b

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/cxgbe: add missing DEV_RX_OFFLOAD_SCATTER flag

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 5:05 PM, Rahul Lakkireddy wrote: > Scatter Rx is already supported by CXGBE PMD. So, add the missing > DEV_RX_OFFLOAD_SCATTER flag to the list of supported Rx offload > features. > > Also, move the macros for supported list of offload features to > header file. > > Fixes: 436125e6417

Re: [dpdk-dev] [PATCH v2] crypto/openssl: support truncated HMAC operations

2018-09-25 Thread Akhil Goyal
On 9/16/2018 8:48 AM, Dmitry Eremin-Solenikov wrote: IPsec requires truncated HMAC operations support. Extend OpenSSL crypto PMD to support truncated HMAC operations necessary for IPsec. Signed-off-by: Dmitry Eremin-Solenikov --- Changes since V1: - support all digest sizes from half of co

Re: [dpdk-dev] [PATCH] acl: fix classify with no rules in ctx

2018-09-25 Thread Ananyev, Konstantin
Hi Filip, > > Executing classify with no context or a context without any rules added > to it leads to a crash. This patch introduces checks for acl to ensure > possibility to defer creation of rules until a later point. A new > return value is introduced to allow the user of the API to decide ho

[dpdk-dev] [PATCH v2 3/3] net/mlx5: eswitch-modify TTL actions

2018-09-25 Thread Xiaoyu Min
Offload following modify TTL actions to E-Switch via TC-Flower driver - RTE_FLOW_ACTION_TYPE_SET_TTL - RTE_FLOW_ACTION_TYPE_DEC_TTL The corresponding IP protocol rte_flow_item_ipv[4|6] must be present in rte_flow pattern otherwith PMD return error Signed-off-by: Xiaoyu Min --- drivers/net/mlx5

[dpdk-dev] [PATCH v2 2/3] app/testpmd: add commands of modify TTL

2018-09-25 Thread Xiaoyu Min
add commands which supports following TTL actions: - RTE_FLOW_ACTION_TYPE_DEC_TTL - RTE_FLOW_ACTION_TYPE_SET_TTL Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 34 + app/test-pmd/config.c | 3 ++ doc/guides/testpmd_app_ug/te

[dpdk-dev] [PATCH v2 1/3] ethdev: add generic TTL rewrite actions

2018-09-25 Thread Xiaoyu Min
rewrite TTL by decrease or just set it directly it's not necessary to check if the final result is zero or not This is slightly different from the one defined by openflow and more generic Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 30 + lib/li

[dpdk-dev] [PATCH v2 0/3] ethdev: add generic TTL rewrite actions

2018-09-25 Thread Xiaoyu Min
This patch series is for RFC[1] Patch 1 adds generic TTL rewrite actions to flow API Patch 2 adds corresponding testpmd commands Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5 [1]: https://patches.dpdk.org/patch/43617/ V2: * fix misspelled issues reported by checkpat

Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

2018-09-25 Thread Ananyev, Konstantin
Hi Luca, > > On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote: > > 24/08/2018 18:47, Konstantin Ananyev: > > > If user specifies priority=0 for some of ACL rules > > > that can cause rte_acl_classify to return wrong results. > > > The reason is that priority zero is used internally for no

Re: [dpdk-dev] [PATCH 00/11] net/sfc: update base driver to support 50G and 100G

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 2:50 PM, Andrew Rybchenko wrote: > Add base driver patches to support 50G and 100G XtremeScale X2 > family adapters. > > In this particular case it looks better to have separate patch which > updates documentation (as a cut line which summarizes the result). > > There are few checkpa

Re: [dpdk-dev] [PATCH v2] latencystats: fix timestamp marking and latency calculation

2018-09-25 Thread Ananyev, Konstantin
Hi Reshma, > > > Latency calculation logic is not correct for the case where > packets gets dropped before TX. As for the dropped packets, > the timestamp is not cleared, and such packets still gets > counted for latency calculation in next runs, that will result > in inaccurate latency measur

Re: [dpdk-dev] [PATCH v1] app/test-crypto-perf: fix double allocation of memory

2018-09-25 Thread Akhil Goyal
On 9/10/2018 12:10 PM, Anoob Joseph wrote: The field, 'cipher_iv.data' is allocated twice when cipher is not null. Ideally the allocation should depend only on the field 'cperf_options.cipher_iv_sz'. This will make sure this code path gets valid for ciphers which doesn't require IV. Fixes: 0f

Re: [dpdk-dev] [PATCH 0/3] fix test vector checks

2018-09-25 Thread Akhil Goyal
On 9/14/2018 2:54 PM, Anoob Joseph wrote: Multiple fixes to the test vector checks. Anoob Joseph (3): app/test-crypto-perf: add checks for AEAD key app/test-crypto-perf: fix check for auth key app/test-crypto-perf: fix check for cipher IV app/test-crypto-perf/main.c | 12 +

Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-25 Thread Singh, Jasvinder
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, September 25, 2018 3:16 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command > > Hi Jasvinder, > > > -Original Message-

Re: [dpdk-dev] secondary processes and private data

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:10 PM, Alejandro Lucero wrote: I've a problem when part of device private data needs to be private per process. Current multiprocess support shares device private data between primary and secondaries but it is all dependent on a pointer initialized to the same memory address by

Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command

2018-09-25 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, September 25, 2018 12:02 PM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command > > > diff --git a/app/test-pmd/c

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:00 PM, Hunt, David wrote: Now you're removing those newlines you added in previous commit :) Fixed in previous patch in the next version.   if (pol->pkt.core_type == CORE_TYPE_VIRTUAL) {   /*    * If the cores in the policy are virtual, we need to map them

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix error handling logic

2018-09-25 Thread Ferruh Yigit
On 9/24/2018 3:10 PM, Andrew Rybchenko wrote: > On 9/24/18 4:43 PM, Alejandro Lucero wrote: >> This patch fixes how function exit is handled when errors inside >> rte_eth_dev_create. >> >> Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs") >> Cc: sta...@dpdk.org >> >> Signed-off

[dpdk-dev] secondary processes and private data

2018-09-25 Thread Alejandro Lucero
I've a problem when part of device private data needs to be private per process. Current multiprocess support shares device private data between primary and secondaries but it is all dependent on a pointer initialized to the same memory address by the multiprocess support code. If there is a per-p

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 3:00 PM, Shreyansh Jain wrote: On Tuesday 25 September 2018 07:21 PM, Burakov, Anatoly wrote: On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, v

Re: [dpdk-dev] [PATCH v3 5/8] examples/power: add json string handling

2018-09-25 Thread Hunt, David
Hi Anatoly, On 25/9/2018 12:27 PM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentati

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Shreyansh Jain
On Tuesday 25 September 2018 07:21 PM, Burakov, Anatoly wrote: On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to main

Re: [dpdk-dev] [PATCH v3 4/8] examples/power: add host channel to power manager

2018-09-25 Thread Hunt, David
Hi Anatoly, On 25/9/2018 10:48 AM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo.0 Signed-off-b

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical a

[dpdk-dev] [PATCH 3/3] net/mlx5: eswitch-modify TTL actions

2018-09-25 Thread Xiaoyu Min
Offload following modify TTL actions to E-Swtich via TC-Flower driver - RTE_FLOW_ACTION_TYPE_SET_TTL - RTE_FLOW_ACTION_TYPE_DEC_TTL The corresponding IP protocol rte_flow_item_ipv[4|6] must be present in rte_flow pattern otherwith PMD return error Signed-off-by: Xiaoyu Min --- drivers/net/mlx5

[dpdk-dev] [PATCH 2/3] app/testpmd: add commands of modify TTL

2018-09-25 Thread Xiaoyu Min
add commands which supports following TTL actions: - RTE_FLOW_ACTION_TYPE_DEC_TTL - RTE_FLOW_ACTION_TYPE_SET_TTL Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 34 + app/test-pmd/config.c | 3 ++ doc/guides/testpmd_app_ug/te

[dpdk-dev] [PATCH 1/3] ethdev: add generic TTL rewrite actions

2018-09-25 Thread Xiaoyu Min
rewrite TTL by decrease or just set it directly it's not necessary to check if the final result is zero or not This is slightly different from the one defined by openflow and more generic Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 30 + lib/li

Re: [dpdk-dev] [PATCH v3 2/8] lib/power: add changes for host commands/policies

2018-09-25 Thread Hunt, David
On 25/9/2018 10:21 AM, Burakov, Anatoly wrote: On 14-Sep-18 2:54 PM, David Hunt wrote: Signed-off-by: David Hunt The commit message is not very descriptive as to what these chages are and why they are added. Sure, I'll add a more descriptive comment next version. Thanks, Dave.

[dpdk-dev] [PATCH 0/3] ethdev: add generic TTL rewrite actions

2018-09-25 Thread Xiaoyu Min
This patch series is for RFC[1] Patch 1 adds generic TTL rewrite actions to flow API Patch 2 adds corresponding testpmd commands Patch 3 implements the offloading logic of E-Switch rules on Mellanox MLX5 [1]: https://patches.dpdk.org/patch/43617/ Xiaoyu Min (3): ethdev: add generic TTL rewrite

Re: [dpdk-dev] [PATCH v3 1/8] examples/power: add checks around hypervisor

2018-09-25 Thread Hunt, David
On 25/9/2018 10:20 AM, Burakov, Anatoly wrote: On 14-Sep-18 2:53 PM, David Hunt wrote: Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A u

Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure

2018-09-25 Thread Thomas Monjalon
25/09/2018 16:31, Ferruh Yigit: > From: Paul M Stillwell Jr > > The doxygen comment describing the rte_eth_dev_info structure > was separated from the structure itself so move the comment > back to be with the structure. > > Fixes: 7238e63bce52 ("ethdev: add support for device offload capabiliti

[dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure

2018-09-25 Thread Ferruh Yigit
From: Paul M Stillwell Jr The doxygen comment describing the rte_eth_dev_info structure was separated from the structure itself so move the comment back to be with the structure. Fixes: 7238e63bce52 ("ethdev: add support for device offload capabilities") Cc: ivan.bo...@6wind.com Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Shreyansh Jain
Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical addressing mode (one of the option for FSLMC,

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Burakov, Anatoly
On 25-Sep-18 1:54 PM, Shreyansh Jain wrote: A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical addressing mode (one of the option for FSLMC, and only option for DPAA bus), the addresses of descriptors Rx'd are physical. T

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: add sanity checks on received/sent packets

2018-09-25 Thread Iremonger, Bernard
Hi David, > -Original Message- > From: David Marchand [mailto:david.march...@6wind.com] > Sent: Monday, September 10, 2018 6:46 AM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard > > Subject: [PATCH 3/3] app/testpmd: add sanity checks on

Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update

2018-09-25 Thread Kovacevic, Marko
> Add empty poll mode command line example > > Signed-off-by: Liang Ma > --- > doc/guides/sample_app_ug/l3_forward_power_man.rst | 29 > +++ > 1 file changed, 29 insertions(+) > > +Empty Poll Mode > +- > +There is a new Mode which is added recently. E

[dpdk-dev] [PATCH] doc: fix eventdev shared library version

2018-09-25 Thread Jerin Jacob
The below change set suppose to bump the eventdev shared library version. It missed updating the version number so fixing it now. Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- doc/guides/rel_notes/release_18_08.rst

Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

2018-09-25 Thread Thomas Monjalon
25/09/2018 14:22, Luca Boccassi: > On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote: > > 24/08/2018 18:47, Konstantin Ananyev: > > > If user specifies priority=0 for some of ACL rules > > > that can cause rte_acl_classify to return wrong results. > > > The reason is that priority zero is us

[dpdk-dev] [PATCH 5/5] fslmc: enable dpaax library

2018-09-25 Thread Shreyansh Jain
With this patch, fslmc bus and ethernet devices on this bus would start using the physical-virtual library interfaces. This patch impacts mempool/dpaa2, event/dpaa2, net/dpaa2, raw/dpaa2_cmdif and raw/dpaa2_qdma as they are dependent on the bus/fslmc and thus impact linkage of libraries. Signed-o

[dpdk-dev] [PATCH 4/5] dpaa: enable dpaax library

2018-09-25 Thread Shreyansh Jain
With this patch, dpaa bus and ethernet devices on this bus would start using the physical-virtual library interfaces. This patch impacts mempool/dpaa, event/dpaa and net/dpaa as they are dependent on the bus/dpaa and thus impact linkage of libraries. Signed-off-by: Shreyansh Jain --- drivers/bu

[dpdk-dev] [PATCH 0/5] Add a PA-VA Translation table for DPAAx

2018-09-25 Thread Shreyansh Jain
::Background:: After the restructuring of memory in last release(s), one of the major impact on fslmc/dpaa bus (and its devices) was the performance drop when using physical addressing. Previously, it was assumed that physical range was contiguous for any given request for hugepage memory. That wa

[dpdk-dev] [PATCH 1/5] bus/fslmc: fix physical addressing check

2018-09-25 Thread Shreyansh Jain
In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabled, only supported class is RTE_IOVA_PA. Fixes: f7768afac101 ("bus/fslmc: support dynamic IOVA") Cc: hemant.agra...@nxp.com Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-25 Thread Shreyansh Jain
A common library, valid for dpaaX drivers, which is used to maintain a local copy of PA->VA translations. In case of physical addressing mode (one of the option for FSLMC, and only option for DPAA bus), the addresses of descriptors Rx'd are physical. These need to be converted into equivalent VA f

[dpdk-dev] [PATCH 2/5] drivers: common as dependency for bus

2018-09-25 Thread Shreyansh Jain
It is possible that bus requires common library for compilation. Prior to this patch, bus and common compiled parallel. But, post this dependency is created. This is especially important for the DPAA/FSLMC buses which are going to use the common/dpaax library. Signed-off-by: Shreyansh Jain ---

Re: [dpdk-dev] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API

2018-09-25 Thread Thomas Monjalon
25/09/2018 11:56, Jerin Jacob: > From: Thomas Monjalon > > 25/09/2018 11:15, Jerin Jacob: > > > From: Nikhil Rao > > > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were > > > > incremented in this version. > > > > librte_distributor.so.1 > > > > librte_eal.so.8 > >

Re: [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API

2018-09-25 Thread Kovacevic, Marko
> > Update the document for empty poll API. > > > > Signed-off-by: Liang Ma > > --- > > doc/guides/prog_guide/power_man.rst | 90 > > + > > 1 file changed, 90 insertions(+) > > > > diff --git a/doc/guides/prog_guide/power_man.rst > > b/doc/guides/prog_guide/pow

Re: [dpdk-dev] [PATCH v8 3/4] doc/guides/proguide/power-man: update the power API

2018-09-25 Thread Kovacevic, Marko
> Update the document for empty poll API. > > Signed-off-by: Liang Ma > --- > doc/guides/prog_guide/power_man.rst | 90 > + > 1 file changed, 90 insertions(+) > > diff --git a/doc/guides/prog_guide/power_man.rst > b/doc/guides/prog_guide/power_man.rst > index

[dpdk-dev] [PATCH v2] latencystats: fix timestamp marking and latency calculation

2018-09-25 Thread Reshma Pattan
Latency calculation logic is not correct for the case where packets gets dropped before TX. As for the dropped packets, the timestamp is not cleared, and such packets still gets counted for latency calculation in next runs, that will result in inaccurate latency measurement. So fix this issue as b

Re: [dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

2018-09-25 Thread Luca Boccassi
On Sun, 2018-09-16 at 11:56 +0200, Thomas Monjalon wrote: > 24/08/2018 18:47, Konstantin Ananyev: > > If user specifies priority=0 for some of ACL rules > > that can cause rte_acl_classify to return wrong results. > > The reason is that priority zero is used internally for no-match > > nodes. > > S

  1   2   >