Hi Jasvinder,
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Tuesday, September 25, 2018 12:02 PM
> To: Iremonger, Bernard <bernard.iremon...@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing
> <jingjing...@intel.com>
> Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command
>
> > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
> > > index f908fb3..32a4730 100644
> > > --- a/app/test-pmd/cmdline_mtr.c
> > > +++ b/app/test-pmd/cmdline_mtr.c
> > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t
> > > cmd_add_port_meter_profile_srtcm = {
> > > (void *)&cmd_add_port_meter_profile_srtcm_port,
> > > (void *)&cmd_add_port_meter_profile_srtcm_meter,
> > > (void *)&cmd_add_port_meter_profile_srtcm_profile,
> > > + (void
> > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697,
> > > (void *)&cmd_add_port_meter_profile_srtcm_port_id,
> > > (void *)&cmd_add_port_meter_profile_srtcm_profile_id,
> > > - (void
> > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697,
> > > (void *)&cmd_add_port_meter_profile_srtcm_cir,
> > > (void *)&cmd_add_port_meter_profile_srtcm_cbs,
> > > (void *)&cmd_add_port_meter_profile_srtcm_ebs,
> > > @@ -521,9 +521,9 @@ cmdline_parse_inst_t
> > > cmd_add_port_meter_profile_trtcm = {
> > > (void *)&cmd_add_port_meter_profile_trtcm_port,
> > > (void *)&cmd_add_port_meter_profile_trtcm_meter,
> > > (void *)&cmd_add_port_meter_profile_trtcm_profile,
> > > + (void
> > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698,
> > > (void *)&cmd_add_port_meter_profile_trtcm_port_id,
> > > (void *)&cmd_add_port_meter_profile_trtcm_profile_id,
> > > - (void
> > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698,
> > > (void *)&cmd_add_port_meter_profile_trtcm_cir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_pir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_cbs,
> > > @@ -633,9 +633,9 @@ cmdline_parse_inst_t
> > > cmd_add_port_meter_profile_trtcm_rfc4115 = {
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile,
> > > + (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id,
> > > - (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115,
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs,
> > > --
> > > 2.9.3
> >
> > ./devtools/check-git-log.sh -1
> > Line too long:
> > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000
> > 3125000000 2500000 2500000
> >
> >
> > Also when I execute the command I get the following error:
> >
> > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000
> > testpmd> 3125000000
> > testpmd> 2500000 2500000
> > cause unspecified: Function not implemented (error 1)
> >
> > Is some more configuration needed to use this command?
> >
> Meter and policing support is only available in Softnic PMD, please trying
> using that when testing the CLI.
>
> Thanks,
> Jasvinder
The fix works with the Softnic PMD.
The commit message needs revision otherwise
Acked-by: Bernard Iremonger <bernard.iremon...@intel.com>
