Re: [dpdk-dev] [RFC v2] ethdev: support metadata as flow rule criteria

2018-08-28 Thread Dekel Peled
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, August 28, 2018 10:44 PM > To: Dekel Peled > Cc: dev ; Shahaf Shuler ; Ori Kam > ; Andrew Rybchenko ; > Yigit, Ferruh ; Thomas Monjalon > ; Ananyev, Konstantin > ; Adrien Mazarguil > ; Olivier Matz ; > Alex Rosenbaum > Subject:

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Kokkilagadda, Kiran
Agreed. Please go a head and make the changes. You need to make same change in kernel side also. And please use c11 ring (see rte_ring) mechanism so that it won't impact other platforms like intel. We need this change just for arm and ppc. From: Honnappa Nagara

Re: [dpdk-dev] [PATCH v1] testpmd: add new command for show port info

2018-08-28 Thread Rami Rosen
Hi, Thanks for this patch, this patch is something needed. It seems to me that adding get_valid_ports() is not necessary, as you have rte_eth_dev_count_avail(), which is implemented the same; please look in rte_ethdev.[c,h; and actually, testpmd uses rte_eth_dev_count_avail(), for example, in atta

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

2018-08-28 Thread Honnappa Nagarahalli
-Original Message- From: dev On Behalf Of Jerin Jacob Sent: Monday, August 27, 2018 7:39 AM To: dev@dpdk.org Cc: olivier.m...@6wind.com; Jerin Jacob Subject: [dpdk-dev] [PATCH] mbuf: add IGMP packet type Add support for IGMP packet type. Signed-off-by: Jerin Jacob --- lib/librte_mb

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Honnappa Nagarahalli
I agree with Gavin here. Store to fifo->write and fifo->read can get hoisted resulting in accessing invalid buffer array entries or over writing of the buffer array entries. IMO, we should solve this using c11 atomics. This will also help remove the use of 'volatile' from 'rte_kni_fifo' structur

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-28 Thread Jack MIN
On Tue, Aug 28, 2018 at 01:42:18PM -0700, Yongseok Koh wrote: > On Fri, Aug 24, 2018 at 02:45:00PM +0800, Jack MIN wrote: > > On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote: > > > On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > > > > rte_errno is a per thread variable an

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-28 Thread Jack MIN
On Tue, Aug 28, 2018 at 01:15:09PM +0300, Andrew Rybchenko wrote: > On 08/07/2018 05:20 PM, Jack Min wrote: > > There is a need to offload rewrite MAC address for both destination and > > source > > from the matched flow > > > > The proposed actions could make above easily achieved > > > > > >

Re: [dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

2018-08-28 Thread Chas Williams
On Fri, Aug 24, 2018 at 12:45 PM wrote: > From: Robert Shearman > > SR-IOV VFs support "transparent" VLANs. Traffic from/to a VM > associated with a VF has a VLAN tag inserted/stripped in a manner > intended to be totally transparent to the VM. On a Linux hypervisor > the vlan can be specified

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Wiles, Keith
> On Aug 28, 2018, at 2:16 PM, Saber Rezvani wrote: > > > > On 08/28/2018 11:39 PM, Wiles, Keith wrote: >> Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a >> performance problem. > I use Pktgen verion 3.0.0, indeed it is O.k as far as I have one core. (10 > Gb/s) but when

Re: [dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

2018-08-28 Thread Honnappa Nagarahalli
-Original Message- From: Malvika Gupta Sent: Tuesday, August 28, 2018 3:46 PM To: konstantin.anan...@intel.com Cc: dev@dpdk.org; Gavin Hu ; Honnappa Nagarahalli ; Brian Brooks ; nd ; Malvika Gupta ; Malvika Gupta Subject: [PATCH] test/bpf: use hton instead of __builtin_bswap Conve

[dpdk-dev] [PATCH] test/bpf: use hton instead of __builtin_bswap

2018-08-28 Thread Malvika Gupta
Convert host machine endianness to networking endianness for comparison of incoming packets with BPF filter Signed-off-by: Malvika Gupta Reviewed-by: Gavin Hu Reviewed-by: Brian Brooks Suggested-by: Brian Brooks --- test/bpf/t1.c | 7 --- test/bpf/t3.c | 3 ++- 2 files changed, 6 inserti

Re: [dpdk-dev] [PATCH] net/mlx5: handle expected errno properly

2018-08-28 Thread Yongseok Koh
On Fri, Aug 24, 2018 at 02:45:00PM +0800, Jack MIN wrote: > On Thu, Aug 23, 2018 at 02:08:09PM -0700, Yongseok Koh wrote: > > On Thu, Aug 23, 2018 at 02:38:51PM +0800, Xiaoyu Min wrote: > > > rte_errno is a per thread variable and is widely used as an > > > error indicator, which means a function c

Re: [dpdk-dev] [RFC v2] ethdev: support metadata as flow rule criteria

2018-08-28 Thread Yongseok Koh
> On Aug 26, 2018, at 7:09 AM, Dekel Peled wrote: > > Current implementation of rte_flow allows match pattern of flow rule, > based on packet data or header fields. > This limits the application use of match patterns. > > For example, consider a vswitch application which controls a set of VMs, >

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Gavin Hu
Assuming reader and writer may execute on different CPU's, this become standard multithreaded programming. We are concerned about that update the reader pointer too early(weak ordering may reorder it before reading from the slots), that means the slots are released and may immediately overwritte

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Saber Rezvani
On 08/28/2018 11:39 PM, Wiles, Keith wrote: Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a performance problem. I use Pktgen verion 3.0.0, indeed it is O.k as far as I  have one core. (10 Gb/s) but when I increase the number of core (one core per queue) then I loose some

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-28 Thread Yongseok Koh
> On Aug 24, 2018, at 3:11 AM, Ananyev, Konstantin > wrote: > > > >> -Original Message- >> From: Yongseok Koh [mailto:ys...@mellanox.com] >> Sent: Thursday, August 23, 2018 10:32 PM >> To: Andrew Rybchenko >> Cc: Dekel Peled ; dev@dpdk.org; or...@mellanox.com; >> shah...@mellanox.com

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Wiles, Keith
Which version of Pktgen? I just pushed a patch in 3.5.3 to fix a performance problem. > On Aug 28, 2018, at 12:05 PM, Saber Rezvani wrote: > > > > On 08/28/2018 08:31 PM, Stephen Hemminger wrote: >> On Tue, 28 Aug 2018 17:34:27 +0430 >> Saber Rezvani wrote: >> >>> Hi, >>> >>> >>> I have

Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt completion queue index wrapping

2018-08-28 Thread Yongseok Koh
> On Aug 23, 2018, at 4:10 PM, Xueming Li wrote: > > Rxq cq_ci was 16 bits while hardware is expecting to wrap > around 24 bits, this caused interrupt failure after burst of packets. > > Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") > Cc: Shahaf Shuler > > Signed-off-by: Xueming

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Van Haaren, Harry
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, August 24, 2018 12:22 AM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastructure > > On Thu, 23 A

Re: [dpdk-dev] [PATCH 03/11] telemetry: add client feature and sockets

2018-08-28 Thread Van Haaren, Harry
> -Original Message- > From: Hunt, David > Sent: Tuesday, August 28, 2018 4:27 PM > To: Stephen Hemminger ; Power, Ciara > > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 03/11] telemetry: add client feature and > sockets > > > On

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Saber Rezvani
On 08/28/2018 08:31 PM, Stephen Hemminger wrote: On Tue, 28 Aug 2018 17:34:27 +0430 Saber Rezvani wrote: Hi, I have run multi_process/symmetric_mp example in DPDK example directory. For a one process its throughput is line rate but as I increase the number of cores I see decrease in throu

Re: [dpdk-dev] [PATCH 02/11] telemetry: add initial connection socket

2018-08-28 Thread Van Haaren, Harry
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, August 28, 2018 5:40 PM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 02/11] telemetry: add initial connection > socket > > +int32_t > > +rte_tele

Re: [dpdk-dev] [PATCH v1] testpmd: add new command for show port info

2018-08-28 Thread Stephen Hemminger
On Tue, 28 Aug 2018 15:11:34 +0100 Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > Signed-off-by: Emma Finn Looks good. Maybe it would be better to drop off redundant information or only add a s

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Van Haaren, Harry
Hi Gaetan, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, August 28, 2018 12:47 PM > To: Power, Ciara > Cc: Van Haaren, Harry ; Archbold, Brian > ; Kenny, Emma ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry >

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Van Haaren, Harry
> From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Friday, August 24, 2018 2:04 PM > To: Power, Ciara ; Van Haaren, Harry > ; Archbold, Brian ; > Kenny, Emma > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastructure > > On Thursday 23 Aug

Re: [dpdk-dev] [PATCH 02/11] telemetry: add initial connection socket

2018-08-28 Thread Gaëtan Rivet
Hi Ciara, On Thu, Aug 23, 2018 at 01:08:04PM +0100, Ciara Power wrote: > This patch adds the telemetry UNIX socket. It is used to > allow connections from external clients. > > On the initial connection from a client, ethdev stats are > registered in the metrics library, to allow for their retrie

Re: [dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Stephen Hemminger
On Tue, 28 Aug 2018 17:34:27 +0430 Saber Rezvani wrote: > Hi, > > > I have run multi_process/symmetric_mp example in DPDK example directory. > For a one process its throughput is line rate but as I increase the > number of cores I see decrease in throughput. For example, If the number > of queu

Re: [dpdk-dev] [PATCH v2] net/mlx: add meson build support

2018-08-28 Thread Bruce Richardson
Thanks for this, comments inline below. /Bruce On Mon, Aug 27, 2018 at 02:42:25PM +0200, Nelio Laranjeiro wrote: > Mellanox drivers remains un-compiled by default due to third party > libraries dependencies. They can be enabled through: > - enable_driver_mlx{4,5}=true or > - enable_driver_mlx{4,

Re: [dpdk-dev] [PATCH 03/11] telemetry: add client feature and sockets

2018-08-28 Thread Hunt, David
On 24/8/2018 12:27 AM, Stephen Hemminger wrote: On Thu, 23 Aug 2018 13:08:05 +0100 Ciara Power wrote: This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register

[dpdk-dev] [PATCH 8/8] net/mvneta: add reset statistics callback

2018-08-28 Thread Andrzej Ostruszka
From: Natalie Samsonov Add support for reseting of driver statistics. Singed-off-by: Natalie Samsonov --- drivers/net/mvneta/mvneta_ethdev.c | 40 +++--- drivers/net/mvneta/mvneta_ethdev.h | 1 + 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/d

[dpdk-dev] [PATCH 3/8] net/mvneta: support for setting of MTU

2018-08-28 Thread Andrzej Ostruszka
From: Natalie Samsonov Add callback for setting of MTU. Signed-off-by: Natalie Samsonov Signed-off-by: Zyta Szpak --- drivers/net/mvneta/mvneta_ethdev.c | 78 ++ 1 file changed, 78 insertions(+) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH 4/8] net/mvneta: add link update

2018-08-28 Thread Andrzej Ostruszka
From: Natalie Samsonov Add callback for updating information about link status/info. Signed-off-by: Natalie Samsonov --- drivers/net/mvneta/mvneta_ethdev.c | 71 ++ 1 file changed, 71 insertions(+) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/

[dpdk-dev] [PATCH 7/8] net/mvneta: add support for basic stats

2018-08-28 Thread Andrzej Ostruszka
From: Yelena Krivosheev Add support for getting of basic statistics for the driver. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov --- drivers/net/mvneta/mvneta_ethdev.c | 47 ++ 1 file changed, 47 insertions(+) diff --git a/drivers/net/m

[dpdk-dev] [PATCH 6/8] net/mvneta: add MAC filtering

2018-08-28 Thread Andrzej Ostruszka
From: Yelena Krivosheev Add callbacks for adding/removing MAC addresses. Signed-off-by: Yelena Krivosheev Signed-off-by: Natalie Samsonov --- drivers/net/mvneta/mvneta_ethdev.c | 69 ++ 1 file changed, 69 insertions(+) diff --git a/drivers/net/mvneta/mvnet

[dpdk-dev] [PATCH 5/8] net/mvneta: support for promiscuous

2018-08-28 Thread Andrzej Ostruszka
From: Yelena Krivosheev Add callbacks for enabling/disabling of promiscuous mode. Signed-off-by: Yelena Krivosheev --- drivers/net/mvneta/mvneta_ethdev.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH 2/8] net/mvneta: add Rx/Tx support

2018-08-28 Thread Andrzej Ostruszka
From: Yelena Krivosheev Add part of PMD for actual reception/transmission. Signed-off-by: Yelena Krivosheev Signed-off-by: Dmitri Epshtein Signed-off-by: Zyta Szpak --- drivers/net/mvneta/mvneta_ethdev.c | 795 + drivers/net/mvneta/mvneta_ethdev.h | 11 +

[dpdk-dev] [PATCH 0/8] Add Marvell NETA PMD

2018-08-28 Thread Andrzej Ostruszka
This patch series introduces new PMD for Marvell NETA adapters (MVNETA). See the documentation for more info. It is split for easier reviewing. Natalie Samsonov (4): net/mvneta: add neta PMD skeleton net/mvneta: support for setting of MTU net/mvneta: add link update net/mvneta: add reset

[dpdk-dev] [PATCH 1/8] net/mvneta: add neta PMD skeleton

2018-08-28 Thread Andrzej Ostruszka
From: Natalie Samsonov Add neta pmd driver skeleton providing base for the further development. Signed-off-by: Natalie Samsonov Signed-off-by: Yelena Krivosheev Signed-off-by: Dmitri Epshtein Signed-off-by: Zyta Szpak Signed-off-by: Andrzej Ostruszka --- MAINTAINERS

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

2018-08-28 Thread Adrien Mazarguil
On Tue, Aug 28, 2018 at 02:38:35PM +0200, Christian Ehrhardt wrote: > On Tue, Aug 28, 2018 at 1:44 PM Adrien Mazarguil > wrote: > > > On Tue, Aug 28, 2018 at 01:30:12PM +0200, Christian Ehrhardt wrote: > > > On Mon, Aug 27, 2018 at 2:22 PM Adrien Mazarguil < > > adrien.mazarg...@6wind.com> > > >

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

2018-08-28 Thread Burakov, Anatoly
On 28-Aug-18 2:27 PM, Sean Harte wrote: On Mon, 27 Aug 2018 at 10:15, Burakov, Anatoly wrote: On 24-Aug-18 4:51 PM, Sean Harte wrote: On Fri, 24 Aug 2018 at 16:19, Burakov, Anatoly wrote: On 24-Aug-18 11:41 AM, Burakov, Anatoly wrote: On 24-Aug-18 10:35 AM, Tiwei Bie wrote: On Fri, Aug 2

[dpdk-dev] [PATCH v1] testpmd: add new command for show port info

2018-08-28 Thread Emma Finn
existing testpmd command "show port info" is too verbose. Added a new summary command to print brief information on ports. Signed-off-by: Emma Finn --- app/test-pmd/cmdline.c | 15 ++- app/test-pmd/config.c | 41 + app/test-pmd/testpmd.h | 2

Re: [dpdk-dev] [PATCH v3 0/6] PMD driver for AF_XDP

2018-08-28 Thread Zhang, Qi Z
Hi William: > -Original Message- > From: William Tu [mailto:u9012...@gmail.com] > Sent: Friday, August 24, 2018 12:25 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Karlsson, Magnus ; Topel, > Bjorn ; Wu, Jingjing ; Li, > Xiaoyun ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v3 0/6] PMD dri

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

2018-08-28 Thread Sean Harte
On Mon, 27 Aug 2018 at 10:15, Burakov, Anatoly wrote: > > On 24-Aug-18 4:51 PM, Sean Harte wrote: > > On Fri, 24 Aug 2018 at 16:19, Burakov, Anatoly > > wrote: > >> > >> On 24-Aug-18 11:41 AM, Burakov, Anatoly wrote: > >>> On 24-Aug-18 10:35 AM, Tiwei Bie wrote: > On Fri, Aug 24, 2018 at 09:

[dpdk-dev] IXGBE throughput loss with 4+ cores

2018-08-28 Thread Saber Rezvani
Hi, I have run multi_process/symmetric_mp example in DPDK example directory. For a one process its throughput is line rate but as I increase the number of cores I see decrease in throughput. For example, If the number of queues set to 4 and each queue assigns to a single core, then the throughpu

[dpdk-dev] [PATCH 3/3] crypto/dpaa2_sec: support pdcp offload

2018-08-28 Thread akhil . goyal
From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 294 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 172 2 files changed, 466 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2

[dpdk-dev] [PATCH 2/3] crypto/dpaa2_sec: add sample pdcp descriptor apis

2018-08-28 Thread akhil . goyal
From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Horia Geanta Neag Signed-off-by: Alex Porosanu Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/hw/desc.h |2 +- drivers/crypto/dpaa2_sec/hw/desc/pdcp.h | 2642 +++ 2 files changed, 2643 insert

[dpdk-dev] [PATCH 0/3] security: support for pdcp

2018-08-28 Thread akhil . goyal
From: Akhil Goyal Security library currently only has support for IPSec protocol. This patchset defines structures for pdcp protocol in rte_security and provide a sample driver implementation for lookaside protocol offload to support PDCP. Akhil Goyal (3): security: support pdcp protocol cry

[dpdk-dev] [PATCH 1/3] security: support pdcp protocol

2018-08-28 Thread akhil . goyal
From: Akhil Goyal Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- doc/guides/prog_guide/rte_security.rst | 90 -- lib/librte_security/rte_security.c | 4 ++ lib/librte_security/rte_security.h | 62 ++ 3 files changed, 149 insertions

Re: [dpdk-dev] [RFC] net/virtio-user: avoid parsing process mappings

2018-08-28 Thread Burakov, Anatoly
On 28-Aug-18 9:42 AM, Tiwei Bie wrote: On Tue, Aug 28, 2018 at 09:12:38AM +0100, Burakov, Anatoly wrote: On 28-Aug-18 8:53 AM, Tiwei Bie wrote: [...] - for (i = 0; i < num; ++i) { - mr = &msg->payload.memory.regions[i]; - mr->guest_phys_addr = huges[i].addr; /*

[dpdk-dev] [dpdk-announce] DPDK Summit North America

2018-08-28 Thread O'Driscoll, Tim
This year's DPDK Summit North America has been confirmed for December 3rd and 4th in Club Auto Sport in San Jose (the same venue as last year). Like last year it will be immediately followed by this year's OVS Conference (http://www.openvswitch.org/support/ovscon2018/), which is on December 5th

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

2018-08-28 Thread Christian Ehrhardt
On Tue, Aug 28, 2018 at 1:44 PM Adrien Mazarguil wrote: > On Tue, Aug 28, 2018 at 01:30:12PM +0200, Christian Ehrhardt wrote: > > On Mon, Aug 27, 2018 at 2:22 PM Adrien Mazarguil < > adrien.mazarg...@6wind.com> > > wrote: > > > > > Hi Christian, > > > > > > On Wed, Aug 22, 2018 at 05:11:41PM +020

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

2018-08-28 Thread Gaëtan Rivet
Hi Ciara, On Thu, Aug 23, 2018 at 01:08:03PM +0100, Ciara Power wrote: > This patch adds the infrastructure and initial code for the > telemetry library. > > A virtual device is used for telemetry, which is included in > this patch. To use telemetry, a command-line argument must be > used - "--vd

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

2018-08-28 Thread Adrien Mazarguil
On Tue, Aug 28, 2018 at 01:30:12PM +0200, Christian Ehrhardt wrote: > On Mon, Aug 27, 2018 at 2:22 PM Adrien Mazarguil > wrote: > > > Hi Christian, > > > > On Wed, Aug 22, 2018 at 05:11:41PM +0200, Christian Ehrhardt wrote: > > > Just FYI the simple change hits similar issues later on. > > > > >

Re: [dpdk-dev] 18.08 build error on ppc64el - bool as vector type

2018-08-28 Thread Christian Ehrhardt
On Mon, Aug 27, 2018 at 2:22 PM Adrien Mazarguil wrote: > Hi Christian, > > On Wed, Aug 22, 2018 at 05:11:41PM +0200, Christian Ehrhardt wrote: > > Just FYI the simple change hits similar issues later on. > > > > The (not really) proposed patch would have to be extended to be as > > following. >

Re: [dpdk-dev] [RFC] ethdev: add action to swap source and destination MAC to flow API

2018-08-28 Thread Andrew Rybchenko
On 08/27/2018 03:54 PM, Rahul Lakkireddy wrote: From: Shagun Agrawal This action is useful for offloading loopback mode, where the hardware will swap source and destination MAC address before looping back the packet. This action can be used in conjunction with other rewrite actions to achieve M

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Kokkilagadda, Kiran
I need to add the same write barrier change in kernel side kni_fifo_put. I will add it and will send v3. From: Kokkilagadda, Kiran Sent: Tuesday, August 28, 2018 4:13:59 PM To: Gavin Hu; Ferruh Yigit; Jacob, Jerin Cc: dev@dpdk.org; Honnappa Nagarahalli Subject: R

Re: [dpdk-dev] [PATCH v2] kni: fix kni Rx fifo producer synchronization

2018-08-28 Thread Kokkilagadda, Kiran
In this instance there won't be any problem, as until the value of fifo->write changes, this loop won't get executed. As of now we didn't see any issue with it and for performance reasons, we don't want to keep read barrier. From: Gavin Hu Sent: Monday, August

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-28 Thread Andrew Rybchenko
On 08/07/2018 05:20 PM, Jack Min wrote: There is a need to offload rewrite MAC address for both destination and source from the matched flow The proposed actions could make above easily achieved Signed-off-by: Xiaoyu Min mailto:jack...@mellanox.com>> The only question I have is which Etherne

Re: [dpdk-dev] [PATCH v5 2/2] virtio: fix PCI config err handling

2018-08-28 Thread Luca Boccassi
On Tue, 2018-08-28 at 14:43 +0800, Tiwei Bie wrote: > I just noticed the title. It should be "net/virtio: xxx", > instead of "virtio: xxx". Fixed > On Mon, Aug 27, 2018 at 05:52:40PM +0100, Luca Boccassi wrote: > [...] > > + ret = rte_pci_read_config(dev, &flags, > > sizeof(flag

[dpdk-dev] [PATCH v6 2/2] net/virtio: fix PCI config err handling

2018-08-28 Thread Luca Boccassi
From: Brian Russell In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config returns the number of bytes read from PCI config or < 0 on error. If less than the expected number of bytes are read then log the failure and return rather than carrying on with garbage. Fixes: 6ba1f63b5ab0 ("virt

[dpdk-dev] [PATCH v6 1/2] bus/pci: harmonize and document rte_pci_read_config return value

2018-08-28 Thread Luca Boccassi
On Linux, rte_pci_read_config on success returns the number of read bytes, but on BSD it returns 0. Document the return values, and have BSD behave as Linux does. At least one case (bnx2x PMD) treats 0 as an error, so the change makes sense also for that. Signed-off-by: Luca Boccassi --- driver

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-28 Thread Matan Azrad
From: Chas Williams >On Mon, Aug 27, 2018 at 11:30 AM Matan Azrad wrote: >>>Because rings are generally quite efficient. >> >>But you are using a ring in addition to regular array management, it must >>hurt performance of the bonding PMD >>(means the bonding itself -

Re: [dpdk-dev] [RFC] net/virtio-user: avoid parsing process mappings

2018-08-28 Thread Tiwei Bie
On Tue, Aug 28, 2018 at 09:12:38AM +0100, Burakov, Anatoly wrote: > On 28-Aug-18 8:53 AM, Tiwei Bie wrote: [...] > > > > - for (i = 0; i < num; ++i) { > > - mr = &msg->payload.memory.regions[i]; > > - mr->guest_phys_addr = huges[i].addr; /* use vaddr! */ > > - mr-

[dpdk-dev] [RFC v2 0/1] A Distributed Software Event Device

2018-08-28 Thread Mattias Rönnblom
v2: * Added support for Meson builds. * Eventdev 'xstats' support is now mandatory. * Added check in dsw_probe() to allow secondary processes. * rte_event_dev_stop() now runs the flush callback. * Added documentation. * Fixed uninitialized-use warning in ‘dsw_port_consider_migration'. * Removed som

[dpdk-dev] [RFC v2 1/1] eventdev: add distributed software (DSW) event device

2018-08-28 Thread Mattias Rönnblom
The distributed software eventdev is a parallel implementation of the eventdev API, which distributes the task of scheduling events among all the eventdev ports and the lcore threads using them. Signed-off-by: Mattias Rönnblom --- config/common_base|5 + doc/guide

[dpdk-dev] [PATCH] pipeline: add symmetric crypto to table action

2018-08-28 Thread Zhang, Roy Fan
This patch adds the symmetric crypto action support to pipeline library. The symmetric crypto action works as the shim layer between pipeline and DPDK cryptodev and is able to interact with cryptodev with the control path requests such as session creation/deletion and data path work to assemble the

Re: [dpdk-dev] [RFC 0/9] Modularize and enhance DPDK Python scripts

2018-08-28 Thread Burakov, Anatoly
On 14-Aug-18 11:11 AM, Burakov, Anatoly wrote: On 25-Jun-18 4:59 PM, Anatoly Burakov wrote: This patchset attempts to create a library out of Python scripts that come with DPDK, with a goal of enabling external tools to get the same information about the system DPDK has, and perhaps configure DP

Re: [dpdk-dev] [RFC] net/virtio-user: avoid parsing process mappings

2018-08-28 Thread Burakov, Anatoly
On 28-Aug-18 8:53 AM, Tiwei Bie wrote: Recently some memory APIs were introduced to allow users to get the file descriptors for each memory segments. We can leverage those APIs to get rid of the /proc magic on memory table preparation in vhost-user backend. Signed-off-by: Tiwei Bie --- This pat

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-28 Thread Michel Machado
On 08/26/2018 11:12 PM, Honnappa Nagarahalli wrote: On 08/23/2018 08:33 PM, Wang, Yipeng1 wrote: I think with Honnappa suggested "uint32_t* next", we may need a little bit tricks to make it work with the extra linked list. The performance may not be optimal though comparing to your original appr

[dpdk-dev] [RFC] net/virtio-user: avoid parsing process mappings

2018-08-28 Thread Tiwei Bie
Recently some memory APIs were introduced to allow users to get the file descriptors for each memory segments. We can leverage those APIs to get rid of the /proc magic on memory table preparation in vhost-user backend. Signed-off-by: Tiwei Bie --- This patch depends on below patch set: https://pa

Re: [dpdk-dev] [PATCH v2] net/virtio-user: check negotiated features before set

2018-08-28 Thread Tiwei Bie
On Mon, Aug 27, 2018 at 02:37:24PM -0400, eric zhang wrote: > This patch checks negotiated features to see if necessary to offload > before set the tap device offload capabilities. It also checks if kernel > support the TUNSETOFFLOAD operation. > > Signed-off-by: eric zhang > > --- > v2: > * don