> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, August 24, 2018 12:22 AM > To: Power, Ciara <ciara.po...@intel.com> > Cc: Van Haaren, Harry <harry.van.haa...@intel.com>; Archbold, Brian > <brian.archb...@intel.com>; Kenny, Emma <emma.ke...@intel.com>; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry > infrastructure > > On Thu, 23 Aug 2018 13:08:03 +0100 > Ciara Power <ciara.po...@intel.com> wrote: > > > +/* Logging Macros */ > > +extern int telemetry_log_level; > > + > > +#define TELEMETRY_LOG(level, fmt, args...) \ > > + rte_log(RTE_LOG_ ##level, telemetry_log_level, "%s(): "fmt "\n", \ > > + __func__, ##args) > > + > > +#define TELEMETRY_LOG_ERR(fmt, args...) \ > > + TELEMETRY_LOG(ERR, fmt, ## args) > > + > > +#define TELEMETRY_LOG_WARN(fmt, args...) \ > > + TELEMETRY_LOG(WARNING, fmt, ## args) > > + > > +#define TELEMETRY_LOG_INFO(fmt, args...) \ > > + TELEMETRY_LOG(INFO, fmt, ## args) > > + > > +typedef struct telemetry_impl { > > + pthread_t thread_id; > > + int thread_status; > > + uint32_t socket_id; > > +} telemetry_impl; > > + > > Your logging macros follow the standard DPDK style. Including automatically > adding a new line. But as I look at the code, many of the TELEMETRY_LOG > calls > have a newline in the format. Therefore your log messages will be double > spaced.
Correct, will get that fixed. Thanks for reviewing! Looking forward to Userspace, curious to hear of your use-cases for Telemetry lib, assuming you have some in mind.
