Re: [dpdk-dev] [PATCH v3 0/6] PMD driver for AF_XDP

Sorry, the patch for kernel sample code is not complete. It should be as below ~~~PATCH START diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index d69c8d78d3fd..44a6318043e7 100644 --- a/samples/bpf/xdpsock_user.c +++ b/sa

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add function to release port in secondary process

> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Monday, August 20, 2018 4:53 PM > To: Zhang, Qi Z ; tho...@monjalon.net; > gaetan.ri...@6wind.com; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; S

[dpdk-dev] 17.11.4 patches review and test (RC2)

Hi all, Here is a list of patches targeted for LTS release 17.11.4. Please help review and test. The planned date for the final release is Aug 30. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests, ple

[dpdk-dev] [PATCH v3 4/6] net/mvpp2: fix comments and error messages

From: Natalie Samsonov Fix comments and error messages. Fixes: 7235341d7517 ("net/mrvl: support classifier") Cc: t...@semihalf.com Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_flow.c | 29 + 1 file changed, 21 insertions(+), 8

[dpdk-dev] [PATCH v3 2/6] net/mvpp2: use common code to initialize DMA

From: Liron Himi Use common code to initialize MUSDK DMA memory buffers. Signed-off-by: Liron Himi Reviewed-by: Natalie Samsonov --- drivers/net/mvpp2/Makefile | 3 ++- drivers/net/mvpp2/meson.build | 2 +- drivers/net/mvpp2/mrvl_ethdev.c | 32 +++- 3 file

[dpdk-dev] [PATCH v3 6/6] net/mvpp2: add VLAN packet type support for parser offload

From: Natalie Samsonov Add VLAN packet type support for parser offload. Signed-off-by: Natalie Samsonov Reviewed-by: Shlomi Gridish Reviewed-by: Dmitri Epshtein Reviewed-by: Yuval Caduri --- drivers/net/mvpp2/mrvl_ethdev.c | 16 1 file changed, 16 insertions(+) diff --git

[dpdk-dev] [PATCH v3 5/6] net/mvpp2: make private variables static

From: Natalie Samsonov Mark internal variables static to avoid potential redefinition errors later on. Signed-off-by: Natalie Samsonov Reviewed-by: Yelena Krivosheev --- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2

[dpdk-dev] [PATCH v3 3/6] net/mvpp2: fix array initialization

Fix used_bpools array initialization by using range initializer. This way all necessary variables are properly initialized regardless of PP2_NUM_PKT_PROC value. Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszynski --- drivers/net/mvpp2/mrvl_

[dpdk-dev] [PATCH v3 1/6] drivers/common: add mvep common code for MRVL PMDs

From: Liron Himi Add MVEP (Marvell Embedded Processors) to drivers/common which will keep code reused by current and future MRVL PMDs. Right now we have only common DMA memory initialization routines there. Signed-off-by: Liron Himi Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov

[dpdk-dev] [PATCH v3 0/6] net/mvpp2: changes and features

This patch series introduces following changes: * Common code responsible for DMA memory initialization is now available under drivers/common/mvep. MVEP stands for Marvell Embedded Processors. This eases maintenance and avoids boilerplate code across Marvell PMDs. MVEP will grow over time as

Re: [dpdk-dev] [PATCH] bus/fslmc: fix shared build

On Wed, Aug 22, 2018 at 10:31 PM Shreyansh Jain wrote: > On Tuesday 21 August 2018 04:55 PM, Pablo de Lara wrote: > > When building DPDK as shared library, disabling optimizations, > > the following compilation issue appears: > > > > portal/dpaa2_hw_dpio.o: In function `dpaa2_mem_ptov': > > drive

Re: [dpdk-dev] [PATCH v2 3/6] net/mvpp2: fix array initialization

On Fri, Aug 24, 2018 at 05:46:42PM +0100, Ferruh Yigit wrote: > On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > > Fix used_bpools array initialization by using range initializer. > > This way all necessary variables are properly initialized regardless > > of PP2_NUM_PKT_PROC value. > > > > Fixes: 0

Re: [dpdk-dev] [PATCH v2 1/6] drivers/common: add mvep common code for MRVL PMDs

On Fri, Aug 24, 2018 at 05:45:48PM +0100, Ferruh Yigit wrote: > On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > > From: Liron Himi > > > > Add MVEP (Marvell Embedded Processors) to drivers/common which > > will keep code reused by current and future MRVL PMDs. > > Right now we have only common DMA

Re: [dpdk-dev] [PATCH v2 2/6] net/mvpp2: use common code to initialize DMA

On Fri, Aug 24, 2018 at 05:46:21PM +0100, Ferruh Yigit wrote: > On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > > From: Liron Himi > > > > Use common code to initialize MUSDK DMA memory buffers. > > > > Signed-off-by: Liron Himi > > Reviewed-by: Natalie Samsonov > > <...> > > > @@ -2653,24 +2651

[dpdk-dev] [RFC] cryptodev: proposed changes in rte_cryptodev_sym_session

This RFC for proposes several changes inside rte_cryptodev_sym_session. Note that this is just RFC not a complete patch, so for now I modified only the librte_cryptodev itself, some cryptodev PMD, test-crypto-perf and ipsec-secgw example. Proposed changes means ABI/API breakage inside cryptodev, so

[dpdk-dev] [PATCH v4 1/2] bus/pci: harmonize and document rte_pci_read_config return value

On Linux, rte_pci_read_config on success returns the number of read bytes, but on BSD it returns 0. Document the return values, and have BSD behave as Linux does. At least one case (bnx2x PMD) treats 0 as an error, so the change makes sense also for that. Signed-off-by: Luca Boccassi --- driver

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

On Fri, 2018-08-24 at 12:23 +0800, Tiwei Bie wrote: > On Thu, Aug 23, 2018 at 01:52:25PM +0100, Luca Boccassi wrote: > > On Tue, 2018-08-21 at 10:40 +0800, Tiwei Bie wrote: > > > On Mon, Aug 20, 2018 at 05:45:35PM +0100, Luca Boccassi wrote: > > > > On Mon, 2018-08-20 at 16:18 +0800, Tiwei Bie wrot

[dpdk-dev] [PATCH v4 2/2] virtio: fix PCI config err handling

From: Brian Russell In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config returns the number of bytes read from PCI config or < 0 on error. If less than the expected number of bytes are read then log the failure and return rather than carrying on with garbage. Fixes: 6ba1f63b5ab0 ("virt

[dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

This RFC introduces a new library within DPDK: librte_ipsec. The aim is to provide DPDK native high performance library for IPsec data-path processing. The library is supposed to utilize existing DPDK crypto-dev and security API to provide application with transparent IPsec processing API. The libr

Re: [dpdk-dev] Multi-thread mempool usage

> On Aug 24, 2018, at 9:44 AM, Matteo Lanzuisi wrote: > > Hi, > > I used valgrind again for a very long time, and it told me nothing strange is > happening on my code. > After it, I changed my code this way > > unsignedlcore_id_start = rte_lcore_id(); > RTE_LCORE_FOREACH(lcore_

[dpdk-dev] [PATCH] acl: fix invalid results for rule with zero priority

If user specifies priority=0 for some of ACL rules that can cause rte_acl_classify to return wrong results. The reason is that priority zero is used internally for no-match nodes. See more details at: https://bugs.dpdk.org/show_bug.cgi?id=79. The simplest way to overcome the issue is just not allow

Re: [dpdk-dev] [PATCH v2 3/6] net/mvpp2: fix array initialization

On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > Fix used_bpools array initialization by using range initializer. > This way all necessary variables are properly initialized regardless > of PP2_NUM_PKT_PROC value. > > Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v2 2/6] net/mvpp2: use common code to initialize DMA

On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > From: Liron Himi > > Use common code to initialize MUSDK DMA memory buffers. > > Signed-off-by: Liron Himi > Reviewed-by: Natalie Samsonov <...> > @@ -2653,24 +2651,17 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev) > if (mrvl_dev_num

Re: [dpdk-dev] [PATCH v2 1/6] drivers/common: add mvep common code for MRVL PMDs

On 8/24/2018 3:54 PM, Tomasz Duszynski wrote: > From: Liron Himi > > Add MVEP (Marvell Embedded Processors) to drivers/common which > will keep code reused by current and future MRVL PMDs. > Right now we have only common DMA memory initialization routines there. > > Signed-off-by: Liron Himi >

[dpdk-dev] [PATCH] net/ixgbe: Strip SR-IOV transparent VLANs in VF

From: Robert Shearman SR-IOV VFs support "transparent" VLANs. Traffic from/to a VM associated with a VF has a VLAN tag inserted/stripped in a manner intended to be totally transparent to the VM. On a Linux hypervisor the vlan can be specified by "ip link set vf vlan ". The VM VF driver is not

Re: [dpdk-dev] [PATCH v5 2/4] net/ixgbe: install ethdev hotplug handler in ixgbe

On 7/11/2018 12:51 PM, Jeff Guo wrote: > This patch aim to enable hotplug detect in ixgbe PMD. Firstly it > set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug > ability, and then use rte_eth_dev_event_handler_install to install > the hotplug event handler for ethdev. When eal d

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On Fri, 24 Aug 2018 at 16:19, Burakov, Anatoly wrote: > > On 24-Aug-18 11:41 AM, Burakov, Anatoly wrote: > > On 24-Aug-18 10:35 AM, Tiwei Bie wrote: > >> On Fri, Aug 24, 2018 at 09:59:42AM +0100, Burakov, Anatoly wrote: > >>> On 24-Aug-18 5:49 AM, Tiwei Bie wrote: > On Thu, Aug 23, 2018 at 03

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On 24-Aug-18 11:41 AM, Burakov, Anatoly wrote: On 24-Aug-18 10:35 AM, Tiwei Bie wrote: On Fri, Aug 24, 2018 at 09:59:42AM +0100, Burakov, Anatoly wrote: On 24-Aug-18 5:49 AM, Tiwei Bie wrote: On Thu, Aug 23, 2018 at 03:01:30PM +0100, Burakov, Anatoly wrote: On 23-Aug-18 12:19 PM, Sean Harte w

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: support all truncated digest sizes

> The full digest size of GCM/GMAC algorithms is 16 bytes. > However, it is sometimes truncated to a smaller size (such as in IPSec). > This commit allows a user to generate a digest of any size up to the full > size. > > Signed-off-by: Pablo de Lara > --- > drivers/crypto/aesni_gcm/aesni_gcm_p

Re: [dpdk-dev] 17.11.4 patches review and test

On Aug 24, 2018, at 8:00 AM, Alejandro Lucero mailto:alejandro.luc...@netronome.com>> wrote: On Fri, Aug 24, 2018 at 4:31 PM, Yongseok Koh mailto:ys...@mellanox.com>> wrote: > On Aug 24, 2018, at 1:51 AM, Alejandro Lucero > mailto:alejandro.luc...@netronome.com>> wrote: > > > > On Thu, Aug

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: fix MAC changes when live change not supported

On 8/24/2018 3:25 PM, Alejandro Lucero wrote: > Current code assumes a MAC change can occur when the port has been > started. In fact, there are some NICs which require this port state > for being successful, but other NICs not always support MAC change > in that case. > > This patch supports a ne

Re: [dpdk-dev] 17.11.4 patches review and test

On Fri, Aug 24, 2018 at 4:31 PM, Yongseok Koh wrote: > > > On Aug 24, 2018, at 1:51 AM, Alejandro Lucero < > alejandro.luc...@netronome.com> wrote: > > > > > > > > On Thu, Aug 23, 2018 at 6:18 PM, Yongseok Koh > wrote: > > > > > On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: > > > > > > On Tu

[dpdk-dev] [PATCH v2 5/6] net/mvpp2: make private variables static

From: Natalie Samsonov Mark internal variables static to avoid potential redefinition errors later on. Signed-off-by: Natalie Samsonov Reviewed-by: Yelena Krivosheev --- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2

[dpdk-dev] [PATCH v2 6/6] net/mvpp2: add VLAN packet type support for parser offload

From: Natalie Samsonov Add VLAN packet type support for parser offload. Signed-off-by: Natalie Samsonov Reviewed-by: Shlomi Gridish Reviewed-by: Dmitri Epshtein Reviewed-by: Yuval Caduri --- drivers/net/mvpp2/mrvl_ethdev.c | 16 1 file changed, 16 insertions(+) diff --git

[dpdk-dev] [PATCH v2 3/6] net/mvpp2: fix array initialization

Fix used_bpools array initialization by using range initializer. This way all necessary variables are properly initialized regardless of PP2_NUM_PKT_PROC value. Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszynski --- drivers/net/mvpp2/mrvl_

[dpdk-dev] [PATCH v2 1/6] drivers/common: add mvep common code for MRVL PMDs

From: Liron Himi Add MVEP (Marvell Embedded Processors) to drivers/common which will keep code reused by current and future MRVL PMDs. Right now we have only common DMA memory initialization routines there. Signed-off-by: Liron Himi Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov

[dpdk-dev] [PATCH v2 2/6] net/mvpp2: use common code to initialize DMA

From: Liron Himi Use common code to initialize MUSDK DMA memory buffers. Signed-off-by: Liron Himi Reviewed-by: Natalie Samsonov --- drivers/net/mvpp2/Makefile | 3 ++- drivers/net/mvpp2/meson.build | 2 +- drivers/net/mvpp2/mrvl_ethdev.c | 36 +--- 3

[dpdk-dev] [PATCH v2 4/6] net/mvpp2: fix comments and error messages

From: Natalie Samsonov Fix comments and error messages. Fixes: 7235341d7517 ("net/mrvl: support classifier") Cc: t...@semihalf.com Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_flow.c | 29 + 1 file changed, 21 insertions(+), 8

[dpdk-dev] [PATCH 0/6] net/mvpp2 changes and features

This patch series introduces following changes: * Common code responsible for DMA memory initialization is now available under drivers/common/mvep. MVEP stands for Marvell Embedded Processors. This eases maintenance and avoids boilerplate code across Marvell PMDs. MVEP will grow over time as

Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live changes allowed

On Fri, 24 Aug 2018 15:25:34 +0100 Alejandro Lucero wrote: > The original patch assumes all NICs can safely change or set the MAC > in any case. However, this is not always true. NFP depends on the firmware > capabilities and this is not always supported. There are other NICs with > this same lim

Re: [dpdk-dev] Multi-thread mempool usage

Hi, I used valgrind again for a very long time, and it told me nothing strange is happening on my code. After it, I changed my code this way  unsigned    lcore_id_start = rte_lcore_id(); RTE_LCORE_FOREACH(lcore_id) {     if (lcore_id_start != lcore_id) // <- before this ch

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

On Fri, 24 Aug 2018 14:55:56 +0100 Ferruh Yigit wrote: > On 8/14/2018 8:46 PM, Matan Azrad wrote: > > Hi Stephen > > > > From: Stephen Hemminger > >> On Tue, 14 Aug 2018 05:52:20 + > >> Matan Azrad wrote: > >> > >>> Hi Stephen > >>> > >>> From: Stephen Hemminger > The rte_eth_dev

Re: [dpdk-dev] 17.11.4 patches review and test

> On Aug 24, 2018, at 1:51 AM, Alejandro Lucero > wrote: > > > > On Thu, Aug 23, 2018 at 6:18 PM, Yongseok Koh wrote: > > > On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: > > > > On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: > >> Hi Yonngseok, > >> > >> There is a

[dpdk-dev] [PATCH v3 2/2] net/nfp: fix live MAC changes not supported

Some NFP firmwares support live changes to the MAC address, but this is not always true and the firmware advertises it accordingly. This patch checks if firmware does not support live changes and sets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case. Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero

[dpdk-dev] [PATCH v3 1/2] ethdev: fix MAC changes when live change not supported

Current code assumes a MAC change can occur when the port has been started. In fact, there are some NICs which require this port state for being successful, but other NICs not always support MAC change in that case. This patch supports a new device flag for a device advertising this limitation, an

[dpdk-dev] [PATCH v3 0/2] support MAC changes when no live changes allowed

This is a patched to fix a functionality coming with the first public release: changing/setting MAC address. The original patch assumes all NICs can safely change or set the MAC in any case. However, this is not always true. NFP depends on the firmware capabilities and this is not always supported

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On Fri, Aug 24, 2018 at 6:39 AM Ferruh Yigit wrote: > On 8/23/2018 4:21 PM, Chas Williams wrote: > > > > > > On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit > > wrote: > > > > On 8/6/2018 4:50 PM, Chas Williams wrote: > > > On Sun, Aug 5, 2018 at 5:55 PM Thoma

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

On 8/14/2018 8:46 PM, Matan Azrad wrote: > Hi Stephen > > From: Stephen Hemminger >> On Tue, 14 Aug 2018 05:52:20 + >> Matan Azrad wrote: >> >>> Hi Stephen >>> >>> From: Stephen Hemminger The rte_eth_dev_owner_unset function is unusable because it always returns -EINVAL. This is bec

[dpdk-dev] [PATCH 6/6] crypto/mvsam: add 3DES ECB to the capabilities list

3DES in ECB mode is supported by the PMD thus specific entry should exist in the crypto PMD capabilities list. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 1 file changed, 20 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB

Add support for AES128/192/256 in ECB mode. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 5 + drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 2 files changed, 25 insertions(+) diff --git a/drivers/crypto/mvs

[dpdk-dev] [PATCH 5/6] crypto/mvsam: add support for crypto/auth NULL algorithms

Add support for both cipher and auth NULL algorithms. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 6 + drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 45 + 2 files changed, 51 insertions(+) diff --g

[dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

Add support for the HMAC SHA224 authentication algorithm. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 3 +++ drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 21 + 2 files changed, 24 insertions(+) diff --git a/drive

[dpdk-dev] [PATCH 1/6] crypto/mvsam: fix shared library build

Add missing rte_kvargs library dependency. Without that shared library build fails due to unresolved rte_kvargs_* symbols. Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions") Cc: pablo.de.lara.gua...@intel.com Signed-off-by: Tomasz Duszynski --- drivers/crypto/mvsam/Makefile

[dpdk-dev] [PATCH 0/6] crypto/mvsam: add new features and fixes

This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. Szymon Sliwa (1): crypto/mvsam: update hash digest sizes Tomasz Duszynski (5): crypto/mvsam: fix shared

[dpdk-dev] [PATCH 2/6] crypto/mvsam: update hash digest sizes

From: Szymon Sliwa Update hash digest sizes to match hardware capabilities. Signed-off-by: Szymon Sliwa Reviewed-by: Yelena Krivosheev Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 - 1 file changed, 23 insertions(+), 23 deleti

[dpdk-dev] [PATCH] ethdev: deprecate DEFERRED device state

Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this is mostly a reminder because of a missing target. It doesn't worth to break the ABI because of this change and removal can be done when ethdev ABI version increased. Signed-off-by: Ferruh Yigit --- Cc: Thomas Monjalon Cc: An

Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure

On Thursday 23 August 2018 05:38 PM, Ciara Power wrote: This patch adds the infrastructure and initial code for the telemetry library. A virtual device is used for telemetry, which is included in this patch. To use telemetry, a command-line argument must be used - "--vdev=telemetry". Control th

[dpdk-dev] [PATCH v4] test: add unit tests for metrics library

Unit testcases are added for metrics library Added metrics unit test to autotest list Updated meson build file Updated MAINTAINERSHIP for metrics unit test Signed-off-by: Hari Kumar Vemula Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton Acked-by: Remy Horton --- v4: Updated changes require

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded J0 calculation

> When IV size is 12, padding to 16 bytes is required and the LSB must be set to > 1, according to the spec. > However, the Multi-buffer library is already doing this, so it is not > necessary > to do it in the PMD. > > Signed-off-by: Pablo de Lara > --- > drivers/crypto/aesni_gcm/aesni_gcm_pmd

[dpdk-dev] [PATCH v13 3/4] test: add unit tests for latencystats library

Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- MAINTAINERS | 1 + test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/meson.build | 3 + test/test/test_latenc

[dpdk-dev] [PATCH v13 1/4] test: add helper functions for tests using ring-PMD Rx/Tx

Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- MAINTAINERS | 5 ++ test/test/Makefile| 1 + test/tes

[dpdk-dev] [PATCH v13 4/4] test: add unit test for pdump library

Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Client

[dpdk-dev] [PATCH v13 2/4] test: add unit tests for bitrate library

Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- MAINTAINERS | 1 + test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/meson.build | 4 + test/t

[dpdk-dev] [PATCH v13 0/4] add unit tests for bitrate, latency and pdump libraries

From: Naga Suresh Somarowthu 1/4: add helper functions for tests using ring-PMD Rx/Tx 2/4: unit test cases added for bitrate library 3/4: unit test cases added for latencystats library 4/4: unit test cases added for pdump library Patches 2/4, 3/4 and 4/4 depends on 1/4 Signed-off-by: Naga Sure

Re: [dpdk-dev] [PATCH 1/6] drivers/common: add mvep common code for MRVL PMDs

On Fri, Aug 24, 2018 at 01:32:47PM +0100, Ferruh Yigit wrote: > On 8/24/2018 1:16 PM, Tomasz Duszynski wrote: > > From: Liron Himi > > > > Add MVEP (Marvell Embedded Processors) to drivers/common which > > will keep code reused by current and future MRVL PMDs. > > Right now we have only common DMA

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: fix MAC changes when live change not supported

On Fri, Aug 24, 2018 at 2:27 PM, Ferruh Yigit wrote: > On 8/24/2018 12:15 PM, Alejandro Lucero wrote: > > Current code assumes a MAC change can occur when the port has been > > started. In fact, there are some NICs which require this port state > > for being successful, but other NICs not always

Re: [dpdk-dev] [PATCH 1/6] drivers/common: add mvep common code for MRVL PMDs

On 8/24/2018 1:16 PM, Tomasz Duszynski wrote: > From: Liron Himi > > Add MVEP (Marvell Embedded Processors) to drivers/common which > will keep code reused by current and future MRVL PMDs. > Right now we have only common DMA memory initialization routines there. > > Signed-off-by: Liron Himi >

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: fix MAC changes when live change not supported

On 8/24/2018 12:15 PM, Alejandro Lucero wrote: > Current code assumes a MAC change can occur when the port has been > started. In fact, there are some NICs which require this port state > for being successful, but other NICs not always support MAC change > in that case. > > This patch supports a n

Re: [dpdk-dev] [PATCH v2 3/3] doc: comment rte_eth_dev_start change

On 8/24/2018 12:15 PM, Alejandro Lucero wrote: > The new device flag RTE_ETH_DEV_NOLIVE_MAC_ADDR modifies how MAC is set > when calling rte_eth_dev_start. > > Signed-off-by: Alejandro Lucero > --- > doc/guides/rel_notes/release_18_11.rst | 6 +- I think it is better to merge this with implem

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: fix MAC changes when live change not supported

On 8/24/2018 12:15 PM, Alejandro Lucero wrote: > Current code assumes a MAC change can occur when the port has been > started. In fact, there are some NICs which require this port state > for being successful, but other NICs not always support MAC change > in that case. > > This patch supports a n

[dpdk-dev] [PATCH 4/6] net/mvpp2: fix comments and error messages

From: Natalie Samsonov Fix comments and error messages. Fixes: 7235341d7517 ("net/mrvl: support classifier") Cc: t...@semihalf.com Signed-off-by: Natalie Samsonov Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_flow.c | 29 + 1 file changed, 21 insertions(+), 8

[dpdk-dev] [PATCH 6/6] net/mvpp2: add VLAN packet type support for parser offload

From: Natalie Samsonov Add VLAN packet type support for parser offload. Signed-off-by: Natalie Samsonov Reviewed-by: Shlomi Gridish Reviewed-by: Dmitri Epshtein Reviewed-by: Yuval Caduri --- drivers/net/mvpp2/mrvl_ethdev.c | 16 1 file changed, 16 insertions(+) diff --git

[dpdk-dev] [PATCH 3/6] net/mvpp2: fix array initialization

Fix used_bpools array initialization by using range initializer. This way all necessary variables are properly initialized regardless of PP2_NUM_PKT_PROC value. Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszynski --- drivers/net/mvpp2/mrvl_

[dpdk-dev] [PATCH 5/6] net/mvpp2: make private variables static

From: Natalie Samsonov Mark internal variables static to avoid potential redefinition errors later on. Signed-off-by: Natalie Samsonov Reviewed-by: Yelena Krivosheev --- drivers/net/mvpp2/mrvl_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2

[dpdk-dev] [PATCH 1/6] drivers/common: add mvep common code for MRVL PMDs

From: Liron Himi Add MVEP (Marvell Embedded Processors) to drivers/common which will keep code reused by current and future MRVL PMDs. Right now we have only common DMA memory initialization routines there. Signed-off-by: Liron Himi Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov

[dpdk-dev] [PATCH 2/6] net/mvpp2: use common code to initialize DMA

From: Liron Himi Use common code to initialize MUSDK DMA memory buffers. Signed-off-by: Liron Himi Reviewed-by: Natalie Samsonov --- drivers/net/Makefile| 3 +++ drivers/net/mvpp2/Makefile | 3 ++- drivers/net/mvpp2/meson.build | 2 +- drivers/net/mvpp2/mrvl_ethdev.c | 3

[dpdk-dev] [PATCH 0/6] mvpp2 changes and features

This patch series introduces following changes: * Common code responsible for DMA memory initialization is now available under drivers/common/mvep. MVEP stands for Marvell Embedded Processors. This eases maintenance and avoids boilerplate code across Marvell PMDs. MVEP will grow over time as

Re: [dpdk-dev] [PATCH v2 2/2] librte_ip_frag: add mbuf counter

Hi Alex, > > Hi Konstantin. > > Could we please make a final decision about counting mbufs, since It still > feels to me like an unfinished business? > Below are my final argumens. if they are not sound to you, just nack ;) Sorry, but as I said before - not sure that it really worth it. Still

Re: [dpdk-dev] [PATCH v2 1/2] librte_ip_frag: add function to delete expired entries

> -Original Message- > From: Alex Kiselev [mailto:a...@therouter.net] > Sent: Monday, June 4, 2018 11:13 AM > To: Ananyev, Konstantin ; dev@dpdk.org; > Burakov, Anatoly > Subject: [dpdk-dev] [PATCH v2 1/2] librte_ip_frag: add function to delete > expired entries > > A fragmented packe

[dpdk-dev] [PATCH v2 2/3] net/nfp: fix live MAC changes not supported

Some NFP firmwares support live changes to the MAC address, but this is not always true and the firmware advertises it accordingly. This patch checks if firmware does not support live changes and sets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case. Cc: sta...@dpdk.org Signed-off-by: Alejandro Lucero

[dpdk-dev] [PATCH v2 1/3] ethdev: fix MAC changes when live change not supported

Current code assumes a MAC change can occur when the port has been started. In fact, there are some NICs which require this port state for being successful, but other NICs not always support MAC change in that case. This patch supports a new device flag for a device advertising this limitation, an

[dpdk-dev] [PATCH v2 3/3] doc: comment rte_eth_dev_start change

The new device flag RTE_ETH_DEV_NOLIVE_MAC_ADDR modifies how MAC is set when calling rte_eth_dev_start. Signed-off-by: Alejandro Lucero --- doc/guides/rel_notes/release_18_11.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_18_11.rst b/do

[dpdk-dev] support MAC changes when no live changes allowed

This is a patched to fix a functionality coming with the first public release: changing/setting MAC address. The original patch assumes all NICs can safely change or set the MAC in any case. However, this is not always true. NFP depends on the firmware capabilities and this is not always supported

Re: [dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

> -Original Message- > From: Li Han [mailto:han@zte.com.cn] > Sent: Thursday, August 2, 2018 3:01 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Li Han > Subject: [PATCH] [dpdk-dev] lib/librte_ip_frag:fix ip_frag_key_cmp bug > > in struct ip_frag_key,src_dst[] type is uint64_t.

Re: [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter

On 8/3/2018 2:36 PM, Adrien Mazarguil wrote: > This is a follow up to the "Flow API helpers enhancements" series submitted > almost a year ago [1]. The new title is due to the reduced scope of this > version. > > rte_flow_conv() is a flexible replacement to rte_flow_copy(), itself a > temporary so

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On 24-Aug-18 10:35 AM, Tiwei Bie wrote: On Fri, Aug 24, 2018 at 09:59:42AM +0100, Burakov, Anatoly wrote: On 24-Aug-18 5:49 AM, Tiwei Bie wrote: On Thu, Aug 23, 2018 at 03:01:30PM +0100, Burakov, Anatoly wrote: On 23-Aug-18 12:19 PM, Sean Harte wrote: On Thu, 23 Aug 2018 at 10:05, Burakov, An

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On 8/23/2018 4:21 PM, Chas Williams wrote: > > > On Thu, Aug 23, 2018 at 9:15 AM Ferruh Yigit > wrote: > > On 8/6/2018 4:50 PM, Chas Williams wrote: > > On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon > wrote: > > >

Re: [dpdk-dev] [RFC 2/2] ethdev: check received mbufs sanity

On Mon, Aug 13, 2018 at 6:03 PM, David Marchand wrote: > Let's check the mbufs given by the drivers directly in the rx handler. > The only drawback is that you need CONFIG_RTE_LIBRTE_MBUF_DEBUG to be set > for this to actually do some real checks. Comments ? -- David Marchand

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Thursday, August 23, 2018 10:32 PM > To: Andrew Rybchenko > Cc: Dekel Peled ; dev@dpdk.org; or...@mellanox.com; > shah...@mellanox.com; Thomas Monjalon > ; Ananyev, Konstantin ; > Yigit, Ferruh ; Adrien > Ma

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On Fri, Aug 24, 2018 at 09:59:42AM +0100, Burakov, Anatoly wrote: > On 24-Aug-18 5:49 AM, Tiwei Bie wrote: > > On Thu, Aug 23, 2018 at 03:01:30PM +0100, Burakov, Anatoly wrote: > >> On 23-Aug-18 12:19 PM, Sean Harte wrote: > >>> On Thu, 23 Aug 2018 at 10:05, Burakov, Anatoly > >>> wrote: > >

Re: [dpdk-dev] [PATCH] net/virtio-user: fix memory hotplug support

On 24-Aug-18 5:49 AM, Tiwei Bie wrote: On Thu, Aug 23, 2018 at 03:01:30PM +0100, Burakov, Anatoly wrote: On 23-Aug-18 12:19 PM, Sean Harte wrote: On Thu, 23 Aug 2018 at 10:05, Burakov, Anatoly wrote: On 23-Aug-18 3:57 AM, Tiwei Bie wrote: Deadlock can occur when allocating memory if a vhost

Re: [dpdk-dev] [PATCH 8/8] mem: support using memfd segments for in-memory mode

On 24-Aug-18 5:39 AM, Jerin Jacob wrote: -Original Message- Date: Thu, 23 Aug 2018 17:59:55 +0100 From: Anatoly Burakov To: dev@dpdk.org CC: tiwei@intel.com, ray.kinse...@intel.com, zhihong.w...@intel.com, maxime.coque...@redhat.com, kuralamudhan.ramakrish...@intel.com Subject: [d

Re: [dpdk-dev] 17.11.4 patches review and test

On Thu, Aug 23, 2018 at 6:18 PM, Yongseok Koh wrote: > > > On Aug 22, 2018, at 5:19 PM, Yongseok Koh wrote: > > > > On Tue, Aug 21, 2018 at 12:07:49PM +0200, Alejandro Lucero wrote: > >> Hi Yonngseok, > >> > >> There is a patchset aimed at 17.11.x: > >> > >> https://emea01.safelinks.protection.o

Re: [dpdk-dev] [RFC] ethdev: add generic TTL rewrite actions

On 8/24/2018 8:17 AM, Jack MIN wrote: > On Thu, Aug 23, 2018 at 03:00:53PM +0100, Ferruh Yigit wrote: >> On 8/7/2018 3:20 PM, Jack Min wrote: >>> There is a need to rewrite TTL by decrease or just set it directly, >>> and it's not necessary to check if the final result is zero or not. >>> >>> This

Re: [dpdk-dev] [PATCH] doc: fix wrong usage of bind command

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Friday, August 24, 2018 3:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.doc; Mcnamara, John ; Rami > Rosen > Subject: [dpdk-dev] [PATCH] doc: fix wrong usage of bind command > > This patch fixes

[dpdk-dev] [PATCH] doc: fix wrong usage of bind command

This patch fixes wrong usage of bind command in vhost.rst. Using "dpdk-devbind.py -b=uio_pci_generic :00:04.0" gives an error of "unbind failed". It should be "-b uio_pci_generic" so it will work correctly. Signed-off-by: Rami Rosen --- doc/guides/sample_app_ug/vhost.rst | 2 +- 1 file cha

Re: [dpdk-dev] [RFC] ethdev: add generic TTL rewrite actions

On Thu, Aug 23, 2018 at 03:00:53PM +0100, Ferruh Yigit wrote: > On 8/7/2018 3:20 PM, Jack Min wrote: > > There is a need to rewrite TTL by decrease or just set it directly, > > and it's not necessary to check if the final result is zero or not. > > > > This is slightly different from the one defin