Re: [dpdk-dev] [RFC] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-08-21 Thread Ori Kam
Hi all, Just looking for more comments if any 😊 Best, Ori > -Original Message- > From: Ori Kam > Sent: Monday, July 30, 2018 9:03 PM > To: 'Stephen Hemminger' > Cc: Xueming(Steven) Li ; Dekel Peled > ; Shahaf Shuler ; Adrien > Mazarguil ; Thomas Monjalon > ; Yongseok Koh ; > ferruh.yi.

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-21 Thread Honnappa Nagarahalli
-Original Message- From: Michel Machado Sent: Tuesday, August 21, 2018 7:42 AM To: Honnappa Nagarahalli ; Fu, Qiaobin ; Richardson, Bruce ; De Lara Guarch, Pablo Cc: dev@dpdk.org; Doucette, Cody, Joseph ; Wang, Yipeng1 ; Wiles, Keith ; Gobriel, Sameh ; Tai, Charlie ; Stephen Hemmi

Re: [dpdk-dev] pktgen: about x710 init error

2018-08-21 Thread Wiles, Keith
> On Aug 18, 2018, at 6:58 AM, Chengbo CB1 Gao wrote: > > Hi Team, > > When I used PKTGEN by X710VF, I found that PKTGEN failed to be initialized. > The reason is that VF has no ability to disable HW CRC strip. But it's > defaulted to be disabled in PKTGEN because the global variable(hw_stri

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-21 Thread Michel Machado
On 08/17/2018 03:41 PM, Honnappa Nagarahalli wrote: Can you elaborate more on using ' struct rte_conflict_iterator_state' as the argument for the API? If the API signature is changed to: rte_hash_iterate_conflict_entries (const struct rte_hash *h, void **key, void **data, const hash_sig_t sig,

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-21 Thread Michel Machado
On 08/21/2018 01:10 AM, Honnappa Nagarahalli wrote: On 08/17/2018 03:41 PM, Honnappa Nagarahalli wrote: Can you elaborate more on using ' struct rte_conflict_iterator_state' as the argument for the API? If the API signature is changed to: rte_hash_iterate_conflict_entries (const struct rte_ha

[dpdk-dev] pktgen: about x710 init error

2018-08-21 Thread Chengbo CB1 Gao
Hi Team, When I used PKTGEN by X710VF, I found that PKTGEN failed to be initialized. The reason is that VF has no ability to disable HW CRC strip. But it's defaulted to be disabled in PKTGEN because the global variable(hw_strip_crc) is set to 0 by default. As we know PF can support to disable H

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-21 Thread Michel Machado
On 08/17/2018 03:41 PM, Honnappa Nagarahalli wrote: Do we also need to have 'rte_hash_iterate_conflict_entries_with_hash' API? I may have not understood the question. We are already working with the hash (i.e. sig). Did you mean something else? Let me elaborate. For the API 'rte_hash_loo

Re: [dpdk-dev] [PATCH v2] hash table: add an iterator over conflicting entries

2018-08-21 Thread Michel Machado
On 08/16/2018 10:33 PM, Honnappa Nagarahalli wrote: +/* Get the primary bucket index given the precomputed hash value. */ +static inline uint32_t rte_hash_get_primary_bucket(const struct +rte_hash *h, hash_sig_t sig) { + return sig & h->bucket_bitmask; +} + +/* Get the secondary bucket inde

[dpdk-dev] [PATCH] bus/fslmc: fix shared build

2018-08-21 Thread Pablo de Lara
When building DPDK as shared library, disabling optimizations, the following compilation issue appears: portal/dpaa2_hw_dpio.o: In function `dpaa2_mem_ptov': drivers/bus/fslmc/portal/dpaa2_hw_pvt.h:289: undefined reference to `rte_dpaa2_memsegs' ... Bugzilla ID: 61 Fixes: 365fb925d3b3 ("bus/fslm

Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-21 Thread Stephen Hemminger
On Tue, 21 Aug 2018 15:48:19 + Matan Azrad wrote: > Hi > > From: Stephen Hemminger > > On Tue, 21 Aug 2018 10:20:43 + > > Matan Azrad wrote: > > > > > From: Stephen Hemminger > > > > Function is boolean so use that. > > > > > > Ethdev is not using bool type, see also: > > > rte_e

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Chas Williams
On Tue, Aug 21, 2018 at 11:43 AM Matan Azrad wrote: > Hi Chas > > From: Chas Williams > > On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad > > wrote: > > Hi > > > > From: Chas Williams > > > This will need to be implemented for some of the other RX burst > > > methods at some point for other modes to

Re: [dpdk-dev] [PATCH v3] ethdev: silence error message on rte_eth_dev_owner_unset

2018-08-21 Thread Matan Azrad
Hi From: Stephen Hemminger > From 74ad4c60262b1451a5a2fabf79a2df89c6c5373d Mon Sep 17 00:00:00 2001 > From: Stephen Hemminger > Date: Thu, 16 Aug 2018 15:37:14 -0700 > Subject: [PATCH 1/5] ethdev: silence error message on > rte_eth_dev_owner_unset > > The rte_eth_dev_owner_unset function always

Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-21 Thread Matan Azrad
Hi From: Stephen Hemminger > On Tue, 21 Aug 2018 10:20:43 + > Matan Azrad wrote: > > > From: Stephen Hemminger > > > Function is boolean so use that. > > > > Ethdev is not using bool type, see also: > > rte_eth_dev_is_valid_port > > rte_eth_dev_is_removed > > rte_eth_dev_pool_ops_supported >

[dpdk-dev] [PATCH v3] ethdev: silence error message on rte_eth_dev_owner_unset

2018-08-21 Thread Stephen Hemminger
From 74ad4c60262b1451a5a2fabf79a2df89c6c5373d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 16 Aug 2018 15:37:14 -0700 Subject: [PATCH 1/5] ethdev: silence error message on rte_eth_dev_owner_unset The rte_eth_dev_owner_unset function always generates a log message because the unset

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Matan Azrad
Hi Chas From: Chas Williams > On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad > wrote: > Hi > > From: Chas Williams > > This will need to be implemented for some of the other RX burst > > methods at some point for other modes to see this performance > > improvement (with the exception of active-back

Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-21 Thread Stephen Hemminger
On Tue, 21 Aug 2018 10:20:43 + Matan Azrad wrote: > From: Stephen Hemminger > > Function is boolean so use that. > > Ethdev is not using bool type, see also: > rte_eth_dev_is_valid_port > rte_eth_dev_is_removed > rte_eth_dev_pool_ops_supported > > I think it should be a full solution to a

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Chas Williams
On Tue, Aug 21, 2018 at 6:56 AM Matan Azrad wrote: > Hi > > From: Chas Williams > > This will need to be implemented for some of the other RX burst methods > at > > some point for other modes to see this performance improvement (with the > > exception of active-backup). > > Yes, I think it should

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Matteo Lanzuisi
Il 21/08/2018 14:51, Wiles, Keith ha scritto: On Aug 21, 2018, at 7:44 AM, Matteo Lanzuisi wrote: Il 21/08/2018 14:17, Wiles, Keith ha scritto: On Aug 21, 2018, at 7:01 AM, Matteo Lanzuisi wrote: Hi Il 20/08/2018 18:03, Wiles, Keith ha scritto: On Aug 20, 2018, at 9:47 AM, Matteo Lanzuis

[dpdk-dev] 18.08 build error on ppc64el - bool as vector type

2018-08-21 Thread Christian Ehrhardt
Hi, Debian and Ubuntu face a build error with 18.08 on ppc64el. It looks like that: Full log: https://buildd.debian.org/status/fetch.php?pkg=dpdk&arch=ppc64el&ver=18.08-1&stamp=1534520196&raw=0 /<>/drivers/net/mlx5/mlx5_nl.c: In function 'mlx5_nl_switch_info_cb': /<>/drivers/net/mlx5/mlx5_nl.c:83

Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria

2018-08-21 Thread Ananyev, Konstantin
> > > -Original Message- > > From: Dekel Peled [mailto:dek...@mellanox.com] > > Sent: Monday, August 13, 2018 10:47 AM > > To: dev@dpdk.org > > Cc: Ori Kam ; Shahaf Shuler > > > > Subject: [RFC] ethdev: support metadata as flow rule criteria > > > > Current implementation of rte_flow a

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Wiles, Keith
> On Aug 21, 2018, at 7:44 AM, Matteo Lanzuisi wrote: > > Il 21/08/2018 14:17, Wiles, Keith ha scritto: >> >>> On Aug 21, 2018, at 7:01 AM, Matteo Lanzuisi wrote: >>> >>> Hi >>> >>> Il 20/08/2018 18:03, Wiles, Keith ha scritto: > On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi > wro

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Matteo Lanzuisi
Il 21/08/2018 14:17, Wiles, Keith ha scritto: On Aug 21, 2018, at 7:01 AM, Matteo Lanzuisi wrote: Hi Il 20/08/2018 18:03, Wiles, Keith ha scritto: On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi wrote: Hello Olivier, Il 13/08/2018 23:54, Olivier Matz ha scritto: Hello Matteo, On Mon, A

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Wiles, Keith
> On Aug 21, 2018, at 7:01 AM, Matteo Lanzuisi wrote: > > Hi > > Il 20/08/2018 18:03, Wiles, Keith ha scritto: >>> On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi >>> wrote: >>> >>> Hello Olivier, >>> >>> Il 13/08/2018 23:54, Olivier Matz ha scritto: >>> Hello Matteo, On Mon

Re: [dpdk-dev] Multi-thread mempool usage

2018-08-21 Thread Matteo Lanzuisi
Hi Il 20/08/2018 18:03, Wiles, Keith ha scritto: On Aug 20, 2018, at 9:47 AM, Matteo Lanzuisi wrote: Hello Olivier, Il 13/08/2018 23:54, Olivier Matz ha scritto: Hello Matteo, On Mon, Aug 13, 2018 at 03:20:44PM +0200, Matteo Lanzuisi wrote: Any suggestion? any idea about this behaviour?

Re: [dpdk-dev] [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset

2018-08-21 Thread Ananyev, Konstantin
> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Tuesday, August 21, 2018 12:07 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > Subject: [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset > > In case of a temporary failure

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Luca Boccassi
On Tue, 2018-08-21 at 10:56 +, Matan Azrad wrote: > Hi > > From: Chas Williams > > This will need to be implemented for some of the other RX burst > > methods at > > some point for other modes to see this performance improvement > > (with the > > exception of active-backup). > > Yes, I think

[dpdk-dev] [PATCH] net/ixgbe: do not return internal code in rte_eth_dev_reset

2018-08-21 Thread Luca Boccassi
In case of a temporary failure the ixgbe driver can return the internal error IXGBE_ERR_RESET_FAILED to the application. Instead, return -EAGAIN as per the public API specification. Signed-off-by: Luca Boccassi --- drivers/net/ixgbe/base/ixgbe_vf.c | 7 ++- 1 file changed, 6 insertions(+), 1

Re: [dpdk-dev] [PATCH v4] net/bonding: per-slave intermediate rx ring

2018-08-21 Thread Matan Azrad
Hi From: Chas Williams > This will need to be implemented for some of the other RX burst methods at > some point for other modes to see this performance improvement (with the > exception of active-backup). Yes, I think it should be done at least to bond_ethdev_rx_burst_8023ad_fast_queue (should

Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool

2018-08-21 Thread Matan Azrad
From: Stephen Hemminger > Function is boolean so use that. Ethdev is not using bool type, see also: rte_eth_dev_is_valid_port rte_eth_dev_is_removed rte_eth_dev_pool_ops_supported I think it should be a full solution to all. > Signed-off-by: Stephen Hemminger > --- > lib/librte_ethdev/rte_

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-21 Thread Alejandro Lucero
Hi Yonngseok, There is a patchset aimed at 17.11.x: https://patches.dpdk.org/cover/42741/ It was not accepted for master because the memory code has changed a lot since 17.11, and I'm working on another patchset for adjusting to the those changes. I wonder if there is any issue with adding this

Re: [dpdk-dev] [PATCH 1/2] ethdev: silence error message on rte_eth_dev_owner_unset

2018-08-21 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > The rte_eth_dev_owner_unset function always generates a log message > because the unset value for owner id is 0. > > Fixes: 5b7ba31148a8 ("ethdev: add port ownership") > Signed-off-by: Stephen Hemminger > --- > lib/librte_ethdev/rte_ethdev.c | 11 ++-

Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-08-21 Thread Jerin Jacob
-Original Message- > Date: Tue, 21 Aug 2018 14:22:15 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: olivier.m...@6wind.com, dev@dpdk.org, nikhil@intel.com > Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for > eth Tx adapter > User-Agent: Mozilla/5.0 (Windo

Re: [dpdk-dev] [PATCH] check-symbol-change: relax rule for identifying a section

2018-08-21 Thread Thomas Monjalon
17/08/2018 05:03, Rao, Nikhil: > On 8/16/2018 4:38 PM, Neil Horman wrote: > > It was reported recently that some patches that add symbols to an > > existing EXPERIMENTAL section of a version map file generate errors > > because the check-symbol-change script was identifying the section as > > "@@"

Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-08-21 Thread Rao, Nikhil
On 8/19/2018 4:15 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 17 Aug 2018 09:50:50 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, olivier.m...@6wind.com CC: dev@dpdk.org, Nikhil Rao Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapt

Re: [dpdk-dev] [PATCH v1 0/5] Enable hotplug in vfio

2018-08-21 Thread Gaëtan Rivet
On Tue, Aug 21, 2018 at 02:45:32PM +0800, Jeff Guo wrote: > hi, gaetan > > > On 8/20/2018 5:15 PM, Gaëtan Rivet wrote: > > Hi Jeff, > > > > On Fri, Aug 17, 2018 at 06:51:26PM +0800, Jeff Guo wrote: > > > As we may know that the process of hotplug is different between igb_uio > > > and vfio. For

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-21 Thread Rahul Lakkireddy
On Tuesday, August 08/14/18, 2018 at 14:45:45 +0530, Jack MIN wrote: > On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote: > > On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote: > > > There is a need to offload rewrite MAC address for both destination and > > > sour

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-21 Thread Marco Varlese
On Mon, 2018-08-20 at 22:35 +, Mody, Rasesh wrote: > > From: dev On Behalf Of Marco Varlese > > Sent: Monday, August 20, 2018 2:21 AM > > > > Hi, > > > > The code in 17.11.4-rc1 does not compile for me. > > This needs to be fixed for 17.11.4 as rte_eth_linkstatus_set() is not > available in

Re: [dpdk-dev] [PATCH v1 2/5] eal: add a new req event to device event

2018-08-21 Thread Jeff Guo
On 8/21/2018 3:20 PM, Andrew Rybchenko wrote: On 21.08.2018 09:56, Jeff Guo wrote: hi, andrew On 8/20/2018 6:37 PM, Andrew Rybchenko wrote: On 17.08.2018 13:51, Jeff Guo wrote: Add a new req event in eal device event for vfio hotplug. When the req request send from the vfio kernel module

Re: [dpdk-dev] [PATCH v1 2/5] eal: add a new req event to device event

2018-08-21 Thread Andrew Rybchenko
On 21.08.2018 09:56, Jeff Guo wrote: hi, andrew On 8/20/2018 6:37 PM, Andrew Rybchenko wrote: On 17.08.2018 13:51, Jeff Guo wrote: Add a new req event in eal device event for vfio hotplug. When the req request send from the vfio kernel module be detected, vfio userpace driver could use this e