Tested-by: Peng, Yuan
- DPDK version: 18.08-rc1 commit c27dbc300eee78c2eb33e84181617fdd7cbaaae4
- OS: 4.5.5-300.fc24.x86_64
- Compiler: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2)
- Hardware platform: BDE-EP
- NIC Intel Corporation Device Fortville [8086:1583]
- driver: i40e
- version: 2.4.3
- fir
Hi, Yuan
How about your test result ?
Thanks a lot!
> -Original Message-
> From: Dai, Wei
> Sent: Thursday, July 19, 2018 8:21 PM
> To: Wu, Jingjing ; yuan.p...@intle.com
> Cc: dev@dpdk.org; sta...@dpdk.org; Dai, Wei
> Subject: [PATCH] app/testpmd: fix commands to config some offload
>
>
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Friday, July 20, 2018 12:46 AM
> To: John W. Linville ; Doherty, Declan
> ; Chas Williams ; Gaetan Rivet
> ; Tetsuya Mukawa ;
> Santosh Shukla ; Jerin Jacob
> ; Wiles, Keith ;
> Maxime Coquel
https://bugs.dpdk.org/show_bug.cgi?id=68
Ajit Khaparde (ajit.khapa...@broadcom.com) changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
As VhostUserMsg structure is resued to generate the reply, move the
relevant fields update into the respective message handling functions.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff
Introduce vhost_message_handlers, which maps the message request
type to the message handler. Then replace the switch construct
with a map and call.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 143 +++--
1 file changed, 54 insertions(+
Add new functions to handle the unsupported vhost message types:
- vhost_user_set_vring_err
- vhost_user_set_log_fd
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/v
Each vhost-user message handling function will return an int result
which is described in the new enum vh_result: error, OK and reply.
All functions will now have two arguments, virtio_net double pointer
and VhostUserMsg pointer.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c
vhost: vhost_user.c code cleanup
This patchesries introduce a set of code redesigns in vhost_user.c.
The goal is to unify and simplify vhost-user message handling. The
patches do not intend to introduce any functional changes.
v2 changes:
- Fix the comments by Tiwei Bie
- Keep the old behavior
Use the typedef version of struct VhostUserMsg. Also unify the related
parameter name.
Signed-off-by: Nikolay Nikolaev
---
lib/librte_vhost/vhost_user.c | 50 +
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c
This seems fine. The bond PMD seems to call back into itself early.
On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau wrote:
> setting up the bonding options before calling rte_eth_dev_probing_finish
> triggers an invalid port id error because of port state not set, or set
> unused
>
> Fixes: fbe90c
Signed-off-by: Fiona Trahe
---
test/test/test_compressdev.c | 59 ++--
1 file changed, 40 insertions(+), 19 deletions(-)
diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c
index e3bfcd1..8645388 100644
--- a/test/test/test_compressdev
Put session private data back to mempool when clearing
a crypto session, which is expected to be done in the PMD.
Fixes: b7fa78c7d3b0 ("crypto/virtio: support session related ops")
Cc: sta...@dpdk.org
Signed-off-by: Pablo de Lara
---
drivers/crypto/virtio/virtio_cryptodev.c | 5 -
1 file ch
On 19.07.2018 19:20, Stephen Hemminger wrote:
DPDK malloc library allows broken programs to work because
the semantics of zmalloc and malloc are the same.
This patch enables a more secure model which will catch
(and crash) programs that reuse memory already freed if
RTE_MALLOC_DEBUG is enabled.
On 19.07.2018 19:20, Stephen Hemminger wrote:
DPDK malloc library allows broken programs to work because
the semantics of zmalloc and malloc are the same.
This patch enables a more secure model which will catch
(and crash) programs that reuse memory already freed if
RTE_MALLOC_DEBUG is enabled.
IV_param_check() function was checking if the IV size provided
was supported by device and setting the IV size in the xform
structure.
Instead of this, the function should only do the parameter check
and outside the IV size on the xform is set.
Signed-off-by: Pablo de Lara
---
examples/l2fwd-cr
Now that device capabilities are checked separately,
before setting the xform parameters, it is not required
to do the check again, leaving only the xform setting
with the device configuration.
Signed-off-by: Pablo de Lara
---
examples/l2fwd-crypto/main.c | 233 +-
When a crypto device does not support an algorithm, it is skipped
and not used. However, when it does support it, but not the rest
of the parameters (IV, key, AAD sizes...), application stops.
Instead, the device should be skipped and the search of a suitable
device should continue.
Fixes: a061e50
The session mempool size for this application depends
on the number of crypto devices that are capable
of performing the operation given by the parameters on the app.
However, previously this calculation was done before all devices
were checked, resulting in an incorrect number of sessions
require
IV size parameter is checked through a function,
but its return value was not checked.
Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session")
Fixes: acf8616901b5 ("cryptodev: add auth IV")
Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters")
Signed-off-by: Pablo de Lara
C
v2 changes:
- Split patch into multiple patches for better review
- First two patches are fixes for previous releases
Pablo de Lara (5):
examples/l2fwd-crypto: check return value on IV size check
examples/l2fwd-crypto: skip device not supporting operation
examples/l2fwd-crypto: separate IV c
On 19.07.2018 12:48, Burakov, Anatoly wrote:
On 19-Jul-18 10:01 AM, Burakov, Anatoly wrote:
On 18-Jul-18 9:58 PM, Stephen Hemminger wrote:
On Wed, 18 Jul 2018 22:52:12 +0300
Andrew Rybchenko wrote:
On 18.07.2018 20:18, Burakov, Anatoly wrote:
On 18-Jul-18 4:20 PM, Andrew Rybchenko wrote:
H
On 19.07.2018 12:42, Anatoly Burakov wrote:
Previously, we were skipping erasing pad because we were
expecting it to be freed when we were merging adjacent
segments. However, if there were no adjacent segments to
merge, we would've skipped erasing the pad, leaving non-zero
memory in our free spac
On Thu, 19 Jul 2018 17:45:56 +0100
Ferruh Yigit wrote:
> Calling rte_eth_dev_info_get() on secondary process cause a crash
> because eth_dev->device is not set properly.
>
> Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ferruh
On 19.07.2018 19:07, Andrew Rybchenko wrote:
On 19.07.2018 13:56, Ferruh Yigit wrote:
On 7/15/2018 10:56 AM, Andrew Rybchenko wrote:
Andrew Rybchenko (3):
net/sfc: move Rx checksum offload check to device level
net/sfc: fix Rx queue offloads reporting in queue info
net/sfc: prepare to
DPDK malloc library allows broken programs to work because
the semantics of zmalloc and malloc are the same.
This patch enables a more secure model which will catch
(and crash) programs that reuse memory already freed if
RTE_MALLOC_DEBUG is enabled.
Signed-off-by: Stephen Hemminger
---
v2
-
On 19.07.2018 13:56, Ferruh Yigit wrote:
On 7/15/2018 10:56 AM, Andrew Rybchenko wrote:
Andrew Rybchenko (3):
net/sfc: move Rx checksum offload check to device level
net/sfc: fix Rx queue offloads reporting in queue info
net/sfc: prepare to support Rx datapath without checksum
Hi Andre
Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any
other IPv6 extension headers when finding the fragment header.
According to RFC 8200, there is no guarantee that the IPv6
Fragment extension header will come before any other extension
header, even though it is recommended.
Signed-o
Calling rte_eth_dev_info_get() on secondary process cause a crash
because eth_dev->device is not set properly.
Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
Cc: Vipin Varghese
---
drivers/net/af_packet/rte_eth_af_p
On Thu, Jul 19, 2018 at 02:09:47PM +0200, Thomas Monjalon wrote:
> 19/07/2018 13:14, Neil Horman:
> > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote:
> > > If the patch filename or the temporary file path have a space
> > > in their name, the script check-symbol-change.sh does not
On 19-Jul-18 3:26 PM, Bruce Richardson wrote:
When building DPDK with meson with the being outside the source
directory, an error was generated as the path to the EAL headers was not
found. The path specified for the includes backed out unnecessarily far and
so broke when the build directory was
EAL is a standard dependency of all libraries, except for those built
before it. We can therefore simplify the logic by just checking if EAL
has been processed, and make it a standard dependency if so.
Signed-off-by: Bruce Richardson
---
lib/meson.build | 10 --
1 file changed, 4 inserti
When building DPDK with meson with the being outside the source
directory, an error was generated as the path to the EAL headers was not
found. The path specified for the includes backed out unnecessarily far and
so broke when the build directory was not in the expected location of
just inside the
There is no need to check for each library, driver and example whether
certain cflags are supported. Instead of checking inside the loop, do
so outside and reuse the value.
Signed-off-by: Bruce Richardson
---
drivers/meson.build | 9 +
examples/meson.build | 9 +
lib/meson.bui
On Thu, Jul 19, 2018 at 11:37:31AM +0800, Tiwei Bie wrote:
> On Tue, Jul 17, 2018 at 09:10:35PM +0800, Tiwei Bie wrote:
> > Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path")
> >
> > Reported-by: Yinan Wang
> > Signed-off-by: Tiwei Bie
>
> Applied to dpdk-next-virtio/master, than
On 7/18/2018 8:43 AM, Andrew Rybchenko wrote:
> Fix debug build assertion if unknown L3 packet is received.
>
> Fixes: 638bddc99faa ("net/sfc: implement EF10 native Rx datapath")
> Fixes: c121f00836ca ("net/sfc: move EF10 Rx event parser to shared header")
> Cc: sta...@dpdk.org
>
> Signed-off-by:
On 7/18/2018 8:40 AM, Andrew Rybchenko wrote:
> Return value equal to zero means success and really expected.
>
> Fixes: 0fa0070e4391 ("net/sfc: support multicast addresses list controls")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Andrew Rybchenko
Applied to dpdk-next-net/master, thanks.
Minutes of 19 July 2018
---
Agenda:
* RC2 for 18.08
* Subtrees
* Defects
Participants:
* Intel
* Mellanox
* NXP
* 6Wind
* RedHat
* Broadcom
RC2 for 18.08
-
* *RC2* date is on *Tuesday 24 July* (May slip to 25 July).
* Testing status
* Multi process memory issu
On 7/18/2018 6:27 PM, Jerin Jacob wrote:
> -Original Message-
>> Date: Wed, 18 Jul 2018 20:35:01 +0530
>> From: Pavan Nikhilesh
>> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>> rkuduruma...@caviumnetworks.com, ferruh.yi...@intel.com
>> Cc: dev@dpdk.org, Pavan N
Update BBDEV Turbo SW driver download/build instructions for
FlexRAN 1.6.0 release
Signed-off-by: Amr Mokhtar
---
doc/guides/bbdevs/turbo_sw.rst | 38 +++-
drivers/baseband/turbo_sw/bbdev_turbo_software.c | 8 ++---
2 files changed, 22 insertions(+), 24 del
> -Original Message-
> From: Horton, Remy
> Sent: Thursday, July 19, 2018 8:41 PM
> To: Zhang, Qi Z
> Cc: Lu, Wenzhuo ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v2] net/ixgbe: fix missing NULL point check
>
>
> On 16/07/2018 13:47, Qi Zhang wrote:
> > Add missing NULL point
On 16/07/2018 13:47, Qi Zhang wrote:
Add missing NULL point check inside ixgbe_pf_host_uninit, or it may cause
segment fault when detaching a device.
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
Acked-by: Remy Horton
Zhang, Qi Z would like to recall the message, "[PATCH v2] net/ixgbe: fix
missing NULL point check".
Hi Remy:
Would you mind to give an ack for this patch if no more issue, so I can
merge to dpdk-next-net-intel.
Thanks
Qi
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, July 16, 2018 8:47 PM
> To: Horton, Remy
> Cc: Lu, Wenzhuo ; dev@dpdk.org; Zhang, Qi Z
> ; sta...@dpdk
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Wednesday, July 18, 2018 8:35 PM
> To: Lu, Wenzhuo ; Ananyev, Konstantin
>
> Cc: dev@dpdk.org; Yigit, Ferruh ; Wiles, Keith
>
> Subject: [dpdk-dev] [PATCH 1/3] net/ixgbe: remove redundant q
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, July 18, 2018 8:35 PM
> To: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Zhang, Qi Z ; Wang,
> Xiao W
> Cc: dev@dpdk.org; Yigit, Ferruh ; Wiles, Keith
>
> Subject: [PATCH 3/3] net/fm10k: remove redundant queue id checks
>
> remove
From: Ilia Kurakin
The patch changes rx_burst profiling approach:
1. VTune's instrumentation is removed
2. empty hook callback for profiling is added
This way all VTune-specific logic moves to the VTune side.
Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option
is
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, July 18, 2018 8:35 PM
> To: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Xing, Beilei ; Zhang,
> Qi Z
> Cc: dev@dpdk.org; Yigit, Ferruh ; Wiles, Keith
>
> Subject: [PATCH 2/3] net/i40e: remove redundant queue id checks
>
> remove
19/07/2018 13:14, Neil Horman:
> On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote:
> > If the patch filename or the temporary file path have a space
> > in their name, the script check-symbol-change.sh does not work.
> > The variables for the filenames must be enclosed in quotes
> >
Modifying port state is not necessary when starting/stopping Rx adapter
as it is same as starting/stopping ethdev.
Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
Cc: sta...@dpdk.org
Signed-off-by: Pavan Nikhilesh
---
drivers/event/octeontx/ssovf_evdev.c | 14 ++
1
Use proper teardown sequence when SIGINT is caught to prevent
eventdev from going into undefined state.
Signed-off-by: Pavan Nikhilesh
---
v2 Changes:
- Only stopping the ethdev(producer) is sufficient.(Jerin)
app/test-eventdev/evt_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletio
On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote:
> If the patch filename or the temporary file path have a space
> in their name, the script check-symbol-change.sh does not work.
> The variables for the filenames must be enclosed in quotes
> in order to preserve spaces.
>
> Fixes:
Compressdev tests depend on Zlib library,
so they can only be enabled if this is available.
Signed-off-by: Pablo de Lara
---
v2:
- Add test "$DPDK_DEP_ZLIB" != y" line, to actually check for the
Zlib dependency
devtools/test-build.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/devt
On Thu, Jul 19, 2018 at 4:03 AM, Pablo de Lara <
pablo.de.lara.gua...@intel.com> wrote:
> NFP PMD does not have any external dependency.
> It only requires Linux OS, so it is not needed
> to be enabled in the test-build script.
>
> Signed-off-by: Pablo de Lara
> ---
> devtools/test-build.sh | 1
NFP PMD does not have any external dependency.
It only requires Linux OS, so it is not needed
to be enabled in the test-build script.
Signed-off-by: Pablo de Lara
---
devtools/test-build.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3
> On Jul 13, 2018, at 7:57 PM, Wiles, Keith wrote:
>
> > On Jul 13, 2018, at 12:10 PM, Burakov, Anatoly
> > wrote:
> >
> > On 06-Jul-18 2:17 PM, Anatoly Burakov wrote:
> >> This is a proposal to enable using externally allocated memory in
> >> DPDK.
> >> In a nutshell, here is what is being done
On 7/18/2018 8:35 AM, Ferruh Yigit wrote:
> On 7/17/2018 7:32 PM, Jasvinder Singh wrote:
>> Improve description of api used to get port name from port id or
>> vice-versa.
>>
>> Signed-off-by: Jasvinder Singh
>
> Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
On 7/15/2018 10:56 AM, Andrew Rybchenko wrote:
> Andrew Rybchenko (3):
> net/sfc: move Rx checksum offload check to device level
> net/sfc: fix Rx queue offloads reporting in queue info
> net/sfc: prepare to support Rx datapath without checksum
Hi Andrew,
These conflict with another sfc pat
18/07/2018 17:58, Yao, Lei A:
> From: Burakov, Anatoly
> >
> > Currently, we need runtime dir to put all of our runtime info in,
> > including the DPDK shared config. However, we use the shared
> > config to determine our proc type, and this happens earlier than
> > we actually create the config d
On 7/19/2018 10:32 AM, Ferruh Yigit wrote:
> On 7/18/2018 5:30 PM, Gage Eads wrote:
>> Set the rx and tx queue state appropriately when the queues or device are
>> started or stopped. This enables usage of the ethdev rx/tx queue start/stop
>> functions with the PCAP PMD.
>>
>> Signed-off-by: Gage E
On 7/9/2018 11:01 PM, Wiles, Keith wrote:
>
>
>> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote:
>>
>> Set the rx and tx queue state appropriately when the queues or device are
>> started or stopped.
>>
>> Signed-off-by: Gage Eads
>
> Acked-by Keith Wiles
Applied to dpdk-next-net/master, thank
On 18-Jul-18 10:44 PM, Stephen Hemminger wrote:
DPDK malloc library allows broken programs to work because
the semantics of zmalloc and malloc are the same.
This patch changes to a more secure model which will catch
(and crash) programs that reuse memory already freed.
This supersedes earlier c
On 19-Jul-18 10:01 AM, Burakov, Anatoly wrote:
On 18-Jul-18 9:58 PM, Stephen Hemminger wrote:
On Wed, 18 Jul 2018 22:52:12 +0300
Andrew Rybchenko wrote:
On 18.07.2018 20:18, Burakov, Anatoly wrote:
On 18-Jul-18 4:20 PM, Andrew Rybchenko wrote:
Hi Anatoly,
I'm investigating issue which fina
On Thu, Jul 19, 2018 at 10:03:55AM +0100, Burakov, Anatoly wrote:
> On 18-Jul-18 10:44 PM, Stephen Hemminger wrote:
> > DPDK malloc library allows broken programs to work because
> > the semantics of zmalloc and malloc are the same.
> >
> > This patch changes to a more secure model which will catc
Previously, we were skipping erasing pad because we were
expecting it to be freed when we were merging adjacent
segments. However, if there were no adjacent segments to
merge, we would've skipped erasing the pad, leaving non-zero
memory in our free space.
Fix this by including pad in the erasing u
On 7/18/2018 5:30 PM, Gage Eads wrote:
> Set the rx and tx queue state appropriately when the queues or device are
> started or stopped. This enables usage of the ethdev rx/tx queue start/stop
> functions with the PCAP PMD.
>
> Signed-off-by: Gage Eads
Acked-by: Ferruh Yigit
On 18-Jul-18 10:44 PM, Stephen Hemminger wrote:
DPDK malloc library allows broken programs to work because
the semantics of zmalloc and malloc are the same.
This patch changes to a more secure model which will catch
(and crash) programs that reuse memory already freed.
This supersedes earlier c
On 18-Jul-18 9:58 PM, Stephen Hemminger wrote:
On Wed, 18 Jul 2018 22:52:12 +0300
Andrew Rybchenko wrote:
On 18.07.2018 20:18, Burakov, Anatoly wrote:
On 18-Jul-18 4:20 PM, Andrew Rybchenko wrote:
Hi Anatoly,
I'm investigating issue which finally comes to the fact that memory
allocated usin
68 matches
Mail list logo
