Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-02 Thread Maxime Coquelin
On 07/03/2018 07:57 AM, Jason Wang wrote: On 2018年07月02日 16:16, Maxime Coquelin wrote: +static inline int +vhost_enable_notify_split(struct vhost_virtqueue *vq, int enable) +{ +    if (enable) +    vq->used->flags &= ~VRING_USED_F_NO_NOTIFY; +    else +    vq->used->flags |= VRING_U

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-07-02 Thread Sunil Kumar Kori
Hello Anoob, Regards Sunil Kumar > -Original Message- > From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, June 28, 2018 4:13 PM > To: Sunil Kumar Kori ; Bruce Richardson > ; Jerin Jacob > ; Pablo de Lara > > Cc: Hemant Agrawal ; Narayana Prasad > ; Nikhil Rao

Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-02 Thread Jason Wang
On 2018年07月02日 16:16, Maxime Coquelin wrote: Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 73 lib/librte_vhost/vhost.h | 71 ++ lib/librte_vhost/vhost_user.c| 24 +

Re: [dpdk-dev] [PATCH v6 14/15] vhost: add notification for packed ring

2018-07-02 Thread Jason Wang
On 2018年07月02日 16:16, Maxime Coquelin wrote: +static inline int +vhost_enable_notify_split(struct vhost_virtqueue *vq, int enable) +{ + if (enable) + vq->used->flags &= ~VRING_USED_F_NO_NOTIFY; + else + vq->used->flags |= VRING_USED_F_NO_NOTIFY; + +

Re: [dpdk-dev] [PATCH v3 1/7] vhost: use shadow used ring in dequeue path

2018-07-02 Thread Maxime Coquelin
On 07/03/2018 05:28 AM, Tiwei Bie wrote: On Wed, Jun 27, 2018 at 04:49:53PM +0200, Maxime Coquelin wrote: [...] @@ -1164,8 +1136,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id, if (mbuf_is_consumed(zmbuf->mbuf)) { used_idx = vq->last_used_idx+

Re: [dpdk-dev] [PATCH v3 2/7] vhost: make gpa to hpa failure an error

2018-07-02 Thread Maxime Coquelin
On 07/03/2018 06:45 AM, Tiwei Bie wrote: On Wed, Jun 27, 2018 at 04:49:54PM +0200, Maxime Coquelin wrote: CVE-2018-1059 fix makes sure gpa contiguous memory is also contiguous in hva space. Incidentally, it also makes sure it is contiguous in hpa space. So we can simplify the code by making

[dpdk-dev] [PATCH v3] mempool/octeontx: fix pool to aura mapping

2018-07-02 Thread Pavan Nikhilesh
HW needs each pool to be mapped to an aura set of 16 auras. Previously, pool to aura mapping was considered to be 1:1. Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh Acked-by: Santosh Shukla Acked-by: Jerin Jacob --- drivers/eve

Re: [dpdk-dev] [PATCH v3 2/7] vhost: make gpa to hpa failure an error

2018-07-02 Thread Tiwei Bie
On Wed, Jun 27, 2018 at 04:49:54PM +0200, Maxime Coquelin wrote: > CVE-2018-1059 fix makes sure gpa contiguous memory is > also contiguous in hva space. Incidentally, it also makes > sure it is contiguous in hpa space. > > So we can simplify the code by making gpa contiguous memory > discontiguous

Re: [dpdk-dev] [PATCH v3 1/7] vhost: use shadow used ring in dequeue path

2018-07-02 Thread Tiwei Bie
On Wed, Jun 27, 2018 at 04:49:53PM +0200, Maxime Coquelin wrote: [...] > @@ -1164,8 +1136,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id, > > if (mbuf_is_consumed(zmbuf->mbuf)) { > used_idx = vq->last_used_idx++ & (vq->size - 1); Above

Re: [dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal and offload improvements

2018-07-02 Thread Tiwei Bie
On Mon, Jul 02, 2018 at 05:25:43PM +0200, Maxime Coquelin wrote: > In this v3, the main change is the removal of the Tx simple path. > Indeed, this path is not compliant with the Virtio specification, > so could cause problems with some host implementations. > > Since Marvin has introduced the in-

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-02 Thread Jack Min
Hey Rahul, Thank you, those two are the ways to achieve that. Personally I prefer the option 1 but with a little bit difference, something like: struct rte_flow_action_of_set_nw_ipv4 { uint32_t ipv4_addr; uint8_t level; /* 0 - outer (default), 1 - inner, 2 -255

Re: [dpdk-dev] [PATCH v5 8/9] net/virtio: add in-order Rx/Tx into selection

2018-07-02 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Monday, July 02, 2018 11:18 PM > To: Liu, Yong ; Bie, Tiwei ; > Yigit, Ferruh > Cc: Wang, Zhihong ; dev@dpdk.org > Subject: Re: [PATCH v5 8/9] net/virtio: add in-order Rx/Tx into selection > > > >

Re: [dpdk-dev] [PATCH v2 03/20] net/mlx5: replace verbs priorities by flow

2018-07-02 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:35PM +0200, Nelio Laranjeiro wrote: > Previous work introduce verbs priorities, whereas the PMD is making > translation between Flow priority into Verbs. Rename this to make more > sense on what the PMD has to translate. > > Signed-off-by: Nelio Laranjeiro > --- Ack

Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx

2018-07-02 Thread Liu, Yong
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, July 03, 2018 12:57 AM > To: Maxime Coquelin ; Liu, Yong > ; Bie, Tiwei > Cc: Wang, Zhihong ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and > Tx > > On 7/2/2018 5:53 PM, Maxime Coquel

Re: [dpdk-dev] [PATCH v2 02/20] net/mlx5: handle drop queues are regular queues

2018-07-02 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:34PM +0200, Nelio Laranjeiro wrote: > Drop queues are essentially used in flows due to Verbs API, the > information if the fate of the flow is a drop or not is already present > in the flow. Due to this, drop queues can be fully mapped on regular > queues. The title

Re: [dpdk-dev] [PATCH 6/7] examples/kni: fix dependency check for building with meson

2018-07-02 Thread Ferruh Yigit
On 6/8/2018 5:38 PM, Bruce Richardson wrote: > Rather than hard-coding the example app to be built only when a set of > conditions are met, we can simplify things by having the app built when > KNI library itself is available. That saves us duplicating the same set > of restrictions on both library

Re: [dpdk-dev] [PATCH 1/7] kni: disable for 32-bit meson builds

2018-07-02 Thread Ferruh Yigit
On 6/8/2018 5:38 PM, Bruce Richardson wrote: > The kni library is not supported on 32-bit so disable it for those > builds using meson. > > Signed-off-by: Bruce Richardson Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

2018-07-02 Thread Ferruh Yigit
On 6/29/2018 10:29 AM, John Daley wrote: > Updated a few commits in the patchset per suggestions by Ferrus Yigit. > thanks, > John > > Hyong Youb Kim (12): > net/enic: fix receive packet types > net/enic: update the UDP RSS detection mechanism > net/enic: do not overwrite admin Tx queue limi

Re: [dpdk-dev] [PATCH v2 01/20] net/mlx5: remove flow support

2018-07-02 Thread Yongseok Koh
On Wed, Jun 27, 2018 at 05:07:33PM +0200, Nelio Laranjeiro wrote: > This start a series to re-work the flow engine in mlx5 to easily support > flow conversion to Verbs or TC. This is necessary to handle both regular > flows and representors flows. > > As the full file needs to be clean-up to re-w

Re: [dpdk-dev] [RFC] ethdev: remove all offload API

2018-07-02 Thread Thomas Monjalon
29/06/2018 03:11, Thomas Monjalon: > 09/06/2018 00:41, Ferruh Yigit: > > Cc: Shahaf Shuler > > > > Signed-off-by: Ferruh Yigit > > I start working on it. > This is the list of remaining work on this patch: > - rebase > - add commit message (and fix title) > - check git grep ET

[dpdk-dev] [PATCH v2 3/5] ethdev: convert remaining apps to new offload API

2018-07-02 Thread Thomas Monjalon
Some test applications and examples were not converted to the new offload API introduced in 17.11. For reference, see "Hardware Offload" in doc/guides/prog_guide/poll_mode_drv.rst Signed-off-by: Thomas Monjalon --- app/test-eventdev/test_perf_common.c | 8 + .../sample_app

[dpdk-dev] [PATCH v2 5/5] ethdev: remove old offload API

2018-07-02 Thread Thomas Monjalon
From: Ferruh Yigit In DPDK 17.11, the ethdev offloads API has changed: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") The new API is documented in the programmer's guide: http://doc.dpdk.org/

[dpdk-dev] [PATCH v2 4/5] net/fm10k: remove unused constant

2018-07-02 Thread Thomas Monjalon
The macro FM10K_SIMPLE_TX_FLAG was used with old Tx queue flags. It is no longer used and was forgotten when cleaning old Tx flags. Fixes: 1778ef67e2e7 ("net/fm10k: remove dependence on Tx queue flags") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- drivers/net/fm10k/fm10k.h | 3 --- 1

[dpdk-dev] [PATCH v2 0/5] remove old ethdev offload API

2018-07-02 Thread Thomas Monjalon
A new offload API has been introduced in DPDK 17.11. This patchset resumes the work started by Ferruh (RFC) to definitely drop the old offload API. There are: - 3 patches to remove some useless code where the old API was found. - 1 patch to remove usage of old API - 1 (big) patch to remove the ol

[dpdk-dev] [PATCH v2 2/5] test: remove unused configuration for bonding

2018-07-02 Thread Thomas Monjalon
The global variables rx_mode and fdir_conf are not used in this test file. Signed-off-by: Thomas Monjalon --- test/test/test_link_bonding.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c index 0ffd65090..d74c0

[dpdk-dev] [PATCH v2 1/5] doc: remove code from KNI example guide

2018-07-02 Thread Thomas Monjalon
The example code is showing how to use KNI, and can be found in examples/kni/ The documentation guide for this example is explaining the code to ease the understanding of the example. And inside this documentation, there are a lot of examples code which are copy/pasted. It is really too muc

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-02 Thread Yongseok Koh
> On Jul 2, 2018, at 4:11 AM, Moti Haimovsky wrote: > > This patch adds support for building and running mlx5 PMD on > 32bit systems such as i686. > > The main issue to tackle was handling the 32bit access to the UAR > as quoted from the mlx5 PRM: > QP and CQ DoorBells require 64-bit writes. F

Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal

2018-07-02 Thread Yongseok Koh
> On Jul 1, 2018, at 10:13 PM, Matan Azrad wrote: > > Starting from rdma-core v19, Mellanox OFED 4.4, the Verbs resources > cleanup is properly activated in plug-out process while setting the > MLX5_DEVICE_FATAL_CLEANUP environment variable to 1. > > Set the aforementioned variable to 1. > >

[dpdk-dev] [PATCH] examples/l3fwd: remove redudant include.

2018-07-02 Thread Rami Rosen
This patch removes unneeded include of rte_mempool.h in two modules in examples/l3fwd. Fixes: 26b5b020 ("examples/l3fwd: modularize") Signed-off-by: Rami Rosen --- examples/l3fwd/l3fwd_em.c | 1 - examples/l3fwd/l3fwd_lpm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/examples/l3f

[dpdk-dev] [PATCH 6/6] net/nfp: support IOVA VA mode

2018-07-02 Thread Alejandro Lucero
NFP can handle IOVA as VA. It requires to check those IOVAs being in the supported range what is done during initialization. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers

[dpdk-dev] [PATCH 2/6] ethdev: add function for checking IOVAs by a device

2018-07-02 Thread Alejandro Lucero
A PMD should invoke this function for checking memsegs iovas are within the supported range by the device. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.h | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_eth

[dpdk-dev] [PATCH 3/6] bus/pci: use IOVAs check when setting IOVA mode

2018-07-02 Thread Alejandro Lucero
Although VT-d emulation currently only supports 39 bits, it could be iovas being within that supported range. This patch allows IOVA mode in such a case. Indeed, memory initialization code can be modified for using lower virtual addresses than those used by the kernel for 64 bits processes by defa

[dpdk-dev] [PATCH 4/6] mem: use address hint for mapping hugepages

2018-07-02 Thread Alejandro Lucero
Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address in the process virtual address space as with 64

[dpdk-dev] [PATCH 5/6] net/nfp: check hugepages IOVAs based on DMA mask

2018-07-02 Thread Alejandro Lucero
NFP devices can not handle DMA addresses requiring more than 40 bits. This patch uses rte_dev_check_dma_mask with 40 bits and avoids device initialization if memory out of NFP range. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 1 file changed, 8 insertions(+) diff

[dpdk-dev] [PATCH 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-02 Thread Alejandro Lucero
A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if this function returns memsegs out of range. Anothe

[dpdk-dev] [PATH 0/6] Use IOVAs check based on DMA mask

2018-07-02 Thread Alejandro Lucero
This patchset adds, mainly, a check for ensuring IOVAs are within a restricted range due to addressing limitations with some devices. There are two known cases: NFP and IOMMU VT-d emulation. With this check IOVAs out of range are detected and PMDs can abort initialization. For the VT-d case, IOVA

[dpdk-dev] [PATCH] common/qat: replace snprintf

2018-07-02 Thread Fiona Trahe
Replaced snprintf with strlcpy for safer string copy Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/common/qat/qat_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c index 64f236

[dpdk-dev] [PATCH v2 5/5] doc: add ZLIB PMD documentation

2018-07-02 Thread Shally Verma
add zlib pmd feature specification and overview documentation Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS | 2 + doc/guides/compressdevs/features/zlib.ini | 22 ++ doc/guides/compressdevs/zlib.rst

[dpdk-dev] [PATCH v2 4/5] compress/zlib: add enq deq apis

2018-07-02 Thread Shally Verma
From: Sunila Sahu implement enqueue and dequeue apis Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 238 ++- 1 file changed, 237 insertions(+), 1 deletion(-) diff --git a/drivers/c

[dpdk-dev] [PATCH v2 3/5] compress/zlib: add xform and stream create support

2018-07-02 Thread Shally Verma
From: Sunila Sahu Implement private xform and stream create ops Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/zlib_pmd.c | 93 drivers/compress/zlib/zlib_pmd_ops.c | 83 +++

[dpdk-dev] [PATCH v2 2/5] compress/zlib: add device setup PMD ops

2018-07-02 Thread Shally Verma
From: Ashish Gupta Implement device configure and PMD ops Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/compress/zlib/Makefile | 1 + drivers/compress/zlib/zlib_pmd.c | 2 + drivers/compress/zlib/zlib_pmd_ops.c | 236

[dpdk-dev] [PATCH v2 1/5] compress/zlib: add ZLIB PMD support

2018-07-02 Thread Shally Verma
From: Ashish Gupta Add sw zlib pmd support in compressdev driver. Add device probe and remove support. Add ZLIB build file support. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS| 3 + config/common_base

Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 5:53 PM, Maxime Coquelin wrote: > > > On 07/02/2018 06:52 PM, Ferruh Yigit wrote: >> On 7/2/2018 5:41 PM, Ferruh Yigit wrote: >>> On 7/2/2018 2:56 PM, Marvin Liu wrote: IN_ORDER Rx function depends on merge-able feature. Descriptors allocation and free will be done in bulk.

[dpdk-dev] [PATCH v2 0/5] compress: add ZLIB compression PMD

2018-07-02 Thread Shally Verma
This patch series add software zlib based compression PMD in DPDK compress drivers. Application must need to install zlib prior to compile and run this PMD to avail compression/decompression services. Currently driver only tested for deflate, stateless compression and decompression with direct memo

[dpdk-dev] [PATCH v2 6/6] usertools: update devbind for octeontx zip device

2018-07-02 Thread Shally Verma
From: Ashish Gupta add the cavium octeontx zip pci device details. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- usertools/dpdk-devbind.py | 9 + 1 file changed, 9 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.

[dpdk-dev] [PATCH v2 5/6] doc: add Octeonx zip guide

2018-07-02 Thread Shally Verma
add zip pmd feature specification and overview documentation Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- doc/guides/compressdevs/features/octeontx.ini | 22 ++ doc/guides/compressdevs/index.rst | 1 + doc/guides/compressdevs/octeont

[dpdk-dev] [PATCH v2 4/6] compress/octeontx: add ops enq deq apis

2018-07-02 Thread Shally Verma
From: Ashish Gupta implement enqueue and dequeue apis Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/zip_pmd.c | 114 drivers/compress/octeontx/zipvf.c | 49 +++ drivers/compress/octeontx/zi

[dpdk-dev] [PATCH v2 3/6] compress/octeontx: add xform and stream create support

2018-07-02 Thread Shally Verma
From: Ashish Gupta implement private xform and stream create ops Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/zip_pmd.c | 140 drivers/compress/octeontx/zipvf.h | 24 ++- 2 files c

[dpdk-dev] [PATCH v2 1/6] compress/octeontx: add octeontx zip PMD support

2018-07-02 Thread Shally Verma
From: Sunila Sahu Add octeontx zip pmd support in compressdev driver. Octeontx ZIP appears as PCI device. Add device probe and remove support. link zip pmd library in rtp.app.mk Update meson.build and Makefile to build octeontx zip pmd Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Si

[dpdk-dev] [PATCH v2 2/6] compress/octeontx: add device setup PMD ops

2018-07-02 Thread Shally Verma
From: Sunila Sahu implement device configure and PMD ops. setup stream resource memory pool setup and enable hardware queue Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/zip_pmd.c | 251 d

[dpdk-dev] [PATCH v2 0/6] compress: add Octeontx ZIP compression PMD

2018-07-02 Thread Shally Verma
This patch series add compression PMD for cavium octeontx ZIP module in DPDK compress drivers. Currently PMD only tested for deflate, stateless compression and decompression with direct memory buffers. Changes in v2: - enable OCTEONTX_ZIPVF bydefault, and remove static debug flag - fix meson build

Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx

2018-07-02 Thread Maxime Coquelin
On 07/02/2018 06:52 PM, Ferruh Yigit wrote: On 7/2/2018 5:41 PM, Ferruh Yigit wrote: On 7/2/2018 2:56 PM, Marvin Liu wrote: IN_ORDER Rx function depends on merge-able feature. Descriptors allocation and free will be done in bulk. Virtio dequeue logic: dequeue_burst_rx(burst mbufs)

Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 5:41 PM, Ferruh Yigit wrote: > On 7/2/2018 2:56 PM, Marvin Liu wrote: >> IN_ORDER Rx function depends on merge-able feature. Descriptors >> allocation and free will be done in bulk. >> >> Virtio dequeue logic: >> dequeue_burst_rx(burst mbufs) >> for (each mbuf b) { >>

[dpdk-dev] [PATCH v2] librte_lpm: Improve performance of the delete and add functions

2018-07-02 Thread Alex Kiselev
There are two major problems with the library: first, there is no need to rebuild the whole LPM tree when a rule is deleted and second, due to the current rules algorithm with complexity O(n) it's almost impossible to deal with large rule sets (50k or so rules). This patch addresses those two issue

Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 2:56 PM, Marvin Liu wrote: > IN_ORDER Rx function depends on merge-able feature. Descriptors > allocation and free will be done in bulk. > > Virtio dequeue logic: > dequeue_burst_rx(burst mbufs) > for (each mbuf b) { > if (b need merge) { > merge

Re: [dpdk-dev] [PATCH] maintainers: update for mempool

2018-07-02 Thread Andrew Rybchenko
On 07/02/2018 06:55 PM, Olivier Matz wrote: Given its very good contributions to this library, add Andrew as official maintainer for librte_mempool. Signed-off-by: Olivier Matz --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index dabb12d65..7781

[dpdk-dev] [PATCH] maintainers: update for mempool

2018-07-02 Thread Olivier Matz
Given its very good contributions to this library, add Andrew as official maintainer for librte_mempool. Signed-off-by: Olivier Matz --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index dabb12d65..7781e43c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 4:40 PM, Emma Kenny wrote: > Fix bug with undeclared variable name and > calling a variable that is not member of struct. > > CC main.o > l2fwd_fork/main.c: In function ‘main’: l2fwd_fork/main.c:1043:33: > error: ‘dev_info’ undeclared (first use in this function) > rte_eth_dev_info_

Re: [dpdk-dev] [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG

2018-07-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Monday, July 2, 2018 1:31 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Parthasarathy, JananeeX M > > Subject: [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG > > From: Jananee Parthasarathy

Re: [dpdk-dev] [PATCH v2 00/23] bnxt patchset

2018-07-02 Thread Ferruh Yigit
On 6/28/2018 9:15 PM, Ajit Khaparde wrote: > Patchset against dpdk-next-net. Please apply. > > v1->v2: > Takes care of the various comments made in the previous version. > I am dropping the style changes for now. I will send them later > after addressing the coding convention issues. > > > Ajit

Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 4:32 PM, Andrew Rybchenko wrote: > On 07/02/2018 06:08 PM, Ferruh Yigit wrote: >> On 6/29/2018 10:44 AM, Jerin Jacob wrote: >>> The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change >>> to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS) >>> >>> Fixes: 5de201df8927 ("ethdev: a

[dpdk-dev] [PATCH v1] examples/multi_process: fix build error

2018-07-02 Thread Emma Kenny
Fix bug with undeclared variable name and calling a variable that is not member of struct. CC main.o l2fwd_fork/main.c: In function ‘main’: l2fwd_fork/main.c:1043:33: error: ‘dev_info’ undeclared (first use in this function) rte_eth_dev_info_get(portid, &dev_info); l2fwd_fork/main.c:1043:33: n

Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation

2018-07-02 Thread Andrew Rybchenko
On 07/02/2018 06:08 PM, Ferruh Yigit wrote: On 6/29/2018 10:44 AM, Jerin Jacob wrote: The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS) Fixes: 5de201df8927 ("ethdev: add stats per queue") Cc: sta...@dpdk.org Signed-off-by: Jerin

[dpdk-dev] [PATCH v4 4/4] net/virtio: improve offload check performance

2018-07-02 Thread Maxime Coquelin
Instead of checking the multiple Virtio features bits for every packet, let's do the check once at configure time and store it in virtio_hw struct. Reviewed-by: Tiwei Bie Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 19 drivers/net/virtio/virtio_pci.h

[dpdk-dev] [PATCH v4 2/4] net/virtio: improve Tx offload features negotiation

2018-07-02 Thread Maxime Coquelin
This patch improves the Tx offload features selection depending on whether the application request for offloads. When the application doesn't request for Tx offload features, the corresponding features bits aren't negotiated. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v4 3/4] net/virtio: don't use simple Rx if TCP LRO or VLAN strip

2018-07-02 Thread Maxime Coquelin
Reviewed-by: Tiwei Bie Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 1d223d029..15d5b4f79 100644 --- a/drivers/net/virtio/

[dpdk-dev] [PATCH v4 1/4] net/virtio: remove simple Tx path

2018-07-02 Thread Maxime Coquelin
The simple Tx path does not comply with the Virtio specification. Now that VIRTIO_F_IN_ORDER feature is supported by the Virtio PMD, let's use this optimized path instead. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 11 +- drivers/net/virtio/virtio_pci.h

[dpdk-dev] [PATCH v4 0/4] net/virtio: Tx simple path removal and offload improvements

2018-07-02 Thread Maxime Coquelin
In this v3, the main change is the removal of the Tx simple path. Indeed, this path is not compliant with the Virtio specification, so could cause problems with some host implementations. Since Marvin has introduced the in-order path, we have a good replacement for simple Tx and so we think it is

Re: [dpdk-dev] [PATCH v5 8/9] net/virtio: add in-order Rx/Tx into selection

2018-07-02 Thread Maxime Coquelin
On 07/02/2018 02:41 PM, Maxime Coquelin wrote: On 07/02/2018 01:24 PM, Maxime Coquelin wrote: On 07/02/2018 03:56 PM, Marvin Liu wrote: After IN_ORDER Rx/Tx paths added, need to update Rx/Tx path selection logic. Rx path select logic: If IN_ORDER and merge-able are enabled will select I

Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation

2018-07-02 Thread Ferruh Yigit
On 6/29/2018 10:44 AM, Jerin Jacob wrote: > The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change > to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS) > > Fixes: 5de201df8927 ("ethdev: add stats per queue") > Cc: sta...@dpdk.org > > Signed-off-by: Jerin Jacob > --- > lib/librte_ethde

[dpdk-dev] [PATCH v1] lib/metrics: fix silent fail when uninitialised

2018-07-02 Thread Remy Horton
If rte_metrics_init() had not been called and hence the internal metric storage is not allocated, rte_metrics_get_values() and rte_metrics_get_name() would silently fail by returning zero (i.e. no metrics registered). This patch changes the result of this scenario to an explicit fail by returning -

Re: [dpdk-dev] Compilation of MLX5 driver

2018-07-02 Thread Asaf Sinai
Hi Shahaf, 1. Can you please explain what is the meaning of upstream-libs? 2. We use Ubuntu 12.04. so if we would like to stay with it, and use MLNX_OFED-4.0, which latest DPDK version should be used? Thanks, Asaf -Original Message- From: Shahaf Shuler [mailto:shah...@mellanox.com] Se

Re: [dpdk-dev] Compilation of MLX5 driver

2018-07-02 Thread Shahaf Shuler
Hi Asaf, Monday, July 2, 2018 3:46 PM, Asaf Sinai: > Subject: RE: [dpdk-dev] Compilation of MLX5 driver > > Additional details: > > Ubuntu: 12.04.3 > Linux: 3.2.0-53-virtual > GCC: 4.7.2 (Ubuntu/Linaro 4.7.2-11precise2) > > I tried to build DPDK 18.05 after installing the Mellanox OFED driver

[dpdk-dev] [PATCH v1] lib/metrics: disallow NULL as metric name

2018-07-02 Thread Remy Horton
This patch adds a sanity check so that names passed into rte_metrics_reg_names() and the wrapper rte_metrics_reg_name() cannot be NULL. Fixes: 349950ddb9c5 ("metrics: add information metrics library") Signed-off-by: Remy Horton --- lib/librte_metrics/rte_metrics.c | 3 +++ 1 file changed, 3 ins

[dpdk-dev] [PATCH v1] lib/bitratestats: add NULL sanity check

2018-07-02 Thread Remy Horton
If rte_stats_bitrate_reg() is passed NULL, the result is a crash. Fixed by adding a sanity check that makes sure the passed-in pointer is not NULL. Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Signed-off-by: Remy Horton --- lib/librte_bitratestats/rte_bitrate.c | 3 +++ 1 fil

Re: [dpdk-dev] [PATCH v4] net/e1000: add support for check descriptor status APIs

2018-07-02 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Monday, July 2, 2018 9:04 PM > To: Zhao1, Wei ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/e1000: add support for check > descriptor status APIs > > > > > --

Re: [dpdk-dev] [PATCH v7] net/fm10k: add support for check descriptor status APIs

2018-07-02 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Monday, July 2, 2018 9:08 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v7] net/fm10k: add support for check > descriptor status APIs > > > -Ori

Re: [dpdk-dev] [PATCH v7] net/fm10k: add support for check descriptor status APIs

2018-07-02 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, July 2, 2018 3:16 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yigit, Ferruh > ; > Zhao1, Wei > Subject: [PATCH v7] net/fm10k: add support for check descriptor status APIs <...> > diff --git a/doc/guides/rel_notes/release_18_08.rst >

Re: [dpdk-dev] [PATCH v4 0/3] crypto/qat: move files to drivers/common directory

2018-07-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jozwiak, TomaszX > Sent: Monday, July 2, 2018 10:39 AM > To: Trahe, Fiona ; De Lara Guarch, Pablo > ; dev@dpdk.org > Subject: [PATCH v4 0/3] crypto/qat: move files to drivers/common directory > > This patchset depends on QAT dynamic logging patchset and shou

Re: [dpdk-dev] [PATCH v4] net/e1000: add support for check descriptor status APIs

2018-07-02 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Monday, July 2, 2018 3:42 PM > To: Yigit, Ferruh > Cc: Zhang, Qi Z ; dev@dpdk.org > Subject: RE: [PATCH v4] net/e1000: add support for check descriptor status > APIs > > Hi, Ferruh > > The doc of igb_vf.ini has enable "Rx descrip

Re: [dpdk-dev] [PATCH v2 10/23] net/bnxt: move function check zero bytes to bnxt util.h

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 1:20 PM, Ferruh Yigit wrote: > On 6/28/2018 9:15 PM, Ajit Khaparde wrote: >> From: Scott Branden >> >> Move check_zero_bytes into new bnxt_util.h file. >> >> Signed-off-by: Scott Branden >> Reviewed-by: Ajit Khaparde >> --- >> drivers/net/bnxt/Makefile | 1 + >> drivers/net/bn

Re: [dpdk-dev] Compilation of MLX5 driver

2018-07-02 Thread Asaf Sinai
Additional details: Ubuntu: 12.04.3 Linux: 3.2.0-53-virtual GCC: 4.7.2 (Ubuntu/Linaro 4.7.2-11precise2) I tried to build DPDK 18.05 after installing the Mellanox OFED driver (MLNX_OFED_LINUX-4.0-2.0.0.1-ubuntu12.04-x86_64), but it failed with the mentioned error. So I removed the OFED driver an

Re: [dpdk-dev] [PATCH v5 8/9] net/virtio: add in-order Rx/Tx into selection

2018-07-02 Thread Maxime Coquelin
On 07/02/2018 01:24 PM, Maxime Coquelin wrote: On 07/02/2018 03:56 PM, Marvin Liu wrote: After IN_ORDER Rx/Tx paths added, need to update Rx/Tx path selection logic. Rx path select logic: If IN_ORDER and merge-able are enabled will select IN_ORDER Rx path. If IN_ORDER is enabled, Rx offloa

[dpdk-dev] [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG

2018-07-02 Thread Jananee Parthasarathy
From: Jananee Parthasarathy For librte_cryptodev dynamic logging, conditional compilation of debug logs would not be required anymore. Signed-off-by: Jananee Parthasarathy Reviewed-by: Reshma Pattan Reviewed-by: Pablo de Lara Guarch --- v2: unused macro removed from config/common_base and r

Re: [dpdk-dev] [PATCH v2 10/23] net/bnxt: move function check zero bytes to bnxt util.h

2018-07-02 Thread Ferruh Yigit
On 6/28/2018 9:15 PM, Ajit Khaparde wrote: > From: Scott Branden > > Move check_zero_bytes into new bnxt_util.h file. > > Signed-off-by: Scott Branden > Reviewed-by: Ajit Khaparde > --- > drivers/net/bnxt/Makefile | 1 + > drivers/net/bnxt/bnxt_ethdev.c | 1 + > drivers/net/bnxt/bnxt_f

Re: [dpdk-dev] Compilation of MLX5 driver

2018-07-02 Thread Asaf Sinai
Hi Shahaf, I face similar problem with DPDK 18.05, where missing file is "mlx5dv.h": == Build drivers/net/mlx5 CC mlx5.o In file included from /net/emcradware/CM_Users/asafsi/work/drivers/dpdk/dpdk-18.05/drivers/net/mlx5/mlx5.h:35:0, from /net/

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-02 Thread Rahul Lakkireddy
Hi Jack, On Monday, July 07/02/18, 2018 at 14:39:06 +0530, Jack Min wrote: > Hey, > > I've one question: > > Do those APIs support modify inner IP headers? > I'm afraid not. These API only modify outer IP addresses. I can think of two ways to achieve this: 1. Enhance these API to accept an

Re: [dpdk-dev] [PATCH v5 8/9] net/virtio: add in-order Rx/Tx into selection

2018-07-02 Thread Maxime Coquelin
On 07/02/2018 03:56 PM, Marvin Liu wrote: After IN_ORDER Rx/Tx paths added, need to update Rx/Tx path selection logic. Rx path select logic: If IN_ORDER and merge-able are enabled will select IN_ORDER Rx path. If IN_ORDER is enabled, Rx offload and merge-able are disabled will select simple R

[dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-02 Thread Moti Haimovsky
This patch adds support for building and running mlx5 PMD on 32bit systems such as i686. The main issue to tackle was handling the 32bit access to the UAR as quoted from the mlx5 PRM: QP and CQ DoorBells require 64-bit writes. For best performance, it is recommended to execute the QP/CQ DoorBell a

Re: [dpdk-dev] [PATCH v3 09/16] cryptodev: remove max number of sessions parameter

2018-07-02 Thread De Lara Guarch, Pablo
Hi > -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Friday, June 29, 2018 9:04 AM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; akhil.go...@nxp.com; > shally.ve...@caviumnetworks.com; ravi1.ku...@amd.com; > jerin.ja...@caviumnetworks.com; Zhang, Roy

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-02 Thread Mohammad Abdul Awal
On 27/06/2018 12:45, Nelio Laranjeiro wrote: This series adds an easy and maintainable configuration version support for those two actions for 18.08 by using global variables in testpmd to store the necessary information for the tunnel encapsulation. Those variables are used in conjunction of

Re: [dpdk-dev] [PATCH] net/mlx5: add support for 32bit systems

2018-07-02 Thread Mordechay Haimovsky
Inline > -Original Message- > From: Shahaf Shuler > Sent: Monday, July 2, 2018 10:05 AM > To: Mordechay Haimovsky ; Yongseok Koh > ; Adrien Mazarguil > Cc: dev@dpdk.org; Mordechay Haimovsky > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: add support for 32bit systems > > Hi Moty, > > Few

Re: [dpdk-dev] [PATCH 1/2] test/link_bonding: disable HW CRC strip by default.

2018-07-02 Thread Ferruh Yigit
On 7/2/2018 9:26 AM, dev-boun...@dpdk.org wrote: > Since the tested virtual device has no capacity of HW CRC offload, > disable it for the link bonding test by default. Otherwise, it will > cause test unexpected failure. > > Fixes: b219c8c("test: enable HW CRC strip by default") > > Signed-off-by

[dpdk-dev] [PATCH v4 1/3] crypto/qat: add weak functions

2018-07-02 Thread Tomasz Jozwiak
This patch adds following weak functions to facilitate conditional compilation of code for those services: - qat_sym_dev_create - qat_asym_dev_create - qat_comp_dev_create - qat_sym_dev_destroy - qat_asym_dev_destroy - qat_comp_dev_destroy and removes unused files with empty defin

[dpdk-dev] [PATCH v4 3/3] crypto/qat: move common qat files to common dir

2018-07-02 Thread Tomasz Jozwiak
- moved common qat files to common/qat dir. - changed common/qat/Makefile, common/qat/meson.build, drivers/Makefile, crypto/Makefile to add possibility of using new files locations - added README file into crypto/qat to clarify where the build is made from - updated MAINT

[dpdk-dev] [PATCH v4 0/3] crypto/qat: move files to drivers/common directory

2018-07-02 Thread Tomasz Jozwiak
This patchset depends on QAT dynamic logging patchset and should be targetig on 18.08. Patchset refactors the PMD in order that files are split into several places: common, crypto. New drivers/common/qat are added and files split between locations. Changes for v2: - removed drivers/common/qat/

[dpdk-dev] [PATCH v4 2/3] crypto/qat: re-organise build file content

2018-07-02 Thread Tomasz Jozwiak
This patch groups sources and related dependencies into common and sym sections in build files. Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- drivers/crypto/qat/Makefile | 25 ++--- drivers/crypto/qat/meson.build | 16 ++-- drivers/crypto/qat/qat

Re: [dpdk-dev] 17.05 --> 17.11, minimum hash table key size

2018-07-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Bly, Mike [mailto:m...@ciena.com] > Sent: Friday, June 29, 2018 9:01 PM > To: Dumitrescu, Cristian ; Yeddula, Avinash > ; dev@dpdk.org; dev ; > us...@dpdk.org > Subject: RE: 17.05 --> 17.11, minimum hash table key size > > Cristian, > > Thank you. I have don

Re: [dpdk-dev] [PATCH v2] mempool/octeontx: fix pool to aura mapping

2018-07-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Jul 2018 11:59:32 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com, > olivier.m...@6wind.com > Cc: dev@dpdk.org, sta...@dpdk.org, Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH v2] mempool/octeontx:

[dpdk-dev] [PATCH v5 5/5] eventdev: add Rx adapter tests for interrupt driven queues

2018-07-02 Thread Nikhil Rao
Add test for queue add and delete, the add/delete calls also switch queues between poll and interrupt mode. Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 261 +++--- 1 file changed, 242 insertions(+), 19 deletions(-) diff --git a/test/test/tes

  1   2   >