Re: [dpdk-dev] [dpdk-stable] 18.02.2 patches review and test

2018-06-12 Thread Marco Varlese
Luca, I ran some smoke tests on 18.02.2 / 17.11.3 and 16.11.7 using test_pmd and found no issues with these snapshots. Further, I ran some tests via OvS-DPDK and VPP (DPDK accelerated) using the aforementioned snapshots and saw no issues. Hope this helps. Cheers, Marco On Fri, 2018-06-08 at

Re: [dpdk-dev] [PATCH v3 2/2] net/ifcvf: enable the host notifier support

2018-06-12 Thread Wang, Xiao W
Hi, > -Original Message- > From: Bie, Tiwei > Sent: Friday, June 8, 2018 11:22 AM > To: maxime.coque...@redhat.com; dev@dpdk.org > Cc: Wang, Xiao W > Subject: [PATCH v3 2/2] net/ifcvf: enable the host notifier support > > The necessary vDPA ops have already been implemented > in ifcvf dr

Re: [dpdk-dev] [PATCH 3/7] net/virtio-user: add mgr_rxbuf and in_order vdev parameters

2018-06-12 Thread Tiwei Bie
On Fri, Jun 08, 2018 at 05:07:20PM +0800, Marvin Liu wrote: [...] > @@ -419,6 +420,12 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char > *path, int queues, > dev->device_features = VIRTIO_USER_SUPPORTED_FEATURES; > } > > + if (!mrg_rxbuf) > + dev->dev

Re: [dpdk-dev] [PATCH 1/7] vhost: announce VIRTIO_F_IN_ORDER support

2018-06-12 Thread Tiwei Bie
On Fri, Jun 08, 2018 at 05:07:18PM +0800, Marvin Liu wrote: [...] > @@ -853,6 +853,10 @@ rte_vhost_driver_register(const char *path, uint64_t > flags) > vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES; > vsocket->features = VIRTIO_NET_SUPPORTED_FEATURES; > > +

Re: [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

2018-06-12 Thread Tomasz Duszynski
On Tue, Jun 12, 2018 at 01:53:36PM +, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: Tomasz Duszynski [mailto:t...@semihalf.com] > > Sent: Tuesday, June 12, 2018 12:38 PM > > To: De Lara Guarch, Pablo > > Cc: Doherty, Declan ; akhil.go...@nxp.com; > > ravi1.ku...@amd

[dpdk-dev] [PATCH v3] net/i40e: workaround for Fortville performance

2018-06-12 Thread Haiyue Wang
The GL_SWR_PM_UP_THR value is not impacted from the link speed, its value is set according to the total number of ports for a better pipe-monitor configuration. All bellowing relevant device IDs are considered (NICs, LOMs, Mezz and Backplane): Device-ID ValueComments 0x1572 0x0303030

[dpdk-dev] [RFC v2] eventdev: event tx adapter APIs

2018-06-12 Thread Nikhil Rao
Add common APIs for the transmit stage of an event driven DPDK application. Also add a transmit queue field to the mbuf that is used by the adapter to transmit mbufs. Signed-off-by: Nikhil Rao --- Changelog = v1->v2: * Add the tx_adapter_enqueue function to struct rte_eventdev. It i

Re: [dpdk-dev] [PATCH v2 08/15] net/ifc: rename to ifcvf

2018-06-12 Thread Wang, Xiao W
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Saturday, June 9, 2018 5:21 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wang, Xiao W > > Subject: [PATCH v2 08/15] net/ifc: rename to ifcvf > > All files in the directory and the resulting driver have prefix of ifcvf, >

[dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device

2018-06-12 Thread Stephen Hemminger
The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). This version supports the latest NetVSP 6.1

[dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support

2018-06-12 Thread Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported at present, but the code

[dpdk-dev] [PATCH v11 4/4] net/netvsc: add documentation

2018-06-12 Thread Stephen Hemminger
From: Stephen Hemminger Matching documentation for new netvsc device. Includes a brief note about the restart issue. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst

[dpdk-dev] [PATCH v11 1/4] eal: add rte_uuid support

2018-06-12 Thread Stephen Hemminger
Since uuid functions may not be available everywhere, implement uuid functions in DPDK. These are based off the BSD licensed libuuid in util-link. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_

[dpdk-dev] [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus support

2018-06-12 Thread Stephen Hemminger
Latest version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 11:31 AM, Ophir Munk wrote: > > This commit implements TCP segmentation offload in TAP. > librte_gso library is used to segment large TCP payloads (e.g. packets > of 64K bytes size) into smaller MTU size buffers. > By supporting TSO offload capability in software a TAP de

Re: [dpdk-dev] [PATCH v4 1/2] net/tap: calculate checksums of multi segs packets

2018-06-12 Thread Wiles, Keith
A few formatting problems I have noticed. We can review the code logic in a meeting. > On Jun 12, 2018, at 11:31 AM, Ophir Munk wrote: > > Prior to this commit IP/UDP/TCP checksum offload calculations > were skipped in case of a multi segments packet. > This commit enables TAP checksum calculat

[dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-12 Thread Ophir Munk
This commit implements TCP segmentation offload in TAP. librte_gso library is used to segment large TCP payloads (e.g. packets of 64K bytes size) into smaller MTU size buffers. By supporting TSO offload capability in software a TAP device can be used as a failsafe sub device and be paired with anot

[dpdk-dev] [PATCH v4 1/2] net/tap: calculate checksums of multi segs packets

2018-06-12 Thread Ophir Munk
Prior to this commit IP/UDP/TCP checksum offload calculations were skipped in case of a multi segments packet. This commit enables TAP checksum calculations for multi segments packets. The only restriction is that the first segment must contain headers of layers 3 (IP) and 4 (UDP or TCP) Reviewed-

[dpdk-dev] [PATCH v4 0/2] TAP TSO

2018-06-12 Thread Ophir Munk
v1: - Initial release v2: - Fixing cksum errors - TCP segment size refers to TCP payload size (not including l2,l3,l4 headers) v3 (8 May 2018): - Bug fixing in case input mbuf is segmented - Following review comments by Raslan Darawsha This patch implements TAP TSO (TSP segmentation offload) i

Re: [dpdk-dev] [PATCH 2/5] crypto/qat: move to dynamic logging for non-dp trace

2018-06-12 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Trahe, Fiona > Sent: Friday, May 11, 2018 12:32 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH 2/5] crypto/qat: move to dynamic logging for non-dp trace > > From: Tomasz Jozwiak > > For all trace

Re: [dpdk-dev] [PATCH v10 0/5] Hyper-V/Azure netvsc PMD and bus support

2018-06-12 Thread Stephen Hemminger
On Tue, 12 Jun 2018 17:21:28 +0200 Thomas Monjalon wrote: > Hi Stephen, > > I would like to try merging these patches soon. > Below are some comments from my first check: > - please fix most of the checkpatches warnings > - please merge meson support in the related patch > - pl

Re: [dpdk-dev] [PATCH v10 0/5] Hyper-V/Azure netvsc PMD and bus support

2018-06-12 Thread Thomas Monjalon
Hi Stephen, I would like to try merging these patches soon. Below are some comments from my first check: - please fix most of the checkpatches warnings - please merge meson support in the related patch - please fix the doxygen of uuid (warnings from "make doc-api-html") 0

Re: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors

2018-06-12 Thread Xueming(Steven) Li
> -Original Message- > From: dev On Behalf Of Adrien Mazarguil > Sent: Saturday, May 26, 2018 12:35 AM > To: Shahaf Shuler > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors > > Prior to this patch, all port representors detected on a giv

Re: [dpdk-dev] [dpdk-dev, 5/7] net/mlx5: add port representor awareness

2018-06-12 Thread Adrien Mazarguil
On Tue, Jun 12, 2018 at 01:57:45PM +, Xueming(Steven) Li wrote: > > -Original Message- > > From: Adrien Mazarguil > > Sent: Tuesday, June 12, 2018 9:20 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [dpdk-dev,5/7] net/mlx5: add port representor awa

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Ophir Munk
Please note that other than cloning iproute2 we also need to install clang and llvm tools versions 3.7 and upper. Not sure there are clang and llvm packages of the required versions for the common distributions. I compiled the tools source code and installed them manually. > -Original Messa

Re: [dpdk-dev] [dpdk-dev, 5/7] net/mlx5: add port representor awareness

2018-06-12 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Tuesday, June 12, 2018 9:20 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [dpdk-dev,5/7] net/mlx5: add port representor awareness > > On Mon, Jun 11, 2018 at 01:05:55PM +, Xueming(Steven) Li wrote

Re: [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

2018-06-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Tuesday, June 12, 2018 12:38 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; akhil.go...@nxp.com; > ravi1.ku...@amd.com; jerin.ja...@caviumnetworks.com; Zhang, Roy Fan > ; Trahe, Fiona ; > t...@semiha

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 8:44 AM, Thomas Monjalon wrote: > > 12/06/2018 15:33, Wiles, Keith: >> >>> On Jun 12, 2018, at 7:58 AM, Thomas Monjalon wrote: >>> >>> 12/06/2018 14:36, Wiles, Keith: > On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: > > 11/06/2018 18:35, Wiles,

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Thomas Monjalon
12/06/2018 15:33, Wiles, Keith: > > > On Jun 12, 2018, at 7:58 AM, Thomas Monjalon wrote: > > > > 12/06/2018 14:36, Wiles, Keith: > >> > >>> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: > >>> > >>> 11/06/2018 18:35, Wiles, Keith: > > > On Jun 11, 2018, at 11:06 AM, Ophir Munk

Re: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors

2018-06-12 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Tuesday, June 12, 2018 9:21 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port > representors > > On Tue, Jun 12, 2018 at 08:02:17AM +, Xueming(

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 7:58 AM, Thomas Monjalon wrote: > > 12/06/2018 14:36, Wiles, Keith: >> >>> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: >>> >>> 11/06/2018 18:35, Wiles, Keith: > On Jun 11, 2018, at 11:06 AM, Ophir Munk wrote: > > This commit explains how to m

Re: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors

2018-06-12 Thread Adrien Mazarguil
On Tue, Jun 12, 2018 at 08:02:17AM +, Xueming(Steven) Li wrote: > Hi Adrien, > > > -Original Message- > > From: dev On Behalf Of Adrien Mazarguil > > Sent: Saturday, May 26, 2018 12:35 AM > > To: Shahaf Shuler > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 7/7] net/mlx5: add par

Re: [dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

2018-06-12 Thread Raslan Darawsheh
Hi Keith, Yes you are right about that, This is exactly the case and I'll need to provide a V2 for this with the kernel mapping. Kindest regards, Raslan Darawsheh -Original Message- From: Wiles, Keith [mailto:keith.wi...@intel.com] Sent: Tuesday, June 12, 2018 3:46 PM To: Raslan Daraws

Re: [dpdk-dev] [PATCH 6/7] net/mlx5: probe all port representors

2018-06-12 Thread Adrien Mazarguil
On Tue, Jun 12, 2018 at 06:42:38AM +, Xueming(Steven) Li wrote: > Hi Adrien, > > > -Original Message- > > From: dev On Behalf Of Adrien Mazarguil > > Sent: Saturday, May 26, 2018 12:35 AM > > To: Shahaf Shuler > > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 6/7] net/mlx5: probe a

Re: [dpdk-dev] [dpdk-dev, 5/7] net/mlx5: add port representor awareness

2018-06-12 Thread Adrien Mazarguil
On Mon, Jun 11, 2018 at 01:05:55PM +, Xueming(Steven) Li wrote: > Hi Adrien, > > Couldn't find your original email from inbox anyway, have to start a new > thread here. > > +static int > > +mlx5_cmp_ibv_name(const void *a, const void *b) > > +{ > > + const char *name_a = (*(const struct ib

Re: [dpdk-dev] [PATCH 3/7] net/mlx5: split PCI from generic probing code

2018-06-12 Thread Adrien Mazarguil
On Sun, Jun 10, 2018 at 12:59:06PM +, Xueming(Steven) Li wrote: > Hi Adrien, > > The logic looks much more clear now with the split. > > - len = snprintf(name, sizeof(name), PCI_PRI_FMT, > > -pci_dev->addr.domain, pci_dev->addr.bus, > > -pci_d

Re: [dpdk-dev] [PATCH 2/7] net/mlx5: remove redundant objects in probe code

2018-06-12 Thread Adrien Mazarguil
On Sun, Jun 10, 2018 at 11:00:59AM +, Xueming(Steven) Li wrote: > Ack. Trivial issue related to other patch found , not sure whether it good to > fix it here. > > - config.tso = ((device_attr_ex.tso_caps.max_tso > 0) && > > - (device_attr_ex.tso_caps.supporte

Re: [dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe code

2018-06-12 Thread Adrien Mazarguil
On Sun, Jun 10, 2018 at 11:00:57AM +, Xueming(Steven) Li wrote: > Ack except one minor question below. > > - mlx5_glue->dv_query_device(attr_ctx, &attrs_out); > > - if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) { > > - if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_ENHANCED

Re: [dpdk-dev] [PATCH 0/7] Make unit tests great again

2018-06-12 Thread Thomas Monjalon
+Cc Jananee 07/06/2018 23:01, Anatoly Burakov: > Previously, unit tests were running in groups. There were > technical reasons why that was the case (mostly having to do > with limiting memory), but it was hard to maintain and update > the autotest script. > > In 18.05, limiting of memory at DPDK

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Thomas Monjalon
12/06/2018 14:36, Wiles, Keith: > > > On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: > > > > 11/06/2018 18:35, Wiles, Keith: > >> > >>> On Jun 11, 2018, at 11:06 AM, Ophir Munk wrote: > >>> > >>> This commit explains how to manually compile the C source file > >>> tap_bpf_program.c into

Re: [dpdk-dev] [RFC] net/tap: add queues when attaching from secondary process

2018-06-12 Thread Wiles, Keith
> On Jun 7, 2018, at 6:24 PM, Raslan Darawsheh wrote: > > Hi, > > As you know that currently TAP pmd support attaching a secondary process to a > primary process. > But, it's still lacking the ability to do Rx/Tx burst since it's lacking the > necessary fds for RX/TX queues, > And the setti

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Wiles, Keith
> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon wrote: > > 11/06/2018 18:35, Wiles, Keith: >> >>> On Jun 11, 2018, at 11:06 AM, Ophir Munk wrote: >>> >>> This commit explains how to manually compile the C source file >>> tap_bpf_program.c into an ELF file using the clang compiler. >>> The cod

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-06-12 Thread Thomas Monjalon
11/06/2018 18:35, Wiles, Keith: > > > On Jun 11, 2018, at 11:06 AM, Ophir Munk wrote: > > > > This commit explains how to manually compile the C source file > > tap_bpf_program.c into an ELF file using the clang compiler. > > The code in tap_bpf_program.c requires definitions found in iproute2 >

Re: [dpdk-dev] [PATCH v5 2/2] doc: add a guide doc for cross compiling from x86

2018-06-12 Thread Thomas Monjalon
12/06/2018 14:06, Gavin Hu: > Hi Jerin, Bruce and Thomas, > > To fix the meson cross build issue(host clang + cross gcc), we have to > decouple clang options from gcc ones. > Currently the options for gcc and clang tightly coupled as they share a > single meson project and both added to the proj

Re: [dpdk-dev] [PATCH v5 2/2] doc: add a guide doc for cross compiling from x86

2018-06-12 Thread Gavin Hu
Hi Jerin, Bruce and Thomas, To fix the meson cross build issue(host clang + cross gcc), we have to decouple clang options from gcc ones. Currently the options for gcc and clang tightly coupled as they share a single meson project and both added to the project arguments, this is the root cause.

Re: [dpdk-dev] [PATCH v3 1/5] net/virtio: forbid simple Tx path by default

2018-06-12 Thread Maxime Coquelin
On 06/12/2018 08:35 AM, Tiwei Bie wrote: On Thu, Jun 07, 2018 at 11:26:12AM +0200, Maxime Coquelin wrote: Simple Tx path is not compliant with the Virtio specification, as it assumes the device will use the descriptors in order. VIRTIO_F_IN_ORDER feature has been introduced recently, but the

[dpdk-dev] [PATCH v1] net/mlx5: fix pmd crash in device probe

2018-06-12 Thread Xueming Li
This patch initializes counter descriptor struct before invoking Verbs api to avoid segment fault. Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") Cc: or...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions

2018-06-12 Thread Tomasz Duszynski
Hello Pablo, On Fri, Jun 08, 2018 at 11:02:31PM +0100, Pablo de Lara wrote: > Sessions are not created and stored in the crypto device > anymore, since now the session mempool is created > at the application level. > > Therefore the limitation of the maximum number of sessions > that can be create

[dpdk-dev] [PATCH] net/mlx5: fix pmd crash in device probe

2018-06-12 Thread Xueming Li
This patch initializes counter descriptor struct before invoking Verbs api to avoid segment fault. Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") Cc: or...@mellanox.com Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [dpdk-dev] [PATCH 0/2] maintainers: updates for Vhost and Virtio

2018-06-12 Thread Wang, Zhihong
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, June 12, 2018 4:01 PM > To: mtetsu...@gmail.com; Bie, Tiwei ; Wang, Zhihong > ; dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Maxime > Coquelin > Subject: [PATCH 0/2] mai

Re: [dpdk-dev] Why rte_pipeline.c only support forwarding to same table in different entries?

2018-06-12 Thread Dumitrescu, Cristian
Hi Hobby, Shyam, > > > > I am trying to have one ACL table 0 to forward different traffic to > > different table, but it failed. > > > > > > Is there any reason why adding this limitation? > > The current librte_pipeline implementation is limited to supporting a chain of tables as opposed to a

[dpdk-dev] [PATCH v1] crypto/qat: add support for 8 byte 3DES

2018-06-12 Thread Kovacevic, Marko
Added extra case to support 8 byte key size for 3DES CBC. Also changed capabilities to reflect the change. Signed-off-by: Marko, Kovacevic --- drivers/crypto/qat/qat_adf/qat_algs.h| 1 + drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 1 + drivers/crypto/qat/qat_crypto_capabilitie

[dpdk-dev] [PATCH v1] crypto/openssl: add support for 8 byte 3DES

2018-06-12 Thread Kovacevic, Marko
Added extra case to support 8 byte key size for 3DES CBC. Also changed capabilities to reflect the change. Signed-off-by: Marko, Kovacevic --- drivers/crypto/openssl/rte_openssl_pmd.c | 3 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 2 +- test/test/test_cryptodev_des_test_vectors.h |

[dpdk-dev] [PATCH 1/3] mem: provide thread-unsafe contig walk variant

2018-06-12 Thread Anatoly Burakov
Sometimes, user code needs to walk memseg list while being inside a memory-related callback. Rather than making everyone copy around the same iteration code and depending on DPDK internals, provide an official way to do memseg_contig_walk() inside callbacks. Signed-off-by: Anatoly Burakov --- li

[dpdk-dev] [PATCH 3/3] mem: provide thread-unsafe memseg list walk variant

2018-06-12 Thread Anatoly Burakov
Sometimes, user code needs to walk memseg list while being inside a memory-related callback. Rather than making everyone copy around the same iteration code and depending on DPDK internals, provide an official way to do memseg_list_walk() inside callbacks. Also, remove existing reimplementation fr

[dpdk-dev] [PATCH 2/3] mem: provide thread-unsafe memseg walk variant

2018-06-12 Thread Anatoly Burakov
Sometimes, user code needs to walk memseg list while being inside a memory-related callback. Rather than making everyone copy around the same iteration code and depending on DPDK internals, provide an official way to do memseg_walk() inside callbacks. Also, remove existing reimplementation from sP

Re: [dpdk-dev] [PATCH 0/2] maintainers: updates for Vhost and Virtio

2018-06-12 Thread Tiwei Bie
Hi Maxime, On Tue, Jun 12, 2018 at 10:01:25AM +0200, Maxime Coquelin wrote: > Hi, > > Since Jianfeng & Yuanhan resignation, I was the only active > maintainer for Vhost lib and PMD, and I had no backup for > managing the next-virtio tree. > > Contacted offline, Tetsuya has kindly accepted to rem

Re: [dpdk-dev] [PATCH] net/ixgbe: fix tunnel id format error for FDIR

2018-06-12 Thread Zhao1, Wei
Hi,wenzhuo > -Original Message- > From: Lu, Wenzhuo > Sent: Tuesday, June 12, 2018 4:39 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix tunnel id format error for FDIR > > Hi Wei, > > > -Original Message- > > From: Zhao1, Wei > > Sen

Re: [dpdk-dev] [PATCH] net/ixgbe: fix tunnel id format error for FDIR

2018-06-12 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, June 12, 2018 3:49 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix tunnel id format error for FDIR > > > Hi, Wenzhuo > > > -Original Message- > > From: Lu, Wenzhuo >

Re: [dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-12 Thread Remy Horton
Was out of office, so only saw the patchset this morning. Missing fixlines (watch out for subject line wrap): Fixes: e2aae1c1ced9 ("ethdev: remove name from extended statistic fetch") Fixes: 0a5beecf466a ("ethdev: revert xstats by ID") Otherwise looks good to me. A case of implementation simpli

Re: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors

2018-06-12 Thread Xueming(Steven) Li
Hi Adrien, > -Original Message- > From: dev On Behalf Of Adrien Mazarguil > Sent: Saturday, May 26, 2018 12:35 AM > To: Shahaf Shuler > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 7/7] net/mlx5: add parameter for port representors > > Prior to this patch, all port representors detecte

[dpdk-dev] [PATCH 0/2] maintainers: updates for Vhost and Virtio

2018-06-12 Thread Maxime Coquelin
Hi, Since Jianfeng & Yuanhan resignation, I was the only active maintainer for Vhost lib and PMD, and I had no backup for managing the next-virtio tree. Contacted offline, Tetsuya has kindly accepted to remove himself from the Vhost PMD maintainers as he didn't had time to be active recently. Tet

[dpdk-dev] [PATCH 1/2] maintainers: update Vhost PMD maintainership

2018-06-12 Thread Maxime Coquelin
Tetsuya has kindly agreed to handover the maintainership for the Vhost PMD. Thanks to him for his contributions. Acked-by: Tetsuya Mukawa Signed-off-by: Maxime Coquelin --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4667fa7fb..1c28f6d38 100644

[dpdk-dev] [PATCH 2/2] maintainers: add Vhost and Virtio co-maintainers

2018-06-12 Thread Maxime Coquelin
Add Tiwei and Zhihong as co-maintainers for the Vhost and Virtio components. They have done great contributions recently, and been very helpfull in helping to review Vhost and Virtio series. Also, add Tiwei as backup for the Next-virtio tree. Signed-off-by: Maxime Coquelin --- MAINTAINERS | 6 +

Re: [dpdk-dev] [PATCH] net/ixgbe: fix tunnel id format error for FDIR

2018-06-12 Thread Zhao1, Wei
Hi, Wenzhuo > -Original Message- > From: Lu, Wenzhuo > Sent: Tuesday, June 12, 2018 1:10 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/ixgbe: fix tunnel id format error for FDIR > > Hi Wei, > > > > -Original Message- > > From: Zhao1, Wei >

Re: [dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-12 Thread David Marchand
Hey guys, On Thu, Jun 7, 2018 at 10:15 AM, David Marchand wrote: > Testpmd should not expect the xstats names and values arrays to be > aligned: neither the arrays sizes, nor the order in which the values are. > > This hid some bugs where pmds would either return wrong values count or > invalid s